Backed out 2 changesets (bug 1481720) for unexpected ok on stream-safe-creation CLOSED TREE
authorBogdan Tara <btara@mozilla.com>
Tue, 25 Sep 2018 01:05:27 +0300
changeset 437968 0ecaa7270e9ca0d343a09c90ea66968379833fbf
parent 437967 66d3ccc4fef2649d5878679dcca4f6fe56e3888f
child 437969 b295ff1a58a9700eb9fbed49e191124c8becd4aa
push id108200
push userbtara@mozilla.com
push dateMon, 24 Sep 2018 22:07:59 +0000
treeherdermozilla-inbound@b295ff1a58a9 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1481720
milestone64.0a1
backs out93b35b140f068fac6336cfd9408934b3cd8eda3e
a2a4a8d57735d173482c452d09ae4eb57ecfe1fe
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out 2 changesets (bug 1481720) for unexpected ok on stream-safe-creation CLOSED TREE Backed out changeset 93b35b140f06 (bug 1481720) Backed out changeset a2a4a8d57735 (bug 1481720)
testing/web-platform/meta/MANIFEST.json
testing/web-platform/meta/fetch/api/basic/stream-safe-creation.any.js.ini
testing/web-platform/tests/fetch/api/basic/stream-safe-creation.any.js
--- a/testing/web-platform/meta/MANIFEST.json
+++ b/testing/web-platform/meta/MANIFEST.json
@@ -356552,34 +356552,16 @@
      "/fetch/api/basic/stream-response.any.html",
      {}
     ],
     [
      "/fetch/api/basic/stream-response.any.worker.html",
      {}
     ]
    ],
-   "fetch/api/basic/stream-safe-creation.any.js": [
-    [
-     "/fetch/api/basic/stream-safe-creation.any.html",
-     {}
-    ],
-    [
-     "/fetch/api/basic/stream-safe-creation.any.serviceworker.html",
-     {}
-    ],
-    [
-     "/fetch/api/basic/stream-safe-creation.any.sharedworker.html",
-     {}
-    ],
-    [
-     "/fetch/api/basic/stream-safe-creation.any.worker.html",
-     {}
-    ]
-   ],
    "fetch/api/basic/text-utf8.html": [
     [
      "/fetch/api/basic/text-utf8.html",
      {}
     ]
    ],
    "fetch/api/cors/cors-basic.any.js": [
     [
@@ -597399,20 +597381,16 @@
   "fetch/api/basic/scheme-others.sub.any.js": [
    "5f9848ff4c297d662a82aa9e847f548371c33d19",
    "testharness"
   ],
   "fetch/api/basic/stream-response.any.js": [
    "5b11018eb31648f5503eba1b1e71a616e219b375",
    "testharness"
   ],
-  "fetch/api/basic/stream-safe-creation.any.js": [
-   "180d338659021fed3d29e08ccea415cc5852fed2",
-   "testharness"
-  ],
   "fetch/api/basic/text-utf8.html": [
    "e5c567b9c4531113c12a3c56d0f5d9c1517589a2",
    "testharness"
   ],
   "fetch/api/cors/cors-basic.any.js": [
    "0b3d7aac584ecd6c84916acecd94fca3534aea9f",
    "testharness"
   ],
deleted file mode 100644
--- a/testing/web-platform/meta/fetch/api/basic/stream-safe-creation.any.js.ini
+++ /dev/null
@@ -1,11 +0,0 @@
-[stream-safe-creation.any.html]
-  expected: TIMEOUT
-
-[stream-safe-creation.any.sharedworker.html]
-  expected: TIMEOUT
-
-[stream-safe-creation.any.worker.html]
-  expected: TIMEOUT
-
-[stream-safe-creation.https.any.serviceworker.html]
-  expected: TIMEOUT
deleted file mode 100644
--- a/testing/web-platform/tests/fetch/api/basic/stream-safe-creation.any.js
+++ /dev/null
@@ -1,54 +0,0 @@
-// META: global=worker
-
-// These tests verify that stream creation is not affected by changes to
-// Object.prototype.
-
-const creationCases = {
-  fetch: async () => fetch(location.href),
-  request: () => new Request(location.href, {method: 'POST', body: 'hi'}),
-  response: () => new Response('bye'),
-  consumeEmptyResponse: () => new Response().text(),
-  consumeNonEmptyResponse: () => new Response(new Uint8Array([64])).text(),
-  consumeEmptyRequest: () => new Request(location.href).text(),
-  consumeNonEmptyRequest: () => new Request(location.href,
-                                            {method: 'POST', body: 'yes'}).arrayBuffer(),
-};
-
-for (creationCase of Object.keys(creationCases)) {
-  for (accessorName of ['start', 'type', 'size', 'highWaterMark']) {
-    promise_test(async t => {
-      Object.defineProperty(Object.prototype, accessorName, {
-        get() { throw Error(`Object.prototype.${accessorName} was accessed`); },
-        configurable: true
-      });
-      t.add_cleanup(() => {
-        delete Object.prototype[accessorName];
-        return Promise.resolve();
-      });
-      await creationCases[creationCase]();
-    }, `throwing Object.prototype.${accessorName} accessor should not affect ` +
-       `stream creation by '${creationCase}'`);
-
-    promise_test(async t => {
-      // -1 is a convenient value which is invalid, and should cause the
-      // constructor to throw, for all four fields.
-      Object.prototype[accessorName] = -1;
-      t.add_cleanup(() => {
-        delete Object.prototype[accessorName];
-        return Promise.resolve();
-      });
-      await creationCases[creationCase]();
-    }, `Object.prototype.${accessorName} accessor returning invalid value ` +
-       `should not affect stream creation by '${creationCase}'`);
-  }
-
-  promise_test(async t => {
-    Object.prototype.start = controller => controller.error(new Error('start'));
-      t.add_cleanup(() => {
-        delete Object.prototype.start;
-        return Promise.resolve();
-      });
-      await creationCases[creationCase]();
-    }, `Object.prototype.start function which errors the stream should not ` +
-       `affect stream creation by '${creationCase}'`);
-}