Bug 1461601 - lower the OOM bound for TArray::test_fallible on Windows; r=erahm
authorNathan Froyd <froydnj@mozilla.com>
Wed, 01 May 2019 17:04:40 +0000
changeset 472137 0e33c9c98d2c75fa62d4606feec22c5db6302779
parent 472136 961d9f01940bcf4b435f5ac62ec56b2b99862522
child 472138 8c89fd37b79d353a6eb8794f3de11151f6924b26
push id112980
push usernerli@mozilla.com
push dateWed, 01 May 2019 21:59:08 +0000
treeherdermozilla-inbound@89d5d74f031b [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerserahm
bugs1461601
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1461601 - lower the OOM bound for TArray::test_fallible on Windows; r=erahm Apparently 7 is not low enough. Maybe 6 will be. Differential Revision: https://phabricator.services.mozilla.com/D29503
xpcom/tests/gtest/TestTArray2.cpp
--- a/xpcom/tests/gtest/TestTArray2.cpp
+++ b/xpcom/tests/gtest/TestTArray2.cpp
@@ -962,21 +962,21 @@ TEST(TArray, test_fallible)
     // will cause, which depends on allocator behavior, so use 128MB - an
     // arbitrary size larger than the array header, so that chances are good
     // that allocations will always be 128MB.
     bool success = arrays[i].SetCapacity(128 * 1024 * 1024 - 1024, fallible);
     if (!success) {
       // We got our OOM.  Check that it didn't come too early.
       oomed = true;
 #  ifdef XP_WIN
-      // 32-bit Windows sometimes OOMs on the 7th, sometimes on the 8th.  To
-      // keep the test green, choose the lower of those: the important thing
-      // here is that some allocations fail and some succeed.  We're not too
+      // 32-bit Windows sometimes OOMs on the 6th, 7th, or 8th.  To keep the
+      // test green, choose the lower of those: the important thing here is
+      // that some allocations fail and some succeed.  We're not too
       // concerned about how many iterations it takes.
-      const size_t kOOMIterations = 7;
+      const size_t kOOMIterations = 6;
 #  else
       const size_t kOOMIterations = 8;
 #  endif
       ASSERT_GE(i, kOOMIterations)
           << "Got OOM on iteration " << i << ". Too early!";
     }
   }