Bug 1380609: Make Windows Universal CRT SDK version 10.0.10586.0 the minimum. r=glandium
authorBob Owen <bobowencode@gmail.com>
Wed, 13 Sep 2017 11:19:40 +0100
changeset 380415 0ddab9b0527d8c66b95880fce6f0c64a1bea6057
parent 380414 ff90282974cef1e1b73b826f165aa7be26246a6a
child 380416 aaf411b9d99f48e25811b131c59c557ce9077d60
push id94926
push userbobowencode@gmail.com
push dateWed, 13 Sep 2017 10:23:40 +0000
treeherdermozilla-inbound@ac48944bf3c6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersglandium
bugs1380609, 10586
milestone57.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1380609: Make Windows Universal CRT SDK version 10.0.10586.0 the minimum. r=glandium
build/moz.configure/windows.configure
--- a/build/moz.configure/windows.configure
+++ b/build/moz.configure/windows.configure
@@ -217,16 +217,21 @@ def valid_ucrt_sdk_dir(windows_sdk_dir, 
                 'CRT.' % windows_sdk_dir_env)
 
     valid_sdks = sorted(sdks, key=lambda x: sdks[x][0], reverse=True)
     if not valid_sdks:
         raise FatalCheckError('Cannot find the Universal CRT SDK. '
                               'Please install it.')
 
     version, sdk = sdks[valid_sdks[0]]
+    minimum_ucrt_version = Version('10.0.10586.0')
+    if version < minimum_ucrt_version:
+        raise FatalCheckError('Latest Universal CRT SDK version found %s'
+                              ' and minimum required is %s.'
+                              % (version,  minimum_ucrt_version))
 
     return namespace(
         path=sdk.path,
         include=sdk.include,
         lib=sdk.lib,
         version=version,
     )