Bug 1282795 - Make VerifyPreTracer final to silence some -Wdelete-non-virtual-dtor warnings caused by Maybe<VerifyPreTracer>. r=froydnj
authorJeff Walden <jwalden@mit.edu>
Tue, 28 Jun 2016 17:09:59 +0100
changeset 303014 0c2f1c16b763e13cd3f96e1fb27e962795d08723
parent 303013 94cb0c8e7febc61770904fca83ae56c86e5ee43b
child 303015 1aeffbc50a98ca81547cb46d9759d5fe0a11bdfe
push id78958
push userjwalden@mit.edu
push dateWed, 29 Jun 2016 09:35:06 +0000
treeherdermozilla-inbound@00aadbafd114 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfroydnj
bugs1282795
milestone50.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1282795 - Make VerifyPreTracer final to silence some -Wdelete-non-virtual-dtor warnings caused by Maybe<VerifyPreTracer>. r=froydnj
js/src/gc/Verifier.cpp
--- a/js/src/gc/Verifier.cpp
+++ b/js/src/gc/Verifier.cpp
@@ -74,17 +74,17 @@ typedef HashMap<void*, VerifyNode*, Defa
  *
  * The edgeptr and term fields are used to allocate out of the block of memory
  * for the graph. If we run out of memory (i.e., if edgeptr goes beyond term),
  * we just abandon the verification.
  *
  * The nodemap field is a hashtable that maps from the address of the GC thing
  * to the VerifyNode that represents it.
  */
-class js::VerifyPreTracer : public JS::CallbackTracer
+class js::VerifyPreTracer final : public JS::CallbackTracer
 {
     JS::AutoDisableGenerationalGC noggc;
 
     void onChild(const JS::GCCellPtr& thing) override;
 
   public:
     /* The gcNumber when the verification began. */
     uint64_t number;