Bug 1244638 - Part 3: Rename method from NotifyTimingUpdate to PostSpecifiedTimingUpdated. r=birtles
authorDaisuke Akatsuka <daisuke@mozilla-japan.org>
Fri, 11 Mar 2016 15:40:32 +0900
changeset 288498 0a78c483152b5fbe3514261880eaa25893013f6d
parent 288497 729fd971cfa66054610a55acef9d8101c33f0b67
child 288499 262b8fce95613808ca0d2d202f3bb60d4c2719d7
push id73429
push userbbirtles@mozilla.com
push dateSun, 13 Mar 2016 13:44:35 +0000
treeherdermozilla-inbound@7a82b7529ca5 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbirtles
bugs1244638
milestone48.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1244638 - Part 3: Rename method from NotifyTimingUpdate to PostSpecifiedTimingUpdated. r=birtles MozReview-Commit-ID: H0fBTwqiZiS
dom/animation/AnimationEffectTiming.cpp
dom/animation/AnimationEffectTiming.h
--- a/dom/animation/AnimationEffectTiming.cpp
+++ b/dom/animation/AnimationEffectTiming.cpp
@@ -14,34 +14,34 @@ namespace mozilla {
 namespace dom {
 
 JSObject*
 AnimationEffectTiming::WrapObject(JSContext* aCx, JS::Handle<JSObject*> aGivenProto)
 {
   return AnimationEffectTimingBinding::Wrap(aCx, this, aGivenProto);
 }
 
-void
-AnimationEffectTiming::NotifyTimingUpdate()
+static inline void
+PostSpecifiedTimingUpdated(KeyframeEffect* aEffect)
 {
-  if (mEffect) {
-    mEffect->NotifySpecifiedTimingUpdated();
+  if (aEffect) {
+    aEffect->NotifySpecifiedTimingUpdated();
   }
 }
 
 void
 AnimationEffectTiming::SetEndDelay(double aEndDelay)
 {
   TimeDuration endDelay = TimeDuration::FromMilliseconds(aEndDelay);
   if (mTiming.mEndDelay == endDelay) {
     return;
   }
   mTiming.mEndDelay = endDelay;
 
-  NotifyTimingUpdate();
+  PostSpecifiedTimingUpdated(mEffect);
 }
 
 void
 AnimationEffectTiming::SetIterationStart(double aIterationStart,
                                          ErrorResult& aRv)
 {
   if (mTiming.mIterationStart == aIterationStart) {
     return;
@@ -49,17 +49,17 @@ AnimationEffectTiming::SetIterationStart
 
   TimingParams::ValidateIterationStart(aIterationStart, aRv);
   if (aRv.Failed()) {
     return;
   }
 
   mTiming.mIterationStart = aIterationStart;
 
-  NotifyTimingUpdate();
+  PostSpecifiedTimingUpdated(mEffect);
 }
 
 void
 AnimationEffectTiming::SetDuration(const UnrestrictedDoubleOrString& aDuration,
                                    ErrorResult& aRv)
 {
   Maybe<StickyTimeDuration> newDuration =
     TimingParams::ParseDuration(aDuration, aRv);
@@ -68,13 +68,13 @@ AnimationEffectTiming::SetDuration(const
   }
 
   if (mTiming.mDuration == newDuration) {
     return;
   }
 
   mTiming.mDuration = newDuration;
 
-  NotifyTimingUpdate();
+  PostSpecifiedTimingUpdated(mEffect);
 }
 
 } // namespace dom
 } // namespace mozilla
--- a/dom/animation/AnimationEffectTiming.h
+++ b/dom/animation/AnimationEffectTiming.h
@@ -25,16 +25,15 @@ public:
   void Unlink() override { mEffect = nullptr; }
 
   void SetEndDelay(double aEndDelay);
   void SetIterationStart(double aIterationStart, ErrorResult& aRv);
   void SetDuration(const UnrestrictedDoubleOrString& aDuration,
                    ErrorResult& aRv);
 
 private:
-  void NotifyTimingUpdate();
   KeyframeEffect* MOZ_NON_OWNING_REF mEffect;
 };
 
 } // namespace dom
 } // namespace mozilla
 
 #endif // mozilla_dom_AnimationEffectTiming_h