Bug 760345 - Make color and text-decoration-line not early properties. r=heycam
authorEmilio Cobos Álvarez <emilio@crisal.io>
Thu, 04 Apr 2019 23:04:50 +0000
changeset 468295 08f256aa338a50d926b779a21a8a1dfe73bc2db6
parent 468294 0550767ec778a95a8b64b2071caca2c8bb63683b
child 468296 0c2d3df59443feb80498c1f555e0c3321c2c649b
push id112700
push usercbrindusan@mozilla.com
push dateSun, 07 Apr 2019 09:40:07 +0000
treeherdermozilla-inbound@58b4488b771a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersheycam
bugs760345
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 760345 - Make color and text-decoration-line not early properties. r=heycam The text-decoration-line is a drive-by thing, but I can put it in a separate patch if you want. It was needed for Servo (to compute -servo-text-decorations-in-effect), but I moved Servo away from that model a while ago. Differential Revision: https://phabricator.services.mozilla.com/D26254
servo/components/style/properties/properties.mako.rs
--- a/servo/components/style/properties/properties.mako.rs
+++ b/servo/components/style/properties/properties.mako.rs
@@ -1265,27 +1265,16 @@ impl LonghandId {
             // Needed to compute the first available font, in order to
             // compute font-relative units correctly.
             LonghandId::FontSize |
             LonghandId::FontWeight |
             LonghandId::FontStretch |
             LonghandId::FontStyle |
             LonghandId::FontFamily |
 
-            // Needed to resolve currentcolor at computed value time properly.
-            //
-            // FIXME(emilio): All the properties should be moved to currentcolor
-            // as a computed-value (and thus resolving it at used-value time).
-            //
-            // This would allow this property to go away from this list.
-            LonghandId::Color |
-
-            // FIXME(emilio): There's no reason for this afaict, nuke it.
-            LonghandId::TextDecorationLine |
-
             // Needed to properly compute the writing mode, to resolve logical
             // properties, and similar stuff.
             LonghandId::WritingMode |
             LonghandId::Direction
         )
     }
 }