No bug. Start sweepGroupIndex at 1. r=me
authorSteve Fink <sfink@mozilla.com>
Tue, 11 Sep 2018 17:06:30 -0700
changeset 450724 08f23ff4708ad0394a8abd53aaeb56c17fd227f9
parent 450723 15cd66da94ea84978915bf4751aee441bc047363
child 450725 c14789dbc570ac10884e4e097102a94259fd985c
push id110530
push usersfink@mozilla.com
push dateFri, 14 Dec 2018 20:23:43 +0000
treeherdermozilla-inbound@5568f16f0191 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersme
milestone66.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
No bug. Start sweepGroupIndex at 1. r=me It's confusing when looking at Zone.lastSweepGroupIndex() and getting 0 for all the zones being inspected. It made me think it wasn't getting set.
js/src/gc/GC.cpp
--- a/js/src/gc/GC.cpp
+++ b/js/src/gc/GC.cpp
@@ -4918,17 +4918,17 @@ void GCRuntime::groupZonesForSweeping(JS
 #endif
 
   for (GCZonesIter zone(rt); !zone.done(); zone.next()) {
     MOZ_ASSERT(zone->isGCMarking());
     finder.addNode(zone);
   }
   sweepGroups = finder.getResultsList();
   currentSweepGroup = sweepGroups;
-  sweepGroupIndex = 0;
+  sweepGroupIndex = 1;
 
   for (GCZonesIter zone(rt); !zone.done(); zone.next()) {
     zone->gcSweepGroupEdges().clear();
   }
 
 #ifdef DEBUG
   for (Zone* head = currentSweepGroup; head; head = head->nextGroup()) {
     for (Zone* zone = head; zone; zone = zone->nextNodeInGroup()) {