Bug 1596599 - Minor update for 'mach test-info report --show-manifests'; r=jmaher
authorGeoff Brown <gbrown@mozilla.com>
Fri, 15 Nov 2019 10:38:06 +0000
changeset 502174 0860d7cbadd429f0bee361d5e389dd61ef5e54ad
parent 502173 6c468a5b599635fc091ea77b888283ada23abfae
child 502175 2a60597c297223332fe440c4c6337a5b1a6edcc7
push id114172
push userdluca@mozilla.com
push dateTue, 19 Nov 2019 11:31:10 +0000
treeherdermozilla-inbound@b5c5ba07d3db [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjmaher
bugs1596599
milestone72.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1596599 - Minor update for 'mach test-info report --show-manifests'; r=jmaher Puppeteer tests have t['manifest'] = None; allowing for this avoids downstream pain when reporting manifests. (Also removed a stray debugging print statement.) Differential Revision: https://phabricator.services.mozilla.com/D53102
testing/mach_commands.py
--- a/testing/mach_commands.py
+++ b/testing/mach_commands.py
@@ -1260,17 +1260,18 @@ class TestInfoCommand(MachCommandBase):
 
         print("Finding tests...")
         resolver = self._spawn(TestResolver)
         tests = list(resolver.resolve_tests(paths=paths, flavor=flavor,
                                             subsuite=subsuite))
 
         manifest_paths = set()
         for t in tests:
-            manifest_paths.add(t['manifest'])
+            if 'manifest' in t and t['manifest'] is not None:
+                manifest_paths.add(t['manifest'])
         manifest_count = len(manifest_paths)
         print("Resolver found {} tests, {} manifests".format(len(tests), manifest_count))
 
         if show_manifests:
             by_component['manifests'] = {}
             manifest_paths = list(manifest_paths)
             manifest_paths.sort()
             relpaths = []
@@ -1280,17 +1281,16 @@ class TestInfoCommand(MachCommandBase):
                     continue
                 relpaths.append(relpath)
             reader = self.mozbuild_reader(config_mode='empty')
             files_info = reader.files_info(relpaths)
             for manifest_path in manifest_paths:
                 relpath = mozpath.relpath(manifest_path, self.topsrcdir)
                 if mozpath.commonprefix((manifest_path, self.topsrcdir)) != self.topsrcdir:
                     continue
-                print("  {}".format(relpath))
                 manifest_info = None
                 if relpath in files_info:
                     bug_component = files_info[relpath].get('BUG_COMPONENT')
                     key = "{}::{}".format(bug_component.product, bug_component.component)
                     if (not components) or (key in components):
                         manifest_info = {
                             'manifest': relpath,
                             'tests': 0,