bug 1442776 treat PinnedStringId as rooted GC pointer in hazard analysis r=sfink
authorKarl Tomlinson <karlt+@karlt.net>
Tue, 05 Jun 2018 16:51:10 +1200
changeset 421595 077407e42b77e532de6e307307356673ecbda73e
parent 421549 c6bccca0305d44381c7b9f8979c851be0d005e4d
child 421596 4d39fdf74ae76b02509a190b7081eecf49e25efe
push id104075
push usernbeleuzu@mozilla.com
push dateWed, 06 Jun 2018 17:05:41 +0000
treeherdermozilla-inbound@97c439edf8ac [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssfink
bugs1442776
milestone62.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
bug 1442776 treat PinnedStringId as rooted GC pointer in hazard analysis r=sfink MozReview-Commit-ID: GFPSwczIZxV
dom/bindings/BindingUtils.h
--- a/dom/bindings/BindingUtils.h
+++ b/dom/bindings/BindingUtils.h
@@ -3105,17 +3105,17 @@ class PinnedStringId
   operator const jsid& () const {
     return id;
   }
 
   operator JS::Handle<jsid> () const {
     /* This is safe because we have pinned the string. */
     return JS::Handle<jsid>::fromMarkedLocation(&id);
   }
-};
+} JS_HAZ_ROOTED;
 
 namespace binding_detail {
 /**
  * WebIDL getters have a "generic" JSNative that is responsible for the
  * following things:
  *
  * 1) Determining the "this" pointer for the C++ call.
  * 2) Extracting the "specialized" getter from the jitinfo on the JSFunction.