Bug 1382581 - Adapt canvasdebugger code to the EventEmitter change in devtools/client/framework; r=sole.
authorNicolas Chevobbe <nchevobbe@mozilla.com>
Wed, 14 Mar 2018 18:14:22 +0100
changeset 408650 072a665b018115ceabfb56dc54d9b277be888f7d
parent 408649 2d11a39440388b95eb59a28795b37a22c44e49ed
child 408651 4815e9bd7de0389439509b80ffa662c76c53255e
push id100996
push userbtara@mozilla.com
push dateSat, 17 Mar 2018 10:37:43 +0000
treeherdermozilla-inbound@97160a734959 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssole
bugs1382581
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1382581 - Adapt canvasdebugger code to the EventEmitter change in devtools/client/framework; r=sole. MozReview-Commit-ID: 3DDGWvQ3MLX
devtools/client/canvasdebugger/canvasdebugger.js
--- a/devtools/client/canvasdebugger/canvasdebugger.js
+++ b/devtools/client/canvasdebugger/canvasdebugger.js
@@ -129,37 +129,31 @@ var EventsHandler = {
    */
   initialize: function () {
     // Make sure the backend is prepared to handle <canvas> contexts.
     // Since actors are created lazily on the first request to them, we need to send an
     // early request to ensure the CallWatcherActor is running and watching for new window
     // globals.
     gFront.setup({ reload: false });
 
-    this._onTabNavigated = this._onTabNavigated.bind(this);
-    gTarget.on("will-navigate", this._onTabNavigated);
-    gTarget.on("navigate", this._onTabNavigated);
+    this._onTabWillNavigate = this._onTabWillNavigate.bind(this);
+    gTarget.on("will-navigate", this._onTabWillNavigate);
   },
 
   /**
    * Remove events emitted by the current tab target.
    */
   destroy: function () {
-    gTarget.off("will-navigate", this._onTabNavigated);
-    gTarget.off("navigate", this._onTabNavigated);
+    gTarget.off("will-navigate", this._onTabWillNavigate);
   },
 
   /**
    * Called for each location change in the debugged tab.
    */
-  _onTabNavigated: function (event) {
-    if (event != "will-navigate") {
-      return;
-    }
-
+  _onTabWillNavigate: function () {
     // Reset UI.
     SnapshotsListView.empty();
     CallsListView.empty();
 
     $("#record-snapshot").removeAttribute("checked");
     $("#record-snapshot").removeAttribute("disabled");
     $("#record-snapshot").hidden = false;