Bug 1538459 [wpt PR 15995] - Fix a bunch of bugs 🤦‍♂️, a=testonly
authorMarcos Cáceres <mcaceres@mozilla.com>
Thu, 18 Apr 2019 10:13:36 +0000
changeset 470940 0450e0f7da7bfb8260ba2f7910851ae73626fbfb
parent 470939 cc03ae79f9b74b2542d5227c2455c86bb996dbc4
child 470941 2dc3d03deb7619061f0f27671941974ea9fd8865
push id112883
push userjames@hoppipolla.co.uk
push dateWed, 24 Apr 2019 10:45:08 +0000
treeherdermozilla-inbound@a9e8bb1d8a16 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1538459, 15995
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1538459 [wpt PR 15995] - Fix a bunch of bugs 🤦‍♂️, a=testonly Automatic update from web-platform-tests Fix a bunch of bugs 🤦‍♂️ -- wpt-commits: f37fcaaefa01b03ca77fb962bb9b491d0e437dde wpt-pr: 15995
testing/web-platform/tests/payment-method-basic-card/steps_for_selecting_the_payment_handler.html
--- a/testing/web-platform/tests/payment-method-basic-card/steps_for_selecting_the_payment_handler.html
+++ b/testing/web-platform/tests/payment-method-basic-card/steps_for_selecting_the_payment_handler.html
@@ -5,16 +5,17 @@
 </title>
 <link
   rel="help"
   href="https://w3c.github.io/payment-method-basic-card/#selecting-the-payment-handler"
 />
 <script src="/resources/testharness.js"></script>
 <script src="/resources/testharnessreport.js"></script>
 <script>
+  setup({ explicit_done: true, explicit_timeout: true });
   const defaultDetails = {
     total: {
       label: "Total",
       amount: {
         currency: "USD",
         value: "1.00",
       },
     },
@@ -60,41 +61,50 @@
     promise_test(async t => {
       const methodData = [
         {
           supportedMethods: "basic-card",
           data: {
             supportedNetworks: ["visa"],
           },
         },
-        // Same as data: { supportedNetworks: ["visa"] }
+        // Same as data: { supportedNetworks: [] }
         {
           supportedMethods: "basic-card",
         },
       ];
       const showPromise = new PaymentRequest(methodData, defaultDetails).show();
       await promise_rejects(t, "AbortError", showPromise);
     }, testableAssertion.trim());
   }
 </script>
 <h1>Manual tests</h1>
-<p>
-  When each button is clicked, the
-</p>
 <ol>
   <li>
-    <button onclick="mixedPMILastOneWins(this.textContent.trim())">
+    <p>
+      To pass, this test must show the payment sheet and allow paying with any
+      card.
+    </p>
+    <button onclick="emptyDataIsAllNetworks(this.textContent.trim())">
       If no data is passed, it's the same as passing an empty BasicCardRequest
       (i.e., allow all networks).
     </button>
   </li>
   <li>
+    <p>
+      To pass, this test must show the payment sheet and restrict to "visa"
+      credit cards.
+    </p>
     <button onclick="mixedPMILastOneWins(this.textContent.trim())">
-      It ignores unknown PMIs and last "basic-card" wins.
+      It ignores unknown PMIs and last "basic-card" wins - in this case, "visa".
     </button>
   </li>
   <li>
+    <p>
+      To pass, this test must show the payment sheet and allow paying with any
+      card.
+    </p>
     <button onclick="lastOneWinsEvenIfDataIsMissing(this.textContent.trim())">
       "Last one wins" even if data is missing.
     </button>
   </li>
   <li><button onclick="done()">Done!</button></li>
 </ol>