Bug 980698 - Rename shadowing parameters. r=Waldo
authorXidorn Quan <quanxunzhen@gmail.com>
Wed, 12 Mar 2014 08:42:39 -0400
changeset 173181 03acaf79c507f7cd39022ba9dab4cb710cad7ce4
parent 173180 7997cb5af49cbcf1a49d3d56d0af2b8dc1db1eea
child 173182 b37c15e6833b0de57fda696c2b918a37dc89f3e5
push id40937
push userryanvm@gmail.com
push dateWed, 12 Mar 2014 12:45:37 +0000
treeherdermozilla-inbound@b37c15e6833b [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersWaldo
bugs980698
milestone30.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 980698 - Rename shadowing parameters. r=Waldo
mfbt/CheckedInt.h
--- a/mfbt/CheckedInt.h
+++ b/mfbt/CheckedInt.h
@@ -592,17 +592,17 @@ struct NegateImpl<T, true>
 template<typename T>
 class CheckedInt
 {
   protected:
     T mValue;
     bool mIsValid;
 
     template<typename U>
-    CheckedInt(U value, bool isValid) : mValue(value), mIsValid(isValid)
+    CheckedInt(U aValue, bool aIsValid) : mValue(aValue), mIsValid(aIsValid)
     {
       static_assert(detail::IsSupported<T>::value &&
                     detail::IsSupported<U>::value,
                     "This type is not supported by CheckedInt");
     }
 
     friend struct detail::NegateImpl<T>;
 
@@ -614,19 +614,19 @@ class CheckedInt
      *
      * This constructor is not explicit. Instead, the type of its argument is a
      * separate template parameter, ensuring that no conversion is performed
      * before this constructor is actually called. As explained in the above
      * documentation for class CheckedInt, this constructor checks that its
      * argument is valid.
      */
     template<typename U>
-    CheckedInt(U value)
-      : mValue(T(value)),
-        mIsValid(detail::IsInRange<T>(value))
+    CheckedInt(U aValue)
+      : mValue(T(aValue)),
+        mIsValid(detail::IsInRange<T>(aValue))
     {
       static_assert(detail::IsSupported<T>::value &&
                     detail::IsSupported<U>::value,
                     "This type is not supported by CheckedInt");
     }
 
     template<typename U>
     friend class CheckedInt;