c8e9b6a81194dff2d37b4f67d23a419fd4587e49: Bug 1519577 Convert toolbarbutton to a custom element r=surkov default tip
Andrew Swan <aswan@mozilla.com> - Mon, 20 May 2019 10:01:02 -0700 - rev 474978
Push 113185 by aswan@mozilla.com at Wed, 22 May 2019 23:25:35 +0000
Bug 1519577 Convert toolbarbutton to a custom element r=surkov Differential Revision: https://phabricator.services.mozilla.com/D31941
595c3065e9ac64ed1d4ada38c3a83c6ba2a0ff91: Bug 1519577 Mark badged page action toolbarbuttons before inserting r=Gijs
Andrew Swan <aswan@mozilla.com> - Tue, 14 May 2019 20:39:38 -0700 - rev 474977
Push 113185 by aswan@mozilla.com at Wed, 22 May 2019 23:25:35 +0000
Bug 1519577 Mark badged page action toolbarbuttons before inserting r=Gijs The "add search engine" page action wants to use badged toolbarbuttons, but it does this by adding the "badged-button" class (which changes the XBL binding) after the button has already been created and added to the DOM. To avoid having to switch between non-badged and badged buttons when toolbarbutton is converted to custom elements, add a property to page actions so that the badged status can be determined when the element is created. Differential Revision: https://phabricator.services.mozilla.com/D31940
82d77e63f4d3971ee341c6a49daacc6524e9d80c: Bug 1519577 Remove support for unused toolbarbutton anchor attribute r=NeilDeakin
Andrew Swan <aswan@mozilla.com> - Tue, 14 May 2019 13:08:53 -0700 - rev 474976
Push 113185 by aswan@mozilla.com at Wed, 22 May 2019 23:25:35 +0000
Bug 1519577 Remove support for unused toolbarbutton anchor attribute r=NeilDeakin This code contains an undesirable dependency between the layout code and the implementation of toolbarbutton. Since it isn't actually used anywhere by the firefox UI, remove it here. Differential Revision: https://phabricator.services.mozilla.com/D31939
8f0abb76f7bb982c13424019f7bda30089acf1e8: Bug 1519577 Update devtools test to use a test-only xbl binding r=jdescottes
Andrew Swan <aswan@mozilla.com> - Thu, 02 May 2019 20:39:20 -0700 - rev 474975
Push 113185 by aswan@mozilla.com at Wed, 22 May 2019 23:25:35 +0000
Bug 1519577 Update devtools test to use a test-only xbl binding r=jdescottes Differential Revision: https://phabricator.services.mozilla.com/D31938
8de5e0880f85d8986b2995cd8685245922e41b5f: Bug 1519577 Remove test_bug562554.xul dependence on button.xml r=bzbarsky
Andrew Swan <aswan@mozilla.com> - Tue, 14 May 2019 16:33:38 -0700 - rev 474974
Push 113185 by aswan@mozilla.com at Wed, 22 May 2019 23:25:35 +0000
Bug 1519577 Remove test_bug562554.xul dependence on button.xml r=bzbarsky This is essentially reverting the test changes from bug 653881. The platform changes that motivated bug 653881 were reverted in bug 888787 but the test changes were left in place at that time. Differential Revision: https://phabricator.services.mozilla.com/D31937
57bf01d965797fac39ca0f267050633039aa4c57: Bug 1519577 Update test_bug467123 to not rely on button.xml r=smaug
Andrew Swan <aswan@mozilla.com> - Thu, 02 May 2019 13:56:15 -0700 - rev 474973
Push 113185 by aswan@mozilla.com at Wed, 22 May 2019 23:25:35 +0000
Bug 1519577 Update test_bug467123 to not rely on button.xml r=smaug Differential Revision: https://phabricator.services.mozilla.com/D31936
f287bb6c18942c75aca41d54987006951270628d: Backed out 18 changesets (bug 1525720) for mass failures on Windows platform e.g ProcessPriorityManager.cpp on a CLOSED TREE.
Gurzau Raul <rgurzau@mozilla.com> - Thu, 23 May 2019 01:57:16 +0300 - rev 474972
Push 113184 by rgurzau@mozilla.com at Wed, 22 May 2019 22:58:26 +0000
Backed out 18 changesets (bug 1525720) for mass failures on Windows platform e.g ProcessPriorityManager.cpp on a CLOSED TREE. Backed out changeset 1f2e86c2d691 (bug 1525720) Backed out changeset 9b79caa460a0 (bug 1525720) Backed out changeset e65cb2d4c5a5 (bug 1525720) Backed out changeset 99f971a02d87 (bug 1525720) Backed out changeset d25963c72ff7 (bug 1525720) Backed out changeset 810b73719871 (bug 1525720) Backed out changeset ee10a8254481 (bug 1525720) Backed out changeset 1bcf9f586c55 (bug 1525720) Backed out changeset d3b2ac8d5ca4 (bug 1525720) Backed out changeset 697774dd8984 (bug 1525720) Backed out changeset eadeacbe4483 (bug 1525720) Backed out changeset 32eeee79d628 (bug 1525720) Backed out changeset 07678a2fa9e7 (bug 1525720) Backed out changeset 757b4f595cc4 (bug 1525720) Backed out changeset b255e0a84e12 (bug 1525720) Backed out changeset 9a255864f75d (bug 1525720) Backed out changeset 5f1c1b609ec1 (bug 1525720) Backed out changeset 00d83f1d02e0 (bug 1525720)
1f2e86c2d6912946eac17beabdd27e4c42accf27: Bug 1525720 - Try to fix build bustage. r=me on a CLOSED TREE
Ryan Hunt <rhunt@eqrion.net> - Wed, 22 May 2019 16:03:26 -0500 - rev 474971
Push 113183 by rhunt@eqrion.net at Wed, 22 May 2019 21:05:09 +0000
Bug 1525720 - Try to fix build bustage. r=me on a CLOSED TREE
9b79caa460a01a7bdf9c27ede487de0ec642ae0b: Bug 1525720, part 17 - Ignore nsIRemoteTab methods after we have destroyed the browser. r=nika
Ryan Hunt <rhunt@eqrion.net> - Wed, 15 May 2019 12:34:14 -0500 - rev 474970
Push 113182 by rhunt@eqrion.net at Wed, 22 May 2019 20:02:12 +0000
Bug 1525720, part 17 - Ignore nsIRemoteTab methods after we have destroyed the browser. r=nika It's possible for front-end references to nsIRemoteTab to outlive the IPDL actor. When this happens, we should ignore methods and property accesses. The one special case is that some code expects to be able to access the TabId after the browser has been destroyed. For this we can just cache the ID. Differential Revision: https://phabricator.services.mozilla.com/D31449
e65cb2d4c5a55e3049922df02af643337b7a58b2: Bug 1525720, part 16 - Cycle collect RemoteBrowser and support weak references in BrowserHost. r=nika
Ryan Hunt <rhunt@eqrion.net> - Tue, 14 May 2019 16:28:10 -0500 - rev 474969
Push 113182 by rhunt@eqrion.net at Wed, 22 May 2019 20:02:12 +0000
Bug 1525720, part 16 - Cycle collect RemoteBrowser and support weak references in BrowserHost. r=nika BrowserParent is cycle collected and supported weak references, so this commit adds support for these things to BrowserHost. Differential Revision: https://phabricator.services.mozilla.com/D31448
99f971a02d87941ee49a391de0e0626c170c0821: Bug 1525720, part 15 - Apply appropriate nsIRemoteTab methods to all BrowserParents. r=nika
Ryan Hunt <rhunt@eqrion.net> - Wed, 08 May 2019 16:12:26 -0500 - rev 474968
Push 113182 by rhunt@eqrion.net at Wed, 22 May 2019 20:02:12 +0000
Bug 1525720, part 15 - Apply appropriate nsIRemoteTab methods to all BrowserParents. r=nika This commit finally updates some nsIRemoteTab methods to apply to the whole tree of BrowserParent's. Differential Revision: https://phabricator.services.mozilla.com/D31447
d25963c72ff7981990660050182a82ea3e935f53: Bug 1525720, part 14 - Move final bits of nsIRemoteTab implementation to BrowserHost. r=nika
Ryan Hunt <rhunt@eqrion.net> - Wed, 08 May 2019 15:47:18 -0500 - rev 474967
Push 113182 by rhunt@eqrion.net at Wed, 22 May 2019 20:02:12 +0000
Bug 1525720, part 14 - Move final bits of nsIRemoteTab implementation to BrowserHost. r=nika This commit moves the actual implementation of nsIRemoteTab from BrowserParent to BrowserHost, without any functional changes. Differential Revision: https://phabricator.services.mozilla.com/D31445
810b7371987139844429d0206f9da6a7701a1efc: Bug 1525720, part 13 - Stop inheriting nsIRemoteTab interface in BrowserParent. r=nika
Ryan Hunt <rhunt@eqrion.net> - Wed, 08 May 2019 14:34:47 -0500 - rev 474966
Push 113182 by rhunt@eqrion.net at Wed, 22 May 2019 20:02:12 +0000
Bug 1525720, part 13 - Stop inheriting nsIRemoteTab interface in BrowserParent. r=nika This commit removes nsIRemoteTab as a parent class from BrowserParent, so that BrowserHost is the only concrete implementation of nsIRemoteTab. Some static_cast's are updated to cast to BrowserHost, and other places have to be updated to pass a BrowserHost instead of a BrowserParent. WindowGlobalParent had a getter to return it's managing BrowserParent as a nsIRemoteTab. I couldn't find a use of this in-tree, so I've just opt-ed to remove it. If there's a use-case, we can add something back in. Differential Revision: https://phabricator.services.mozilla.com/D31444
ee10a825448133635dbd933c3d60fe427400647b: Bug 1525720, part 12 - Make BrowserHost implement nsIRemoteTab by delegating to nsIRemoteTab. r=nika
Ryan Hunt <rhunt@eqrion.net> - Wed, 08 May 2019 11:45:23 -0500 - rev 474965
Push 113182 by rhunt@eqrion.net at Wed, 22 May 2019 20:02:12 +0000
Bug 1525720, part 12 - Make BrowserHost implement nsIRemoteTab by delegating to nsIRemoteTab. r=nika This commit implements nsIRemoteTab in BrowserHost by delegating to nsIRemoteTab. In a future commit, these methods will be implemented by BrowserHost. Differential Revision: https://phabricator.services.mozilla.com/D31443
1bcf9f586c5582ddeb822f4c2be3ca314694337e: Bug 1525720, part 11 - Use RemoteBrowser interface instead of IPDL actors in nsFrameLoader. r=nika
Ryan Hunt <rhunt@eqrion.net> - Mon, 06 May 2019 21:29:48 -0500 - rev 474964
Push 113182 by rhunt@eqrion.net at Wed, 22 May 2019 20:02:12 +0000
Bug 1525720, part 11 - Use RemoteBrowser interface instead of IPDL actors in nsFrameLoader. r=nika This commit replaces the direct use of the IPDL actors in nsFrameLoader with the RemoteBrowser interface. Some special use cases are adapted to still use the IPDL actors. In the future, we should burn these use cases down. Differential Revision: https://phabricator.services.mozilla.com/D31442
d3b2ac8d5ca4bd350603085c3cb9f6a51269e075: Bug 1525720, part 10 - Link BrowserParent and BrowserHost on creation. r=nika
Ryan Hunt <rhunt@eqrion.net> - Wed, 15 May 2019 10:34:03 -0500 - rev 474963
Push 113182 by rhunt@eqrion.net at Wed, 22 May 2019 20:02:12 +0000
Bug 1525720, part 10 - Link BrowserParent and BrowserHost on creation. r=nika This commit adds a link from BrowserParent to it's owning BrowserHost if it is the root BrowserParent. Differential Revision: https://phabricator.services.mozilla.com/D31441
697774dd89848fb992355abaae97bba35b8c74ba: Bug 1525720, part 9 - Fill out implementations of BrowserHost and BrowserBridgeHost. r=nika
Ryan Hunt <rhunt@eqrion.net> - Wed, 08 May 2019 11:27:49 -0500 - rev 474962
Push 113182 by rhunt@eqrion.net at Wed, 22 May 2019 20:02:12 +0000
Bug 1525720, part 9 - Fill out implementations of BrowserHost and BrowserBridgeHost. r=nika This commit implements the RemoteBrowser interface for BrowserHost and BrowserBridgeHost. For BrowserHost, most methods delegate to the root BrowserParent. In the future, we should move these over to BrowserHost. For BrowserBridgeHost, most methods are taken from BrowserBridgeParent. Differential Revision: https://phabricator.services.mozilla.com/D31439
eadeacbe44838a0db21d5f535fd14bfd62455a22: Bug 1525720, part 8 - Add RemoteBrowser interface and BrowserHost/BrowserBridgeHost implementations. r=nika
Ryan Hunt <rhunt@eqrion.net> - Mon, 06 May 2019 16:04:34 -0500 - rev 474961
Push 113182 by rhunt@eqrion.net at Wed, 22 May 2019 20:02:12 +0000
Bug 1525720, part 8 - Add RemoteBrowser interface and BrowserHost/BrowserBridgeHost implementations. r=nika RemoteBrowser is a common interface between the chrome/content process cases for nsFrameLoader, that allows us to abstract IPC details away. BrowserHost is a concrete implementation for the chrome process, while BrowserBridgeHost implements the content process case. Differential Revision: https://phabricator.services.mozilla.com/D31438
32eeee79d628dade8109454c636d5f8aaff0c93e: Bug 1525720, part 7 - Use getter methods to access mBrowserParent and mBrowserBridgeChild. r=farre
Ryan Hunt <rhunt@eqrion.net> - Thu, 25 Apr 2019 12:36:16 -0500 - rev 474960
Push 113182 by rhunt@eqrion.net at Wed, 22 May 2019 20:02:12 +0000
Bug 1525720, part 7 - Use getter methods to access mBrowserParent and mBrowserBridgeChild. r=farre This prepares nsFrameLoader for replacing mBrowserParent and mBrowserBridgeChild with a common interface by making special case code use a getter method instead of direct access. Differential Revision: https://phabricator.services.mozilla.com/D31437
07678a2fa9e7cb164b2d3b07b8c61653253b7540: Bug 1525720, part 6 - Move BrowserBridgeChild creation to ContentChild. r=farre
Ryan Hunt <rhunt@eqrion.net> - Wed, 24 Apr 2019 23:52:47 -0500 - rev 474959
Push 113182 by rhunt@eqrion.net at Wed, 22 May 2019 20:02:12 +0000
Bug 1525720, part 6 - Move BrowserBridgeChild creation to ContentChild. r=farre This makes it symmetrical to how BrowserParent is created by ContentParent. Differential Revision: https://phabricator.services.mozilla.com/D31436
757b4f595cc4b18ae35483d23edff4896d15d4b1: Bug 1525720, part 5 - Redirect nsIHttpChannel using content process ID instead of nsIRemoteTab. r=valentin
Ryan Hunt <rhunt@eqrion.net> - Wed, 15 May 2019 12:33:42 -0500 - rev 474958
Push 113182 by rhunt@eqrion.net at Wed, 22 May 2019 20:02:12 +0000
Bug 1525720, part 5 - Redirect nsIHttpChannel using content process ID instead of nsIRemoteTab. r=valentin This code currently works for remote subframes assuming that nsIRemoteTab is implemented by BrowserParent, but will break when nsIRemoteTab is only for a top-level BrowserParent. What this code really wants is a content process ID to retarget the channel to. This commit switches the interfaces to pass this around instead of nsIRemoteTab. Differential Revision: https://phabricator.services.mozilla.com/D31435
b255e0a84e12657a62a2cdfd4a4c2ebb893b2a0d: Bug 1525720, part 4 - Assert in DrawSnapshot if not the chrome process. r=mattwoodrow
Ryan Hunt <rhunt@eqrion.net> - Wed, 24 Apr 2019 23:28:31 -0500 - rev 474957
Push 113182 by rhunt@eqrion.net at Wed, 22 May 2019 20:02:12 +0000
Bug 1525720, part 4 - Assert in DrawSnapshot if not the chrome process. r=mattwoodrow This API is only intended to be used in the chrome process and this commit makes this explicit to simplify a later refactoring. Differential Revision: https://phabricator.services.mozilla.com/D31434
9a255864f75ddcf4096b6222d016a914f5a43c8a: Bug 1525720, part 3 - Remove method to createRemoteFrameLoader from nsIMozBrowserFrame interface. r=farre
Ryan Hunt <rhunt@eqrion.net> - Wed, 24 Apr 2019 23:25:56 -0500 - rev 474956
Push 113182 by rhunt@eqrion.net at Wed, 22 May 2019 20:02:12 +0000
Bug 1525720, part 3 - Remove method to createRemoteFrameLoader from nsIMozBrowserFrame interface. r=farre This appears unused and adds unneeded surface area for these API's to support. Differential Revision: https://phabricator.services.mozilla.com/D31431
5f1c1b609ec1ecc28734e1b6daeeb3f6854ded38: Bug 1525720, part 2 - Move UITabResolutionChanged method to nsIRemoteTab interface from BrowserParent. r=smaug
Ryan Hunt <rhunt@eqrion.net> - Wed, 24 Apr 2019 23:05:40 -0500 - rev 474955
Push 113182 by rhunt@eqrion.net at Wed, 22 May 2019 20:02:12 +0000
Bug 1525720, part 2 - Move UITabResolutionChanged method to nsIRemoteTab interface from BrowserParent. r=smaug This reduces the amount of code that assumes that BrowserParent implements nsIRemoteTab. Differential Revision: https://phabricator.services.mozilla.com/D31430
00d83f1d02e015735d580045524eceeeccdc4e28: Bug 1525720, part 1 - Allow calling BrowserParent::InitRendering multiple times, and remove RenderFrame dependency from nsFrameLoader. r=kats
Ryan Hunt <rhunt@eqrion.net> - Wed, 24 Apr 2019 22:36:27 -0500 - rev 474954
Push 113182 by rhunt@eqrion.net at Wed, 22 May 2019 20:02:12 +0000
Bug 1525720, part 1 - Allow calling BrowserParent::InitRendering multiple times, and remove RenderFrame dependency from nsFrameLoader. r=kats This cleanup will simplify refactoring nsFrameLoader later. Differential Revision: https://phabricator.services.mozilla.com/D31429
bdd76368ddc15c25c10527bd1afd2b8e9c46dbee: Merge mozilla-central to inbound. a=merge CLOSED TREE
shindli <shindli@mozilla.com> - Wed, 22 May 2019 18:37:34 +0300 - rev 474953
Push 113181 by shindli@mozilla.com at Wed, 22 May 2019 15:39:08 +0000
Merge mozilla-central to inbound. a=merge CLOSED TREE
aaae630f30291056f4f40bbd9e12a917309e401e: Merge inbound to mozilla-central. a=merge
shindli <shindli@mozilla.com> - Wed, 22 May 2019 18:26:18 +0300 - rev 474952
Push 113181 by shindli@mozilla.com at Wed, 22 May 2019 15:39:08 +0000
Merge inbound to mozilla-central. a=merge
a5f7f53421ebce84b0dd4cb3535b49906fdf78ef: Merge autoland to mozilla-central. a=merge
shindli <shindli@mozilla.com> - Wed, 22 May 2019 18:23:32 +0300 - rev 474951
Push 113181 by shindli@mozilla.com at Wed, 22 May 2019 15:39:08 +0000
Merge autoland to mozilla-central. a=merge
5f95b3f2ea44723ba6a8c41a4b27c88032df709f: Backed out changeset fa4c37c31dfd (bug 1550956) as requested by mikedeboer on IRC for causing mach to stop working on Python 2. a=backout
Brindusan Cristian <cbrindusan@mozilla.com> - Wed, 22 May 2019 12:33:23 +0300 - rev 474950
Push 113181 by shindli@mozilla.com at Wed, 22 May 2019 15:39:08 +0000
Backed out changeset fa4c37c31dfd (bug 1550956) as requested by mikedeboer on IRC for causing mach to stop working on Python 2. a=backout
3c6b640e364f1eb7fc920ed1737de089631882b3: Bug 1552636 - Remove eStyleImageType_URL. r=TYLin
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 22 May 2019 11:34:23 +0000 - rev 474949
Push 113181 by shindli@mozilla.com at Wed, 22 May 2019 15:39:08 +0000
Bug 1552636 - Remove eStyleImageType_URL. r=TYLin It was introduced in bug 1352096 to reduce complexity with Stylo (apparently). Right now it doesn't look like it reduces any complexity, and it's a bit annoying with some of the patches that I'm writing at the moment. So unless there's any objection I think it should go away. Differential Revision: https://phabricator.services.mozilla.com/D31708
97a9fa27755b76a1f64fdaa7a2a2ed84fb120af9: Bug 1418472 - Flush line-breaks when encountering a Placeholder for an absolutely-positioned frame. r=emilio
Jonathan Kew <jkew@mozilla.com> - Wed, 22 May 2019 11:33:21 +0000 - rev 474948
Push 113181 by shindli@mozilla.com at Wed, 22 May 2019 15:39:08 +0000
Bug 1418472 - Flush line-breaks when encountering a Placeholder for an absolutely-positioned frame. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D32023
03ffbd776c1e8075880041d97c13c7cc31055e04: Bug 1418472 - Add WPT reftests for the abs-pos at line-break issue here. r=emilio
Jonathan Kew <jkew@mozilla.com> - Tue, 21 May 2019 17:02:21 +0000 - rev 474947
Push 113181 by shindli@mozilla.com at Wed, 22 May 2019 15:39:08 +0000
Bug 1418472 - Add WPT reftests for the abs-pos at line-break issue here. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D32022
b6e9a64b68d92fcb540c0c90550986d0ada13eab: Backed out changeset 3c2a368a4c8b (bug 1552464) for xpcshell failures on test_rotate_viewport.js on a CLOSED TREE
Oana Pop Rus <opoprus@mozilla.com> - Wed, 22 May 2019 14:57:46 +0300 - rev 474946
Push 113181 by shindli@mozilla.com at Wed, 22 May 2019 15:39:08 +0000
Backed out changeset 3c2a368a4c8b (bug 1552464) for xpcshell failures on test_rotate_viewport.js on a CLOSED TREE
ee7e04b12dd34b89aff8a4e0ba5ae3dc5be7d9f9: Bug 1548542 - Remove notions of Kinto in blocklists unit tests r=keeler,Gijs
Mathieu Leplatre <mathieu@mozilla.com> - Wed, 22 May 2019 11:25:04 +0000 - rev 474945
Push 113181 by shindli@mozilla.com at Wed, 22 May 2019 15:39:08 +0000
Bug 1548542 - Remove notions of Kinto in blocklists unit tests r=keeler,Gijs Differential Revision: https://phabricator.services.mozilla.com/D31221
46afaea4fa40e6dbae17245d138e90c973fe20a9: Bug 1553385 - Add context fill to about:preferences permanent private browsing mode info icon for dark mode r=dao
Kestrel <ke5trel@protonmail.com> - Wed, 22 May 2019 08:41:31 +0000 - rev 474944
Push 113181 by shindli@mozilla.com at Wed, 22 May 2019 15:39:08 +0000
Bug 1553385 - Add context fill to about:preferences permanent private browsing mode info icon for dark mode r=dao Differential Revision: https://phabricator.services.mozilla.com/D32096
134250706ea6c5988546c73f808815acfc80688e: Bug 1526018 - Initialize PSM clients in their own service r=Gijs,jcj
Mathieu Leplatre <mathieu@mozilla.com> - Tue, 21 May 2019 21:14:11 +0000 - rev 474943
Push 113181 by shindli@mozilla.com at Wed, 22 May 2019 15:39:08 +0000
Bug 1526018 - Initialize PSM clients in their own service r=Gijs,jcj Differential Revision: https://phabricator.services.mozilla.com/D31603
3c2a368a4c8bb527fdd37645b015787a3d3e2613: Bug 1552464 - Add telemetry probe to count the number of viewport changes in RDM. r=mtigley,nchevobbe.
Razvan Caliman <rcaliman@mozilla.com> - Tue, 21 May 2019 18:40:23 +0000 - rev 474942
Push 113181 by shindli@mozilla.com at Wed, 22 May 2019 15:39:08 +0000
Bug 1552464 - Add telemetry probe to count the number of viewport changes in RDM. r=mtigley,nchevobbe. This patch adds telemetry instrumentation to count the number of times the RDM viewport properties are changed (dimensions and rotation). This count will be correlated with the panel open count and time spent open to refine the baseline for RDM usage and filter out accidental usage. A new Redux middleware, `telemetryMiddleware`, is introduced to the RDM Redux store. This observes actions dispatched to the store. For `RESIZE_VIEWPORT` and `ROTATE_VIEWPORT` actions, it increases a numeric value for the new scalar telemetry probe, `"devtools.responsive.viewport_change_count"`. Other actions may be observed in this middleware for future telemetry instrumentation of RDM. The `RESIZE_VIEWPORT` action is a dispatched with a high frequency when dragging to resize. Therefore, we debounce logging for this action. To ensure the test can reliably test counting this action without adding needless complexity to account for the asynchronicity, the `debounce()` utility is extended with an `immediate` parameter to cause the very first call to be executed immediately before going into the debounce behaviour. Differential Revision: https://phabricator.services.mozilla.com/D31645
e61c315b780db1def991c721606ad947d6848a47: Bug 1553194 - Remove unrelated code comment from shared/css-logic.js r=pbro
Razvan Caliman <rcaliman@mozilla.com> - Wed, 22 May 2019 07:35:02 +0000 - rev 474941
Push 113181 by shindli@mozilla.com at Wed, 22 May 2019 15:39:08 +0000
Bug 1553194 - Remove unrelated code comment from shared/css-logic.js r=pbro Depends on D32016 The code comment is perhaps a leftover from a file duplication to extract shared methods to `shared/inspector/css-logic.js` from `server/actors/inspector/css-logic.js`. The comment is confusing because there is no usage of any of the CssLogic terminology within the file. Differential Revision: https://phabricator.services.mozilla.com/D32017
e24c48157bf155e4f92db2e8e33e487fcbfa98db: Bug 1553194 - Remove unnecessary isInherited from CssLogic constructor. r=pbro
Razvan Caliman <rcaliman@mozilla.com> - Wed, 22 May 2019 07:34:03 +0000 - rev 474940
Push 113181 by shindli@mozilla.com at Wed, 22 May 2019 15:39:08 +0000
Bug 1553194 - Remove unnecessary isInherited from CssLogic constructor. r=pbro `isInherited` is a callback function that checks if a given CSS property is inherited. It is misleadingly commented as a cache of inherited properties (which perhaps it is on the InspectorUtils implementation, but on the consumer side it is just a function). The actual call is done by InspectorUtils.isPropertyInherited. There is no need to pass the handler to CssLogic or to CssPropertyInfo since InspectorUtils is available in the same context as the definition of the consumers. There is no other use case where a custom handler is passed to check for inherited properties in so it is safe to remove this as an argument and just use InspectorUtils.isPropertyInherited where needed. This cleans up the code slightly. Differential Revision: https://phabricator.services.mozilla.com/D32016
0a9f9f076b93f3d456a3f11a330aae3d42ed6f78: Bug 1553113 - Rename the profiles uploaded by startup main thread IO tests so that treeherder offers to open them in Firefox Profiler, r=mconley.
Florian Quèze <florian@queze.net> - Wed, 22 May 2019 10:03:48 +0000 - rev 474939
Push 113181 by shindli@mozilla.com at Wed, 22 May 2019 15:39:08 +0000
Bug 1553113 - Rename the profiles uploaded by startup main thread IO tests so that treeherder offers to open them in Firefox Profiler, r=mconley. Differential Revision: https://phabricator.services.mozilla.com/D31994
bc517e65f14efda9a149410692057c1500dcb0e1: Bug 1549973 - Force tabState flush from C++ listener before tab is closed r=peterv
Alphan Chen <alchen@mozilla.com> - Wed, 22 May 2019 09:06:14 +0000 - rev 474938
Push 113181 by shindli@mozilla.com at Wed, 22 May 2019 15:39:08 +0000
Bug 1549973 - Force tabState flush from C++ listener before tab is closed r=peterv Differential Revision: https://phabricator.services.mozilla.com/D30475
81e2959af69065808f368500becaa85f61a9ac1c: Bug 1538270 - Show toast for default file picker when permissions denied.;r=VladBaicu
Brad Arant <brad.arant@softvision.com> - Wed, 22 May 2019 09:10:45 +0000 - rev 474937
Push 113181 by shindli@mozilla.com at Wed, 22 May 2019 15:39:08 +0000
Bug 1538270 - Show toast for default file picker when permissions denied.;r=VladBaicu Differential Revision: https://phabricator.services.mozilla.com/D32073
bfb0684033ad22f579ed7bbbc9f0098f72eedb78: Bug 1553413 - Update and harden form data filtering for privacy to account for no data being passed in. r=dao
Mike de Boer <mdeboer@mozilla.com> - Wed, 22 May 2019 09:46:58 +0000 - rev 474936
Push 113181 by shindli@mozilla.com at Wed, 22 May 2019 15:39:08 +0000
Bug 1553413 - Update and harden form data filtering for privacy to account for no data being passed in. r=dao Differential Revision: https://phabricator.services.mozilla.com/D32116
41db3c4f9929b832dfdce160ffc57d65280dc15f: Bug 1546255 - When an @import stylesheet is cloned, we should also make sure to restyle. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 22 May 2019 06:01:51 +0000 - rev 474935
Push 113181 by shindli@mozilla.com at Wed, 22 May 2019 15:39:08 +0000
Bug 1546255 - When an @import stylesheet is cloned, we should also make sure to restyle. r=heycam We need to notify the whole parent chain (using NOTIFY) rather than just mStyleSets, since mStyleSets is empty for @import-ed sheets. Differential Revision: https://phabricator.services.mozilla.com/D31787
ce950f1fe559c61010ac30386a607fe29bca82b6: Bug 1543684 - When a session is set to resume anyways, skip analyzing previous crashes and always restore immediately. r=dao
Mike de Boer <mdeboer@mozilla.com> - Wed, 22 May 2019 09:08:09 +0000 - rev 474934
Push 113181 by shindli@mozilla.com at Wed, 22 May 2019 15:39:08 +0000
Bug 1543684 - When a session is set to resume anyways, skip analyzing previous crashes and always restore immediately. r=dao I also made a few gratuitous code formatting cleanups. I hope you don't mind. We are unable to properly analyze shutdown crashes and deduce the right action to take when that happened. This leads to surprising occurrences of the 'about:sessionrestore' page shown, especially when a full restore is expected anyway. Differential Revision: https://phabricator.services.mozilla.com/D29676
65de6e306adb3257187dcb00fab74b0333765ab3: Bug 1549786 - Add test for Page.navigate reloads the page with the same URL r=ochameau
Julian Descottes <jdescottes@mozilla.com> - Wed, 22 May 2019 08:58:08 +0000 - rev 474933
Push 113181 by shindli@mozilla.com at Wed, 22 May 2019 15:39:08 +0000
Bug 1549786 - Add test for Page.navigate reloads the page with the same URL r=ochameau Differential Revision: https://phabricator.services.mozilla.com/D32027
baf86b77635c22a5739fcef15e0a9172fd5cbd6b: Bug 1541355 - Don't display DevTools internal frames in Netmonitor stacktrace. r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Wed, 22 May 2019 08:57:36 +0000 - rev 474932
Push 113181 by shindli@mozilla.com at Wed, 22 May 2019 15:39:08 +0000
Bug 1541355 - Don't display DevTools internal frames in Netmonitor stacktrace. r=Honza. Before sending back the stacktrace, we remove all the devtools internal frames using removeFramesAboveDebuggerEval. A test (that was failing without the fix) is added to ensure this works as expected. The test revealed some issues in webconsole-connection-proxy (mostly trying to access webConsoleUI while closing the toolbox), which we fix in the patch as well. Differential Revision: https://phabricator.services.mozilla.com/D31249
3f4a4ab9eed068c89e4721294d62a001d205422a: Bug 1547944 [RTL] Mirror the Separate Window icon r=pbro
vishal singh <vishalsingh600700@gmail.com> - Wed, 22 May 2019 07:41:26 +0000 - rev 474931
Push 113181 by shindli@mozilla.com at Wed, 22 May 2019 15:39:08 +0000
Bug 1547944 [RTL] Mirror the Separate Window icon r=pbro Before the icon was reverse for rtl . But now it is in correct form. Differential Revision: https://phabricator.services.mozilla.com/D32049
2f20a0d737e1f11d5933671809ad8c0f725a0543: Bug 1543369 Raptor cold page-load tests on Firefox android fennec r=Bebe
alexandru.ionescu <alexandru.ionescu@softvision.ro> - Tue, 21 May 2019 12:03:03 +0000 - rev 474930
Push 113181 by shindli@mozilla.com at Wed, 22 May 2019 15:39:08 +0000
Bug 1543369 Raptor cold page-load tests on Firefox android fennec r=Bebe Differential Revision: https://phabricator.services.mozilla.com/D31251
ce125698decddfbf1f3e62e2265affa8bf328387: Bug 1551729 - Revert bug 1548432 - Re-introducing the support for cookies without values, r=mayhemer
Andrea Marchesini <amarchesini@mozilla.com> - Wed, 22 May 2019 06:31:22 +0000 - rev 474929
Push 113181 by shindli@mozilla.com at Wed, 22 May 2019 15:39:08 +0000
Bug 1551729 - Revert bug 1548432 - Re-introducing the support for cookies without values, r=mayhemer This patch reverts the second part of bug 1548432. Differential Revision: https://phabricator.services.mozilla.com/D31267
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 tip