searching for reviewer(yzen)
597cb65dad667703d23017c879e5b7628015bbb0: Bug 1594337: When dismissing a pop-up or the menu bar, if focus is inside an OOP iframe, restore a11y focus inside the iframe. r=yzen
James Teh <jteh@mozilla.com> - Wed, 13 Nov 2019 16:01:02 +0000 - rev 501852
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1594337: When dismissing a pop-up or the menu bar, if focus is inside an OOP iframe, restore a11y focus inside the iframe. r=yzen Previously, we only restored focus within the top level remote browser. This is fine for remote documents without iframes or only in-process iframes, as was the case with e10s. For Fission, if an OOP iframe has focus, we need to get the appropriate nested remote browser. Fortunately, BrowserParent::GetFocused was introduced to do exactly this. Differential Revision: https://phabricator.services.mozilla.com/D52803
256dd52a81ff2273dc44c27feb72ee7028e884d2: Bug 1594623: Suppress focus events for OuterDocAccessibles to prevent incorrect reporting for OOP iframes. r=yzen
James Teh <jteh@mozilla.com> - Thu, 07 Nov 2019 20:32:46 +0000 - rev 501195
Push 114168 by dluca@mozilla.com at Sun, 10 Nov 2019 03:08:55 +0000
Bug 1594623: Suppress focus events for OuterDocAccessibles to prevent incorrect reporting for OOP iframes. r=yzen An OuterDoc shouldn't get accessibility focus itself. Focus should always go to something inside it. However, OOP iframes will get DOM focus because their content isn't in this process. We now suppress the OuterDoc focus in this case. The OOP browser will fire focus for the correct Accessible inside the embedded document. Without suppression of the OuterDoc focus, the two focus events will race and the OuterDoc focus may override the correct embedded focus for accessibility clients. Even if they fired in the correct order, clients may report extraneous focus information to the user before reporting the correct focus. Differential Revision: https://phabricator.services.mozilla.com/D52126
182220a74df1c5bf85a5f733bf923c5b005d3563: Bug 1581040: handle late creation/re-creation of OuterDocAccessible for OOP iframe. r=yzen,nika
James Teh <jteh@mozilla.com> - Thu, 07 Nov 2019 00:38:59 +0000 - rev 501018
Push 114166 by apavel@mozilla.com at Thu, 07 Nov 2019 10:04:01 +0000
Bug 1581040: handle late creation/re-creation of OuterDocAccessible for OOP iframe. r=yzen,nika 1. When creating a DocAccessibleParent for an embedded document in an OOP iframe, it's possible that the embedder accessible hasn't been set yet. This can occur if the iframe is initially hidden. Previously, we incorrectly set the document up as a top level document (e.g. tab document) in this case. Now, we set up the document as top level in its content process, set up the proxy, etc. The document will be added to its child document later when the embedder is set. 2. When setting the embedder accessible for an OOP iframe, check if the embedded DocAccessibleParent already exists. This can happen if an iframe is hidden and then shown or an iframe is reflowed by layout. If it already exists, add the embedded (child) document to its embedder. 3. Mac's implementation of ProxyCreated requires that AddChildDoc be called *before* ProxyCreated so it can invalidate the native children of the parent. Because it's possible for an OOP iframe document to be added to its embedder after the document is created, we can't satisfy this requirement for OOP iframe documents. Therefore, we now allow a null parent in Mac's ProxyCreated and use the reorder event fired later to invalidate the native children. Differential Revision: https://phabricator.services.mozilla.com/D51357
c35912afabe45c5800fa0c9487548140e9c98e26: Bug 1593892: Fire OOP iframe reorder events on all platforms, not just Windows. r=yzen
James Teh <jteh@mozilla.com> - Wed, 06 Nov 2019 00:36:45 +0000 - rev 500779
Push 114166 by apavel@mozilla.com at Thu, 07 Nov 2019 10:04:01 +0000
Bug 1593892: Fire OOP iframe reorder events on all platforms, not just Windows. r=yzen Previously, this code was unintentionally inside a Windows ifdef. Differential Revision: https://phabricator.services.mozilla.com/D51754
ac4242e7f029764384385099fa55b4b1429ed635: Bug 1581040: handle late creation/re-creation of OuterDocAccessible for OOP iframe. r=yzen,nika
James Teh <jteh@mozilla.com> - Tue, 05 Nov 2019 05:44:34 +0000 - rev 500547
Push 114166 by apavel@mozilla.com at Thu, 07 Nov 2019 10:04:01 +0000
Bug 1581040: handle late creation/re-creation of OuterDocAccessible for OOP iframe. r=yzen,nika 1. When creating a DocAccessibleParent for an embedded document in an OOP iframe, it's possible that the embedder accessible hasn't been set yet. This can occur if the iframe is initially hidden. Previously, we incorrectly set the document up as a top level document (e.g. tab document) in this case. Now, we set up the document as top level in its content process, set up the proxy, etc. The document will be added to its child document later when the embedder is set. 2. When setting the embedder accessible for an OOP iframe, check if the embedded DocAccessibleParent already exists. This can happen if an iframe is hidden and then shown or an iframe is reflowed by layout. If it already exists, add the embedded (child) document to its embedder. Differential Revision: https://phabricator.services.mozilla.com/D51357
967bb08714f99980174db7ef12d01259d8943dfd: Bug 1581040: handle late creation/re-creation of OuterDocAccessible for OOP iframe. r=yzen,nika
James Teh <jteh@mozilla.com> - Tue, 05 Nov 2019 05:02:38 +0000 - rev 500527
Push 114166 by apavel@mozilla.com at Thu, 07 Nov 2019 10:04:01 +0000
Bug 1581040: handle late creation/re-creation of OuterDocAccessible for OOP iframe. r=yzen,nika 1. When creating a DocAccessibleParent for an embedded document in an OOP iframe, it's possible that the embedder accessible hasn't been set yet. This can occur if the iframe is initially hidden. Previously, we incorrectly set the document up as a top level document (e.g. tab document) in this case. Now, we set up the document as top level in its content process, set up the proxy, etc. The document will be added to its child document later when the embedder is set. 2. When setting the embedder accessible for an OOP iframe, check if the embedded DocAccessibleParent already exists. This can happen if an iframe is hidden and then shown or an iframe is reflowed by layout. If it already exists, add the embedded (child) document to its embedder. Differential Revision: https://phabricator.services.mozilla.com/D51357
61de50c753208632a315ef3b07786fe926768c56: Bug 1590974 - Pass the toolbox document to MenuButton in the a11y panel. r=yzen.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 04 Nov 2019 06:38:37 +0000 - rev 500323
Push 114164 by aiakab@mozilla.com at Tue, 05 Nov 2019 10:06:15 +0000
Bug 1590974 - Pass the toolbox document to MenuButton in the a11y panel. r=yzen. This makes it possible for the menus to not be constrained to the panel boundaries if they are taller than the panel itself (which could be the case for the simulate menu as it has lots of items). We need to style the button with a link role in the toolbox CSS so they don't look like real buttons. Differential Revision: https://phabricator.services.mozilla.com/D50461
40619794029735fa21220c2d183eeca26a3a3935: Bug 1581040: handle late creation/re-creation of OuterDocAccessible for OOP iframe. r=yzen,nika
James Teh <jteh@mozilla.com> - Fri, 01 Nov 2019 17:12:19 +0000 - rev 500319
Push 114164 by aiakab@mozilla.com at Tue, 05 Nov 2019 10:06:15 +0000
Bug 1581040: handle late creation/re-creation of OuterDocAccessible for OOP iframe. r=yzen,nika 1. When creating a DocAccessibleParent for an embedded document in an OOP iframe, it's possible that the embedder accessible hasn't been set yet. This can occur if the iframe is initially hidden. Previously, we incorrectly set the document up as a top level document (e.g. tab document) in this case. Now, we set up the document as top level in its content process, set up the proxy, etc. The document will be added to its child document later when the embedder is set. 2. When setting the embedder accessible for an OOP iframe, check if the embedded DocAccessibleParent already exists. This can happen if an iframe is hidden and then shown or an iframe is reflowed by layout. If it already exists, add the embedded (child) document to its embedder. Differential Revision: https://phabricator.services.mozilla.com/D51357
bd5ca045d481384cf7e1de5d71b70e57e9b68ef5: Bug 1525939 - Use shared Accordion component in Inspector; r=yzen
Florens Verschelde <florens@fvsch.com> - Fri, 01 Nov 2019 16:11:13 +0000 - rev 500173
Push 114164 by aiakab@mozilla.com at Tue, 05 Nov 2019 10:06:15 +0000
Bug 1525939 - Use shared Accordion component in Inspector; r=yzen Differential Revision: https://phabricator.services.mozilla.com/D43640
a8d297ad5ac53fd40c1eb6910639745e74dc2c57: Bug 1415667: Always use OuterDocAccessible for iframes, even if an ARIA table role is specified. r=yzen
James Teh <jteh@mozilla.com> - Tue, 29 Oct 2019 14:26:49 +0000 - rev 499639
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1415667: Always use OuterDocAccessible for iframes, even if an ARIA table role is specified. r=yzen OuterDocAccessible has some special behaviour. We really shouldn't try to use some other class for iframes. Anyway, making an iframe part of an ARIA table won't work for other reasons, plus I'm not sure it makes much sense. Differential Revision: https://phabricator.services.mozilla.com/D50769
e062c3bc7cbd57ec80757c4ad04de799660577a1: Bug 1576509: Add a function to announce a message to screen reader users. r=Gijs,yzen
James Teh <jteh@mozilla.com> - Wed, 02 Oct 2019 05:53:52 +0000 - rev 495948
Push 114140 by dvarga@mozilla.com at Wed, 02 Oct 2019 18:04:51 +0000
Bug 1576509: Add a function to announce a message to screen reader users. r=Gijs,yzen Differential Revision: https://phabricator.services.mozilla.com/D47717
a7bbb75ce7212ed060fb5004e4ac3a969da09ae5: Bug 1583444 - Reuse DevToolsUtils.getTopWindow in HTMLTooltip r=yzen
Julian Descottes <jdescottes@mozilla.com> - Mon, 30 Sep 2019 09:53:33 +0000 - rev 495618
Push 114140 by dvarga@mozilla.com at Wed, 02 Oct 2019 18:04:51 +0000
Bug 1583444 - Reuse DevToolsUtils.getTopWindow in HTMLTooltip r=yzen Depends on D46958 The getTopWindow logic was duplicated between DevToolsUtils and HTMLTooltip. This removes the duplication and adds a fixture to the accessibility panel to avoid loading the actual DevToolsUtils file in jest tests. Differential Revision: https://phabricator.services.mozilla.com/D46959
b19d946a62e06c2df1027393a7679d0b6467113b: Bug 1582865 - Don't use document/window in tree component. r=yzen.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Fri, 27 Sep 2019 12:06:20 +0000 - rev 495331
Push 114134 by ccoroiu@mozilla.com at Mon, 30 Sep 2019 09:57:15 +0000
Bug 1582865 - Don't use document/window in tree component. r=yzen. When using the ObjectInspector in an inspector extension sidebar, document is not an HTMLDocument but a Sandbox, which means we don't have access to the same properties than in a document. Since the Tree and the ObjectInspector components do use `document` and `window`, this means some interaction would lead to the sidebar crashing. To prevent this, we retrieve the document and/or the window from a node reference instead. Differential Revision: https://phabricator.services.mozilla.com/D47271
5eca1b56929069654b5851c9dd054e821570fd78: Bug 1564549 - Remove AccessFu. r=geckoview-reviewers,yzen,snorp
Eitan Isaacson <eitan@monotonous.org> - Tue, 24 Sep 2019 19:28:28 +0000 - rev 494804
Push 114131 by dluca@mozilla.com at Thu, 26 Sep 2019 09:47:34 +0000
Bug 1564549 - Remove AccessFu. r=geckoview-reviewers,yzen,snorp Differential Revision: https://phabricator.services.mozilla.com/D45604
348ec040eaa29265fde613c82d08d5b89ecbd9ba: Bug 1564549 - Implement clipboard actions natively. r=geckoview-reviewers,yzen,snorp
Eitan Isaacson <eitan@monotonous.org> - Mon, 23 Sep 2019 23:42:38 +0000 - rev 494802
Push 114131 by dluca@mozilla.com at Thu, 26 Sep 2019 09:47:34 +0000
Bug 1564549 - Implement clipboard actions natively. r=geckoview-reviewers,yzen,snorp Differential Revision: https://phabricator.services.mozilla.com/D45602
95544c7598d53d71f5223240488656717b83e0d7: Bug 1564549 - Implement set selection natively. r=geckoview-reviewers,yzen,snorp
Eitan Isaacson <eitan@monotonous.org> - Mon, 23 Sep 2019 23:42:40 +0000 - rev 494801
Push 114131 by dluca@mozilla.com at Thu, 26 Sep 2019 09:47:34 +0000
Bug 1564549 - Implement set selection natively. r=geckoview-reviewers,yzen,snorp Differential Revision: https://phabricator.services.mozilla.com/D45601
414ba8c039e6bad3f21ef3da8fa16a5aab684d99: Bug 1564549 - Implement move and explore by touch natively. r=geckoview-reviewers,yzen,snorp
Eitan Isaacson <eitan@monotonous.org> - Mon, 23 Sep 2019 23:42:49 +0000 - rev 494799
Push 114131 by dluca@mozilla.com at Thu, 26 Sep 2019 09:47:34 +0000
Bug 1564549 - Implement move and explore by touch natively. r=geckoview-reviewers,yzen,snorp Differential Revision: https://phabricator.services.mozilla.com/D45599
83b8e1b49e1e2bd64cff30f52de828e8557a80b6: Bug 1564549 - Introduce native traveral rule. r=yzen
Eitan Isaacson <eitan@monotonous.org> - Mon, 23 Sep 2019 23:42:51 +0000 - rev 494798
Push 114131 by dluca@mozilla.com at Thu, 26 Sep 2019 09:47:34 +0000
Bug 1564549 - Introduce native traveral rule. r=yzen The rule takes a granularity constant as an argument in the constructor. Differential Revision: https://phabricator.services.mozilla.com/D45598
a6b83802832ce0baaade4f296c406bde187782ee: Bug 1564549 - Remove AccessFu. r=geckoview-reviewers,yzen,snorp
Eitan Isaacson <eitan@monotonous.org> - Mon, 23 Sep 2019 21:07:21 +0000 - rev 494590
Push 114123 by csabou@mozilla.com at Tue, 24 Sep 2019 03:53:15 +0000
Bug 1564549 - Remove AccessFu. r=geckoview-reviewers,yzen,snorp Differential Revision: https://phabricator.services.mozilla.com/D45604
15a754fb192e7a9d67e71c987449b84935122606: Bug 1564549 - Implement clipboard actions natively. r=geckoview-reviewers,yzen,snorp
Eitan Isaacson <eitan@monotonous.org> - Mon, 23 Sep 2019 21:07:08 +0000 - rev 494588
Push 114123 by csabou@mozilla.com at Tue, 24 Sep 2019 03:53:15 +0000
Bug 1564549 - Implement clipboard actions natively. r=geckoview-reviewers,yzen,snorp Differential Revision: https://phabricator.services.mozilla.com/D45602
34441585469fc7dcd757477d485913fe81da1614: Bug 1564549 - Implement set selection natively. r=geckoview-reviewers,yzen,snorp
Eitan Isaacson <eitan@monotonous.org> - Mon, 23 Sep 2019 21:07:02 +0000 - rev 494587
Push 114123 by csabou@mozilla.com at Tue, 24 Sep 2019 03:53:15 +0000
Bug 1564549 - Implement set selection natively. r=geckoview-reviewers,yzen,snorp Differential Revision: https://phabricator.services.mozilla.com/D45601
103dbf465704512a132786f7c5599b7579ea215c: Bug 1564549 - Implement move and explore by touch natively. r=geckoview-reviewers,yzen,snorp
Eitan Isaacson <eitan@monotonous.org> - Mon, 23 Sep 2019 21:06:51 +0000 - rev 494585
Push 114123 by csabou@mozilla.com at Tue, 24 Sep 2019 03:53:15 +0000
Bug 1564549 - Implement move and explore by touch natively. r=geckoview-reviewers,yzen,snorp Differential Revision: https://phabricator.services.mozilla.com/D45599
c38e720588697e5c0917cab88a4fea6d70af71e1: Bug 1564549 - Introduce native traveral rule. r=yzen
Eitan Isaacson <eitan@monotonous.org> - Mon, 23 Sep 2019 21:06:49 +0000 - rev 494584
Push 114123 by csabou@mozilla.com at Tue, 24 Sep 2019 03:53:15 +0000
Bug 1564549 - Introduce native traveral rule. r=yzen The rule takes a granularity constant as an argument in the constructor. Differential Revision: https://phabricator.services.mozilla.com/D45598
48b2e9346da3fd0938603bae310008498ed12f24: Bug 1567249 - Update a11y contrast calculation to make it work with applied simulation matrices, r=yzen,nchevobbe
Maliha Islam <mislam@mozilla.com> - Tue, 03 Sep 2019 05:39:18 +0000 - rev 491561
Push 114026 by aiakab@mozilla.com at Wed, 04 Sep 2019 04:24:07 +0000
Bug 1567249 - Update a11y contrast calculation to make it work with applied simulation matrices, r=yzen,nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D42417
1581357c9e7b5548064334de939db9290e19a7e1: Bug 1567200 - Add telemetry for simulation menu usage, r=yzen
Maliha Islam <mislam@mozilla.com> - Fri, 30 Aug 2019 03:14:51 +0000 - rev 490793
Push 114002 by shindli@mozilla.com at Fri, 30 Aug 2019 09:43:28 +0000
Bug 1567200 - Add telemetry for simulation menu usage, r=yzen Differential Revision: https://phabricator.services.mozilla.com/D42254
82ffbd60679f5b86a37f80113954263a9c3886e8: Bug 1564999 - Add menu with simulation options to the a11y panel, r=yzen
Maliha Islam <mislam@mozilla.com> - Thu, 29 Aug 2019 05:01:52 +0000 - rev 490633
Push 114000 by csabou@mozilla.com at Thu, 29 Aug 2019 22:00:33 +0000
Bug 1564999 - Add menu with simulation options to the a11y panel, r=yzen Differential Revision: https://phabricator.services.mozilla.com/D38885
5a009a174052bb4a8a1f3e8bd96ab4f22b0e96b8: Bug 1564993 - Create simulator actor and front, r=yzen,nchevobbe
Maliha Islam <mislam@mozilla.com> - Thu, 29 Aug 2019 04:55:45 +0000 - rev 490632
Push 114000 by csabou@mozilla.com at Thu, 29 Aug 2019 22:00:33 +0000
Bug 1564993 - Create simulator actor and front, r=yzen,nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D38884
3231c97680c749d65e53d63929c7c364b02e22b8: Bug 1573791 - Fix Accessibility tabs dropdown checkmark for RTL users r=yzen
Itiel <itiel_yn8@walla.com> - Fri, 16 Aug 2019 01:13:26 +0000 - rev 488435
Push 113908 by ccoroiu@mozilla.com at Fri, 16 Aug 2019 09:57:53 +0000
Bug 1573791 - Fix Accessibility tabs dropdown checkmark for RTL users r=yzen Differential Revision: https://phabricator.services.mozilla.com/D42220
c009e486b4c2e82a516e95cfb635523ea215e275: Bug 1568053 - Redesign contrast info in color picker (front-end), r=yzen,gl
Maliha Islam <mislam@mozilla.com> - Fri, 16 Aug 2019 00:55:27 +0000 - rev 488397
Push 113908 by ccoroiu@mozilla.com at Fri, 16 Aug 2019 09:57:53 +0000
Bug 1568053 - Redesign contrast info in color picker (front-end), r=yzen,gl Differential Revision: https://phabricator.services.mozilla.com/D40925
d9a83f0385d54763aabbadaea607a7451381beba: Bug 1568053 - Create node actor method for getting complex bg color data for text nodes and refactor existing contrast calculation methods, r=yzen,gl
Maliha Islam <mislam@mozilla.com> - Fri, 16 Aug 2019 00:55:26 +0000 - rev 488396
Push 113908 by ccoroiu@mozilla.com at Fri, 16 Aug 2019 09:57:53 +0000
Bug 1568053 - Create node actor method for getting complex bg color data for text nodes and refactor existing contrast calculation methods, r=yzen,gl Differential Revision: https://phabricator.services.mozilla.com/D40086
6d13675abafe5638f69ef2e79b7996c94381be85: Bug 1570523 - Move browser/events.js to mochitest/promisified-events.js r=yzen
Eitan Isaacson <eitan@monotonous.org> - Fri, 02 Aug 2019 20:40:25 +0000 - rev 486064
Push 113827 by btara@mozilla.com at Sat, 03 Aug 2019 09:54:50 +0000
Bug 1570523 - Move browser/events.js to mochitest/promisified-events.js r=yzen Also reworked test_recreation.html to test/demo how these ergonomics would work. Differential Revision: https://phabricator.services.mozilla.com/D40124
7a9fe2316293e77590c4a673aec766c2e480d523: Bug 1570038: When sending the parent COM proxy for a remote document, return early if the parent COM proxy can't be retrieved. r=yzen
James Teh <jteh@mozilla.com> - Fri, 02 Aug 2019 03:40:14 +0000 - rev 485859
Push 113821 by malexandru@mozilla.com at Fri, 02 Aug 2019 09:51:08 +0000
Bug 1570038: When sending the parent COM proxy for a remote document, return early if the parent COM proxy can't be retrieved. r=yzen Previously, we expected that we'd always be able to get the COM proxy for the parent (outer doc), so we crashed if it was null. For an out-of-process iframe, this sometimes fails. That is probably because the outer doc died in the embedder process, but the parent process hasn't received a message to remove it from the ProxyAccessible tree yet. Differential Revision: https://phabricator.services.mozilla.com/D40150
3f39ed95662a0528d53f02a5baf24553f90f46b8: Bug 1568163: Don't return proxy wrappers from OuterDocAccessible::ChildAtPoint with eDeepestChild to prevent crashes when hit testing via XPCOM. r=yzen
James Teh <jteh@mozilla.com> - Wed, 24 Jul 2019 13:32:22 +0000 - rev 484627
Push 113775 by aciure@mozilla.com at Thu, 25 Jul 2019 06:34:07 +0000
Bug 1568163: Don't return proxy wrappers from OuterDocAccessible::ChildAtPoint with eDeepestChild to prevent crashes when hit testing via XPCOM. r=yzen On Windows, OuterDocAccessible::GetChildAt can return a proxy wrapper for a remote document. These aren't real Accessibles and shouldn't be returned except to the Windows a11y code (which doesn't use eDeepestChild). Calling ChildAtPoint on these will crash! Therefore, just return null in this case. Differential Revision: https://phabricator.services.mozilla.com/D39135
f61413f491f3d1135a3934f7ed215dc7ceb35437: Bug 1509234: Add some assertions to help debug crashes. r=yzen
James Teh <jteh@mozilla.com> - Wed, 24 Jul 2019 00:08:01 +0000 - rev 483935
Push 113759 by malexandru@mozilla.com at Wed, 24 Jul 2019 09:58:20 +0000
Bug 1509234: Add some assertions to help debug crashes. r=yzen Differential Revision: https://phabricator.services.mozilla.com/D38967
bab3a664928e8ef726025292c47a82b0a3eece56: Bug 1552142 Text inside the contrast badges should be unselectable r=yzen
Krishnal Ciccolella <shellyc23@hotmail.com> - Sat, 20 Jul 2019 15:14:27 +0000 - rev 483624
Push 113735 by shindli@mozilla.com at Sun, 21 Jul 2019 09:53:58 +0000
Bug 1552142 Text inside the contrast badges should be unselectable r=yzen I added `-moz-user-select: none;` to the `.badge` class in devtools/client/accessibility/accessibility.css . Differential Revision: https://phabricator.services.mozilla.com/D37730
bf6d08f93d8dc218ebcd4898e0b1816ef03eada6: Bug 1564542: Add a dummy implementation of Bounds() on DocProxyAccessibleWrap/RemoteIframeDocProxyAccessibleWrap to prevent crashes when hit testing via XPCOM. r=yzen
James Teh <jteh@mozilla.com> - Wed, 17 Jul 2019 15:43:40 +0000 - rev 483154
Push 113708 by aciure@mozilla.com at Thu, 18 Jul 2019 03:50:35 +0000
Bug 1564542: Add a dummy implementation of Bounds() on DocProxyAccessibleWrap/RemoteIframeDocProxyAccessibleWrap to prevent crashes when hit testing via XPCOM. r=yzen OuterDocAccessible can return a DocProxyAccessibleWrap or RemoteIframeDocProxyAccessibleWrap as a child. Accessible::ChildAtPoint on an ancestor might retrieve this proxy and call Bounds() on it. This will crash on a proxy, so we override it on these document proxies to do nothing. Differential Revision: https://phabricator.services.mozilla.com/D38256
83881815f007452eeacfd248be7ca22a29cf3341: Bug 1478156 - Make color picker tooltip screen reader accessible, r=yzen,gl
Maliha Islam <mislam@mozilla.com> - Mon, 15 Jul 2019 11:01:04 +0000 - rev 482802
Push 113692 by nerli@mozilla.com at Mon, 15 Jul 2019 21:50:20 +0000
Bug 1478156 - Make color picker tooltip screen reader accessible, r=yzen,gl Differential Revision: https://phabricator.services.mozilla.com/D35980
c3bb4cfd04dc7021be139dcb2e9a03b4b020bd69: Bug 1478156 - Make color picker tooltip keyboard accessible, r=yzen,gl
Maliha Islam <mislam@mozilla.com> - Mon, 15 Jul 2019 11:01:04 +0000 - rev 482801
Push 113692 by nerli@mozilla.com at Mon, 15 Jul 2019 21:50:20 +0000
Bug 1478156 - Make color picker tooltip keyboard accessible, r=yzen,gl Differential Revision: https://phabricator.services.mozilla.com/D33331
71c74b7d0e45047c0eedbff56907cf52f1175842: Bug 1478156 - Move shareable focus methods to be used for color picker accessibility, r=yzen,gl
Maliha Islam <mislam@mozilla.com> - Mon, 15 Jul 2019 11:01:04 +0000 - rev 482800
Push 113692 by nerli@mozilla.com at Mon, 15 Jul 2019 21:50:20 +0000
Bug 1478156 - Move shareable focus methods to be used for color picker accessibility, r=yzen,gl Differential Revision: https://phabricator.services.mozilla.com/D33885
2bfcab598ff432c7212725ffbbbf2418d5e8d19b: Bug 1478156 - Add contrast ratio annotation title and info link to color picker, r=yzen,gl
Maliha Islam <mislam@mozilla.com> - Mon, 15 Jul 2019 11:01:03 +0000 - rev 482799
Push 113692 by nerli@mozilla.com at Mon, 15 Jul 2019 21:50:20 +0000
Bug 1478156 - Add contrast ratio annotation title and info link to color picker, r=yzen,gl Differential Revision: https://phabricator.services.mozilla.com/D32842
1a57ac83b59cc3be6bca9a7c4c754bc7a3d94e89: Bug 1478156 - Add color contrast span to color picker, r=yzen,gl
Maliha Islam <mislam@mozilla.com> - Mon, 15 Jul 2019 17:25:23 +0000 - rev 482798
Push 113692 by nerli@mozilla.com at Mon, 15 Jul 2019 21:50:20 +0000
Bug 1478156 - Add color contrast span to color picker, r=yzen,gl Differential Revision: https://phabricator.services.mozilla.com/D32491
e16036e3719c3e6dbe10e4dd535f4f7b9676b9c6: Bug 1478156 - Move shared code to be used by color contrast feature, r=yzen,gl
Maliha Islam <mislam@mozilla.com> - Mon, 15 Jul 2019 11:01:03 +0000 - rev 482797
Push 113692 by nerli@mozilla.com at Mon, 15 Jul 2019 21:50:20 +0000
Bug 1478156 - Move shared code to be used by color contrast feature, r=yzen,gl Differential Revision: https://phabricator.services.mozilla.com/D32490
5ca694230ffaba883772256d1184aac51faaa9e6: Bug 1478156 - Make color picker tooltip screen reader accessible, r=yzen,gl
Maliha Islam <mislam@mozilla.com> - Sat, 13 Jul 2019 18:37:48 +0000 - rev 482720
Push 113682 by aiakab@mozilla.com at Sun, 14 Jul 2019 09:47:29 +0000
Bug 1478156 - Make color picker tooltip screen reader accessible, r=yzen,gl Differential Revision: https://phabricator.services.mozilla.com/D35980
fcc9123589fd0a275a574e9815383c01ea9c91bc: Bug 1478156 - Make color picker tooltip keyboard accessible, r=yzen,gl
Maliha Islam <mislam@mozilla.com> - Sat, 13 Jul 2019 18:37:35 +0000 - rev 482719
Push 113682 by aiakab@mozilla.com at Sun, 14 Jul 2019 09:47:29 +0000
Bug 1478156 - Make color picker tooltip keyboard accessible, r=yzen,gl Differential Revision: https://phabricator.services.mozilla.com/D33331
83a10c635fe9d9154efce5c01f4e19a42b58f95d: Bug 1478156 - Move shareable focus methods to be used for color picker accessibility, r=yzen,gl
Maliha Islam <mislam@mozilla.com> - Sat, 13 Jul 2019 18:37:18 +0000 - rev 482718
Push 113682 by aiakab@mozilla.com at Sun, 14 Jul 2019 09:47:29 +0000
Bug 1478156 - Move shareable focus methods to be used for color picker accessibility, r=yzen,gl Differential Revision: https://phabricator.services.mozilla.com/D33885
a363971fffb024000ef3d6bdb4f34c1980d9bfa2: Bug 1478156 - Add contrast ratio annotation title and info link to color picker, r=yzen,gl
Maliha Islam <mislam@mozilla.com> - Sat, 13 Jul 2019 18:37:06 +0000 - rev 482717
Push 113682 by aiakab@mozilla.com at Sun, 14 Jul 2019 09:47:29 +0000
Bug 1478156 - Add contrast ratio annotation title and info link to color picker, r=yzen,gl Differential Revision: https://phabricator.services.mozilla.com/D32842
314855eab887413961b82229d38d8e33a3cb03c2: Bug 1478156 - Add color contrast span to color picker, r=yzen,gl
Maliha Islam <mislam@mozilla.com> - Sat, 13 Jul 2019 18:36:54 +0000 - rev 482716
Push 113682 by aiakab@mozilla.com at Sun, 14 Jul 2019 09:47:29 +0000
Bug 1478156 - Add color contrast span to color picker, r=yzen,gl Differential Revision: https://phabricator.services.mozilla.com/D32491
041f51c9d4d1819ca15a74481b5c954aa4d17557: Bug 1478156 - Move shared code to be used by color contrast feature, r=yzen,gl
Maliha Islam <mislam@mozilla.com> - Sat, 13 Jul 2019 18:36:41 +0000 - rev 482715
Push 113682 by aiakab@mozilla.com at Sun, 14 Jul 2019 09:47:29 +0000
Bug 1478156 - Move shared code to be used by color contrast feature, r=yzen,gl Differential Revision: https://phabricator.services.mozilla.com/D32490
bf25c3b58362c73e91a1587c1caaeb33f70de53b: Bug 1564299: Fire a reorder event on the outer doc accessible when an OOP document gets added. r=yzen
James Teh <jteh@mozilla.com> - Wed, 10 Jul 2019 12:59:21 +0000 - rev 482282
Push 113660 by opoprus@mozilla.com at Thu, 11 Jul 2019 10:01:33 +0000
Bug 1564299: Fire a reorder event on the outer doc accessible when an OOP document gets added. r=yzen For same-process iframe documents, this reorder event is fired by the content process. This isn't possible when the document is in a different process to its embedder. In this case, we need to fire it from the parent process when the embedded document accessible is added. Differential Revision: https://phabricator.services.mozilla.com/D37352
e00934d477363c275f103a82d96020696b0469d6: Bug 1562208: Don't assume that a child DocAccessibleParent is for a different process to its parent because there is a BrowserBridgeParent. r=yzen
James Teh <jteh@mozilla.com> - Tue, 09 Jul 2019 00:56:56 +0000 - rev 481776
Push 113636 by rgurzau@mozilla.com at Tue, 09 Jul 2019 10:11:06 +0000
Bug 1562208: Don't assume that a child DocAccessibleParent is for a different process to its parent because there is a BrowserBridgeParent. r=yzen Previously, DocAccessibleParent::AddChildDoc used the presence of a BrowserBridgeParent to determine whether the child document was in a different process to the parent document. While this is normally the case, there can be a point while the embedded document is loading where there is a temporary document in the same (embedder) process. In this case, we tried to get the COM proxy for the child document. For a child document in the same process, this isn't available yet, so this caused infinite recursion (stack overflow) in ProxyAccessible::GetCOMInterface. Instead of using the presence of BrowserBridgeParent, first check whether the child document is at the top level of its content process. If it isn't, the document is in the same process as its parent. Also, add a DIAGNOSTIC_ASSERT to ProxyAccessible::GetCOMInterface which will fire if no COM proxy or MSAA child id has been set. Previously, we just recursed infinitely and overflowed the stack in this case, which is painful to debug. Differential Revision: https://phabricator.services.mozilla.com/D37344