searching for reviewer(tnikkel)
02d9dc4d39a56b6b660aa2689c689f3bf9172d95: Bug 1551088 - Part 8. Add reftest annotations for slight premultiplication differences. r=tnikkel
Andrew Osmond <aosmond@mozilla.com> - Fri, 20 Sep 2019 18:54:04 +0000 - rev 494410
Push 114117 by shindli@mozilla.com at Sat, 21 Sep 2019 21:52:18 +0000
Bug 1551088 - Part 8. Add reftest annotations for slight premultiplication differences. r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D46451
d7684ca35c0d675fdb798771c062b8e5167d0434: Bug 1551088 - Part 7. Add gtests for SwizzleFilter. r=tnikkel
Andrew Osmond <aosmond@mozilla.com> - Fri, 20 Sep 2019 18:53:56 +0000 - rev 494409
Push 114117 by shindli@mozilla.com at Sat, 21 Sep 2019 21:52:18 +0000
Bug 1551088 - Part 7. Add gtests for SwizzleFilter. r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D46450
b061b1bf8281f12698282b6fe5c6f48ef1146253: Bug 1551088 - Part 6. Make image decoders use accelerated methods for swizzling and premultiplication. r=tnikkel
Andrew Osmond <aosmond@mozilla.com> - Sat, 21 Sep 2019 07:13:45 +0000 - rev 494408
Push 114117 by shindli@mozilla.com at Sat, 21 Sep 2019 21:52:18 +0000
Bug 1551088 - Part 6. Make image decoders use accelerated methods for swizzling and premultiplication. r=tnikkel The PNG decoder lacks fast implementations for swizzling/unpacking inside the library, and both PNG and WebP may need to perform premultiplication due to the alpha channel. This patch adds a new filter allowing us to take advantage of our accelerated implementations to perform these transformations on their behalf. Differential Revision: https://phabricator.services.mozilla.com/D46449
4760b8b22ffd4b549100a2a29ee666a9d9b6000c: Bug 1551088 - Part 5. Expose SurfaceFilter input row directly to avoid copy if possible. r=tnikkel
Andrew Osmond <aosmond@mozilla.com> - Fri, 20 Sep 2019 19:36:00 +0000 - rev 494407
Push 114117 by shindli@mozilla.com at Sat, 21 Sep 2019 21:52:18 +0000
Bug 1551088 - Part 5. Expose SurfaceFilter input row directly to avoid copy if possible. r=tnikkel Some filters can do the copy of the given data into the working buffer as part of the filter operation. For those that cannot, we will just copy the data first, and then advance the row. Differential Revision: https://phabricator.services.mozilla.com/D46448
21e02b122b3d868a340e4f23cfb24249544694e3: Bug 1541256 - Tests for elements' accessibility states in out-of-process iframes in a deck. r=tnikkel,surkov
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Fri, 20 Sep 2019 11:33:00 +0000 - rev 494293
Push 114114 by dluca@mozilla.com at Fri, 20 Sep 2019 22:00:08 +0000
Bug 1541256 - Tests for elements' accessibility states in out-of-process iframes in a deck. r=tnikkel,surkov Differential Revision: https://phabricator.services.mozilla.com/D44951
d0b93d0ae65d692bbcb88aec947ac56dd5a3a7a3: Bug 1541256 - Returns an empty screen rect from GetFrameVisibleRectOnScreen if the given nsIFrame is in out-of-process even if the corresponding iframe is totally invisbile. r=tnikkel
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Fri, 20 Sep 2019 11:33:00 +0000 - rev 494292
Push 114114 by dluca@mozilla.com at Fri, 20 Sep 2019 22:00:08 +0000
Bug 1541256 - Returns an empty screen rect from GetFrameVisibleRectOnScreen if the given nsIFrame is in out-of-process even if the corresponding iframe is totally invisbile. r=tnikkel We need to distinguish between the out-of-process iframe is totally invisible and the given nsIFrame is not in out-of-process iframes. Differential Revision: https://phabricator.services.mozilla.com/D46553
691c50b5729af881fff324bf68b739a3b8da5518: Bug 1541256 - Tests for elements' accessibility states in out-of-process iframes in a deck. r=tnikkel,surkov
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Fri, 20 Sep 2019 11:33:00 +0000 - rev 494271
Push 114114 by dluca@mozilla.com at Fri, 20 Sep 2019 22:00:08 +0000
Bug 1541256 - Tests for elements' accessibility states in out-of-process iframes in a deck. r=tnikkel,surkov Differential Revision: https://phabricator.services.mozilla.com/D44951
fc785139655e3d22d681f1419bd4c80f93460f0e: Bug 1541256 - Returns an empty screen rect from GetFrameVisibleRectOnScreen if the given nsIFrame is in out-of-process even if the corresponding iframe is totally invisbile. r=tnikkel
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Fri, 20 Sep 2019 11:33:00 +0000 - rev 494270
Push 114114 by dluca@mozilla.com at Fri, 20 Sep 2019 22:00:08 +0000
Bug 1541256 - Returns an empty screen rect from GetFrameVisibleRectOnScreen if the given nsIFrame is in out-of-process even if the corresponding iframe is totally invisbile. r=tnikkel We need to distinguish between the out-of-process iframe is totally invisible and the given nsIFrame is not in out-of-process iframes. Differential Revision: https://phabricator.services.mozilla.com/D46553
bb47781a80b9ef1d02f0d59e35c587716ccdb6e5: Bug 1564195 - Add a GTest to test correct setting of the mHitRegionWithApzAwareListeners flags. r=tnikkel
Botond Ballo <botond@mozilla.com> - Thu, 19 Sep 2019 03:05:05 +0000 - rev 494047
Push 114104 by opoprus@mozilla.com at Thu, 19 Sep 2019 10:02:13 +0000
Bug 1564195 - Add a GTest to test correct setting of the mHitRegionWithApzAwareListeners flags. r=tnikkel Depends on D46377 Differential Revision: https://phabricator.services.mozilla.com/D46378
71bd580326950fb37bb5f419972a8f4f18ed77d7: Bug 1564195 - Add a flag to APZEventResult indicating whether the event hit a region with APZ-aware listeners. r=tnikkel
Botond Ballo <botond@mozilla.com> - Thu, 19 Sep 2019 02:55:35 +0000 - rev 494046
Push 114104 by opoprus@mozilla.com at Thu, 19 Sep 2019 10:02:13 +0000
Bug 1564195 - Add a flag to APZEventResult indicating whether the event hit a region with APZ-aware listeners. r=tnikkel This is currently only populated for touch events. Depends on D46376 Differential Revision: https://phabricator.services.mozilla.com/D46377
ffc0e1cd529761f99a74914150f84e2320cecb22: Bug 1564195 - Group the results of APZInputBridge::ReceiveInputEvent() into a struct. r=tnikkel
Botond Ballo <botond@mozilla.com> - Thu, 19 Sep 2019 02:45:21 +0000 - rev 494045
Push 114104 by opoprus@mozilla.com at Thu, 19 Sep 2019 10:02:13 +0000
Bug 1564195 - Group the results of APZInputBridge::ReceiveInputEvent() into a struct. r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D46376
504f24d7331637bcaea72ff6dcf1ae38588defb5: Bug 1578777 - Use UsesSVGEffectsNotSupportedInCompositor() in ShouldBuildScrollInfoItemsForHoisting(). r=tnikkel
Botond Ballo <botond@mozilla.com> - Tue, 17 Sep 2019 00:06:30 +0000 - rev 493463
Push 114090 by rgurzau@mozilla.com at Tue, 17 Sep 2019 09:38:30 +0000
Bug 1578777 - Use UsesSVGEffectsNotSupportedInCompositor() in ShouldBuildScrollInfoItemsForHoisting(). r=tnikkel This required replacing nsDisplayListBuilder::mSVGEffectsBuildingDepth with a stack of the SVG effects frames that we're currently building inside. Depends on D46063 Differential Revision: https://phabricator.services.mozilla.com/D46064
b3d7b5f40cf7d8700a7521c30948fac5dae46a48: Bug 1578777 - Move UsesSVGEffectsNotSupportedInCompositor() to nsSVGIntegrationUtils. r=tnikkel
Botond Ballo <botond@mozilla.com> - Tue, 17 Sep 2019 00:06:28 +0000 - rev 493462
Push 114090 by rgurzau@mozilla.com at Tue, 17 Sep 2019 09:38:30 +0000
Bug 1578777 - Move UsesSVGEffectsNotSupportedInCompositor() to nsSVGIntegrationUtils. r=tnikkel Depends on D46061 Differential Revision: https://phabricator.services.mozilla.com/D46063
c278c4ce9447c6f51dc1c9ab12b0ccd59a381d43: Bug 1578777 - Use CanCreateWebRenderFiltersForFrame() in ScrollFrameWillBuildScrollInfoLayer(). r=tnikkel
Botond Ballo <botond@mozilla.com> - Tue, 17 Sep 2019 00:05:02 +0000 - rev 493461
Push 114090 by rgurzau@mozilla.com at Tue, 17 Sep 2019 09:38:30 +0000
Bug 1578777 - Use CanCreateWebRenderFiltersForFrame() in ScrollFrameWillBuildScrollInfoLayer(). r=tnikkel Depends on D46060 Differential Revision: https://phabricator.services.mozilla.com/D46061
c0797e496fd9637cb288246f602029fa7ef95b64: Bug 1577859 - Additional post container scrolling removal cleanup in APZ code. r=tnikkel
Botond Ballo <botond@mozilla.com> - Sun, 15 Sep 2019 23:34:13 +0000 - rev 493373
Push 114089 by shindli@mozilla.com at Tue, 17 Sep 2019 04:39:17 +0000
Bug 1577859 - Additional post container scrolling removal cleanup in APZ code. r=tnikkel With container scrolling, layers that are fixed wrt. the RCD-RSF are no longer descendants of layers with RCD-RSF metadata. This allows us to remove some code that handles this case in AsyncCompositionManager. In particular, when ApplyAsyncContentTransformToTree() calls AlignFixedAndStickyLayers(): - If we are currently processing a layer with RCD-RSF metadata, AlignFixedAndStickyLayers() will not do anything (because there will be no descendants fixed wrt. the RCD-RSF), so it doesn't matter what transform we pass to AlignFixedAndStickyLayers(). - If we are processing a different layer, then Metrics().IsRootContent() will be false, so GetCurrentAsyncTransformForFixedAdjustment() simplifies to just GetCurrentAsyncTransform(). As a result, GetCurrentAsyncTransformForFixedAdjustment() (and its helper GetCurrentAsyncViewportTransform()) can be removed, and its use replaced with GetCurrentAsyncTransform(). Differential Revision: https://phabricator.services.mozilla.com/D45595
e291531d8dbe1314e83e821ede5aaf67ca345fcc: Bug 1577859 - Stop handling scrollbar layers that are descendants of the scrolled content. r=tnikkel
Botond Ballo <botond@mozilla.com> - Sun, 15 Sep 2019 21:50:10 +0000 - rev 493372
Push 114089 by shindli@mozilla.com at Tue, 17 Sep 2019 04:39:17 +0000
Bug 1577859 - Stop handling scrollbar layers that are descendants of the scrolled content. r=tnikkel With containerless scrolling, scrollbar layers and their target scrolled layers will be in sibling subtrees. Depends on D45596 Differential Revision: https://phabricator.services.mozilla.com/D45918
c42f6c24277685fa7592a6ce596144289506bdaa: Bug 1581137 - Allow one frameUpdate observation for the animated image which is out of the display port for now. r=tnikkel
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Sun, 15 Sep 2019 22:03:07 +0000 - rev 493299
Push 114087 by csabou@mozilla.com at Mon, 16 Sep 2019 09:47:02 +0000
Bug 1581137 - Allow one frameUpdate observation for the animated image which is out of the display port for now. r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D45945
0ece55dd71472c1af519a34cefa840ce86970c51: Bug 1577859 - Additional post container scrolling removal cleanup in Layout code. r=tnikkel
Botond Ballo <botond@mozilla.com> - Sun, 15 Sep 2019 21:51:41 +0000 - rev 493298
Push 114087 by csabou@mozilla.com at Mon, 16 Sep 2019 09:47:02 +0000
Bug 1577859 - Additional post container scrolling removal cleanup in Layout code. r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D45596
286cbc3b542b29210b9d7a4b5678adcac9211962: Bug 1577859 - Remove the layout.scroll.root-frame-containers pref and code that depends directly on it. r=tnikkel
Botond Ballo <botond@mozilla.com> - Sun, 15 Sep 2019 17:01:22 +0000 - rev 493295
Push 114086 by aciure@mozilla.com at Sun, 15 Sep 2019 21:45:19 +0000
Bug 1577859 - Remove the layout.scroll.root-frame-containers pref and code that depends directly on it. r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D45198
fd34209bdecb327b012f1457fc1922c93c940a5b: Bug 1581233 - Add a helper function to reduce repetition at the call sites of HitTestingTreeNode::SetHitTestData(). r=tnikkel
Botond Ballo <botond@mozilla.com> - Sat, 14 Sep 2019 09:01:22 +0000 - rev 493266
Push 114084 by btara@mozilla.com at Sat, 14 Sep 2019 21:30:15 +0000
Bug 1581233 - Add a helper function to reduce repetition at the call sites of HitTestingTreeNode::SetHitTestData(). r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D45916
276f16496517ee8c6cd8b30d44dced6ec7d8f604: Bug 1580703 - Use wider spacers to ensure that the given scroll position is outside of the display port. r=tnikkel
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Fri, 13 Sep 2019 10:18:08 +0000 - rev 493025
Push 114081 by btara@mozilla.com at Fri, 13 Sep 2019 15:49:27 +0000
Bug 1580703 - Use wider spacers to ensure that the given scroll position is outside of the display port. r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D45814
2407a61b4a61fb7c4a7deb8efda34a79682633bc: Bug 1552317 - Fix codespell errors for image/. r=tnikkel
championshuttler <shivams2799@gmail.com> - Thu, 12 Sep 2019 09:00:52 +0000 - rev 492884
Push 114078 by nerli@mozilla.com at Thu, 12 Sep 2019 22:41:47 +0000
Bug 1552317 - Fix codespell errors for image/. r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D45553
4880c3a309c94ca37d75e5d356be20a5937d7ae5: Bug 1541705 - Test for offscreen image in out-of-process iframe. r=tnikkel
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Thu, 12 Sep 2019 08:09:34 +0000 - rev 492814
Push 114076 by ncsoregi@mozilla.com at Thu, 12 Sep 2019 15:29:15 +0000
Bug 1541705 - Test for offscreen image in out-of-process iframe. r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D44424
7b6c7a490d9f76c0375807d304d5b04357bf4df4: Bug 1570559 - Add a gtest. r=tnikkel
Botond Ballo <botond@mozilla.com> - Fri, 06 Sep 2019 22:10:03 +0000 - rev 492136
Push 114043 by rmaries@mozilla.com at Sun, 08 Sep 2019 09:49:14 +0000
Bug 1570559 - Add a gtest. r=tnikkel Depends on D45083 Differential Revision: https://phabricator.services.mozilla.com/D45084
95f44aea61ebfd9261e8d2874adcd3a7c384aea5: Bug 1570559 - Move helper functions that are only used in TestTreeManager.cpp into that file. r=tnikkel
Botond Ballo <botond@mozilla.com> - Fri, 06 Sep 2019 22:03:45 +0000 - rev 492135
Push 114043 by rmaries@mozilla.com at Sun, 08 Sep 2019 09:49:14 +0000
Bug 1570559 - Move helper functions that are only used in TestTreeManager.cpp into that file. r=tnikkel Depends on D45082 Differential Revision: https://phabricator.services.mozilla.com/D45083
61cedc44f752540e3472a358e3b18bdfe9485071: Bug 1570559 - Add a helper function APZCTreeManagerTester::UpdateHitTestingTree(). r=tnikkel
Botond Ballo <botond@mozilla.com> - Fri, 06 Sep 2019 22:03:43 +0000 - rev 492134
Push 114043 by rmaries@mozilla.com at Sun, 08 Sep 2019 09:49:14 +0000
Bug 1570559 - Add a helper function APZCTreeManagerTester::UpdateHitTestingTree(). r=tnikkel Depends on D44712 Differential Revision: https://phabricator.services.mozilla.com/D45082
bea7e40d295e91df0f64f9297c9f1469708b00b8: Bug 1570559 - When the target APZC changes mid-gesture, always clear the old APZC's gesture state. r=tnikkel
Botond Ballo <botond@mozilla.com> - Fri, 06 Sep 2019 21:23:23 +0000 - rev 492133
Push 114043 by rmaries@mozilla.com at Sun, 08 Sep 2019 09:49:14 +0000
Bug 1570559 - When the target APZC changes mid-gesture, always clear the old APZC's gesture state. r=tnikkel Previously we were only doing this if content wasn't prevent-defaulting the events targeting the new APZC. Differential Revision: https://phabricator.services.mozilla.com/D44712
8d7284764bd66ba04710d5296357db5bd5206810: Bug 1576524 - Clean up APZCTreeManager::mDetachedLayersIds in UpdateHitTestingTree. r=tnikkel
Botond Ballo <botond@mozilla.com> - Fri, 06 Sep 2019 08:39:52 +0000 - rev 492035
Push 114040 by ncsoregi@mozilla.com at Sat, 07 Sep 2019 09:47:24 +0000
Bug 1576524 - Clean up APZCTreeManager::mDetachedLayersIds in UpdateHitTestingTree. r=tnikkel This ensures that mDetachedLayersIds doesn't grow indefinitely. Differential Revision: https://phabricator.services.mozilla.com/D44741
bc384b89c51f57e71943b3e05236ff343c7a4dc8: Bug 1576524 - Have APZCTreeManager track a set of layers ids for which it should not send MatrixMessages. r=tnikkel,hsivonen
Botond Ballo <botond@mozilla.com> - Fri, 06 Sep 2019 08:28:36 +0000 - rev 492034
Push 114040 by ncsoregi@mozilla.com at Sat, 07 Sep 2019 09:47:24 +0000
Bug 1576524 - Have APZCTreeManager track a set of layers ids for which it should not send MatrixMessages. r=tnikkel,hsivonen Differential Revision: https://phabricator.services.mozilla.com/D44740
98bdc3047120ee9d3700f4c13bc09b0db585c58f: Bug 1577867 - Remove using namespace std from image/ r=tnikkel
Eric Rahm <erahm@mozilla.com> - Fri, 30 Aug 2019 19:58:25 +0000 - rev 490974
Push 114010 by dluca@mozilla.com at Sat, 31 Aug 2019 09:58:00 +0000
Bug 1577867 - Remove using namespace std from image/ r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D44250
4229066f494382b9c779c8a2db1c0582305193a4: Bug 1574100 - For RefLayers with multiple metrics, only expose the event regions override for the bottom one. r=tnikkel
Botond Ballo <botond@mozilla.com> - Fri, 16 Aug 2019 20:23:11 +0000 - rev 488608
Push 113914 by nbeleuzu@mozilla.com at Sat, 17 Aug 2019 21:54:15 +0000
Bug 1574100 - For RefLayers with multiple metrics, only expose the event regions override for the bottom one. r=tnikkel We only want the bottom LayerMetricsWrapper / WebRenderScrollDataWrapper to be treated as a ref layer, and only ref layers have event regions overrides. Differential Revision: https://phabricator.services.mozilla.com/D42339
87ed773c0a80425133bae39146f06de4a7425974: Bug 1554777 - Use SIZE_AVAILABLE rather than loaded to figure out whether to try to draw a border image. r=tnikkel
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 15 Aug 2019 19:03:06 +0000 - rev 488483
Push 113910 by ccoroiu@mozilla.com at Fri, 16 Aug 2019 16:28:54 +0000
Bug 1554777 - Use SIZE_AVAILABLE rather than loaded to figure out whether to try to draw a border image. r=tnikkel The current code needs to handle incomplete draws already due to async decoding, and this prevents the race condition where we paint between the size-available and load notifications, as the CSS image loader only invalidates for the first. Once we try to decode the image at least once, then we'd repaint properly from ImageLoader::OnFrameComplete. Differential Revision: https://phabricator.services.mozilla.com/D41006
da9ae31b5000eccbc38438680952ff08d06addea: Bug 1554777 - Call SchedulePaint() rather than MarkNeedsDisplayItemRebuild() when we get the size available notification for a style image. r=mattwoodrow,tnikkel
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 15 Aug 2019 19:03:18 +0000 - rev 488482
Push 113910 by ccoroiu@mozilla.com at Fri, 16 Aug 2019 16:28:54 +0000
Bug 1554777 - Call SchedulePaint() rather than MarkNeedsDisplayItemRebuild() when we get the size available notification for a style image. r=mattwoodrow,tnikkel So the issue here is that this test-case has a zero-sized border, but still with a border-image (which we should paint). So the first time we get here, the image is not loaded, and thus we don't get here: https://searchfox.org/mozilla-central/rev/e0b0c38ee83f99d3cf868bad525ace4a395039f1/layout/painting/nsDisplayList.h#4254 Which means that we end up with zero bounds and thus we don't even get to the border painting code. However, when the image loads, we get to MarkNeedsDisplayItemRebuild(), but that doesn't schedule any paint, only marks the frames as modified in order for display items to be rebuilt _eventually_. Thus eventually, where we force a repaint by other means, we paint correctly. This only works in more general cases because we get to the nsImageRenderer code which does vastly different stuff. InvalidateFrame() seems to do the right thing and schedule a paint, so use it. It's not clear to me which one of nsIFrame::InvalidateFrame() or nsIFrame::SchedulePaint() we should use... If I understand correctly, InvalidateFrame() will only do something iff there are display items for the frame, so that should make the IsVisible() check redundant. Note however that I think there's still a race condition, if we get to paint in between the SIZE_AVAILABLE notification (the one where we actually invalidate the display items), and the LOAD notification (the one the border-image code checks). I'll send a separate patch for that, I think SIZE_AVAILABLE should be a strong-enough hint and that allows us to remove nsStyleImage::IsLoaded()... The RequestReflow stuff also looks highly suspicious... shape-outside sync-decodes, and it seems we could end up invalidating reflow from the reflow code... Differential Revision: https://phabricator.services.mozilla.com/D41005
06f8821f01d76796f68138977c00f953756c7aed: Bug 1508177 - Use expanded layout viewport height to tell whether we need to render the vertical overlay scrollbar. r=tnikkel
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Tue, 13 Aug 2019 22:38:01 +0000 - rev 487820
Push 113885 by dvarga@mozilla.com at Wed, 14 Aug 2019 04:13:43 +0000
Bug 1508177 - Use expanded layout viewport height to tell whether we need to render the vertical overlay scrollbar. r=tnikkel In the previous commit, we expanded layout viewport height but during reflow the expanded layout viewport size hasn't reflected in ScrollReflowInput::mContentsOverflowAreas.ScrollableOverflow(). We explicitly need to use the expanded height to tell whether we need vertical vertical scrollbars or not. Note that the expanded layout viewport height should NOT be used for non-overlay scrollbars cases since, for example, if the content width is specified by `width: 100%`, the non-overlay vertical scrollbar narrows down the content's used width a little bit because of the vertical scrollbar width, which in turn the minimum scale gets bigger because the content's width became bit narrower, thus the layout viewport size calculated with the minimum scale gets smaller, then it results the vertical scrollbar no longer needs to be rendered, thus the minimum scale gets back to the original value, then the vertical scroll needs to be rendered again, thus this sequence of processes happens repreatedly. Differential Revision: https://phabricator.services.mozilla.com/D40772
156532527ac93f32ef438c4ef129930bed4cb9d3: Bug 1508177 - Reftests that check scrollbars are properly appeared by the difference between visual and layout viewports. r=botond,tnikkel
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Tue, 13 Aug 2019 22:37:54 +0000 - rev 487818
Push 113885 by dvarga@mozilla.com at Wed, 14 Aug 2019 04:13:43 +0000
Bug 1508177 - Reftests that check scrollbars are properly appeared by the difference between visual and layout viewports. r=botond,tnikkel scrollbars-in-landscape-content.html doesn't fail on environments where we don't use overlay scrollbars because scrollbars for the visual viewport are not rendered there. Differential Revision: https://phabricator.services.mozilla.com/D40770
2c35163a7686b9caa9f5e608f8c7cbc2d3249cc7: Bug 1528775 - Disable immediate handoff on all platforms. r=tnikkel
Botond Ballo <botond@mozilla.com> - Fri, 09 Aug 2019 19:45:57 +0000 - rev 487297
Push 113869 by ncsoregi@mozilla.com at Sat, 10 Aug 2019 21:42:30 +0000
Bug 1528775 - Disable immediate handoff on all platforms. r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D41434
ea97d944e1a74e99e39350cb2d733eefab437c5e: Bug 1565512 - Ensure the RCD-RSF callback transform is applied for events targeting fixed content too. r=tnikkel
Botond Ballo <botond@mozilla.com> - Sat, 03 Aug 2019 16:16:56 +0000 - rev 486094
Push 113829 by dvarga@mozilla.com at Sat, 03 Aug 2019 22:20:04 +0000
Bug 1565512 - Ensure the RCD-RSF callback transform is applied for events targeting fixed content too. r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D40535
dfa76bace85c114f9a410785b289b4fa630a01cd: Bug 1558915 - Use infallible nsIURI::SchemeIs in image/ r=tnikkel
Tom Schuster <evilpies@gmail.com> - Sat, 03 Aug 2019 09:44:12 +0000 - rev 486088
Push 113829 by dvarga@mozilla.com at Sat, 03 Aug 2019 22:20:04 +0000
Bug 1558915 - Use infallible nsIURI::SchemeIs in image/ r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D40459
39ff0262a9d103575fa22c3f72ee2ff26e31b917: Bug 1568826 - Restrict the fix for bug 1549625 to cases where we have a zoomable viewport. r=tnikkel
Botond Ballo <botond@mozilla.com> - Fri, 02 Aug 2019 20:31:57 +0000 - rev 486050
Push 113827 by btara@mozilla.com at Sat, 03 Aug 2019 09:54:50 +0000
Bug 1568826 - Restrict the fix for bug 1549625 to cases where we have a zoomable viewport. r=tnikkel The fix for bug 1549625 is only necessary in cases where the layout and visual viewports can diverge (currently mobile, and later desktop zooming), but it has caused regressions in desktop scenarios that don't involve zooming. While we can get a proper fix in place (tracked in bug 1543485), restricting the existing fix to zoomable configurations mitigates the regressions. Differential Revision: https://phabricator.services.mozilla.com/D40473
31c85754cf9441246e506fe95f64908638d7f22a: Bug 1569772 - Release load group on main thread in win/nsIconChannel r=tnikkel
Junior Hsu <juhsu@mozilla.com> - Mon, 29 Jul 2019 22:42:39 +0000 - rev 485227
Push 113800 by apavel@mozilla.com at Tue, 30 Jul 2019 10:43:19 +0000
Bug 1569772 - Release load group on main thread in win/nsIconChannel r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D39795
0dd8f624159efc3b9ef7333e29ee0785a1a8a39f: Bug 1563717 - Mark pinch-zoom-position-sticky.html as failing on webrender. r=tnikkel
Botond Ballo <botond@mozilla.com> - Sat, 27 Jul 2019 02:31:37 +0000 - rev 484990
Push 113786 by dvarga@mozilla.com at Sat, 27 Jul 2019 09:34:13 +0000
Bug 1563717 - Mark pinch-zoom-position-sticky.html as failing on webrender. r=tnikkel WebRender handling of position:sticky is buggy in the presence of zooming. The fix for bug 1563717 exposes this bug in pinch-zoom-position-sticky.html. Differential Revision: https://phabricator.services.mozilla.com/D39574
0c3bcd3598fffa21e9cb612a1b9d267db2d4e03e: Bug 1566411 Use ReferrerInfo class in imgLoader.idl r=tnikkel
Thomas Nguyen <tnguyen@mozilla.com> - Thu, 25 Jul 2019 08:23:32 +0000 - rev 484691
Push 113779 by aciure@mozilla.com at Thu, 25 Jul 2019 16:24:54 +0000
Bug 1566411 Use ReferrerInfo class in imgLoader.idl r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D38177
d3b65ecc2afb84a09d2728a04a14ac6bf68028ce: Bug 1567237 - Only use scroll range to select scrollable frames to scroll to, don't use scrollbar visibility. r=tnikkel
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 24 Jul 2019 22:33:57 +0000 - rev 484621
Push 113775 by aciure@mozilla.com at Thu, 25 Jul 2019 06:34:07 +0000
Bug 1567237 - Only use scroll range to select scrollable frames to scroll to, don't use scrollbar visibility. r=tnikkel This is what other browsers do, and it does make sense to me, it's useless to try to scroll a frame with no scroll range in a given direction. I think all callers of this function should be treated like this, so this is more like a RFC / feedback request than a patch per se. The wheel handling code already checks scroll range, so there's no difference of behavior in that case, if I'm reading the code right. There are a few other functions that check the result of GetPerceivedScrollingDirections(), but I think if we change this we should change this consistently. I also think that if we do this we should rename the method to something like GetAvailableScrollingDirections() or such. Anyhow, wdyt? I should also add a test for this if we go with this. Differential Revision: https://phabricator.services.mozilla.com/D38991
2fe42a3dda2c3a72f5ed829ba145cfce4a242752: Bug 1567237 - Only use scroll range to select scrollable frames to scroll to, don't use scrollbar visibility. r=tnikkel
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 24 Jul 2019 13:17:11 +0000 - rev 484530
Push 113775 by aciure@mozilla.com at Thu, 25 Jul 2019 06:34:07 +0000
Bug 1567237 - Only use scroll range to select scrollable frames to scroll to, don't use scrollbar visibility. r=tnikkel This is what other browsers do, and it does make sense to me, it's useless to try to scroll a frame with no scroll range in a given direction. I think all callers of this function should be treated like this, so this is more like a RFC / feedback request than a patch per se. The wheel handling code already checks scroll range, so there's no difference of behavior in that case, if I'm reading the code right. There are a few other functions that check the result of GetPerceivedScrollingDirections(), but I think if we change this we should change this consistently. I also think that if we do this we should rename the method to something like GetAvailableScrollingDirections() or such. Anyhow, wdyt? I should also add a test for this if we go with this. Differential Revision: https://phabricator.services.mozilla.com/D38991
5d602a56edc7a081f6a62ae41bcbf9540ddcb3fc: Bug 1567237 - Only use scroll range to select scrollable frames to scroll to, don't use scrollbar visibility. r=tnikkel
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 23 Jul 2019 22:04:31 +0000 - rev 483924
Push 113759 by malexandru@mozilla.com at Wed, 24 Jul 2019 09:58:20 +0000
Bug 1567237 - Only use scroll range to select scrollable frames to scroll to, don't use scrollbar visibility. r=tnikkel This is what other browsers do, and it does make sense to me, it's useless to try to scroll a frame with no scroll range in a given direction. I think all callers of this function should be treated like this, so this is more like a RFC / feedback request than a patch per se. The wheel handling code already checks scroll range, so there's no difference of behavior in that case, if I'm reading the code right. There are a few other functions that check the result of GetPerceivedScrollingDirections(), but I think if we change this we should change this consistently. I also think that if we do this we should rename the method to something like GetAvailableScrollingDirections() or such. Anyhow, wdyt? I should also add a test for this if we go with this. Differential Revision: https://phabricator.services.mozilla.com/D38991
a37238f046d563fee862b36231ecbfd1ee18b0d8: Bug 1528180 - Don't align scroll offsets to layer pixels when using WebRender. r=tnikkel
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 12 Jul 2019 20:04:16 +0000 - rev 482657
Push 113678 by csabou@mozilla.com at Sat, 13 Jul 2019 10:07:02 +0000
Bug 1528180 - Don't align scroll offsets to layer pixels when using WebRender. r=tnikkel This position is only invalidated from FrameLayerBuilder, that's not a very good signal. This would get out of sync when using WebRender, and APZ messages will send sub-pixel scroll positions that will get wrongly adjusted, causing small scroll offsets which scroll anchoring would incorrectly try to correct, which is the ultimate cause of the jittering. Differential Revision: https://phabricator.services.mozilla.com/D37875
bc634ddca05b04dfcf2572b382b232077fc1f5dd: Bug 1565056, merge ImgDecoder and mozStorage threads in THREAD_WAKEUP telemetry, r=tnikkel,asuth
Olli Pettay <Olli.Pettay@helsinki.fi> - Thu, 11 Jul 2019 04:03:44 +0000 - rev 482370
Push 113664 by cbrindusan@mozilla.com at Thu, 11 Jul 2019 16:24:25 +0000
Bug 1565056, merge ImgDecoder and mozStorage threads in THREAD_WAKEUP telemetry, r=tnikkel,asuth Differential Revision: https://phabricator.services.mozilla.com/D37643
ff23369d071869072c56646034cd0411cb346a85: Bug 1553012 - Make PresShell::ScrollFrameRectIntoView work in fission world. r=mattwoodrow,nika,tnikkel
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Tue, 09 Jul 2019 05:34:27 +0000 - rev 481829
Push 113641 by rgurzau@mozilla.com at Tue, 09 Jul 2019 16:13:03 +0000
Bug 1553012 - Make PresShell::ScrollFrameRectIntoView work in fission world. r=mattwoodrow,nika,tnikkel Differential Revision: https://phabricator.services.mozilla.com/D36136
13557cb78993a31ebdb850e0076efc3a4a3dfdcb: Bug 1561726 - Add an nsIDOMWindowUtils API for querying the size of layout scrollbars. r=tnikkel
Botond Ballo <botond@mozilla.com> - Fri, 28 Jun 2019 20:22:49 +0000 - rev 480631
Push 113561 by ncsoregi@mozilla.com at Sat, 29 Jun 2019 10:06:30 +0000
Bug 1561726 - Add an nsIDOMWindowUtils API for querying the size of layout scrollbars. r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D34257
6d20bab59174d90c2f8b209500648ea73e0f06f1: Bug 1561726 - Add an nsIContent overload of nsLayoutUtils::FindScrollableFrameFor. r=tnikkel
Botond Ballo <botond@mozilla.com> - Fri, 28 Jun 2019 20:22:37 +0000 - rev 480630
Push 113561 by ncsoregi@mozilla.com at Sat, 29 Jun 2019 10:06:30 +0000
Bug 1561726 - Add an nsIContent overload of nsLayoutUtils::FindScrollableFrameFor. r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D34256