searching for reviewer(snorp)
a53d575c3889ad038d85ccc7b1a496b799377b6d: Bug 1554260 - Send WebExtension Page messages to GeckoSession. r=snorp
Agi Sferro <agi@sferro.dev> - Mon, 10 Jun 2019 20:09:25 +0000 - rev 478137
Push 113405 by nerli@mozilla.com at Tue, 11 Jun 2019 03:22:35 +0000
Bug 1554260 - Send WebExtension Page messages to GeckoSession. r=snorp WebExtension pages introduce a case that was previously not possible: a script with full WebExtension privileges that runs on a page with a GeckoSession associated to it. This breaks the assumption that all messages from a privileged context don't have a GeckoSession associated to it. We fix this by checking if we can find an eventDispatcher for the given window. This also fixes the test which had the same wrong assumption. Differential Revision: https://phabricator.services.mozilla.com/D32512
2ebc660d70e3d66cc0829dfa2325b4914cf6d885: Bug 1533575 - Simplified GeckoSession.MediaSource.Source constants. r=droeh,geckoview-reviewers,snorp
Alvina Waseem <awaseem@44764.local> - Fri, 07 Jun 2019 18:33:34 +0000 - rev 477912
Push 113386 by nbeleuzu@mozilla.com at Sat, 08 Jun 2019 09:51:50 +0000
Bug 1533575 - Simplified GeckoSession.MediaSource.Source constants. r=droeh,geckoview-reviewers,snorp Differential Revision: https://phabricator.services.mozilla.com/D34010
3648e278fa94836ececa4bfbfbdda9d8711e7031: Bug 1553769 - Have a single way of requesting window focus and switching to a tab. r=NeilDeakin,snorp
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 03 Jun 2019 19:42:28 +0000 - rev 476671
Push 113305 by cbrindusan@mozilla.com at Tue, 04 Jun 2019 03:54:43 +0000
Bug 1553769 - Have a single way of requesting window focus and switching to a tab. r=NeilDeakin,snorp Right now there's some duplicated code with the focus manager and the DOMWindowFocus event. Android didn't handle the new framefocusrequested event, so the test-cases in bug 416771 still didn't work there. I think using the focus manager codepath everywhere is preferable. I confirmed manually that the stuff that sent DOMWindowFocus events still works as expected with this patch (i.e., switching to the right tab when you click on a notification, etc.). This fixes it so that it works in Fennec, and it sends the focus events right in GeckoView Example (i.e., we get here[1] properly). The snippet that Snorp provided on IRC to implement the "bring activity to front" stuff (`startActivity(getIntent())`) didn't actually work for me, but I confirmed that the right message is sent when the focus is requested, and that we get there. [1]: https://searchfox.org/mozilla-central/rev/952521e6164ddffa3f34bc8cfa5a81afc5b859c4/mobile/android/geckoview_example/src/main/java/org/mozilla/geckoview_example/GeckoViewActivity.java#503 Depends on D32353 Differential Revision: https://phabricator.services.mozilla.com/D32354
57e23c9c25d064b9328e08b782e1cd4bed4acb81: Bug 1549519 - Add page reload telemetry probe for geckoview r=bdekoz,geckoview-reviewers,snorp
Sean Feng <sefeng@mozilla.com> - Thu, 30 May 2019 14:37:03 +0000 - rev 476466
Push 113285 by aiakab@mozilla.com at Fri, 31 May 2019 22:31:43 +0000
Bug 1549519 - Add page reload telemetry probe for geckoview r=bdekoz,geckoview-reviewers,snorp Differential Revision: https://phabricator.services.mozilla.com/D32143
4aef15b64c5d2321da9a4a058c428bb0e4ed7ad3: Bug 1508976 - Post: Don't include architecture in multi-architecture GeckoView artifactId. r=snorp
Nick Alexander <nalexander@mozilla.com> - Thu, 30 May 2019 15:22:19 +0000 - rev 476236
Push 113262 by nbeleuzu@mozilla.com at Thu, 30 May 2019 21:52:09 +0000
Bug 1508976 - Post: Don't include architecture in multi-architecture GeckoView artifactId. r=snorp Differential Revision: https://phabricator.services.mozilla.com/D15772
7379601ed10dcaa612f6d5db1d665c55a660311b: Bug 1554693 - Remove unused constants. r=geckoview-reviewers,snorp
Emily Toop <etoop@mozilla.com> - Wed, 29 May 2019 14:57:15 +0000 - rev 476080
Push 113247 by shindli@mozilla.com at Wed, 29 May 2019 21:58:37 +0000
Bug 1554693 - Remove unused constants. r=geckoview-reviewers,snorp This was caused by a rebasing error that was missed. Depends on D32830 Differential Revision: https://phabricator.services.mozilla.com/D32831
71fc0f7a8846bba1a6d81773049b259a9df570ed: Bug 1554778 - Fetch dispatcher at the beginning of `handleRecordingDeviceEvents`. r=geckoview-reviewers,snorp
Emily Toop <etoop@mozilla.com> - Wed, 29 May 2019 14:57:03 +0000 - rev 476079
Push 113247 by shindli@mozilla.com at Wed, 29 May 2019 21:58:37 +0000
Bug 1554778 - Fetch dispatcher at the beginning of `handleRecordingDeviceEvents`. r=geckoview-reviewers,snorp This is because in some circumstances, when navigating away from a page, the dispatcher is no longer present when trying to send the `GeckoView:MediaRecordingStatusChanged` causing the message not to be sent. Fetching the dispatcher earlier ensures that it is present at the point of message sending. Differential Revision: https://phabricator.services.mozilla.com/D32830
80512ab53f44633a3f68544d67bb767b6b5e1d45: Bug 1553515 - Call geckoview.startup on DOMContentLoaded. r=geckoview-reviewers,snorp
Agi Sferro <agi@sferro.dev> - Wed, 29 May 2019 15:11:04 +0000 - rev 476076
Push 113247 by shindli@mozilla.com at Wed, 29 May 2019 21:58:37 +0000
Bug 1553515 - Call geckoview.startup on DOMContentLoaded. r=geckoview-reviewers,snorp Believe it or not this helps with getting PageStop events more reliably. Differential Revision: https://phabricator.services.mozilla.com/D32585
57f0a1d67c3eb45ad02c37451096c6df28dd2c1a: Bug 1554256 - Read GeckoView configuration file in release builds when package is the current Android "debug-app". r=geckoview-reviewers,snorp
Nick Alexander <nalexander@mozilla.com> - Tue, 28 May 2019 22:08:41 +0000 - rev 475999
Push 113240 by nerli@mozilla.com at Wed, 29 May 2019 09:56:33 +0000
Bug 1554256 - Read GeckoView configuration file in release builds when package is the current Android "debug-app". r=geckoview-reviewers,snorp Bug 1533385 taught GeckoView to read configuration from a file. But right now, release APKs don't read that configuration: see the documentation at See https://mozilla.github.io/geckoview/tutorials/automation.html#enabling-reading-configuration-from-a-file-for-release-builds. However, Android has a flag -- the "debug_app" flag -- that Chrome uses to control this configuration file behaviour, and this commit makes GeckoView uses that flag as well. To use this, invoke `adb shell am set-debug-app --persistent PACKAGE` (see https://developer.android.com/studio/command-line/adb). Differential Revision: https://phabricator.services.mozilla.com/D32511
158f25256022be3aebd1e1649cc059e633e7842e: Bug 1548525 - Detect Android launch failure. r=snorp
Jed Davis <jld@mozilla.com> - Tue, 28 May 2019 21:08:36 +0000 - rev 475980
Push 113240 by nerli@mozilla.com at Wed, 29 May 2019 09:56:33 +0000
Bug 1548525 - Detect Android launch failure. r=snorp Currently the Android implementation of process launch signals failure by returning pid 0 through an out-parameter; we don't check for that, so we report success and then the bad pid spreads through IPC until it sets off an assertion somewhere else. This patch adds the missing check and strengthens an assertion that would have caught the problem more directly. Differential Revision: https://phabricator.services.mozilla.com/D32875
d47b2d152a7d2ab3b8a13ac2e96147d9fdb084be: Bug 1551377 - GeckoView unique tab id r=geckoview-reviewers,snorp
chrmod <chrmod@chrmod.net> - Tue, 28 May 2019 16:54:40 +0000 - rev 475977
Push 113240 by nerli@mozilla.com at Wed, 29 May 2019 09:56:33 +0000
Bug 1551377 - GeckoView unique tab id r=geckoview-reviewers,snorp Differential Revision: https://phabricator.services.mozilla.com/D32824
51414d51854c0f3602cf7bc94f3e94826c49ed4e: Bug 1330467 - part 9. Use principal with mobile permissions; r=johannh,snorp
Liang-Heng Chen <xeonchen@gmail.com> - Sun, 26 May 2019 17:00:54 +0000 - rev 475647
Push 113218 by opoprus@mozilla.com at Mon, 27 May 2019 10:01:39 +0000
Bug 1330467 - part 9. Use principal with mobile permissions; r=johannh,snorp Differential Revision: https://phabricator.services.mozilla.com/D19930
6edea9711df489668ba55da00f4f085618702fd0: Bug 1549633 - Enable listening for `recording-device-events`. r=esawin,geckoview-reviewers,snorp
Emily Toop <etoop@mozilla.com> - Fri, 24 May 2019 07:45:41 +0000 - rev 475364
Push 113208 by cbrindusan@mozilla.com at Fri, 24 May 2019 21:57:39 +0000
Bug 1549633 - Enable listening for `recording-device-events`. r=esawin,geckoview-reviewers,snorp This is to allow us to detect the enabling and disabling of recording so that we can notify the embedding application of the change in status. Differential Revision: https://phabricator.services.mozilla.com/D31072
6280c120acca9ac2b6c47db350f7bf8455f0b3a3: Bug 1550401 - Report OOM size when StringParam::GetString is failure. r=geckoview-reviewers,snorp
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Wed, 22 May 2019 18:43:08 +0000 - rev 475332
Push 113201 by csabou@mozilla.com at Fri, 24 May 2019 09:57:23 +0000
Bug 1550401 - Report OOM size when StringParam::GetString is failure. r=geckoview-reviewers,snorp Actually, all JNI Exceptions with `java.lang.OutOfMemoryError` call `NS_ABORT_OOM(0)`. But `JNIEnv::NewString` in `StringParam::GetString` can know OOM size when returning `nullptr`. So call `NS_ABORT_OOM` directly when `NewString` is failure. Differential Revision: https://phabricator.services.mozilla.com/D31026
1912d221317a9ba513e087d4775b105d95856078: Bug 1489669 - [1.4] Add Storage Controller API. r=baku,snorp
Eugen Sawin <esawin@me73.com> - Wed, 22 May 2019 20:21:09 +0000 - rev 475078
Push 113193 by dvarga@mozilla.com at Thu, 23 May 2019 16:04:39 +0000
Bug 1489669 - [1.4] Add Storage Controller API. r=baku,snorp Differential Revision: https://phabricator.services.mozilla.com/D32153
35991bb82eb3eaf7008ab3a97ad12c119afbaf5b: Bug 1543387 - Ignore initial about:blank load when restoring scroll position. r=snorp
Dylan Roeh <droeh@mozilla.com> - Wed, 22 May 2019 16:53:07 +0000 - rev 475067
Push 113193 by dvarga@mozilla.com at Thu, 23 May 2019 16:04:39 +0000
Bug 1543387 - Ignore initial about:blank load when restoring scroll position. r=snorp When restoreState is called early in a GeckoSession's life, the scroll position restore code can catch the pageshow event for the initial about:blank load rather than for the page being restored, resulting in a failure to restore scroll position. Differential Revision: https://phabricator.services.mozilla.com/D32163
28d50d22a289aaf16d614fce4026aad2a81e4073: Bug 1553371 - Load chrome frameScripts when switching processes. r=snorp
Agi Sferro <agi@sferro.dev> - Wed, 22 May 2019 19:20:54 +0000 - rev 475061
Push 113193 by dvarga@mozilla.com at Thu, 23 May 2019 16:04:39 +0000
Bug 1553371 - Load chrome frameScripts when switching processes. r=snorp Whenever we switch processes in GeckoView we didn't inject frameScripts. This change adds a new method `loadInitFrameScript` that is called whenever a module's new browser is attached to a window so that the frame script is loaded correctly into the new browser. This fixes a bug in WebExtension pages where the WebExtension Process Script would never be notified of a new WebExtension page window, breaking privileged APIs. Differential Revision: https://phabricator.services.mozilla.com/D32148
d4516071aefffa936541f886faefbfba386267ba: Bug 1553371 - Load moz-extension pages in extension principal. r=snorp
Agi Sferro <agi@sferro.dev> - Wed, 22 May 2019 19:20:54 +0000 - rev 475060
Push 113193 by dvarga@mozilla.com at Thu, 23 May 2019 16:04:39 +0000
Bug 1553371 - Load moz-extension pages in extension principal. r=snorp WebExtension can always open their respective WebExtension pages even when the WebExtension page is not content accessible. However, this is not true for `tabs.update`, which couldn't link to WebExtension pages at all. Similarly, a user should be able to open a WebExtension page directly by typing the URL. To fix the above problems we pass the correct `triggeringPrincipal` when loading such URIs. This change also makes URI typed by the user not use the `systemPrincipal` anymore but a more restrictive codebase principal local to the page that's being typed to avoid unintended side-effects. This also makes the triggering URI always the page for these privileged pages, so we need to adjust some tests to account for that by loading unprivileged `http` pages instead. Differential Revision: https://phabricator.services.mozilla.com/D32149
4646d2e361f61fd2feae6c33e8545cad55f1c28f: Bug 1553304 - Use APZC for accessibility scroll action on root node. r=geckoview-reviewers,snorp
Eitan Isaacson <eitan@monotonous.org> - Tue, 21 May 2019 21:38:57 +0000 - rev 474883
Push 113174 by nerli@mozilla.com at Wed, 22 May 2019 03:46:05 +0000
Bug 1553304 - Use APZC for accessibility scroll action on root node. r=geckoview-reviewers,snorp Differential Revision: https://phabricator.services.mozilla.com/D32062
566c25b14d477ff86772ed8bb270d64609f5a3dc: Bug 1550877 - Use correct E10SUtils in GeckoViewNavigation. r=snorp
Agi Sferro <agi@sferro.dev> - Fri, 17 May 2019 13:43:44 +0000 - rev 474343
Push 113149 by rgurzau@mozilla.com at Fri, 17 May 2019 21:50:06 +0000
Bug 1550877 - Use correct E10SUtils in GeckoViewNavigation. r=snorp This fixes a crash in `browser.tabs.update` when used with WebExtension pages. Differential Revision: https://phabricator.services.mozilla.com/D31453
877ae9359a2774f9ccee1f68935b4e7194a5711e: Bug 1550877 - Use correct E10SUtils in GeckoViewNavigation. r=snorp
Agi Sferro <agi@sferro.dev> - Fri, 17 May 2019 04:10:53 +0000 - rev 474293
Push 113144 by shindli@mozilla.com at Fri, 17 May 2019 16:44:55 +0000
Bug 1550877 - Use correct E10SUtils in GeckoViewNavigation. r=snorp This fixes a crash in `browser.tabs.update` when used with WebExtension pages. Differential Revision: https://phabricator.services.mozilla.com/D31453
f6d24071d2baeecac739a6a5d2853db19ee57e79: Bug 1551890 - Cache GFXInfo WebRTC HW encode/decode result on Android. r=snorp
Chris Pearce <cpearce@mozilla.com> - Thu, 16 May 2019 22:42:00 +0000 - rev 474270
Push 113144 by shindli@mozilla.com at Fri, 17 May 2019 16:44:55 +0000
Bug 1551890 - Cache GFXInfo WebRTC HW encode/decode result on Android. r=snorp Profiling shows that we're spending a lot of time on startup inside android.media.MediaCodecList.getCodecCount when GfxInfo::GetFeatureStatus calls over to Java to determine whether hardware accelerated video encoding is supported. Looking at the Java stacks in the profile, Android is spending most of our time creating a list of codecs. It doesn't look like there's a faster way to query for hardware accelerated video support. So to speed this up we can cache the value in the user's profile. We also store the OS version, which we can use to detect when the OS is updated so we can invalidate the cache then. Presumably an OS update is the only way a device can have its hardware acceleration support status change. With this change, the time we take figuring out the HW encode/decode status goes from ~100ms on a cold run to ~0.01ms on a cache hit on my HD8 tablet. Differential Revision: https://phabricator.services.mozilla.com/D31380
5fae8054799fd916ceca727611c2f99afc83e93e: Bug 1551342 - Don't assert the thread calling JNI WebAuthn functions r=snorp
J.C. Jones <jjones@mozilla.com> - Thu, 16 May 2019 19:08:15 +0000 - rev 474226
Push 113144 by shindli@mozilla.com at Fri, 17 May 2019 16:44:55 +0000
Bug 1551342 - Don't assert the thread calling JNI WebAuthn functions r=snorp The mozilla::java::WebAuthnTokenManager asserts its return-to-C++ callbacks as being run on the main Android UI thread, but since these methods are called directly from the Fido2PendingIntent listeners, there's no guarantee of that. We don't actually care what thread was tasked with returning us data, just that it gets done, so let's not assert the thread here. Differential Revision: https://phabricator.services.mozilla.com/D31497
357afb47596887ce6037200334ba7e2d1360bc52: Bug 1543823 - Compute Accept-Language header based on app and OS prefs. r=snorp
Matt Brubeck <mbrubeck@mozilla.com> - Mon, 13 May 2019 20:52:10 +0000 - rev 474218
Push 113144 by shindli@mozilla.com at Fri, 17 May 2019 16:44:55 +0000
Bug 1543823 - Compute Accept-Language header based on app and OS prefs. r=snorp Differential Revision: https://phabricator.services.mozilla.com/D30946
928038c23227504c1cd7dff5f5e214501bb4b688: Bug 1549855 - remove references to e10s force-enable pref that is no longer used, r=ato,snorp,eeejay
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Thu, 16 May 2019 16:21:56 +0000 - rev 474201
Push 113144 by shindli@mozilla.com at Fri, 17 May 2019 16:44:55 +0000
Bug 1549855 - remove references to e10s force-enable pref that is no longer used, r=ato,snorp,eeejay Differential Revision: https://phabricator.services.mozilla.com/D31417
97c7af33ac1db2daa8b55c9f4f7e14e342010ab7: Bug 1544584 - Make it possible to remove android.speech dependencies using Proguard r=snorp,rbarker,eeejay
Imanol Fernandez <imanol@mozilla.com> - Thu, 16 May 2019 01:05:01 +0000 - rev 474039
Push 113120 by dvarga@mozilla.com at Thu, 16 May 2019 04:21:05 +0000
Bug 1544584 - Make it possible to remove android.speech dependencies using Proguard r=snorp,rbarker,eeejay Some minor refactor to make it possible to remove android.speech dependencies using Proguard Differential Revision: https://phabricator.services.mozilla.com/D27612
b60e7b3407b3aa6a2110f7e09a41e1ea10a04213: Bug 1544584 - Make it possible to remove android.speech dependencies using Proguard r=snorp,rbarker,eeejay
Imanol Fernandez <mortimergoro@gmail.com> - Wed, 15 May 2019 19:56:43 +0000 - rev 474008
Push 113120 by dvarga@mozilla.com at Thu, 16 May 2019 04:21:05 +0000
Bug 1544584 - Make it possible to remove android.speech dependencies using Proguard r=snorp,rbarker,eeejay Some minor refactor to make it possible to remove android.speech dependencies using Proguard Differential Revision: https://phabricator.services.mozilla.com/D27612
4fbfc8798cad0ecc7ae867ed943b91b24789a500: Bug 1550596: Remove overly broad keep rule from GV proguard rules. r=snorp,agi
Will Hawkins <whawkins@mozilla.com> - Mon, 13 May 2019 21:35:09 +0000 - rev 473698
Push 113102 by apavel@mozilla.com at Tue, 14 May 2019 04:24:11 +0000
Bug 1550596: Remove overly broad keep rule from GV proguard rules. r=snorp,agi Requesting reviewers based on `hg blame` output and general knowledge of who is working on the project. I hope that's okay. Differential Revision: https://phabricator.services.mozilla.com/D30580
2b0045289ea3ff901ce697c2bb51389bca055074: Bug 1551226 - Run Android x86_64 7.0/debug mochitests; r=snorp
Geoff Brown <gbrown@mozilla.com> - Mon, 13 May 2019 20:52:36 +0000 - rev 473689
Push 113102 by apavel@mozilla.com at Tue, 14 May 2019 04:24:11 +0000
Bug 1551226 - Run Android x86_64 7.0/debug mochitests; r=snorp We can run /debug mochitests against geckoview for the cost of another dozen or so test annotations. Both /opt and /debug mochitests are nearly worthy of tier 1, but still waiting for bug 1534732. Differential Revision: https://phabricator.services.mozilla.com/D30931
b231eb222b8c8b9eab3014459ff4cf48b6f1d24b: Bug 1551262 - Remove mach support for jimdb; r=snorp
Geoff Brown <gbrown@mozilla.com> - Mon, 13 May 2019 20:52:29 +0000 - rev 473688
Push 113102 by apavel@mozilla.com at Tue, 14 May 2019 04:24:11 +0000
Bug 1551262 - Remove mach support for jimdb; r=snorp If there is still value to this -- if you know of anyone using jimdb via mach, etc -- I am happy to throw this away, but otherwise, would like to clean it up. Differential Revision: https://phabricator.services.mozilla.com/D30943
abaf133a405518a1c014b704c4fe72dc27a018c1: Bug 1541485. Stop using AutoJSContext in android widget code. r=snorp
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 13 May 2019 14:44:51 +0000 - rev 473609
Push 113093 by apavel@mozilla.com at Mon, 13 May 2019 22:09:34 +0000
Bug 1541485. Stop using AutoJSContext in android widget code. r=snorp Differential Revision: https://phabricator.services.mozilla.com/D30762
f9170a14e63672ffff429d81c76ffd5c49f9936f: Bug 1549732 - Use ReferrerInfo instead of ReferrerURI when loading URI r=geckoview-reviewers,snorp
Emily Toop <etoop@mozilla.com> - Fri, 10 May 2019 18:00:28 +0000 - rev 473598
Push 113093 by apavel@mozilla.com at Mon, 13 May 2019 22:09:34 +0000
Bug 1549732 - Use ReferrerInfo instead of ReferrerURI when loading URI r=geckoview-reviewers,snorp Differential Revision: https://phabricator.services.mozilla.com/D30524
d8e0bfeb5fa39545f737a6979c94a210d947ab22: Bug 1391438 - Support FIDO2 for WebAuthn on Android r=snorp,keeler
J.C. Jones <jjones@mozilla.com> - Fri, 10 May 2019 16:40:17 +0000 - rev 473459
Push 113084 by rmaries@mozilla.com at Sat, 11 May 2019 10:04:51 +0000
Bug 1391438 - Support FIDO2 for WebAuthn on Android r=snorp,keeler Support using the Google Play-provided FIDO2 API for Web Authentication. FIDO U2F API support is being handled subsequently in Bug 1550625. This patch uses the privileged APIs and thus will only work on Fennec Nightly, Beta, and Release builds. Differential Revision: https://phabricator.services.mozilla.com/D1148
192ba11153b4c29512a9722caf8260292601e6aa: Bug 1391438 - Move GECKOBUNDLE macros into their own header r=snorp
J.C. Jones <jjones@mozilla.com> - Fri, 10 May 2019 17:59:46 +0000 - rev 473458
Push 113084 by rmaries@mozilla.com at Sat, 11 May 2019 10:04:51 +0000
Bug 1391438 - Move GECKOBUNDLE macros into their own header r=snorp The GECKOBUNDLE macros are useful to more than just a11y code, so let's move them into the jni package so that all jni consumers may drink of their sweet nectar. Differential Revision: https://phabricator.services.mozilla.com/D30585
2648f5bb180463e213b55a0f1434c51c9853f213: Bug 1330467 - part 9. Use principal with mobile permissions; r=johannh,snorp
Liang-Heng Chen <xeonchen@gmail.com> - Tue, 07 May 2019 22:20:46 +0000 - rev 473418
Push 113082 by dvarga@mozilla.com at Fri, 10 May 2019 21:54:38 +0000
Bug 1330467 - part 9. Use principal with mobile permissions; r=johannh,snorp Differential Revision: https://phabricator.services.mozilla.com/D19930
84191877561ed6ad1e5905b703c2c5865836c45b: Bug 1538458 - Part 2. Update tests that includes fieldset r=geckoview-reviewers,snorp
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Tue, 07 May 2019 20:17:28 +0000 - rev 473190
Push 113068 by nerli@mozilla.com at Thu, 09 May 2019 15:38:15 +0000
Bug 1538458 - Part 2. Update tests that includes fieldset r=geckoview-reviewers,snorp Update this junit test with this bug's test case. Actually, autofill_userpass doesn't work with the latest GV, so I should like to update this to fix focus timing. Also, this does't run on our test infra because this requires API 26. Differential Revision: https://phabricator.services.mozilla.com/D30178
b0c3aa221224b5f3c6f60079756791a04fe33602: Bug 1538458 - Part 1. LoginManagerContent requires <input> or <input type="password"> element to recognize login form r=geckoview-reviewers,snorp
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Tue, 07 May 2019 20:18:12 +0000 - rev 473189
Push 113068 by nerli@mozilla.com at Thu, 09 May 2019 15:38:15 +0000
Bug 1538458 - Part 1. LoginManagerContent requires <input> or <input type="password"> element to recognize login form r=geckoview-reviewers,snorp Actually, sample url has `<fieldset>` element, so LoginManagerContent cannot detects username field. `LoginManagerContent.getUserNameAndPasswordFields` detects username field and password field when passing `<input>` element. So we should pass password field if possible. Differential Revision: https://phabricator.services.mozilla.com/D30179
176eced1154bca5f78b54505aa0b8a7bbabeacb6: Bug 1550185 - Ensure GeckoView CrashHandler.getRootException() does not return null r=snorp
Randall E. Barker <rbarker@mozilla.com> - Wed, 08 May 2019 23:49:04 +0000 - rev 473158
Push 113065 by opoprus@mozilla.com at Thu, 09 May 2019 03:46:59 +0000
Bug 1550185 - Ensure GeckoView CrashHandler.getRootException() does not return null r=snorp Differential Revision: https://phabricator.services.mozilla.com/D30422
f883d868ce316ef506df5dd52cd0b9697c63760d: Bug 1550185 - Ensure GeckoView CrashHandler.getRootException() does not return null r=snorp
Randall E. Barker <rbarker@mozilla.com> - Wed, 08 May 2019 21:23:13 +0000 - rev 473126
Push 113065 by opoprus@mozilla.com at Thu, 09 May 2019 03:46:59 +0000
Bug 1550185 - Ensure GeckoView CrashHandler.getRootException() does not return null r=snorp Differential Revision: https://phabricator.services.mozilla.com/D30422
e20b442b0ee386a6bd20b562d0e381eec4f41ca5: Bug 1542566 - Put Android system locale before app default in Accept-Language. r=snorp
Matt Brubeck <mbrubeck@mozilla.com> - Tue, 07 May 2019 22:03:04 +0000 - rev 472982
Push 113059 by ncsoregi@mozilla.com at Wed, 08 May 2019 03:43:45 +0000
Bug 1542566 - Put Android system locale before app default in Accept-Language. r=snorp Differential Revision: https://phabricator.services.mozilla.com/D29906
9905f7082bedaa523f83f8d2cc67e1c28ff02157: Bug 1540573 - Followup - Don't double-start/stop NetworkManager in Fennec. r=snorp
Jan Henning <jh+bugzilla@buttercookie.de> - Tue, 07 May 2019 20:26:13 +0000 - rev 472979
Push 113059 by ncsoregi@mozilla.com at Wed, 08 May 2019 03:43:45 +0000
Bug 1540573 - Followup - Don't double-start/stop NetworkManager in Fennec. r=snorp Now handled via GeckoRuntime's lifecycle callbacks. Differential Revision: https://phabricator.services.mozilla.com/D30245
5c8c1f93843a8114a6576bee2989ee0558f52be4: Bug 1549576 - Store fixed layer margin in session and send to compositor when ready. r=geckoview-reviewers,snorp
Eitan Isaacson <eitan@monotonous.org> - Tue, 07 May 2019 21:13:29 +0000 - rev 472973
Push 113059 by ncsoregi@mozilla.com at Wed, 08 May 2019 03:43:45 +0000
Bug 1549576 - Store fixed layer margin in session and send to compositor when ready. r=geckoview-reviewers,snorp Differential Revision: https://phabricator.services.mozilla.com/D30132
45f82a11656c33e633132d8c4d54841e42cc97dc: Bug 1549576 - Store fixed layer margin in session and send to compositor when ready. r=geckoview-reviewers,snorp
Eitan Isaacson <eitan@monotonous.org> - Tue, 07 May 2019 17:54:22 +0000 - rev 472944
Push 113059 by ncsoregi@mozilla.com at Wed, 08 May 2019 03:43:45 +0000
Bug 1549576 - Store fixed layer margin in session and send to compositor when ready. r=geckoview-reviewers,snorp Differential Revision: https://phabricator.services.mozilla.com/D30132
90cb2313723f7106ae2521ff42c14a631d65b62f: Bug 1549699 - Don't use communication mode and speakerphone mode methods of AudioManager. r=snorp
Paul Adenot <paul@paul.cx> - Tue, 07 May 2019 15:20:02 +0000 - rev 472914
Push 113059 by ncsoregi@mozilla.com at Wed, 08 May 2019 03:43:45 +0000
Bug 1549699 - Don't use communication mode and speakerphone mode methods of AudioManager. r=snorp This is more related to telephony than anything else, and are more suited to real telephony app. Differential Revision: https://phabricator.services.mozilla.com/D30071
b78948e4f480ea6b99f2c689fe048256590b8769: Bug 1540573 - P3. Expose network link type on ContentChild for use in content process. r=snorp
Chris Pearce <cpearce@mozilla.com> - Mon, 06 May 2019 22:41:25 +0000 - rev 472822
Push 113048 by shindli@mozilla.com at Tue, 07 May 2019 09:56:38 +0000
Bug 1540573 - P3. Expose network link type on ContentChild for use in content process. r=snorp In GeckoView the nsINetworkLinkService doesn't work in the content process, as we don't seem to have an AndroidBridge there, so just maintain the network connection type on the ContentChild. (I had considered keeping this on the NeckoChild, but the creation of that is initiated from the content process side, and there's not an easy and clean way to have the parent process send us the connection type after construction of the NeckoParent, other than have the NeckoChild request it either synchronously, or doing it async and hoping it's not asked for the value before the response comes in.) Differential Revision: https://phabricator.services.mozilla.com/D26232
d029091d7fd831b30cbc4a660c03f962b20fa44e: Bug 1540573 - P2. Have GeckoRuntime listen for network link changes when in the foreground. r=snorp
Chris Pearce <cpearce@mozilla.com> - Mon, 06 May 2019 22:41:10 +0000 - rev 472821
Push 113048 by shindli@mozilla.com at Tue, 07 May 2019 09:56:38 +0000
Bug 1540573 - P2. Have GeckoRuntime listen for network link changes when in the foreground. r=snorp This allows Gecko to react to network link/status changes events as needed. Differential Revision: https://phabricator.services.mozilla.com/D28942
6a17951bc4b981f455e3b8f54db29b5ed28fa122: Bug 1540573 - P1. Observe ProcessLifecycle events in GeckoRuntime. r=snorp
Eugen Sawin <esawin@mozilla.com>, Chris Pearce <cpearce@mozilla.com> - Mon, 06 May 2019 22:40:56 +0000 - rev 472820
Push 113048 by shindli@mozilla.com at Tue, 07 May 2019 09:56:38 +0000
Bug 1540573 - P1. Observe ProcessLifecycle events in GeckoRuntime. r=snorp This is esawin's patch from Bug 1544076; D28083. Differential Revision: https://phabricator.services.mozilla.com/D28941
729b948b257afc86585243423bb191b845b09238: Bug 1548960 - Call super.onAttachedToWindow from GeckoView even when we have no session set. r=geckoview-reviewers,snorp
Eitan Isaacson <eitan@monotonous.org> - Mon, 06 May 2019 16:38:18 +0000 - rev 472740
Push 113042 by opoprus@mozilla.com at Mon, 06 May 2019 22:36:56 +0000
Bug 1548960 - Call super.onAttachedToWindow from GeckoView even when we have no session set. r=geckoview-reviewers,snorp Differential Revision: https://phabricator.services.mozilla.com/D29916
c8216edb37a946d516820743a831804512bbba4c: Bug 1545255 - [2.0] Add GeckoSession.loadUri() referrer test. r=snorp
Eugen Sawin <esawin@me73.com> - Fri, 03 May 2019 16:15:45 +0000 - rev 472688
Push 113042 by opoprus@mozilla.com at Mon, 06 May 2019 22:36:56 +0000
Bug 1545255 - [2.0] Add GeckoSession.loadUri() referrer test. r=snorp Depends on D29683 Differential Revision: https://phabricator.services.mozilla.com/D29684
f7323ab06d60a509da4344e477c6d55094673009: Bug 1545255 - [1.0] Use ReferrerInfo when loading URIs in GeckoView. r=snorp
Eugen Sawin <esawin@me73.com> - Fri, 03 May 2019 22:08:29 +0000 - rev 472687
Push 113042 by opoprus@mozilla.com at Mon, 06 May 2019 22:36:56 +0000
Bug 1545255 - [1.0] Use ReferrerInfo when loading URIs in GeckoView. r=snorp Differential Revision: https://phabricator.services.mozilla.com/D29683