searching for reviewer(peterv)
76ad398222a6809bef3116d77b580ef3e9339cce: Bug 1568903 - Part 10: Update test_xrayToJS to handle the new AggregateError object and the Promise method. r=peterv,jorendorff
André Bargull <andre.bargull@gmail.com> - Fri, 15 Nov 2019 10:34:04 +0000 - rev 502146
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1568903 - Part 10: Update test_xrayToJS to handle the new AggregateError object and the Promise method. r=peterv,jorendorff Differential Revision: https://phabricator.services.mozilla.com/D51660
11ce58dd19022bd0d8c7f4da372b6f1134623474: Bug 1594850 - Part 2 - Write a test for gHistoryMaxSize in nsSHistory being set to 0 and mIndex and mRequestedIndex=-1, r=peterv
Anny Gakhokidze <agakhokidze@mozilla.com> - Thu, 14 Nov 2019 20:09:58 +0000 - rev 502045
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1594850 - Part 2 - Write a test for gHistoryMaxSize in nsSHistory being set to 0 and mIndex and mRequestedIndex=-1, r=peterv Differential Revision: https://phabricator.services.mozilla.com/D52927
3af47ccb969a9c50101c1efffbefc5eaece26bb4: Bug 1594850 - Part 1 - Fix crash in nsSHistory::EnsureCorrectEntryAtCurrIndex when mIndex=-1, r=peterv
Anny Gakhokidze <agakhokidze@mozilla.com> - Thu, 14 Nov 2019 20:09:58 +0000 - rev 502044
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1594850 - Part 1 - Fix crash in nsSHistory::EnsureCorrectEntryAtCurrIndex when mIndex=-1, r=peterv Differential Revision: https://phabricator.services.mozilla.com/D52370
27f06b7cc987734c9f55742f18351b5e40ea3aed: Bug 1595900 - CanonicalBrowsingContext::GetSessionHistory should be able to deal with in-process case too, r=peterv
Olli Pettay <Olli.Pettay@helsinki.fi> - Wed, 13 Nov 2019 15:21:25 +0000 - rev 501762
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1595900 - CanonicalBrowsingContext::GetSessionHistory should be able to deal with in-process case too, r=peterv Differential Revision: https://phabricator.services.mozilla.com/D52738
4ebefd304d2f40a91c9d595e750d5ec8372bfc6a: Bug 1571066: Return WindowProxyHolder from nsDocShell::GetWindowProxy. r=peterv
Kris Maglione <maglione.k@gmail.com> - Tue, 12 Nov 2019 08:32:09 +0000 - rev 501660
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1571066: Return WindowProxyHolder from nsDocShell::GetWindowProxy. r=peterv Returning BrowsingContext* from these sorts of getters tends to lead to misuse. WindowProxyHolder is the semantically correct type to return here, in any case. Differential Revision: https://phabricator.services.mozilla.com/D52096
46948e618953a6cb0d7aa931ea94c4d64789dbdb: Bug 1573647, try to make test_windowedhistoryframes.html less racy by using popstate event and not timeout, r=peterv
Olli Pettay <Olli.Pettay@helsinki.fi> - Tue, 12 Nov 2019 17:14:51 +0000 - rev 501601
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1573647, try to make test_windowedhistoryframes.html less racy by using popstate event and not timeout, r=peterv Using popstate event in cases it is fired. Differential Revision: https://phabricator.services.mozilla.com/D52600
d9acb8da07684d0511722574cb8a673322604f00: Bug 1588260 part 2. Switch nsICollation away from using xpidl [array]. r=peterv,emk
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 11 Nov 2019 18:03:42 +0000 - rev 501489
Push 114170 by malexandru@mozilla.com at Tue, 12 Nov 2019 21:58:32 +0000
Bug 1588260 part 2. Switch nsICollation away from using xpidl [array]. r=peterv,emk Differential Revision: https://phabricator.services.mozilla.com/D49052
dfa02c90256c40834b0db938ce769506dc2955da: Bug 1588260 part 1. Make some XSLT comparator code a bit more type-safe. r=peterv.
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 11 Nov 2019 18:03:34 +0000 - rev 501488
Push 114170 by malexandru@mozilla.com at Tue, 12 Nov 2019 21:58:32 +0000
Bug 1588260 part 1. Make some XSLT comparator code a bit more type-safe. r=peterv. Differential Revision: https://phabricator.services.mozilla.com/D49051
b51eda439bbe0b5431453353ab1a66ab43527eb4: Bug 1592290 - Propagate aLookForCallerOnJSStack in nsGlobalWindowOuter::WindowExists to BrowsingContext::FindWith. r=peterv
Andreas Farre <farre@mozilla.com> - Tue, 05 Nov 2019 13:39:50 +0000 - rev 500635
Push 114166 by apavel@mozilla.com at Thu, 07 Nov 2019 10:04:01 +0000
Bug 1592290 - Propagate aLookForCallerOnJSStack in nsGlobalWindowOuter::WindowExists to BrowsingContext::FindWith. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D50942
8361b46b39dbc3bdc02388a71a56e597f0789f61: Bug 1545474 - Part 3: Test eviction of content viewer entries, r=peterv
Anny Gakhokidze <agakhokidze@mozilla.com> - Wed, 22 May 2019 16:19:19 -0400 - rev 500506
Push 114165 by pvanderbeken@mozilla.com at Wed, 06 Nov 2019 09:18:40 +0000
Bug 1545474 - Part 3: Test eviction of content viewer entries, r=peterv Add a new callback to session history listener to listen for content viewers being evicted. Differential Revision: https://phabricator.services.mozilla.com/D32731
3b772fd4f675fd9fd111ab0d8bdcc4c799f54ae2: Bug 1545474 - Part 2: Modify eviction of content viewers to accomodate session history changes, r=peterv
Anny Gakhokidze <agakhokidze@mozilla.com> - Tue, 07 May 2019 14:18:00 -0400 - rev 500505
Push 114165 by pvanderbeken@mozilla.com at Wed, 06 Nov 2019 09:18:40 +0000
Bug 1545474 - Part 2: Modify eviction of content viewers to accomodate session history changes, r=peterv When we need to evict content viewers, we group SHEntrySharedParentState, corresponding to session history entries that need to be evicted, by their content parent and send their id's to their corresponding parents for eviction. Differential Revision: https://phabricator.services.mozilla.com/D32730
351e31cced31850983c9552b6f9a90dc69c3e5d8: Bug 1545474 - Part 1: Consolidate sync IPC calls inside of nsDocShell::UpdateURLAndHistory, r=peterv, r=nika for adding sync IPC messages
Anny Gakhokidze <agakhokidze@mozilla.com> - Thu, 18 Apr 2019 15:18:00 -0400 - rev 500504
Push 114165 by pvanderbeken@mozilla.com at Wed, 06 Nov 2019 09:18:40 +0000
Bug 1545474 - Part 1: Consolidate sync IPC calls inside of nsDocShell::UpdateURLAndHistory, r=peterv, r=nika for adding sync IPC messages Inside of nsDocShell::UpdateURLAndHistory, there are 4 sync IPC calls to nsSHistory plus 1 static call, which contains at least one nsSHEntry::GetParent sync IPC call. All of these calls can be moved inside of a new method EvictContentViewersOrReplaceEntry on nsSHEntry, resulting in just 1 sync IPC call. Differential Revision: https://phabricator.services.mozilla.com/D32729
0f25a3d302734de4abeaf80a692987fc2c6df124: Bug 1541515 - Consolidate IPC calls to nsISHEntry inside of nsDocShell::GetChildSHEntry, r=peterv, r=nika for adding sync IPC messages
Anny Gakhokidze <agakhokidze@mozilla.com> - Mon, 15 Apr 2019 14:27:44 -0400 - rev 500499
Push 114165 by pvanderbeken@mozilla.com at Wed, 06 Nov 2019 09:18:40 +0000
Bug 1541515 - Consolidate IPC calls to nsISHEntry inside of nsDocShell::GetChildSHEntry, r=peterv, r=nika for adding sync IPC messages Currently, nsDocShell::GetChildSHEntry calls 3 sync IPC calls on nsISHEntry, and the method GetChildSHEntry only has one caller. By moving GetChildSHEntry method to parent process for nsISHEntry, resulting in a new method nsISHEntry::GetChildSHEntry, 3 sync IPC calls can be reduced to 1. Differential Revision: https://phabricator.services.mozilla.com/D27633
ed6458f398494a144429b694e5960dac94d0751c: Bug 1546761 - Consolidate IPC calls to nsISHistory inside of nsDocShell::OnNewURI, r=peterv, r=nika for adding sync IPC messages
Anny Gakhokidze <agakhokidze@mozilla.com> - Tue, 07 May 2019 15:23:08 -0400 - rev 500498
Push 114165 by pvanderbeken@mozilla.com at Wed, 06 Nov 2019 09:18:40 +0000
Bug 1546761 - Consolidate IPC calls to nsISHistory inside of nsDocShell::OnNewURI, r=peterv, r=nika for adding sync IPC messages Inside of nsDocShell::OnNewURI there are 4 sync IPC calls to nsSHistory that can be replaced with 1 sync IPC call by adding a new method EnsureCorrectEntryAtCurrIndex to nsSHistory. Differential Revision: https://phabricator.services.mozilla.com/D31539
82c30a27597ec427282fcfd0285dec4aa23de362: Bug 1536468 - Make retrieval of WebBrowserPersistDocumentAttrs.cacheKey async in SessionHistory. Compilation fix, r=peterv.
Peter Van der Beken <peterv@propagandism.org> - Fri, 24 May 2019 09:05:04 +0200 - rev 500497
Push 114165 by pvanderbeken@mozilla.com at Wed, 06 Nov 2019 09:18:40 +0000
Bug 1536468 - Make retrieval of WebBrowserPersistDocumentAttrs.cacheKey async in SessionHistory. Compilation fix, r=peterv.
a7f24a5236c9dcecdbaba57a33dc9baac400969c: Bug 1539482 - Write tests for nsISHEntry::CreateLoadInfo, r=peterv
Anny Gakhokidze <agakhokidze@mozilla.com> - Mon, 08 Apr 2019 18:39:40 -0400 - rev 500496
Push 114165 by pvanderbeken@mozilla.com at Wed, 06 Nov 2019 09:18:40 +0000
Bug 1539482 - Write tests for nsISHEntry::CreateLoadInfo, r=peterv Differential Revision: https://phabricator.services.mozilla.com/D26813
5eaeccea05e50f6447122127fa52501730a58c82: Bug 1539482 - Reduce the number of IPC calls on nsISHEntry in nsDocShell::LoadHistoryEntry, r=peterv, r=nika for adding sync IPC messages
Anny Gakhokidze <agakhokidze@mozilla.com> - Fri, 29 Mar 2019 15:48:59 -0400 - rev 500495
Push 114165 by pvanderbeken@mozilla.com at Wed, 06 Nov 2019 09:18:40 +0000
Bug 1539482 - Reduce the number of IPC calls on nsISHEntry in nsDocShell::LoadHistoryEntry, r=peterv, r=nika for adding sync IPC messages In nsDocShell::LoadHistoryEntry method, when it gets called from parent process, there are 13 sync IPC calls on nsISHEntry that retrieve information from the session history entry and create a doc shell load state object using the retrieved information. By adding a new method 'CreateLoadInfo'on nsISHEntry, inside of which the doc shell load state object will be created (with appropriate data filled out) and returned, we eliminate 12 sync IPC call, resulting in just 1 IPC call to nsISHEntry::CreateLoadInfo. Differential Revision: https://phabricator.services.mozilla.com/D26042
a1f164c082f6d0cddce6ddb5057ba1649ad9a960: Bug 1539238 - Modify nsSHEntry::Create to consolidate setter calls on nsSHEntry in nsDocShell::AddToSessionHistory, r=peterv
Anny Gakhokidze <agakhokidze@mozilla.com> - Tue, 26 Mar 2019 15:46:36 -0400 - rev 500494
Push 114165 by pvanderbeken@mozilla.com at Wed, 06 Nov 2019 09:18:40 +0000
Bug 1539238 - Modify nsSHEntry::Create to consolidate setter calls on nsSHEntry in nsDocShell::AddToSessionHistory, r=peterv nsDocShell is the only consumer of nsISHEntry::Create, and in AddToSessionHistory method, after calling nsISHEntry::Create, it calls 8 setter methods on nsISHEntry, which results in a total of 9 sync IPC calls. With the proposed solution of setting everything via nsISHEntry::Create, we get a total of 1 sync IPC call. Differential Revision: https://phabricator.services.mozilla.com/D24979
d5388b03ad037a8837da1907b2f3344b73ef3976: Bug 1536471 - Consolidate calls to nsISHEntry::GetChildAt in nsDocShell::AddToSessionHistory by adding nsSHEntry::ClearEntry method, r=peterv, r=nika for adding sync IPC messages
Anny Gakhokidze <agakhokidze@mozilla.com> - Tue, 26 Mar 2019 14:24:33 -0400 - rev 500493
Push 114165 by pvanderbeken@mozilla.com at Wed, 06 Nov 2019 09:18:40 +0000
Bug 1536471 - Consolidate calls to nsISHEntry::GetChildAt in nsDocShell::AddToSessionHistory by adding nsSHEntry::ClearEntry method, r=peterv, r=nika for adding sync IPC messages Currently, nsDocShell repeatedly calls nsISHEntry::GetChildAt and nsISHEntry::RemoveChild in nsDocShell::AddToSessionHistory, which results in twice as many IPC calls as the number of children a session history entry has. Additionally, there is one extra IPC sync call to nsISHEntry::AbandonBFCacheEntry after the loop. With the proposed solution, there will only be 1 sync IPC call. Differential Revision: https://phabricator.services.mozilla.com/D24978
8d5396434bb4a2b53481a1df3b2d65b29f666676: Bug 1536471 - Write tests for nsISHistory::RemoveFrameEntries, r=peterv
Anny Gakhokidze <agakhokidze@mozilla.com> - Tue, 26 Mar 2019 11:21:26 -0400 - rev 500492
Push 114165 by pvanderbeken@mozilla.com at Wed, 06 Nov 2019 09:18:40 +0000
Bug 1536471 - Write tests for nsISHistory::RemoveFrameEntries, r=peterv Differential Revision: https://phabricator.services.mozilla.com/D24977
4c45890e566b34ef07b0cc5670e99a3fec748483: Bug 1536471 - Consolidate calls to nsISHEntry::GetChildAt in nsDocShell::ClearFrameHistory by adding a new sync IPC call nsISHistory::RemoveFrameEntries, r=peterv, r=nika for adding sync IPC messages
Anny Gakhokidze <agakhokidze@mozilla.com> - Fri, 22 Mar 2019 15:45:38 -0400 - rev 500491
Push 114165 by pvanderbeken@mozilla.com at Wed, 06 Nov 2019 09:18:40 +0000
Bug 1536471 - Consolidate calls to nsISHEntry::GetChildAt in nsDocShell::ClearFrameHistory by adding a new sync IPC call nsISHistory::RemoveFrameEntries, r=peterv, r=nika for adding sync IPC messages Currently, nsDocShell repeatedly calls nsISHEntry::GetChildAt, which results in as many IPC sync calls as the number of children a session history entry has. Calling nsISHEntry::GetChildCount and ChildSHistory::Index and incurs additional extra 2 sync IPC calls. With the proposed solution, there will only be 1 sync IPC call. Differential Revision: https://phabricator.services.mozilla.com/D24980
2ca26ca71fa0f4b459f1e02e8a73e537e07e8d20: Bug 1536468 - Make retrieval of WebBrowserPersistDocumentAttrs.cacheKey async in SessionHistory, r=peterv
Anny Gakhokidze <agakhokidze@mozilla.com> - Thu, 21 Mar 2019 16:33:51 -0400 - rev 500490
Push 114165 by pvanderbeken@mozilla.com at Wed, 06 Nov 2019 09:18:40 +0000
Bug 1536468 - Make retrieval of WebBrowserPersistDocumentAttrs.cacheKey async in SessionHistory, r=peterv Differential Revision: https://phabricator.services.mozilla.com/D24472
784c94ebc27fb14fc3e00ff2935991158a95a60d: Bug 1588194 part 2. Add missing property use counters to Window. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 29 Oct 2019 16:20:49 +0000 - rev 499642
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1588194 part 2. Add missing property use counters to Window. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D49045
cd01e6cc73d86c2ae6d8abd4c04c6238f7d83b19: Bug 1588194 part 1. Factor out the missing property use counter code into helper functions. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 29 Oct 2019 16:18:44 +0000 - rev 499641
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1588194 part 1. Factor out the missing property use counter code into helper functions. r=peterv This incidentally reduces the codesize, while allowing us to call those functions from elsewhere. The performance impact of the extra out-of-line call is not measurable (that is, is within the noise level) on the testcase at <https://bugzilla.mozilla.org/attachment.cgi?id=9096814>. Differential Revision: https://phabricator.services.mozilla.com/D49044
4938d59bdfac24a42e783eed36894418e200896e: Bug 1214364 part 4. Only output full-featured Init methods for dictionaries that need them. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 28 Oct 2019 20:24:31 +0000 - rev 499535
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1214364 part 4. Only output full-featured Init methods for dictionaries that need them. r=peterv Dictionaries that we never initialize with JS values don't need a full-featured Init() method. Instead, we output a cut-down Init() method that doesn't even take a JSContext and Value as argument, and skips as much work as it can. It uses constant-false for "is the value present?", but also, to avoid compilation errors due to use of `cx` and `val` in now-dead conversion code, it tells the native-to-JS conversion machinery that the value is always missing, which lets it skip most of the the work it would normally try to do and just output initialization to the default value. We only need to do this for members that have default values; the others either remain no-passed or are required members with no default-initialization behavior. This saves about 330KB of codesize on Linux64 without PGO and 285KB with PGO. Differential Revision: https://phabricator.services.mozilla.com/D48007
f44823eeed6eecc8066a221bf21fd552e892692f: Bug 1214364 part 3. Only output ToObjectInternal methods for dictionaries that need it. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 28 Oct 2019 23:20:11 +0000 - rev 499534
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1214364 part 3. Only output ToObjectInternal methods for dictionaries that need it. r=peterv This saves about 270KB of codesize on Linux64 without LTO, or 20KB with LTO. The basic idea is that we can flag dictionaries that need to-JS conversion (hence ToObjectInternal) based on various IDL uses (return value in normal interface, argument in callback, etc) and then annotate the ones that are converted to JS manually in C++ code. The mozwebidlcodegen changes are needed because non-local changes (e.g. whether a dictionary is used as a return value somewhere) can now affect the code generation for a dictionary and hence whether the relevant binding file should be regenerated. Since these changes can happen in any .webidl file, we need to check for them. We can't track this via the dependency set on the dictionary itself, because that would not notice new uses being added. Differential Revision: https://phabricator.services.mozilla.com/D48006
cbc214ea08f34c8193f808c978e5eac27d8b81ee: Bug 1214364 part 2. Remove the dead code around MethodNotNewObjectError. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 23 Oct 2019 18:04:30 +0000 - rev 499533
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1214364 part 2. Remove the dead code around MethodNotNewObjectError. r=peterv I don't know when we stopped raising them, but we did at some point. I am leaving the capability to not generate a union's ToJSVal method, because I will need it soon. Differential Revision: https://phabricator.services.mozilla.com/D48554
22ca446987dc3734e2adf014b32fb49145a6d1e1: Bug 1214364 part 1. Only output conversions to/from JSON for dictionaries that need it. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 23 Oct 2019 15:58:29 +0000 - rev 499532
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1214364 part 1. Only output conversions to/from JSON for dictionaries that need it. r=peterv This saves about 200KB of codesize on Linux64 without LTO. No effect with LTO, but is needed for the following patches to work. Very few dictionaries need these conversions, so explicit opt-in is fine. Differential Revision: https://phabricator.services.mozilla.com/D48005
2d821f7566485c62eb26fc374320ed836b41c889: Bug 1586750, don't compile event handlers on unloaded windows r=peterv
Olli Pettay <Olli.Pettay@helsinki.fi> - Mon, 28 Oct 2019 21:08:50 +0000 - rev 499517
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1586750, don't compile event handlers on unloaded windows r=peterv Differential Revision: https://phabricator.services.mozilla.com/D48983
7bdd8b2e2e67efd0d3c6e30a7c4ebad57ec6d09e: Bug 1396309, try to make file_fragment_handling_during_load.html less racy, r=peterv
Olli Pettay <Olli.Pettay@helsinki.fi> - Mon, 28 Oct 2019 20:18:24 +0000 - rev 499496
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1396309, try to make file_fragment_handling_during_load.html less racy, r=peterv The changes try to ensure we haven't really started load process of the new page, just that there is ongoing active request. history.back() will then only affect to the fragment navigation. Differential Revision: https://phabricator.services.mozilla.com/D50220
6b3edf5e5ad09012f755543ea2d15f5cd533607d: Bug 1575051 - Part 4: Expose JS stack access check control on FindWithName. r=peterv
Andreas Farre <farre@mozilla.com> - Fri, 25 Oct 2019 15:34:30 +0000 - rev 499291
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1575051 - Part 4: Expose JS stack access check control on FindWithName. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D49286
821fdad0dbb2eac515637141a872ff6870108f3c: Bug 1586793 - [Fission] iframe.contentWindow may be null when it shouldn't be, r=peterv
Olli Pettay <Olli.Pettay@helsinki.fi> - Thu, 17 Oct 2019 14:56:54 +0000 - rev 498053
Push 114157 by nbeleuzu@mozilla.com at Mon, 21 Oct 2019 22:00:13 +0000
Bug 1586793 - [Fission] iframe.contentWindow may be null when it shouldn't be, r=peterv The other cases when ClearWindowProxy is called seem to be fine. It is the Unlink case which was causing null .contentWindow with test_mozfiledataurl.html Fixes bug 1580391 and backs out bug 1581004 Differential Revision: https://phabricator.services.mozilla.com/D48878
02578c5bb2032fa0d91e712a03667b9757314ed0: Bug 1568883. Remove the QI implementation from Web IDL elements. r=peterv,mossop
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 11 Oct 2019 22:10:20 +0000 - rev 497519
Push 114152 by dvarga@mozilla.com at Tue, 15 Oct 2019 11:14:34 +0000
Bug 1568883. Remove the QI implementation from Web IDL elements. r=peterv,mossop The XBL test is being removed because it was the only remaining consumer of xbl's implements="interfacename" in the tree, and was triggering QI on elements for that codepath. I've verified that a try run that MOZ_CRASHes when the C++ binding QueryInterface implementation is invoked is green with these changes. Differential Revision: https://phabricator.services.mozilla.com/D48249
54b7889d4457f4e94ba2dceb0de8f1a0e4fbfb41: Bug 1588231. Remove special-cased QI-for-DOM-objects handling in CPOWs, since no one uses it outside of one test. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 14 Oct 2019 10:31:28 +0000 - rev 497499
Push 114152 by dvarga@mozilla.com at Tue, 15 Oct 2019 11:14:34 +0000
Bug 1588231. Remove special-cased QI-for-DOM-objects handling in CPOWs, since no one uses it outside of one test. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D49025
624eb2d8080b1e7a19d6207f8232d6a185f65293: Bug 1585684. Fix error message for permission failures when passing a union member. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 09 Oct 2019 09:22:05 +0000 - rev 497303
Push 114148 by shindli@mozilla.com at Mon, 14 Oct 2019 10:49:50 +0000
Bug 1585684. Fix error message for permission failures when passing a union member. r=peterv The new error message is still not great, but it's a lot better than having %s as the description of what's going on. Differential Revision: https://phabricator.services.mozilla.com/D47915
c0029f42afd2873d7a7f3a5db4b40bfbb3865e18: Bug 1586911: Silence SHEntry assertion after local->remote->local iframe navigation. r=peterv
Kris Maglione <maglione.k@gmail.com> - Fri, 11 Oct 2019 19:32:02 +0000 - rev 497301
Push 114148 by shindli@mozilla.com at Mon, 14 Oct 2019 10:49:50 +0000
Bug 1586911: Silence SHEntry assertion after local->remote->local iframe navigation. r=peterv When we have a parser-created iframe which starts out in-process, transitions to remote, and then transitions back to in-process, we create separate DocShells for the first and last in-process loads. Since both are network-created, and have the same child index, they both try to add themselves as children to their parent's SHistory at the same index. And since the entry for the first DocShell already exists at that index when we try to add the second, that triggers an assertion. This isn't really ideal, but it is expected given the current state of session history under Fission. It should hopefully be solved more gracefully when the Fission-aware session history rewrite is done, but in the mean time, I think we should just ignore the conflict, since it's expected. Differential Revision: https://phabricator.services.mozilla.com/D48437
d3f5f69f38a829af852593d2202976e67598d883: Bug 1568883. Remove the QI implementation from Web IDL elements. r=peterv,mossop
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 09 Oct 2019 09:19:32 +0000 - rev 497299
Push 114148 by shindli@mozilla.com at Mon, 14 Oct 2019 10:49:50 +0000
Bug 1568883. Remove the QI implementation from Web IDL elements. r=peterv,mossop The XBL test is being removed because it was the only remaining consumer of xbl's implements="interfacename" in the tree, and was triggering QI on elements for that codepath. I've verified that a try run that MOZ_CRASHes when the C++ binding QueryInterface implementation is invoked is green with these changes. Differential Revision: https://phabricator.services.mozilla.com/D48249
31d32668afb5e427b8d50ffca875ee7c7faa4a41: Bug 1584630. Implement missing property use counters for HTMLDocument. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 11 Oct 2019 16:56:36 +0000 - rev 497295
Push 114148 by shindli@mozilla.com at Mon, 14 Oct 2019 10:49:50 +0000
Bug 1584630. Implement missing property use counters for HTMLDocument. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D47504
86d33a025dd4475bddd9236e98ba24f5bc98c6a8: Bug 1584009 part 1. Loosen up the check for dictionary-containing-union-containing-dictionary. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 02 Oct 2019 14:16:34 +0000 - rev 496040
Push 114141 by rmaries@mozilla.com at Thu, 03 Oct 2019 09:42:28 +0000
Bug 1584009 part 1. Loosen up the check for dictionary-containing-union-containing-dictionary. r=peterv Since unions can now end up a in binding header, it's only a problem when the two dictionaries are in one header and the union is in a different one. If all three are in the same header, for example, there is no issue. Differential Revision: https://phabricator.services.mozilla.com/D47195
0932a7fdb46b7ff0fe22fd5debcd1e5481461f7a: Bug 1584009 part 1. Loosen up the check for dictionary-containing-union-containing-dictionary. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 02 Oct 2019 13:10:34 +0000 - rev 496032
Push 114141 by rmaries@mozilla.com at Thu, 03 Oct 2019 09:42:28 +0000
Bug 1584009 part 1. Loosen up the check for dictionary-containing-union-containing-dictionary. r=peterv Since unions can now end up a in binding header, it's only a problem when the two dictionaries are in one header and the union is in a different one. If all three are in the same header, for example, there is no issue. Differential Revision: https://phabricator.services.mozilla.com/D47195
344ae0abff73dd19d0a2c4d04f22db45c8bd335b: Bug 1573276 - Always allow localization in error pages r=johannh,peterv
Alex Catarineu <acat@torproject.org> - Wed, 25 Sep 2019 10:39:45 +0000 - rev 494993
Push 114131 by dluca@mozilla.com at Thu, 26 Sep 2019 09:47:34 +0000
Bug 1573276 - Always allow localization in error pages r=johannh,peterv Differential Revision: https://phabricator.services.mozilla.com/D43216
05dd1a3de4ccff296984df22a5c1bfb578c6a275: Bug 1582520: Part 1 - Treat remote object proxies as opaque wrappers when unwrapping. r=peterv
Kris Maglione <maglione.k@gmail.com> - Wed, 25 Sep 2019 17:49:48 +0000 - rev 494942
Push 114131 by dluca@mozilla.com at Thu, 26 Sep 2019 09:47:34 +0000
Bug 1582520: Part 1 - Treat remote object proxies as opaque wrappers when unwrapping. r=peterv We support calling WebIDL prototype methods on cross-compartment objects as long as they're same-type and same-origin. Any attempt to call them on cross-origin wrappers with security policies leads to a security error. Remote object proxies look and behave like cross-origin objects, but are not technically wrappers. This means that for non-cross-origin-accessible method/getter calls, we just treat them as same-origin objects which do not implement the correct interface. Aside from being confusing, this makes it easy for web content to distinguish between remote and in-process objects with the same interface, which they generally should not be able to do. Treating remote object proxies as if they were opaque wrappers solves these problems. Differential Revision: https://phabricator.services.mozilla.com/D46495
bb9d14131aea0b7464c4d2dc6a97808349dc7090: Bug 1582911 part 2. Fix LenientThis behavior to match spec when a security check fails. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 24 Sep 2019 10:15:43 +0000 - rev 494774
Push 114127 by rgurzau@mozilla.com at Tue, 24 Sep 2019 21:57:45 +0000
Bug 1582911 part 2. Fix LenientThis behavior to match spec when a security check fails. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D46694
8e5289a67e6af729629fe80c140945d58b3c84fb: Bug 1582911 part 1. Fix the exception we throw when binding this-unwrapping fails security checks to match spec. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 24 Sep 2019 10:15:35 +0000 - rev 494773
Push 114127 by rgurzau@mozilla.com at Tue, 24 Sep 2019 21:57:45 +0000
Bug 1582911 part 1. Fix the exception we throw when binding this-unwrapping fails security checks to match spec. r=peterv Spec says to throw a SecurityError, not a TypeError. Differential Revision: https://phabricator.services.mozilla.com/D46693
7af995190f6742650028cf7238ab919a2fcfbe71: Bug 1574195 part 3. Switch XPathEvaluator to using IDL mixins. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 24 Sep 2019 10:10:47 +0000 - rev 494768
Push 114127 by rgurzau@mozilla.com at Tue, 24 Sep 2019 21:57:45 +0000
Bug 1574195 part 3. Switch XPathEvaluator to using IDL mixins. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D46522
e81ff64116372a157c9c94d8d7379c28fe8e12da: Bug 1574195 part 1. Switch message managers from "implements" to IDL mixins. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 24 Sep 2019 16:48:36 +0000 - rev 494766
Push 114127 by rgurzau@mozilla.com at Tue, 24 Sep 2019 21:57:45 +0000
Bug 1574195 part 1. Switch message managers from "implements" to IDL mixins. r=peterv The fact that mixins can't include mixins and can't inherit makes the message manager setup a bit annoying... Differential Revision: https://phabricator.services.mozilla.com/D46520
a4f724ead21abf243f47c5ec3134c0507b16e856: Bug 1580014. Don't force methods into the "can throw any exception" bucket just because they always return a new JS object. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 24 Sep 2019 08:51:47 +0000 - rev 494763
Push 114127 by rgurzau@mozilla.com at Tue, 24 Sep 2019 21:57:45 +0000
Bug 1580014. Don't force methods into the "can throw any exception" bucket just because they always return a new JS object. r=peterv Instead, mark them as "can OOM", since we have that concept now. Differential Revision: https://phabricator.services.mozilla.com/D45251
79ac597adb58c9b4946b82a78eebe7b5aa71e19b: Bug 1582857. Fix security checks around this-unwrapping. r=peterv,bholley
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 24 Sep 2019 01:02:25 +0000 - rev 494613
Push 114124 by cbrindusan@mozilla.com at Tue, 24 Sep 2019 09:47:58 +0000
Bug 1582857. Fix security checks around this-unwrapping. r=peterv,bholley Differential Revision: https://phabricator.services.mozilla.com/D46692
8357c5978e4ce8de5d5b078afc7c8ad94d6685f0: Bug 1582196 part 4. Get rid of NS_ERROR_RANGE_ERR. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 23 Sep 2019 19:14:33 +0000 - rev 494555
Push 114123 by csabou@mozilla.com at Tue, 24 Sep 2019 03:53:15 +0000
Bug 1582196 part 4. Get rid of NS_ERROR_RANGE_ERR. r=peterv The two remaining consumers don't seem to depend on actually using this specific nsresult in any way. Differential Revision: https://phabricator.services.mozilla.com/D46462
b4653a0b413ea2f3eaec57e176c9999432be9b40: Bug 1578296 - TabListener is only for contentSessionStore on FF desktop r=peterv
Alphan Chen <alchen@mozilla.com> - Mon, 09 Sep 2019 13:49:27 +0000 - rev 492329
Push 114051 by rgurzau@mozilla.com at Mon, 09 Sep 2019 21:51:12 +0000
Bug 1578296 - TabListener is only for contentSessionStore on FF desktop r=peterv Don't need TabListener on Thunderbird Differential Revision: https://phabricator.services.mozilla.com/D44995