searching for reviewer(peterv)
3073770e06f1: Bug 1535403 - Take indirection into account for the CC optimizations for the outer window wrapper. r=peterv
Andrew McCreight <continuation@gmail.com> - Mon, 22 Apr 2019 16:34:51 +0000 - rev 470376
Push 112868 by opoprus@mozilla.com at Mon, 22 Apr 2019 22:19:22 +0000
Bug 1535403 - Take indirection into account for the CC optimizations for the outer window wrapper. r=peterv Most wrapper cached C++ objects are held alive by their wrapper. The cycle collector takes advantage of this in many classes and ignores the C++ object if the wrapper is marked black. However, this is not true for the outer window's wrapper. Instead, the outer window's wrapper keeps the inner window alive. The inner window usually keeps its outer window alive, but not after it has been unlinked. For reasons I do not yet understand, the outer window's wrapper can be kept alive after the inner window it is a proxy for is unlinked. This patch fixes the cycle collector optimization for the outer window by only applying it if the outer window still has a weak reference to the inner window, which it will until the inner no longer holds the outer alive. This in turn fixes, or at least helps fix, window leaks seen intermittently when the lifetime of outer windows and docshells are tied together. The code comment is based on a review comment by peterv. Differential Revision: https://phabricator.services.mozilla.com/D27981
607e1bc95c9b: Bug 1542790 - Part 2: Use BC::GetParent and BC::GetTop for local windows, r=peterv
Nika Layzell <nika@thelayzells.com> - Wed, 17 Apr 2019 00:53:09 +0000 - rev 469845
Push 112826 by btara@mozilla.com at Wed, 17 Apr 2019 21:50:20 +0000
Bug 1542790 - Part 2: Use BC::GetParent and BC::GetTop for local windows, r=peterv This is required to support getting the `parent` and `top` properties from within remote subframes. Differential Revision: https://phabricator.services.mozilla.com/D26559
5fde2cc9277a: Bug 1542790 - Part 1: BC::GetParent on toplevel windows should be self, r=peterv
Nika Layzell <nika@thelayzells.com> - Wed, 17 Apr 2019 00:53:05 +0000 - rev 469844
Push 112826 by btara@mozilla.com at Wed, 17 Apr 2019 21:50:20 +0000
Bug 1542790 - Part 1: BC::GetParent on toplevel windows should be self, r=peterv Differential Revision: https://phabricator.services.mozilla.com/D26558
ca2c4053e33c: Bug 1542787 - Support getting contentWindow on out-of-process frames, r=peterv
Nika Layzell <nika@thelayzells.com> - Thu, 11 Apr 2019 18:56:48 +0000 - rev 469533
Push 112801 by ccoroiu@mozilla.com at Mon, 15 Apr 2019 21:40:09 +0000
Bug 1542787 - Support getting contentWindow on out-of-process frames, r=peterv Differential Revision: https://phabricator.services.mozilla.com/D26556
0b0a39e79b6e: Bug 1539694 - Part 3: Update xray tests for Promise. r=peterv
André Bargull <andre.bargull@gmail.com> - Thu, 11 Apr 2019 21:07:00 +0000 - rev 469128
Push 112769 by csabou@mozilla.com at Fri, 12 Apr 2019 03:51:12 +0000
Bug 1539694 - Part 3: Update xray tests for Promise. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D26144
b69cb7f4f305: Bug 1539694 - Part 3: Update xray tests for Promise. r=peterv
André Bargull <andre.bargull@gmail.com> - Wed, 10 Apr 2019 10:29:49 +0000 - rev 469097
Push 112769 by csabou@mozilla.com at Fri, 12 Apr 2019 03:51:12 +0000
Bug 1539694 - Part 3: Update xray tests for Promise. r=peterv Depends on D25209 Differential Revision: https://phabricator.services.mozilla.com/D26144
e251a566abb6: bug 1524359 - 49,600 instances of "NS_ENSURE_SUCCESS(rv, false) failed with result 0x80004005" emitted from docshell/shistory/nsSHistory.cpp during linux64 debug testing r=peterv
Khyati Agarwal <f20160385@hyderabad.bits-pilani.ac.in> - Thu, 11 Apr 2019 12:11:05 +0000 - rev 469028
Push 112769 by csabou@mozilla.com at Fri, 12 Apr 2019 03:51:12 +0000
bug 1524359 - 49,600 instances of "NS_ENSURE_SUCCESS(rv, false) failed with result 0x80004005" emitted from docshell/shistory/nsSHistory.cpp during linux64 debug testing r=peterv Replaced "NS_ENSURE_SUCCESS" with 'if' condition Differential Revision: https://phabricator.services.mozilla.com/D25529
e93e17bb399a: Bug 1543461. Add the missing newline after a static assert in Web IDL codegen. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 10 Apr 2019 19:05:15 +0000 - rev 468921
Push 112762 by aciure@mozilla.com at Thu, 11 Apr 2019 09:57:48 +0000
Bug 1543461. Add the missing newline after a static assert in Web IDL codegen. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D26960
65f7904484c8: Bug 1507004, get the contentDocument for all iframes, to ensure that the iframe is focusable, r=peterv
Neil Deakin <neil@mozilla.com> - Mon, 01 Apr 2019 09:09:04 -0400 - rev 467029
Push 112622 by neil@mozilla.com at Mon, 01 Apr 2019 13:09:47 +0000
Bug 1507004, get the contentDocument for all iframes, to ensure that the iframe is focusable, r=peterv
95f9efbbf805: Bug 1533413 - Add Symbol.matchAll to list of expected RegExp methods. r=peterv
Jason Orendorff <jorendorff@mozilla.com> - Mon, 11 Mar 2019 10:20:38 +0000 - rev 463448
Push 112390 by rgurzau@mozilla.com at Mon, 11 Mar 2019 16:57:46 +0000
Bug 1533413 - Add Symbol.matchAll to list of expected RegExp methods. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D22583
60142f1fcb4c: Bug 1527277 - Part 4: Add crashtest. r=peterv
Eric Rahm <erahm@mozilla.com> - Wed, 06 Mar 2019 18:54:27 +0000 - rev 462706
Push 112326 by ccoroiu@mozilla.com at Thu, 07 Mar 2019 04:41:19 +0000
Bug 1527277 - Part 4: Add crashtest. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D20581
b4fef176bc8f: Bug 1527277 - Part 3: Validate usage of string iterator. r=peterv
Eric Rahm <erahm@mozilla.com> - Wed, 06 Mar 2019 18:55:54 +0000 - rev 462705
Push 112326 by ccoroiu@mozilla.com at Thu, 07 Mar 2019 04:41:19 +0000
Bug 1527277 - Part 3: Validate usage of string iterator. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D20580
7ce2309548da: Bug 1527277 - Part 2: Use unique pointer to manage buffer lifetime. r=peterv
Eric Rahm <erahm@mozilla.com> - Thu, 21 Feb 2019 23:06:04 +0000 - rev 462704
Push 112326 by ccoroiu@mozilla.com at Thu, 07 Mar 2019 04:41:19 +0000
Bug 1527277 - Part 2: Use unique pointer to manage buffer lifetime. r=peterv Switch to managing the buffer lifetime with a UniquePtr. This will make handling errors simpler in the next patch. Differential Revision: https://phabricator.services.mozilla.com/D20579
62aba7d6d779: Bug 1527277 - Part 1: Refactor error reporting logic. r=peterv
Eric Rahm <erahm@mozilla.com> - Thu, 21 Feb 2019 23:07:05 +0000 - rev 462703
Push 112326 by ccoroiu@mozilla.com at Thu, 07 Mar 2019 04:41:19 +0000
Bug 1527277 - Part 1: Refactor error reporting logic. r=peterv Add a common function for reporting an invalid argument. Differential Revision: https://phabricator.services.mozilla.com/D20578
d7d6b249119a: Bug 1497147 - Rewrite "mapFrameTree" implementation to C++ r=peterv
Alphan Chen <alchen@mozilla.com> - Thu, 28 Feb 2019 13:09:54 +0000 - rev 461755
Push 112218 by opoprus@mozilla.com at Thu, 28 Feb 2019 22:09:07 +0000
Bug 1497147 - Rewrite "mapFrameTree" implementation to C++ r=peterv Get rid of mapFrameTree() implementation Differential Revision: https://phabricator.services.mozilla.com/D17149
fcf3d5468b1f: Bug 1525101 - adjust nsIFormFillController to make custom elements popup working, r=peterv
Alexander Surkov <surkov.alexander@gmail.com> - Mon, 25 Feb 2019 20:02:35 +0000 - rev 461010
Push 112146 by nerli@mozilla.com at Tue, 26 Feb 2019 04:26:08 +0000
Bug 1525101 - adjust nsIFormFillController to make custom elements popup working, r=peterv Differential Revision: https://phabricator.services.mozilla.com/D20505
bea571f9708b: Bug 1525101 - adjust nsIAutoCompletePopup to make custom element popups working, r=peterv
Alexander Surkov <surkov.alexander@gmail.com> - Mon, 25 Feb 2019 20:02:17 +0000 - rev 461009
Push 112146 by nerli@mozilla.com at Tue, 26 Feb 2019 04:26:08 +0000
Bug 1525101 - adjust nsIAutoCompletePopup to make custom element popups working, r=peterv Differential Revision: https://phabricator.services.mozilla.com/D20504
996e8765c85a: Bug 1515646 - Test BrowsingContext::FindWithName. r=peterv
Andreas Farre <farre@mozilla.com> - Fri, 15 Feb 2019 11:17:50 +0000 - rev 459518
Push 111964 by csabou@mozilla.com at Fri, 15 Feb 2019 18:54:44 +0000
Bug 1515646 - Test BrowsingContext::FindWithName. r=peterv Test that BrowsingContext::FindWithName finds the expected BrowsingContexts and also that BrowsingContext::FindWithName finds the same browsing contexts as if nsIDocShellTreeItem::FindItemWithName had been used. Differential Revision: https://phabricator.services.mozilla.com/D15191
9243ddacadcc: Bug 1515646 - Add FindWithName and FindChildWithName to BrowsingContext. r=peterv
Andreas Farre <farre@mozilla.com> - Fri, 15 Feb 2019 09:59:21 +0000 - rev 459515
Push 111964 by csabou@mozilla.com at Fri, 15 Feb 2019 18:54:44 +0000
Bug 1515646 - Add FindWithName and FindChildWithName to BrowsingContext. r=peterv This implements the step of choosing a browsing context with FindWithName, which should be equivalent to calling nsIDocShellTreeItem.findItemWithName passing null for 'aRequestor' and 'aOriginalRequestor' and false for 'aSkipTabGroup'. Differential Revision: https://phabricator.services.mozilla.com/D15190
3dd87564278e: Bug 1525145, remove harmless assertions by using IgnoredErrorResult, r=peterv
Olli Pettay <Olli.Pettay@helsinki.fi> - Wed, 13 Feb 2019 22:51:10 +0200 - rev 458866
Push 111900 by opettay@mozilla.com at Wed, 13 Feb 2019 20:52:16 +0000
Bug 1525145, remove harmless assertions by using IgnoredErrorResult, r=peterv
100d9de169ab: Bug 1525673. Don't assume that same-compartment means same-realm in WrapNewBindingNonWrapperCache. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 11 Feb 2019 13:33:23 +0000 - rev 458508
Push 111855 by btara@mozilla.com at Mon, 11 Feb 2019 22:01:49 +0000
Bug 1525673. Don't assume that same-compartment means same-realm in WrapNewBindingNonWrapperCache. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D18863
57664c81a1de: Bug 1516642 - Add a function declaration for arc4random_buf in expat. r=peterv
Mike Hommey <mh+mozilla@glandium.org> - Fri, 08 Feb 2019 13:48:36 +0000 - rev 458406
Push 111821 by dvarga@mozilla.com at Sat, 09 Feb 2019 21:55:30 +0000
Bug 1516642 - Add a function declaration for arc4random_buf in expat. r=peterv The function has been in bionic (Android's libc since the first commit in the upstream repository), but it's not been in stdlib.h until recently. As it happens, we have a similar declaration in xpcom/base/nsUUIDGenerator.cpp. Differential Revision: https://phabricator.services.mozilla.com/D19120
b7646b8ccfd3: Bug 1525355. Make sure to clear out the cached-function-map slot on WindowProxy before we transplant it. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 06 Feb 2019 13:01:27 +0000 - rev 457447
Push 111729 by rgurzau@mozilla.com at Wed, 06 Feb 2019 22:00:03 +0000
Bug 1525355. Make sure to clear out the cached-function-map slot on WindowProxy before we transplant it. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D18725
4d21e1285e2a: Bug 1514098 - Don't call into UA Widget distructor if the element is being CC'd r=peterv,bgrins
Timothy Guan-tin Chien <timdream@gmail.com> - Mon, 04 Feb 2019 13:56:22 +0000 - rev 457245
Push 111711 by csabou@mozilla.com at Tue, 05 Feb 2019 23:12:20 +0000
Bug 1514098 - Don't call into UA Widget distructor if the element is being CC'd r=peterv,bgrins Differential Revision: https://phabricator.services.mozilla.com/D18130
f39008382451: Bug 1521907 part 6. Start using CheckedUnwrapStatic/Dynamic in toolkit. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Sat, 02 Feb 2019 03:25:07 +0000 - rev 456534
Push 111656 by dvarga@mozilla.com at Sat, 02 Feb 2019 09:51:54 +0000
Bug 1521907 part 6. Start using CheckedUnwrapStatic/Dynamic in toolkit. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D17886
a0b9977daa36: Bug 1521907 part 5. Start using CheckedUnwrapStatic/Dynamic in XPConnect. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Sat, 02 Feb 2019 03:24:45 +0000 - rev 456533
Push 111656 by dvarga@mozilla.com at Sat, 02 Feb 2019 09:51:54 +0000
Bug 1521907 part 5. Start using CheckedUnwrapStatic/Dynamic in XPConnect. r=peterv I am not a huge fan of the UnwrapReflectorToISupports setup here. Maybe we should introduce two differently-named methods that make it somewhat clear what the limitations of not taking a JSContext are? I couldn't think of sane naming... Differential Revision: https://phabricator.services.mozilla.com/D17885
f41215bdded6: Bug 1521907 part 4. Start using CheckedUnwrapStatic/Dynamic in non-binding DOM code. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Sat, 02 Feb 2019 03:24:22 +0000 - rev 456532
Push 111656 by dvarga@mozilla.com at Sat, 02 Feb 2019 09:51:54 +0000
Bug 1521907 part 4. Start using CheckedUnwrapStatic/Dynamic in non-binding DOM code. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D17884
64af12d24e9d: Bug 1521907 part 3. Start using CheckedUnwrapStatic/Dynamic in bindings. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Sat, 02 Feb 2019 03:23:49 +0000 - rev 456531
Push 111656 by dvarga@mozilla.com at Sat, 02 Feb 2019 09:51:54 +0000
Bug 1521907 part 3. Start using CheckedUnwrapStatic/Dynamic in bindings. r=peterv The basic idea for the changes around UnwrapObjectInternal and its callers (UnwrapObject, UNWRAP_OBJECT, etc) is to add a parameter to the guts of the object-unwrapping code in bindings which can be either a JSContext* or nullptr (statically typed). Then we test which type it is and do either a CheckedUnwrapDynamic or CheckedUnwrapStatic. Since the type is known at compile time, there is no actual runtime check; the compiler just emits a call to the right thing directly (verified by examining the assembly output on Linux). The rest of the changes are mostly propagating through that template parameter, adding static asserts to make sure people don't accidentally pass nullptr while trying to unwrap to a type that might be a WindowProxy or Location, etc. There are also some changes to places that were calling CheckedUnwrap directly to use either the static or dynamic version, as needed. Differential Revision: https://phabricator.services.mozilla.com/D17883
46854f5097bb: Bug 1521907 part 2. Add dynamic CheckedUnwrap support to CrossOriginObjectWrapper. r=peterv,sfink
Boris Zbarsky <bzbarsky@mit.edu> - Sat, 02 Feb 2019 03:23:16 +0000 - rev 456530
Push 111656 by dvarga@mozilla.com at Sat, 02 Feb 2019 09:51:54 +0000
Bug 1521907 part 2. Add dynamic CheckedUnwrap support to CrossOriginObjectWrapper. r=peterv,sfink This will allow us to correctly handle CheckedUnwrapDynamic on wrappers around WindowProxy and Location. Differential Revision: https://phabricator.services.mozilla.com/D17882
ac1c61bf61e9: Bug 1521907 part 6. Start using CheckedUnwrapStatic/Dynamic in toolkit. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 01 Feb 2019 18:49:45 +0000 - rev 456509
Push 111656 by dvarga@mozilla.com at Sat, 02 Feb 2019 09:51:54 +0000
Bug 1521907 part 6. Start using CheckedUnwrapStatic/Dynamic in toolkit. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D17886
df09b7be63c5: Bug 1521907 part 5. Start using CheckedUnwrapStatic/Dynamic in XPConnect. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 01 Feb 2019 18:49:04 +0000 - rev 456508
Push 111656 by dvarga@mozilla.com at Sat, 02 Feb 2019 09:51:54 +0000
Bug 1521907 part 5. Start using CheckedUnwrapStatic/Dynamic in XPConnect. r=peterv I am not a huge fan of the UnwrapReflectorToISupports setup here. Maybe we should introduce two differently-named methods that make it somewhat clear what the limitations of not taking a JSContext are? I couldn't think of sane naming... Differential Revision: https://phabricator.services.mozilla.com/D17885
585fa0024d46: Bug 1521907 part 4. Start using CheckedUnwrapStatic/Dynamic in non-binding DOM code. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 01 Feb 2019 18:48:36 +0000 - rev 456507
Push 111656 by dvarga@mozilla.com at Sat, 02 Feb 2019 09:51:54 +0000
Bug 1521907 part 4. Start using CheckedUnwrapStatic/Dynamic in non-binding DOM code. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D17884
e593c29aaff4: Bug 1521907 part 3. Start using CheckedUnwrapStatic/Dynamic in bindings. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 01 Feb 2019 18:48:13 +0000 - rev 456506
Push 111656 by dvarga@mozilla.com at Sat, 02 Feb 2019 09:51:54 +0000
Bug 1521907 part 3. Start using CheckedUnwrapStatic/Dynamic in bindings. r=peterv The basic idea for the changes around UnwrapObjectInternal and its callers (UnwrapObject, UNWRAP_OBJECT, etc) is to add a parameter to the guts of the object-unwrapping code in bindings which can be either a JSContext* or nullptr (statically typed). Then we test which type it is and do either a CheckedUnwrapDynamic or CheckedUnwrapStatic. Since the type is known at compile time, there is no actual runtime check; the compiler just emits a call to the right thing directly (verified by examining the assembly output on Linux). The rest of the changes are mostly propagating through that template parameter, adding static asserts to make sure people don't accidentally pass nullptr while trying to unwrap to a type that might be a WindowProxy or Location, etc. There are also some changes to places that were calling CheckedUnwrap directly to use either the static or dynamic version, as needed. Differential Revision: https://phabricator.services.mozilla.com/D17883
ac2e180a35b6: Bug 1521907 part 2. Add dynamic CheckedUnwrap support to CrossOriginObjectWrapper. r=peterv,sfink
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 01 Feb 2019 22:00:58 +0000 - rev 456505
Push 111656 by dvarga@mozilla.com at Sat, 02 Feb 2019 09:51:54 +0000
Bug 1521907 part 2. Add dynamic CheckedUnwrap support to CrossOriginObjectWrapper. r=peterv,sfink This will allow us to correctly handle CheckedUnwrapDynamic on wrappers around WindowProxy and Location. Differential Revision: https://phabricator.services.mozilla.com/D17882
efd05f4979f1: Bug 1521907 part 6. Start using CheckedUnwrapStatic/Dynamic in toolkit. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 01 Feb 2019 13:22:44 +0000 - rev 456460
Push 111652 by ncsoregi@mozilla.com at Fri, 01 Feb 2019 22:14:41 +0000
Bug 1521907 part 6. Start using CheckedUnwrapStatic/Dynamic in toolkit. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D17886
2d0895148907: Bug 1521907 part 5. Start using CheckedUnwrapStatic/Dynamic in XPConnect. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 01 Feb 2019 16:17:44 +0000 - rev 456459
Push 111652 by ncsoregi@mozilla.com at Fri, 01 Feb 2019 22:14:41 +0000
Bug 1521907 part 5. Start using CheckedUnwrapStatic/Dynamic in XPConnect. r=peterv I am not a huge fan of the UnwrapReflectorToISupports setup here. Maybe we should introduce two differently-named methods that make it somewhat clear what the limitations of not taking a JSContext are? I couldn't think of sane naming... Differential Revision: https://phabricator.services.mozilla.com/D17885
192152fe986a: Bug 1521907 part 4. Start using CheckedUnwrapStatic/Dynamic in non-binding DOM code. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 31 Jan 2019 15:51:52 +0000 - rev 456458
Push 111652 by ncsoregi@mozilla.com at Fri, 01 Feb 2019 22:14:41 +0000
Bug 1521907 part 4. Start using CheckedUnwrapStatic/Dynamic in non-binding DOM code. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D17884
ca65b46b0d37: Bug 1521907 part 3. Start using CheckedUnwrapStatic/Dynamic in bindings. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 31 Jan 2019 15:50:06 +0000 - rev 456457
Push 111652 by ncsoregi@mozilla.com at Fri, 01 Feb 2019 22:14:41 +0000
Bug 1521907 part 3. Start using CheckedUnwrapStatic/Dynamic in bindings. r=peterv The basic idea for the changes around UnwrapObjectInternal and its callers (UnwrapObject, UNWRAP_OBJECT, etc) is to add a parameter to the guts of the object-unwrapping code in bindings which can be either a JSContext* or nullptr (statically typed). Then we test which type it is and do either a CheckedUnwrapDynamic or CheckedUnwrapStatic. Since the type is known at compile time, there is no actual runtime check; the compiler just emits a call to the right thing directly (verified by examining the assembly output on Linux). The rest of the changes are mostly propagating through that template parameter, adding static asserts to make sure people don't accidentally pass nullptr while trying to unwrap to a type that might be a WindowProxy or Location, etc. There are also some changes to places that were calling CheckedUnwrap directly to use either the static or dynamic version, as needed. Differential Revision: https://phabricator.services.mozilla.com/D17883
b3daf5ca3d11: Bug 1521907 part 2. Add dynamic CheckedUnwrap support to CrossOriginObjectWrapper. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 31 Jan 2019 11:22:53 +0000 - rev 456456
Push 111652 by ncsoregi@mozilla.com at Fri, 01 Feb 2019 22:14:41 +0000
Bug 1521907 part 2. Add dynamic CheckedUnwrap support to CrossOriginObjectWrapper. r=peterv This will allow us to correctly handle CheckedUnwrapDynamic on wrappers around WindowProxy and Location. Differential Revision: https://phabricator.services.mozilla.com/D17882
a66d868f77c4: Bug 1497146 part 3 - Convert FormData.jsm to C++ [restore() part] r=peterv,mikedeboer
Alphan Chen <alchen@mozilla.com> - Mon, 28 Jan 2019 19:44:03 +0000 - rev 455779
Push 111545 by archaeopteryx@coole-files.de at Tue, 29 Jan 2019 10:55:53 +0000
Bug 1497146 part 3 - Convert FormData.jsm to C++ [restore() part] r=peterv,mikedeboer Differential Revision: https://phabricator.services.mozilla.com/D12672
21ad3aeb636f: Bug 1497146 part 3 - Convert FormData.jsm to C++ [restore() part] r=peterv,mikedeboer
Alphan Chen <alchen@mozilla.com> - Fri, 25 Jan 2019 10:19:04 +0000 - rev 455433
Push 111469 by ccoroiu@mozilla.com at Fri, 25 Jan 2019 21:56:18 +0000
Bug 1497146 part 3 - Convert FormData.jsm to C++ [restore() part] r=peterv,mikedeboer Differential Revision: https://phabricator.services.mozilla.com/D12672
a6cc9b15b1e3: Bug 1497146 part 3 - Convert FormData.jsm to C++ [restore() part] r=peterv,mikedeboer
Alphan Chen <alchen@mozilla.com> - Thu, 24 Jan 2019 12:53:28 +0000 - rev 455290
Push 111440 by nbeleuzu@mozilla.com at Thu, 24 Jan 2019 21:48:07 +0000
Bug 1497146 part 3 - Convert FormData.jsm to C++ [restore() part] r=peterv,mikedeboer Differential Revision: https://phabricator.services.mozilla.com/D12672
dbab9ee37db1: Bug 1363208 part 9. Remove now-unused cross-origin Xray infrastructure. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 21 Jan 2019 03:33:55 +0000 - rev 454672
Push 111317 by rmaries@mozilla.com at Mon, 21 Jan 2019 18:01:55 +0000
Bug 1363208 part 9. Remove now-unused cross-origin Xray infrastructure. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D15433
d4d779afb736: Bug 1363208 part 8. Stop using cross-origin Xrays for Location. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 21 Jan 2019 03:33:32 +0000 - rev 454671
Push 111317 by rmaries@mozilla.com at Mon, 21 Jan 2019 18:01:55 +0000
Bug 1363208 part 8. Stop using cross-origin Xrays for Location. r=peterv The test change is because it was testing Window, not Location. Differential Revision: https://phabricator.services.mozilla.com/D15432
140c8b32490c: Bug 1363208 part 7. Change the Location binding to inherit from MaybeCrossOriginObject. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 21 Jan 2019 04:26:13 +0000 - rev 454670
Push 111317 by rmaries@mozilla.com at Mon, 21 Jan 2019 18:01:55 +0000
Bug 1363208 part 7. Change the Location binding to inherit from MaybeCrossOriginObject. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D15431
c825004b9059: Bug 1363208 part 6. Remove the NonOrdinaryGetPrototypeOf annotation. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 21 Jan 2019 03:33:16 +0000 - rev 454669
Push 111317 by rmaries@mozilla.com at Mon, 21 Jan 2019 18:01:55 +0000
Bug 1363208 part 6. Remove the NonOrdinaryGetPrototypeOf annotation. r=peterv We can just check for a non-global object (so excluding Window) with cross-origin properties. Differential Revision: https://phabricator.services.mozilla.com/D15430
7faa84f9f73a: Bug 1363208 part 5. Remove now-unnecessary named subframe handling from XrayWrapper. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 21 Jan 2019 03:33:14 +0000 - rev 454668
Push 111317 by rmaries@mozilla.com at Mon, 21 Jan 2019 18:01:55 +0000
Bug 1363208 part 5. Remove now-unnecessary named subframe handling from XrayWrapper. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D15429
2e31b4d57c6a: Bug 1363208 part 4. Stop using cross-origin Xrays for WindowProxy. r=peterv,jandem
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 21 Jan 2019 03:30:31 +0000 - rev 454667
Push 111317 by rmaries@mozilla.com at Mon, 21 Jan 2019 18:01:55 +0000
Bug 1363208 part 4. Stop using cross-origin Xrays for WindowProxy. r=peterv,jandem The change to test_bug440572.html is due to a behavior change. Specifically, before this change, any IDL-declared property, even one not exposed cross-origin, would prevent named frames with that name being visible cross-origin. The new behavior is that cross-origin-exposed IDL properties prevent corresponding frame names from being visible, but ones not exposed cross-origin don't. This matches the spec and other browsers. Same thing for the changes to test_bug860494.xul. The wpt test changes are just adding test coverage for the thing the other tests caught. Differential Revision: https://phabricator.services.mozilla.com/D15428
9b1badc02fd1: Bug 1363208 part 3. Change nsOuterWindowProxy to inherit from MaybeCrossOriginObject. r=peterv,jandem
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 21 Jan 2019 03:28:55 +0000 - rev 454666
Push 111317 by rmaries@mozilla.com at Mon, 21 Jan 2019 18:01:55 +0000
Bug 1363208 part 3. Change nsOuterWindowProxy to inherit from MaybeCrossOriginObject. r=peterv,jandem The cross-origin named window code in nsOuterWindowProxy::getOwnPropertyDescriptor is mostly copied from XrayWrapper::getPropertyDescriptor, with some minor changes because we can't assume some work that CrossOriginXrayWrapper does. The getPropertyDescriptor version will go away in a later patch in this stack. Differential Revision: https://phabricator.services.mozilla.com/D15427
52f7c0595d0d: Bug 1363208 part 2. Add a helper class for implementing the HTML requirements for cross-origin-accessible objects. r=jandem,peterv
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 21 Jan 2019 03:28:06 +0000 - rev 454665
Push 111317 by rmaries@mozilla.com at Mon, 21 Jan 2019 18:01:55 +0000
Bug 1363208 part 2. Add a helper class for implementing the HTML requirements for cross-origin-accessible objects. r=jandem,peterv Differential Revision: https://phabricator.services.mozilla.com/D15425