searching for reviewer(pehrsons)
3b21c6bc1e1c58fefc34c71ad370fe903c42613f: Bug 1595618 - Optimize SourceListener iteration on devicechange. r=pehrsons
Jan-Ivar Bruaroey <jib@mozilla.com> - Tue, 12 Nov 2019 14:50:24 +0000 - rev 501599
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1595618 - Optimize SourceListener iteration on devicechange. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D52598
6c86995d33de69e490386b0d4eb66ccc68680ef6: Bug 1586057 - Avoid stepping on docShells of unrelated docs in MediaManager device stopping code. r=bzbarsky,pehrsons
Jan-Ivar Bruaroey <jib@mozilla.com> - Mon, 11 Nov 2019 21:56:15 +0000 - rev 501529
Push 114170 by malexandru@mozilla.com at Tue, 12 Nov 2019 21:58:32 +0000
Bug 1586057 - Avoid stepping on docShells of unrelated docs in MediaManager device stopping code. r=bzbarsky,pehrsons Differential Revision: https://phabricator.services.mozilla.com/D52427
6d4a958ff1554c7bc1258da680cb7c9327af529b: Bug 1594141 - Handle failure to reconfigure video encoder in MediaEncoder. r=pehrsons
Bryce Seager van Dyk <bvandyk@mozilla.com> - Thu, 07 Nov 2019 23:11:30 +0000 - rev 501338
Push 114168 by dluca@mozilla.com at Sun, 10 Nov 2019 03:08:55 +0000
Bug 1594141 - Handle failure to reconfigure video encoder in MediaEncoder. r=pehrsons If the VP8 encoder fails to reconfigure in the middle of a stream it can transition from a state where it was returning `true` for `IsInitialized` to then returning false. This would trigger an assert in `GetEncodedData` in `MediaEncoder`. This patch changes to instead handle this case by early returning if we're in an error state, and ensuring we enter the error state if a track encoder fails to reconfigure. Update the TrackEncoder contract to differentiate the error used if encoding has been canceled or completed, from other, more severe errors. This also adjusts the logs in the vp8 track encoder to more clearly log if a reconfigure of the encoder failed or not. Differential Revision: https://phabricator.services.mozilla.com/D51956
0516cc76b5b20ede18eafb873a289d7ababa905a: Bug 1594141 - Add crashtest for if a Vp8 track encoder becomes uninitialized mid stream. r=pehrsons
Bryce Seager van Dyk <bvandyk@mozilla.com> - Thu, 07 Nov 2019 23:11:17 +0000 - rev 501337
Push 114168 by dluca@mozilla.com at Sun, 10 Nov 2019 03:08:55 +0000
Bug 1594141 - Add crashtest for if a Vp8 track encoder becomes uninitialized mid stream. r=pehrsons This is adapted from the original test on the bug. The only changes are: - Adding reftest-wait so the test plays nice with our harness. - Removing code that doesn't appear required to hit the assert. - There are a few lines that don't appear needed. - Simplified some arguments to make the test more human readable. Differential Revision: https://phabricator.services.mozilla.com/D51955
a04cf95c417d672597ff34e0f50218333ac7608e: Bug 1593203 - Proper initialization of nested dictionaries for MediaDebugInfo.webidl r=pehrsons,bzbarsky
Tarek Ziadé <tarek@mozilla.com> - Thu, 07 Nov 2019 09:22:29 +0000 - rev 501046
Push 114167 by csabou@mozilla.com at Fri, 08 Nov 2019 00:35:25 +0000
Bug 1593203 - Proper initialization of nested dictionaries for MediaDebugInfo.webidl r=pehrsons,bzbarsky The debug dictionaries in MediaDebugInfo.webidl all have default values, and the intent when the debug structure is created by the C++ promise is to initialize all values, including nested dictionaries, to the provided defaults. **required** was not the right way to do this. Differential Revision: https://phabricator.services.mozilla.com/D51822
91b3fc6f5fa0c418db43b4154f90a8040f97ad52: Bug 1593161 - Fixed video capturing on Mac. (from upstream) r=pehrsons
Jan-Ivar Bruaroey <jib@mozilla.com> - Tue, 05 Nov 2019 08:07:48 +0000 - rev 500563
Push 114166 by apavel@mozilla.com at Thu, 07 Nov 2019 10:04:01 +0000
Bug 1593161 - Fixed video capturing on Mac. (from upstream) r=pehrsons On specific Macbooks (no exact pattern, unfortunately), video from an integrated camera is not captured. Changed AVCaptureVideoDataOutput pixel format configuration as in Chromium which solved the problem. https://chromium.googlesource.com/chromium/src/media/+/master/capture/video/mac/video_capture_device_avfoundation_mac.mm FourCharCode best_fourcc = kCVPixelFormatType_422YpCbCr8; Tested with external cameras as well. Bug: webrtc:8958 Differential Revision: https://phabricator.services.mozilla.com/D51733
956fbf0fe9291a999beab00107114767b3bfc6c8: Bug 1592915 - Fix three warnings in `VideoFrameConverter.h` and `TestVideoTrackEncoder.h`. r=pehrsons
Paul Adenot <paul@paul.cx> - Thu, 31 Oct 2019 12:12:19 +0000 - rev 499972
Push 114164 by aiakab@mozilla.com at Tue, 05 Nov 2019 10:06:15 +0000
Bug 1592915 - Fix three warnings in `VideoFrameConverter.h` and `TestVideoTrackEncoder.h`. r=pehrsons This warns because an expression with a side effect is inside a `static_assert` or `sizeof`. Differential Revision: https://phabricator.services.mozilla.com/D51243
75ed11ced6252acd0119752477d50682be546a73: Bug 1592915 - Fix three warnings in `VideoFrameConverter.h` and `TestVideoTrackEncoder.h`. r=pehrsons
Paul Adenot <paul@paul.cx> - Thu, 31 Oct 2019 10:50:51 +0000 - rev 499961
Push 114164 by aiakab@mozilla.com at Tue, 05 Nov 2019 10:06:15 +0000
Bug 1592915 - Fix three warnings in `VideoFrameConverter.h` and `TestVideoTrackEncoder.h`. r=pehrsons This warns because an expression with a side effect is inside a `static_assert` or `sizeof`. Differential Revision: https://phabricator.services.mozilla.com/D51243
63f3e109f02b99fe7ef765e452e59c676c68fffb: Bug 1420893 - Remove mediaconduit_unittests; r=pehrsons
Dan Minor <dminor@mozilla.com> - Wed, 30 Oct 2019 11:31:23 +0000 - rev 499766
Push 114163 by aiakab@mozilla.com at Thu, 31 Oct 2019 10:03:38 +0000
Bug 1420893 - Remove mediaconduit_unittests; r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D50971
25bf8e097e604cca2842af6754c2c1698db5618a: Bug 1543622 - Make number of channels out param of GetAudioFrame; r=pehrsons
Dan Minor <dminor@mozilla.com> - Tue, 29 Oct 2019 17:30:03 +0000 - rev 499657
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1543622 - Make number of channels out param of GetAudioFrame; r=pehrsons The number of channels is available in mAudioFrame in GetAudioFrame so there is no reason to calculate it after the fact in MediaPipeline. Differential Revision: https://phabricator.services.mozilla.com/D50934
257c1099e4e0d71c04b4e4cef6bceea25115c115: Bug 1590135 - Don't call stop in AsyncLogger destructor. r=pehrsons
Paul Adenot <paul@paul.cx> - Tue, 22 Oct 2019 14:02:53 +0000 - rev 498566
Push 114159 by shindli@mozilla.com at Thu, 24 Oct 2019 09:49:00 +0000
Bug 1590135 - Don't call stop in AsyncLogger destructor. r=pehrsons It does not achieve anything and crashes if the log module manager hasn't been initialized. Differential Revision: https://phabricator.services.mozilla.com/D49958
e322e2112b1f07758d92dac2553af17ece2a28d9: Bug 1248897 - Introducing an online speech recognition service for Web Speech API r=smaug,pehrsons,padenot
Andre Natal <anatal@gmail.com> - Mon, 21 Oct 2019 20:58:57 +0000 - rev 498458
Push 114158 by ncsoregi@mozilla.com at Tue, 22 Oct 2019 09:53:30 +0000
Bug 1248897 - Introducing an online speech recognition service for Web Speech API r=smaug,pehrsons,padenot This patch introduces a Speech Recognition Service which interfaces with Mozilla's remote STT endpoint which is currently being used by multiple services Differential Revision: https://phabricator.services.mozilla.com/D26047
fd81bc5ca14623a917cc213b4ae06cd3eb6d4be5: Bug 1508567 - Move call to run_function_deprecated_ to outside of message loop; r=pehrsons
Dan Minor <dminor@mozilla.com> - Wed, 16 Oct 2019 12:11:43 +0000 - rev 497828
Push 114154 by btara@mozilla.com at Thu, 17 Oct 2019 09:58:40 +0000
Bug 1508567 - Move call to run_function_deprecated_ to outside of message loop; r=pehrsons This moves the call to run_function_deprecated_, which ensures it is called at least once prior to the thread exiting, to outside of the do/while loop. As written, it is being called every time a message is received, causing desktop capture frame rates on Windows to be higher than expected. Differential Revision: https://phabricator.services.mozilla.com/D49412
5976eb8e6be6aa0822752a6648f9a5fb13cdad23: Bug 1509316 - p4: disable HW codec in WebRTC tests. r=pehrsons,drno
John Lin <jolin@mozilla.com> - Wed, 09 Oct 2019 23:15:56 +0000 - rev 497060
Push 114147 by ccoroiu@mozilla.com at Thu, 10 Oct 2019 09:56:56 +0000
Bug 1509316 - p4: disable HW codec in WebRTC tests. r=pehrsons,drno Differential Revision: https://phabricator.services.mozilla.com/D47713
a57eab6eda4b3da89e9192e5b7df86f7e70a379e: Bug 1581902 - p6: introduce a pref to enable/disable H.264 for WebRTC. r=pehrsons
John Lin <jolin@mozilla.com> - Tue, 08 Oct 2019 17:16:01 +0000 - rev 496790
Push 114146 by dmajor@mozilla.com at Wed, 09 Oct 2019 17:52:49 +0000
Bug 1581902 - p6: introduce a pref to enable/disable H.264 for WebRTC. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D46368
20a0cccb492f99cefdfd6ae7a5c35ada3fd2eb56: Bug 1581902 - p5: check H.264 hardware availability. r=pehrsons
John Lin <jolin@mozilla.com> - Tue, 08 Oct 2019 17:15:52 +0000 - rev 496789
Push 114146 by dmajor@mozilla.com at Wed, 09 Oct 2019 17:52:49 +0000
Bug 1581902 - p5: check H.264 hardware availability. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D46367
c900fdf28f827067ec44e527af1d1a417d53cce4: Bug 1581902 - p6: introduce a pref to enable/disable H.264 for WebRTC. r=pehrsons
John Lin <jolin@mozilla.com> - Tue, 01 Oct 2019 16:54:50 +0000 - rev 496631
Push 114145 by apavel@mozilla.com at Tue, 08 Oct 2019 11:00:56 +0000
Bug 1581902 - p6: introduce a pref to enable/disable H.264 for WebRTC. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D46368
92c9ea70040dd22fbf57e48cf903b23546c68cd5: Bug 1581902 - p5: check H.264 hardware availability. r=pehrsons
John Lin <jolin@mozilla.com> - Tue, 01 Oct 2019 16:54:41 +0000 - rev 496630
Push 114145 by apavel@mozilla.com at Tue, 08 Oct 2019 11:00:56 +0000
Bug 1581902 - p5: check H.264 hardware availability. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D46367
734f05da6e8ef700461d6b8464c58194e5299acf: Bug 1559011 - Try using PW_RENDERFULLCONTENT for Windows window capture; r=pehrsons
Dan Minor <dminor@mozilla.com> - Thu, 03 Oct 2019 19:47:07 +0000 - rev 496351
Push 114143 by rgurzau@mozilla.com at Mon, 07 Oct 2019 09:35:08 +0000
Bug 1559011 - Try using PW_RENDERFULLCONTENT for Windows window capture; r=pehrsons This is a partial cherrypick of https://webrtc.googlesource.com/src/+/f89110d67902e787f6745ad2b52f7f09fc808512. The cropping changes in that revision are problematic on our version of webrtc.org and result in distorted video, which looks as though there is a stride problem. This takes the change to try to use PW_RENDERFULLCONTENT and to fall back to the current code if that fails. This fixes capturing Chrome windows and allows Firefox to properly capture its own window. Using PW_RENDERFULLCONTENT can adversely affect performance. Using the CroppingWindowCapturer can avoid using the WindowCapturer in some circumstances and so result in better performance. Bug 1586071 tracks switching to the CroppingWindowCapturer. Differential Revision: https://phabricator.services.mozilla.com/D48108
2487e743e786fdf077f18fe28355fe186bf5d128: Bug 1584523 - Add tracing statements to `AudioStream.cpp` to diagnose real-time safety issues. r=pehrsons
Paul Adenot <paul@paul.cx> - Wed, 02 Oct 2019 12:16:24 +0000 - rev 496005
Push 114141 by rmaries@mozilla.com at Thu, 03 Oct 2019 09:42:28 +0000
Bug 1584523 - Add tracing statements to `AudioStream.cpp` to diagnose real-time safety issues. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D47431
55f52129eacce4904a07c07f247e76ce85dfe40b: Bug 1584522 - Change the audio callback trace logger to be more ergonomic. r=pehrsons
Paul Adenot <paul@paul.cx> - Wed, 02 Oct 2019 12:16:22 +0000 - rev 496004
Push 114141 by rmaries@mozilla.com at Thu, 03 Oct 2019 09:42:28 +0000
Bug 1584522 - Change the audio callback trace logger to be more ergonomic. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D47430
9f15627684961ce192df91efb997b88b56e9cd98: Bug 1572281 - Enhance CubebDeviceEnumerator to accept listeners and signal notifications when an audio device changes. r=pehrsons
Alex Chronopoulos <achronop@gmail.com> - Fri, 20 Sep 2019 10:13:51 +0000 - rev 494260
Push 114114 by dluca@mozilla.com at Fri, 20 Sep 2019 22:00:08 +0000
Bug 1572281 - Enhance CubebDeviceEnumerator to accept listeners and signal notifications when an audio device changes. r=pehrsons CubebDeviceEnumerator already knows when an audio device changes. It is enhanced to allow listeners/observers registration and to create notifications when that happens. Also, it is hooked to the existing notification path. On a minor note, it has been revisited the way the enumerator is touched in MediaEngineWebRTC class. Differential Revision: https://phabricator.services.mozilla.com/D46271
90286c5d1ef171475be1d02d337825ef5fcf3b14: Bug 1572281 - In DeviceChangeCallback class separate the observer from the subject functionality. r=pehrsons
Alex Chronopoulos <achronop@gmail.com> - Fri, 20 Sep 2019 10:11:31 +0000 - rev 494259
Push 114114 by dluca@mozilla.com at Fri, 20 Sep 2019 22:00:08 +0000
Bug 1572281 - In DeviceChangeCallback class separate the observer from the subject functionality. r=pehrsons DeviceChangeCallback class implements the observer pattern. However, the role of the observer and the subject is integrated into the same class which makes use of virtual methods to allow a separation of the roles. This makes code reading difficult. Also, it does not allow from a class to inherit only the observer role or the subject role. This patch breaks the DeviceChangeCallback class into two classes according to the observer or subject functionality. Differential Revision: https://phabricator.services.mozilla.com/D46270
1f4a5ebd5c7ba0a0170e344096bf663072bf1acb: Bug 1576168 - mach vendor rust. r=pehrsons
Paul Adenot <paul@paul.cx> - Tue, 27 Aug 2019 08:00:43 +0000 - rev 490169
Push 113983 by csabou@mozilla.com at Tue, 27 Aug 2019 16:40:52 +0000
Bug 1576168 - mach vendor rust. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D43403
6e85d1ee673aed2891cff7f532d6ce34f18b61ab: Bug 1576168 - Update audio_thread_priority to 0.19.1. r=pehrsons
Paul Adenot <paul@paul.cx> - Tue, 27 Aug 2019 08:00:36 +0000 - rev 490168
Push 113983 by csabou@mozilla.com at Tue, 27 Aug 2019 16:40:52 +0000
Bug 1576168 - Update audio_thread_priority to 0.19.1. r=pehrsons This changes the hard-limit of `RLIMIT_RTTIME` to be the maximum available (200ms on my system), and keep the soft limit to the same number. Having different numbers allow catching SIGXCPU before getting SIGKILL. Differential Revision: https://phabricator.services.mozilla.com/D43402
3ea6795200b155f75de68931f12671a0b3b0c397: Bug 1576168 - mach vendor rust. r=pehrsons
Paul Adenot <paul@paul.cx> - Mon, 26 Aug 2019 14:19:39 +0000 - rev 489893
Push 113976 by malexandru@mozilla.com at Mon, 26 Aug 2019 23:07:04 +0000
Bug 1576168 - mach vendor rust. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D43403
4e8fc76cd529eb9bc1113367d2b1caa6ede0bd38: Bug 1576168 - Update audio_thread_priority to 0.19.0. r=pehrsons
Paul Adenot <paul@paul.cx> - Mon, 26 Aug 2019 14:20:22 +0000 - rev 489892
Push 113976 by malexandru@mozilla.com at Mon, 26 Aug 2019 23:07:04 +0000
Bug 1576168 - Update audio_thread_priority to 0.19.0. r=pehrsons This changes the hard-limit of `RLIMIT_RTTIME` to be the maximum available (200ms on my system), and keep the soft limit to the same number. Having different numbers allow catching SIGXCPU before getting SIGKILL. Differential Revision: https://phabricator.services.mozilla.com/D43402
d10e0c8243cf41fa4b6b563d6036755c055370de: Bug 1574914 - mach vendor rust. r=pehrsons
Paul Adenot <paul@paul.cx> - Mon, 19 Aug 2019 13:51:58 +0000 - rev 488728
Push 113922 by opoprus@mozilla.com at Mon, 19 Aug 2019 22:15:45 +0000
Bug 1574914 - mach vendor rust. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D42505
77b69bee6f181fcad607771abf4c12ad727a9a62: Bug 1574914 - Bump audio_thread_priority to 0.18. r=pehrsons
Paul Adenot <paul@paul.cx> - Mon, 19 Aug 2019 13:50:08 +0000 - rev 488727
Push 113922 by opoprus@mozilla.com at Mon, 19 Aug 2019 22:15:45 +0000
Bug 1574914 - Bump audio_thread_priority to 0.18. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D42504
a550b308d88ae8e6bbdd1bab0123028ca98512d8: Bug 1573833 - Add missing & and parentheses r=pehrsons
Sylvestre Ledru <sledru@mozilla.com> - Fri, 16 Aug 2019 08:11:39 +0000 - rev 488471
Push 113910 by ccoroiu@mozilla.com at Fri, 16 Aug 2019 16:28:54 +0000
Bug 1573833 - Add missing & and parentheses r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D41957
3184a33c1daa5f13f5105997b33462f276d2f621: Bug 1014393 - Move AudioGenerator to its own files so it can be used in more media gtests. r=pehrsons
Bryce Van Dyk <bvandyk@mozilla.com> - Sat, 03 Aug 2019 17:27:17 +0000 - rev 487413
Push 113876 by aiakab@mozilla.com at Mon, 12 Aug 2019 16:26:30 +0000
Bug 1014393 - Move AudioGenerator to its own files so it can be used in more media gtests. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D35389
d099c60bfd46fb944024bd99d7c8b4cd8d1d109d: Bug 1014393 - MediaEncoder better orders frames passed to the muxer. r=pehrsons
Bryce Van Dyk <bvandyk@mozilla.com> - Sat, 03 Aug 2019 17:27:17 +0000 - rev 487412
Push 113876 by aiakab@mozilla.com at Mon, 12 Aug 2019 16:26:30 +0000
Bug 1014393 - MediaEncoder better orders frames passed to the muxer. r=pehrsons Update MediaEncoder to pass frames to the muxer in order of their time stamps. This should prevent the currently possible scenario where audio and video frames are written with non-monotonically increasing timestamps (in violation of the webm spec). Differential Revision: https://phabricator.services.mozilla.com/D35388
c979aee45aab20d06b133e978483650cb11af89c: Bug 1014393 - Use MediaQueue to store frames pending write to muxer in MediaEncoder. r=pehrsons
Bryce Van Dyk <bvandyk@mozilla.com> - Sat, 03 Aug 2019 17:27:17 +0000 - rev 487411
Push 113876 by aiakab@mozilla.com at Mon, 12 Aug 2019 16:26:30 +0000
Bug 1014393 - Use MediaQueue to store frames pending write to muxer in MediaEncoder. r=pehrsons MediaQueue provides a better interface for interleaving frames when writing to the muxer (this change will follow in another changeset). The queue interface provides a nicer abstraction than manually managing a nsTArray. Differential Revision: https://phabricator.services.mozilla.com/D35387
01204a8c60a420974b134bb2066cca176787b0d3: Bug 1014393 - Update EncodedFrame class to more closely resemble MediaData class. r=pehrsons
Bryce Van Dyk <bvandyk@mozilla.com> - Sat, 03 Aug 2019 17:27:17 +0000 - rev 487410
Push 113876 by aiakab@mozilla.com at Mon, 12 Aug 2019 16:26:30 +0000
Bug 1014393 - Update EncodedFrame class to more closely resemble MediaData class. r=pehrsons This changes EncodedFrame to behave more like MediaData, so that EncodedFrame can be used with the MediaQueue data structure. It also provides a somewhat more consistent interface across media data types. Differential Revision: https://phabricator.services.mozilla.com/D35386
1af87ed9c5fb6270f1dc97997c7222eaa46580d8: Bug 1014393 - Shift responsibility of adjusting packets with opus codec delay to MediaEncoder. r=pehrsons
Bryce Van Dyk <bvandyk@mozilla.com> - Sat, 03 Aug 2019 17:27:16 +0000 - rev 487409
Push 113876 by aiakab@mozilla.com at Mon, 12 Aug 2019 16:26:30 +0000
Bug 1014393 - Shift responsibility of adjusting packets with opus codec delay to MediaEncoder. r=pehrsons Move the responsibility of adjusting opus frame timestamps to the MediaEncoder. This was previously done by the EbmlComposer, but doing so in the MediaEncoder means we can have greater control over handling of time codes and interleaving of frames. Differential Revision: https://phabricator.services.mozilla.com/D35385
ca958984393b5a93cefe5daced8b738a209ff168: Bug 1014393 - Remove EncodedFrameContainer. r=pehrsons
Bryce Van Dyk <bvandyk@mozilla.com> - Sat, 03 Aug 2019 17:27:16 +0000 - rev 487408
Push 113876 by aiakab@mozilla.com at Mon, 12 Aug 2019 16:26:30 +0000
Bug 1014393 - Remove EncodedFrameContainer. r=pehrsons Remove EncodedFrameContainer and clean up areas where it was used. EncodedFrameContainer provided a wrapper around an nsTArray<RefPtr<EncodedFrame>>, but it simplifies the code to simply expose this array. Also clean up unused enums in EncodedFrame, and clean up some of the outdated comments for our encoded frame handling. Differential Revision: https://phabricator.services.mozilla.com/D35384
a010340cfa037de06e2869ea1870fffcc31d7fba: Bug 1014393 - Separate MediaEncoders encode and mux steps. r=pehrsons
Bryce Van Dyk <bvandyk@mozilla.com> - Sat, 03 Aug 2019 17:27:16 +0000 - rev 487407
Push 113876 by aiakab@mozilla.com at Mon, 12 Aug 2019 16:26:30 +0000
Bug 1014393 - Separate MediaEncoders encode and mux steps. r=pehrsons Separating the encode and mux steps allows for better control over interleaving audio and video data. If encode and mux are done in a single step it's possible to mux large amounts of audio or video data which should have been interleaved with the other data type to give correctly ordered time stamps in the target container. Differential Revision: https://phabricator.services.mozilla.com/D35383
6744a817591699c5411940865698504361b64057: Bug 1570948 - mach vendor rust. r=pehrsons
Paul Adenot <paul@paul.cx> - Fri, 02 Aug 2019 12:49:45 +0000 - rev 485940
Push 113824 by csabou@mozilla.com at Fri, 02 Aug 2019 16:06:39 +0000
Bug 1570948 - mach vendor rust. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D40411
621826223c09ad8b3f43e03c5eed3258a85866a6: Bug 1570948 - Bump audio_thread_priority to 0.17. r=pehrsons
Paul Adenot <paul@paul.cx> - Fri, 02 Aug 2019 12:44:33 +0000 - rev 485939
Push 113824 by csabou@mozilla.com at Fri, 02 Aug 2019 16:06:39 +0000
Bug 1570948 - Bump audio_thread_priority to 0.17. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D40410
c49241bad727d17cc76fdfe69ae6934b67d16ce2: Bug 1014393 - Move AudioGenerator to its own files so it can be used in more media gtests. r=pehrsons
Bryce Van Dyk <bvandyk@mozilla.com> - Thu, 01 Aug 2019 08:47:58 +0000 - rev 485734
Push 113820 by rmaries@mozilla.com at Fri, 02 Aug 2019 04:17:07 +0000
Bug 1014393 - Move AudioGenerator to its own files so it can be used in more media gtests. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D35389
fc24872739e41417b6851d64ab066c933d0cfa00: Bug 1014393 - MediaEncoder better orders frames passed to the muxer. r=pehrsons
Bryce Van Dyk <bvandyk@mozilla.com> - Thu, 01 Aug 2019 08:47:56 +0000 - rev 485733
Push 113820 by rmaries@mozilla.com at Fri, 02 Aug 2019 04:17:07 +0000
Bug 1014393 - MediaEncoder better orders frames passed to the muxer. r=pehrsons Update MediaEncoder to pass frames to the muxer in order of their time stamps. This should prevent the currently possible scenario where audio and video frames are written with non-monotonically increasing timestamps (in violation of the webm spec). Differential Revision: https://phabricator.services.mozilla.com/D35388
fd846ac16731a861c5a4a7e97bfdeb47a022774c: Bug 1014393 - Use MediaQueue to store frames pending write to muxer in MediaEncoder. r=pehrsons
Bryce Van Dyk <bvandyk@mozilla.com> - Thu, 01 Aug 2019 08:47:54 +0000 - rev 485732
Push 113820 by rmaries@mozilla.com at Fri, 02 Aug 2019 04:17:07 +0000
Bug 1014393 - Use MediaQueue to store frames pending write to muxer in MediaEncoder. r=pehrsons MediaQueue provides a better interface for interleaving frames when writing to the muxer (this change will follow in another changeset). The queue interface provides a nicer abstraction than manually managing a nsTArray. Differential Revision: https://phabricator.services.mozilla.com/D35387
4b11f19aa613db793dfab132162ec4c8b02b4391: Bug 1014393 - Update EncodedFrame class to more closely resemble MediaData class. r=pehrsons
Bryce Van Dyk <bvandyk@mozilla.com> - Thu, 01 Aug 2019 08:47:52 +0000 - rev 485731
Push 113820 by rmaries@mozilla.com at Fri, 02 Aug 2019 04:17:07 +0000
Bug 1014393 - Update EncodedFrame class to more closely resemble MediaData class. r=pehrsons This changes EncodedFrame to behave more like MediaData, so that EncodedFrame can be used with the MediaQueue data structure. It also provides a somewhat more consistent interface across media data types. Differential Revision: https://phabricator.services.mozilla.com/D35386
4a57b865b4610dbbf288c7ed783405f068f5d250: Bug 1014393 - Shift responsibility of adjusting packets with opus codec delay to MediaEncoder. r=pehrsons
Bryce Van Dyk <bvandyk@mozilla.com> - Thu, 01 Aug 2019 08:47:51 +0000 - rev 485730
Push 113820 by rmaries@mozilla.com at Fri, 02 Aug 2019 04:17:07 +0000
Bug 1014393 - Shift responsibility of adjusting packets with opus codec delay to MediaEncoder. r=pehrsons Move the responsibility of adjusting opus frame timestamps to the MediaEncoder. This was previously done by the EbmlComposer, but doing so in the MediaEncoder means we can have greater control over handling of time codes and interleaving of frames. Differential Revision: https://phabricator.services.mozilla.com/D35385
147d5aeaab465cbfdf802d0b934e2a8ecd1d8359: Bug 1014393 - Remove EncodedFrameContainer. r=pehrsons
Bryce Van Dyk <bvandyk@mozilla.com> - Thu, 01 Aug 2019 08:47:49 +0000 - rev 485729
Push 113820 by rmaries@mozilla.com at Fri, 02 Aug 2019 04:17:07 +0000
Bug 1014393 - Remove EncodedFrameContainer. r=pehrsons Remove EncodedFrameContainer and clean up areas where it was used. EncodedFrameContainer provided a wrapper around an nsTArray<RefPtr<EncodedFrame>>, but it simplifies the code to simply expose this array. Also clean up unused enums in EncodedFrame, and clean up some of the outdated comments for our encoded frame handling. Differential Revision: https://phabricator.services.mozilla.com/D35384
c58e17df9c99c7301bce382e98368b1114b9a10e: Bug 1014393 - Separate MediaEncoders encode and mux steps. r=pehrsons
Bryce Van Dyk <bvandyk@mozilla.com> - Thu, 01 Aug 2019 08:47:47 +0000 - rev 485728
Push 113820 by rmaries@mozilla.com at Fri, 02 Aug 2019 04:17:07 +0000
Bug 1014393 - Separate MediaEncoders encode and mux steps. r=pehrsons Separating the encode and mux steps allows for better control over interleaving audio and video data. If encode and mux are done in a single step it's possible to mux large amounts of audio or video data which should have been interleaved with the other data type to give correctly ordered time stamps in the target container. Differential Revision: https://phabricator.services.mozilla.com/D35383
8bcbc931942b9439ae8e0215c54c1db0c5d76d5b: Bug 1014393 - Move AudioGenerator to its own files so it can be used in more media gtests. r=pehrsons
Bryce Van Dyk <bvandyk@mozilla.com> - Wed, 31 Jul 2019 11:29:24 +0000 - rev 485663
Push 113818 by rmaries@mozilla.com at Thu, 01 Aug 2019 22:55:32 +0000
Bug 1014393 - Move AudioGenerator to its own files so it can be used in more media gtests. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D35389
a16bcc633362ddc5aec26581cdbc8ed43aaa865e: Bug 1014393 - MediaEncoder better orders frames passed to the muxer. r=pehrsons
Bryce Van Dyk <bvandyk@mozilla.com> - Wed, 31 Jul 2019 11:29:22 +0000 - rev 485662
Push 113818 by rmaries@mozilla.com at Thu, 01 Aug 2019 22:55:32 +0000
Bug 1014393 - MediaEncoder better orders frames passed to the muxer. r=pehrsons Update MediaEncoder to pass frames to the muxer in order of their time stamps. This should prevent the currently possible scenario where audio and video frames are written with non-monotonically increasing timestamps (in violation of the webm spec). Differential Revision: https://phabricator.services.mozilla.com/D35388
bf46f2a2e519447ff1135667b4ded23d55079127: Bug 1014393 - Use MediaQueue to store frames pending write to muxer in MediaEncoder. r=pehrsons
Bryce Van Dyk <bvandyk@mozilla.com> - Wed, 31 Jul 2019 11:29:15 +0000 - rev 485661
Push 113818 by rmaries@mozilla.com at Thu, 01 Aug 2019 22:55:32 +0000
Bug 1014393 - Use MediaQueue to store frames pending write to muxer in MediaEncoder. r=pehrsons MediaQueue provides a better interface for interleaving frames when writing to the muxer (this change will follow in another changeset). The queue interface provides a nicer abstraction than manually managing a nsTArray. Differential Revision: https://phabricator.services.mozilla.com/D35387
aa508d83a2c35adf20617c7ecac72694cea88c77: Bug 1014393 - Update EncodedFrame class to more closely resemble MediaData class. r=pehrsons
Bryce Van Dyk <bvandyk@mozilla.com> - Wed, 31 Jul 2019 11:29:07 +0000 - rev 485660
Push 113818 by rmaries@mozilla.com at Thu, 01 Aug 2019 22:55:32 +0000
Bug 1014393 - Update EncodedFrame class to more closely resemble MediaData class. r=pehrsons This changes EncodedFrame to behave more like MediaData, so that EncodedFrame can be used with the MediaQueue data structure. It also provides a somewhat more consistent interface across media data types. Differential Revision: https://phabricator.services.mozilla.com/D35386