searching for reviewer(pbro)
e61c315b780db1def991c721606ad947d6848a47: Bug 1553194 - Remove unrelated code comment from shared/css-logic.js r=pbro
Razvan Caliman <rcaliman@mozilla.com> - Wed, 22 May 2019 07:35:02 +0000 - rev 474941
Push 113181 by shindli@mozilla.com at Wed, 22 May 2019 15:39:08 +0000
Bug 1553194 - Remove unrelated code comment from shared/css-logic.js r=pbro Depends on D32016 The code comment is perhaps a leftover from a file duplication to extract shared methods to `shared/inspector/css-logic.js` from `server/actors/inspector/css-logic.js`. The comment is confusing because there is no usage of any of the CssLogic terminology within the file. Differential Revision: https://phabricator.services.mozilla.com/D32017
e24c48157bf155e4f92db2e8e33e487fcbfa98db: Bug 1553194 - Remove unnecessary isInherited from CssLogic constructor. r=pbro
Razvan Caliman <rcaliman@mozilla.com> - Wed, 22 May 2019 07:34:03 +0000 - rev 474940
Push 113181 by shindli@mozilla.com at Wed, 22 May 2019 15:39:08 +0000
Bug 1553194 - Remove unnecessary isInherited from CssLogic constructor. r=pbro `isInherited` is a callback function that checks if a given CSS property is inherited. It is misleadingly commented as a cache of inherited properties (which perhaps it is on the InspectorUtils implementation, but on the consumer side it is just a function). The actual call is done by InspectorUtils.isPropertyInherited. There is no need to pass the handler to CssLogic or to CssPropertyInfo since InspectorUtils is available in the same context as the definition of the consumers. There is no other use case where a custom handler is passed to check for inherited properties in so it is safe to remove this as an argument and just use InspectorUtils.isPropertyInherited where needed. This cleans up the code slightly. Differential Revision: https://phabricator.services.mozilla.com/D32016
3f4a4ab9eed068c89e4721294d62a001d205422a: Bug 1547944 [RTL] Mirror the Separate Window icon r=pbro
vishal singh <vishalsingh600700@gmail.com> - Wed, 22 May 2019 07:41:26 +0000 - rev 474931
Push 113181 by shindli@mozilla.com at Wed, 22 May 2019 15:39:08 +0000
Bug 1547944 [RTL] Mirror the Separate Window icon r=pbro Before the icon was reverse for rtl . But now it is in correct form. Differential Revision: https://phabricator.services.mozilla.com/D32049
9580f1df7a53b17cbda444f9d2809aeb63912743: Bug 1551174 - Inactive CSS - visual polish r=pbro
Michael Ratcliffe <mratcliffe@mozilla.com> - Tue, 21 May 2019 16:29:49 +0000 - rev 474782
Push 113171 by aiakab@mozilla.com at Tue, 21 May 2019 21:56:33 +0000
Bug 1551174 - Inactive CSS - visual polish r=pbro Depends on: D31986 ### Summary - [X] Extra margin between paragraphs (about 14px, or whatever 1em is) - [X] Same amount of padding on all sides - match left spacing. Looks like we need 4px less on the side with the arrow, 2px less on the other side. - [X] Fully opaque, white-colored background - [X] Drop shadow should be half as dark (I think this is the MacOS doubled dropshadow issue - it should match the meatball menu's shadow) - [X] Less space between ending icons and CSS - seems like we can just remove margin-inline-start: 5px - [X] I think florens may have a better info icon that will be more legible at this small size !!I just created a new one!! - [X] Warning icon should be smaller now to match the size of the info icon :) It was an illusion but I have made it slightly smaller and changed the background position to make it look closer to the same size. - [X] Seems like it would be helpful if you could select the tooltip text - Whole tooltip 1px to the right and 2px lower !!I have moved this out to bug 1552146!! Differential Revision: https://phabricator.services.mozilla.com/D31292
62ffe3570de446a92c0eed4c22c81e6c50fb840b: Bug 1543216 - Improved colors for the markup view's inactive elements r=pbro
Michael Ratcliffe <mratcliffe@mozilla.com> - Tue, 21 May 2019 12:09:51 +0000 - rev 474781
Push 113171 by aiakab@mozilla.com at Tue, 21 May 2019 21:56:33 +0000
Bug 1543216 - Improved colors for the markup view's inactive elements r=pbro Changes: - Applied colors from Victorias mockups. - Removed `margin-inline-start` from the icon to move it closer to the property value. Differential Revision: https://phabricator.services.mozilla.com/D31986
4750c8223f658b0abf51974d1a88af0e2070a44b: Bug 1548240 - Disable test temporarily r=pbro
Michael Ratcliffe <mratcliffe@mozilla.com> - Mon, 13 May 2019 15:17:43 +0000 - rev 473615
Push 113093 by apavel@mozilla.com at Mon, 13 May 2019 22:09:34 +0000
Bug 1548240 - Disable test temporarily r=pbro Differential Revision: https://phabricator.services.mozilla.com/D30925
87e01787d465cfcb89c0e593685c15d43a30f61e: Bug 1551167 - Move import of mochitest/helpers/context.js to test instead of head.js r=pbro
Julian Descottes <jdescottes@mozilla.com> - Mon, 13 May 2019 09:49:24 +0000 - rev 473587
Push 113093 by apavel@mozilla.com at Mon, 13 May 2019 22:09:34 +0000
Bug 1551167 - Move import of mochitest/helpers/context.js to test instead of head.js r=pbro Importing scripts in shared head files is hard to maintain because it forces all browser ini that use the shared file to whitelist all its imports. The debugger context helper is almost unused in the inspector, so it would be easier to just import it in the few tests that require it. Also removed the whitelist entry in rules' browser.ini, no test in this suite used it. Differential Revision: https://phabricator.services.mozilla.com/D30882
6685fd95730257d69b3e9169a1d84c7336a8ce74: Bug 1468402 - Part 3: Add test for subgrids in the grid list. r=pbro
Gabriel Luong <gabriel.luong@gmail.com> - Thu, 09 May 2019 11:28:53 -0400 - rev 473575
Push 113091 by gabriel.luong@gmail.com at Mon, 13 May 2019 16:23:11 +0000
Bug 1468402 - Part 3: Add test for subgrids in the grid list. r=pbro Differential Revision: https://phabricator.services.mozilla.com/D30512
63f40ac370c63ec1aae568a569a25f768998b998: Bug 1468402 - Part 2: Indent the subgrids in the grid list. r=pbro
Gabriel Luong <gabriel.luong@gmail.com> - Tue, 30 Apr 2019 00:50:50 -0400 - rev 473574
Push 113091 by gabriel.luong@gmail.com at Mon, 13 May 2019 16:23:11 +0000
Bug 1468402 - Part 2: Indent the subgrids in the grid list. r=pbro Differential Revision: https://phabricator.services.mozilla.com/D29316
567911d83bda7ad05d88ce584e9a29000fdd4b52: Bug 1468402 - Part 1: Add isSubgrid and subgridParentNode to the grid actor form. r=pbro
Gabriel Luong <gabriel.luong@gmail.com> - Tue, 30 Apr 2019 00:50:47 -0400 - rev 473573
Push 113091 by gabriel.luong@gmail.com at Mon, 13 May 2019 16:23:11 +0000
Bug 1468402 - Part 1: Add isSubgrid and subgridParentNode to the grid actor form. r=pbro Differential Revision: https://phabricator.services.mozilla.com/D29317
2f85ada34acb9da79c83f9fb73b59f8d8d295a8d: Bug 1541175 Part 2: Force RDM UI to be at 100% zoom. r=pbro,ochameau
Brad Werth <bwerth@mozilla.com> - Mon, 06 May 2019 07:21:13 +0000 - rev 472952
Push 113059 by ncsoregi@mozilla.com at Wed, 08 May 2019 03:43:45 +0000
Bug 1541175 Part 2: Force RDM UI to be at 100% zoom. r=pbro,ochameau Once RDM is up-and-running, the Zoom UI will stay synchronized with the zoom level of the RDM content pane. These changes ensure that the RDM tools are forced to 100%, and then does a fixup to get the Zoom UI to match the RDM content pane zoom level again. Differential Revision: https://phabricator.services.mozilla.com/D26045
067fd517e656b6276034dca9f0ed139fcf55b450: Bug 1545270 - Update CSS variable for Add Device Settings Input fields, r=victoria,pbro
Megan Bailey <megan@rockstarcreativestudio.com> - Mon, 06 May 2019 18:29:57 +0000 - rev 472854
Push 113051 by shindli@mozilla.com at Tue, 07 May 2019 15:19:30 +0000
Bug 1545270 - Update CSS variable for Add Device Settings Input fields, r=victoria,pbro Differential Revision: https://phabricator.services.mozilla.com/D29730
b1ca002764784802c57f7b13e4d4971a4b67ba72: Bug 1440537 - Don't unnecessarily use cross-origin iframes on a devtools test. r=pbro
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 25 Apr 2019 22:47:07 +0200 - rev 471655
Push 112933 by rmaries@mozilla.com at Sat, 27 Apr 2019 21:51:53 +0000
Bug 1440537 - Don't unnecessarily use cross-origin iframes on a devtools test. r=pbro See the rest of the patches in this bug for more context :) Differential Revision: https://phabricator.services.mozilla.com/D28912
f482629843e0efab24362571669131e4a43728f6: Bug 1538648 - Ensure buttons don't have a selection highlight. r=pbro
Razvan Caliman <rcaliman@mozilla.com> - Thu, 25 Apr 2019 14:41:10 +0000 - rev 471325
Push 112913 by opoprus@mozilla.com at Thu, 25 Apr 2019 22:21:16 +0000
Bug 1538648 - Ensure buttons don't have a selection highlight. r=pbro Button elements are not user-selectable by default as defined by User Agent stylesheet defaults: https://www.w3.org/TR/css-ui-4/#issue-74a40dd9 However, by using the Selection.selectAllChildren() API, button elements do get a selection highlight (their text contents don't get copied to the clipboard; that is expected). See Bug 1546366. Until bug 1546366 is addressed, this patch ensures that button elements in DevTools never get a selection highlight by unsetting any applied styles with the `::selection` pseudo-element. Differential Revision: https://phabricator.services.mozilla.com/D28627
988b90e06a7ad93c32eed60b0f765997d88caffb: Bug 1546451 - Fix RTL spacing for inputs in Fonts panel. r=pbro
Razvan Caliman <rcaliman@mozilla.com> - Thu, 25 Apr 2019 12:30:09 +0000 - rev 471308
Push 112913 by opoprus@mozilla.com at Thu, 25 Apr 2019 22:21:16 +0000
Bug 1546451 - Fix RTL spacing for inputs in Fonts panel. r=pbro Minor fixes to the layout of inputs in right-to-left (RTL) language layout. To enable RTL, navigate to `about:config` and set `intl.uidirection` to 1. Differential Revision: https://phabricator.services.mozilla.com/D28610
12a2c9870dc53fec10c77cf3386cdee1bdaff170: Bug 1545957 - Fix expander/twisty icon rotation for LTR panels in RTL mode. r=pbro
Razvan Caliman <rcaliman@mozilla.com> - Wed, 24 Apr 2019 11:44:48 +0000 - rev 471118
Push 112895 by cbrindusan@mozilla.com at Wed, 24 Apr 2019 22:47:15 +0000
Bug 1545957 - Fix expander/twisty icon rotation for LTR panels in RTL mode. r=pbro Reverts the icon rotation while in RTL mode for panels which always use LTR layout. To test RTL layout, navigate to about:config and set intl.uidirection = 1 Differential Revision: https://phabricator.services.mozilla.com/D28618
0d0d5b67b2cc524045672b67a13401cd0dbf939e: Bug 1542213 - Track newly added CSS rules in the Changes panel. r=pbro
Razvan Caliman <rcaliman@mozilla.com> - Tue, 23 Apr 2019 07:59:12 +0000 - rev 470688
Push 112876 by aciure@mozilla.com at Tue, 23 Apr 2019 22:24:17 +0000
Bug 1542213 - Track newly added CSS rules in the Changes panel. r=pbro Introduces tracking for newly created CSS rules in the PageStyleActor. Adds a boolean flag, `isNew`, to the tracked rule in the Changes Redux store. Using this flag, render the new rule's selector in the React component as added (plus sign, green background). Ensure selector changes for thew new rule always overwrite the original selector (fix for Bug 1542288) instead of erroneously showing the original selector as removed. Removes obsolete documentation for "changeType" from the tracked rule in the Changes Redux store. This was never used. Differential Revision: https://phabricator.services.mozilla.com/D28215
5e19fc2158c1875050dd8b79062ade3d2476110d: Bug 1544170 Part 3 - Inspector changes to fetch style sheets from replaying process, r=pbro.
Brian Hackett <bhackett1024@gmail.com> - Fri, 12 Apr 2019 16:36:12 -1000 - rev 470217
Push 112849 by bhackett@mozilla.com at Sat, 20 Apr 2019 02:36:08 +0000
Bug 1544170 Part 3 - Inspector changes to fetch style sheets from replaying process, r=pbro. Differential Revision: https://phabricator.services.mozilla.com/D27410
9dafc71a1f375a6865521e7e26073394b0c8cd0b: Bug 1544714 - ensure that the contrast ratio check required stylesheet does not get removed while calculating contrast. r=pbro
Yura Zenevich <yura.zenevich@gmail.com> - Thu, 18 Apr 2019 07:16:07 +0000 - rev 470067
Push 112843 by aiakab@mozilla.com at Fri, 19 Apr 2019 09:50:22 +0000
Bug 1544714 - ensure that the contrast ratio check required stylesheet does not get removed while calculating contrast. r=pbro Differential Revision: https://phabricator.services.mozilla.com/D27897
10e39089de4eae107554300619c34fdcc18ae9d3: Bug 1545089 - Make the subgrid markup badge toggle the grid highlighter. r=pbro
Gabriel Luong <gabriel.luong@gmail.com> - Wed, 17 Apr 2019 10:50:58 -0400 - rev 469772
Push 112823 by gabriel.luong@gmail.com at Wed, 17 Apr 2019 15:11:19 +0000
Bug 1545089 - Make the subgrid markup badge toggle the grid highlighter. r=pbro Differential Revision: https://phabricator.services.mozilla.com/D27908
17ee3af4102a80992f87148b5e1a52fa88d433c8: Bug 1540904 - added full page API for accessibility walker actor. r=pbro
Yura Zenevich <yura.zenevich@gmail.com> - Wed, 10 Apr 2019 18:36:02 +0000 - rev 468861
Push 112758 by dvarga@mozilla.com at Thu, 11 Apr 2019 04:29:43 +0000
Bug 1540904 - added full page API for accessibility walker actor. r=pbro Differential Revision: https://phabricator.services.mozilla.com/D26458
cff6e35cda2b04d31d986a80c3e91e91e2d8db06: Bug 1541446 - added audited event to AccessibleActor/Front. r=pbro
Yura Zenevich <yura.zenevich@gmail.com> - Wed, 10 Apr 2019 18:36:00 +0000 - rev 468860
Push 112758 by dvarga@mozilla.com at Thu, 11 Apr 2019 04:29:43 +0000
Bug 1541446 - added audited event to AccessibleActor/Front. r=pbro Differential Revision: https://phabricator.services.mozilla.com/D26457
a27b2d2038852219b9c9983702197630f2d3ad82: Bug 1540904 - added full page API for accessibility walker actor. r=pbro
Yura Zenevich <yura.zenevich@gmail.com> - Wed, 10 Apr 2019 00:58:31 +0000 - rev 468716
Push 112747 by ncsoregi@mozilla.com at Wed, 10 Apr 2019 13:22:28 +0000
Bug 1540904 - added full page API for accessibility walker actor. r=pbro Differential Revision: https://phabricator.services.mozilla.com/D26458
9f43419c7b402fd90950749c1053669e92a1c7fd: Bug 1541446 - added audited event to AccessibleActor/Front. r=pbro
Yura Zenevich <yura.zenevich@gmail.com> - Wed, 10 Apr 2019 00:58:24 +0000 - rev 468715
Push 112747 by ncsoregi@mozilla.com at Wed, 10 Apr 2019 13:22:28 +0000
Bug 1541446 - added audited event to AccessibleActor/Front. r=pbro Differential Revision: https://phabricator.services.mozilla.com/D26457
106e58c798efea5320f6806f2ef6781a5987b294: Bug 1282084 - Don't allow RDM to show triggered hover states while touch is enabled. r=pbro
Micah Tigley <mtigley@mozilla.com> - Tue, 09 Apr 2019 14:23:32 +0000 - rev 468589
Push 112738 by nbeleuzu@mozilla.com at Tue, 09 Apr 2019 22:28:41 +0000
Bug 1282084 - Don't allow RDM to show triggered hover states while touch is enabled. r=pbro Differential Revision: https://phabricator.services.mozilla.com/D26053
0a00348d14b809cf657733726d375bb77166bf0d: Bug 1543007 - Restore ./mach test command;r=pbro
Julian Descottes <jdescottes@mozilla.com> - Tue, 09 Apr 2019 09:22:22 +0000 - rev 468520
Push 112733 by csabou@mozilla.com at Tue, 09 Apr 2019 16:30:22 +0000
Bug 1543007 - Restore ./mach test command;r=pbro Differential Revision: https://phabricator.services.mozilla.com/D26661
d6988a918ee495a0776e49ffa4d9e18b89b3dea0: Bug 1543007 - Restore ./mach test command;r=pbro a=important-tooling-fix DONTBUILD NPOTB
Julian Descottes <jdescottes@mozilla.com> - Tue, 09 Apr 2019 09:22:22 +0000 - rev 468500
Push 112725 by archaeopteryx@coole-files.de at Tue, 09 Apr 2019 11:23:31 +0000
Bug 1543007 - Restore ./mach test command;r=pbro a=important-tooling-fix DONTBUILD NPOTB Differential Revision: https://phabricator.services.mozilla.com/D26661
db8e59458b4aae9bd444697e7baf46fb6b80a6c7: Bug 1542659 Part 2 - Remove unnecessary ReplayInspector instrumentation, r=pbro.
Brian Hackett <bhackett1024@gmail.com> - Sun, 07 Apr 2019 16:02:04 -1000 - rev 468414
Push 112716 by bhackett@mozilla.com at Tue, 09 Apr 2019 01:59:32 +0000
Bug 1542659 Part 2 - Remove unnecessary ReplayInspector instrumentation, r=pbro. Differential Revision: https://phabricator.services.mozilla.com/D26452
50ce9167f1cef3991f352258dab7bf784443c43e: Bug 1538171 - Remove the style-editor-options-popup XUL menupopup from the StyleEditor and use the JS Menu API instead. r=pbro
Hemakshi Sachdev <sachdev.hemakshi@gmail.com> - Mon, 08 Apr 2019 13:16:46 +0000 - rev 468349
Push 112710 by dvarga@mozilla.com at Mon, 08 Apr 2019 16:30:07 +0000
Bug 1538171 - Remove the style-editor-options-popup XUL menupopup from the StyleEditor and use the JS Menu API instead. r=pbro Differential Revision: https://phabricator.services.mozilla.com/D26075
263c51a3b7b4058ccc53f15ca351c987969c06aa: Bug 1497393 Part 8 - Client side changes for inspector support while replaying, r=pbro.
Brian Hackett <bhackett1024@gmail.com> - Sat, 09 Mar 2019 16:46:16 -1000 - rev 468292
Push 112699 by bhackett@mozilla.com at Sun, 07 Apr 2019 03:06:36 +0000
Bug 1497393 Part 8 - Client side changes for inspector support while replaying, r=pbro. Differential Revision: https://phabricator.services.mozilla.com/D22864
269961cd844f3ab71de40d5348f73a2c212b5c0f: Bug 1497393 Part 7 - Server side changes for inspector support while replaying, r=pbro.
Brian Hackett <bhackett1024@gmail.com> - Sat, 09 Mar 2019 16:45:50 -1000 - rev 468291
Push 112699 by bhackett@mozilla.com at Sun, 07 Apr 2019 03:06:36 +0000
Bug 1497393 Part 7 - Server side changes for inspector support while replaying, r=pbro. Differential Revision: https://phabricator.services.mozilla.com/D22863
efc734d0f5066083469378f593e4a2464c4e4cba: Bug 1541158 Part 2: Add a test that only RDM content is affected by full zoom changes. r=pbro
Brad Werth <bwerth@mozilla.com> - Fri, 05 Apr 2019 07:37:55 +0000 - rev 468189
Push 112692 by shindli@mozilla.com at Fri, 05 Apr 2019 21:53:39 +0000
Bug 1541158 Part 2: Add a test that only RDM content is affected by full zoom changes. r=pbro Differential Revision: https://phabricator.services.mozilla.com/D26041
fce9f2905ff0eb3845b1e585fbd6fead4c663ce2: Bug 1541158 Part 1: Passthrough zoom to RDM document. r=pbro
Brad Werth <bwerth@mozilla.com> - Thu, 04 Apr 2019 16:52:12 +0000 - rev 468188
Push 112692 by shindli@mozilla.com at Fri, 05 Apr 2019 21:53:39 +0000
Bug 1541158 Part 1: Passthrough zoom to RDM document. r=pbro This ensures that any changes to zoom level, when RDM is active, happen on the content document and not on the RDM interface. Differential Revision: https://phabricator.services.mozilla.com/D26040
3239894a74021dd5d970a8861efc0d793a1c3001: Bug 1536237 - Refactor unit conversion in Font Editor. r=pbro
Razvan Caliman <rcaliman@mozilla.com> - Tue, 02 Apr 2019 17:49:49 +0000 - rev 467640
Push 112638 by dvarga@mozilla.com at Wed, 03 Apr 2019 06:18:49 +0000
Bug 1536237 - Refactor unit conversion in Font Editor. r=pbro Depends on D25087 Simplified the convertUnits() method by externalizing the logic to get the reference node, reference box and reference font size value used when converting between units. The result is easier to read, but more importantly it reduces the cyclomatic complexity which trips the ESlint "complexity" rule and triggers a backout. Differential Revision: https://phabricator.services.mozilla.com/D25611
fb4a79e4b5f901c9a178e77bc1bb4abfa35efdb3: Bug 1539265 - Make ::marker pseudo-elements always visible in the markup view. r=jdescottes,mbalfanz,pbro
Ian Moody <moz-ian@perix.co.uk> - Tue, 02 Apr 2019 07:36:27 +0000 - rev 467548
Push 112633 by cbrindusan@mozilla.com at Tue, 02 Apr 2019 15:52:18 +0000
Bug 1539265 - Make ::marker pseudo-elements always visible in the markup view. r=jdescottes,mbalfanz,pbro Instead of only when setting devtools.inspector.showAllAnonymousContent. Differential Revision: https://phabricator.services.mozilla.com/D25166
8206b880f9ecf19c5933efe72addf9c350977199: Bug 1539265 - Make ::marker pseudo-elements always visible in the markup view. r=jdescottes,mbalfanz,pbro
Ian Moody <moz-ian@perix.co.uk> - Mon, 01 Apr 2019 21:46:11 +0000 - rev 467487
Push 112626 by cbrindusan@mozilla.com at Tue, 02 Apr 2019 08:40:51 +0000
Bug 1539265 - Make ::marker pseudo-elements always visible in the markup view. r=jdescottes,mbalfanz,pbro Instead of only when setting devtools.inspector.showAllAnonymousContent. Differential Revision: https://phabricator.services.mozilla.com/D25166
76e7655d974e628646aa26b7d25fe7ef3a4ec615: Bug 1538306 - ensure highlighter bounds overlay does not interfere with the accessible audit. r=pbro
Yura Zenevich <yura.zenevich@gmail.com> - Tue, 26 Mar 2019 13:33:37 +0000 - rev 466109
Push 112561 by dvarga@mozilla.com at Tue, 26 Mar 2019 22:00:04 +0000
Bug 1538306 - ensure highlighter bounds overlay does not interfere with the accessible audit. r=pbro Differential Revision: https://phabricator.services.mozilla.com/D24546
72b740c734db3f2241236f35168c5da0658ffa1c: Bug 1538306 - ensure that only one audit can run at a given time for an Accessible actor. r=pbro
Yura Zenevich <yura.zenevich@gmail.com> - Tue, 26 Mar 2019 13:33:29 +0000 - rev 466108
Push 112561 by dvarga@mozilla.com at Tue, 26 Mar 2019 22:00:04 +0000
Bug 1538306 - ensure that only one audit can run at a given time for an Accessible actor. r=pbro Differential Revision: https://phabricator.services.mozilla.com/D24545
6cf500743cc46cdfea24a87ee5ce78875d887bde: Bug 1536682: Add a test for special CSS color. r=pbro
Daisuke Akatsuka <dakatsuka@mozilla.com> - Mon, 25 Mar 2019 03:03:34 +0000 - rev 465879
Push 112530 by opoprus@mozilla.com at Mon, 25 Mar 2019 10:05:39 +0000
Bug 1536682: Add a test for special CSS color. r=pbro Differential Revision: https://phabricator.services.mozilla.com/D24127
92d5c598ccef849df83d298b06130d6b1027c0e2: Bug 1536682: Handle special CSS color within animation inspector. r=pbro
Daisuke Akatsuka <dakatsuka@mozilla.com> - Mon, 25 Mar 2019 03:06:43 +0000 - rev 465878
Push 112530 by opoprus@mozilla.com at Mon, 25 Mar 2019 10:05:39 +0000
Bug 1536682: Handle special CSS color within animation inspector. r=pbro Differential Revision: https://phabricator.services.mozilla.com/D24125
650a3bd934c4f8f0115ff74951244b00aaed8f8c: Bug 1537877 - Update getDocumentWalker to fallback to non-anonymous walker;r=pbro
Julian Descottes <jdescottes@mozilla.com> - Fri, 22 Mar 2019 19:43:08 +0000 - rev 465777
Push 112523 by shindli@mozilla.com at Sat, 23 Mar 2019 09:54:29 +0000
Bug 1537877 - Update getDocumentWalker to fallback to non-anonymous walker;r=pbro Except for rawParentNode, all consumers of getDocumentWalker should be ok with this fallback. Differential Revision: https://phabricator.services.mozilla.com/D24414
168ced56310572786eec78fd04e29e6340b84ddb: Bug 1114929: Add a test for multiline comment. r=pbro
Daisuke Akatsuka <dakatsuka@mozilla.com> - Thu, 21 Mar 2019 09:18:31 +0000 - rev 465404
Push 112505 by opoprus@mozilla.com at Thu, 21 Mar 2019 23:01:57 +0000
Bug 1114929: Add a test for multiline comment. r=pbro Depends on D24118 Differential Revision: https://phabricator.services.mozilla.com/D24119
9c404dce84745cd0b99acb604becca42c3777fbe: Bug 1114929: Apply line count of comments. r=pbro
Daisuke Akatsuka <dakatsuka@mozilla.com> - Wed, 20 Mar 2019 22:31:14 +0000 - rev 465403
Push 112505 by opoprus@mozilla.com at Thu, 21 Mar 2019 23:01:57 +0000
Bug 1114929: Apply line count of comments. r=pbro Differential Revision: https://phabricator.services.mozilla.com/D24118
007061524040559ab12d5735716599d8c97749cc: Bug 1536502 - Update license file with correct path to dagre-d3 devtools lib;r=pbro
Julian Descottes <jdescottes@mozilla.com> - Wed, 20 Mar 2019 16:30:55 +0000 - rev 465247
Push 112496 by shindli@mozilla.com at Thu, 21 Mar 2019 04:37:39 +0000
Bug 1536502 - Update license file with correct path to dagre-d3 devtools lib;r=pbro Depends on D24197 Differential Revision: https://phabricator.services.mozilla.com/D24200
4ef67fc524b631e9fc0ff5db4ceb6135d4620cb7: Bug 1536502 - Remove remaining references to webaudioeditor in devtools;r=pbro
Julian Descottes <jdescottes@mozilla.com> - Wed, 20 Mar 2019 16:08:01 +0000 - rev 465246
Push 112496 by shindli@mozilla.com at Thu, 21 Mar 2019 04:37:39 +0000
Bug 1536502 - Remove remaining references to webaudioeditor in devtools;r=pbro Differential Revision: https://phabricator.services.mozilla.com/D24197
4641d251c20864795f672b873466c41fb5d014d9: Bug 1535661 - Fix CORS issues in Markup Panel r=pbro
Michael Ratcliffe <mratcliffe@mozilla.com> - Mon, 18 Mar 2019 09:22:50 +0000 - rev 464755
Push 112481 by rgurzau@mozilla.com at Mon, 18 Mar 2019 21:51:19 +0000
Bug 1535661 - Fix CORS issues in Markup Panel r=pbro One change is in `node.js::isScrollable()` so I decided to assign this to you for review. Feel free to re-assign as you feel appropriate if you don't have time. ### Try https://treeherder.mozilla.org/#/jobs?repo=try&revision=2e2f20af3f902ea65436bcfd288b3e075d6508f8 Differential Revision: https://phabricator.services.mozilla.com/D23803
9d33ee85f2d4e5f45d6c795c2be3c27ec31f2bae: Bug 1488991: Update remote browser position before showing context menu. r=pbro,smaug
Daisuke Akatsuka <dakatsuka@mozilla.com> - Fri, 15 Mar 2019 00:09:20 +0000 - rev 464110
Push 112438 by opoprus@mozilla.com at Fri, 15 Mar 2019 09:46:56 +0000
Bug 1488991: Update remote browser position before showing context menu. r=pbro,smaug The position of remote browser was not updated by resizing the window and changing the align of viewport etc, although will be updated when the window moves, the frame reflows and so on. Thus, in this patch, update the position of remote browser before showing context menu so as to locates at proper position. I investigated though, when reflow and moving happens, the position is updated by TabParent::UpdateDimensions()[1]. This patch as well is taking an approach which update the position explicitly by TabParent::UpdateDimensions() before showing context menu. [1] https://searchfox.org/mozilla-central/source/dom/ipc/TabParent.cpp#729 Differential Revision: https://phabricator.services.mozilla.com/D23470
5c4d90e31d8c92a7df69e63d7f0624df52fed79f: Bug 1534567 - Ensure inherited CSS variables are case sensitive; r=pbro
Razvan Caliman <rcaliman@mozilla.com> - Tue, 12 Mar 2019 13:45:00 +0000 - rev 463664
Push 112406 by nbeleuzu@mozilla.com at Tue, 12 Mar 2019 21:48:50 +0000
Bug 1534567 - Ensure inherited CSS variables are case sensitive; r=pbro Bug 1512634 introduced a case-insensitive check for CSS properties. This caused a regression whereby inherited CSS variables with mixed case were incorrectly unmatched when shown in the Rules view. To fix this, we do a strict check for CSS variables in CSSProperties front because they are case sensitive (--color and --COLOR are different CSS variables). See: https://www.w3.org/TR/css-variables-1/ > Unlike other CSS properties, custom property names are case-sensitive. Differential Revision: https://phabricator.services.mozilla.com/D23113
a52a29b099bb46766007651c4418435ae68aa963: Bug 1533158 - Replace the orange highlight color with yellow when highlighting CSS properties. r=pbro
Micah Tigley <mtigley@mozilla.com> - Mon, 11 Mar 2019 15:09:04 +0000 - rev 463523
Push 112400 by btara@mozilla.com at Tue, 12 Mar 2019 10:04:06 +0000
Bug 1533158 - Replace the orange highlight color with yellow when highlighting CSS properties. r=pbro Differential Revision: https://phabricator.services.mozilla.com/D22418
0d69ee629ce50368c1dfead01fdd9878022380d9: Bug 1530621 - Disable smooth scrolling if user prefers reduced motion. r=pbro
Micah Tigley <mtigley@mozilla.com> - Thu, 07 Mar 2019 14:49:08 +0000 - rev 462944
Push 112349 by aiakab@mozilla.com at Thu, 07 Mar 2019 22:20:12 +0000
Bug 1530621 - Disable smooth scrolling if user prefers reduced motion. r=pbro Differential Revision: https://phabricator.services.mozilla.com/D22384