searching for reviewer(padenot)
ce1b32236689a46bed461fe3ca79df58414394bc: Bug 1596433 - Mark MediaStreamTrackAudioSourceNode active when set up with a live input track. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Fri, 15 Nov 2019 15:25:05 +0000 - rev 502404
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1596433 - Mark MediaStreamTrackAudioSourceNode active when set up with a live input track. r=padenot Differential Revision: https://phabricator.services.mozilla.com/D53025
9f72416c9e8a507772a72ac8d6f3d5f48f05e5b5: Bug 1565956 updated quoted AudioWorkletProcessor instantiation steps r=padenot
Karl Tomlinson <karlt+@karlt.net> - Fri, 15 Nov 2019 13:34:01 +0000 - rev 502355
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1565956 updated quoted AudioWorkletProcessor instantiation steps r=padenot Depends on D53129 Differential Revision: https://phabricator.services.mozilla.com/D53130
a77200f8f3eb7b00e27169f98d1272ceedab59d6: Bug 1565956 reorder AudioWorkletNode constructor parameter verification to align with spec r=padenot
Karl Tomlinson <karlt+@karlt.net> - Sun, 17 Nov 2019 21:21:31 +0000 - rev 502354
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1565956 reorder AudioWorkletNode constructor parameter verification to align with spec r=padenot and update quoted steps. Depends on D53128 Differential Revision: https://phabricator.services.mozilla.com/D53129
06248120ae60f264025c41a0cf6c62967b659b34: Bug 1596594 close MessagePort after 'recordfinished' is sent r=padenot
Karl Tomlinson <karlt+@karlt.net> - Fri, 15 Nov 2019 13:26:23 +0000 - rev 502352
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1596594 close MessagePort after 'recordfinished' is sent r=padenot so that 'recordfinished' is not sent again. Additional messages posted are dropped without error. `close()`ing to disentangle the MessagePort is also good practice as it allows GC of otherwise unused objects. Differential Revision: https://phabricator.services.mozilla.com/D53100
e6727b7a53916137d8f9988ab70d9e26ed72561b: Bug 1589931 - P2: Update cubeb-audiounit-rs to 0920240. r=padenot
Chun-Min Chang <chun.m.chang@gmail.com> - Thu, 14 Nov 2019 21:00:16 +0000 - rev 502077
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1589931 - P2: Update cubeb-audiounit-rs to 0920240. r=padenot Pick commits: 0920240 - Always return null-terminated strings from current_device (#25) Differential Revision: https://phabricator.services.mozilla.com/D52880
51cd57a31ea775eeb8605c160cb363512ab6cd2a: Bug 1589931 - P1: Only check non-null current output device. r=padenot
Chun-Min Chang <chun.m.chang@gmail.com> - Thu, 14 Nov 2019 21:00:34 +0000 - rev 502076
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1589931 - P1: Only check non-null current output device. r=padenot Differential Revision: https://phabricator.services.mozilla.com/D52750
a26e7fcb649ad67e85424c4db3bde8d91f807713: Bug 1546756 - Update WPT expectations following bug 1172394. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Thu, 14 Nov 2019 14:33:44 +0000 - rev 501963
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1546756 - Update WPT expectations following bug 1172394. r=padenot mediaElementAudioSourceToScriptProcessorTest creates an AudioContext at sample rate 44100, but that might not be the default cubeb rate on some platforms. If it isn't, we end up with two MediaTrackGraphs for the same window, with one being fed by the media element, and the other running the script processor node. It's when this happens that we only get 0 on the output. We force the preferred cubeb rate to 44100 for this test, so we at least keep the test coverage of the media element source node. This became permafail with bug 1172394, whereas before it was intermittent. Unclear why. Differential Revision: https://phabricator.services.mozilla.com/D52050
2516219862e8105ea4a782aaf4b55abfed95ca43: Bug 1172394 - Forward direct listeners to all inputs over a ForwardedInputTrack's lifetime. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Thu, 14 Nov 2019 14:56:00 +0000 - rev 501962
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1172394 - Forward direct listeners to all inputs over a ForwardedInputTrack's lifetime. r=padenot This was not needed when inputs to a ForwardedInputTrack could not come and go, but they can now. This keeps direct listeners for a ForwardedInputTrack around until it ends, as that's the terminal state where we know we can no longer process another input. Depends on D52049 Differential Revision: https://phabricator.services.mozilla.com/D53015
ae3cd36f38f669205933cb5c54e3e9a1b4144d99: Bug 1172394 - Always mark a MediaStreamAudioSourceNode attached to a live track as active. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Thu, 14 Nov 2019 14:33:44 +0000 - rev 501961
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1172394 - Always mark a MediaStreamAudioSourceNode attached to a live track as active. r=padenot Differential Revision: https://phabricator.services.mozilla.com/D52049
4f27806289e24d59e576305d93dbf1305c0e4ba3: Bug 1172394 - Use tail dispatching instead of mSrcStreamTracksAvailable. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Wed, 13 Nov 2019 22:39:58 +0000 - rev 501958
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1172394 - Use tail dispatching instead of mSrcStreamTracksAvailable. r=padenot Differential Revision: https://phabricator.services.mozilla.com/D52046
b91bd828c657d85120fe02e57410a0b82ec0acd3: Bug 1172394 - Simplify MediaSink somewhat. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Wed, 13 Nov 2019 22:40:05 +0000 - rev 501955
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1172394 - Simplify MediaSink somewhat. r=padenot This patches does several minor things: - Moves SetSink (from setSinkid) to automatic coalescing of multiple calls through a Canonical/Mirror setup instead of a manual atomic counter. - Simplifies the logic for when to update the sink in SetSink. - Removes PlaybackParams as a general MediaSink property, as it only contains audio params. - Makes PlaybackParams an internal AudioSink concept, that AudioSinkWrapper knows about. - Ensures mMediaSink is only accessed on the decoder TaskQueue, to allow accessing mirrored members when creating it. Differential Revision: https://phabricator.services.mozilla.com/D52043
fdf5dd8ff80792a48fd00771850104df655cd866: Bug 1172394 - Refactor how DecodedStream is set up. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Wed, 13 Nov 2019 22:40:07 +0000 - rev 501954
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1172394 - Refactor how DecodedStream is set up. r=padenot This patch removes the responsibility of js-facing MediaStreamTracks from the MediaDecoder stack, and moves the machinery for setting up DecodedStream to higher order functions like state mirroring and watchables. OutputStreamManager is completely gone, since it was designed to manage MediaStreamTracks across multiple output streams for a single decoder, on main thread. HTMLMediaElement took over its task in the previous patch. The MediaDecoderStateMachine now has three control points for capturing: - mOutputCaptured, which, if true, will capture all decoded data into mOutputTracks. If this is set, but mOutputTracks is empty, we are still waiting for tracks, and DecodedStream will not play any data. When tracks are set, a new DecodedStream is created that will play data through SourceMediaTracks piped into mOutputTracks. - mOutputTracks, which is the set of tracks data is captured into, for forwarding to all the output tracks the media element is managing. This set of tracks is managed by the MediaDecoder owner, and must contain one audio track if the decoder is decoding audio, and one video track if the decoder is decoding video. It may be empty since output can be captured before metadata is loaded, or playback has ended. - mOutputPrincipal, which is the principal of the decoded data. All data sent into SourceMediaTracks is tagged with this principal. Differential Revision: https://phabricator.services.mozilla.com/D52042
9114318b64930ec2e51c69567fa1281aa8f4f210: Bug 1172394 - Merge MediaStream and MediaDecoder track sources. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Wed, 13 Nov 2019 22:40:09 +0000 - rev 501953
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1172394 - Merge MediaStream and MediaDecoder track sources. r=padenot This reworks how media element captureStream works by removing the differences between MediaStream and MediaDecoder capture. MediaDecoder capture will be refactored so that ownership of MediaStreamTracks lies with the media element instead of the OutputStreamManager. The internal MediaDecoder parts happen in a later patch. The new API for capturing a MediaDecoder involves a boolean on/off toggle, the output tracks the decoder pipes data to, and the principal that data is tagged with. If capturing is on but there are no output tracks, playback will not happen, to ensure that no data gets accidentally skipped in the output tracks while captured. This also changes the logic for setting up MediaElementTrackSources in HTMLMediaElement so it's triggered by the WatchManager and thus run in tail dispatched runnables. Differential Revision: https://phabricator.services.mozilla.com/D52040
e20ee1ce7ce5a7fd144cedbb051c3858d9f91550: Bug 1172394 - Don't remove dom::MediaTracks on chained metadata updates. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Wed, 13 Nov 2019 22:39:46 +0000 - rev 501951
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1172394 - Don't remove dom::MediaTracks on chained metadata updates. r=padenot HTMLMediaElement avoid creating new tracks in MetadataLoaded when it has already created some, so there should be no side effect to this patch. Differential Revision: https://phabricator.services.mozilla.com/D52037
5b466cf155f9df1f059731abc615cf775e6a5ca0: Bug 1172394 - Perform some forgotten Stream -> Track renaming in DecodedStream. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Wed, 13 Nov 2019 22:39:48 +0000 - rev 501950
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1172394 - Perform some forgotten Stream -> Track renaming in DecodedStream. r=padenot Differential Revision: https://phabricator.services.mozilla.com/D52036
3ff0d72d23a267ace6188dcb339b06e7d09d51f2: Bug 1546756 - Update WPT expectations following bug 1172394. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Wed, 13 Nov 2019 08:58:30 +0000 - rev 501795
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1546756 - Update WPT expectations following bug 1172394. r=padenot mediaElementAudioSourceToScriptProcessorTest creates an AudioContext at sample rate 44100, but that might not be the default cubeb rate on some platforms. If it isn't, we end up with two MediaTrackGraphs for the same window, with one being fed by the media element, and the other running the script processor node. It's when this happens that we only get 0 on the output. We force the preferred cubeb rate to 44100 for this test, so we at least keep the test coverage of the media element source node. This became permafail with bug 1172394, whereas before it was intermittent. Unclear why. Differential Revision: https://phabricator.services.mozilla.com/D52050
a4f256e68ceff48ff088715a51ff793d880cd6e9: Bug 1172394 - Always mark a MediaStreamAudioSourceNode attached to a live track as active. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Wed, 13 Nov 2019 08:58:25 +0000 - rev 501794
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1172394 - Always mark a MediaStreamAudioSourceNode attached to a live track as active. r=padenot Differential Revision: https://phabricator.services.mozilla.com/D52049
94bd21d9b396a1d0ec3232a1afc0ea154879c491: Bug 1172394 - Use tail dispatching instead of mSrcStreamTracksAvailable. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Wed, 13 Nov 2019 08:56:31 +0000 - rev 501791
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1172394 - Use tail dispatching instead of mSrcStreamTracksAvailable. r=padenot Differential Revision: https://phabricator.services.mozilla.com/D52046
1c45b135318d8cb519b8d58af72ab864fe6bfd62: Bug 1172394 - Simplify MediaSink somewhat. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Wed, 13 Nov 2019 08:55:54 +0000 - rev 501788
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1172394 - Simplify MediaSink somewhat. r=padenot This patches does several minor things: - Moves SetSink (from setSinkid) to automatic coalescing of multiple calls through a Canonical/Mirror setup instead of a manual atomic counter. - Simplifies the logic for when to update the sink in SetSink. - Removes PlaybackParams as a general MediaSink property, as it only contains audio params. - Makes PlaybackParams an internal AudioSink concept, that AudioSinkWrapper knows about. - Ensures mMediaSink is only accessed on the decoder TaskQueue, to allow accessing mirrored members when creating it. Differential Revision: https://phabricator.services.mozilla.com/D52043
c57c41e8c39ea51e96c13af8ecdcbe1640e2a9d6: Bug 1172394 - Refactor how DecodedStream is set up. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Wed, 13 Nov 2019 08:55:39 +0000 - rev 501787
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1172394 - Refactor how DecodedStream is set up. r=padenot This patch removes the responsibility of js-facing MediaStreamTracks from the MediaDecoder stack, and moves the machinery for setting up DecodedStream to higher order functions like state mirroring and watchables. OutputStreamManager is completely gone, since it was designed to manage MediaStreamTracks across multiple output streams for a single decoder, on main thread. HTMLMediaElement took over its task in the previous patch. The MediaDecoderStateMachine now has three control points for capturing: - mOutputCaptured, which, if true, will capture all decoded data into mOutputTracks. If this is set, but mOutputTracks is empty, we are still waiting for tracks, and DecodedStream will not play any data. When tracks are set, a new DecodedStream is created that will play data through SourceMediaTracks piped into mOutputTracks. - mOutputTracks, which is the set of tracks data is captured into, for forwarding to all the output tracks the media element is managing. This set of tracks is managed by the MediaDecoder owner, and must contain one audio track if the decoder is decoding audio, and one video track if the decoder is decoding video. It may be empty since output can be captured before metadata is loaded, or playback has ended. - mOutputPrincipal, which is the principal of the decoded data. All data sent into SourceMediaTracks is tagged with this principal. Differential Revision: https://phabricator.services.mozilla.com/D52042
a796541fe5ef045738f1c10d95830b71fc5c024d: Bug 1172394 - Merge MediaStream and MediaDecoder track sources. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Wed, 13 Nov 2019 08:55:29 +0000 - rev 501786
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1172394 - Merge MediaStream and MediaDecoder track sources. r=padenot This reworks how media element captureStream works by removing the differences between MediaStream and MediaDecoder capture. MediaDecoder capture will be refactored so that ownership of MediaStreamTracks lies with the media element instead of the OutputStreamManager. The internal MediaDecoder parts happen in a later patch. The new API for capturing a MediaDecoder involves a boolean on/off toggle, the output tracks the decoder pipes data to, and the principal that data is tagged with. If capturing is on but there are no output tracks, playback will not happen, to ensure that no data gets accidentally skipped in the output tracks while captured. This also changes the logic for setting up MediaElementTrackSources in HTMLMediaElement so it's triggered by the WatchManager and thus run in tail dispatched runnables. Differential Revision: https://phabricator.services.mozilla.com/D52040
744fb77a58333b632dbf6820c77c7d8e97674b2c: Bug 1172394 - Don't remove dom::MediaTracks on chained metadata updates. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Wed, 13 Nov 2019 08:48:03 +0000 - rev 501784
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1172394 - Don't remove dom::MediaTracks on chained metadata updates. r=padenot HTMLMediaElement avoid creating new tracks in MetadataLoaded when it has already created some, so there should be no side effect to this patch. Differential Revision: https://phabricator.services.mozilla.com/D52037
afb4b226ff0409682b7bb2eb2475f227bc52aa96: Bug 1172394 - Perform some forgotten Stream -> Track renaming in DecodedStream. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Wed, 13 Nov 2019 08:47:48 +0000 - rev 501783
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1172394 - Perform some forgotten Stream -> Track renaming in DecodedStream. r=padenot Differential Revision: https://phabricator.services.mozilla.com/D52036
7a55cb6e7aecdd0d3fb786fefe8cc165558b78e0: Bug 1594136 - Check for ended track in MediaStreamTrackAudioSourceNode. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Wed, 13 Nov 2019 13:13:48 +0000 - rev 501734
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1594136 - Check for ended track in MediaStreamTrackAudioSourceNode. r=padenot Depends on D52521 Differential Revision: https://phabricator.services.mozilla.com/D52522
9473f8de212155dedc4eb74165211636324262bc: Bug 1594136 - Add crashtest. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Wed, 13 Nov 2019 13:13:55 +0000 - rev 501733
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1594136 - Add crashtest. r=padenot Differential Revision: https://phabricator.services.mozilla.com/D52521
f331f382d86bc23f85029c7380b938cc67010a3a: Bug 1594067 - Fix RemoveTrailing to handle correctly keep frames equals to zero. r=padenot
Alex Chronopoulos <achronop@gmail.com> - Thu, 07 Nov 2019 09:58:27 +0000 - rev 501123
Push 114168 by dluca@mozilla.com at Sun, 10 Nov 2019 03:08:55 +0000
Bug 1594067 - Fix RemoveTrailing to handle correctly keep frames equals to zero. r=padenot Fix `MediaSegmentBase::RemoveTrailing` to be able to accept the first argument, keep frames, equal to zero. The patch avoids calling the `AudioChunk::SliceTo()` method with zero slice duration which hits an assert. The crash was being triggered when in the AudioSegment was including one or more chunks, with the first chunk containing silence (null). Then the `AudioSegment::FlushAfter` had to be called with a duration smaller or equal to the duration of the first chunk. A unit test has been created, verifying the duration of the final segment. Differential Revision: https://phabricator.services.mozilla.com/D52092
cb5434e79ec6a188207818423e92485ff84d9c23: Bug 1594067 - Clear the AudioSegment when FlushAfter is called with new end equals to zero. r=padenot
Alex Chronopoulos <achronop@gmail.com> - Thu, 07 Nov 2019 09:58:20 +0000 - rev 501122
Push 114168 by dluca@mozilla.com at Sun, 10 Nov 2019 03:08:55 +0000
Bug 1594067 - Clear the AudioSegment when FlushAfter is called with new end equals to zero. r=padenot The AudioSegment::FlushAfter with input argument equals to zero is crashing on an assert that indicates misuse of the AudioChunk::SliceTo method. In general MediaSegmentBase::FlushAfter is better to clear itself when is called with argument equals to zero. This avoids the misuse and it is slightly more efficient. Differential Revision: https://phabricator.services.mozilla.com/D51862
268a241e565100c7433a03f6e41a490985b1b2c1: Bug 1590151 - Update cubeb-coreaudio-rs to cd954ca. r=padenot
Chun-Min Chang <chun.m.chang@gmail.com> - Thu, 07 Nov 2019 16:41:44 +0000 - rev 501113
Push 114168 by dluca@mozilla.com at Sun, 10 Nov 2019 03:08:55 +0000
Bug 1590151 - Update cubeb-coreaudio-rs to cd954ca. r=padenot Pick commits: cd954ca - Update dependencies (#22) 7043a0c - Make audiounit_get_devices_of_type infallible (#21) Differential Revision: https://phabricator.services.mozilla.com/D51725
586c8dec24bbf51a16c924e0f70596aea085758e: Bug 1593244 avoid await and async function so that setup() catches undefined context.audioWorklet r=padenot
Karl Tomlinson <karlt+@karlt.net> - Mon, 04 Nov 2019 17:28:32 +0000 - rev 500447
Push 114164 by aiakab@mozilla.com at Tue, 05 Nov 2019 10:06:15 +0000
Bug 1593244 avoid await and async function so that setup() catches undefined context.audioWorklet r=padenot Differential Revision: https://phabricator.services.mozilla.com/D51556
02f6d5d52fa9a9f364eaf88b70871af13614e577: Bug 1592555 - Not allow adding a null receiver in the AudioMixer callback list. r=padenot
Alex Chronopoulos <achronop@gmail.com> - Thu, 31 Oct 2019 10:01:53 +0000 - rev 499952
Push 114164 by aiakab@mozilla.com at Tue, 05 Nov 2019 10:06:15 +0000
Bug 1592555 - Not allow adding a null receiver in the AudioMixer callback list. r=padenot A null MixerCallbackReceiver in the AudioMixer callback list can create a crash when the AudioMixer::FinishMixing() is being called. Verify that the receiver is not null before adding it in the list. Differential Revision: https://phabricator.services.mozilla.com/D51082
02d15f78c542fb761dbf46f645c2fd50e47869db: Bug 1592503 use setup() to wrap code that may error before tests are created r=padenot
Karl Tomlinson <karlt+@karlt.net> - Wed, 30 Oct 2019 11:08:33 +0000 - rev 499830
Push 114163 by aiakab@mozilla.com at Thu, 31 Oct 2019 10:03:38 +0000
Bug 1592503 use setup() to wrap code that may error before tests are created r=padenot as documented in https://web-platform-tests.org/writing-tests/testharness-api.html#setup On errors without setup(), the harness would assume a single page test and report as FAIL in an imaginary subtest name based on document.title. Wrapping in setup() leads to failures reporting as a toplevel ERROR, which perhaps better reports the nature of the failure. Differential Revision: https://phabricator.services.mozilla.com/D51052
18202ef8a94a6997d1e0934210ad1f12553ff4a6: Bug 1591254 set WorkletNodeEngine input and output span lengths appropriately for zero inputs and outputs r=padenot
Karl Tomlinson <karlt+@karlt.net> - Fri, 25 Oct 2019 12:57:46 +0000 - rev 499348
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1591254 set WorkletNodeEngine input and output span lengths appropriately for zero inputs and outputs r=padenot AudioNodeTrack::ProcessInput() uses ProcessBlock() when input and output counts are <= 1. Differential Revision: https://phabricator.services.mozilla.com/D50552
f599b71d92e01a06e028eb2ab5aaa01f91056514: Bug 1589514 - P2: Update cubeb-coreaudio-rs to 92e2e11. r=padenot
Chun-Min Chang <chun.m.chang@gmail.com> - Tue, 22 Oct 2019 11:46:55 +0000 - rev 498595
Push 114159 by shindli@mozilla.com at Thu, 24 Oct 2019 09:49:00 +0000
Bug 1589514 - P2: Update cubeb-coreaudio-rs to 92e2e11. r=padenot Depends on D50002 Differential Revision: https://phabricator.services.mozilla.com/D50003
7200475570e8243a9cd91e76692493672a7e2f0b: Bug 1589514 - P1: Update script importing cubeb-coreaudio-rs. r=padenot
Chun-Min Chang <chun.m.chang@gmail.com> - Tue, 22 Oct 2019 11:46:32 +0000 - rev 498594
Push 114159 by shindli@mozilla.com at Thu, 24 Oct 2019 09:49:00 +0000
Bug 1589514 - P1: Update script importing cubeb-coreaudio-rs. r=padenot Pick commits: 92e2e11 - minor style fix 5163960 - Update authors fdb0b1d - Make utf8_from_cfstringref work with empty CFStringRef (#20) a39bf5f - Remove a fixed issue Differential Revision: https://phabricator.services.mozilla.com/D50002
e322e2112b1f07758d92dac2553af17ece2a28d9: Bug 1248897 - Introducing an online speech recognition service for Web Speech API r=smaug,pehrsons,padenot
Andre Natal <anatal@gmail.com> - Mon, 21 Oct 2019 20:58:57 +0000 - rev 498458
Push 114158 by ncsoregi@mozilla.com at Tue, 22 Oct 2019 09:53:30 +0000
Bug 1248897 - Introducing an online speech recognition service for Web Speech API r=smaug,pehrsons,padenot This patch introduces a Speech Recognition Service which interfaces with Mozilla's remote STT endpoint which is currently being used by multiple services Differential Revision: https://phabricator.services.mozilla.com/D26047
239ff6e79980e9b8c96a5f46a9555066fd899aed: Bug 1572884 - Upmix mono webaudio channels to stereo when the output configuration is 3 and 5 channels. r=padenot
Alex Chronopoulos <achronop@gmail.com> - Fri, 18 Oct 2019 07:46:07 +0000 - rev 498135
Push 114157 by nbeleuzu@mozilla.com at Mon, 21 Oct 2019 22:00:13 +0000
Bug 1572884 - Upmix mono webaudio channels to stereo when the output configuration is 3 and 5 channels. r=padenot WebAudio upmix layout is defined in the spec for the channel configurations mono, stereo, quad and 5.1. Layouts with 3 and 5 channels are not defined yet. For those undefined layouts firefox provided upmix to a single channel (left). This has been updated to upmix to the two stereo channels (left, right). Differential Revision: https://phabricator.services.mozilla.com/D49610
ff6a0f7ee6970c73ebcfbb1a4a62b3ccef53a9e2: Bug 1572884 - Upmix mono webaudio channels to stereo when the output configuration is 3 and 5 channels. r=padenot
Alex Chronopoulos <achronop@gmail.com> - Thu, 17 Oct 2019 14:39:44 +0000 - rev 498052
Push 114157 by nbeleuzu@mozilla.com at Mon, 21 Oct 2019 22:00:13 +0000
Bug 1572884 - Upmix mono webaudio channels to stereo when the output configuration is 3 and 5 channels. r=padenot WebAudio upmix layout is defined in the spec for the channel configurations mono, stereo, quad and 5.1. Layouts with 3 and 5 channels are not defined yet. For those undefined layouts firefox provided upmix to a single channel (left). This has been updated to upmix to the two stereo channels (left, right). Differential Revision: https://phabricator.services.mozilla.com/D49610
c116c122cc6f555d67ec4d863a347073a1f255bd: Bug 1581000 - Turn on audiounit-rust by default in Nightly. r=padenot
Chun-Min Chang <chun.m.chang@gmail.com> - Tue, 15 Oct 2019 23:16:18 +0000 - rev 497751
Push 114154 by btara@mozilla.com at Thu, 17 Oct 2019 09:58:40 +0000
Bug 1581000 - Turn on audiounit-rust by default in Nightly. r=padenot Differential Revision: https://phabricator.services.mozilla.com/D45762
ead1bd9a7f61aeca97db2285b1c640c04d5bee55: Bug 1586387 - Don't append a device change message to a graph that is going away. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Tue, 08 Oct 2019 21:39:30 +0000 - rev 496926
Push 114147 by ccoroiu@mozilla.com at Thu, 10 Oct 2019 09:56:56 +0000
Bug 1586387 - Don't append a device change message to a graph that is going away. r=padenot Differential Revision: https://phabricator.services.mozilla.com/D48553
8f081694cf9bd8c388e0276cd3a40174c608eb44: Bug 1586678 - Remove media/audioipc from the license exclude list r=padenot
Sylvestre Ledru <sledru@mozilla.com> - Mon, 07 Oct 2019 14:44:12 +0000 - rev 496583
Push 114145 by apavel@mozilla.com at Tue, 08 Oct 2019 11:00:56 +0000
Bug 1586678 - Remove media/audioipc from the license exclude list r=padenot Differential Revision: https://phabricator.services.mozilla.com/D48305
2e24c5cac308985ae67f82bbe19d3389aa3bd3e0: Bug 1583463 - Lock SourceMediaStream's mMutex also during shutdown. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Thu, 03 Oct 2019 19:49:47 +0000 - rev 496540
Push 114145 by apavel@mozilla.com at Tue, 08 Oct 2019 11:00:56 +0000
Bug 1583463 - Lock SourceMediaStream's mMutex also during shutdown. r=padenot Differential Revision: https://phabricator.services.mozilla.com/D47681
3418a8c2baa6d3e2d3246032b9a9268480bbe90a: Bug 1585843 - Don't try to reject disconnected promise in AudioSink::Errored. r=padenot
Matthew Gregan <kinetik@flim.org> - Thu, 03 Oct 2019 07:32:29 +0000 - rev 496147
Push 114143 by rgurzau@mozilla.com at Mon, 07 Oct 2019 09:35:08 +0000
Bug 1585843 - Don't try to reject disconnected promise in AudioSink::Errored. r=padenot Differential Revision: https://phabricator.services.mozilla.com/D48002
9ea7aabf10fbf326e43daaa88b30f477b4ee3c32: Bug 1454998 - Rename streams to tracks. r=padenot,karlt,smaug
Andreas Pehrson <apehrson@mozilla.com> - Wed, 02 Oct 2019 10:23:02 +0000 - rev 495984
Push 114140 by dvarga@mozilla.com at Wed, 02 Oct 2019 18:04:51 +0000
Bug 1454998 - Rename streams to tracks. r=padenot,karlt,smaug This renames the following (in alphabetical order, non-exhaustive): AudioCaptureStream -> AudioCaptureTrack AudioNodeStream -> AudioNodeTrack AudioNodeExternalInputStream -> AudioNodeExternalInputTrack DirectMediaStreamTrackListener -> DirectMediaTrackListener MediaStream -> MediaTrack - Note that there's also dom::MediaTrack. Namespaces differentiate them. MediaStreamGraph -> MediaTrackGraph MediaStreamTrackListener -> MediaTrackListener MSG -> MTG (in comments) ProcessedMediaStream -> ProcessedMediaTrack SharedDummyStream -> SharedDummyTrack SourceMediaStream -> SourceMediaTrack StreamTime -> TrackTime TrackUnionStream -> ForwardedInputTrack - Because this no longer takes a union of anything, but only a single track as input. Other minor classes, members and comments have been updated to reflect these name changes. Differential Revision: https://phabricator.services.mozilla.com/D46146
7cd5ea4167b6a84da615d02ab362507ac507ab8a: Bug 1454998 - Remove the notion of streams from MediaStreamGraph. r=padenot,karlt
Andreas Pehrson <apehrson@mozilla.com> - Wed, 02 Oct 2019 10:22:53 +0000 - rev 495982
Push 114140 by dvarga@mozilla.com at Wed, 02 Oct 2019 18:04:51 +0000
Bug 1454998 - Remove the notion of streams from MediaStreamGraph. r=padenot,karlt This change mainly removes the `mTracks` member from MediaStream and moves all associated members up a level, so that a MediaStream in practice represents a single track. Classes will be renamed in a future patch to reflect this. Other changes include: The new `mEnded` member of MediaStream changes meaning to only become true when all data in the stream has been processed. It stems from StreamTracks::Track::mEnded which used to become true as soon as the last bit of data had been added to a track, and there could still be data in the track that would get processed in future iterations. We are moving towards not having any future data in tracks, which is why this change is ok to make -- keeping the old behavior will soon not make sense. TrackUnionStream is changed to no longer take a list of streams as input and forward the union of their tracks to itself. Instead it's limited to having one track as input at a time. The autofinishing functionality that TrackUnionStream had before has been transformed into an autoending functionality to allow it to defer ending until its been told that it's ok to end through the control API. This lets a single TrackUnionStream span the lifetime of multiple inputs, which will be useful for making DecodedStream spec compliant with HTMLMediaElement::CaptureStream(), and for implementing the currently discussed MediaRecorder::ReplaceTrack(), to name a few potential use cases. AudioNodeStreams used to only have a track (and thus an AudioSegment) if the EXTERNAL_OUTPUT flag was enabled on them. With all MediaStreams now representing a track, AudioNodeStreams inherently have an AudioSegment as a member. It is however only used with data if the EXTERNAL_OUTPUT flag is enabled. Differential Revision: https://phabricator.services.mozilla.com/D45821
a4d88d5b86d236867bd590c9b770725a9b0a8f93: Bug 1454998 - Break out PrincipalHandle into its own file. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Wed, 02 Oct 2019 10:22:48 +0000 - rev 495979
Push 114140 by dvarga@mozilla.com at Wed, 02 Oct 2019 18:04:51 +0000
Bug 1454998 - Break out PrincipalHandle into its own file. r=padenot Differential Revision: https://phabricator.services.mozilla.com/D46764
80417bdfa72112c6f9472c29ce49e8ff81e8c688: Bug 1454998 - Rename streams to tracks. r=padenot,karlt,smaug
Andreas Pehrson <apehrson@mozilla.com> - Wed, 02 Oct 2019 08:18:16 +0000 - rev 495965
Push 114140 by dvarga@mozilla.com at Wed, 02 Oct 2019 18:04:51 +0000
Bug 1454998 - Rename streams to tracks. r=padenot,karlt,smaug This renames the following (in alphabetical order, non-exhaustive): AudioCaptureStream -> AudioCaptureTrack AudioNodeStream -> AudioNodeTrack AudioNodeExternalInputStream -> AudioNodeExternalInputTrack DirectMediaStreamTrackListener -> DirectMediaTrackListener MediaStream -> MediaTrack - Note that there's also dom::MediaTrack. Namespaces differentiate them. MediaStreamGraph -> MediaTrackGraph MediaStreamTrackListener -> MediaTrackListener MSG -> MTG (in comments) ProcessedMediaStream -> ProcessedMediaTrack SharedDummyStream -> SharedDummyTrack SourceMediaStream -> SourceMediaTrack StreamTime -> TrackTime TrackUnionStream -> ForwardedInputTrack - Because this no longer takes a union of anything, but only a single track as input. Other minor classes, members and comments have been updated to reflect these name changes. Differential Revision: https://phabricator.services.mozilla.com/D46146
ae6056b748d1eb640cfe5d457f39054d66346a8e: Bug 1454998 - Remove the notion of streams from MediaStreamGraph. r=padenot,karlt
Andreas Pehrson <apehrson@mozilla.com> - Wed, 02 Oct 2019 08:17:51 +0000 - rev 495963
Push 114140 by dvarga@mozilla.com at Wed, 02 Oct 2019 18:04:51 +0000
Bug 1454998 - Remove the notion of streams from MediaStreamGraph. r=padenot,karlt This change mainly removes the `mTracks` member from MediaStream and moves all associated members up a level, so that a MediaStream in practice represents a single track. Classes will be renamed in a future patch to reflect this. Other changes include: The new `mEnded` member of MediaStream changes meaning to only become true when all data in the stream has been processed. It stems from StreamTracks::Track::mEnded which used to become true as soon as the last bit of data had been added to a track, and there could still be data in the track that would get processed in future iterations. We are moving towards not having any future data in tracks, which is why this change is ok to make -- keeping the old behavior will soon not make sense. TrackUnionStream is changed to no longer take a list of streams as input and forward the union of their tracks to itself. Instead it's limited to having one track as input at a time. The autofinishing functionality that TrackUnionStream had before has been transformed into an autoending functionality to allow it to defer ending until its been told that it's ok to end through the control API. This lets a single TrackUnionStream span the lifetime of multiple inputs, which will be useful for making DecodedStream spec compliant with HTMLMediaElement::CaptureStream(), and for implementing the currently discussed MediaRecorder::ReplaceTrack(), to name a few potential use cases. AudioNodeStreams used to only have a track (and thus an AudioSegment) if the EXTERNAL_OUTPUT flag was enabled on them. With all MediaStreams now representing a track, AudioNodeStreams inherently have an AudioSegment as a member. It is however only used with data if the EXTERNAL_OUTPUT flag is enabled. Differential Revision: https://phabricator.services.mozilla.com/D45821
3ce4dc7e9ae24adc463c4106cc5d3ab6c13dedb6: Bug 1454998 - Break out PrincipalHandle into its own file. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Wed, 02 Oct 2019 08:12:18 +0000 - rev 495960
Push 114140 by dvarga@mozilla.com at Wed, 02 Oct 2019 18:04:51 +0000
Bug 1454998 - Break out PrincipalHandle into its own file. r=padenot Differential Revision: https://phabricator.services.mozilla.com/D46764
3fbc1456c6d26d91729498ea6ad19dc24e479dfa: Bug 1544997 - Propogate cubeb stream error to AudioSink to handle loss of audio device. r=padenot
Matthew Gregan <kinetik@flim.org> - Tue, 01 Oct 2019 12:14:44 +0000 - rev 495842
Push 114140 by dvarga@mozilla.com at Wed, 02 Oct 2019 18:04:51 +0000
Bug 1544997 - Propogate cubeb stream error to AudioSink to handle loss of audio device. r=padenot Differential Revision: https://phabricator.services.mozilla.com/D47745
c6d0570a09eed3bb6e15073d61175ff4e312407b: Bug 1584560 - On default settings use the actual device channel count. r=padenot
Alex Chronopoulos <achronop@gmail.com> - Mon, 30 Sep 2019 09:15:42 +0000 - rev 495615
Push 114140 by dvarga@mozilla.com at Wed, 02 Oct 2019 18:04:51 +0000
Bug 1584560 - On default settings use the actual device channel count. r=padenot In `MediaEngineWebRTCMicrophoneSource::EvaluateSettings`, on default settings, the `prefs.mChannels` is updated accordingly. However, it is not used for the calculation of the `FlattenedConstraints`. As a result, the channel count is 0, which is converted to 1, and not the actual device channel count as it should. Thus, the `prefs.mChannels` is used in the calculation of the `FlattenedConstraints`. Differential Revision: https://phabricator.services.mozilla.com/D47453