searching for reviewer(nbp)
55bcd7df1f7ad1748065e0fa8d1989fc9345c6f6: Bug 1593388: Remove gdb pretty-printer for js::jit::ExecutableAllocator. r=nbp
Jim Blandy <jimb@mozilla.com> - Wed, 06 Nov 2019 19:43:42 +0000 - rev 500924
Push 114166 by apavel@mozilla.com at Thu, 07 Nov 2019 10:04:01 +0000
Bug 1593388: Remove gdb pretty-printer for js::jit::ExecutableAllocator. r=nbp This pretty printer wants to traverse a mozilla::detail::HashTable, but the way that type represents the actual table has changed drastically since the pretty-printer was last working. The type of the `mTable` member is now `char*`, and it seems to be an array of hash values concatenated with the actual entries. Fixing that seems like it will take a significant investment. I would love to see this brought back from the revision control history and fixed, but removing it is all I have time for at the moment. Differential Revision: https://phabricator.services.mozilla.com/D51487
dfd48b94b7456751af03213a57625faa335da1dc: Bug 1585372 - Compute script name in InitScriptCoverage. r=nbp
Ted Campbell <tcampbell@mozilla.com> - Mon, 04 Nov 2019 16:33:35 +0000 - rev 500454
Push 114164 by aiakab@mozilla.com at Tue, 05 Nov 2019 10:06:15 +0000
Bug 1585372 - Compute script name in InitScriptCoverage. r=nbp To avoid calling JSScript::function() from finalizer, we need to read the name earlier in process. Differential Revision: https://phabricator.services.mozilla.com/D51474
b3a76c2b11b343f6170ccb599d1af7d8cfd06858: Bug 1585372 - Run InitScriptCoverage after initialization. r=jandem,nbp
Ted Campbell <tcampbell@mozilla.com> - Mon, 04 Nov 2019 20:21:28 +0000 - rev 500453
Push 114164 by aiakab@mozilla.com at Tue, 05 Nov 2019 10:06:15 +0000
Bug 1585372 - Run InitScriptCoverage after initialization. r=jandem,nbp To allow InitScriptCoverage to be more flexible, we need to delay the call until the JSScript is actually initialized. This moves the calls from JSScript constructor until the JSScript is actually initialized. This is similar to the debugger onNewScript call, but more cleanup would be needed to unify these. Differential Revision: https://phabricator.services.mozilla.com/D51473
747fc2e159baf123a82b85590b430f2b013b32ca: Bug 1586912: Don't ComputeRandomAllocationAddress on OpenBSD r=nbp
Kurt Miller <kurt@intricatesoftware.com> - Mon, 04 Nov 2019 14:04:53 +0000 - rev 500375
Push 114164 by aiakab@mozilla.com at Tue, 05 Nov 2019 10:06:15 +0000
Bug 1586912: Don't ComputeRandomAllocationAddress on OpenBSD r=nbp OpenBSD already has a random mmap() Differential Revision: https://phabricator.services.mozilla.com/D51299
529b411a970ac57d44ad7d752d2a79ca010d5699: Bug 1588300 - Use IterateScripts API when generating code coverage data r=nbp
Jon Coppeard <jcoppeard@mozilla.com> - Mon, 14 Oct 2019 10:12:23 +0000 - rev 497484
Push 114152 by dvarga@mozilla.com at Tue, 15 Oct 2019 11:14:34 +0000
Bug 1588300 - Use IterateScripts API when generating code coverage data r=nbp Differential Revision: https://phabricator.services.mozilla.com/D49111
85a86e5a8815527c1a64d21ff63c66c086224285: Bug 1586485 - Don't discard script counts on GC when --dump-bytecode is used. r=nbp
Jan de Mooij <jdemooij@mozilla.com> - Mon, 07 Oct 2019 12:36:01 +0000 - rev 496567
Push 114145 by apavel@mozilla.com at Tue, 08 Oct 2019 11:00:56 +0000
Bug 1586485 - Don't discard script counts on GC when --dump-bytecode is used. r=nbp Also ensure DumpPCCounts does not trigger GC and discard the script counts when disassembling in debug builds. Differential Revision: https://phabricator.services.mozilla.com/D48299
0d25043ccb597b798d42a16f8c3173ec030daa86: Bug 1398738 - Discard ScriptCounts after discarding JitScript. r=nbp
Jan de Mooij <jdemooij@mozilla.com> - Fri, 04 Oct 2019 15:03:57 +0000 - rev 496331
Push 114143 by rgurzau@mozilla.com at Mon, 07 Oct 2019 09:35:08 +0000
Bug 1398738 - Discard ScriptCounts after discarding JitScript. r=nbp Differential Revision: https://phabricator.services.mozilla.com/D48165
1cf96914dd193a3a596e6b35a12fdaeb816e095a: Bug 1586165 - Null check ionCounts_ before calling sizeOfIncludingThis on it. r=nbp
Jan de Mooij <jdemooij@mozilla.com> - Fri, 04 Oct 2019 12:46:20 +0000 - rev 496314
Push 114143 by rgurzau@mozilla.com at Mon, 07 Oct 2019 09:35:08 +0000
Bug 1586165 - Null check ionCounts_ before calling sizeOfIncludingThis on it. r=nbp Differential Revision: https://phabricator.services.mozilla.com/D48163
5bd04359efb6dfd901e1ee729c50f80a3ab88499: Bug 1583907 - Add MOZ_NEVER_INLINE to LifoAlloc::mark to work around Clang 9 miscompilation on Android. r=nbp
Jan de Mooij <jdemooij@mozilla.com> - Fri, 27 Sep 2019 16:22:43 +0000 - rev 495404
Push 114134 by ccoroiu@mozilla.com at Mon, 30 Sep 2019 09:57:15 +0000
Bug 1583907 - Add MOZ_NEVER_INLINE to LifoAlloc::mark to work around Clang 9 miscompilation on Android. r=nbp Differential Revision: https://phabricator.services.mozilla.com/D47435
95a274d7de37e77c1edd7f535de702a60bfdde51: Bug 1583408 - Handle uncompleted scripts correctly in LCov code. r=nbp
Ted Campbell <tcampbell@mozilla.com> - Tue, 24 Sep 2019 10:25:27 +0000 - rev 494667
Push 114125 by cbrindusan@mozilla.com at Tue, 24 Sep 2019 16:12:51 +0000
Bug 1583408 - Handle uncompleted scripts correctly in LCov code. r=nbp When a JSScript is partially initialized we must detect this and not generate coverage information. This incomplete script may still have an entry in the ScriptLCovMap. The existing collectCodeCoverageInfo code handled this correctly but the new CollectScriptCoverage function did not. Differential Revision: https://phabricator.services.mozilla.com/D46888
8a7f8a71391fddc37bdddec40d78b4e84662f693: Bug 1578730 - Track script-associated LCovSource instead of filename. r=nbp
Ted Campbell <tcampbell@mozilla.com> - Mon, 23 Sep 2019 13:15:29 +0000 - rev 494494
Push 114122 by csabou@mozilla.com at Mon, 23 Sep 2019 21:59:47 +0000
Bug 1578730 - Track script-associated LCovSource instead of filename. r=nbp To avoid needing to access JSScript::realm() during finalization, we associate the LCovSource* with a JSScript (if coverage is enabled). This also saves memory by avoiding cloning the filename for each inner function. One semantic change here is that the LCovRealm/Source is allocated sooner than previously, but the result is the same. Differential Revision: https://phabricator.services.mozilla.com/D46173
b194fe05c5559d1d02af6d8bb28c5195f0f8cdb7: Bug 1578730 - Move ScriptNameMap to js/src/vm/CodeCoverage files. r=nbp
Ted Campbell <tcampbell@mozilla.com> - Mon, 23 Sep 2019 13:04:04 +0000 - rev 494493
Push 114122 by csabou@mozilla.com at Mon, 23 Sep 2019 21:59:47 +0000
Bug 1578730 - Move ScriptNameMap to js/src/vm/CodeCoverage files. r=nbp Refactor the ScriptNameMap code to put more of the logic in the code-coverage sources instead of the JSScript sources. Also make JS::Realm::lcovRealm use an accessor function to allocate as needed. Differential Revision: https://phabricator.services.mozilla.com/D46172
8d80982a429fb1da9cf751b80153cfe822307a12: Bug 1578730 - Defer LCovSource::writeScript OOM flag. r=nbp
Ted Campbell <tcampbell@mozilla.com> - Mon, 23 Sep 2019 13:06:40 +0000 - rev 494492
Push 114122 by csabou@mozilla.com at Mon, 23 Sep 2019 21:59:47 +0000
Bug 1578730 - Defer LCovSource::writeScript OOM flag. r=nbp To prepare for later patches, track writeScript OOMs as a flag inside LCovSource. This flag is checked when merging the LCovSource into an LCovRealm. This allows us to avoid handling errors while finalizing JSScripts. Differential Revision: https://phabricator.services.mozilla.com/D46171
910a125e41dce67b5d5a0b0bc168c840b35033a9: Bug 1578730 - Use vector of pointers for LCovRealm::sources. r=nbp
Ted Campbell <tcampbell@mozilla.com> - Sat, 21 Sep 2019 14:11:09 +0000 - rev 494419
Push 114117 by shindli@mozilla.com at Sat, 21 Sep 2019 21:52:18 +0000
Bug 1578730 - Use vector of pointers for LCovRealm::sources. r=nbp Now that LCovRealm is allocated on demand, use a Vector directly instead of allocating that vector on demand. To ensure pointer stability of LCovSources, allocated them in the LifoAlloc and only store pointers in the sources vector. They are still fully owned by the LCovRealm. Differential Revision: https://phabricator.services.mozilla.com/D46170
19172ad2dea7ca4b24e864d1ea6db7cec58ab3d5: Bug 1578730 - Allocate LCovRealm on first use. r=nbp
Ted Campbell <tcampbell@mozilla.com> - Sat, 21 Sep 2019 13:36:58 +0000 - rev 494418
Push 114117 by shindli@mozilla.com at Sat, 21 Sep 2019 21:52:18 +0000
Bug 1578730 - Allocate LCovRealm on first use. r=nbp Save a little bit of memory when code coverage is not in use. Add a collectCodeCoverage method to the realm so it can allocate LCovRealm on demand. Also compute the realm name string from the constructor instead of in the lookup code (this still happens at same time). Depends on D46168 Differential Revision: https://phabricator.services.mozilla.com/D46169
985febe1e1a790223f952d8a980f6cb81ec8b94f: Bug 1578730 - Run JSScript::initScriptName on main-thread only. r=nbp
Ted Campbell <tcampbell@mozilla.com> - Sat, 21 Sep 2019 13:04:41 +0000 - rev 494417
Push 114117 by shindli@mozilla.com at Sat, 21 Sep 2019 21:52:18 +0000
Bug 1578730 - Run JSScript::initScriptName on main-thread only. r=nbp Avoid creating the ScriptNameMap in the off-thread parse zone. Instead perform JSScript::initScriptName when merging the parse result to main thread. This will avoid the need to migrate coverage initialization data between Realms. Differential Revision: https://phabricator.services.mozilla.com/D46168
7581d5468864321298470596bf7de196566dfde1: Bug 1578730 - Add js::GetCodeCovergeSummaryAll API. r=nbp,marco
Ted Campbell <tcampbell@mozilla.com> - Thu, 19 Sep 2019 00:08:39 +0000 - rev 494416
Push 114117 by shindli@mozilla.com at Sat, 21 Sep 2019 21:52:18 +0000
Bug 1578730 - Add js::GetCodeCovergeSummaryAll API. r=nbp,marco Split the GetCodeCoverageSummary API into a variant for a specific realm vs checking all realms. This restores the original behaviour of the getLcovInfo testing function to only return info on current realm. This makes testing OOM behaviour much more predictable. Differential Revision: https://phabricator.services.mozilla.com/D46167
008417a25693a324e5ead68b28e3ecd2c5cb46aa: Bug 1580518: Don't explicitly depend on target-lexicon for Cranelift's build; r=nbp
Benjamin Bouvier <benj@benj.me> - Wed, 11 Sep 2019 16:04:20 +0000 - rev 492805
Push 114076 by ncsoregi@mozilla.com at Thu, 12 Sep 2019 15:29:15 +0000
Bug 1580518: Don't explicitly depend on target-lexicon for Cranelift's build; r=nbp This means that every update of target-lexicon in Cranelift won't require Spidermonkey developers to bump the version number of target-lexicon in Baldrdash. Differential Revision: https://phabricator.services.mozilla.com/D45549
4bfe4a6b33415bd9ac4bae7c03b90f03519580e7: Bug 1580518: Cranelift: update to new FunctionBuilder's API; r=nbp
Benjamin Bouvier <benj@benj.me> - Wed, 11 Sep 2019 16:08:14 +0000 - rev 492804
Push 114076 by ncsoregi@mozilla.com at Thu, 12 Sep 2019 15:29:15 +0000
Bug 1580518: Cranelift: update to new FunctionBuilder's API; r=nbp There's a memory regression caused by the merge of https://github.com/CraneStation/cranelift/pull/671, preventing us from reusing the memory of the Context's func field for the Function passed to the translate function. This is tracked as https://github.com/CraneStation/cranelift/issues/1018. Differential Revision: https://phabricator.services.mozilla.com/D45548
3c352d78e1c512a7408ea6899dd35c7f676c8bcf: Bug 1577224 - Fix assertion in assertNoPoolAndNoNops to account for OOM. r=nbp
Jan de Mooij <jdemooij@mozilla.com> - Tue, 03 Sep 2019 09:25:07 +0000 - rev 491409
Push 114022 by rmaries@mozilla.com at Tue, 03 Sep 2019 15:49:32 +0000
Bug 1577224 - Fix assertion in assertNoPoolAndNoNops to account for OOM. r=nbp Most of the pool-related methods return early on OOM. Differential Revision: https://phabricator.services.mozilla.com/D44363
11042db2e05e1d29562f1d115508c647707ad74e: Bug 1568740 - (part 1) Remove Nursery::exists r=nbp
Paul Bone <pbone@mozilla.com> - Mon, 02 Sep 2019 23:25:25 +0000 - rev 491257
Push 114019 by dluca@mozilla.com at Tue, 03 Sep 2019 04:12:43 +0000
Bug 1568740 - (part 1) Remove Nursery::exists r=nbp The Nursery almost always exists. To remove the nursery's chunkCountLimit_ field we need to remove Nursery::exists(), so no-longer use it in the JIT. Differential Revision: https://phabricator.services.mozilla.com/D39280
1d3e2f937623fd8f6323417fafa49177849cfa1b: Bug 1531480 - Replace uses of jsbytecode* with BytecodeLocation and BytecodeIterator inside RemoveReferenceNames r=nbp
kellykc72 <kellykc72@gmail.com> - Fri, 09 Aug 2019 14:33:56 +0000 - rev 487262
Push 113866 by csabou@mozilla.com at Fri, 09 Aug 2019 22:18:05 +0000
Bug 1531480 - Replace uses of jsbytecode* with BytecodeLocation and BytecodeIterator inside RemoveReferenceNames r=nbp Encapsulate manipulation of bytecode within RemoveReferenceNames method using accessor classes BytecodeLocation and BytecodeIterator Differential Revision: https://phabricator.services.mozilla.com/D41120
251f98554914c77fa41b94361fc5b8e593860d38: Bug 1568740 - (part 1) Remove Nursery::exists r=nbp
Paul Bone <pbone@mozilla.com> - Wed, 31 Jul 2019 04:06:45 +0000 - rev 486145
Push 113833 by cbrindusan@mozilla.com at Mon, 05 Aug 2019 10:00:20 +0000
Bug 1568740 - (part 1) Remove Nursery::exists r=nbp Nursery::exists() behaved exactly the same as Nursery::isEnabled() so use the latter. Differential Revision: https://phabricator.services.mozilla.com/D39280
30a8df41ff6db0323d045bdc56cb5f0c95e92b9a: Bug 1570091 Part 2 - Don't use bytecode cache when loading scripts in globals with instrumentation, r=smaug,nbp.
Brian Hackett <bhackett1024@gmail.com> - Sun, 04 Aug 2019 00:03:56 +0000 - rev 486110
Push 113830 by aciure@mozilla.com at Sun, 04 Aug 2019 09:50:05 +0000
Bug 1570091 Part 2 - Don't use bytecode cache when loading scripts in globals with instrumentation, r=smaug,nbp. Depends on D39932 Differential Revision: https://phabricator.services.mozilla.com/D39933
0abde41f3403465bfc024c0d942e4ab84a1ef55d: Bug 1568119 - Mark the test as slow so it doesn't cause timeouts r=nbp
Paul Bone <pbone@mozilla.com> - Fri, 26 Jul 2019 12:34:52 +0000 - rev 484873
Push 113783 by shindli@mozilla.com at Fri, 26 Jul 2019 16:31:06 +0000
Bug 1568119 - Mark the test as slow so it doesn't cause timeouts r=nbp Differential Revision: https://phabricator.services.mozilla.com/D39491
2ab78a0e3a04c3aa65b8c3d1022403e5371d858a: Bug 1562437 - Call Mutex::Shutdown when the watchdog thread exits r=nbp
Paul Bone <pbone@mozilla.com> - Wed, 17 Jul 2019 10:02:12 +0000 - rev 483255
Push 113709 by csabou@mozilla.com at Thu, 18 Jul 2019 09:58:26 +0000
Bug 1562437 - Call Mutex::Shutdown when the watchdog thread exits r=nbp Differential Revision: https://phabricator.services.mozilla.com/D38265
9d4b4711856ae76154757d5fe74b5afe56e25906: Bug 1564125 - Part 3: Collapse negative and positive zero for additional operands to avoid possible bailouts. r=nbp
André Bargull <andre.bargull@gmail.com> - Tue, 09 Jul 2019 13:11:05 +0000 - rev 482379
Push 113664 by cbrindusan@mozilla.com at Thu, 11 Jul 2019 16:24:25 +0000
Bug 1564125 - Part 3: Collapse negative and positive zero for additional operands to avoid possible bailouts. r=nbp Negative zero can be treated the same way as positive zero for MInArray, MStoreTypedArrayElementHole, and MPostWriteElementBarrier. This avoids possible negative zero bailouts for these operations. Depends on D37260 Differential Revision: https://phabricator.services.mozilla.com/D37261
3e2d63c9f835f84809c1bdf7dfbe0013a4a4067b: Bug 1564125 - Part 2: Avoid negative zero bailouts for MStoreElementHole and MFallibleStoreElement. r=nbp
André Bargull <andre.bargull@gmail.com> - Tue, 09 Jul 2019 13:11:05 +0000 - rev 482378
Push 113664 by cbrindusan@mozilla.com at Thu, 11 Jul 2019 16:24:25 +0000
Bug 1564125 - Part 2: Avoid negative zero bailouts for MStoreElementHole and MFallibleStoreElement. r=nbp Use the correct index position for MStoreElementHold and MFallibleStoreElement to avoid possible negative zero bailouts for these operations. Depends on D37259 Differential Revision: https://phabricator.services.mozilla.com/D37260
b2044941257e5407aa18936f35ca1e1c21cce706: Bug 1564125 - Part 1: Don't call into the runtime for negative zero in LDoubleToString. r=nbp
André Bargull <andre.bargull@gmail.com> - Tue, 09 Jul 2019 13:11:05 +0000 - rev 482377
Push 113664 by cbrindusan@mozilla.com at Thu, 11 Jul 2019 16:24:25 +0000
Bug 1564125 - Part 1: Don't call into the runtime for negative zero in LDoubleToString. r=nbp The string representation of negative zero is equal to the one for positive zero, so there's no need to call into the runtime for that case. Differential Revision: https://phabricator.services.mozilla.com/D37259
2060e14fa20dc8ee48efdc28c041f65ed0603398: Bug 1564847 - Add js/src/octane/ to the list of thirdparty code r=nbp
Sylvestre Ledru <sledru@mozilla.com> - Wed, 10 Jul 2019 11:40:27 +0000 - rev 482148
Push 113654 by aiakab@mozilla.com at Wed, 10 Jul 2019 22:00:37 +0000
Bug 1564847 - Add js/src/octane/ to the list of thirdparty code r=nbp Differential Revision: https://phabricator.services.mozilla.com/D37542
be4f68034abd0676dd48a572722258ffba09731d: Bug 1564349 part 2 - Load browser JIT prefs only once, during startup. r=nbp
Jan de Mooij <jdemooij@mozilla.com> - Wed, 10 Jul 2019 09:43:53 +0000 - rev 482129
Push 113650 by aciure@mozilla.com at Wed, 10 Jul 2019 15:54:09 +0000
Bug 1564349 part 2 - Load browser JIT prefs only once, during startup. r=nbp Updating these process-wide prefs at runtime is racy, it was easy to get into a weird state and we bake in some of these values in JIT code. Differential Revision: https://phabricator.services.mozilla.com/D37387
4f267c2d1a7c13de18ab06beb4b224838950d889: Bug 1564349 part 1 - Convert Baseline/Ion/NativeRegExp prefs from ContextOptions to JitOptions. r=nbp,smaug
Jan de Mooij <jdemooij@mozilla.com> - Wed, 10 Jul 2019 09:43:39 +0000 - rev 482128
Push 113650 by aciure@mozilla.com at Wed, 10 Jul 2019 15:54:09 +0000
Bug 1564349 part 1 - Convert Baseline/Ion/NativeRegExp prefs from ContextOptions to JitOptions. r=nbp,smaug Using process-wide prefs is consistent with the other JIT options and is simpler to work with (one place to initialize for all runtimes). Differential Revision: https://phabricator.services.mozilla.com/D37385
5902299b20aa770a8a9d4be38d714bcb16e0a626: Bug 1556571 - Use FJCVTZS for convertDoubleToInt32. r=nbp
Sean Stangl <sean.stangl@gmail.com> - Wed, 05 Jun 2019 09:56:17 +0000 - rev 477447
Push 113340 by aiakab@mozilla.com at Wed, 05 Jun 2019 22:07:26 +0000
Bug 1556571 - Use FJCVTZS for convertDoubleToInt32. r=nbp Differential Revision: https://phabricator.services.mozilla.com/D33576
cfeedb5ec50c4cb8e4007ac4a4030bcae8eb0177: Bug 1555509 - Allow encoding FJCVTZS. r=nbp
Sean Stangl <sean.stangl@gmail.com> - Mon, 03 Jun 2019 20:49:37 +0000 - rev 476682
Push 113305 by cbrindusan@mozilla.com at Tue, 04 Jun 2019 03:54:43 +0000
Bug 1555509 - Allow encoding FJCVTZS. r=nbp Imports all VIXL machinery necessary to encode FJCVTZS. Differential Revision: https://phabricator.services.mozilla.com/D33090
53f2ffc77a62f878d0bd919dd1437debcd1f4371: Bug 1551339 - Update VIXL to recent Utils and Globals files. r=nbp
Sean Stangl <sean.stangl@gmail.com> - Thu, 23 May 2019 20:26:52 +0000 - rev 475290
Push 113198 by aciure@mozilla.com at Fri, 24 May 2019 04:03:55 +0000
Bug 1551339 - Update VIXL to recent Utils and Globals files. r=nbp This is preliminary work to allowing encoding of JSCVTFP, the instruction that exists on new AArch64 devices that greatly speeds up websites that use floating-point math. Differential Revision: https://phabricator.services.mozilla.com/D30997
cc575aa34c366538f85e98e878e8a062e3cfbb33: Bug 1551140 - Add code coverage instrumentation to Baseline Interpreter. r=nbp
Jan de Mooij <jdemooij@mozilla.com> - Wed, 15 May 2019 06:50:13 +0000 - rev 473914
Push 113116 by rgurzau@mozilla.com at Wed, 15 May 2019 16:03:00 +0000
Bug 1551140 - Add code coverage instrumentation to Baseline Interpreter. r=nbp Differential Revision: https://phabricator.services.mozilla.com/D30877
bfa4ce8a0ef6b464e349f252b1f8e46cbf9bba11: Bug 1551339 - Update VIXL to recent Utils and Globals files. r=nbp
Sean Stangl <sean.stangl@gmail.com> - Tue, 14 May 2019 16:16:20 +0000 - rev 473837
Push 113113 by rgurzau@mozilla.com at Wed, 15 May 2019 09:32:06 +0000
Bug 1551339 - Update VIXL to recent Utils and Globals files. r=nbp This is preliminary work to allowing encoding of JSCVTFP, the instruction that exists on new AArch64 devices that greatly speeds up websites that use floating-point math. Differential Revision: https://phabricator.services.mozilla.com/D30997
6fabc0c9c2cde56f6921056d3e98500f0f7a47e3: Bug 1541404 part 21 - Interpreter DebugTrapHandler changes. r=nbp
Jan de Mooij <jdemooij@mozilla.com> - Fri, 10 May 2019 09:54:04 +0000 - rev 473390
Push 113082 by dvarga@mozilla.com at Fri, 10 May 2019 21:54:38 +0000
Bug 1541404 part 21 - Interpreter DebugTrapHandler changes. r=nbp Differential Revision: https://phabricator.services.mozilla.com/D29804
dcdecf563747b29b8bd7270937d190e967b3ea50: Bug 1547179 - Remove an assertion that's no longer valid because rt->profilingScripts no longer implies IsLCovEnabled. r=nbp
Jan de Mooij <jdemooij@mozilla.com> - Fri, 03 May 2019 12:28:57 +0000 - rev 472657
Push 113032 by malexandru@mozilla.com at Mon, 06 May 2019 09:59:33 +0000
Bug 1547179 - Remove an assertion that's no longer valid because rt->profilingScripts no longer implies IsLCovEnabled. r=nbp Differential Revision: https://phabricator.services.mozilla.com/D28952
80f03c3dd739ce09d18d06c31cc857ed56307e1f: Bug 1544792 - Abort on try-catch blocks when doing definite properties analysis. r=nbp
Jan de Mooij <jdemooij@mozilla.com> - Thu, 02 May 2019 17:51:24 +0000 - rev 472460
Push 113012 by dluca@mozilla.com at Fri, 03 May 2019 13:13:31 +0000
Bug 1544792 - Abort on try-catch blocks when doing definite properties analysis. r=nbp Ion does not compile the catch block so the analysis fails to account for code there. Differential Revision: https://phabricator.services.mozilla.com/D29475
af2d798ce6b375492d44d7ed0b4060faad823bb5: Bug 1546594 - Move JitRuntime::generateDebugTrapHandler to shared code. r=nbp
Jan de Mooij <jdemooij@mozilla.com> - Thu, 02 May 2019 12:20:40 +0000 - rev 472454
Push 113012 by dluca@mozilla.com at Fri, 03 May 2019 13:13:31 +0000
Bug 1546594 - Move JitRuntime::generateDebugTrapHandler to shared code. r=nbp This trampoline isn't performance sensitive so platform-specific optimizations are not worth it. Differential Revision: https://phabricator.services.mozilla.com/D28601
1ac79bd52a1106f850bc78af12c964cba0d3af5c: Bug 1546874 - Propagate OOM status from x86 assembler buffer. r=nbp
Lars T Hansen <lhansen@mozilla.com> - Thu, 25 Apr 2019 14:49:52 +0200 - rev 471365
Push 112917 by lhansen@mozilla.com at Fri, 26 Apr 2019 06:42:39 +0000
Bug 1546874 - Propagate OOM status from x86 assembler buffer. r=nbp This copies the mechanism that was introduced for ARM into the x86 code: it uses a flag on the jitcontext, if present, to propagate the OOM flag so that we won't assert in ~Label. Differential Revision: https://phabricator.services.mozilla.com/D28829
24740ab9a7266f84283b2beeebe665edf903f09f: Bug 1546934 - Change LCov code coverage machinery to use a process-wide flag. r=nbp
Jan de Mooij <jdemooij@mozilla.com> - Thu, 25 Apr 2019 13:35:55 +0000 - rev 471332
Push 112913 by opoprus@mozilla.com at Thu, 25 Apr 2019 22:21:16 +0000
Bug 1546934 - Change LCov code coverage machinery to use a process-wide flag. r=nbp This will simplify the Baseline Interpreter work. Differential Revision: https://phabricator.services.mozilla.com/D28813
f14763229806d9678164e11659cd79674adf9816: Bug 1538083 - Fix -0 handling in ARM64 visitTrunc(). r=nbp
Sean Stangl <sean.stangl@gmail.com> - Thu, 11 Apr 2019 22:34:46 +0000 - rev 469151
Push 112769 by csabou@mozilla.com at Fri, 12 Apr 2019 03:51:12 +0000
Bug 1538083 - Fix -0 handling in ARM64 visitTrunc(). r=nbp The existing truncation code did not correctly handle the case of negative zero. The fix is to avoid using FCMP floating-point comparisons, and check the sign bit explicitly in a GPR. Differential Revision: https://phabricator.services.mozilla.com/D26381
c15b9e3615f7f19caeb490599192eb373f9d6480: Bug 1543230 - Move JSScript::warmUpResetCount into MutableFlags r=nbp
Ted Campbell <tcampbell@mozilla.com> - Wed, 10 Apr 2019 16:12:37 +0000 - rev 468842
Push 112758 by dvarga@mozilla.com at Thu, 11 Apr 2019 04:29:43 +0000
Bug 1543230 - Move JSScript::warmUpResetCount into MutableFlags r=nbp This data is only needed for testing but is currently messing with the structure packing. This reduces the size of the field and packs it into free space saving one word per script on certain platforms. Differential Revision: https://phabricator.services.mozilla.com/D26801
d0e8c583c0fe3c7059cfa0bc00481f2140220bbf: Bug 1540771 - LIR.cpp: Remove nested redundant #ifdef r=nbp
Anthony Aillerie <a1.aillerie@gmail.com> - Wed, 03 Apr 2019 09:35:19 +0000 - rev 467788
Push 112658 by aciure@mozilla.com at Thu, 04 Apr 2019 04:41:45 +0000
Bug 1540771 - LIR.cpp: Remove nested redundant #ifdef r=nbp Remove nested redundant #ifdef Differential Revision: https://phabricator.services.mozilla.com/D25807
3134740d831cc24b5b931a8512584100fcc10471: Bug 1382650 part 8 - Add a JitOption to disable use of Ion optimization levels. r=nbp
Jan de Mooij <jdemooij@mozilla.com> - Tue, 02 Apr 2019 12:34:09 +0000 - rev 467753
Push 112658 by aciure@mozilla.com at Thu, 04 Apr 2019 04:41:45 +0000
Bug 1382650 part 8 - Add a JitOption to disable use of Ion optimization levels. r=nbp We might uplift these patches to beta. Having a JitOption makes it easier to turn this off if needed. Differential Revision: https://phabricator.services.mozilla.com/D25754
192b326a74a5c28fdc24231e62e4e92ebd579370: Bug 1533295 - Ignore basic/testTypedArrayInit.js in ARM64 Simulator. r=nbp
Sean Stangl <sean.stangl@gmail.com> - Fri, 29 Mar 2019 16:06:03 +0000 - rev 466969
Push 112610 by nbeleuzu@mozilla.com at Sat, 30 Mar 2019 21:47:41 +0000
Bug 1533295 - Ignore basic/testTypedArrayInit.js in ARM64 Simulator. r=nbp The ARM64 Simulator can take upwards of 6 minutes to execute this test, causing intermittent timeouts. Differential Revision: https://phabricator.services.mozilla.com/D25391
27b59f0c66307dfd885e26112e351fa72b60d838: Bug 1512491 - Part 2: Hoist access to MConstantElements. r=nbp
André Bargull <andre.bargull@gmail.com> - Mon, 25 Mar 2019 17:55:37 +0000 - rev 466617
Push 112592 by ncsoregi@mozilla.com at Fri, 29 Mar 2019 05:30:21 +0000
Bug 1512491 - Part 2: Hoist access to MConstantElements. r=nbp Depends on D24351 Differential Revision: https://phabricator.services.mozilla.com/D24352
07d5d42519f300922af72eed02cb3e0d0b707739: Bug 1512491 - Part 1: Hoist bound checks with constants. r=nbp,jandem
André Bargull <andre.bargull@gmail.com> - Thu, 28 Mar 2019 08:30:26 +0000 - rev 466616
Push 112592 by ncsoregi@mozilla.com at Fri, 29 Mar 2019 05:30:21 +0000
Bug 1512491 - Part 1: Hoist bound checks with constants. r=nbp,jandem Differential Revision: https://phabricator.services.mozilla.com/D24351