searching for reviewer(nbp)
5902299b20aa770a8a9d4be38d714bcb16e0a626: Bug 1556571 - Use FJCVTZS for convertDoubleToInt32. r=nbp
Sean Stangl <sean.stangl@gmail.com> - Wed, 05 Jun 2019 09:56:17 +0000 - rev 477447
Push 113340 by aiakab@mozilla.com at Wed, 05 Jun 2019 22:07:26 +0000
Bug 1556571 - Use FJCVTZS for convertDoubleToInt32. r=nbp Differential Revision: https://phabricator.services.mozilla.com/D33576
cfeedb5ec50c4cb8e4007ac4a4030bcae8eb0177: Bug 1555509 - Allow encoding FJCVTZS. r=nbp
Sean Stangl <sean.stangl@gmail.com> - Mon, 03 Jun 2019 20:49:37 +0000 - rev 476682
Push 113305 by cbrindusan@mozilla.com at Tue, 04 Jun 2019 03:54:43 +0000
Bug 1555509 - Allow encoding FJCVTZS. r=nbp Imports all VIXL machinery necessary to encode FJCVTZS. Differential Revision: https://phabricator.services.mozilla.com/D33090
53f2ffc77a62f878d0bd919dd1437debcd1f4371: Bug 1551339 - Update VIXL to recent Utils and Globals files. r=nbp
Sean Stangl <sean.stangl@gmail.com> - Thu, 23 May 2019 20:26:52 +0000 - rev 475290
Push 113198 by aciure@mozilla.com at Fri, 24 May 2019 04:03:55 +0000
Bug 1551339 - Update VIXL to recent Utils and Globals files. r=nbp This is preliminary work to allowing encoding of JSCVTFP, the instruction that exists on new AArch64 devices that greatly speeds up websites that use floating-point math. Differential Revision: https://phabricator.services.mozilla.com/D30997
cc575aa34c366538f85e98e878e8a062e3cfbb33: Bug 1551140 - Add code coverage instrumentation to Baseline Interpreter. r=nbp
Jan de Mooij <jdemooij@mozilla.com> - Wed, 15 May 2019 06:50:13 +0000 - rev 473914
Push 113116 by rgurzau@mozilla.com at Wed, 15 May 2019 16:03:00 +0000
Bug 1551140 - Add code coverage instrumentation to Baseline Interpreter. r=nbp Differential Revision: https://phabricator.services.mozilla.com/D30877
bfa4ce8a0ef6b464e349f252b1f8e46cbf9bba11: Bug 1551339 - Update VIXL to recent Utils and Globals files. r=nbp
Sean Stangl <sean.stangl@gmail.com> - Tue, 14 May 2019 16:16:20 +0000 - rev 473837
Push 113113 by rgurzau@mozilla.com at Wed, 15 May 2019 09:32:06 +0000
Bug 1551339 - Update VIXL to recent Utils and Globals files. r=nbp This is preliminary work to allowing encoding of JSCVTFP, the instruction that exists on new AArch64 devices that greatly speeds up websites that use floating-point math. Differential Revision: https://phabricator.services.mozilla.com/D30997
6fabc0c9c2cde56f6921056d3e98500f0f7a47e3: Bug 1541404 part 21 - Interpreter DebugTrapHandler changes. r=nbp
Jan de Mooij <jdemooij@mozilla.com> - Fri, 10 May 2019 09:54:04 +0000 - rev 473390
Push 113082 by dvarga@mozilla.com at Fri, 10 May 2019 21:54:38 +0000
Bug 1541404 part 21 - Interpreter DebugTrapHandler changes. r=nbp Differential Revision: https://phabricator.services.mozilla.com/D29804
dcdecf563747b29b8bd7270937d190e967b3ea50: Bug 1547179 - Remove an assertion that's no longer valid because rt->profilingScripts no longer implies IsLCovEnabled. r=nbp
Jan de Mooij <jdemooij@mozilla.com> - Fri, 03 May 2019 12:28:57 +0000 - rev 472657
Push 113032 by malexandru@mozilla.com at Mon, 06 May 2019 09:59:33 +0000
Bug 1547179 - Remove an assertion that's no longer valid because rt->profilingScripts no longer implies IsLCovEnabled. r=nbp Differential Revision: https://phabricator.services.mozilla.com/D28952
80f03c3dd739ce09d18d06c31cc857ed56307e1f: Bug 1544792 - Abort on try-catch blocks when doing definite properties analysis. r=nbp
Jan de Mooij <jdemooij@mozilla.com> - Thu, 02 May 2019 17:51:24 +0000 - rev 472460
Push 113012 by dluca@mozilla.com at Fri, 03 May 2019 13:13:31 +0000
Bug 1544792 - Abort on try-catch blocks when doing definite properties analysis. r=nbp Ion does not compile the catch block so the analysis fails to account for code there. Differential Revision: https://phabricator.services.mozilla.com/D29475
af2d798ce6b375492d44d7ed0b4060faad823bb5: Bug 1546594 - Move JitRuntime::generateDebugTrapHandler to shared code. r=nbp
Jan de Mooij <jdemooij@mozilla.com> - Thu, 02 May 2019 12:20:40 +0000 - rev 472454
Push 113012 by dluca@mozilla.com at Fri, 03 May 2019 13:13:31 +0000
Bug 1546594 - Move JitRuntime::generateDebugTrapHandler to shared code. r=nbp This trampoline isn't performance sensitive so platform-specific optimizations are not worth it. Differential Revision: https://phabricator.services.mozilla.com/D28601
1ac79bd52a1106f850bc78af12c964cba0d3af5c: Bug 1546874 - Propagate OOM status from x86 assembler buffer. r=nbp
Lars T Hansen <lhansen@mozilla.com> - Thu, 25 Apr 2019 14:49:52 +0200 - rev 471365
Push 112917 by lhansen@mozilla.com at Fri, 26 Apr 2019 06:42:39 +0000
Bug 1546874 - Propagate OOM status from x86 assembler buffer. r=nbp This copies the mechanism that was introduced for ARM into the x86 code: it uses a flag on the jitcontext, if present, to propagate the OOM flag so that we won't assert in ~Label. Differential Revision: https://phabricator.services.mozilla.com/D28829
24740ab9a7266f84283b2beeebe665edf903f09f: Bug 1546934 - Change LCov code coverage machinery to use a process-wide flag. r=nbp
Jan de Mooij <jdemooij@mozilla.com> - Thu, 25 Apr 2019 13:35:55 +0000 - rev 471332
Push 112913 by opoprus@mozilla.com at Thu, 25 Apr 2019 22:21:16 +0000
Bug 1546934 - Change LCov code coverage machinery to use a process-wide flag. r=nbp This will simplify the Baseline Interpreter work. Differential Revision: https://phabricator.services.mozilla.com/D28813
f14763229806d9678164e11659cd79674adf9816: Bug 1538083 - Fix -0 handling in ARM64 visitTrunc(). r=nbp
Sean Stangl <sean.stangl@gmail.com> - Thu, 11 Apr 2019 22:34:46 +0000 - rev 469151
Push 112769 by csabou@mozilla.com at Fri, 12 Apr 2019 03:51:12 +0000
Bug 1538083 - Fix -0 handling in ARM64 visitTrunc(). r=nbp The existing truncation code did not correctly handle the case of negative zero. The fix is to avoid using FCMP floating-point comparisons, and check the sign bit explicitly in a GPR. Differential Revision: https://phabricator.services.mozilla.com/D26381
c15b9e3615f7f19caeb490599192eb373f9d6480: Bug 1543230 - Move JSScript::warmUpResetCount into MutableFlags r=nbp
Ted Campbell <tcampbell@mozilla.com> - Wed, 10 Apr 2019 16:12:37 +0000 - rev 468842
Push 112758 by dvarga@mozilla.com at Thu, 11 Apr 2019 04:29:43 +0000
Bug 1543230 - Move JSScript::warmUpResetCount into MutableFlags r=nbp This data is only needed for testing but is currently messing with the structure packing. This reduces the size of the field and packs it into free space saving one word per script on certain platforms. Differential Revision: https://phabricator.services.mozilla.com/D26801
d0e8c583c0fe3c7059cfa0bc00481f2140220bbf: Bug 1540771 - LIR.cpp: Remove nested redundant #ifdef r=nbp
Anthony Aillerie <a1.aillerie@gmail.com> - Wed, 03 Apr 2019 09:35:19 +0000 - rev 467788
Push 112658 by aciure@mozilla.com at Thu, 04 Apr 2019 04:41:45 +0000
Bug 1540771 - LIR.cpp: Remove nested redundant #ifdef r=nbp Remove nested redundant #ifdef Differential Revision: https://phabricator.services.mozilla.com/D25807
3134740d831cc24b5b931a8512584100fcc10471: Bug 1382650 part 8 - Add a JitOption to disable use of Ion optimization levels. r=nbp
Jan de Mooij <jdemooij@mozilla.com> - Tue, 02 Apr 2019 12:34:09 +0000 - rev 467753
Push 112658 by aciure@mozilla.com at Thu, 04 Apr 2019 04:41:45 +0000
Bug 1382650 part 8 - Add a JitOption to disable use of Ion optimization levels. r=nbp We might uplift these patches to beta. Having a JitOption makes it easier to turn this off if needed. Differential Revision: https://phabricator.services.mozilla.com/D25754
192b326a74a5c28fdc24231e62e4e92ebd579370: Bug 1533295 - Ignore basic/testTypedArrayInit.js in ARM64 Simulator. r=nbp
Sean Stangl <sean.stangl@gmail.com> - Fri, 29 Mar 2019 16:06:03 +0000 - rev 466969
Push 112610 by nbeleuzu@mozilla.com at Sat, 30 Mar 2019 21:47:41 +0000
Bug 1533295 - Ignore basic/testTypedArrayInit.js in ARM64 Simulator. r=nbp The ARM64 Simulator can take upwards of 6 minutes to execute this test, causing intermittent timeouts. Differential Revision: https://phabricator.services.mozilla.com/D25391
27b59f0c66307dfd885e26112e351fa72b60d838: Bug 1512491 - Part 2: Hoist access to MConstantElements. r=nbp
André Bargull <andre.bargull@gmail.com> - Mon, 25 Mar 2019 17:55:37 +0000 - rev 466617
Push 112592 by ncsoregi@mozilla.com at Fri, 29 Mar 2019 05:30:21 +0000
Bug 1512491 - Part 2: Hoist access to MConstantElements. r=nbp Depends on D24351 Differential Revision: https://phabricator.services.mozilla.com/D24352
07d5d42519f300922af72eed02cb3e0d0b707739: Bug 1512491 - Part 1: Hoist bound checks with constants. r=nbp,jandem
André Bargull <andre.bargull@gmail.com> - Thu, 28 Mar 2019 08:30:26 +0000 - rev 466616
Push 112592 by ncsoregi@mozilla.com at Fri, 29 Mar 2019 05:30:21 +0000
Bug 1512491 - Part 1: Hoist bound checks with constants. r=nbp,jandem Differential Revision: https://phabricator.services.mozilla.com/D24351
391cc6344efe5a7422fed6a057c2527e36b5b74e: Bug 1382650 part 7 - Use a separate Ion optimization level for very hot code. r=nbp
Jan de Mooij <jdemooij@mozilla.com> - Thu, 28 Mar 2019 07:35:40 +0000 - rev 466553
Push 112588 by opoprus@mozilla.com at Thu, 28 Mar 2019 17:43:48 +0000
Bug 1382650 part 7 - Use a separate Ion optimization level for very hot code. r=nbp Ion can do aggressive inlining, but inlining a lot of code has a negative effect on compilation time and memory usage. It also means we spend more time in the slower Baseline code while compiling the Ion code off-thread or after an invalidation. To address this, Ion now consists of two tiers: * Normal: the first tier (warm-up threshold of 1,000) only inlines small functions one level deep. This tier also has recompile checks to recompile the script when it becomes very hot. * Full: the second tier (warm-up threshold of 100,000) is only used for very hot code so we can afford inlining a lot more code. This improves Speedometer and GDocs by more than 5%. Differential Revision: https://phabricator.services.mozilla.com/D24159
6960595971e59ed7c59ea4e77134f66ae1aeac57: Bug 1382650 part 6 - Fix ARM64 implementation of branch32(AbsoluteAddress, Imm32). r=nbp
Jan de Mooij <jdemooij@mozilla.com> - Wed, 27 Mar 2019 18:58:27 +0000 - rev 466442
Push 112585 by opoprus@mozilla.com at Thu, 28 Mar 2019 10:26:17 +0000
Bug 1382650 part 6 - Fix ARM64 implementation of branch32(AbsoluteAddress, Imm32). r=nbp The old code would assert because we needed too many scratch registers, but it was dead code until this patch. Differential Revision: https://phabricator.services.mozilla.com/D24158
0614a9178eeff65e032b6729df6e2f61562a9dc7: Bug 1382650 part 5 - Calculate OSR warm-up threshold difference based on the warm-up threshold instead of hard-coding 100. r=nbp
Jan de Mooij <jdemooij@mozilla.com> - Wed, 27 Mar 2019 18:58:13 +0000 - rev 466441
Push 112585 by opoprus@mozilla.com at Thu, 28 Mar 2019 10:26:17 +0000
Bug 1382650 part 5 - Calculate OSR warm-up threshold difference based on the warm-up threshold instead of hard-coding 100. r=nbp We want this to be more than 100 for the full-optimizations tier. Making this relative also works better for tests that set a small Ion warm-up threshold. Also disables OSR in some tests depending on the old behavior. Differential Revision: https://phabricator.services.mozilla.com/D24157
a812f6daf98e1bb1b746dd8b56e5067c54c37738: Bug 1382650 part 4 - Split Ion warmup threshold JitOption in 'normal' and 'full' options. r=nbp
Jan de Mooij <jdemooij@mozilla.com> - Wed, 27 Mar 2019 18:57:58 +0000 - rev 466440
Push 112585 by opoprus@mozilla.com at Thu, 28 Mar 2019 10:26:17 +0000
Bug 1382650 part 4 - Split Ion warmup threshold JitOption in 'normal' and 'full' options. r=nbp Also adds a javascript.options.ion.full.threshold browser pref and similar shell flags. This doesn't rename the existing prefs yet. Differential Revision: https://phabricator.services.mozilla.com/D24156
7ee65d07d83f59534a1b0e797a489bc706d9051c: Bug 1382650 part 3 - Clean up Ion eager compilation code. r=nbp
Jan de Mooij <jdemooij@mozilla.com> - Wed, 27 Mar 2019 12:18:59 +0000 - rev 466340
Push 112577 by aciure@mozilla.com at Wed, 27 Mar 2019 16:44:02 +0000
Bug 1382650 part 3 - Clean up Ion eager compilation code. r=nbp There's a lot of complexity around setting/unsetting the eagerCompilation flag. It's simpler to determine this based on the warm-up threshold being 0. The patch also fixes some jit-tests where this patch would result in a change in behavior. Differential Revision: https://phabricator.services.mozilla.com/D24155
30247ab616790977118ebdc0dfd4e6b706f3ea69: Bug 1382650 part 2 - Store Ion warmup threshold only in JitOptions. r=nbp
Jan de Mooij <jdemooij@mozilla.com> - Wed, 27 Mar 2019 12:30:10 +0000 - rev 466339
Push 112577 by aciure@mozilla.com at Wed, 27 Mar 2019 16:44:02 +0000
Bug 1382650 part 2 - Store Ion warmup threshold only in JitOptions. r=nbp Storing this also in IonOptimizationLevels.h/cpp is more complicated than necessary. Differential Revision: https://phabricator.services.mozilla.com/D24154
ca8d272b176f9d3d5a2b65a0b86a86696c61c42d: Bug 1382650 part 1 - Remove separate Ion warmup threshold for small functions, as it's equivalent to the normal one. r=nbp
Jan de Mooij <jdemooij@mozilla.com> - Wed, 27 Mar 2019 12:18:22 +0000 - rev 466338
Push 112577 by aciure@mozilla.com at Wed, 27 Mar 2019 16:44:02 +0000
Bug 1382650 part 1 - Remove separate Ion warmup threshold for small functions, as it's equivalent to the normal one. r=nbp We used to have a different threshold for small functions but now they're both set to 1000 so there's no need to special-case small functions. Differential Revision: https://phabricator.services.mozilla.com/D24153
78d7e3aaf5042c3d33aaa5540357645eb3afb914: Bug 1538094 - Remove misleading TODO comments. r=nbp
Lars T Hansen <lhansen@mozilla.com> - Tue, 26 Mar 2019 09:02:47 +0100 - rev 466059
Push 112552 by lhansen@mozilla.com at Tue, 26 Mar 2019 12:54:29 +0000
Bug 1538094 - Remove misleading TODO comments. r=nbp Differential Revision: https://phabricator.services.mozilla.com/D24862
cb26ae90e781cdde29cfb88303d38157c3f68d7d: Bug 1538191 - Remove stale comments. r=nbp
Lars T Hansen <lhansen@mozilla.com> - Fri, 22 Mar 2019 15:11:52 +0100 - rev 465970
Push 112548 by lhansen@mozilla.com at Tue, 26 Mar 2019 08:01:28 +0000
Bug 1538191 - Remove stale comments. r=nbp Differential Revision: https://phabricator.services.mozilla.com/D24505
ddd7029e48269e23a061cf6c559c6ea97a893f4f: Bug 1537733 - Use halt instructions for haltingAlign. r=nbp
Lars T Hansen <lhansen@mozilla.com> - Thu, 21 Mar 2019 13:06:47 +0100 - rev 465969
Push 112548 by lhansen@mozilla.com at Tue, 26 Mar 2019 08:01:28 +0000
Bug 1537733 - Use halt instructions for haltingAlign. r=nbp Differential Revision: https://phabricator.services.mozilla.com/D24334
ef947b198f2c861b13b13b66f5b4095c43b4acb8: Bug 1505574 - Remove Unboxed Objects in ScalarReplacement r=nbp
Matthew Gaudet <mgaudet@mozilla.com> - Fri, 22 Mar 2019 15:31:33 +0000 - rev 465722
Push 112523 by shindli@mozilla.com at Sat, 23 Mar 2019 09:54:29 +0000
Bug 1505574 - Remove Unboxed Objects in ScalarReplacement r=nbp A note about the Scalar Replacement Changes: The M{Load,Store}Unboxed* instructions in theory could be used to manipulate and analyze typed arrays. However, according to nbp TypedArrays should already be excluded from elibility because of the potential for cross-thread sharing in a SharedArrayBuffer world, and so the only support in Scalar Replacement here is for Unboxed Objects, and so it can all be removed. Differential Revision: https://phabricator.services.mozilla.com/D24038
ebf98069b0fbc60e1cfa79ce97f4266c66860bcd: Bug 1536220 - Enable IonMonkey on ARM64 in-browser. r=nbp
Sean Stangl <sean.stangl@gmail.com> - Tue, 19 Mar 2019 15:26:43 +0000 - rev 465050
Push 112488 by rmaries@mozilla.com at Tue, 19 Mar 2019 22:11:19 +0000
Bug 1536220 - Enable IonMonkey on ARM64 in-browser. r=nbp Enable IonMonkey on ARM64 in-browser. Differential Revision: https://phabricator.services.mozilla.com/D23929
c13b55d67ea264ba37de9c52375597e2c73cb164: Bug 1535848 - Define JumpImmediateRange on ARM64. r=nbp
Lars T Hansen <lhansen@mozilla.com> - Mon, 18 Mar 2019 17:52:49 +0100 - rev 464788
Push 112484 by lhansen@mozilla.com at Tue, 19 Mar 2019 08:09:12 +0000
Bug 1535848 - Define JumpImmediateRange on ARM64. r=nbp There are comments in the code suggesting that we've made plans at some point to handle very far jumps via patching + indirect jumps, but all of those comments are TODO/FIXME. Absent such a strategy, the furthest jump is 2^27-1 bytes, and we need to define JumpImmediateRange to reflect that. Differential Revision: https://phabricator.services.mozilla.com/D23883
3aa21d7302e79b1e9324ea4933c719f200de2ab1: Bug 1530937 part 17 - Remove now unused VMFunction code. r=nbp
Jan de Mooij <jdemooij@mozilla.com> - Tue, 12 Mar 2019 14:47:50 +0000 - rev 463679
Push 112406 by nbeleuzu@mozilla.com at Tue, 12 Mar 2019 21:48:50 +0000
Bug 1530937 part 17 - Remove now unused VMFunction code. r=nbp Differential Revision: https://phabricator.services.mozilla.com/D23137
7b85bf9c5210e5679fa6cfad92466a6e2ba30232: Bug 1533969 - Fix build error with newer glibc. r=nbp
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 11 Mar 2019 19:28:37 +0000 - rev 463533
Push 112400 by btara@mozilla.com at Tue, 12 Mar 2019 10:04:06 +0000
Bug 1533969 - Fix build error with newer glibc. r=nbp New glibc versions provide a wrapper for gettid, which means that our stuff fails to build with: ``` /home/emilio/src/moz/gecko/js/src/util/NativeStack.cpp:28:14: error: static declaration of 'gettid' follows non-static declaration static pid_t gettid() { return syscall(__NR_gettid); } ^ /usr/include/bits/unistd_ext.h:34:16: note: previous declaration is here extern __pid_t gettid (void) __THROW; ``` Differential Revision: https://phabricator.services.mozilla.com/D22829
16b947cb279ad6a8b3232d6ca78405211e66828e: Bug 1530937 part 13 - Convert Ion oolCallVMs and remove old CodeGenerator callVM overload. r=nbp
Jan de Mooij <jdemooij@mozilla.com> - Mon, 11 Mar 2019 13:30:29 +0000 - rev 463520
Push 112400 by btara@mozilla.com at Tue, 12 Mar 2019 10:04:06 +0000
Bug 1530937 part 13 - Convert Ion oolCallVMs and remove old CodeGenerator callVM overload. r=nbp Differential Revision: https://phabricator.services.mozilla.com/D22946
5734a9a9153133cd366f75742cc958ce205a8b5d: Bug 1530937 part 10 - Convert more callVMs in CodeGenerator.cpp. r=nbp
Jan de Mooij <jdemooij@mozilla.com> - Thu, 07 Mar 2019 17:49:04 +0000 - rev 463224
Push 112369 by btara@mozilla.com at Fri, 08 Mar 2019 21:57:38 +0000
Bug 1530937 part 10 - Convert more callVMs in CodeGenerator.cpp. r=nbp Differential Revision: https://phabricator.services.mozilla.com/D22523
afb2e1e1665f03d83fd217cd953b4759ca3747cb: Bug 1528869 - Enable IonMonkey in the ARM64 shell, but keep it disabled in the browser. r=nbp
Sean Stangl <sean.stangl@gmail.com> - Thu, 07 Mar 2019 03:57:23 +0000 - rev 462816
Push 112329 by apavel@mozilla.com at Thu, 07 Mar 2019 10:01:39 +0000
Bug 1528869 - Enable IonMonkey in the ARM64 shell, but keep it disabled in the browser. r=nbp Enable IonMonkey in the ARM64 shell, but keep it disabled in the browser. Differential Revision: https://phabricator.services.mozilla.com/D20243
73efd5f3bfff6227a6a37da9f9a4aa3ab7e126cf: Bug 1530937 part 8 - Convert some Ion callVMs that already exist in VMFunctionList-inl.h. r=nbp
Jan de Mooij <jdemooij@mozilla.com> - Wed, 06 Mar 2019 15:56:21 +0000 - rev 462666
Push 112326 by ccoroiu@mozilla.com at Thu, 07 Mar 2019 04:41:19 +0000
Bug 1530937 part 8 - Convert some Ion callVMs that already exist in VMFunctionList-inl.h. r=nbp Depends on D22278 Differential Revision: https://phabricator.services.mozilla.com/D22279
529da09b7f7e2165081e4a885e056bb2f974c1df: Bug 1530937 part 7 - Move callVM and oolCallVM methods from CodeGeneratorShared to CodeGenerator. r=nbp
Jan de Mooij <jdemooij@mozilla.com> - Wed, 06 Mar 2019 15:56:21 +0000 - rev 462665
Push 112326 by ccoroiu@mozilla.com at Thu, 07 Mar 2019 04:41:19 +0000
Bug 1530937 part 7 - Move callVM and oolCallVM methods from CodeGeneratorShared to CodeGenerator. r=nbp They're only used in CodeGenerator.cpp so we can now move some of the helper classes and templates from the header file to the cpp file. Differential Revision: https://phabricator.services.mozilla.com/D22278
b2fb7cd41c796eabae8e4310aa34ea23ef858714: Bug 1528869 - Enable IonMonkey in the ARM64 shell, but keep it disabled in the browser. r=nbp
Sean Stangl <sean.stangl@gmail.com> - Wed, 06 Mar 2019 04:40:51 +0000 - rev 462553
Push 112315 by ncsoregi@mozilla.com at Wed, 06 Mar 2019 16:18:23 +0000
Bug 1528869 - Enable IonMonkey in the ARM64 shell, but keep it disabled in the browser. r=nbp Enable IonMonkey in the ARM64 shell, but keep it disabled in the browser. Differential Revision: https://phabricator.services.mozilla.com/D20243
af0ecb4e1e695590b0dcd96cae7afa631912c046: Bug 1529034 - Just punt on auto-regress/bug1263857.js. r=nbp
Sean Stangl <sean.stangl@gmail.com> - Tue, 05 Mar 2019 14:41:40 +0000 - rev 462383
Push 112300 by shindli@mozilla.com at Tue, 05 Mar 2019 21:48:58 +0000
Bug 1529034 - Just punt on auto-regress/bug1263857.js. r=nbp Disable auto-regress/bug1263857.js, leaving it for follow-up work. Differential Revision: https://phabricator.services.mozilla.com/D22047
4e8b8c1e0d19cf0c5bba05fd3df46254d5d68ab9: Bug 1530937 part 6 - Convert remaining callVMs in BaselineCompiler.cpp. r=nbp
Jan de Mooij <jdemooij@mozilla.com> - Tue, 05 Mar 2019 13:47:36 +0000 - rev 462376
Push 112300 by shindli@mozilla.com at Tue, 05 Mar 2019 21:48:58 +0000
Bug 1530937 part 6 - Convert remaining callVMs in BaselineCompiler.cpp. r=nbp Also removes the old callVM overload so new code in BaselineCompiler must use the new mechanism. Differential Revision: https://phabricator.services.mozilla.com/D22059
a70132c4c444ca959970fbc9bd6674d04c9586e4: Bug 1530937 part 5 - Convert more callVMs in BaselineCompiler. r=nbp
Jan de Mooij <jdemooij@mozilla.com> - Tue, 05 Mar 2019 11:22:46 +0000 - rev 462375
Push 112300 by shindli@mozilla.com at Tue, 05 Mar 2019 21:48:58 +0000
Bug 1530937 part 5 - Convert more callVMs in BaselineCompiler. r=nbp We had multiple overloads for js::Throw so I renamed the one we call here for JSOP_THROW to js::ThrowOperation. Differential Revision: https://phabricator.services.mozilla.com/D22058
77b7364aabec18d52b6f520c14ef4ec21c614600: Bug 1530937 part 4 - Move pointer to C++ function out of VMFunctionData. r=nbp
Jan de Mooij <jdemooij@mozilla.com> - Mon, 04 Mar 2019 14:40:45 +0000 - rev 462238
Push 112282 by aciure@mozilla.com at Mon, 04 Mar 2019 21:54:47 +0000
Bug 1530937 part 4 - Move pointer to C++ function out of VMFunctionData. r=nbp GCC 8.2/8.3 doesn't like the (void*) trick in (some) constexpr contexts because it treats it like a reinterpret_cast (which isn't allowed in constexpr). This patch moves the function pointers into a separate const array so that VMFunctionData can stay constexpr and relies on compilers being smart enough to treat the function-pointer-array as constexpr. Differential Revision: https://phabricator.services.mozilla.com/D21922
673976e3f52e343996b2d4da4e2988bb2f6c5e82: Bug 1529400 - Summary: Disable ARM64 atomics tests in-simulator: the simulator lacks atomics emulation. r=nbp
Sean Stangl <sean.stangl@gmail.com> - Thu, 28 Feb 2019 14:45:20 +0000 - rev 461808
Push 112229 by rgurzau@mozilla.com at Fri, 01 Mar 2019 07:31:26 +0000
Bug 1529400 - Summary: Disable ARM64 atomics tests in-simulator: the simulator lacks atomics emulation. r=nbp Differential Revision: https://phabricator.services.mozilla.com/D20576
756272e36e32264332e6b95aa804b69581295c7e: Bug 1530937 part 2 - Add new VMFunction mechanism and use it for some Baseline callVMs. r=nbp,tcampbell
Jan de Mooij <jdemooij@mozilla.com> - Thu, 28 Feb 2019 12:31:01 +0000 - rev 461746
Push 112218 by opoprus@mozilla.com at Thu, 28 Feb 2019 22:09:07 +0000
Bug 1530937 part 2 - Add new VMFunction mechanism and use it for some Baseline callVMs. r=nbp,tcampbell We are doing this to: 1) Eliminate (hundreds of) static constructors. These account for a significant fraction of all remaining static constructors in Gecko. 2) Use constexpr for VMFunction data. This was not possible with the linked list but the new design stores all data in a constexpr array. This will save a few KB per process. 3) Make it easier to define a new VMFunction. 4) Coalesce duplicate VMFunction copies in Baseline/Ion/ICs. 5) Get rid of the (read-only) HashMap for the VMFunction => code lookup. We can use a Vector instead. 6) Make it easier in the future to generate the wrappers at compile time. This patch will let us incrementally convert the remaining VM functions. The only thing not handled by this patch is support for the TailCall and extraValuesToPop fields. We can do this when we convert the Baseline IC code that uses these fields. Once all VM functions have been converted we can remove and simplify more code. Differential Revision: https://phabricator.services.mozilla.com/D21332
d629f7abeca07b44babffed909a38120fe24aceb: Bug 1530937 part 1 - Remove FunctionInfo Context template parameter. r=nbp
Jan de Mooij <jdemooij@mozilla.com> - Thu, 28 Feb 2019 09:37:36 +0000 - rev 461745
Push 112218 by opoprus@mozilla.com at Thu, 28 Feb 2019 22:09:07 +0000
Bug 1530937 part 1 - Remove FunctionInfo Context template parameter. r=nbp This was useful when we had ExclusiveContext and PJS ThreadSafeContext but now we only use JSContext* so it's simpler to just use that. Differential Revision: https://phabricator.services.mozilla.com/D21331
5580674b0d5fb1fe26d9d47b56f49e8e28635804: Bug 1530031 - Summary: Allow ARM64 Simulator to return a different error message. r=nbp
Sean Stangl <sean.stangl@gmail.com> - Wed, 27 Feb 2019 10:52:42 +0000 - rev 461592
Push 112205 by csabou@mozilla.com at Thu, 28 Feb 2019 11:44:16 +0000
Bug 1530031 - Summary: Allow ARM64 Simulator to return a different error message. r=nbp Differential Revision: https://phabricator.services.mozilla.com/D21288
1d7d1c75a9a561b3356f0ad8183f6d6759728200: Bug 1530484: Rewrite DeadIfUnused to clarify conditions r=nbp
Matthew Gaudet <mgaudet@mozilla.com> - Tue, 26 Feb 2019 20:26:58 +0000 - rev 461366
Push 112174 by ncsoregi@mozilla.com at Wed, 27 Feb 2019 04:40:22 +0000
Bug 1530484: Rewrite DeadIfUnused to clarify conditions r=nbp Differential Revision: https://phabricator.services.mozilla.com/D21057
9fe57a98497d82eaf129fe52c2759b7b9faa5c5b: Bug 1516644 - MBasicBlock::MBasicBlock: guard lineno_ and columnIndex_ initialisations correctly. r=nbp.
Julian Seward <jseward@acm.org> - Mon, 25 Feb 2019 17:29:01 +0100 - rev 460895
Push 112133 by csabou@mozilla.com at Mon, 25 Feb 2019 20:52:02 +0000
Bug 1516644 - MBasicBlock::MBasicBlock: guard lineno_ and columnIndex_ initialisations correctly. r=nbp.
4d9aebc3fabb38f3f19609143e2614bef8828433: Bug 1516644 - MBasicBlock::MBasicBlock: guard lineno_ and columnIndex_ initialisations correctly. r=nbp.
Julian Seward <jseward@acm.org> - Mon, 25 Feb 2019 17:29:01 +0100 - rev 460893
Push 112131 by jseward@mozilla.com at Mon, 25 Feb 2019 20:10:25 +0000
Bug 1516644 - MBasicBlock::MBasicBlock: guard lineno_ and columnIndex_ initialisations correctly. r=nbp.