searching for reviewer(mento)
a1162349b49cb3a0107ae6ea07164fc9e94b7cc1: bug 1283916 - Fix DWARF handling of inlined functions in namespaces. r=mento
Ted Mielczarek <ted@mielczarek.org> - Wed, 06 Jul 2016 09:36:35 -0400 - rev 303783
Push 79181 by tmielczarek@mozilla.com at Wed, 06 Jul 2016 13:37:16 +0000
bug 1283916 - Fix DWARF handling of inlined functions in namespaces. r=mento Currently an inlined function in a namespace in DWARF will be given a name comprised of just `namespace::`. This is due to a logic error in ComputeQualifiedName, where it doesn't handle an empty `unqualified_name` properly. We apparently have a fair number of these in our Mac builds, an example of the DWARF that's being mishandled looks like: 0x117eda40: TAG_namespace [5] * AT_name( "js" ) AT_decl_file( "../../dist/include/js/Utility.h" ) AT_decl_line( 35 ) 0x11808500: TAG_subprogram [251] * AT_low_pc( 0x0000000002f12110 ) AT_high_pc( 0x0000000002f1216b ) AT_APPLE_omit_frame_ptr( 0x01 ) AT_frame_base( rsp ) AT_abstract_origin( {0x0000000011800a4f}"_ZN2js40TraceManuallyBarrieredGenericPointerEdgeEP8JSTracerPPNS_2gc4CellEPKc" ) AT_MIPS_linkage_name( "_ZN2js40TraceManuallyBarrieredGenericPointerEdgeEP8JSTracerPPNS_2gc4CellEPKc" ) AT_name( "TraceManuallyBarrieredGenericPointerEdge" ) AT_decl_file( "/builds/slave/rel-m-rel-m64_bld-000000000000/build/js/src/gc/Marking.cpp" ) AT_decl_line( 547 ) AT_external( 0x01 ) AT_APPLE_optimized( 0x01 ) AT_inline( DW_INL_inlined ) This turned a few instances of this in the file I was testing on into `<name omitted>`, which seems to just be a symptom of the "DW_AT_abstract_origin comes later in the file" issue. (Which is probably also worth fixing given that it occurs some 29k times when dumping symbols from Firefox's XUL binary, but it's a separate issue.) R=mark@chromium.org BUG= Review URL: https://codereview.chromium.org/1887033002 . MozReview-Commit-ID: L3cn5z4FY6M
8be3eb37856c2609098b07d3f88ba482892c21b6: bug 1272278 - Don't let PDBSourceLineWriter::GetSymbolFunctionName return empty function names. r=mento
Ted Mielczarek <ted@mielczarek.org> - Mon, 16 May 2016 12:37:58 -0400 - rev 297551
Push 76784 by tmielczarek@mozilla.com at Mon, 16 May 2016 16:38:58 +0000
bug 1272278 - Don't let PDBSourceLineWriter::GetSymbolFunctionName return empty function names. r=mento It's possible for `IDiaSymbol::get_name` to return S_OK and provide and empty string. I haven't figured out the exact root cause yet (the symbols in question are coming from the Rust standard library), but FUNC lines with missing function names break the processor and so we should never do it. This change makes it output "<name omitted>" which matches the behavior of the DWARF dumping code. Review URL: https://codereview.chromium.org/1985643004 . MozReview-Commit-ID: E8jZZM5KVtJ
8de36593cd3b0ecd534efba8e36d73ee4a7692d8: bug 543111 - Fix Mac Breakpad host tools to build in Linux cross-compile. r=mento,glandium
Ted Mielczarek <ted@mielczarek.org> - Thu, 01 Oct 2015 15:04:27 -0400 - rev 265550
Push 65972 by tmielczarek@mozilla.com at Thu, 01 Oct 2015 19:34:39 +0000
bug 543111 - Fix Mac Breakpad host tools to build in Linux cross-compile. r=mento,glandium
3b323ed3b20a881473d15a1b71144c0a51a3ed1e: bug 543111 - Fix Mac Breakpad host tools to build in Linux cross-compile. r=mento,glandium
Ted Mielczarek <ted@mielczarek.org> - Thu, 01 Oct 2015 06:24:58 -0400 - rev 265485
Push 65955 by tmielczarek@mozilla.com at Thu, 01 Oct 2015 11:53:01 +0000
bug 543111 - Fix Mac Breakpad host tools to build in Linux cross-compile. r=mento,glandium
62cba8b2fd7d4686c92bb322b6f3904236df3c83: bug 717758 - handle abort() in Breakpad on OS X. r=mento
Ted Mielczarek <ted@mielczarek.org> - Mon, 16 Sep 2013 14:44:24 -0400 - rev 147739
Push 33970 by tmielczarek@mozilla.com at Wed, 18 Sep 2013 17:08:26 +0000
bug 717758 - handle abort() in Breakpad on OS X. r=mento
752ef8b0c92ae52355ca0fadf4ee64bd49d53bdd: Rename Breakpad's md5.c to md5.cc, wrap its functions in the google_breakpad namespace. no bug, r=mento at http://breakpad.appspot.com/322003/show
Ted Mielczarek <ted.mielczarek@gmail.com> - Mon, 21 Nov 2011 12:40:25 -0500 - rev 81051
Push 3706 by bmo@edmorley.co.uk at Thu, 01 Dec 2011 04:15:54 +0000
Rename Breakpad's md5.c to md5.cc, wrap its functions in the google_breakpad namespace. no bug, r=mento at http://breakpad.appspot.com/322003/show
2873fd69475001beda6d4fbcff5b23a043460572: Rename Breakpad's md5.c to md5.cc, wrap its functions in the google_breakpad namespace. no bug, r=mento at http://breakpad.appspot.com/322003/show
Ted Mielczarek <ted.mielczarek@gmail.com> - Mon, 21 Nov 2011 12:40:25 -0500 - rev 80567
Push 3504 by tmielczarek@mozilla.com at Mon, 21 Nov 2011 17:50:11 +0000
Rename Breakpad's md5.c to md5.cc, wrap its functions in the google_breakpad namespace. no bug, r=mento at http://breakpad.appspot.com/322003/show
846f2ea91e63392221ea1944ae8c1156e1f06139: bug 599301 - Make Breakpad include memory around instruction pointer in minidumps on older versions of Windows. r=mento, a=beltzner
Ted Mielczarek <ted.mielczarek@gmail.com> - Fri, 28 Jan 2011 11:57:08 -0500 - rev 61551
bug 599301 - Make Breakpad include memory around instruction pointer in minidumps on older versions of Windows. r=mento, a=beltzner
247da71f616e0ec93d6454f97f48f1d64113665e: Fix compiling some parts of Breakpad processor on Win32. Landing as part of bug 620974, reviewed and landed upstream. r=mento, a=testonly
Ted Mielczarek <ted.mielczarek@gmail.com> - Wed, 12 Jan 2011 14:13:53 -0500 - rev 60514
Fix compiling some parts of Breakpad processor on Win32. Landing as part of bug 620974, reviewed and landed upstream. r=mento, a=testonly
2020888cd34f6378fea834425c9524a9d7a47357: bug 590961 - Allow generating minidumps from processes of differing CPU architecture. r=mento a=blocking-2.0
Ted Mielczarek <ted.mielczarek@gmail.com> - Thu, 16 Dec 2010 17:56:27 -0500 - rev 59426
bug 590961 - Allow generating minidumps from processes of differing CPU architecture. r=mento a=blocking-2.0
68529f865a6e6cebb480b1e6f312adb7d78c0d2f: bug 589955 - Submit empty crash reports on Windows. r=mento, a=blocking2.0
Ted Mielczarek <ted.mielczarek@gmail.com> - Wed, 15 Dec 2010 11:34:55 -0500 - rev 59193
bug 589955 - Submit empty crash reports on Windows. r=mento, a=blocking2.0
8d361867d243b37fd1303e4d8da139f68181c8e2: bug 411586 - make hte default packager format bzip2 instead of gzip. r=mento
Ted Mielczarek <ted.mielczarek@gmail.com> - Tue, 08 Jul 2008 16:31:09 -0400 - rev 15735
bug 411586 - make hte default packager format bzip2 instead of gzip. r=mento
0dd583397eaa0b8bf8aa97652544269ea6111536: cvs remove the xpfe files obsoleted by the recent checkin for bug 383085 which had r=mento, r/sr=Neil via IRC for cvs removal (files are unused now)
kairo@kairo.at - Fri, 02 May 2008 10:34:22 -0700 - rev 14895
cvs remove the xpfe files obsoleted by the recent checkin for bug 383085 which had r=mento, r/sr=Neil via IRC for cvs removal (files are unused now)
a06c7656730d8bfecea9cfedb67d281f8cfa530b: Bug 383085: Stop building console, updates, alerts, and extensions in xpfe/ for non-MOZ_XUL_APP (only affects Camino). r=mento a1.9=beltzner
stuart.morgan@alumni.case.edu - Thu, 01 May 2008 14:38:25 -0700 - rev 14855
Bug 383085: Stop building console, updates, alerts, and extensions in xpfe/ for non-MOZ_XUL_APP (only affects Camino). r=mento a1.9=beltzner
bad8ccdebc80d522ea76d19f3bc24edfa98d8e37: Bug 359255 - "Importers: Import Filters from current Eudora" (Get{Native}Target implementations for OS X) [p=beckley@qualcomm.com (Jeff Beckley) r=mento sr=mscott a1.9=damons]
reed@reedloden.com - Tue, 26 Feb 2008 01:57:06 -0800 - rev 12246
Bug 359255 - "Importers: Import Filters from current Eudora" (Get{Native}Target implementations for OS X) [p=beckley@qualcomm.com (Jeff Beckley) r=mento sr=mscott a1.9=damons]
4ecfdc77f7cf6859a64f4637174fb66b7a70f64f: Bug 416055 - "Beta 3 l10n builds are missing the Application Folder icon" [p=reed r=mento a1.9=schrep a=blocking-firefox3+]
reed@reedloden.com - Sat, 09 Feb 2008 22:09:54 -0800 - rev 11493
Bug 416055 - "Beta 3 l10n builds are missing the Application Folder icon" [p=reed r=mento a1.9=schrep a=blocking-firefox3+]
57d6e736eada2af90fbf32748d9e1f1c60ccbec3: bug 408729 - collect time since open stat. r=mento
ted.mielczarek@gmail.com - Fri, 21 Dec 2007 13:49:32 -0800 - rev 9612
bug 408729 - collect time since open stat. r=mento
c7545b8f1bc59e3113110a80173213d2bd6331a3: bug 408729 - annotate crash report with StartupTime. r=mento
ted.mielczarek@gmail.com - Tue, 18 Dec 2007 08:07:26 -0800 - rev 9410
bug 408729 - annotate crash report with StartupTime. r=mento
3eb11245684c7f412e17b1e9b84aa4f30ff214eb: Bug 320155: create symlinks dmg files (build tool part); r=mento, blocking-firefox3=beltzner
mnyromyr@tprac.de - Wed, 12 Dec 2007 09:35:45 -0800 - rev 8962
Bug 320155: create symlinks dmg files (build tool part); r=mento, blocking-firefox3=beltzner
08bb0641356ab3bc54eb19582f8d3de34584f2eb: Bug 401718 - "[UA] Remove Mach-O from UA on PPC" [p=reed r=dbaron r=mento sr=biesi a1.9=damons]
reed@reedloden.com - Tue, 04 Dec 2007 17:07:00 -0800 - rev 8718
Bug 401718 - "[UA] Remove Mach-O from UA on PPC" [p=reed r=dbaron r=mento sr=biesi a1.9=damons]
1bf36330353accb81642cba1631676bd041fc3ea: bug 392919 - update Breakpad to SVN revision 234. r=mento
ted.mielczarek@gmail.com - Tue, 04 Dec 2007 07:54:20 -0800 - rev 8662
bug 392919 - update Breakpad to SVN revision 234. r=mento
61479299c22f4d585032387b1b3c8c85bd98b233: clean up mac default plugin. b=373070 r=mento sr=jst a=schrep
joshmoz@gmail.com - Wed, 14 Nov 2007 22:23:46 -0800 - rev 8011
clean up mac default plugin. b=373070 r=mento sr=jst a=schrep
deb6e8a2feb216b35932852b850cd31e41f2287c: Bug 402294: Pull nsIDownload from toolkit rather than xpfe for Camino. r=mento a1.9=schrep
stuart.morgan@alumni.case.edu - Tue, 13 Nov 2007 07:09:11 -0800 - rev 7957
Bug 402294: Pull nsIDownload from toolkit rather than xpfe for Camino. r=mento a1.9=schrep
c4256b6b709799555320d942667accb600172e56: sync trunk and branch setup for bug 400165. r=mento sr=bsmedberg a=schrep
joshmoz@gmail.com - Fri, 09 Nov 2007 11:45:34 -0800 - rev 7769
sync trunk and branch setup for bug 400165. r=mento sr=bsmedberg a=schrep
9b44161ce70c304f0da143bd54dc8dc68809755d: Bug 402294: Switch Camino to getting nsIDownload.h from toolkit rather than xpfe. r=mento
stuart.morgan@alumni.case.edu - Sat, 03 Nov 2007 11:57:35 -0700 - rev 7313
Bug 402294: Switch Camino to getting nsIDownload.h from toolkit rather than xpfe. r=mento
cfef2762ecb383f0abb2ca08bca43a95ab4675b1: Bug 397200 - "OS X dylibs have non-unique signatures causing incorrect stack traces". r=luser,mento. a=bzbarsky.
bent.mozilla@gmail.com - Mon, 24 Sep 2007 23:57:09 -0700 - rev 6288
Bug 397200 - "OS X dylibs have non-unique signatures causing incorrect stack traces". r=luser,mento. a=bzbarsky.
cba342a5fe974b8c850169deadb3bf9ee2eda81d: bug 376721 - send time-since-last-crash with crash report. r=bsmedberg/mento
ted.mielczarek@gmail.com - Wed, 29 Aug 2007 12:46:00 -0700 - rev 5437
bug 376721 - send time-since-last-crash with crash report. r=bsmedberg/mento
f84218c7dae52ff4b0561b9eb224307b105d132d: Bug 382762 - "Crash reporter client app should be named other than "crashreporter"" [p=ardissone r=mento]
reed@reedloden.com - Tue, 28 Aug 2007 14:59:31 -0700 - rev 5396
Bug 382762 - "Crash reporter client app should be named other than "crashreporter"" [p=ardissone r=mento]
e89dced24812241eac71a7e09ad95f21725c06c6: Fixing bug 384796, Call to |nsIStringBundleOverride| always beats the embedding calls. r=mento, sr=roc, 1.9approval=dsicore. Trunk only.
nick.kreeger@park.edu - Tue, 28 Aug 2007 12:48:47 -0700 - rev 5392
Fixing bug 384796, Call to |nsIStringBundleOverride| always beats the embedding calls. r=mento, sr=roc, 1.9approval=dsicore. Trunk only.
460590707584f862cf6787acdfd930b06015f8e1: bug 383083 - post-process symbol files to add source file revision numbers - handle mixed-case srcdir on win32. r=mento
ted.mielczarek@gmail.com - Wed, 22 Aug 2007 13:47:15 -0700 - rev 5171
bug 383083 - post-process symbol files to add source file revision numbers - handle mixed-case srcdir on win32. r=mento
750052e32fd4521a6f840b13599ec77064d707cc: Bug 83265 - Add a way to disable HTTP-EQUIV=refresh. patch from Mark Pilgrim <pilgrim@gmail.com>, r=biesi,mano,mento. sr=bz.
mozilla.mano@sent.com - Tue, 21 Aug 2007 22:02:29 -0700 - rev 5117
Bug 83265 - Add a way to disable HTTP-EQUIV=refresh. patch from Mark Pilgrim <pilgrim@gmail.com>, r=biesi,mano,mento. sr=bz.
e6c36c34c67a42ba12a49727b56853dd97f1a1e9: bug 383083 - post-process symbol files to add source file revision numbers - re-enable --vcs-info on win32/msys. r=mento
ted.mielczarek@gmail.com - Tue, 21 Aug 2007 14:52:54 -0700 - rev 4877
bug 383083 - post-process symbol files to add source file revision numbers - re-enable --vcs-info on win32/msys. r=mento
20d0ff5542112195a7dd79bb25099c02ba30e674: fix srcdir builds on mac os x, bustage from 378995. b=378995 r=mento
joshmoz@gmail.com - Tue, 14 Aug 2007 14:10:00 -0700 - rev 4644
fix srcdir builds on mac os x, bustage from 378995. b=378995 r=mento
2216222562221400a649619a0cd72949ea410d74: bug 382665 - Use a better icon for the crash reporter on OS X. r=mento
ted.mielczarek@gmail.com - Tue, 24 Jul 2007 18:06:15 -0700 - rev 3933
bug 382665 - Use a better icon for the crash reporter on OS X. r=mento
b787ea4db38acc9b46b10315b89f8b285c6ba997: bug 386632 - update to breakpad revision 195. r=mento (missed this file from the original checkin)
ted.mielczarek@gmail.com - Tue, 24 Jul 2007 18:06:13 -0700 - rev 3924
bug 386632 - update to breakpad revision 195. r=mento (missed this file from the original checkin)
c2a90f6a487317fa2a1f807095962a951c25849d: bug 386632 - update to breakpad revision 195. r=mento
ted.mielczarek@gmail.com - Tue, 24 Jul 2007 18:06:11 -0700 - rev 3915
bug 386632 - update to breakpad revision 195. r=mento
38ab679b5dfa5de4876e1adddba7f72796847d3d: bug 384034 - update to breakpad revision 189. r=mento
ted.mielczarek@gmail.com - Tue, 24 Jul 2007 18:06:10 -0700 - rev 3910
bug 384034 - update to breakpad revision 189. r=mento
0bc459662ce5209cb9f800b3961814e3ffd485d9: bug 382541 - Mozilla Crash Reporter supresses writing of Mac OS X crash log - short term workaround. r=mento
ted.mielczarek@gmail.com - Tue, 24 Jul 2007 18:06:09 -0700 - rev 3908
bug 382541 - Mozilla Crash Reporter supresses writing of Mac OS X crash log - short term workaround. r=mento
0c1fcfcc6773b4b27203b2761892f804fbbc618d: bug 379518 - sync up with breakpad svn, yet again. sync to breakpad svn revision 159. r=mento
ted.mielczarek@gmail.com - Tue, 24 Jul 2007 18:06:10 -0700 - rev 3895
bug 379518 - sync up with breakpad svn, yet again. sync to breakpad svn revision 159. r=mento
526fa40af3bd626972ef983d3c00df6c4b89a19f: bug 380541 - build time logic to extract debug symbols on Linux - first cut at integrating Breakpad on Linux. r=mento
ted.mielczarek@gmail.com - Tue, 24 Jul 2007 18:06:04 -0700 - rev 3892
bug 380541 - build time logic to extract debug symbols on Linux - first cut at integrating Breakpad on Linux. r=mento
347b9241d93ab82473623490042f2c734c3d80ba: bug 379518 - sync up with breakpad svn, to revision 157. r=mento
ted.mielczarek@gmail.com - Tue, 24 Jul 2007 18:06:09 -0700 - rev 3889
bug 379518 - sync up with breakpad svn, to revision 157. r=mento
815be93ee39e739896cb6e72432fe78bc45603d4: bug 378463 - build time logic to extract debug symbols on OS X. r=mento. second try
ted.mielczarek@gmail.com - Tue, 24 Jul 2007 18:06:10 -0700 - rev 3888
bug 378463 - build time logic to extract debug symbols on OS X. r=mento. second try
472c4c7005a1aa42de73306b25dff2def599e18c: bug 378463 - build time logic to extract debug symbols on OS X. r=mento
ted.mielczarek@gmail.com - Tue, 24 Jul 2007 18:06:13 -0700 - rev 3886
bug 378463 - build time logic to extract debug symbols on OS X. r=mento
cada7ae9112c39e486e3672cd001117157b85a98: bug 378463 - build time logic to extract debug symbols on OS X. r=mento
ted.mielczarek@gmail.com - Tue, 24 Jul 2007 18:06:08 -0700 - rev 3884
bug 378463 - build time logic to extract debug symbols on OS X. r=mento
be59e0089a72a8c6de191410aa8cd0663b48bec6: bug 368205 - sync up with breakpad svn (again). r=mento
ted.mielczarek@gmail.com - Tue, 24 Jul 2007 18:05:56 -0700 - rev 3869
bug 368205 - sync up with breakpad svn (again). r=mento
629956c5af01701b97c9c6ca69821259bff80c68: bug 360938 - Update airbag to svn tip. r=mento
ted.mielczarek@gmail.com - Tue, 24 Jul 2007 18:06:07 -0700 - rev 3868
bug 360938 - Update airbag to svn tip. r=mento
35c291264a4fb5a576b730919398fe5142f3abb8: bug 366970, crash reporter needs to send Product, Build ID, Platform. r=mento
ted.mielczarek@gmail.com - Tue, 24 Jul 2007 18:05:55 -0700 - rev 3866
bug 366970, crash reporter needs to send Product, Build ID, Platform. r=mento
d9aac21e99f92198c93e633c04567b53cb8e8a3f: bug 354980, integrate airbag exception handler library on windows. Compiling by default on windows, but disabled at runtime by default right now. Set the environment var MOZ_AIRBAG=1 to enable it. r=bsmedberg/mento
ted.mielczarek@gmail.com - Tue, 24 Jul 2007 18:05:54 -0700 - rev 3863
bug 354980, integrate airbag exception handler library on windows. Compiling by default on windows, but disabled at runtime by default right now. Set the environment var MOZ_AIRBAG=1 to enable it. r=bsmedberg/mento
2bf99941fb6898ac8d49dc0d4696ccd407ce6556: use gcc 4 on PPC Mac OS X (we already use gcc 4 on Intel), use 10.4 SDK on all tinderboxes, Mac OS X 10.4 is the new minimum system requirement for Gecko 1.9. b=385221 r=mento r=luser
joshmoz@gmail.com - Tue, 17 Jul 2007 11:10:59 -0700 - rev 3567
use gcc 4 on PPC Mac OS X (we already use gcc 4 on Intel), use 10.4 SDK on all tinderboxes, Mac OS X 10.4 is the new minimum system requirement for Gecko 1.9. b=385221 r=mento r=luser
9b1b97572ab637ebec0033b7367fb9ec09b5852c: bug 386632 - update to breakpad revision 195. r=mento (missed this file from the original checkin)
ted.mielczarek@gmail.com - Fri, 13 Jul 2007 11:18:12 -0700 - rev 3456
bug 386632 - update to breakpad revision 195. r=mento (missed this file from the original checkin)