searching for reviewer(mcomella)
b75e6bb295a948cda358d42f96a0b8c95db8655d: Bug 1459420 - HLS Player doesn't use the centralized Proxy Selector r=mcomella
Igor Oliveira <igt0@torproject.org> - Mon, 04 Jun 2018 05:15:00 +0300 - rev 421475
Push 104045 by nerli@mozilla.com at Wed, 06 Jun 2018 01:03:52 +0000
Bug 1459420 - HLS Player doesn't use the centralized Proxy Selector r=mcomella GeckoHlsPlayer uses the default http ExoPlayer handler, called DefaultHttpDataSource. It uses URL::openConnection instead of the Firefox ProxySelector. This patch updates the ExoPlayer DefaultHttpDataSource to use the ProxySelector.
df3e0250b27571e8bbb8d36a19ecf19d9650dc61: Bug 1457078 - Package default theme icon on Android. r=mcomella
Tim Nguyen <ntim.bugs@gmail.com> - Mon, 04 Jun 2018 22:33:25 +0100 - rev 421400
Push 104043 by aiakab@mozilla.com at Tue, 05 Jun 2018 22:11:53 +0000
Bug 1457078 - Package default theme icon on Android. r=mcomella MozReview-Commit-ID: 5ewrG6aszUj
fc040acc00af17b8d8101090739867461f4d843b: Bug 1457078 - Package default theme icon on Android. r=mcomella
Tim Nguyen <ntim.bugs@gmail.com> - Mon, 04 Jun 2018 21:37:54 +0100 - rev 421397
Push 104043 by aiakab@mozilla.com at Tue, 05 Jun 2018 22:11:53 +0000
Bug 1457078 - Package default theme icon on Android. r=mcomella MozReview-Commit-ID: I2ojxjgMzk1
276a007b27f2892d39152efa194832b0f95907b4: Bug 1462594 - Allow accessing all Settings menus on tablets; r=mcomella
Petru Lingurar <petru.lingurar@softvision.ro> - Thu, 24 May 2018 14:09:22 +0300 - rev 419994
Push 103674 by dluca@mozilla.com at Sat, 26 May 2018 04:18:42 +0000
Bug 1462594 - Allow accessing all Settings menus on tablets; r=mcomella Bug details: The problem stemmed from the now called GeckoPreferences.trySwitchToHeader(int id) which could be called with an invalid id, constant with the same value as the id of the last available setting. (GeckoPreferenceFragment().getHeader() would return valid ids only for preference screens that are launched directly. Otherwise it would return: -1) By chance the id for the last available setting - vendor was not set and so Android saw it with an invalid header id: -1. GeckoPreferences.trySwitchToHeader(int id) would just switch to showing the vendor setting because that is what he has been instructed to whenever the user tried to access other settings than the ones which can be launched directly. Cleaned the code a bit: - renamed GeckoPreferences.switchToHeader(..) to trySwitchToHeader(..) as it won't always perform that action - removed the call to activity.showBreadCrumbs(..) as in my tests it didn't have any effect and the documentation says "This will normally be called for you". Tested on An Android 8 tablet, on an Android 8 phone, on an Android 5.0.1 phone and all works ok. MozReview-Commit-ID: 2sbfcuRHgZd
a25b2c7238f46770d612f2a2cb2f8731e31261ee: Bug 1459089 - Don't use OS Locale when resistFingerprinting is enabled. When the OS Locale is used, it leaks the OS language in the HTTP Accept-Language header. r=mcomella
Igor Oliveira <igt0@torproject.org> - Thu, 03 May 2018 18:28:00 +0300 - rev 419420
Push 103534 by rgurzau@mozilla.com at Wed, 23 May 2018 01:39:59 +0000
Bug 1459089 - Don't use OS Locale when resistFingerprinting is enabled. When the OS Locale is used, it leaks the OS language in the HTTP Accept-Language header. r=mcomella
3f3064a1dfed148a1f80ddb6c3c2c07a9400ec9d: Bug 1411198 - Unlabeled voice input button. r=mcomella
s37syed <shah@shahsyed.me> - Thu, 17 May 2018 01:05:47 -0400 - rev 419309
Push 103497 by nbeleuzu@mozilla.com at Tue, 22 May 2018 11:25:17 +0000
Bug 1411198 - Unlabeled voice input button. r=mcomella Made QR string consistent with respect to other url related strings MozReview-Commit-ID: 432jaONccer
6afab2248a4deb2e00e5d5fa2bb280d954566809: Bug 1411198 - Unlabeled voice input button. r=mcomella
s37syed <shah@shahsyed.me> - Thu, 17 May 2018 00:52:41 -0400 - rev 419308
Push 103497 by nbeleuzu@mozilla.com at Tue, 22 May 2018 11:25:17 +0000
Bug 1411198 - Unlabeled voice input button. r=mcomella Added localization notes and more verbose strings for non-visual users. MozReview-Commit-ID: FiOcDJrgRIy
291f380e8167d4245c3e24fe6375968e02fb635e: Bug 1411198 - Unlabeled voice input button. r=mcomella
s37syed <shah@shahsyed.me> - Mon, 14 May 2018 21:35:34 -0400 - rev 419307
Push 103497 by nbeleuzu@mozilla.com at Tue, 22 May 2018 11:25:17 +0000
Bug 1411198 - Unlabeled voice input button. r=mcomella Added contentDescription strings for QR Code and Voice Input MozReview-Commit-ID: 6tpoewhPxev
de4e1b2221d7f35bd5c3fa1ea8134451f0d7a38f: Bug 1454686 - Remove Lint error suppression for unused strings; r=mcomella
Petru Lingurar <petru.lingurar@softvision.ro> - Wed, 16 May 2018 15:59:56 +0300 - rev 419303
Push 103497 by nbeleuzu@mozilla.com at Tue, 22 May 2018 11:25:17 +0000
Bug 1454686 - Remove Lint error suppression for unused strings; r=mcomella Strings needed for this feature were added in a separate bug - 1445798 which were causing Lint errors. When this feature will land there will be no need for the suppression. MozReview-Commit-ID: IhtTS8rHLwz
d21bb52a99dce11eddb59a480275a75edd5277d7: Bug 1454686 - Respond to changes in the new preference state state; r=mcomella
Petru Lingurar <petru.lingurar@softvision.ro> - Wed, 16 May 2018 15:54:13 +0300 - rev 419302
Push 103497 by nbeleuzu@mozilla.com at Tue, 22 May 2018 11:25:17 +0000
Bug 1454686 - Respond to changes in the new preference state state; r=mcomella Because Mma cannot work if Health Report is disabled by the user (Settings - Privacy) we will treat toggling Health Report on/off the same as we treat toggling the new preference from Settings - Notifications. Toggling Health Report on will inform about the need to start LeanPlum (useful if the user did not explicitly stopped LP notifications but only Health Report which in turn disabled LeanPlum also) but there are other checks made afterwards (BrowserAp() is informed about this which calls GeckoPreferences.isMmaAvailable(..)) to decide if LP can and should be enabled. Toggling any of these preferences will trigger an event caught by BrowserApp which can either - immediately initialize LeanPlum (if the toggle was off LP is not running) as it would normally do when the app first starts - stop LeanPlum reporting to servers, flush the per-session available messages and resets the LP started status so that it can be restarted in the same app session (like if the user toggles the feature again) MozReview-Commit-ID: 1SmhN0NucWW ***
c6586abb677359e0a876a6d26d897af84149c67b: Bug 1454686 - Small refactoring of Mma related methods; r=mcomella
Petru Lingurar <petru.lingurar@softvision.ro> - Thu, 17 May 2018 18:55:38 +0300 - rev 419301
Push 103497 by nbeleuzu@mozilla.com at Tue, 22 May 2018 11:25:17 +0000
Bug 1454686 - Small refactoring of Mma related methods; r=mcomella With the adding of the new preference that Mma depends on we need to have only one place where all the conditions for considering if Mma is available are checked - GeckoPreferences.isMmaAvailableAndEnabled() Added only one place from where the availability of the LP experiments should be checked as that currently involves two checks - MmaDelegate.isMmaExperimentEnabled(..) Also renamed isMmaEnabled() from MmaDelegate() and initSwitchboard from BrowserApp() to better express what those methods do. MozReview-Commit-ID: BCJqM9b5JbW ***
84312c7af401068076933a2928043be3167571ee: Bug 1454686 - MmaLeanPlumImp().stop() will now stop LP, stop showing messages and allow restart in same app session; r=mcomella
Petru Lingurar <petru.lingurar@softvision.ro> - Thu, 17 May 2018 18:45:01 +0300 - rev 419300
Push 103497 by nbeleuzu@mozilla.com at Tue, 22 May 2018 11:25:17 +0000
Bug 1454686 - MmaLeanPlumImp().stop() will now stop LP, stop showing messages and allow restart in same app session; r=mcomella According to current LP documentation there are no SDK APIs to allow users to fully stop LP: events reporting and message displaying there. After extensive testing and investigations I think I found the least intrusive way to offer that. We will use internal methods but which are public so I hope they will be supported in the future also. Nevertheless we will need to maintain this in regards to future SDK updates. MozReview-Commit-ID: Ke3HGAyCqVA ***
a371b3bb0cd60bbd82374a32bc8749230209ac6c: Bug 1454686 - Add a new preference under Settings - Notifications; r=mcomella
Petru Lingurar <petru.lingurar@softvision.ro> - Wed, 16 May 2018 11:49:35 +0300 - rev 419299
Push 103497 by nbeleuzu@mozilla.com at Tue, 22 May 2018 11:25:17 +0000
Bug 1454686 - Add a new preference under Settings - Notifications; r=mcomella The behavior of this new preference is dynamic in that: - it will be hidden if LeanPlum is not available for the device - it will be toggled off and disabled if Health Report is disabled by the user MozReview-Commit-ID: 1x9zZukyygr ***
e5ecf6627dfd203a2d6e3f764811fb132fe2126a: Bug 1434603 - Settings Header not changed when visiting sub-menus on Oreo; r=mcomella
Petru Lingurar <petru.lingurar@softvision.ro> - Tue, 15 May 2018 13:03:44 +0300 - rev 418673
Push 103359 by csabou@mozilla.com at Thu, 17 May 2018 09:50:16 +0000
Bug 1434603 - Settings Header not changed when visiting sub-menus on Oreo; r=mcomella The ActionBar's title will always be updated with the title of the visiting PreferenceScreen. MozReview-Commit-ID: b5MyrSaWFC
ebcbcffb286fb946bd5d5dc82be5e086a14d3616: Bug 1318046 - Allow inputting years for "date" and "datetime" html input types; r=mcomella
Petru Lingurar <petru.lingurar@softvision.ro> - Fri, 04 May 2018 15:03:03 +0300 - rev 417244
Push 103021 by aiakab@mozilla.com at Tue, 08 May 2018 12:45:06 +0000
Bug 1318046 - Allow inputting years for "date" and "datetime" html input types; r=mcomella For "date" I switched to using platform's DatePicker in place of our custom DateTimePicker, change that will also ensure future feature compatibility. For "datetime" and "datetime-local" I've kept using our DateTimePicker but which will now offer spinners for selecting all fields. MozReview-Commit-ID: 2oOORFH6OJ6
d1f8638fcf2bd16c12faaa6500e0c80a64e4c07b: Bug 1459632 - Update Notifications settings summary; r=mcomella
Petru Lingurar <petru.lingurar@softvision.ro> - Mon, 07 May 2018 18:11:48 +0300 - rev 417243
Push 103021 by aiakab@mozilla.com at Tue, 08 May 2018 12:45:06 +0000
Bug 1459632 - Update Notifications settings summary; r=mcomella MozReview-Commit-ID: 4CqGnyx9qt1
bd60840b26cb0b47d40af1a7ec1c7a6f83482b68: Bug 1425669 - Move StumblerService location permission check after the intent&scan enabled checks. r=mcomella
Vlad Baicu <vlad.baicu@softvision.ro> - Fri, 04 May 2018 16:10:17 +0300 - rev 417033
Push 102950 by ncsoregi@mozilla.com at Sat, 05 May 2018 09:53:48 +0000
Bug 1425669 - Move StumblerService location permission check after the intent&scan enabled checks. r=mcomella On Android 7.0.0, the OS would start the StumblerService and without having given fennec the location permission the intent and scan enabled checks would've been skipped - which ensure that the Stumbler Service does not run in unadequate scenarios. MozReview-Commit-ID: AGU67ytE4ff
b2bbaf13b5ebebdfdd733fe27cc02716e5cf8cb4: Bug 1380850 - Track when Focus or Klar get installed; r=mcomella
Petru Lingurar <petru.lingurar@softvision.ro> - Wed, 02 May 2018 13:32:43 +0300 - rev 416726
Push 102840 by rgurzau@mozilla.com at Wed, 02 May 2018 21:09:04 +0000
Bug 1380850 - Track when Focus or Klar get installed; r=mcomella Added a static broadcast receiver that will inform us as soon as possible of any installed packages. Because mma methods are static, if LeanPlum is enabled, the event will be tracked even if the app was not running when the new package was installed and as per LeanPlum's internal workings the event will be reported to the dashboard when the application resumes. MozReview-Commit-ID: AGNsQn7LuCz ***
1e5514bef692f08ee0bce003f6f1c2c256cf808c: Bug 1445798 - Add Leanplum settings opt-out strings needed for bug #1454686; r=mcomella
Petru Lingurar <petru.lingurar@softvision.ro> - Mon, 23 Apr 2018 19:09:13 +0300 - rev 415938
Push 102694 by csabou@mozilla.com at Fri, 27 Apr 2018 10:15:42 +0000
Bug 1445798 - Add Leanplum settings opt-out strings needed for bug #1454686; r=mcomella To allow users to opt-out from receiving LeanPlum messages we need a new setting added. This are the Strings for the title and summary of that setting. Localization notes also added as this Strings will ship before the feature. Decided to suppress all UnusedResources Lint errors for android strings until the patch for #1454686 lands as using in-line suppression caused other errors. Ran Lint locally, the build passed. MozReview-Commit-ID: 9Kx567ruY3n ***
a64ffd8dd1320a175bceb1359886e93d273051eb: Bug 1405192 - Return if onResume has already been called and onPause hasn't. Add telemetry ping for future investigations. r=mcomella
Vlad Baicu <vlad.baicu@softvision.ro> - Wed, 25 Apr 2018 18:56:55 +0300 - rev 415936
Push 102694 by csabou@mozilla.com at Fri, 27 Apr 2018 10:15:42 +0000
Bug 1405192 - Return if onResume has already been called and onPause hasn't. Add telemetry ping for future investigations. r=mcomella After investigating and analyzing the crash reports this type of scenario can occur due to multi-window or some popups. We are tracking this scenario for further investiagion with a telemetry event. Also added a constant for the hardcoded telemetry event when onPause gets called before onResume. MozReview-Commit-ID: 2qXCYFyjlce
9a092f00fdd698ea9b3f705dcea9e32b9979fb28: Bug 1455165 - Filter external apps out if needed. r=mcomella
Igor Oliveira <igt0@torproject.org> - Wed, 18 Apr 2018 17:16:00 +0300 - rev 415436
Push 102575 by cbrindusan@mozilla.com at Wed, 25 Apr 2018 02:12:05 +0000
Bug 1455165 - Filter external apps out if needed. r=mcomella
770da11a39608efba866a3a074e8df41665439e9: Bug 1445798 - Add Leanplum settings opt-out strings needed for bug #1454686; r=mcomella
Petru Lingurar <petru.lingurar@softvision.ro> - Sun, 22 Apr 2018 22:39:21 +0300 - rev 414992
Push 102458 by archaeopteryx@coole-files.de at Sun, 22 Apr 2018 19:39:40 +0000
Bug 1445798 - Add Leanplum settings opt-out strings needed for bug #1454686; r=mcomella To allow users to opt-out from receiving LeanPlum messages we need a new setting added. This are the Strings for the title and summary of that setting. Localization notes also added as this Strings will ship before the feature. MozReview-Commit-ID: 9Kx567ruY3n
33a23441508ad8544db9c4308b7b74b83319ac2f: Bug 1445798 - Add Leanplum settings opt-out strings needed for bug #1454686; r=mcomella
Petru Lingurar <petru.lingurar@softvision.ro> - Wed, 18 Apr 2018 10:59:16 +0300 - rev 414941
Push 102435 by apavel@mozilla.com at Sat, 21 Apr 2018 11:11:43 +0000
Bug 1445798 - Add Leanplum settings opt-out strings needed for bug #1454686; r=mcomella To allow users to opt-out from receiving LeanPlum messages we need a new setting added. This are the Strings for the title and summary of that setting. Localization notes also added as this Strings will ship before the feature. MozReview-Commit-ID: 9Kx567ruY3n
9dece6b7a5949d4c56415ee7ed6f4e03c3eb8e42: Bug 1445798 - Add Leanplum settings opt-out strings needed for bug #1454686; r=mcomella
Petru Lingurar <petru.lingurar@softvision.ro> - Wed, 18 Apr 2018 10:59:16 +0300 - rev 414399
Push 102329 by nerli@mozilla.com at Thu, 19 Apr 2018 09:59:48 +0000
Bug 1445798 - Add Leanplum settings opt-out strings needed for bug #1454686; r=mcomella To allow users to opt-out from receiving LeanPlum messages we need a new setting added. This are the Strings for the title and summary of that setting. Localization notes also added as this Strings will ship before the feature. MozReview-Commit-ID: 9Kx567ruY3n
924aabc981b6136cf09cfc8df170ffd882dde8a3: Bug 1423045 - Drop an event when User changes default browser to Firefox; r=mcomella
Petru Lingurar <petru.lingurar@softvision.ro> - Wed, 18 Apr 2018 15:21:12 +0300 - rev 414393
Push 102329 by nerli@mozilla.com at Thu, 19 Apr 2018 09:59:48 +0000
Bug 1423045 - Drop an event when User changes default browser to Firefox; r=mcomella Use SharedPreference to ensure we won't loose previous state if Fennec is killed, set as default, restarted. The default browser status will only be set once, when the app is resumed, as it cannot change while the app is in foreground. We will track "E_Changed_Default_To_Fennec" only if Fennec wasn't previously the default browser. The method to track the event is safe to be called even before the mma init process is finished as LeanPlum postpones the track operation until it has actually been started. Refactored MmaDelegate to not use a WeakReference for application context anymore as that should exist for the entire time the app is open, and only in that timeframe the MmaDelegate methods that use that context can be called. MozReview-Commit-ID: JMJJclWj9fq
376bf7bbb8285b179c3279bc14ab8dd054cc758f: Bug 1355389 - Added one extra parameter to the message from the emitted event, parameter which indicates if the input element has multiple attribute. r=mcomella
Andrei Lazar <andrei.a.lazar@softvision.ro> - Fri, 13 Apr 2018 18:09:23 +0300 - rev 414223
Push 102289 by dluca@mozilla.com at Wed, 18 Apr 2018 11:09:48 +0000
Bug 1355389 - Added one extra parameter to the message from the emitted event, parameter which indicates if the input element has multiple attribute. r=mcomella MozReview-Commit-ID: CpRfgaYvV5y
739f3fb1e63cf7ae3e727b089175e733183bc5f7: Bug 1453154 - Add Leanplum documentation for Users resuming the app from background; r=mcomella
Petru Lingurar <petru.lingurar@softvision.ro> - Fri, 13 Apr 2018 16:35:39 +0300 - rev 414221
Push 102289 by dluca@mozilla.com at Wed, 18 Apr 2018 11:09:48 +0000
Bug 1453154 - Add Leanplum documentation for Users resuming the app from background; r=mcomella MozReview-Commit-ID: 5bHNO2GACya
f22a918616f8457e25115c54e3517fc18265d8e2: Bug 1442054 Replaced deprecated singleLine attribute with maxLines=1 r=mcomella
Vlad Baicu <vlad.baicu@softvision.ro> - Mon, 16 Apr 2018 15:52:08 +0300 - rev 414006
Push 102220 by cbrindusan@mozilla.com at Tue, 17 Apr 2018 10:11:08 +0000
Bug 1442054 Replaced deprecated singleLine attribute with maxLines=1 r=mcomella MozReview-Commit-ID: BKJhIRG0d1v
787dce710dce6dff0d9f9e7621c9dac676843678: Bug 1453413 - Use aapt2 to build Firefox for Android. r=mcomella
Nick Alexander <nalexander@mozilla.com> - Wed, 11 Apr 2018 09:59:22 -0700 - rev 413121
Push 102087 by aiakab@mozilla.com at Fri, 13 Apr 2018 09:58:48 +0000
Bug 1453413 - Use aapt2 to build Firefox for Android. r=mcomella MozReview-Commit-ID: LhWmLl2movv
ba90e25685c640fdb9d531397032d6d52c72a998: Bug 1453276 - Improve mma documentation for "Pocket in Top Sites"; r=mcomella
Petru Lingurar <petru.lingurar@softvision.ro> - Wed, 11 Apr 2018 13:45:22 +0300 - rev 413117
Push 102087 by aiakab@mozilla.com at Fri, 13 Apr 2018 09:58:48 +0000
Bug 1453276 - Improve mma documentation for "Pocket in Top Sites"; r=mcomella MozReview-Commit-ID: KDuBHXB8Q1a
6ea3c1db006049ff57f392c7042db0a91ec9b10b: Bug 1431329 - If the tab in which the media player is running is in private browsing mode then we shall not display media playback notification. r=mcomella
Andrei Lazar <andrei.a.lazar@softvision.ro> - Thu, 12 Apr 2018 14:39:56 +0300 - rev 413091
Push 102087 by aiakab@mozilla.com at Fri, 13 Apr 2018 09:58:48 +0000
Bug 1431329 - If the tab in which the media player is running is in private browsing mode then we shall not display media playback notification. r=mcomella MozReview-Commit-ID: EROHEubnP3r
633defe3cba479e3b482aa06589f5949d237b21e: Bug 1451565 - Update Robolectric to 3.8. r=mcomella
Nick Alexander <nalexander@mozilla.com> - Wed, 04 Apr 2018 16:48:03 -0700 - rev 412894
Push 102036 by ebalazs@mozilla.com at Thu, 12 Apr 2018 09:47:53 +0000
Bug 1451565 - Update Robolectric to 3.8. r=mcomella MozReview-Commit-ID: 9lQ7De6cifZ
e041cf30962f1507837954702c32d8a5dba65e84: Bug 1452173 - Add Leanplum documentation for Users Opting out of pocket in top sites; r=mcomella
Petru Lingurar <petru.lingurar@softvision.ro> - Tue, 10 Apr 2018 11:39:42 +0300 - rev 412740
Push 102000 by aciure@mozilla.com at Wed, 11 Apr 2018 09:01:07 +0000
Bug 1452173 - Add Leanplum documentation for Users Opting out of pocket in top sites; r=mcomella Make mention of the new LeanPlum user attribute introduced as per Bug 1445799 MozReview-Commit-ID: 7jjRzh2wfe5
5f20da3f845d239e245ffe0e5091ff7ea4f2fb62: Bug 1423046 - Drop an event when User opens the Firefox app (from Leanplum contextual hints); r=mcomella
Petru <petru.lingurar@softvision.ro> - Thu, 05 Apr 2018 13:34:32 +0300 - rev 412739
Push 102000 by aciure@mozilla.com at Wed, 11 Apr 2018 09:01:07 +0000
Bug 1423046 - Drop an event when User opens the Firefox app (from Leanplum contextual hints); r=mcomella The app already sends "E_Launch_Browser" for when it is first launched. MozReview-Commit-ID: 9BU6b3D58vY
6419ebd66757aabdf72c64fe1a52e2474f4abed7: Bug 1445799 - User Attribute for Leanplum for Android Users that have Opted Out of Pocket in their Top Sites; r=mcomella
Petru Lingurar <petru.lingurar@softvision.ro> - Thu, 05 Apr 2018 12:32:26 +0300 - rev 412019
Push 101825 by apavel@mozilla.com at Fri, 06 Apr 2018 10:22:00 +0000
Bug 1445799 - User Attribute for Leanplum for Android Users that have Opted Out of Pocket in their Top Sites; r=mcomella Small refactoring to avoid duplicated code and use newly created way of checking if Pocket is recommending Top Sites. MozReview-Commit-ID: Lw9hvcM4uya
73df2d0026bbe589547b860ce1e594f553c93966: Bug 1445799 - User Attribute for Leanplum for Android Users that have Opted Out of Pocket in their Top Sites; r=mcomella
Petru Lingurar <petru.lingurar@softvision.ro> - Wed, 04 Apr 2018 14:03:39 +0300 - rev 412018
Push 101825 by apavel@mozilla.com at Fri, 06 Apr 2018 10:22:00 +0000
Bug 1445799 - User Attribute for Leanplum for Android Users that have Opted Out of Pocket in their Top Sites; r=mcomella Added a new user attribute in LP: "Top Sites by Pocket" to indicate if the user has the feature enabled or not, which will stored in LP along with the other attributes when the app first starts. Small refactoring to avoid duplicated code and use newly created way of checking if Pocket is recommending Top Sites. MozReview-Commit-ID: IWieAorkB1P
479e52127d919b9aa165ef24a0b729e7cc57d77f: Bug 1444549: Remove unused IconTabWidget XML attr. r=mcomella
Vlad Baicu <vlad.baicu@softvision.ro> - Thu, 22 Mar 2018 13:46:41 -0700 - rev 409606
Push 101249 by ryanvm@gmail.com at Thu, 22 Mar 2018 23:44:36 +0000
Bug 1444549: Remove unused IconTabWidget XML attr. r=mcomella This code was crashing in the framework; removing it should hopefully fix the crash. MozReview-Commit-ID: 2G3q4JrJ9tP
f334c282d6fa25de9a415b560bd8474e518cdd60: Bug 1443825 - Update sanitizing methods for autocomplete domains. r=ekager,mcomella
Sebastian Kaspari <s.kaspari@gmail.com> - Wed, 07 Mar 2018 17:51:33 +0100 - rev 408877
Push 101061 by apavel@mozilla.com at Mon, 19 Mar 2018 22:44:08 +0000
Bug 1443825 - Update sanitizing methods for autocomplete domains. r=ekager,mcomella MozReview-Commit-ID: 2cB62XXdflS
e0a19b7fc6f6a44a990dacf210e871eda7eeddce: Bug 1437430: Make some immutable final fields static; r=mcomella
Andrew Gaul <andrew@gaul.org> - Sun, 11 Feb 2018 22:36:58 -0800 - rev 407870
Push 100792 by nbeleuzu@mozilla.com at Tue, 13 Mar 2018 10:37:01 +0000
Bug 1437430: Make some immutable final fields static; r=mcomella Adding static reduces memory overhead from per-instance to per-class and allows initialization at compile-time instead of run-time. Found via a proposed error-prone pull request: https://github.com/google/error-prone/pull/930 MozReview-Commit-ID: CMj6vqFeCdI
a4acfa51d53c6b36be93cd8e3d9838eb6904dd3a: Bug 1411654 - Part 5c: Work through ResourceUnused lint issues. r=mcomella
Nick Alexander <nalexander@mozilla.com> - Tue, 14 Nov 2017 19:20:16 -0800 - rev 401989
Push 99472 by cbrindusan@mozilla.com at Thu, 01 Feb 2018 10:20:30 +0000
Bug 1411654 - Part 5c: Work through ResourceUnused lint issues. r=mcomella MozReview-Commit-ID: 82rgLEEMQzG
431cf29e833967572b80817be661f698e43e3879: Bug 1411654 - Part 5b: Work through WrongConstant lint issues. r=mcomella
Nick Alexander <nalexander@mozilla.com> - Tue, 14 Nov 2017 15:36:49 -0800 - rev 401988
Push 99472 by cbrindusan@mozilla.com at Thu, 01 Feb 2018 10:20:30 +0000
Bug 1411654 - Part 5b: Work through WrongConstant lint issues. r=mcomella MozReview-Commit-ID: 6zJ7EMu9rgO
cbbb957aa4703abfbdd984b1dbc3bbdff025de8a: Bug 1411654 - Part 6: Fix checkstyle. r=mcomella
Nick Alexander <nalexander@mozilla.com> - Tue, 14 Nov 2017 09:49:27 -0800 - rev 401987
Push 99472 by cbrindusan@mozilla.com at Thu, 01 Feb 2018 10:20:30 +0000
Bug 1411654 - Part 6: Fix checkstyle. r=mcomella MozReview-Commit-ID: GPRogNGKQBJ
1eb2f1b4c9618edd69cba67e16753398d8a10051: Bug 1411654 - Part 5: Work through various new lint issues. r=mcomella
Nick Alexander <nalexander@mozilla.com> - Wed, 08 Nov 2017 10:11:25 -0800 - rev 401986
Push 99472 by cbrindusan@mozilla.com at Thu, 01 Feb 2018 10:20:30 +0000
Bug 1411654 - Part 5: Work through various new lint issues. r=mcomella MozReview-Commit-ID: AhrT7jbztE3
d67b952ecbe41872990cc0acd1ad480476560bc9: Bug 1411654 - Part 2: Update Robolectric to 3.5.1. r=mcomella
Nick Alexander <nalexander@mozilla.com> - Tue, 07 Nov 2017 20:26:43 -0800 - rev 401983
Push 99472 by cbrindusan@mozilla.com at Thu, 01 Feb 2018 10:20:30 +0000
Bug 1411654 - Part 2: Update Robolectric to 3.5.1. r=mcomella There were a few API changes, mostly around explicitly creating Services/Activities/ContentProvider instances, but they were pretty easy to address. Sadly, Robolectric doesn't really work with the new aapt2 processing in Android-Gradle plugin 3.0+ -- see in particular https://github.com/robolectric/robolectric/issues/3333#issuecomment-324300418 -- so we have to opt-out of the new implementation for now. Hopefully plugin 3.1+ will address these issues, which are widespread. MozReview-Commit-ID: dlbd32kMs6
d5a5a3d8e6e560a17bf16a3c2fa7256f0280df96: Bug 1411654 - Pre: Remove unused HomeExpandableListView. r=mcomella
Nick Alexander <nalexander@mozilla.com> - Tue, 14 Nov 2017 19:32:18 -0800 - rev 401979
Push 99472 by cbrindusan@mozilla.com at Thu, 01 Feb 2018 10:20:30 +0000
Bug 1411654 - Pre: Remove unused HomeExpandableListView. r=mcomella This was added for the Remote Tabs panel in Bug 785199. That code has now morphed into the combined history panel, which uses a RecyclerView. MozReview-Commit-ID: J6KsVCn8mzh
96c50f1649654bbd681320a8aa15bbc21c993aaf: Bug 1411654 - Pre: Fix checkstyle whitespace error in GeckoHlsPlayer. r=mcomella
Nick Alexander <nalexander@mozilla.com> - Thu, 04 Jan 2018 12:26:11 -0800 - rev 401978
Push 99472 by cbrindusan@mozilla.com at Thu, 01 Feb 2018 10:20:30 +0000
Bug 1411654 - Pre: Fix checkstyle whitespace error in GeckoHlsPlayer. r=mcomella MozReview-Commit-ID: 4h1p4J5B8sM
986da6f801e425bbb335f44b61e90e293b18ca41: Bug 1411654 - Pre: Clear icon disk storage in test. r=mcomella
Nick Alexander <nalexander@mozilla.com> - Tue, 07 Nov 2017 20:24:04 -0800 - rev 401975
Push 99472 by cbrindusan@mozilla.com at Thu, 01 Feb 2018 10:20:30 +0000
Bug 1411654 - Pre: Clear icon disk storage in test. r=mcomella Newer versions of Robolectric seem to have different semantics about clearing disk caches, so this is necessary. But for older versions, it shouldn't hurt, and is slightly more clear than relying on an implicit clear. MozReview-Commit-ID: LRcaEPasXj8
9177a22af8d0ecbaf738e5182f7ab77ae91b6c5f: Bug 1411654 - Pre: Remove unused PerProfileDatabaseProvider. r=mcomella
Nick Alexander <nalexander@mozilla.com> - Tue, 07 Nov 2017 20:18:56 -0800 - rev 401974
Push 99472 by cbrindusan@mozilla.com at Thu, 01 Feb 2018 10:20:30 +0000
Bug 1411654 - Pre: Remove unused PerProfileDatabaseProvider. r=mcomella No idea what is going on with this hierarchy, but this isn't used and isn't helping anything. MozReview-Commit-ID: Ir3LxLYHR6M
f4ea28fdbc3e6e19f6146435ec8a8b3707eed562: Bug 1411654 - Pre: Fix dangling resource. r=mcomella
Nick Alexander <nalexander@mozilla.com> - Wed, 08 Nov 2017 09:47:48 -0800 - rev 401973
Push 99472 by cbrindusan@mozilla.com at Thu, 01 Feb 2018 10:20:30 +0000
Bug 1411654 - Pre: Fix dangling resource. r=mcomella This is just wrong. MozReview-Commit-ID: EBtKTD07aNu
55776829a744ec20be08d29083c4b39b9519b9b4: Bug 1411654 - Part 5c: Work through ResourceUnused lint issues. r=mcomella
Nick Alexander <nalexander@mozilla.com> - Tue, 14 Nov 2017 19:20:16 -0800 - rev 399349
Push 98941 by dluca@mozilla.com at Tue, 16 Jan 2018 04:09:40 +0000
Bug 1411654 - Part 5c: Work through ResourceUnused lint issues. r=mcomella MozReview-Commit-ID: 82rgLEEMQzG