searching for reviewer(mattwoodrow)
f663e895f99599275d45eee3bc4525dfd4ad9d8e: Bug 1593170. Annotate new expected asserts in docshell/base/crashtests/1257730-1.html as a result of Fission work in reftest harness. r=mattwoodrow
Timothy Nikkel <tnikkel@gmail.com> - Mon, 18 Nov 2019 11:28:14 +0000 - rev 502494
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1593170. Annotate new expected asserts in docshell/base/crashtests/1257730-1.html as a result of Fission work in reftest harness. r=mattwoodrow The asserts are NS_ASSERTION(mDidInitialize, "should have done initial reflow by now"); in layout/base/PresShell.cpp in a couple of different places. The stacks are slightly different from the existing case in bug 566159. In bug 566159 the stacks are as a result of asking to scroll. In this case the stacks are from an autofocus form element. The element is actually in our about:neterror page when the test tries to navigate to "href". The reason they show up now is that the Fission work on the reftest harness, in general, makes things more async. So in this test we previously tore down the page and moved on to the next test before being able to hit these assertions. Differential Revision: https://phabricator.services.mozilla.com/D51348
cd93c57f87fa3819f04d57385a68561d2508a316: Bug 1593170. Skip plugin-background-*-step.html when we do not have the test plugin. r=mattwoodrow
Timothy Nikkel <tnikkel@gmail.com> - Mon, 18 Nov 2019 11:28:02 +0000 - rev 502493
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1593170. Skip plugin-background-*-step.html when we do not have the test plugin. r=mattwoodrow These tests test that moving around the plugin causes it to still draw correctly. If we don't have the test plugin then they fail and are marked as such. The tests start by moving the plugin and then waiting for MozAfterPaint or MozPaintWaitFinished. When there is no plugin these events don't come. Without the test plugin this was working because they got an unrelated MozAfterPaint (it was probably one of the early paints of the page). After we update the reftest harness for fission and make it more async in general we no longer catch this early MozAfterPaint and the tests don't start. We should just skip them, there is nothing to test with a plugin. Differential Revision: https://phabricator.services.mozilla.com/D51347
249e26bfefd68d3efe8c06eee1ffa1341a43c59e: Bug 1593170. Skip 1553571-1.html reftest on android debug webrender. r=mattwoodrow
Timothy Nikkel <tnikkel@gmail.com> - Mon, 18 Nov 2019 11:27:49 +0000 - rev 502492
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1593170. Skip 1553571-1.html reftest on android debug webrender. r=mattwoodrow The changes to make the test harness avoid busy waiting with setTimeout(0)'s made this test fail on Android 8.0 debug webrender. In order to get an active layer the test tweaks a transform slightly that has no visual effect every 74 ms. This is necessary to test the bug as far as I can tell (I wrote the test). The test times out because MakeProgress never makes any progress, there is always an afterpaint pending or an after paint has fired and we need to update the canvas for it. The painting and running through the settimeouts etc of the reftest harness take slightly too long. Before the changes to remove the busy waits we were just barely passing this test, it took 76 seconds in once instance that I checked and hundreds of iterations before we could make progress. Haven't debugged exactly why removing the busywaits makes this fail but it doesn't seem important. Differential Revision: https://phabricator.services.mozilla.com/D52650
0dc7546c4a8a75dda043edc312305a6ceba0ad53: Bug 1593170. Check if contentRootElement is a dead wrapper before using it. r=mattwoodrow,dbaron
Timothy Nikkel <tnikkel@gmail.com> - Mon, 18 Nov 2019 11:27:00 +0000 - rev 502491
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1593170. Check if contentRootElement is a dead wrapper before using it. r=mattwoodrow,dbaron With the fission changes everything is more async, meaning some tests can run longer. Some crashtests navigate to a new location meaning the original root element we have a variable for is no longer around, and chrome isn't allowed to keep content nodes alive, so we are left holding a dead wrapper that throws if we try to access anything on it. So we check if contentRootElement has become a dead wrapper (and null it out) any time we try to access it and it could have become dead. Generally the existing code already handled a null contentRootElement. Differential Revision: https://phabricator.services.mozilla.com/D52829
285e9108032ffb6cd62fe7d587ef97c1a86d8d41: Bug 1593170. Avoid useless painting work in queued up rects to paint by ignoring new rects that are already covered. r=mattwoodrow
Timothy Nikkel <tnikkel@gmail.com> - Mon, 18 Nov 2019 11:26:45 +0000 - rev 502490
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1593170. Avoid useless painting work in queued up rects to paint by ignoring new rects that are already covered. r=mattwoodrow I don't think this is strictly necessary but it lets us avoid a bunch of useless work, especially with webrender where these rects are always the full window size. Differential Revision: https://phabricator.services.mozilla.com/D51346
ddcfa0a1fa00353cb74f5b237a9652bce8398b45: Bug 1593170. Adjust how we deal with the reftest events for async plugin drawing for the fission changes to the reftest harness. r=mattwoodrow
Timothy Nikkel <tnikkel@gmail.com> - Mon, 18 Nov 2019 11:26:33 +0000 - rev 502489
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1593170. Adjust how we deal with the reftest events for async plugin drawing for the fission changes to the reftest harness. r=mattwoodrow The long code comment explains. Differential Revision: https://phabricator.services.mozilla.com/D51345
449d87c4759340bd61e4ae3ab0bc67f826ac02cf: Bug 1593170. Make the reftest harness deal with SynchronizeForSnapshot and FlushRendering returning promises. r=mattwoodrow
Timothy Nikkel <tnikkel@gmail.com> - Mon, 18 Nov 2019 11:26:20 +0000 - rev 502488
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1593170. Make the reftest harness deal with SynchronizeForSnapshot and FlushRendering returning promises. r=mattwoodrow The code comment mostly explains the design. Basically, we force nothing to happen while we wait for the promises to finish and instead record what we need to do once the promise is finished, and do those pending tasks when it's finished. Differential Revision: https://phabricator.services.mozilla.com/D51344
06f14f474f284543abd637543cecfa4d6079be50: Bug 1593170. Make the reftest-content.js functions FlushRendering and SynchronizeForSnapshot work on Fission child oop iframes. r=mattwoodrow,kmag
Timothy Nikkel <tnikkel@gmail.com> - Mon, 18 Nov 2019 11:25:11 +0000 - rev 502487
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1593170. Make the reftest-content.js functions FlushRendering and SynchronizeForSnapshot work on Fission child oop iframes. r=mattwoodrow,kmag This changes them to return a promise that resolves when the work is done, but we still need to change the callers to handle this new return type and do the right thing when these functions do their work async-ly. To do this we add a JSWindowActor called ReftestFission. reftest-content.js communicates with this actor via reftest.jsm. Differential Revision: https://phabricator.services.mozilla.com/D51343
eb5f05b67d5684795a3043d90ef99cc9f17c504a: Bug 1597175. Fix nsExternalHelperAppService::DoContent to work with non-docshell content contexts. r=mattwoodrow
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 18 Nov 2019 06:14:57 +0000 - rev 502375
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1597175. Fix nsExternalHelperAppService::DoContent to work with non-docshell content contexts. r=mattwoodrow Some consumers of this code have an aContentContext implemented in JS. Differential Revision: https://phabricator.services.mozilla.com/D53385
2c98625f235b532d925f84e473406ff81e47d02e: Bug 1593170. Annotate new expected asserts in docshell/base/crashtests/1257730-1.html as a result of Fission work in reftest harness. r=mattwoodrow
Timothy Nikkel <tnikkel@gmail.com> - Mon, 18 Nov 2019 00:51:08 +0000 - rev 502368
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1593170. Annotate new expected asserts in docshell/base/crashtests/1257730-1.html as a result of Fission work in reftest harness. r=mattwoodrow The asserts are NS_ASSERTION(mDidInitialize, "should have done initial reflow by now"); in layout/base/PresShell.cpp in a couple of different places. The stacks are slightly different from the existing case in bug 566159. In bug 566159 the stacks are as a result of asking to scroll. In this case the stacks are from an autofocus form element. The element is actually in our about:neterror page when the test tries to navigate to "href". The reason they show up now is that the Fission work on the reftest harness, in general, makes things more async. So in this test we previously tore down the page and moved on to the next test before being able to hit these assertions. Differential Revision: https://phabricator.services.mozilla.com/D51348
39d63ae4d2871837382c0cbfe8ba616f60ed116c: Bug 1593170. Skip plugin-background-*-step.html when we do not have the test plugin. r=mattwoodrow
Timothy Nikkel <tnikkel@gmail.com> - Mon, 18 Nov 2019 00:51:00 +0000 - rev 502367
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1593170. Skip plugin-background-*-step.html when we do not have the test plugin. r=mattwoodrow These tests test that moving around the plugin causes it to still draw correctly. If we don't have the test plugin then they fail and are marked as such. The tests start by moving the plugin and then waiting for MozAfterPaint or MozPaintWaitFinished. When there is no plugin these events don't come. Without the test plugin this was working because they got an unrelated MozAfterPaint (it was probably one of the early paints of the page). After we update the reftest harness for fission and make it more async in general we no longer catch this early MozAfterPaint and the tests don't start. We should just skip them, there is nothing to test with a plugin. Differential Revision: https://phabricator.services.mozilla.com/D51347
2c8e57a90cb8dbe3763a6d26de0198aba1bcb75e: Bug 1593170. Skip 1553571-1.html reftest on android debug webrender. r=mattwoodrow
Timothy Nikkel <tnikkel@gmail.com> - Mon, 18 Nov 2019 00:50:47 +0000 - rev 502366
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1593170. Skip 1553571-1.html reftest on android debug webrender. r=mattwoodrow The changes to make the test harness avoid busy waiting with setTimeout(0)'s made this test fail on Android 8.0 debug webrender. In order to get an active layer the test tweaks a transform slightly that has no visual effect every 74 ms. This is necessary to test the bug as far as I can tell (I wrote the test). The test times out because MakeProgress never makes any progress, there is always an afterpaint pending or an after paint has fired and we need to update the canvas for it. The painting and running through the settimeouts etc of the reftest harness take slightly too long. Before the changes to remove the busy waits we were just barely passing this test, it took 76 seconds in once instance that I checked and hundreds of iterations before we could make progress. Haven't debugged exactly why removing the busywaits makes this fail but it doesn't seem important. Differential Revision: https://phabricator.services.mozilla.com/D52650
d511975b764e8f5e97c4511dc39c9aa103e30793: Bug 1593170. Check if contentRootElement is a dead wrapper before using it. r=mattwoodrow,dbaron
Timothy Nikkel <tnikkel@gmail.com> - Mon, 18 Nov 2019 00:49:07 +0000 - rev 502365
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1593170. Check if contentRootElement is a dead wrapper before using it. r=mattwoodrow,dbaron With the fission changes everything is more async, meaning some tests can run longer. Some crashtests navigate to a new location meaning the original root element we have a variable for is no longer around, and chrome isn't allowed to keep content nodes alive, so we are left holding a dead wrapper that throws if we try to access anything on it. So we check if contentRootElement has become a dead wrapper (and null it out) any time we try to access it and it could have become dead. Generally the existing code already handled a null contentRootElement. Differential Revision: https://phabricator.services.mozilla.com/D52829
a10072d821e51e633d96a86120595e37a49429c2: Bug 1593170. Avoid useless painting work in queued up rects to paint by ignoring new rects that are already covered. r=mattwoodrow
Timothy Nikkel <tnikkel@gmail.com> - Mon, 18 Nov 2019 00:45:46 +0000 - rev 502364
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1593170. Avoid useless painting work in queued up rects to paint by ignoring new rects that are already covered. r=mattwoodrow I don't think this is strictly necessary but it lets us avoid a bunch of useless work, especially with webrender where these rects are always the full window size. Differential Revision: https://phabricator.services.mozilla.com/D51346
80bd8cadf835988a4ea48084d80cf47eb4aa5b24: Bug 1593170. Adjust how we deal with the reftest events for async plugin drawing for the fission changes to the reftest harness. r=mattwoodrow
Timothy Nikkel <tnikkel@gmail.com> - Mon, 18 Nov 2019 00:45:33 +0000 - rev 502363
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1593170. Adjust how we deal with the reftest events for async plugin drawing for the fission changes to the reftest harness. r=mattwoodrow The long code comment explains. Differential Revision: https://phabricator.services.mozilla.com/D51345
a004de6493422688953b5b8ea2fc5e1522240f47: Bug 1593170. Make the reftest harness deal with SynchronizeForSnapshot and FlushRendering returning promises. r=mattwoodrow
Timothy Nikkel <tnikkel@gmail.com> - Mon, 18 Nov 2019 00:45:25 +0000 - rev 502362
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1593170. Make the reftest harness deal with SynchronizeForSnapshot and FlushRendering returning promises. r=mattwoodrow The code comment mostly explains the design. Basically, we force nothing to happen while we wait for the promises to finish and instead record what we need to do once the promise is finished, and do those pending tasks when it's finished. Differential Revision: https://phabricator.services.mozilla.com/D51344
78d380a2241afa5c60a90ac8ceca9b3108b99345: Bug 1593170. Make the reftest-content.js functions FlushRendering and SynchronizeForSnapshot work on Fission child oop iframes. r=mattwoodrow,kmag
Timothy Nikkel <tnikkel@gmail.com> - Mon, 18 Nov 2019 00:45:07 +0000 - rev 502361
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1593170. Make the reftest-content.js functions FlushRendering and SynchronizeForSnapshot work on Fission child oop iframes. r=mattwoodrow,kmag This changes them to return a promise that resolves when the work is done, but we still need to change the callers to handle this new return type and do the right thing when these functions do their work async-ly. To do this we add a JSWindowActor called ReftestFission. reftest-content.js communicates with this actor via reftest.jsm. Differential Revision: https://phabricator.services.mozilla.com/D51343
2909f92bb59434929217c1510b991ef7ed88314c: Bug 1588241 - P9. Make ChannelEventQueue::PrependEvents infallible. r=mattwoodrow
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 15 Nov 2019 05:35:28 +0000 - rev 502322
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1588241 - P9. Make ChannelEventQueue::PrependEvents infallible. r=mattwoodrow nsTArray::InsertElementsAt is infallible. So the test checking that nullptr wasn't returned would always be false. Seeing that queuing an event is also an infallible operation, there's no point for prepentEvents to be. Differential Revision: https://phabricator.services.mozilla.com/D53115
b9737a17de366f287072fec20ae5dcbc14bfad50: Bug 1596052. If the SendUpdateCanvasForEvent call is for a previous test then ignore it. r=mattwoodrow
Timothy Nikkel <tnikkel@gmail.com> - Fri, 15 Nov 2019 22:41:19 +0000 - rev 502299
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1596052. If the SendUpdateCanvasForEvent call is for a previous test then ignore it. r=mattwoodrow This is basically what we did in bug 1593171 (Protect against the same test from calling RecordResult more than once in the reftest harness) where we early exit in SendInitCanvasWithSnapshot. But now we do it in SendUpdateCanvasForEvent too because SendUpdateCanvasForEvent calls SynchronizeForSnapshot which calls setupAsyncScrollOffsets and setupAsyncZoom, both of which get the documentElement of the current doc and operate on it. The problem is that this could be SendUpdateCanvasForEvent call from the previous test operating on the dom of the current test. I haven't actually observed this, just noticed it while implementing checking of contentRootElement to make sure all cases are covered. Differential Revision: https://phabricator.services.mozilla.com/D52827
0ba862a839d190ce4c443e4db2f5788aeeea97ad: Bug 1588241 - P8. Use NeckoTargetChannelFunctionEvent with FTPChannelChild. r=mattwoodrow
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 15 Nov 2019 02:42:20 +0000 - rev 502109
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1588241 - P8. Use NeckoTargetChannelFunctionEvent with FTPChannelChild. r=mattwoodrow Fix style consistency while at it and a couple of constness issues. Differential Revision: https://phabricator.services.mozilla.com/D52505
693144fd8c54c51f442ca4741aa484d1f3795747: Bug 1588241 - P7. Use NeckoTargetChannelFunctionEvent in DCC. r=mattwoodrow
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 15 Nov 2019 02:42:18 +0000 - rev 502108
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1588241 - P7. Use NeckoTargetChannelFunctionEvent in DCC. r=mattwoodrow Differential Revision: https://phabricator.services.mozilla.com/D52503
c70d60f8293ca2996cde6384af2a0f9bc5311e9c: Bug 1588241 - P6. Disable test under fission. r=mattwoodrow
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 15 Nov 2019 02:42:10 +0000 - rev 502107
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1588241 - P6. Disable test under fission. r=mattwoodrow And amend comment on other bugs failing for the same reasons, linking to bug that is the cause. Differential Revision: https://phabricator.services.mozilla.com/D52306
354253d41c6adfc68a08248cce9fd1e74f952a4d: Bug 1588241 - P5. Re-enable tests. r=mattwoodrow
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 15 Nov 2019 02:42:08 +0000 - rev 502106
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1588241 - P5. Re-enable tests. r=mattwoodrow This reverts bug 1590608 and bug 1590649. Differential Revision: https://phabricator.services.mozilla.com/D52264
e9ca1ee307d6f259951dd6c541e3d2e4f8ed6991: Bug 1588241 - P4. Remove nsIClassifiedChannel implementation from DocumentChannelChild. r=mattwoodrow
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 15 Nov 2019 02:42:06 +0000 - rev 502105
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1588241 - P4. Remove nsIClassifiedChannel implementation from DocumentChannelChild. r=mattwoodrow The information is now passed to the parent channel once replacement is completed. Differential Revision: https://phabricator.services.mozilla.com/D52263
2a6684436b37e2dff61a160105790e0a44d1c655: Bug 1588241 - P1. Use move semantics with PrependEvent. r=mattwoodrow
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 15 Nov 2019 02:41:59 +0000 - rev 502102
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1588241 - P1. Use move semantics with PrependEvent. r=mattwoodrow PrepentEvent was already moving the argument passed by reference. This makes it clear that the object will be moved. Differential Revision: https://phabricator.services.mozilla.com/D52260
fa6c87627ec8d357de398ebdbb05bc03399b8df4: Bug 1596330 - Remove CrossProcessRedirectDone and FinishCrossProcessSwitch r=mattwoodrow
Paul Bone <pbone@mozilla.com> - Thu, 14 Nov 2019 08:43:06 +0000 - rev 502083
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1596330 - Remove CrossProcessRedirectDone and FinishCrossProcessSwitch r=mattwoodrow Depends on D52950 Differential Revision: https://phabricator.services.mozilla.com/D52951
f406de07f131f6478b7d012f3534021698331f74: Bug 1596330 - Remove mDoingCrossProcessRedirect r=mattwoodrow
Paul Bone <pbone@mozilla.com> - Thu, 14 Nov 2019 08:43:06 +0000 - rev 502082
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1596330 - Remove mDoingCrossProcessRedirect r=mattwoodrow Depends on D52949 Differential Revision: https://phabricator.services.mozilla.com/D52950
f1b88c7e983e1aacb8897ac1a2858b6af1514e82: Bug 1596330 - Remove dead process switching code r=mattwoodrow
Paul Bone <pbone@mozilla.com> - Thu, 14 Nov 2019 08:43:05 +0000 - rev 502081
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1596330 - Remove dead process switching code r=mattwoodrow Differential Revision: https://phabricator.services.mozilla.com/D52949
d21a794140eaf8f83113afa6346d352596292e9b: Bug 1593545 - Disable DocumentChannel assertion in non-fission mode r=mattwoodrow
Paul Bone <pbone@mozilla.com> - Thu, 14 Nov 2019 00:12:58 +0000 - rev 501915
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1593545 - Disable DocumentChannel assertion in non-fission mode r=mattwoodrow Differential Revision: https://phabricator.services.mozilla.com/D52804
d4c8a1b56b1ad44c9222fb78a470a5f4bc3b6423: Bug 1593545 - Disable DocumentChannel assertion in non-fission mode r=mattwoodrow
Paul Bone <pbone@mozilla.com> - Thu, 14 Nov 2019 00:12:58 +0000 - rev 501861
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1593545 - Disable DocumentChannel assertion in non-fission mode r=mattwoodrow Differential Revision: https://phabricator.services.mozilla.com/D52804
fd2d5ef280f4501b8fe79c66f9011d6a73a10115: Bug 1596049. Calling CheckForProcessCrashExpectation needs to pass contentRootElement otherwise it does nothing. r=mattwoodrow
Timothy Nikkel <tnikkel@gmail.com> - Wed, 13 Nov 2019 23:15:39 +0000 - rev 501856
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1596049. Calling CheckForProcessCrashExpectation needs to pass contentRootElement otherwise it does nothing. r=mattwoodrow Depends on D52827 Differential Revision: https://phabricator.services.mozilla.com/D52828
628967f53151659cf2666e15d50f37fd80952d9a: Bug 1576390 - Remove now-unused DrawWindowOverlay and WindowOverlayChanged methods. r=mattwoodrow
Markus Stange <mstange@themasta.com> - Wed, 13 Nov 2019 02:24:06 +0000 - rev 501830
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1576390 - Remove now-unused DrawWindowOverlay and WindowOverlayChanged methods. r=mattwoodrow Differential Revision: https://phabricator.services.mozilla.com/D52748
fbab3b7be09261b604148655537ba0ff90d2a9fb: Bug 1576390 - Remove the prefs gfx.core-animation.enabled and gfx.compositor.glcontext.opaque, and all the code needed to support it. r=mattwoodrow,spohl
Markus Stange <mstange@themasta.com> - Wed, 13 Nov 2019 19:07:37 +0000 - rev 501829
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1576390 - Remove the prefs gfx.core-animation.enabled and gfx.compositor.glcontext.opaque, and all the code needed to support it. r=mattwoodrow,spohl Differential Revision: https://phabricator.services.mozilla.com/D52739
6a4727c44078f7eca99f39b72a6f8eab2752c3f0: Bug 1588241 - P8. Use NeckoTargetChannelFunctionEvent with FTPChannelChild. r=mattwoodrow
Jean-Yves Avenard <jyavenard@mozilla.com> - Tue, 12 Nov 2019 01:17:59 +0000 - rev 501698
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1588241 - P8. Use NeckoTargetChannelFunctionEvent with FTPChannelChild. r=mattwoodrow Fix style consistency while at it and a couple of constness issues. Depends on D52503 Differential Revision: https://phabricator.services.mozilla.com/D52505
125430c4316a188db6ce5b50da3ffdd99c4fc5aa: Bug 1588241 - P7. Use NeckoTargetChannelFunctionEvent in DCC. r=mattwoodrow
Jean-Yves Avenard <jyavenard@mozilla.com> - Tue, 12 Nov 2019 01:16:14 +0000 - rev 501697
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1588241 - P7. Use NeckoTargetChannelFunctionEvent in DCC. r=mattwoodrow Differential Revision: https://phabricator.services.mozilla.com/D52503
449606f22baf89dbd2ddd4fc537219c13907bd11: Bug 1588241 - P6. Disable test under fission. r=mattwoodrow
Jean-Yves Avenard <jyavenard@mozilla.com> - Mon, 11 Nov 2019 06:08:59 +0000 - rev 501696
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1588241 - P6. Disable test under fission. r=mattwoodrow And amend comment on other bugs failing for the same reasons, linking to bug that is the cause. Differential Revision: https://phabricator.services.mozilla.com/D52306
c9a6203582acc7285034ab684d1f844e2ddda108: Bug 1588241 - P5. Re-enable tests. r=mattwoodrow
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 08 Nov 2019 04:06:53 +0000 - rev 501695
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1588241 - P5. Re-enable tests. r=mattwoodrow This reverts bug 1590608 and bug 1590649. Depends on D52263 Differential Revision: https://phabricator.services.mozilla.com/D52264
48362412c9d583393fc81a551543499b4bf31039: Bug 1588241 - P4. Remove nsIClassifiedChannel implementation from DocumentChannelChild. r=mattwoodrow
Jean-Yves Avenard <jyavenard@mozilla.com> - Tue, 12 Nov 2019 23:35:20 +0000 - rev 501694
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1588241 - P4. Remove nsIClassifiedChannel implementation from DocumentChannelChild. r=mattwoodrow The information is now passed to the parent channel once replacement is completed. Depends on D52262 Differential Revision: https://phabricator.services.mozilla.com/D52263
17e7f137067f89c0d82cada3af77b1bc5161c547: Bug 1588241 - P1. Use move semantics with PrependEvent. r=mattwoodrow
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 07 Nov 2019 23:25:20 +0000 - rev 501691
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1588241 - P1. Use move semantics with PrependEvent. r=mattwoodrow PrepentEvent was already moving the argument passed by reference. This makes it clear that the object will be moved. Differential Revision: https://phabricator.services.mozilla.com/D52260
37b70cca0d2fafeb578520983bae2c0a5fd8e540: Bug 1585114 - Don't return shutdown pending processes from ContentParent::GetNewOrUsedBrowserProcess. r=mattwoodrow
Andrew McCreight <continuation@gmail.com> - Wed, 13 Nov 2019 01:16:10 +0000 - rev 501676
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1585114 - Don't return shutdown pending processes from ContentParent::GetNewOrUsedBrowserProcess. r=mattwoodrow ContentParent::GetNewOrUsedBrowserProcess can end up returning a content parent that is in the middle of shutting down if the nsIContentProcessProvider implementation threw an error because we'd fall back to MinTabSelect(), which didn't exclude content parents that were being shutdown. This patch fixes that. The reason that the existing implementations of nsIContentProcessProviders fail is that the array that is passed to them can contain null entries which the code does not expect. I'll fix that in a separate bug. Differential Revision: https://phabricator.services.mozilla.com/D52774
09005ea3861f549d6f4f613d1e83fe18fd13ebc8: Bug 1590782 - Switch process when InternalLoad finds oop BrowsingContext. r=mattwoodrow
Andreas Farre <farre@mozilla.com> - Tue, 12 Nov 2019 21:52:18 +0000 - rev 501670
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1590782 - Switch process when InternalLoad finds oop BrowsingContext. r=mattwoodrow Differential Revision: https://phabricator.services.mozilla.com/D50945
b4f592ebb7ec9ee9ed3751fb6e83e5dfed603b5f: Bug 1593291 - Remove unnecessary assert r=mattwoodrow
Miko Mynttinen <mikokm@gmail.com> - Mon, 11 Nov 2019 18:01:42 +0000 - rev 501492
Push 114170 by malexandru@mozilla.com at Tue, 12 Nov 2019 21:58:32 +0000
Bug 1593291 - Remove unnecessary assert r=mattwoodrow Differential Revision: https://phabricator.services.mozilla.com/D52395
aafdd02eb30a2dae68eefb1505083254634d8034: Bug 1588412 - Fix a spelling error r=mattwoodrow
Paul Bone <pbone@mozilla.com> - Mon, 04 Nov 2019 21:45:10 +0000 - rev 501448
Push 114170 by malexandru@mozilla.com at Tue, 12 Nov 2019 21:58:32 +0000
Bug 1588412 - Fix a spelling error r=mattwoodrow The already-landed patches contained a spelling error. This patch fixes it. Differential Revision: https://phabricator.services.mozilla.com/D51390
8df9e44645e481fbd3d0bff5f4cdab9fbd6ad8c1: Bug 1587960 - Replace StreamListenerParent's channel on internal redirects r=asuth,mattwoodrow,kmag
Perry Jiang <perry@mozilla.com> - Thu, 07 Nov 2019 23:56:47 +0000 - rev 501196
Push 114168 by dluca@mozilla.com at Sun, 10 Nov 2019 03:08:55 +0000
Bug 1587960 - Replace StreamListenerParent's channel on internal redirects r=asuth,mattwoodrow,kmag Differential Revision: https://phabricator.services.mozilla.com/D52101
8ff3fc3e27c5e5361fe2507efd8ff15e767fcc00: Bug 1590898 test encoding in webRequest.filterResponseData r=mattwoodrow
Shane Caraveo <scaraveo@mozilla.com> - Thu, 07 Nov 2019 20:00:41 +0000 - rev 501153
Push 114168 by dluca@mozilla.com at Sun, 10 Nov 2019 03:08:55 +0000
Bug 1590898 test encoding in webRequest.filterResponseData r=mattwoodrow Differential Revision: https://phabricator.services.mozilla.com/D52213
19ab4b56d21818d6ce77eeaed004063ee20d8728: Bug 1594236 - Use real result principal for DocumentChannel process selection, r=mattwoodrow
Nika Layzell <nika@thelayzells.com> - Wed, 06 Nov 2019 02:30:38 +0000 - rev 500868
Push 114166 by apavel@mozilla.com at Thu, 07 Nov 2019 10:04:01 +0000
Bug 1594236 - Use real result principal for DocumentChannel process selection, r=mattwoodrow Currently the logic for process selection extracts a URI from the principal, and uses that URI to perform process selection. This patch adds a codepath for passing the result principal through the remote type selection logic and using it directly. This should ideally improve the behaviour of URIs with less obvious origins, such as those which inherit their origin. Unfortunately, OriginAttributes are still ignored by process selection, due to some code using the fallback logic which is unaware of OAs. This should be fixed in the future. Differential Revision: https://phabricator.services.mozilla.com/D51942
b4ef304c1c6ba4ae9dcce9eddb14cdfe98ccf871: Bug 1590550 - Don't do the "simple display list" optimization when we have overflow clips. r=mattwoodrow
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 06 Nov 2019 12:17:26 +0000 - rev 500830
Push 114166 by apavel@mozilla.com at Thu, 07 Nov 2019 10:04:01 +0000
Bug 1590550 - Don't do the "simple display list" optimization when we have overflow clips. r=mattwoodrow The previous code tried to do it, but it did it wrongly, as the overflow clip comes from the parent, not the child. Thus when we change a style that influences it, we weren't invalidating the SIMPLE_DISPLAY_LIST bit, and such. Make the reftest that caught this fail more reliable. Differential Revision: https://phabricator.services.mozilla.com/D51805
bc1b0170ef111f043355bf2fe140ec940d4d065d: Bug 1590550 - Don't apply contain: paint inappropriately. r=mattwoodrow
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 06 Nov 2019 12:10:34 +0000 - rev 500829
Push 114166 by apavel@mozilla.com at Thu, 07 Nov 2019 10:04:01 +0000
Bug 1590550 - Don't apply contain: paint inappropriately. r=mattwoodrow This fixes css/css-contain/contain-paint-{002,012,024}.html when not using the fast path (i.e., with the following patch). Also invert the check in IsStackingContext as IsFrameOfType is a virtual method, and IsContain* is just a bitflag. Differential Revision: https://phabricator.services.mozilla.com/D51804
89e0d67e037b74f1e2ae8e9d7cbccc5a0f652397: Bug 1592826 - Expand Qualcom driver blacklist to cover new versions. r=mattwoodrow
Bryce Seager van Dyk <bvandyk@mozilla.com> - Tue, 05 Nov 2019 08:31:42 +0000 - rev 500760
Push 114166 by apavel@mozilla.com at Thu, 07 Nov 2019 10:04:01 +0000
Bug 1592826 - Expand Qualcom driver blacklist to cover new versions. r=mattwoodrow Recent Qualcom drivers are exhibiting the same issues as seen in previous versions when decoding video. Notably: - Crashes. - Green frames. This patch expands our black list to avoid these problems. Differential Revision: https://phabricator.services.mozilla.com/D51722
6400ccbce0a2a07049242aedc6748d1449c758e4: Bug 1590550 - Don't do the "simple display list" optimization when we have overflow clips. r=mattwoodrow
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 05 Nov 2019 20:55:40 +0000 - rev 500751
Push 114166 by apavel@mozilla.com at Thu, 07 Nov 2019 10:04:01 +0000
Bug 1590550 - Don't do the "simple display list" optimization when we have overflow clips. r=mattwoodrow The previous code tried to do it, but it did it wrongly, as the overflow clip comes from the parent, not the child. Thus when we change a style that influences it, we weren't invalidating the SIMPLE_DISPLAY_LIST bit, and such. Make the reftest that caught this fail more reliable. Differential Revision: https://phabricator.services.mozilla.com/D51805