searching for reviewer(mats)
4c34130cc58ff8d8efbbd2c1e8190f4982ee4223: Bug 1593796 - Apply the correct specified implicit size. r=mats
Boris Chiou <boris.chiou@gmail.com> - Tue, 12 Nov 2019 22:28:09 +0000 - rev 501675
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1593796 - Apply the correct specified implicit size. r=mats Per the spec, if multiple track sizes are given, the pattern is repeated as necessary to find the size of the implicit tracks: 1. The first implicit grid track after the explicit grid receives the first specified size, and so on forwards. 2. The last implicit grid track before the explicit grid receives the last specified size, and so on backwards. We use a positive index of the auto track sizes for (1) and a negative index for (2), so we can apply the correct specified implicit size. Differential Revision: https://phabricator.services.mozilla.com/D52265
1a85c571a4645798ba4d9295ba2504acac149ac8: Bug 1576946 - Remove nsStackFrame platform code. r=mats
Tim Nguyen <ntim.bugs@gmail.com> - Tue, 12 Nov 2019 19:50:19 +0000 - rev 501621
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1576946 - Remove nsStackFrame platform code. r=mats Differential Revision: https://phabricator.services.mozilla.com/D49487
68cc349414ca0ceb846fe0833a13a72df9fb4353: Bug 1576946 - Rewrite and remove tests relying on `display: -moz-stack;`. r=mats
Tim Nguyen <ntim.bugs@gmail.com> - Tue, 12 Nov 2019 19:50:06 +0000 - rev 501620
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1576946 - Rewrite and remove tests relying on `display: -moz-stack;`. r=mats Differential Revision: https://phabricator.services.mozilla.com/D49485
90da3a622fbfa8d4b6fd0a9c01c1915d5aacefd8: Bug 1593366 - Check default prevented status in nsListControlFrame::KeyDown. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 06 Nov 2019 12:53:53 +0000 - rev 500834
Push 114166 by apavel@mozilla.com at Thu, 07 Nov 2019 10:04:01 +0000
Bug 1593366 - Check default prevented status in nsListControlFrame::KeyDown. r=mats Differential Revision: https://phabricator.services.mozilla.com/D51982
47865c3e9794bdb4840dd31f2e5374c1f2c5fd57: Bug 1526268 Part 3 - Disable APZ if AccessibleCaret is in position:fixed subtree or its position is changed. r=botond,mats
Ting-Yu Lin <tlin@mozilla.com> - Sat, 02 Nov 2019 03:05:28 +0000 - rev 500280
Push 114164 by aiakab@mozilla.com at Tue, 05 Nov 2019 10:06:15 +0000
Bug 1526268 Part 3 - Disable APZ if AccessibleCaret is in position:fixed subtree or its position is changed. r=botond,mats In common cases where the caret is in a position:static frame subtree, the caret's position (relative to canvas frame's custom content container) should not be changed during scrolling. However, when the caret is in a position:fixed or "stuck" position:sticky frame subtree, the caret's position will change during scrolling. We need to disable APZ to avoid jumpy carets. Differential Revision: https://phabricator.services.mozilla.com/D51351
bad5d7c12e6b7a6a2cb451d88545e4eefe9ad6d5: Bug 1526268 Part 2 - Fix the logic to detect whether AccessibleCaret's position is changed. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Fri, 01 Nov 2019 22:19:18 +0000 - rev 500279
Push 114164 by aiakab@mozilla.com at Tue, 05 Nov 2019 10:06:15 +0000
Bug 1526268 Part 2 - Fix the logic to detect whether AccessibleCaret's position is changed. r=mats This is the main patch to fix bug 1526268. It is wrong to use the cached rects relative to the root frame (ViewportFrame) to detect whether AccessibleCaret's position is changed or not, because it doesn't account the root scroll frame's scroll offset. The effect is that we always produce "PositionChangedResult::Changed" when scrolling on position:static elements, but "PositionChangedResult::NotChanged" on position:fixed elements. This patch fixes this by using the rect relative to custom content container, which is the actually rect to set caret's position, to check whether the position is changed or not. Note that even with this patch, the caret on "position:fixed" element is still jumpy during scrolling due to APZ. Part 3 will fixed this. Differential Revision: https://phabricator.services.mozilla.com/D51350
4440195bda021a88e204a18040e37fd04cedc5ee: Bug 1526268 Part 1 - Make AccessibleCaret's #text-overlay and #image children be normal in-flow elements. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Fri, 01 Nov 2019 22:16:08 +0000 - rev 500278
Push 114164 by aiakab@mozilla.com at Tue, 05 Nov 2019 10:06:15 +0000
Bug 1526268 Part 1 - Make AccessibleCaret's #text-overlay and #image children be normal in-flow elements. r=mats The #text-overlay and #image child divs were "position: absolute" under the main AccessibleCaret div. However, they don't necessary need to be position:absolute to achieve the desired layout. We can make them normal in-flow elements to simplify the frame structure. There should not be any perceivable change to the user. Also, AccessibleCaret's position can made more accurate by using float CSS pixels when converting it from app unit. Differential Revision: https://phabricator.services.mozilla.com/D51349
caf41ea01dae1ffcdda35fa9fd22c48cdbd90612: Bug 1591282 - Add an easier way to skip tests for debugging in tests_reftests_with_caret.html. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 26 Oct 2019 19:54:47 +0000 - rev 499592
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1591282 - Add an easier way to skip tests for debugging in tests_reftests_with_caret.html. r=mats I always end up writing some variation of this for local debugging. Differential Revision: https://phabricator.services.mozilla.com/D50702
5ea7c20012edd1f466f1839d0c8a8d966c4e2f40: Bug 1584018 - Make flex and grid code indicate that its block resizes can affect basis for percentages. r=dholbert,mats
L. David Baron <dbaron@dbaron.org> - Thu, 24 Oct 2019 22:35:46 +0000 - rev 499192
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1584018 - Make flex and grid code indicate that its block resizes can affect basis for percentages. r=dholbert,mats Differential Revision: https://phabricator.services.mozilla.com/D50511
4049249a2c9f8d436ccd86ea37f17ceb0f09e7d0: Bug 1590897 - Remove support for XUL <spring> element. r=mats
Tim Nguyen <ntim.bugs@gmail.com> - Thu, 24 Oct 2019 14:55:25 +0000 - rev 499107
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1590897 - Remove support for XUL <spring> element. r=mats Differential Revision: https://phabricator.services.mozilla.com/D50440
2a548b23c4d5b4399a64c117db288af75ad96a5e: Bug 1590903 - Remove support for XUL <text> element. r=mats
Tim Nguyen <ntim.bugs@gmail.com> - Thu, 24 Oct 2019 06:23:10 +0000 - rev 499051
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1590903 - Remove support for XUL <text> element. r=mats Differential Revision: https://phabricator.services.mozilla.com/D50368
c728e613e0e49949658328cab52cb04118a7bd4f: Bug 1588486 - Fix whitespace skipping inside inlines to handle display: contents correctly. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 14 Oct 2019 17:38:43 +0000 - rev 497531
Push 114152 by dvarga@mozilla.com at Tue, 15 Oct 2019 11:14:34 +0000
Bug 1588486 - Fix whitespace skipping inside inlines to handle display: contents correctly. r=mats This also unifies the code a bit more. Differential Revision: https://phabricator.services.mozilla.com/D49139
6d9868605ef242caa488674ac86fda4ca004bb0e: Bug 1588486 - Don't generate frames for children display: contents is used within SVG text. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 14 Oct 2019 17:38:41 +0000 - rev 497530
Push 114152 by dvarga@mozilla.com at Tue, 15 Oct 2019 11:14:34 +0000
Bug 1588486 - Don't generate frames for children display: contents is used within SVG text. r=mats The TextNodeCorrespondenceRecorder stuff doesn't handle display: contents or Shadow DOM at all. This causes a failure with an upcoming patch. This patch fixes it and fixes related crashes like bug 1563779. This is the same wallpaper as bug 1421807. Differential Revision: https://phabricator.services.mozilla.com/D49138
36ab7b5bb1859ce4c084f8ee9e52aa1d381e769f: Bug 1581467 - Fix checks for display: inline{,-block} which don't account for inline list items. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 12 Oct 2019 21:05:16 +0000 - rev 497355
Push 114148 by shindli@mozilla.com at Mon, 14 Oct 2019 10:49:50 +0000
Bug 1581467 - Fix checks for display: inline{,-block} which don't account for inline list items. r=mats Differential Revision: https://phabricator.services.mozilla.com/D48346
a0f1057c6f5042b1c80f411a9208a18b46b710cd: Bug 1578844 - Fix various issues with display: contents within svg text. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 12 Oct 2019 16:28:13 +0000 - rev 497346
Push 114148 by shindli@mozilla.com at Mon, 14 Oct 2019 10:49:50 +0000
Bug 1578844 - Fix various issues with display: contents within svg text. r=mats I'm not happy about all the SVG text / disallow out of flow complexity sprinkled during frame construction... :( Maybe we should add some kind of more generic mechanism to disallow some children for particular kinds of frames, or something. Co-authored-by: Mats Palmgren <mats@mozilla.com> Differential Revision: https://phabricator.services.mozilla.com/D44808
e9783a644016aa9b317887076618425586730d73: Bug 1168921 - Stop cloning block direction margins for box-decoration-break:clone. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Thu, 10 Oct 2019 13:38:07 +0000 - rev 497153
Push 114148 by shindli@mozilla.com at Mon, 14 Oct 2019 10:49:50 +0000
Bug 1168921 - Stop cloning block direction margins for box-decoration-break:clone. r=mats This can also fix bug 1586470. This change basically reverts Bug 1025669 Part 1. https://hg.mozilla.org/mozilla-central/rev/ae2fd5b2defb0df1bd30521f4793de6757d1e98b In box-decoration-break-block-margin.html, the `height` in `.inner` is changed to 79px so that 79px plus 7px margin top and 1px margin end, total 87px, can be divided by 3 (columns). The modification to reference file reflects what we currently rendered. Co-authored-by: Mats Palmgren <mats@mozilla.com> Differential Revision: https://phabricator.services.mozilla.com/D48484
0ef0c5a2e38a7e62573018b3f4049279fe9b5b12: Bug 1581467 - Use DisplayInside() / DisplayOutside() a bit more. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 07 Oct 2019 12:27:27 +0000 - rev 496565
Push 114145 by apavel@mozilla.com at Tue, 08 Oct 2019 11:00:56 +0000
Bug 1581467 - Use DisplayInside() / DisplayOutside() a bit more. r=mats And remove some unused display values from the C++ bindings. Differential Revision: https://phabricator.services.mozilla.com/D45974
985e7a586265c3b74b695849812c1d658eb2e135: Bug 1584492 - Add mPIPWindow to nsWidgetInitData and set it for PIP window on Linux/Gtk, r=mats
Martin Stransky <stransky@redhat.com> - Sat, 28 Sep 2019 06:55:41 +0000 - rev 495480
Push 114134 by ccoroiu@mozilla.com at Mon, 30 Sep 2019 09:57:15 +0000
Bug 1584492 - Add mPIPWindow to nsWidgetInitData and set it for PIP window on Linux/Gtk, r=mats Differential Revision: https://phabricator.services.mozilla.com/D47409
7eb6fa2d58d0cf3bee4bc10673f9c6500f35a30b: Bug 1584492 - Add mPIPWindow to nsWidgetInitData and set it for PIP window on Linux/Gtk, r=mats
Martin Stransky <stransky@redhat.com> - Fri, 27 Sep 2019 12:36:30 +0000 - rev 495372
Push 114134 by ccoroiu@mozilla.com at Mon, 30 Sep 2019 09:57:15 +0000
Bug 1584492 - Add mPIPWindow to nsWidgetInitData and set it for PIP window on Linux/Gtk, r=mats Differential Revision: https://phabricator.services.mozilla.com/D47409
70ff507dae3b006b112c4458f40e5082db6fbdf1: Bug 1584187: Pass an assertion-only variable to mozilla::Unused, to fix non-nightly opt build error. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 26 Sep 2019 21:11:33 +0000 - rev 495268
Push 114134 by ccoroiu@mozilla.com at Mon, 30 Sep 2019 09:57:15 +0000
Bug 1584187: Pass an assertion-only variable to mozilla::Unused, to fix non-nightly opt build error. r=mats Differential Revision: https://phabricator.services.mozilla.com/D47319
c154d38e2741b2a2c7ed4a70e58e43b40204dbf9: Bug 1553772 - Bug 1549812 - Try to assert a bit harder about stuff not flushing under our nose. r=TYLin,mats
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 26 Sep 2019 20:55:58 +0000 - rev 495255
Push 114134 by ccoroiu@mozilla.com at Mon, 30 Sep 2019 09:57:15 +0000
Bug 1553772 - Bug 1549812 - Try to assert a bit harder about stuff not flushing under our nose. r=TYLin,mats I think these should hold, everything that runs under them should just schedule other stuff to some later date: * Synth mouse events -> scheduled as refresh driver observers. * Scroll events -> Scheduled as well. * Caret state change events -> Also scheduled after last patch. * IME and accessibility stuff -> I don't think they can reenter layout. We can always revert this if it causes troubles, plus it shouldn't crash on release so should be fine. Differential Revision: https://phabricator.services.mozilla.com/D31090
e79b84e42250763cf51680a7314d614ad0e3006f: Bug 1582819: Add diagnostic assert to catch positioned elements with display:-moz-box or -moz-inline-box that were previously blockified to 'block' but won't be anymore. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 25 Sep 2019 20:38:55 +0000 - rev 494997
Push 114131 by dluca@mozilla.com at Thu, 26 Sep 2019 09:47:34 +0000
Bug 1582819: Add diagnostic assert to catch positioned elements with display:-moz-box or -moz-inline-box that were previously blockified to 'block' but won't be anymore. r=mats Differential Revision: https://phabricator.services.mozilla.com/D46681
cc64c7f364b796a1696a7012822c3b7af7dfea15: Bug 1472328 - Check if we're already at the end of the frame's content. r=mats
Jonathan Kew <jkew@mozilla.com> - Mon, 16 Sep 2019 19:07:00 +0000 - rev 494251
Push 114114 by dluca@mozilla.com at Fri, 20 Sep 2019 22:00:08 +0000
Bug 1472328 - Check if we're already at the end of the frame's content. r=mats Differential Revision: https://phabricator.services.mozilla.com/D45924
088c878f9f7cb9c8033f35bf591f246754048f87: Bug 1580302: Treat all flex items and grid items as being block-level in ReflowInput::InitConstraints. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 19 Sep 2019 23:43:55 +0000 - rev 494242
Push 114114 by dluca@mozilla.com at Fri, 20 Sep 2019 22:00:08 +0000
Bug 1580302: Treat all flex items and grid items as being block-level in ReflowInput::InitConstraints. r=mats In particular: in our frontend code, if we happen to end up with a flex/grid item with 'display:-moz-box', we want it to take the same sizing codepath as other flex/grid items, which are all block-level (even though -moz-box is not exactly block-level itself). Notably, we want to use ComputeSizeFlags::eDefault for sizing (like we do for real block-level things), because that's necessary in order for grid items to stretch correctly in their inline axis. Also: this patch renames "isBlock" to "isBlockLevel" to reflect reality. Its naming is based on the constant NS_CSS_FRAME_TYPE_BLOCK, which in fact is not specific to 'display:block' but in fact is for frames that are "block-level in normal flow" (which I think in practice means block-level and not out-of-flow). That is documented here: https://searchfox.org/mozilla-central/rev/7531325c8660cfa61bf71725f83501028178cbb9/layout/generic/ReflowInput.h#51 Differential Revision: https://phabricator.services.mozilla.com/D46539
4dc6ff8d58b31c747e519abcbe01270d01d66636: Bug 1241631 - Add more whitespace-at-soft-break examples (based on Testcase #2) to the WPT innerText getter test. r=mats
Jonathan Kew <jkew@mozilla.com> - Tue, 17 Sep 2019 19:58:24 +0000 - rev 493636
Push 114097 by malexandru@mozilla.com at Wed, 18 Sep 2019 10:10:26 +0000
Bug 1241631 - Add more whitespace-at-soft-break examples (based on Testcase #2) to the WPT innerText getter test. r=mats Depends on D45159 Differential Revision: https://phabricator.services.mozilla.com/D46186
040bfa810af65f76dd002cb0da45ba052a9376c5: Bug 1241631 - Add reftest for bug in innerText with soft-wrapped text and word-break:break-all. r=mats
Jonathan Kew <jkew@mozilla.com> - Tue, 17 Sep 2019 17:28:20 +0000 - rev 493635
Push 114097 by malexandru@mozilla.com at Wed, 18 Sep 2019 10:10:26 +0000
Bug 1241631 - Add reftest for bug in innerText with soft-wrapped text and word-break:break-all. r=mats Differential Revision: https://phabricator.services.mozilla.com/D45159
fa06e1da9426398247c5fd0583755c1b03c04fcb: Bug 1241631 - Don't trim leading whitespace from soft-wrapped lines when getting rendered text for a11y or .innerText. r=mats
Jonathan Kew <jkew@mozilla.com> - Tue, 17 Sep 2019 17:36:13 +0000 - rev 493634
Push 114097 by malexandru@mozilla.com at Wed, 18 Sep 2019 10:10:26 +0000
Bug 1241631 - Don't trim leading whitespace from soft-wrapped lines when getting rendered text for a11y or .innerText. r=mats Differential Revision: https://phabricator.services.mozilla.com/D45157
fa3d10d81e6464ce82af7947144699aea61d15ed: Bug 1092007 followup: fix typo in code comment. rs=mats via review feedback
Daniel Holbert <dholbert@cs.stanford.edu> - Fri, 13 Sep 2019 21:53:18 +0000 - rev 493231
Push 114084 by btara@mozilla.com at Sat, 14 Sep 2019 21:30:15 +0000
Bug 1092007 followup: fix typo in code comment. rs=mats via review feedback DONTBUILD because this is comment-only. This patch is just addressing a typo in a code comment that was left as a review nit, which I forgot to address before landing. Differential Revision: https://phabricator.services.mozilla.com/D45907
febaeac334c49e9776101c53558ff04a0d80b4e3: Bug 1580556 - Remove the xul/grid/examples folder;r=mats
Brian Grinstead <bgrinstead@mozilla.com> - Wed, 11 Sep 2019 18:35:06 +0000 - rev 492717
Push 114071 by ncsoregi@mozilla.com at Thu, 12 Sep 2019 06:16:52 +0000
Bug 1580556 - Remove the xul/grid/examples folder;r=mats Differential Revision: https://phabricator.services.mozilla.com/D45564
82faf6a9be5064f5629bdc7634e4926686e61732: Bug 1578133 - Make nsBox get theme from the nsPresContext. r=mats
Cameron McCormack <cam@mcc.id.au> - Mon, 09 Sep 2019 00:08:59 +0000 - rev 492164
Push 114045 by shindli@mozilla.com at Mon, 09 Sep 2019 10:00:00 +0000
Bug 1578133 - Make nsBox get theme from the nsPresContext. r=mats Differential Revision: https://phabricator.services.mozilla.com/D44344
55e700b5f42e46e43f699936c2b998d7a4807955: Bug 1092007 part 2: Treat a flex item's main-size as indefinite if the item and the container both have an indefinite size in that axis. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 04 Sep 2019 22:45:08 +0000 - rev 491899
Push 114036 by nerli@mozilla.com at Fri, 06 Sep 2019 09:46:47 +0000
Bug 1092007 part 2: Treat a flex item's main-size as indefinite if the item and the container both have an indefinite size in that axis. r=mats Flex containers resolve a main-axis size for each of their flex items, and they impose this size on the flex items by stomping on the items' ReflowInput::ComputedISize() or ComputedBSize() data. For cases when we're stomping on the flex item's block-axis, then this can make us improperly treat this size as definite (i.e. use it for percent resolution). The flexbox spec does call out some cases where the item's size *is* supposed to be considered definite[1], but if we're not in one of those cases, we need to be careful to treat the size as indefinite even though it's been resolved. This patch achieves this by: - adding a flag to FlexItem, which gets set in cases where we know we need to treat the size as indefinite. - adding a flag to ReflowInput, which gets set whenever a ComputedBSize is imposed (if the FlexItem had its flag set). - adding some code to the ReflowInput percent-resolution codepath to test for this flag and skip past percent-resolution if it's set. This patch makes us pass all of the existing testcases in the web-platform-test "percentage-heights-003.html". This patch also adds a few more subtests there to exercise cases where the flex container and item have orthogonal writing-modes. (Note the XXXdholbert comments in the patch about items being "fully inflexible" in some cases in order to be treated as having a definite size. If I were to address that comment here, then we would start failing the web-platform-test "percentage-heights-005.html", which all browsers currently pass[2]. Therefore, I'm not adding that restriction at this point.) [1] https://drafts.csswg.org/css-flexbox/#definite-sizes [2] https://wpt.fyi/results/css/css-flexbox/percentage-heights-005.html Differential Revision: https://phabricator.services.mozilla.com/D43705
dc39c5293563d3f78bb404512845078e23c033c4: Bug 1578295 - Use cbindgen for counters. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 02 Sep 2019 23:11:26 +0000 - rev 491408
Push 114022 by rmaries@mozilla.com at Tue, 03 Sep 2019 15:49:32 +0000
Bug 1578295 - Use cbindgen for counters. r=mats Differential Revision: https://phabricator.services.mozilla.com/D44403
776f100fead626a135489e8a5373b237c1691c2f: Bug 1563163 Part 2: Downgrade an assert to a warning in nsFlexContainerFrame::GetFlexFrameWithComputedInfo. r=mats
Brad Werth <bwerth@mozilla.com> - Fri, 30 Aug 2019 23:16:44 +0000 - rev 490964
Push 114010 by dluca@mozilla.com at Sat, 31 Aug 2019 09:58:00 +0000
Bug 1563163 Part 2: Downgrade an assert to a warning in nsFlexContainerFrame::GetFlexFrameWithComputedInfo. r=mats Differential Revision: https://phabricator.services.mozilla.com/D44284
5119f09d6b99ac8b9f27ee676e8dc7acdfb02815: Bug 1563163 Part 1: Make Flex::Flex gracefully handle frames without FlexContainerInfo structures. r=mats
Brad Werth <bwerth@mozilla.com> - Fri, 30 Aug 2019 23:16:09 +0000 - rev 490963
Push 114010 by dluca@mozilla.com at Sat, 31 Aug 2019 09:58:00 +0000
Bug 1563163 Part 1: Make Flex::Flex gracefully handle frames without FlexContainerInfo structures. r=mats Differential Revision: https://phabricator.services.mozilla.com/D44283
f7ff76e196bdb37607020bf9fc5db4ef8818fcf6: Bug 1577745 - Remove dead version of nsStyleDisplay::IsOriginalDisplayInlineOutside. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 30 Aug 2019 13:21:42 +0000 - rev 490855
Push 114006 by malexandru@mozilla.com at Fri, 30 Aug 2019 22:01:27 +0000
Bug 1577745 - Remove dead version of nsStyleDisplay::IsOriginalDisplayInlineOutside. r=mats SVG Text stuff doesn't support abspos or anything like that, so it's not like it is useful. Differential Revision: https://phabricator.services.mozilla.com/D44136
64140fe11fc2ba22bc1b27adca94c847a61a9cb9: Bug 1576194 - Remove kDisplayKTable. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 23 Aug 2019 15:52:05 +0000 - rev 489759
Push 113964 by dluca@mozilla.com at Sat, 24 Aug 2019 21:59:36 +0000
Bug 1576194 - Remove kDisplayKTable. r=mats It doesn't represent anything useful anymore. Differential Revision: https://phabricator.services.mozilla.com/D43262
3db1abb6e436926e67d3dedefeed38fbb1faca01: Bug 1481112 - Be consistent on which properties we allow to inherit through for input, textarea, button and select, for compat with other UAs. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 23 Aug 2019 13:24:05 +0000 - rev 489651
Push 113958 by dvarga@mozilla.com at Fri, 23 Aug 2019 21:54:58 +0000
Bug 1481112 - Be consistent on which properties we allow to inherit through for input, textarea, button and select, for compat with other UAs. r=mats There should be no change in behavior for <input> and <textarea>. Tests need to be written for <button> and <select>. Tests are at https://github.com/web-platform-tests/wpt/pull/17152 Differential Revision: https://phabricator.services.mozilla.com/D43221
91d88ae893e790b1a3a9df5aebf87fa3ff02b29a: Bug 1574544 - Remove now-unnecessary condition that makes the frame constructor get confused with editor anonymous nodes. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 19 Aug 2019 12:16:28 +0000 - rev 488711
Push 113920 by aciure@mozilla.com at Mon, 19 Aug 2019 16:15:07 +0000
Bug 1574544 - Remove now-unnecessary condition that makes the frame constructor get confused with editor anonymous nodes. r=mats This condition was needed when FindInsertionPrevSibling and co didn't understand display: contents. Editor is pretty broken (and calls into PresShell::ContentRemoved directly, and incorrectly, using anonymous nodes). In this case we were taking the XBL path because of display: contents, which means that we tried to seek to the editor anonymous node, and crash (since it's not an explicit kid). Editor needs to get fixed, but this is technically more correct and fixes the crash, so we may as well take it in the interim. Differential Revision: https://phabricator.services.mozilla.com/D42472
9798b876061ebbc28eb23ab5d456c094855a4ce9: Bug 1574101 - Use the right parent frame for `block ruby` if it's out of flow. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 15 Aug 2019 22:21:35 +0000 - rev 488368
Push 113906 by ncsoregi@mozilla.com at Fri, 16 Aug 2019 04:07:24 +0000
Bug 1574101 - Use the right parent frame for `block ruby` if it's out of flow. r=mats I should've caught this when reviewing, in fairness. Differential Revision: https://phabricator.services.mozilla.com/D42163
4d8eb840fc2eaa37f6e75e5a5f2e8863beeccf19: Bug 1574101 - Use the right parent frame for `block ruby` if it's out of flow. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 15 Aug 2019 21:14:34 +0000 - rev 488353
Push 113906 by ncsoregi@mozilla.com at Fri, 16 Aug 2019 04:07:24 +0000
Bug 1574101 - Use the right parent frame for `block ruby` if it's out of flow. r=mats I should've caught this when reviewing, in fairness. Differential Revision: https://phabricator.services.mozilla.com/D42163
0bc9d6bfeb5a08b9dfe2f03c897e564478982e36: Bug 1573907 - Make non-list-items not increment the start value for <ol reversed>. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 15 Aug 2019 09:54:21 +0000 - rev 488212
Push 113904 by ncsoregi@mozilla.com at Thu, 15 Aug 2019 19:41:00 +0000
Bug 1573907 - Make non-list-items not increment the start value for <ol reversed>. r=mats Differential Revision: https://phabricator.services.mozilla.com/D42084
a9bdb526a7a01e0984c2bf8c888e8d8ffc69c5c4: Bug 1573907 - Fix interaction of <li value> inside <ol reversed>. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 15 Aug 2019 09:52:28 +0000 - rev 488211
Push 113904 by ncsoregi@mozilla.com at Thu, 15 Aug 2019 19:41:00 +0000
Bug 1573907 - Fix interaction of <li value> inside <ol reversed>. r=mats The counting code was incrementing the start counter twice for <li value>, as it generates both an increment and a reset. We should instead only increment it once per list-item, that is, once per increment. Differential Revision: https://phabricator.services.mozilla.com/D42001
ad04c84153da637000c7a472ccbc248116b5c330: Bug 1571764 - Subtract combobox display frame border-padding when inferring the height from line-height. r=mats,jfkthame
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 15 Aug 2019 09:41:15 +0000 - rev 488209
Push 113904 by ncsoregi@mozilla.com at Thu, 15 Aug 2019 19:41:00 +0000
Bug 1571764 - Subtract combobox display frame border-padding when inferring the height from line-height. r=mats,jfkthame This fixes it and seems to be an acceptable fix... Should I make it conditional on box-sizing: border-box for completeness? The display frame has border-box box-sizing, and not having it would be a bug, I'd think... Differential Revision: https://phabricator.services.mozilla.com/D41939
bd44d2dd0c02c1e2ab10e73695ee3ef1da971aa6: Bug 1571764 - Subtract combobox display frame border-padding when inferring the height from line-height. r=mats,jfkthame
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 14 Aug 2019 16:06:46 +0000 - rev 488055
Push 113900 by cbrindusan@mozilla.com at Thu, 15 Aug 2019 09:53:50 +0000
Bug 1571764 - Subtract combobox display frame border-padding when inferring the height from line-height. r=mats,jfkthame This fixes it and seems to be an acceptable fix... Should I make it conditional on box-sizing: border-box for completeness? The display frame has border-box box-sizing, and not having it would be a bug, I'd think... Differential Revision: https://phabricator.services.mozilla.com/D41939
4e4bb211b6733d7a9d710118fe58834f631152a4: Bug 1339672 - Support multiple track sizes for grid-auto-{columns|rows}. r=emilio,mats
Boris Chiou <boris.chiou@gmail.com> - Tue, 06 Aug 2019 18:32:16 +0000 - rev 486606
Push 113849 by aciure@mozilla.com at Wed, 07 Aug 2019 04:39:23 +0000
Bug 1339672 - Support multiple track sizes for grid-auto-{columns|rows}. r=emilio,mats Support `<track-size>+` on the implicit track sizing properties, grid-auto-columns and grid-auto-rows. Differential Revision: https://phabricator.services.mozilla.com/D38408
a1eb75e785ded866d66184c8b59b5a5b907a34fb: Bug 1519958 - Refactor grid types to preserve repeat() at computed value time and use cbindgen. r=mats,boris
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 28 Jun 2019 13:27:19 +0200 - rev 486434
Push 113840 by dluca@mozilla.com at Tue, 06 Aug 2019 09:43:33 +0000
Bug 1519958 - Refactor grid types to preserve repeat() at computed value time and use cbindgen. r=mats,boris I'm _really_ sorry for the size of the patch. I tried to do this in two steps but it was a lot of work and pretty ugly. This patch makes us use cbindgen for grid-template-{rows,columns}, in order to: * Make us preserve repeat() at computed-value time. This is per spec since interpolation needs to know about repeat(). Except for subgrid, which did the repeat expansion at parse-time and was a bit more annoying (plus it doesn't really animate yet so we don't need it to comply with the spec). * Tweaks the WPT tests for interpolation to adopt the resolution at: https://github.com/w3c/csswg-drafts/issues/3503. Trade-off here, as this patch stands, is that this change makes us use less long-living memory, since we expand repeat() during layout, but at the cost of a bit of CPU time during layout (conditional on the property applying though, which wasn't the case before). It should be very easy to store a cached version of the template, should this be too hot (I expect it isn't), or to change the representation in other ways to optimize grid layout code if it's worth it. Another trade-off: I've used SmallPointerArray to handle line-name merging, pointing to the individual arrays in the style data, rather than actually heap-allocating the merged lists. This would also be pretty easy to change should we measure and see that it's not worth it. This patch also opens the gate to potentially improving memory usage in some other ways, by reference-counting line-name lists for example, though I don't have data that suggests it is worth it. In general, this patch makes much easier to tweak the internal representation of the grid style data structures. Overall, I think it's a win, the amount of magic going on in that mako code was a bit huge; it took a bit to wrap my head around it. This patch comments out the style struct size assertions. They will be uncommented in a follow-up patch which contains some improvements for this type, which are worth getting reviewed separately. Also, this patch doesn't remove as much code as I would've hoped for because of I tried not to change most of the dom/grid code for inspector, but I think a fair bit of the nsGridContainerFrame.cpp code that collects information for it can be simplified / de-copy-pasted to some extent. But that was a pre-existing problem and this patch is already quite massive. Differential Revision: https://phabricator.services.mozilla.com/D36598
50be005d08a9ef783c009fc8259cd4f3f3e57d49: Bug 1571135 - Remove the preference that controls breaking floats inside columns. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Mon, 05 Aug 2019 17:39:19 +0000 - rev 486407
Push 113838 by rgurzau@mozilla.com at Mon, 05 Aug 2019 22:08:47 +0000
Bug 1571135 - Remove the preference that controls breaking floats inside columns. r=mats Differential Revision: https://phabricator.services.mozilla.com/D40587
178481b79e4e8b1e293e97813e0cc5663c60b7d6: Bug 1570096 - Fix parsing of align=bottom on replaced elements. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 31 Jul 2019 09:59:30 +0000 - rev 485553
Push 113810 by malexandru@mozilla.com at Wed, 31 Jul 2019 16:03:22 +0000
Bug 1570096 - Fix parsing of align=bottom on replaced elements. r=mats See https://github.com/whatwg/html/issues/4810. I accidentally changed its behavior in bug 1547985 due to an embarrassing typo. Turns out that my typo made us follow the spec, but the spec is not what we or anybody else implemented. Fun times. I added a test accounting for the proposed spec change. There's a different divergence between what does abscenter map to. Other browsers don't map `abscenter` at all, looks like, but it's in the spec. We may want to remove it, but for now I've left it in the test. Differential Revision: https://phabricator.services.mozilla.com/D39928
06b5dca91073b5b2a6b44bf0f9dd4999c794a721: Bug 1559814 - Use the cbindgen representation for grid line properties. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 26 Jun 2019 21:21:38 +0000 - rev 480243
Push 113537 by ccoroiu@mozilla.com at Thu, 27 Jun 2019 09:46:01 +0000
Bug 1559814 - Use the cbindgen representation for grid line properties. r=mats We clamp earlier (parse time rather than computed value time), but that's the only behavior change, which I think doesn't really matter. Differential Revision: https://phabricator.services.mozilla.com/D35198
9e01b4a3ac613e735d863ec922287c2dc7a0b0db: Bug 1559814 - Remove GetGridLine since it's dead code now that Stylo serializes all grid lines. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 26 Jun 2019 21:21:13 +0000 - rev 480241
Push 113537 by ccoroiu@mozilla.com at Thu, 27 Jun 2019 09:46:01 +0000
Bug 1559814 - Remove GetGridLine since it's dead code now that Stylo serializes all grid lines. r=mats Differential Revision: https://phabricator.services.mozilla.com/D35196