searching for reviewer(masayuki)
cea0bc0724141732068175f1f82e1c215b4bfd12: Bug 1588311 - Update mousedown targets when native anonymous content is recreated, r=masayuki
Olli Pettay <Olli.Pettay@helsinki.fi> - Fri, 08 Nov 2019 19:08:27 +0000 - rev 501384
Push 114169 by ncsoregi@mozilla.com at Mon, 11 Nov 2019 12:39:11 +0000
Bug 1588311 - Update mousedown targets when native anonymous content is recreated, r=masayuki Test click handling on input element which has a placeholder. Differential Revision: https://phabricator.services.mozilla.com/D51877
e2a636a0c780c0c1c12455835e3e25945a66d3c2: Bug 1570124 - Enable mouse scrolling in FxR window r=masayuki
thomasmo <thomasmo@mozilla.com> - Wed, 06 Nov 2019 20:38:45 +0000 - rev 500967
Push 114166 by apavel@mozilla.com at Thu, 07 Nov 2019 10:04:01 +0000
Bug 1570124 - Enable mouse scrolling in FxR window r=masayuki This change addresses two issues with vrhost sending WM_MOUSEWHEEL events: - The point from the message had an incorrect coordinate origin. Documentation specifices that it should be screen, rather than window/client, origin. Since vrhost only knows about a position in the window, it translates the point before sending the message. - Gecko ignores the point passed in to the window message and instead uses the point from GetMessagePos. As warnings indicate, this can be incorrect, as is exposed with vrhost. This change now uses this point from the message when available. Differential Revision: https://phabricator.services.mozilla.com/D51322
e81731a64af67d360d42563e2b19e251581b3dc3: Bug 1588311 - Update mousedown targets when native anonymous content is recreated, r=masayuki
Olli Pettay <Olli.Pettay@helsinki.fi> - Wed, 06 Nov 2019 19:05:23 +0000 - rev 500921
Push 114166 by apavel@mozilla.com at Thu, 07 Nov 2019 10:04:01 +0000
Bug 1588311 - Update mousedown targets when native anonymous content is recreated, r=masayuki Differential Revision: https://phabricator.services.mozilla.com/D51877
81e027b9973731be9522e96d48a2b0b0ecbcf0b4: Bug 1593299 - Disconnect EventListenerManager is DOMEventTargetHelper's Unlink, r=masayuki
Olli Pettay <Olli.Pettay@helsinki.fi> - Sun, 03 Nov 2019 00:03:12 +0000 - rev 500334
Push 114164 by aiakab@mozilla.com at Tue, 05 Nov 2019 10:06:15 +0000
Bug 1593299 - Disconnect EventListenerManager is DOMEventTargetHelper's Unlink, r=masayuki Differential Revision: https://phabricator.services.mozilla.com/D51423
a67173efac2602cd62cc39b7bc520461ba61f130: Bug 1581822 - Try Chinese font prefs before Japanese when no locale hint is found, to reduce chance of ransom-note font mixtures. r=m_kato,masayuki,emk
Jonathan Kew <jkew@mozilla.com> - Thu, 31 Oct 2019 08:50:12 +0000 - rev 499936
Push 114164 by aiakab@mozilla.com at Tue, 05 Nov 2019 10:06:15 +0000
Bug 1581822 - Try Chinese font prefs before Japanese when no locale hint is found, to reduce chance of ransom-note font mixtures. r=m_kato,masayuki,emk Differential Revision: https://phabricator.services.mozilla.com/D50947
9cf41163400a59b4c5b09fe16c3e1b85326a8e9e: Bug 1581822 - Try Chinese font prefs before Japanese when no locale hint is found, to reduce chance of ransom-note font mixtures. r=m_kato,masayuki,emk
Jonathan Kew <jkew@mozilla.com> - Wed, 30 Oct 2019 11:39:00 +0000 - rev 499763
Push 114163 by aiakab@mozilla.com at Thu, 31 Oct 2019 10:03:38 +0000
Bug 1581822 - Try Chinese font prefs before Japanese when no locale hint is found, to reduce chance of ransom-note font mixtures. r=m_kato,masayuki,emk Differential Revision: https://phabricator.services.mozilla.com/D50947
0b9d0a86ebfd89cfb89b8044a72e89ce743aeeee: Bug 1453190 - Don't get editing session during destroying docshell. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Fri, 25 Oct 2019 10:23:31 +0000 - rev 499350
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1453190 - Don't get editing session during destroying docshell. r=masayuki When closing window / documnet, if content modifies an element that has contenteditable via unload event, it hits assertion in `nsDocShell::EnsureEditorData` due to destroying document. So we should return error before getting editing session. Differential Revision: https://phabricator.services.mozilla.com/D50573
e00b4447378dbd14b8e7dae0c4e6b40f0dacdebe: Bug 1582398 - Remove user-select: all for editable labels. r=masayuki
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 23 Oct 2019 09:30:03 +0000 - rev 498672
Push 114159 by shindli@mozilla.com at Thu, 24 Oct 2019 09:49:00 +0000
Bug 1582398 - Remove user-select: all for editable labels. r=masayuki This seems to go back to our initial contenteditable implementation, and I don't think there's a reason <label> should work differently from anything else. Differential Revision: https://phabricator.services.mozilla.com/D46929
973eac50bb33fc630b9d7a49556a9c9c26ff465c: Bug 1587141 part 2 - Make execCommand("indent") ignore whitespace when looking for sibling list element. r=masayuki
Mats Palmgren <mats@mozilla.com> - Mon, 14 Oct 2019 17:11:00 +0000 - rev 498298
Push 114157 by nbeleuzu@mozilla.com at Mon, 21 Oct 2019 22:00:13 +0000
Bug 1587141 part 2 - Make execCommand("indent") ignore whitespace when looking for sibling list element. r=masayuki Differential Revision: https://phabricator.services.mozilla.com/D48587
47b2e27b46b7577dad33c4172019dc5236754747: Bug 1587141 part 1 - Share some common code between Handle[CSS|HTML]IndentAtSelectionInternal (idempotent patch). r=masayuki
Mats Palmgren <mats@mozilla.com> - Tue, 15 Oct 2019 04:36:26 +0000 - rev 498297
Push 114157 by nbeleuzu@mozilla.com at Mon, 21 Oct 2019 22:00:13 +0000
Bug 1587141 part 1 - Share some common code between Handle[CSS|HTML]IndentAtSelectionInternal (idempotent patch). r=masayuki Differential Revision: https://phabricator.services.mozilla.com/D48586
4dbfb65c5991c35b9539b3e121a91e69657a4f05: Bug 1587942 - Forwarding keyboard show/hide events to VR host API. r=thomasmo,PhilipLamb,masayuki,imanol
Daosheng Mu <daoshengmu@gmail.com> - Fri, 18 Oct 2019 01:24:56 +0000 - rev 498126
Push 114157 by nbeleuzu@mozilla.com at Mon, 21 Oct 2019 22:00:13 +0000
Bug 1587942 - Forwarding keyboard show/hide events to VR host API. r=thomasmo,PhilipLamb,masayuki,imanol Forwarding keyboard focus/blur events to VR browser that runs at another process. We will need to set these events in VR shmem, then VR host can receive these states from other process. Differential Revision: https://phabricator.services.mozilla.com/D48903
8b91e7e2ca1c60492dd6a05e90da6ac11f39fcd2: Bug 1587312 - Fix typo of finding non-anonymous content. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Wed, 09 Oct 2019 05:42:42 +0000 - rev 496894
Push 114147 by ccoroiu@mozilla.com at Thu, 10 Oct 2019 09:56:56 +0000
Bug 1587312 - Fix typo of finding non-anonymous content. r=masayuki Differential Revision: https://phabricator.services.mozilla.com/D48640
246acf3911021b31132ff1c158bc87d5976e32e9: Bug 1568996 - Flush layout before calling nsFrameSelection::MoveCaret. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 07 Oct 2019 08:18:33 +0000 - rev 496675
Push 114145 by apavel@mozilla.com at Tue, 08 Oct 2019 11:00:56 +0000
Bug 1568996 - Flush layout before calling nsFrameSelection::MoveCaret. r=masayuki Differential Revision: https://phabricator.services.mozilla.com/D47532
669c9f530d92dd7229fa314f74fcddee1cd3895c: Bug 1584901 - Convert tail space to NBSP in composition string. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 07 Oct 2019 08:16:18 +0000 - rev 496552
Push 114145 by apavel@mozilla.com at Tue, 08 Oct 2019 11:00:56 +0000
Bug 1584901 - Convert tail space to NBSP in composition string. r=masayuki This is related to bug 1530649. When using <span> element with contentedtiable, we won't insert <br> element at last. When Korean IME on macOS commits composition by space key, composition string has space. Gekco removes U+0020 space when it is last character into editing host. To keep whitespace, we have to replace with NBSP when it is last. Differential Revision: https://phabricator.services.mozilla.com/D48146
08a0433d72f185b8de87b7f3442ec04e23f30465: Bug 1586337, Replace XUL textbox with HTML input in testcases within editor directory r=masayuki
Emma Malysz <emalysz@mozilla.com> - Fri, 04 Oct 2019 16:30:10 +0000 - rev 496350
Push 114143 by rgurzau@mozilla.com at Mon, 07 Oct 2019 09:35:08 +0000
Bug 1586337, Replace XUL textbox with HTML input in testcases within editor directory r=masayuki Differential Revision: https://phabricator.services.mozilla.com/D48100
bda0c57ed6ddbe5e0f7c2cda17efbe1f17595b26: Bug 1585553 - s/wchar_t/char16_t/ for a variable always initialized from char16_t. r=masayuki
Henri Sivonen <hsivonen@hsivonen.fi> - Thu, 03 Oct 2019 10:53:39 +0000 - rev 496160
Push 114143 by rgurzau@mozilla.com at Mon, 07 Oct 2019 09:35:08 +0000
Bug 1585553 - s/wchar_t/char16_t/ for a variable always initialized from char16_t. r=masayuki Differential Revision: https://phabricator.services.mozilla.com/D48050
028237b07907e3dcb71c8fc00f12999767f16aaa: Bug 1574195 part 2. Switch key event interfaces to IDL mixins. r=masayuki
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 20 Sep 2019 01:50:49 +0000 - rev 494767
Push 114127 by rgurzau@mozilla.com at Tue, 24 Sep 2019 21:57:45 +0000
Bug 1574195 part 2. Switch key event interfaces to IDL mixins. r=masayuki Differential Revision: https://phabricator.services.mozilla.com/D46521
022359b23ac52beb5ecff34a8a58ed55c898b8c1: Bug 1474978 - Add crashtest. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 23 Sep 2019 10:37:40 +0000 - rev 494617
Push 114124 by cbrindusan@mozilla.com at Tue, 24 Sep 2019 09:47:58 +0000
Bug 1474978 - Add crashtest. r=masayuki Differential Revision: https://phabricator.services.mozilla.com/D46756
f9a0c897d2db229ef1096a6ada8103d63ce7b4e1: Bug 1552041 - Part 1. Set CAUSE_UNKNOWN_CHROME if caller is chrome script or native. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 23 Sep 2019 07:22:03 +0000 - rev 494468
Push 114121 by malexandru@mozilla.com at Mon, 23 Sep 2019 16:07:27 +0000
Bug 1552041 - Part 1. Set CAUSE_UNKNOWN_CHROME if caller is chrome script or native. r=masayuki Actually, CAUSE_UNKNOWN_CHROME is set when caller is chrome process. I would like to change that this value is called from chrome or native. Differential Revision: https://phabricator.services.mozilla.com/D44104
435ebebfb638bfa98f519f93922544bacf6a37b5: Bug 1582306 - Set tabfocus pref for test. r=masayuki
Adam Gashlin <agashlin@mozilla.com> - Thu, 19 Sep 2019 21:20:32 +0000 - rev 494135
Push 114108 by dvarga@mozilla.com at Fri, 20 Sep 2019 09:59:36 +0000
Bug 1582306 - Set tabfocus pref for test. r=masayuki This avoids relying on the accessibility.tabfocus pref having been set by a previous test. Differential Revision: https://phabricator.services.mozilla.com/D46374
4dd3945f8b0a2be5d591cf0a96fab41b70b8a8d0: Bug 1571375 - Don't remove white space when committing composition. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Wed, 18 Sep 2019 03:56:25 +0000 - rev 493694
Push 114097 by malexandru@mozilla.com at Wed, 18 Sep 2019 10:10:26 +0000
Bug 1571375 - Don't remove white space when committing composition. r=masayuki This is regression by bug 1530649. After landing bug 1530649, we try to scan end point of replacement text. But in this bug's situation, afterRun becomes same as current ws run by landing bug 1530649. To get white space type of next of replacement end, we have to scan around end point again. Differential Revision: https://phabricator.services.mozilla.com/D45947
66713250039256030dae69f7f3b1eb254b5e3e0f: Bug 1579788 - Downgrade a few assertions in beta / release as to avoid crashing there. r=masayuki
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 12 Sep 2019 08:46:27 +0000 - rev 492818
Push 114076 by ncsoregi@mozilla.com at Thu, 12 Sep 2019 15:29:15 +0000
Bug 1579788 - Downgrade a few assertions in beta / release as to avoid crashing there. r=masayuki This is the only short-term fix for now until we fix editor or find a test-case... This will keep asserting on Nightly, but the correctness issue it'd show in release (some pseudo-classes not matching) is better than crashing. Differential Revision: https://phabricator.services.mozilla.com/D45575
b3cd91c124cc86c9bbe11de4688262212ff6d52b: Bug 1571339 - Don't use nsTextFragment::AppendTo to get string in TextNodeContainsDOMWordSeparator. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 09 Sep 2019 03:42:45 +0000 - rev 492173
Push 114045 by shindli@mozilla.com at Mon, 09 Sep 2019 10:00:00 +0000
Bug 1571339 - Don't use nsTextFragment::AppendTo to get string in TextNodeContainsDOMWordSeparator. r=masayuki Actually, spellchecker always allocates the heap to get text from text node. But it is unnecessary to allocate another heap here since `WordSplitState` walks text only and it is stack class. If text is in '<textarea>', text node may be too large, so we shouldn't allocate memory to walk character in `WordSplitState` if possible. Because `TextNodeContainsDOMWordSeparator` will be called per input. And `mWordUtil` is unused, so we should remove it. Differential Revision: https://phabricator.services.mozilla.com/D42257
454b9be1b61388183b0c5b55d780507d845858dd: Bug 1550058: Move most keyboard shortcut handling out of XBL. r=masayuki
Dave Townsend <dtownsend@oxymoronical.com> - Fri, 06 Sep 2019 17:10:40 +0000 - rev 492046
Push 114040 by ncsoregi@mozilla.com at Sat, 07 Sep 2019 09:47:24 +0000
Bug 1550058: Move most keyboard shortcut handling out of XBL. r=masayuki Most of our keyboard shortcut handling is handled by nsXBLWindowKeyHandler along with nsXBLPrototypeHandler. With the impending removal of XBL this needs to change. This patch moves nsXBLWindowKeyHandler to dom/events/GlobalKeyListener and copies nsXBLPrototypeHandler to dom/events/KeyEventHandler. Windows, text elements and XUL <keyset> are changed to use the new copies and anything unnecessary for those is stripped out. XBL handler elements still remain using the existing nsXBLPrototypeHandler path. Some of the code is ripped out there to make it compile. There is probably a lot more that can be removed but since the whole of XBL is likely gone soon I'm not sure it is worth cleaning that up much. Differential Revision: https://phabricator.services.mozilla.com/D42336
e18ae5f66cacf06f72113830dc87ea8a5435b63b: Bug 1550058: Move most keyboard shortcut handling out of XBL. r=masayuki
Dave Townsend <dtownsend@oxymoronical.com> - Thu, 05 Sep 2019 16:51:27 +0000 - rev 491881
Push 114036 by nerli@mozilla.com at Fri, 06 Sep 2019 09:46:47 +0000
Bug 1550058: Move most keyboard shortcut handling out of XBL. r=masayuki Most of our keyboard shortcut handling is handled by nsXBLWindowKeyHandler along with nsXBLPrototypeHandler. With the impending removal of XBL this needs to change. This patch moves nsXBLWindowKeyHandler to dom/events/GlobalKeyListener and copies nsXBLPrototypeHandler to dom/events/KeyEventHandler. Windows, text elements and XUL <keyset> are changed to use the new copies and anything unnecessary for those is stripped out. XBL handler elements still remain using the existing nsXBLPrototypeHandler path. Some of the code is ripped out there to make it compile. There is probably a lot more that can be removed but since the whole of XBL is likely gone soon I'm not sure it is worth cleaning that up much. Differential Revision: https://phabricator.services.mozilla.com/D42336
8f7c665a6e3414f7ed6f9eea496d81b5e417360f: Bug 1577969 - Get rid of nsIHTMLEditor.getLinkedObject and nsIURIRefObject. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 02 Sep 2019 12:15:41 +0000 - rev 491292
Push 114020 by rmaries@mozilla.com at Tue, 03 Sep 2019 09:51:48 +0000
Bug 1577969 - Get rid of nsIHTMLEditor.getLinkedObject and nsIURIRefObject. r=masayuki Since bug 1577443 is landed in comm-central, no one uses `nsIHTMLEditor.getLinkedObject`. Differential Revision: https://phabricator.services.mozilla.com/D44361
10b0a2e34429cb716ae206ff7daf32ac074a57ac: Bug 1577685 - Move some utility functions from IMEStateManager to widget. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Fri, 30 Aug 2019 05:56:58 +0000 - rev 491010
Push 114010 by dluca@mozilla.com at Sat, 31 Aug 2019 09:58:00 +0000
Bug 1577685 - Move some utility functions from IMEStateManager to widget. r=masayuki I would like to log `IMEState` and `InputContextAction`in widget. But this utilities are in `IMEStateManager`, so I would like to move it to widget by using `mozilla/ToString.h`. Differential Revision: https://phabricator.services.mozilla.com/D44103
dd6e8cc3c3d4d155c69de00c8357d45a8e5d94b7: Bug 1564788. Remove unnecessary null check from PrintPreviewUserEventSuppressor::HandleEvent. r=masayuki
Jonathan Watt <jwatt@jwatt.org> - Tue, 23 Jul 2019 01:50:03 +0000 - rev 490823
Push 114003 by shindli@mozilla.com at Fri, 30 Aug 2019 16:27:44 +0000
Bug 1564788. Remove unnecessary null check from PrintPreviewUserEventSuppressor::HandleEvent. r=masayuki Most other overrides of nsIDOMEventListener::HandleEvent don't null check aEvent at all. This method should never be called without an event. Differential Revision: https://phabricator.services.mozilla.com/D38906
160da901fc3e63632497c1d42b3ebd7e84892224: Bug 1572939 - part2 : remove editable content tests. r=masayuki
alwu <alwu@mozilla.com> - Tue, 27 Aug 2019 04:46:13 +0000 - rev 490166
Push 113983 by csabou@mozilla.com at Tue, 27 Aug 2019 16:40:52 +0000
Bug 1572939 - part2 : remove editable content tests. r=masayuki As we will allow user inputs on editable content to activate document, we should remove them from black list test. Differential Revision: https://phabricator.services.mozilla.com/D43533
2ba2516d4a2c9d353a724b8c433701bf1b9df329: Bug 1572939 - part1 : allow user inputs on editable content to activate document. r=masayuki
alwu <alwu@mozilla.com> - Tue, 27 Aug 2019 04:45:05 +0000 - rev 490165
Push 113983 by csabou@mozilla.com at Tue, 27 Aug 2019 16:40:52 +0000
Bug 1572939 - part1 : allow user inputs on editable content to activate document. r=masayuki As Chrome and Safari didn't block autoplay when haiving user input on editable content, it causes a compatible issue on Firefox because we only allow user inputs happening on non-editable content to activate document. It seems that we don't really need to restrict that user inputs, which can activate document, should only occur on non-editable content. Even if they occur on non-editable content, it might still have a chance to annoy user, it's totally depending on websites' design. Differential Revision: https://phabricator.services.mozilla.com/D43532
c8fcbaade215ecf3cd353b4196787d8c5826527a: Bug 1575584: prevent reading uninitialized variable in `TextEditor::ComputeValueInternal`. r=masayuki
Mirko Brodesser <mbrodesser@mozilla.com> - Fri, 23 Aug 2019 09:25:00 +0000 - rev 489564
Push 113953 by ncsoregi@mozilla.com at Fri, 23 Aug 2019 15:43:44 +0000
Bug 1575584: prevent reading uninitialized variable in `TextEditor::ComputeValueInternal`. r=masayuki The fix here is to first check `NS_FAILED(rv)`, because if that's the case, `cancel` wasn't necessarily set to a value. As best practice I initialized `cancel` and `handled` with default values. Differential Revision: https://phabricator.services.mozilla.com/D43071
8b40b616dbff58f7fbfd304f2bdd31652dae9837: Bug 1574596 - Keep editing UI until PresShell is really gone. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Wed, 21 Aug 2019 06:05:16 +0000 - rev 489344
Push 113944 by aiakab@mozilla.com at Thu, 22 Aug 2019 10:02:51 +0000
Bug 1574596 - Keep editing UI until PresShell is really gone. r=masayuki This is regression by bug 1543312. By bug 1543312, we destroy editor when destroying PresShell. But when destroying PresShell, editor doesn't remove anonymous content of editing UI from PresShell. Then, when destroying the frame manager in `PresShell::Destroy`, it hits assertion due to uncomposed doc. We shouldn't hide editing UI during destroying PresShell and we should hide it after destroyed. Differential Revision: https://phabricator.services.mozilla.com/D42773
e5549942df83c31af0d23e897bab110031eecb95: Bug 1574223, make touchstart/move passive by default also when using event handlers, not only event listeners, r=masayuki
Olli Pettay <Olli.Pettay@helsinki.fi> - Fri, 16 Aug 2019 15:18:46 +0000 - rev 488651
Push 113915 by dvarga@mozilla.com at Sun, 18 Aug 2019 09:56:49 +0000
Bug 1574223, make touchstart/move passive by default also when using event handlers, not only event listeners, r=masayuki Differential Revision: https://phabricator.services.mozilla.com/D42235
2fce06fd642bada80669049de12f9b15924c979b: Bug 1438996. Don't construct a unneeded temporary range object in RangeUtils::CompareNodeToRange. r=masayuki
Timothy Nikkel <tnikkel@gmail.com> - Thu, 15 Aug 2019 21:13:54 +0000 - rev 488360
Push 113906 by ncsoregi@mozilla.com at Fri, 16 Aug 2019 04:07:24 +0000
Bug 1438996. Don't construct a unneeded temporary range object in RangeUtils::CompareNodeToRange. r=masayuki nsContentUtils::ComparePoints just immediately deconstructs the range boundary into container and offset and calls a version of nsContentUtils::ComparePoints that takes containers/offsets instead of range boundaries. This also avoids a warning in the RangeBoundary constructor. Differential Revision: https://phabricator.services.mozilla.com/D42071
8cc56f3f8a0881cdc99356d545117c03997a34a9: Bug 1573119: declare more methods around `HTMLEditor` `const`/`static`. r=masayuki
Mirko Brodesser <mbrodesser@mozilla.com> - Tue, 13 Aug 2019 07:34:11 +0000 - rev 487603
Push 113883 by btara@mozilla.com at Tue, 13 Aug 2019 16:13:25 +0000
Bug 1573119: declare more methods around `HTMLEditor` `const`/`static`. r=masayuki Differential Revision: https://phabricator.services.mozilla.com/D41524
66e8aafac348952cd16aec2c691afa5f0c9a66be: Bug 1543312 - Tear down editor when PresShell is destroyed. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Tue, 13 Aug 2019 02:00:00 +0000 - rev 487596
Push 113883 by btara@mozilla.com at Tue, 13 Aug 2019 16:13:25 +0000
Bug 1543312 - Tear down editor when PresShell is destroyed. r=masayuki When browsing reported site (https://minecraft.curseforge.com/), user that uses Android cannot set caret on some editable contents. GV's IME code uses `NOTIFY_IME_OF_SELECTION_CHANGE` to update selection on native IME. But GV doesn't receives this notification on this reported site. This notification is fired by editor's selection listener, but when this occurs, this notification is no logner fired unfortunately. Because selection listener isn't registered by current selection. At first, editor registers selection listener by `EditorBase::Init`. But like test case, if PresShell is destroyed after editor is created, this registration is no longer used, and we have to register it by new selection again. So we should tear down editor when PresShell is destroyed. (or we have to add a way to re-initialize selection listener?) This isn't related to Android. Android's IME code depends on this notification, so this occurs easily. Also, `PresShell::SetCaretEnabled` only works when caret is valid (`PresShell::GetCaret` has caret). If caret is nothing, it hits assertion. And, attached test case is reproduced sample. Differential Revision: https://phabricator.services.mozilla.com/D41356
8fc745a7fb86b9d1af138735f9752ce2827824d5: Bug 1572715: part 2) Make some methods around `HTMLEditor` const-correct. r=masayuki
Mirko Brodesser <mbrodesser@mozilla.com> - Mon, 12 Aug 2019 08:31:04 +0000 - rev 487430
Push 113876 by aiakab@mozilla.com at Mon, 12 Aug 2019 16:26:30 +0000
Bug 1572715: part 2) Make some methods around `HTMLEditor` const-correct. r=masayuki Differential Revision: https://phabricator.services.mozilla.com/D41385
710947b25081ea2da6477550e9ad068bf117e975: Bug 1572715: part 1) Factor out `WSRunScanner` from `WSRunObject`. r=masayuki
Mirko Brodesser <mbrodesser@mozilla.com> - Mon, 12 Aug 2019 08:30:57 +0000 - rev 487429
Push 113876 by aiakab@mozilla.com at Mon, 12 Aug 2019 16:26:30 +0000
Bug 1572715: part 1) Factor out `WSRunScanner` from `WSRunObject`. r=masayuki This allows users of `WSRunScanner`'s functionality to pass a `const HTMLEditor*`, allowing themselves to become const-correct. Differential Revision: https://phabricator.services.mozilla.com/D41384
d89fd391a5523b8f6dd527d3191a36047a657467: Bug 1571621 - Convert VarCache prefs in HTMLEditor.cpp to static prefs. r=masayuki
Nicholas Nethercote <nnethercote@mozilla.com> - Tue, 06 Aug 2019 08:49:32 +0000 - rev 486487
Push 113845 by dluca@mozilla.com at Tue, 06 Aug 2019 16:18:48 +0000
Bug 1571621 - Convert VarCache prefs in HTMLEditor.cpp to static prefs. r=masayuki Differential Revision: https://phabricator.services.mozilla.com/D40775
8a0763d975aae456b2cf4b5ddbc6ebff287293d7: Bug 1570719 - Skip more elements in spellcheck for MailNews. r=masayuki
Jorg K <jorgk@jorgk.com> - Fri, 02 Aug 2019 10:49:17 +0200 - rev 485904
Push 113824 by csabou@mozilla.com at Fri, 02 Aug 2019 16:06:39 +0000
Bug 1570719 - Skip more elements in spellcheck for MailNews. r=masayuki
cea84d44c6a2758719340bf3e86b9a73285d7e57: Bug 1570861 - Editor should store text node in mCachedSelectionNode to pass previous selected node/offset to spell checker r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Fri, 02 Aug 2019 07:44:20 +0000 - rev 485893
Push 113824 by csabou@mozilla.com at Fri, 02 Aug 2019 16:06:39 +0000
Bug 1570861 - Editor should store text node in mCachedSelectionNode to pass previous selected node/offset to spell checker r=masayuki When using `<textarea>`, spell checker sometimes check spell when editing last text node. Because editor passes invalid previous selection node and offset via `HandleInlineSpellCheck`. Although previous selected node uses `mCachedSelectionNode` that is stored by `BeforeEdit`, when this occurs, it isn't text node. When editing last text node in `<textarea>`, anchror node might be root node, not current text node. So we should use text node instead when this is inserting text operation. Differential Revision: https://phabricator.services.mozilla.com/D40368
fa68a5b78e08d8a67c32e1dac8d65ca222f90a08: Bug 1517477 - Upgrade Hunspell to version 1.7.0. r=masayuki
Ryan VanderMeulen <ryanvm@gmail.com> - Wed, 03 Jul 2019 16:18:23 +0000 - rev 481682
Push 113632 by nbeleuzu@mozilla.com at Tue, 09 Jul 2019 03:54:50 +0000
Bug 1517477 - Upgrade Hunspell to version 1.7.0. r=masayuki Differential Revision: https://phabricator.services.mozilla.com/D15652
9005dd228db53f620ea6c1fb96989053966dab22: Bug 1178763, move UIEvent.pageX/pageY to MouseEvent, r=masayuki
Olli Pettay <Olli.Pettay@helsinki.fi> - Thu, 04 Jul 2019 01:50:22 +0000 - rev 481258
Push 113607 by rmaries@mozilla.com at Thu, 04 Jul 2019 21:50:40 +0000
Bug 1178763, move UIEvent.pageX/pageY to MouseEvent, r=masayuki Differential Revision: https://phabricator.services.mozilla.com/D36781
88e9ed06620ee0654795181f998b7210eee942d0: Bug 1556103 - Part 1. Add long press action when setting focus. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Fri, 28 Jun 2019 00:39:45 +0000 - rev 481236
Push 113603 by ncsoregi@mozilla.com at Thu, 04 Jul 2019 09:55:46 +0000
Bug 1556103 - Part 1. Add long press action when setting focus. r=masayuki Actually, long tap can set focus. But since it uses `nsIFocusManager::FLAG_BYMOUSE` flag, we cannot recognize whether setting focus is by long tap or not. So I would like to add new flag `FLAG_BYLONGPRESS` and `CAUSE_LONGPRESS` that are by long tap. Differential Revision: https://phabricator.services.mozilla.com/D35991
109ccdeb96342a315b86ef0c7ebe76738308673b: Bug 1562655: rename `Selection::HasSameRoot` to `HasSameRootOrSameComposedDoc`. r=masayuki
Mirko Brodesser <mbrodesser@mozilla.com> - Mon, 01 Jul 2019 17:20:28 +0200 - rev 480905
Push 113581 by mbrodesser@mozilla.com at Tue, 02 Jul 2019 11:24:46 +0000
Bug 1562655: rename `Selection::HasSameRoot` to `HasSameRootOrSameComposedDoc`. r=masayuki Differential Revision: https://phabricator.services.mozilla.com/D36492
423026d65fe92abe9a22c10af78056be2bddcad3: Bug 1560517 - Add update script and patch files for hunspell library r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Fri, 21 Jun 2019 18:57:35 +0000 - rev 479833
Push 113494 by dluca@mozilla.com at Sat, 22 Jun 2019 09:49:59 +0000
Bug 1560517 - Add update script and patch files for hunspell library r=masayuki Add `update.sh` script and patch files to update hunspell library easily. Differential Revision: https://phabricator.services.mozilla.com/D35516
164ae5b4ff067240721f51c4917961048de3a6d0: Bug 1549930 addendum - Notify widgets of IME blur on quit (on non-Android). r=masayuki
Henri Sivonen <hsivonen@hsivonen.fi> - Mon, 17 Jun 2019 04:51:29 +0000 - rev 479077
Push 113459 by malexandru@mozilla.com at Mon, 17 Jun 2019 10:07:02 +0000
Bug 1549930 addendum - Notify widgets of IME blur on quit (on non-Android). r=masayuki Differential Revision: https://phabricator.services.mozilla.com/D34992
05f0605563106e546d131074bcbd397d1fd9b494: Bug 1549930 - Avoid popping BrowserParent in response to window lowering. r=masayuki
Henri Sivonen <hsivonen@hsivonen.fi> - Fri, 14 Jun 2019 07:02:18 +0000 - rev 479076
Push 113459 by malexandru@mozilla.com at Mon, 17 Jun 2019 10:07:02 +0000
Bug 1549930 - Avoid popping BrowserParent in response to window lowering. r=masayuki Differential Revision: https://phabricator.services.mozilla.com/D30873
89f2a15823bc3c64a5e2b55c0d593b4e3949d2a7: Bug 1558704 - Fix spellchecker when XUL is loaded as XHTML r=masayuki
Brendan Dahl <bdahl@mozilla.com> - Thu, 13 Jun 2019 11:53:12 +0000 - rev 478718
Push 113434 by shindli@mozilla.com at Thu, 13 Jun 2019 22:05:34 +0000
Bug 1558704 - Fix spellchecker when XUL is loaded as XHTML r=masayuki Temporary workaround to use the document element as the root content node in XHTML pages that have a XUL root element. Differential Revision: https://phabricator.services.mozilla.com/D34657
c259c1017aa193b8b4a2031488aab0dc779b3a2f: Bug 1557231. Stop using [array] in nsIInlineSpellChecker. r=masayuki
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 06 Jun 2019 06:59:37 +0000 - rev 477597
Push 113366 by ncsoregi@mozilla.com at Thu, 06 Jun 2019 22:41:06 +0000
Bug 1557231. Stop using [array] in nsIInlineSpellChecker. r=masayuki Differential Revision: https://phabricator.services.mozilla.com/D33908