searching for reviewer(mak)
4658f41dadeee748ec1fe0c9ad6a0ab4c4690921: Bug 1593965 - Use new drag & drop indicators for tabs and the bookmarks toolbar. r=mak,dao
Harry Twyford <htwyford@mozilla.com> - Fri, 15 Nov 2019 14:45:22 +0000 - rev 502187
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1593965 - Use new drag & drop indicators for tabs and the bookmarks toolbar. r=mak,dao Differential Revision: https://phabricator.services.mozilla.com/D52822
81b1c17310c2e3060f5a6e92f0a5221514c5fa72: Bug 1593965 - Use new drag & drop indicators for tabs and the bookmarks toolbar. r=mak,dao
Harry Twyford <htwyford@mozilla.com> - Fri, 15 Nov 2019 10:27:50 +0000 - rev 502136
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1593965 - Use new drag & drop indicators for tabs and the bookmarks toolbar. r=mak,dao Differential Revision: https://phabricator.services.mozilla.com/D52822
409ebe45687765c849936626fbc7d95fcfc17f6d: Bug 1595328 - Add browser.experiments.urlbar.lastBrowserUpdateDate webextension experiment API. r=mak,mixedpuppy CLOSED TREE
Drew Willcoxon <adw@mozilla.com> - Thu, 14 Nov 2019 20:00:46 +0000 - rev 502111
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1595328 - Add browser.experiments.urlbar.lastBrowserUpdateDate webextension experiment API. r=mak,mixedpuppy CLOSED TREE Differential Revision: https://phabricator.services.mozilla.com/D52948
289a3851e8c71110ffcb64425fef17a8cce04af9: Bug 1595328 - Add browser.experiments.urlbar.lastBrowserUpdateDate webextension experiment API. r=mak,mixedpuppy
Drew Willcoxon <adw@mozilla.com> - Thu, 14 Nov 2019 20:00:46 +0000 - rev 502032
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1595328 - Add browser.experiments.urlbar.lastBrowserUpdateDate webextension experiment API. r=mak,mixedpuppy Differential Revision: https://phabricator.services.mozilla.com/D52948
7ace5357440ad37e7608a301bf37b6c2b53dd6b4: Bug 1595678 - browser.experiments.urlbar.isBrowserShowingNotification should not treat app menu badges as notifications. r=mak
Drew Willcoxon <adw@mozilla.com> - Wed, 13 Nov 2019 22:50:50 +0000 - rev 501849
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1595678 - browser.experiments.urlbar.isBrowserShowingNotification should not treat app menu badges as notifications. r=mak This also updates each test task to make sure the function returns false after each notification is dismissed. Differential Revision: https://phabricator.services.mozilla.com/D52915
73c69599b3f12fa0f2dc45ee29fb202c93a9a695: Bug 1595985 - Add browser.urlbar.closeView webextension API. r=mak,mixedpuppy
Drew Willcoxon <adw@mozilla.com> - Wed, 13 Nov 2019 17:59:08 +0000 - rev 501819
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1595985 - Add browser.urlbar.closeView webextension API. r=mak,mixedpuppy This is based on D52612 Differential Revision: https://phabricator.services.mozilla.com/D52792
da8d5a96f3c8f93be0a4ca787eedd410dcf3b0c8: Bug 1595285 - Fix TestUtils.waitForCondition to not use setInterval. r=mak
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 13 Nov 2019 18:24:02 +0000 - rev 501811
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1595285 - Fix TestUtils.waitForCondition to not use setInterval. r=mak The test that is timing out with these patches does something relatively simple: await TestUtils.waitForCondition(async function() { let color = await ContentTask.spawn(browserWindow, async function() { /* Do stuff... */ }); return color == something; }); await closeWindow(browserWindow); Turns out that this can intermittently leak the window due to waitForCondition using setInterval. setInterval can schedule multiple tasks while awaiting for the inner ContentTask. What this means, is that we may still have a ContentTask awaiting us when we get to close the window. Closing the window makes the ContentTask not finish, and thus we leak a promise keeping alive the window in gPromises: https://searchfox.org/mozilla-central/rev/6566d92dd46417a2f57e75c515135ebe84c9cef5/testing/mochitest/BrowserTestUtils/ContentTask.jsm#24 Which means that we keep alive the window all the way until shutdown. Fix it by ensuring that we only run one task at a time. Differential Revision: https://phabricator.services.mozilla.com/D52833
f30f256f9b67880a1d934d2e1a4d0fd012d06818: Bug 1595285 - Do not track TRANSITION_EMBED visits for link-coloring purposes. r=mak
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 13 Nov 2019 16:36:09 +0000 - rev 501775
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1595285 - Do not track TRANSITION_EMBED visits for link-coloring purposes. r=mak Other browsers don't, plus it blocks work I want to do to query multiple links at the same time. Differential Revision: https://phabricator.services.mozilla.com/D52443
909f5eb0cc4807fb607a7ec225d3d1389c3bcf49: Bug 1595641 - Add a focus option to browser.urlbar.search and add a browser.urlbar.focus function. r=mak,mixedpuppy
Drew Willcoxon <adw@mozilla.com> - Wed, 13 Nov 2019 14:36:56 +0000 - rev 501765
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1595641 - Add a focus option to browser.urlbar.search and add a browser.urlbar.focus function. r=mak,mixedpuppy Differential Revision: https://phabricator.services.mozilla.com/D52612
b73d74bcafda125ebc57dcd59fb3dd00cacfed8c: Bug 1595285 - Do not track TRANSITION_EMBED visits for link-coloring purposes. r=mak
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 12 Nov 2019 05:06:36 +0000 - rev 501747
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1595285 - Do not track TRANSITION_EMBED visits for link-coloring purposes. r=mak Other browsers don't, plus it blocks work I want to do to query multiple links at the same time. Differential Revision: https://phabricator.services.mozilla.com/D52443
ffc59a6dfbd58dcc28114acc38a7ef29f55d0aab: Bug 1595285 - Fix TestUtils.waitForCondition to not use setInterval. r=mak
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 13 Nov 2019 14:39:51 +0000 - rev 501746
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1595285 - Fix TestUtils.waitForCondition to not use setInterval. r=mak The test that is timing out with these patches does something relatively simple: await TestUtils.waitForCondition(async function() { let color = await ContentTask.spawn(browserWindow, async function() { /* Do stuff... */ }); return color == something; }); await closeWindow(browserWindow); Turns out that this can intermittently leak the window due to waitForCondition using setInterval. setInterval can schedule multiple tasks while awaiting for the inner ContentTask. What this means, is that we may still have a ContentTask awaiting us when we get to close the window. Closing the window makes the ContentTask not finish, and thus we leak a promise keeping alive the window in gPromises: https://searchfox.org/mozilla-central/rev/6566d92dd46417a2f57e75c515135ebe84c9cef5/testing/mochitest/BrowserTestUtils/ContentTask.jsm#24 Which means that we keep alive the window all the way until shutdown. Fix it by ensuring that we only run one task at a time. Differential Revision: https://phabricator.services.mozilla.com/D52833
4b3eacb45a38a33175976e7d76d1651334f52d82: Bug 1568595 - [Nudges] Implement an experiment API to check whether a notification is being displayed in Firefox r=mak,mixedpuppy
Drew Willcoxon <adw@mozilla.com> - Tue, 12 Nov 2019 02:55:15 +0000 - rev 501543
Push 114170 by malexandru@mozilla.com at Tue, 12 Nov 2019 21:58:32 +0000
Bug 1568595 - [Nudges] Implement an experiment API to check whether a notification is being displayed in Firefox r=mak,mixedpuppy This sets up a `browser.experiments.urlbar` WebExtension Experiment API and adds a function called `isBrowserShowingNotification`. To recap, for the nudges experiment, we want to open the urlbar view automatically in some cases to show a nudge, but only if the browser isn't already showing a notification. There are a few things to point out about this patch. What counts as a notification is a little fuzzy. I chose: the tracking protection doorhanger, site identity doorhanger, app menu notifications, notification box (info bar), page action panels, and toolbar button panels. The last two aren't really notifications, but they're panels similar to doorhanger notifications. I also count the urlbar view as a notification since we don't want to show a nudge if the urlbar view is already open. I didn't bother with tab-modal dialogs since none of the pages we want to show nudges on will have them. I didn't bother with app-modal dialogs since the user can't interact with the browser until they're dismissed. I chose `browser.experiments.urlbar` as the namespace, which we previously used in the top-sites experiment. There was also discussion of `browser.experiments.app` (bug 1579933), but I think we should keep all our urlbar experiment-related APIs in a urlbar namespace even when they aren't actually related to the urlbar. It's not a big deal though. Shane recommends that we land tests for our experiment APIs in mozilla-central even though they won't ship in mozilla-central, at least for APIs that will be used in more than one version of Firefox. I think that's also a good idea for APIs we reuse in multiple experiments. It may not be necessary in this case since I'm not sure how broadly useful this notification API is, so I'm open to removing it and keeping it only in the experiment's GitHub repo. But I found that this was actually a nice way to develop and test this patch. Also, if we keep our experiment APIs in mozilla-central this way, we may not need a separate GitHub repo for them, or at most it'll just be a copy of this browser/components/urlbar/tests/ext directory. As mentioned, I made a new ext tests directory. I think we should keep these files separate from the normal tests. Differential Revision: https://phabricator.services.mozilla.com/D52312
e19c5df398de58747cceb53d36db418d1d63f8e3: Bug 1595285 - Do not track TRANSITION_EMBED visits for link-coloring purposes. r=mak
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 11 Nov 2019 13:28:52 +0000 - rev 501471
Push 114170 by malexandru@mozilla.com at Tue, 12 Nov 2019 21:58:32 +0000
Bug 1595285 - Do not track TRANSITION_EMBED visits for link-coloring purposes. r=mak Other browsers don't, plus it blocks work I want to do to query multiple links at the same time. Differential Revision: https://phabricator.services.mozilla.com/D52443
9cba679cc50d3df22967ec82fe1d4d3d6f967e73: Bug 1595285 - Minor cleanup of the visited query code. r=mak
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 11 Nov 2019 13:28:34 +0000 - rev 501469
Push 114170 by malexandru@mozilla.com at Tue, 12 Nov 2019 21:58:32 +0000
Bug 1595285 - Minor cleanup of the visited query code. r=mak Differential Revision: https://phabricator.services.mozilla.com/D52446
44afbc73fe15710fcc9d1591d8a783a55473cb04: Bug 1594622 - Quantumbar: Remove the context.preselected property and rely on result.heuristic instead r=mak
Drew Willcoxon <adw@mozilla.com> - Fri, 08 Nov 2019 18:50:00 +0000 - rev 501351
Push 114168 by dluca@mozilla.com at Sun, 10 Nov 2019 03:08:55 +0000
Bug 1594622 - Quantumbar: Remove the context.preselected property and rely on result.heuristic instead r=mak Please see bug 1594622 for a description. Differential Revision: https://phabricator.services.mozilla.com/D52120
5b0cc1595568d210a4d9b1a321310bb97d449761: Bug 1590461 - Add browser.urlbar.search() to the webextensions API r=mak,mixedpuppy
Drew Willcoxon <adw@mozilla.com> - Fri, 08 Nov 2019 09:39:54 +0000 - rev 501328
Push 114168 by dluca@mozilla.com at Sun, 10 Nov 2019 03:08:55 +0000
Bug 1590461 - Add browser.urlbar.search() to the webextensions API r=mak,mixedpuppy Differential Revision: https://phabricator.services.mozilla.com/D52127
5aae86b2b1ee1b466d4b4c91be784ea9c451ab16: Bug 1594276 - Fix browser_keepStateAcrossTabSwitches.js to work with Fission r=mak
Drew Willcoxon <adw@mozilla.com> - Wed, 06 Nov 2019 17:47:43 +0000 - rev 500890
Push 114166 by apavel@mozilla.com at Thu, 07 Nov 2019 10:04:01 +0000
Bug 1594276 - Fix browser_keepStateAcrossTabSwitches.js to work with Fission r=mak The test hangs in the first task on `await errorPageLoaded`. aboutNetError.js does fire the AboutNetErrorLoad event that BrowserTestUtils is waiting for, and BrowserTestUtils does add its listener before the event is fired, but the event never reaches the listener for some reason. Changing the initial page in the test from about:blank to an actual page and waiting for it to load fixes it, but I don't know why. The test doesn't depend on the initial page, so this should be OK. Differential Revision: https://phabricator.services.mozilla.com/D51962
4ee2e15986b6115c94c803d807178c2e282c17bc: Bug 1593959 - Introduce a visual gap between results. r=mak
Harry Twyford <htwyford@mozilla.com> - Wed, 06 Nov 2019 16:23:45 +0000 - rev 500880
Push 114166 by apavel@mozilla.com at Thu, 07 Nov 2019 10:04:01 +0000
Bug 1593959 - Introduce a visual gap between results. r=mak Differential Revision: https://phabricator.services.mozilla.com/D51979
b461f28b9c9e4c9279ab4cff6398457ba1013f4a: Bug 1593690 - Batch content -> parent visited queries. r=mak
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 06 Nov 2019 12:11:06 +0000 - rev 500823
Push 114166 by apavel@mozilla.com at Thu, 07 Nov 2019 10:04:01 +0000
Bug 1593690 - Batch content -> parent visited queries. r=mak Differential Revision: https://phabricator.services.mozilla.com/D51628
d4bbf56e69f3cf157b1122a0cb4a4fc3f378cbc1: Bug 1593690 - Start visited queries from an idle timer. r=mak,lina
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 06 Nov 2019 12:10:59 +0000 - rev 500822
Push 114166 by apavel@mozilla.com at Thu, 07 Nov 2019 10:04:01 +0000
Bug 1593690 - Start visited queries from an idle timer. r=mak,lina Getting visited colors is relatively low priority during page load. GeckoView was using a 250ms timer, which was somewhat arbitrary. If this turns out not to be acceptable for desktop, we can change it to a higher priority timer. This enables batching queries from the content process. The lesser priority of the queries, plus the batching that this enables on the content process I hope will make a dent on the performance regression that bug 1506842 introduces as-is. We should probably introduce batching in the other direction too, both of those are potential follow-up work. Differential Revision: https://phabricator.services.mozilla.com/D51621
14830ac12439f75466e0aed13fa89f554e02a1f1: Bug 1593690 - Fix some races caused by bug 1591717, and add some debugging code. r=mak
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 05 Nov 2019 22:30:26 +0000 - rev 500754
Push 114166 by apavel@mozilla.com at Thu, 07 Nov 2019 10:04:01 +0000
Bug 1593690 - Fix some races caused by bug 1591717, and add some debugging code. r=mak These were unveiled by the coming patch. We didn't use to call run_next_test for the links that expected no visits before bug 1591717. Differential Revision: https://phabricator.services.mozilla.com/D51620
8b79d4ccb76e0a85a1f9de2933b4c16665065c82: Bug 1589826 - Remove the megabar's "focused & collapsed" state. r=mak
Harry Twyford <htwyford@mozilla.com> - Tue, 05 Nov 2019 15:21:29 +0000 - rev 500722
Push 114166 by apavel@mozilla.com at Thu, 07 Nov 2019 10:04:01 +0000
Bug 1589826 - Remove the megabar's "focused & collapsed" state. r=mak Differential Revision: https://phabricator.services.mozilla.com/D49824
e6fa62187db798c6c58c2bf973cc453768047b67: Bug 1592268 - Make the permanent search icon a bookmarks doorhanger anchor. r=mak
Harry Twyford <htwyford@mozilla.com> - Tue, 05 Nov 2019 16:28:13 +0000 - rev 500721
Push 114166 by apavel@mozilla.com at Thu, 07 Nov 2019 10:04:01 +0000
Bug 1592268 - Make the permanent search icon a bookmarks doorhanger anchor. r=mak Differential Revision: https://phabricator.services.mozilla.com/D51814
5275ea4d5a1aec6e1e66e051456c4239fe91df11: Bug 1593665 - Increase font-weight of highlighted URLs and titles in the Megabar. r=mak
Harry Twyford <htwyford@mozilla.com> - Tue, 05 Nov 2019 16:16:28 +0000 - rev 500720
Push 114166 by apavel@mozilla.com at Thu, 07 Nov 2019 10:04:01 +0000
Bug 1593665 - Increase font-weight of highlighted URLs and titles in the Megabar. r=mak Differential Revision: https://phabricator.services.mozilla.com/D51816
af5556dcd6bb19e49fff2b0d732f01262146b870: Bug 1594110 - Remove unused searchPrefsLink UI Tour target r=mak
Brian Grinstead <bgrinstead@mozilla.com> - Tue, 05 Nov 2019 18:03:57 +0000 - rev 500678
Push 114166 by apavel@mozilla.com at Thu, 07 Nov 2019 10:04:01 +0000
Bug 1594110 - Remove unused searchPrefsLink UI Tour target r=mak Differential Revision: https://phabricator.services.mozilla.com/D51741
27be25a455011635616815a9f2b798e4227bb712: Bug 1592172 - Quantumbar: Recreate result DOM as necessary when reusing rows, and don't try to update the overflow state of nonexistent tip URLs r=mak
Drew Willcoxon <adw@mozilla.com> - Tue, 05 Nov 2019 02:39:17 +0000 - rev 500520
Push 114166 by apavel@mozilla.com at Thu, 07 Nov 2019 10:04:01 +0000
Bug 1592172 - Quantumbar: Recreate result DOM as necessary when reusing rows, and don't try to update the overflow state of nonexistent tip URLs r=mak Differential Revision: https://phabricator.services.mozilla.com/D50899
d4ccc43984530b4f687407786d6f1358e6b389bd: Bug 1592172 - Quantumbar: Recreate result DOM as necessary when reusing rows, and don't try to update the overflow state of nonexistent tip URLs r=mak
Drew Willcoxon <adw@mozilla.com> - Tue, 05 Nov 2019 00:37:41 +0000 - rev 500475
Push 114164 by aiakab@mozilla.com at Tue, 05 Nov 2019 10:06:15 +0000
Bug 1592172 - Quantumbar: Recreate result DOM as necessary when reusing rows, and don't try to update the overflow state of nonexistent tip URLs r=mak Differential Revision: https://phabricator.services.mozilla.com/D50899
ccf26346c5be32d666795b7ea413662f31bd6865: Bug 1593659 - Put the search button behind a pref. r=mak
Harry Twyford <htwyford@mozilla.com> - Mon, 04 Nov 2019 20:40:40 +0000 - rev 500462
Push 114164 by aiakab@mozilla.com at Tue, 05 Nov 2019 10:06:15 +0000
Bug 1593659 - Put the search button behind a pref. r=mak Differential Revision: https://phabricator.services.mozilla.com/D51674
8aa733c22e794cd404a1f90f959ec1b5afe57199: Bug 1593661 - Extend the expanded megabar by 2px. r=mak
Harry Twyford <htwyford@mozilla.com> - Mon, 04 Nov 2019 20:25:51 +0000 - rev 500461
Push 114164 by aiakab@mozilla.com at Tue, 05 Nov 2019 10:06:15 +0000
Bug 1593661 - Extend the expanded megabar by 2px. r=mak Differential Revision: https://phabricator.services.mozilla.com/D51661
345aa7ad3051a3c4c74dab8f6505dc8c8d1248a7: Bug 1592157, convert LinkHandlerChild.jsm to JSWindowActor to support fission, r=mak
Neil Deakin <neil@mozilla.com> - Mon, 04 Nov 2019 14:48:04 +0000 - rev 500385
Push 114164 by aiakab@mozilla.com at Tue, 05 Nov 2019 10:06:15 +0000
Bug 1592157, convert LinkHandlerChild.jsm to JSWindowActor to support fission, r=mak Differential Revision: https://phabricator.services.mozilla.com/D51026
af790c1efe5d6e0ee45fad4c02f247467f11db0e: Bug 1591717 - Add a pref to notify of unvisited uris in the history service. r=mak,lina
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 04 Nov 2019 13:28:58 +0000 - rev 500358
Push 114164 by aiakab@mozilla.com at Tue, 05 Nov 2019 10:06:15 +0000
Bug 1591717 - Add a pref to notify of unvisited uris in the history service. r=mak,lina Behind a pref to ensure that we can turn this off pretty easily if it has perf impact. I want to leave the repainting stuff to another bug to land separately, to track potential (though I hope not!) perf regressions more easily. Differential Revision: https://phabricator.services.mozilla.com/D50704
b3ec0c1791741b820a5f2736335ac315a612155d: Bug 1588953 - Don't let UrlbarView::_openPanel display results before UrlbarInput::_updateLayoutBreakoutDimensions has finished. r=mak
Dão Gottwald <dao@mozilla.com> - Wed, 30 Oct 2019 14:21:33 +0000 - rev 499796
Push 114163 by aiakab@mozilla.com at Thu, 31 Oct 2019 10:03:38 +0000
Bug 1588953 - Don't let UrlbarView::_openPanel display results before UrlbarInput::_updateLayoutBreakoutDimensions has finished. r=mak Differential Revision: https://phabricator.services.mozilla.com/D51106
cf21b0dd7d7a9a86122ddf7a8cb6d412068b71e8: Bug 1591327 - Quantumbar: Properly limit results to maxResults while taking result spans into account. r=mak
Drew Willcoxon <adw@mozilla.com> - Tue, 29 Oct 2019 15:44:26 +0000 - rev 499638
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1591327 - Quantumbar: Properly limit results to maxResults while taking result spans into account. r=mak The muxer shouldn't decrease `maxResults`. The cropping in the providers manager should take result spans into account. I updated the result-span test to also check a non-restricting provider, which triggers this bug. Differential Revision: https://phabricator.services.mozilla.com/D50892
f915da42169e70bdd6711457966620e80f9fa774: Bug 1590816 - Remove a useless script blocker and comment from BaseHistory. r=mak
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 25 Oct 2019 13:02:39 +0000 - rev 499260
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1590816 - Remove a useless script blocker and comment from BaseHistory. r=mak This was copied verbatim from places, but the only thing the code can do is schedule runnables, which outlive the function, so there's no script that can run. Depends on D50502. Differential Revision: https://phabricator.services.mozilla.com/D50503
bdbaba80d7a0a185d1244b1a8124c29c56540918: Bug 1590816 - Cleanup some link coloring APIs to make them infallible when appropriate. r=mak
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 25 Oct 2019 13:02:25 +0000 - rev 499257
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1590816 - Cleanup some link coloring APIs to make them infallible when appropriate. r=mak GeckoView does this link clearing stuff (which is somewhat dubious), but always used to return NS_OK. The error handling case in Link.cpp was pretty broken anyway (it'd leave the link marked as registered), so make that infallible, given we fatally assert in the non-android case. NotifyVisited is also infallible so make that infallible too. There's no need to use NS_IMETHOD gunk when not using scriptable XPCOM, and these functions are not called from script, so make them regular pure-virtual functions. Depends on D50478. Differential Revision: https://phabricator.services.mozilla.com/D50480
10c5d5a32f62b543972e04ca75b9efd8626a2b31: Bug 1590816 - Various naming and comment cleanups, as suggested in review comments. r=mak
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 25 Oct 2019 13:02:23 +0000 - rev 499256
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1590816 - Various naming and comment cleanups, as suggested in review comments. r=mak Depends on D50266 Differential Revision: https://phabricator.services.mozilla.com/D50478
ceeff631a71b43578250a5e5b793a9afdfe52c9f: Bug 1590816 - Make GetLinkDocument a static function again. r=mak
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 25 Oct 2019 13:02:22 +0000 - rev 499255
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1590816 - Make GetLinkDocument a static function again. r=mak Now without a duplicate version on another file :) Differential Revision: https://phabricator.services.mozilla.com/D50266
b93b7fb6f7f7fc66f945695e0472a85b255d8254: Bug 1590816 - Move NotifyVisited to BaseHistory. r=mak,lina
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 25 Oct 2019 13:02:20 +0000 - rev 499254
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1590816 - Move NotifyVisited to BaseHistory. r=mak,lina Differential Revision: https://phabricator.services.mozilla.com/D50265
f9c5be57dacb238c17bf26bdbc2c4fec1fc173cf: Bug 1590816 - Move Register and UnregisterVisitedCallback to BaseHistory. r=mak,lina
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 25 Oct 2019 13:02:18 +0000 - rev 499253
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1590816 - Move Register and UnregisterVisitedCallback to BaseHistory. r=mak,lina Differential Revision: https://phabricator.services.mozilla.com/D50264
f18c7c05ffd0d91be2c663d285a28919d106d72c: Bug 1590816 - Move History::DispatchNotifyVisited and related code to BaseHistory. r=mak,lina
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 25 Oct 2019 13:02:16 +0000 - rev 499252
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1590816 - Move History::DispatchNotifyVisited and related code to BaseHistory. r=mak,lina Interestingly the android implementation had a potentially serious bug (was missing a script blocker). Differential Revision: https://phabricator.services.mozilla.com/D50263
d5c1df050f9fe8fcd81cc0f0c0f3e92e5ee3501f: Bug 1590816 - Introduce mozilla::BaseHistory, and move tracked URIs and a simple function there. r=mak
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 25 Oct 2019 13:02:08 +0000 - rev 499251
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1590816 - Introduce mozilla::BaseHistory, and move tracked URIs and a simple function there. r=mak Differential Revision: https://phabricator.services.mozilla.com/D50262
60601417a73113421f66c338dc4cb9527f3ecce6: Bug 1590816 - Simplify a rather weird ifdef set. r=mak
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 25 Oct 2019 13:02:06 +0000 - rev 499250
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1590816 - Simplify a rather weird ifdef set. r=mak GetHistoryService should work everywhere. Differential Revision: https://phabricator.services.mozilla.com/D50261
c340ffe9aa3bee8f733095af07d04bf9ca7b3e4a: Bug 1590816 - Move the tracked URIs hash table to IHistory. r=mak
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 25 Oct 2019 13:02:04 +0000 - rev 499249
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1590816 - Move the tracked URIs hash table to IHistory. r=mak In preparation for moving all the link coloring code. Differential Revision: https://phabricator.services.mozilla.com/D50260
c0b1c51a4ef38112e097a82b807131e2f82c1a53: Bug 1590816 - Use the same data structures for GeckoViewHistory and places History. r=mak
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 25 Oct 2019 13:02:02 +0000 - rev 499248
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1590816 - Use the same data structures for GeckoViewHistory and places History. r=mak Differential Revision: https://phabricator.services.mozilla.com/D50259
c0ca50bb81ce068022cea0a1005c89bdcdde8c80: Bug 1590816 - Use a more modern hash table for mRecentlyVisitedURI. r=mak
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 25 Oct 2019 13:02:00 +0000 - rev 499247
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1590816 - Use a more modern hash table for mRecentlyVisitedURI. r=mak In preparation to unify the link coloring code with GeckoViewHistory, which uses these hashtables for the equivalent of mObservers, it'd be good if we'd be using the same. Differential Revision: https://phabricator.services.mozilla.com/D50258
6cab6abf119e885459e30d7d40bff8ea1317fa92: Bug 1590816 - Marginally cleanup an error case in the history service. r=mak
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 25 Oct 2019 13:01:53 +0000 - rev 499246
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1590816 - Marginally cleanup an error case in the history service. r=mak Differential Revision: https://phabricator.services.mozilla.com/D50257
ae141ea79cb898194884bf477830f6d7d816f1ba: Bug 1590816 - Improve assertions in history service. r=mak
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 25 Oct 2019 13:01:51 +0000 - rev 499245
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1590816 - Improve assertions in history service. r=mak Differential Revision: https://phabricator.services.mozilla.com/D50256
06754561e77e1c48224e05eda7151bb02c0130f0: Bug 1591043 - Tweak megabar search icon margin. r=mak
Dão Gottwald <dao@mozilla.com> - Fri, 25 Oct 2019 08:45:47 +0000 - rev 499223
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1591043 - Tweak megabar search icon margin. r=mak Differential Revision: https://phabricator.services.mozilla.com/D50479
b40527d329bd31f5b8f453b35c5406fb82124308: Bug 1591012 - Fix Megabar search icon color with webextension themes. r=mak
Dão Gottwald <dao@mozilla.com> - Thu, 24 Oct 2019 12:25:02 +0000 - rev 499092
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1591012 - Fix Megabar search icon color with webextension themes. r=mak Differential Revision: https://phabricator.services.mozilla.com/D50446
36e230321fd00eab502391f7a16aff4aef35364d: Bug 1582234 - Change the meaning of browser.urlbar.suggest.bookmark = false so that visited bookmarks are autofilled but unvisited bookmarks still are not. r=mak
Drew Willcoxon <adw@mozilla.com> - Wed, 23 Oct 2019 16:09:31 +0000 - rev 498727
Push 114159 by shindli@mozilla.com at Thu, 24 Oct 2019 09:49:00 +0000
Bug 1582234 - Change the meaning of browser.urlbar.suggest.bookmark = false so that visited bookmarks are autofilled but unvisited bookmarks still are not. r=mak When suggest.history = true and suggest.bookmark = false, change the inclusion logic from `NOT bookmarked` to `visited OR NOT bookmarked`. That will include visited bookmarks above the autofill threshold but still exclude unvisited bookmarks. This also renames the various SQL query consts to better reflect when they are used: `HISTORY_BOOKMARK` for when both suggest.history and suggest.bookmark = true, `HISTORY` for when only suggest.history = true, and `BOOKMARK` for when only suggest.bookmark = true. Finally, it adds a bunch of test tasks consistent with the other existing autofill test tasks. Differential Revision: https://phabricator.services.mozilla.com/D50146