searching for reviewer(luke)
f1b6b50a1b9a: Bug 1469006 - Replace some script->compartment() calls with script->realm(). r=luke
Jan de Mooij <jdemooij@mozilla.com> - Fri, 22 Jun 2018 09:54:22 +0200 - rev 423306
Push 104532 by jandemooij@gmail.com at 2018-06-22 07:59 +0000
Bug 1469006 - Replace some script->compartment() calls with script->realm(). r=luke
ca13bbbbb8c5: Bug 1459900 - Rename Sig as FuncType, transitively. rs=luke
Lars T Hansen <lhansen@mozilla.com> - Thu, 21 Jun 2018 10:30:48 +0200 - rev 423301
Push 104527 by lhansen@mozilla.com at 2018-06-22 06:06 +0000
Bug 1459900 - Rename Sig as FuncType, transitively. rs=luke
ca90f5e47f46: Bug 1459900 - Struct types: read, write, validate. r=luke
Lars T Hansen <lhansen@mozilla.com> - Tue, 08 May 2018 14:18:30 +0200 - rev 423241
Push 104507 by lhansen@mozilla.com at 2018-06-21 14:50 +0000
Bug 1459900 - Struct types: read, write, validate. r=luke We introduce a simple "struct" type definition for Wasm. A struct has fields of primitive types, including anyref, but no other information, notably no information about subtype relationships. The syntax is: (type $tname (struct (field $fname i32) ...)) where the $fnames are currently ignored. (In the future, the $fnames will denote the field numbers of their fields within the structure and will be used by the struct.get and struct.set instructions in the text format. If any $fname is bound in multiple structures the bindings must resolve to the same field number and field type.) To record the type information there is a new StructType type in WasmTypes.h. We generalize the SigWithId table in ModuleEnvironment to instead be a TypeDef table, where a TypeDef is a tagged union of SigWithId and StructType. Similarly, there is a new AstTypeDef base class for AstSig and AstStruct, and the sigs_ table in AstModule becomes a types_ table. When the ModuleEnvironment is about to be destroyed we move the StructType types into a dense structTypes_ table in the Module; a later patch will make use of these types. The structTypes_ get serialized and deserialized with the module.
82874b00bab0: Bug 1459900 - Struct types: read, write, validate. r=luke
Lars T Hansen <lhansen@mozilla.com> - Tue, 08 May 2018 14:18:30 +0200 - rev 423206
Push 104492 by lhansen@mozilla.com at 2018-06-21 08:12 +0000
Bug 1459900 - Struct types: read, write, validate. r=luke We introduce a simple "struct" type definition for Wasm. A struct has fields of primitive types, including anyref, but no other information, notably no information about subtype relationships. The syntax is: (type $tname (struct (field $fname i32) ...)) where the $fnames are currently ignored. (In the future, the $fnames will denote the field numbers of their fields within the structure and will be used by the struct.get and struct.set instructions in the text format. If any $fname is bound in multiple structures the bindings must resolve to the same field number and field type.) To record the type information there is a new StructType type in WasmTypes.h. We generalize the SigWithId table in ModuleEnvironment to instead be a TypeDef table, where a TypeDef is a tagged union of SigWithId and StructType. Similarly, there is a new AstTypeDef base class for AstSig and AstStruct, and the sigs_ table in AstModule becomes a types_ table. When the ModuleEnvironment is about to be destroyed we move the StructType types into a dense structTypes_ table in the Module; a later patch will make use of these types. The structTypes_ get serialized and deserialized with the module.
40461ea89e0c: Bug 1466503 part 3 - Check realms instead of compartments in JSContext::currentScript. r=luke
Jan de Mooij <jdemooij@mozilla.com> - Wed, 20 Jun 2018 17:45:07 +0200 - rev 423093
Push 104465 by jandemooij@gmail.com at 2018-06-20 15:51 +0000
Bug 1466503 part 3 - Check realms instead of compartments in JSContext::currentScript. r=luke
92d154bc6515: Bug 1466503 part 2 - Some DescribeScriptedCallerForCompilation cleanup. r=luke
Jan de Mooij <jdemooij@mozilla.com> - Wed, 20 Jun 2018 17:45:06 +0200 - rev 423092
Push 104465 by jandemooij@gmail.com at 2018-06-20 15:51 +0000
Bug 1466503 part 2 - Some DescribeScriptedCallerForCompilation cleanup. r=luke
44a69a4ebc09: Bug 1437600 - Use mprotect to prevent mutations of inaccessible regions. r=luke
Nicolas B. Pierron <nicolas.b.pierron@gmail.com> - Wed, 14 Feb 2018 17:12:00 +0000 - rev 423090
Push 104464 by npierron@mozilla.com at 2018-06-20 15:41 +0000
Bug 1437600 - Use mprotect to prevent mutations of inaccessible regions. r=luke
77b8ddea1fbd: Bug 1468406 part 4 - Remove remaining JSObject::realm() calls. r=luke
Jan de Mooij <jdemooij@mozilla.com> - Wed, 20 Jun 2018 11:04:02 +0200 - rev 423088
Push 104462 by jandemooij@gmail.com at 2018-06-20 14:39 +0000
Bug 1468406 part 4 - Remove remaining JSObject::realm() calls. r=luke
49cbcdeaa8bb: Bug 1468406 part 4 - Remove remaining JSObject::realm() calls. r=luke
Jan de Mooij <jdemooij@mozilla.com> - Wed, 20 Jun 2018 11:04:02 +0200 - rev 423038
Push 104449 by jandemooij@gmail.com at 2018-06-20 09:09 +0000
Bug 1468406 part 4 - Remove remaining JSObject::realm() calls. r=luke
8695dbfdc556: Bug 1468406 part 1 - Add NativeObject::realm(), forwarding to JSObject::realm() for now. r=luke
Jan de Mooij <jdemooij@mozilla.com> - Mon, 18 Jun 2018 12:41:27 -0700 - rev 422853
Push 104378 by jandemooij@gmail.com at 2018-06-18 19:42 +0000
Bug 1468406 part 1 - Add NativeObject::realm(), forwarding to JSObject::realm() for now. r=luke
7cd314fe93e3: Bug 1465081 - Preserve bytecode if there's a module name subsection. r=luke
Benjamin Bouvier <benj@benj.me> - Thu, 14 Jun 2018 22:53:11 +0200 - rev 422642
Push 104313 by aciure@mozilla.com at 2018-06-15 09:51 +0000
Bug 1465081 - Preserve bytecode if there's a module name subsection. r=luke
24d8e05af3d9: Bug 1464790 - js/src/wasm/WasmTypes.h: define MaxMemoryAccessSize correctly. r=luke.
Julian Seward <jseward@acm.org> - Thu, 14 Jun 2018 23:00:13 +0200 - rev 422568
Push 104302 by jseward@mozilla.com at 2018-06-15 00:30 +0000
Bug 1464790 - js/src/wasm/WasmTypes.h: define MaxMemoryAccessSize correctly. r=luke. Currently we have MaxMemoryAccessSize = sizeof(Val). That doesn't seem right, since it includes not only the size of the largest underlying value, but also the size of the tag (Val::type_) field. Indeed, printing MaxMemoryAccessSize produces 24 on x86_64 and 20 on x86. This patch fixes it, and adds some sanity checks too.
fc2ffbc36c07: Bug 1468252 part 8 - Rename JSObject::global to deprecatedGlobal. r=luke
Jan de Mooij <jdemooij@mozilla.com> - Thu, 14 Jun 2018 09:07:32 -0700 - rev 422548
Push 104289 by jandemooij@gmail.com at 2018-06-14 16:13 +0000
Bug 1468252 part 8 - Rename JSObject::global to deprecatedGlobal. r=luke
5a19b871c590: Bug 1468252 part 7 - Replace more environment->global() calls. r=luke
Jan de Mooij <jdemooij@mozilla.com> - Thu, 14 Jun 2018 09:07:31 -0700 - rev 422547
Push 104289 by jandemooij@gmail.com at 2018-06-14 16:13 +0000
Bug 1468252 part 7 - Replace more environment->global() calls. r=luke
3d767ed287af: Bug 1468252 part 4 - Add JSObject::nonCCWGlobal() and use it in a few places. r=luke
Jan de Mooij <jdemooij@mozilla.com> - Thu, 14 Jun 2018 09:07:31 -0700 - rev 422544
Push 104289 by jandemooij@gmail.com at 2018-06-14 16:13 +0000
Bug 1468252 part 4 - Add JSObject::nonCCWGlobal() and use it in a few places. r=luke
4face648a152: Bug 1468252 part 3 - Remove some environment->global() calls. r=luke
Jan de Mooij <jdemooij@mozilla.com> - Thu, 14 Jun 2018 09:07:31 -0700 - rev 422543
Push 104289 by jandemooij@gmail.com at 2018-06-14 16:13 +0000
Bug 1468252 part 3 - Remove some environment->global() calls. r=luke
671e4d24c511: Bug 1468252 part 1 - Define NativeObject::global(). r=luke
Jan de Mooij <jdemooij@mozilla.com> - Thu, 14 Jun 2018 09:07:30 -0700 - rev 422541
Push 104289 by jandemooij@gmail.com at 2018-06-14 16:13 +0000
Bug 1468252 part 1 - Define NativeObject::global(). r=luke
cceb75ca1a1d: Bug 1466121 part 7 - Split Compartment-inl.h from Realm-inl.h. r=luke
Jan de Mooij <jdemooij@mozilla.com> - Fri, 08 Jun 2018 16:16:21 +0200 - rev 421950
Push 104148 by jandemooij@gmail.com at 2018-06-08 14:22 +0000
Bug 1466121 part 7 - Split Compartment-inl.h from Realm-inl.h. r=luke
45e231683dbf: Bug 1466121 part 6 - Split Compartment.cpp from Realm.cpp. r=luke
Jan de Mooij <jdemooij@mozilla.com> - Fri, 08 Jun 2018 16:16:20 +0200 - rev 421949
Push 104148 by jandemooij@gmail.com at 2018-06-08 14:22 +0000
Bug 1466121 part 6 - Split Compartment.cpp from Realm.cpp. r=luke
af265d75fc00: Bug 1466121 part 5 - Split Compartment.h from Realm.h. r=luke
Jan de Mooij <jdemooij@mozilla.com> - Fri, 08 Jun 2018 16:16:19 +0200 - rev 421948
Push 104148 by jandemooij@gmail.com at 2018-06-08 14:22 +0000
Bug 1466121 part 5 - Split Compartment.h from Realm.h. r=luke
ac87103cdf38: Bug 1466121 part 4 - Rename vm/JSCompartment* to vm/Realm*. r=luke
Jan de Mooij <jdemooij@mozilla.com> - Fri, 08 Jun 2018 16:16:19 +0200 - rev 421947
Push 104148 by jandemooij@gmail.com at 2018-06-08 14:22 +0000
Bug 1466121 part 4 - Rename vm/JSCompartment* to vm/Realm*. r=luke
4db98fad2f4e: Bug 1466121 part 3 - Merge Realm.cpp into JSCompartment.cpp to simplify later patches. r=luke
Jan de Mooij <jdemooij@mozilla.com> - Fri, 08 Jun 2018 16:16:18 +0200 - rev 421946
Push 104148 by jandemooij@gmail.com at 2018-06-08 14:22 +0000
Bug 1466121 part 3 - Merge Realm.cpp into JSCompartment.cpp to simplify later patches. r=luke
e3b458961e04: Bug 1466121 part 2 - Make Compartment and Zone classes instead of structs. r=luke
Jan de Mooij <jdemooij@mozilla.com> - Thu, 07 Jun 2018 16:45:04 +0200 - rev 421740
Push 104103 by jandemooij@gmail.com at 2018-06-07 14:48 +0000
Bug 1466121 part 2 - Make Compartment and Zone classes instead of structs. r=luke
b640dc9b8998: Bug 1466121 part 1 - Rename JSCompartment to JS::Compartment. r=luke
Jan de Mooij <jdemooij@mozilla.com> - Thu, 07 Jun 2018 16:44:40 +0200 - rev 421739
Push 104103 by jandemooij@gmail.com at 2018-06-07 14:48 +0000
Bug 1466121 part 1 - Rename JSCompartment to JS::Compartment. r=luke
60828108f4b8: Bug 1466458 part 2 - Refactor Realm::enterRealmDepth_ to account for Realms entered from JIT code. r=luke
Jan de Mooij <jdemooij@mozilla.com> - Thu, 07 Jun 2018 12:18:43 +0200 - rev 421724
Push 104094 by jandemooij@gmail.com at 2018-06-07 10:19 +0000
Bug 1466458 part 2 - Refactor Realm::enterRealmDepth_ to account for Realms entered from JIT code. r=luke
b968ba27d88c: Bug 1466458 part 1 - Remove JSContext::enterRealmDepth_. r=luke
Jan de Mooij <jdemooij@mozilla.com> - Thu, 07 Jun 2018 12:17:08 +0200 - rev 421723
Push 104094 by jandemooij@gmail.com at 2018-06-07 10:19 +0000
Bug 1466458 part 1 - Remove JSContext::enterRealmDepth_. r=luke
4b6608413e08: Bug 1466501 part 3 - Add an objectGlobal(obj) testing function. r=luke
Jan de Mooij <jdemooij@mozilla.com> - Thu, 07 Jun 2018 10:02:10 +0200 - rev 421679
Push 104087 by jandemooij@gmail.com at 2018-06-07 08:04 +0000
Bug 1466501 part 3 - Add an objectGlobal(obj) testing function. r=luke
22ea0700931c: Bug 1466501 part 2 - Add a scriptedCallerGlobal() testing function for JS::GetScriptedCallerGlobal. r=luke
Jan de Mooij <jdemooij@mozilla.com> - Thu, 07 Jun 2018 10:02:10 +0200 - rev 421678
Push 104087 by jandemooij@gmail.com at 2018-06-07 08:04 +0000
Bug 1466501 part 2 - Add a scriptedCallerGlobal() testing function for JS::GetScriptedCallerGlobal. r=luke
6bbae91a2eaf: Bug 1466501 part 1 - Refactor ZoneSpecifier and add a sameCompartmentAs option to newGlobal in the shell. r=luke
Jan de Mooij <jdemooij@mozilla.com> - Thu, 07 Jun 2018 10:02:10 +0200 - rev 421677
Push 104087 by jandemooij@gmail.com at 2018-06-07 08:04 +0000
Bug 1466501 part 1 - Refactor ZoneSpecifier and add a sameCompartmentAs option to newGlobal in the shell. r=luke
bf5be9b21c3c: Bug 1466083 part 8 - Various minor API changes. r=luke
Jan de Mooij <jdemooij@mozilla.com> - Wed, 06 Jun 2018 12:55:50 +0200 - rev 421559
Push 104059 by jandemooij@gmail.com at 2018-06-06 10:56 +0000
Bug 1466083 part 8 - Various minor API changes. r=luke * GetScriptCompartment => GetScriptRealm * Adds IsSystemRealm in addition to IsSystemCompartment and uses it where we can. * JS_GetCompartmentPrincipals and IsSystemCompartment now release-assert they have a single realm. This is temporary until we know what Gecko will do/need exactly.
eff5e370cb33: Bug 1466083 part 7 - Replace GetCompartmentZone with GetRealmZone. r=luke
Jan de Mooij <jdemooij@mozilla.com> - Wed, 06 Jun 2018 12:55:50 +0200 - rev 421558
Push 104059 by jandemooij@gmail.com at 2018-06-06 10:56 +0000
Bug 1466083 part 7 - Replace GetCompartmentZone with GetRealmZone. r=luke
84aa50d4663a: Bug 1465728 part 2 - Remove the compartment name callback. r=luke
Jan de Mooij <jdemooij@mozilla.com> - Wed, 06 Jun 2018 11:44:17 +0200 - rev 421500
Push 104055 by jandemooij@gmail.com at 2018-06-06 09:45 +0000
Bug 1465728 part 2 - Remove the compartment name callback. r=luke
df11dced021e: Bug 1429818 - Make wasm sign extension feature unconditional. r=luke
Lars T Hansen <lhansen@mozilla.com> - Thu, 22 Mar 2018 09:06:20 +0100 - rev 421030
Push 103967 by lhansen@mozilla.com at 2018-06-04 09:43 +0000
Bug 1429818 - Make wasm sign extension feature unconditional. r=luke Remove the feature define and all the ifdefs that use it. Remove the TestingFunctions predicate that reveals the value of the define. Update the test cases that used the predicate.
a4187e4b06ee: Bug 1464772 part 4 - Use cx->realm()->creationOptions() instead of RealmCreationOptionsRef in NowAsMillis. r=luke
Jan de Mooij <jdemooij@mozilla.com> - Sun, 03 Jun 2018 12:22:29 +0200 - rev 420993
Push 103954 by jandemooij@gmail.com at 2018-06-03 10:23 +0000
Bug 1464772 part 4 - Use cx->realm()->creationOptions() instead of RealmCreationOptionsRef in NowAsMillis. r=luke
e3a6af0b27ec: Bug 1464772 part 3 - Remove unused RealmCreationOptionsRef(obj). r=luke
Jan de Mooij <jdemooij@mozilla.com> - Sun, 03 Jun 2018 12:22:29 +0200 - rev 420992
Push 103954 by jandemooij@gmail.com at 2018-06-03 10:23 +0000
Bug 1464772 part 3 - Remove unused RealmCreationOptionsRef(obj). r=luke
f58f5333e375: Bug 1464772 part 2 - Remove RealmBehaviorsRef(obj), change RealmBehaviorsRef(compartment) to take a realm. r=luke
Jan de Mooij <jdemooij@mozilla.com> - Sun, 03 Jun 2018 12:22:28 +0200 - rev 420991
Push 103954 by jandemooij@gmail.com at 2018-06-03 10:23 +0000
Bug 1464772 part 2 - Remove RealmBehaviorsRef(obj), change RealmBehaviorsRef(compartment) to take a realm. r=luke At some point I'll audit the obj->realm() calls for CCWs; removing RealmBehaviorsRef(obj) prepares for that. Also, RealmBehaviorsRef(realm) could be removed and we could use RealmBehaviorsRef(cx) everywhere, but it seems reasonable to keep it.
480eb5a4c02e: Bug 1466083 part 2 - Replace JSRuntime::numCompartments with JSRuntime::numRealms. r=luke
Jan de Mooij <jdemooij@mozilla.com> - Sat, 02 Jun 2018 11:58:28 +0200 - rev 420975
Push 103949 by jandemooij@gmail.com at 2018-06-02 10:03 +0000
Bug 1466083 part 2 - Replace JSRuntime::numCompartments with JSRuntime::numRealms. r=luke
497592872516: Bug 1466083 part 1 - Make IterateScripts take a realm instead of a compartment. r=luke
Jan de Mooij <jdemooij@mozilla.com> - Sat, 02 Jun 2018 11:58:27 +0200 - rev 420974
Push 103949 by jandemooij@gmail.com at 2018-06-02 10:03 +0000
Bug 1466083 part 1 - Make IterateScripts take a realm instead of a compartment. r=luke
8733db9b64b0: Bug 1465002 part 2 - Don't skip wasm frames in GetScriptedCallerActivationRealmFast. r=luke
Jan de Mooij <jdemooij@mozilla.com> - Fri, 01 Jun 2018 19:23:14 +0200 - rev 420894
Push 103921 by jandemooij@gmail.com at 2018-06-01 17:24 +0000
Bug 1465002 part 2 - Don't skip wasm frames in GetScriptedCallerActivationRealmFast. r=luke
99519e97491a: Bug 1464374 part 7 - Use GetRealmPrincipals in GetCompartmentName. r=luke
Jan de Mooij <jdemooij@mozilla.com> - Thu, 31 May 2018 11:28:49 +0200 - rev 420585
Push 103843 by jandemooij@gmail.com at 2018-05-31 09:29 +0000
Bug 1464374 part 7 - Use GetRealmPrincipals in GetCompartmentName. r=luke This will become GetRealmName at some point.
98f31ca33d2a: Bug 1464374 part 5 - Use GetRealmPrincipals in AsmJSCacheOpenEntryFor{Read,Write}. r=luke
Jan de Mooij <jdemooij@mozilla.com> - Thu, 31 May 2018 11:28:49 +0200 - rev 420583
Push 103843 by jandemooij@gmail.com at 2018-05-31 09:29 +0000
Bug 1464374 part 5 - Use GetRealmPrincipals in AsmJSCacheOpenEntryFor{Read,Write}. r=luke
e2b90c69db5d: Bug 1464374 part 2 - Pass JS::Realm* instead of JSCompartment* to CallSetup. r=bz,luke
Jan de Mooij <jdemooij@mozilla.com> - Thu, 31 May 2018 11:28:48 +0200 - rev 420580
Push 103843 by jandemooij@gmail.com at 2018-05-31 09:29 +0000
Bug 1464374 part 2 - Pass JS::Realm* instead of JSCompartment* to CallSetup. r=bz,luke The principals are on the realm so we need a realm instead of a compartment. Also adds js::GetNonCCWObjectRealm to get the realm of a non-CCW object.
a42a47e58247: Bug 1464134 part 1 - Fix various places to use Realm instead of JSCompartment. r=luke
Jan de Mooij <jdemooij@mozilla.com> - Thu, 31 May 2018 11:28:48 +0200 - rev 420579
Push 103843 by jandemooij@gmail.com at 2018-05-31 09:29 +0000
Bug 1464134 part 1 - Fix various places to use Realm instead of JSCompartment. r=luke
74279538a616: Bug 1465037 - Fix FrameIter principals check to work with same-compartment realms. r=luke
Jan de Mooij <jdemooij@mozilla.com> - Thu, 31 May 2018 07:19:08 +0200 - rev 420562
Push 103837 by jandemooij@gmail.com at 2018-05-31 05:20 +0000
Bug 1465037 - Fix FrameIter principals check to work with same-compartment realms. r=luke The principals are now on the realm and an activation will contain cross-realm calls, so the principals need to be checked for each frame instead of each activation.
2fddfc4fff54: Bug 1465002 - Make GetScriptedCallerGlobal work with same-compartment realms. r=luke
Jan de Mooij <jdemooij@mozilla.com> - Thu, 31 May 2018 07:18:52 +0200 - rev 420561
Push 103837 by jandemooij@gmail.com at 2018-05-31 05:20 +0000
Bug 1465002 - Make GetScriptedCallerGlobal work with same-compartment realms. r=luke
24a0788bae5f: Bug 1464134 part 7 - Replace GetAnyCompartmentInZone with GetAnyRealmInZone. r=luke
Jan de Mooij <jdemooij@mozilla.com> - Wed, 30 May 2018 20:14:19 +0200 - rev 420488
Push 103824 by jandemooij@gmail.com at 2018-05-30 18:19 +0000
Bug 1464134 part 7 - Replace GetAnyCompartmentInZone with GetAnyRealmInZone. r=luke
fc4c476186ab: Bug 1464789 - If page-size is not 4K, the function of LazyStubTier::createMany would trigger a segment fault within executableCopy. r=luke
qiaopengcheng <qiaopengcheng-hf@loongson.cn> - Mon, 28 May 2018 18:16:00 +0300 - rev 420451
Push 103813 by rgurzau@mozilla.com at 2018-05-30 14:22 +0000
Bug 1464789 - If page-size is not 4K, the function of LazyStubTier::createMany would trigger a segment fault within executableCopy. r=luke
fa0f453c5be9: Bug 1459900 - Adapt ValType to accomodate reference types. r=luke
Lars T Hansen <lhansen@mozilla.com> - Thu, 24 May 2018 15:42:15 +0200 - rev 420420
Push 103803 by lhansen@mozilla.com at 2018-05-30 10:42 +0000
Bug 1459900 - Adapt ValType to accomodate reference types. r=luke
bf36035bed13: Bug 1464134 part 1 - Fix various places to use Realm instead of JSCompartment. r=luke
Jan de Mooij <jdemooij@mozilla.com> - Sun, 27 May 2018 11:53:11 +0200 - rev 420059
Push 103697 by jandemooij@gmail.com at 2018-05-27 09:53 +0000
Bug 1464134 part 1 - Fix various places to use Realm instead of JSCompartment. r=luke
a33765bea383: Bug 1463371 - Revert to previous behaviour for setting module resolve hook in the shell r=luke
Jon Coppeard <jcoppeard@mozilla.com> - Fri, 25 May 2018 10:39:40 +0100 - rev 419796
Push 103626 by jcoppeard@mozilla.com at 2018-05-25 09:42 +0000
Bug 1463371 - Revert to previous behaviour for setting module resolve hook in the shell r=luke