searching for reviewer(longsonr)
ed2612dfc5c2f9a7c0fd5babe407e658f4371d6c: Bug 1585863 - Remove nsChangeHint_UpdateTextPath. r=longsonr
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 08 Oct 2019 21:52:47 +0000 - rev 496830
Push
114146 by dmajor@mozilla.com at Wed, 09 Oct 2019 17:52:49 +0000
Bug 1585863 - Remove nsChangeHint_UpdateTextPath. r=longsonr
The only thing it does is asserting a bit and posting more async work to the
text frame. It seems we can just post all the async work early instead, and
remove the change hint.
This was only introduced to fix
bug 779971, where a <textPath> element
references its parent SVG, which is obviously unsound if we allowed to render
it.
What we're doing right now is a bit silly... We're observing the <svg>, so when
we finish reflowing it and store its overflow, we invalidate its rendering
observers, but that invalidates a _descendant_, which makes no sense.
Fortunately we don't let the element affect its rendering, as it fails this
check:
* https://searchfox.org/mozilla-central/rev/35cc00a25c4471993fdaa5761952bd3afd4f1731/layout/svg/SVGObserverUtils.cpp#1390
But we still request reflow of the outer <text>, which is not amazing. We
shouldn't invalidate anything if the textpath doesn't reference a valid element
and that didn't change. This is roughly what the code tried to do when checking
mValid, except we always initialize mValid to true and thus always trigger at
least one bogus reflow call.
Differential Revision:
https://phabricator.services.mozilla.com/D48008
4495ef2bbb0cc8ef69ad71620484beee2b5a4582: Bug 1582506. Remove some pointless null-checks in SVG code. r=longsonr
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 20 Sep 2019 06:02:10 +0000 - rev 494273
Push
114114 by dluca@mozilla.com at Fri, 20 Sep 2019 22:00:08 +0000
Bug 1582506. Remove some pointless null-checks in SVG code. r=longsonr
Assuming our caller didn't mess up passing the reference (and code inspection
suggests callers did not thus mess up), we should not have null when we take a
pointer to the reference.
Differential Revision:
https://phabricator.services.mozilla.com/D46506
0b9d726f140203f807d04ddabd499a37589bdfd1: Bug 1581399 - Remove useless rule in svg.css. r=longsonr
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 15 Sep 2019 17:39:12 +0000 - rev 493302
Push
114087 by csabou@mozilla.com at Mon, 16 Sep 2019 09:47:02 +0000
Bug 1581399 - Remove useless rule in svg.css. r=longsonr
It was added in
bug 256624, but -moz-binding is no longer exposed to content so
it doesn't do anything.
Differential Revision:
https://phabricator.services.mozilla.com/D45954
076af5db788815042df2190e620c9dbc5911b3b1: Bug 1579181 - Don't keep <use> shadow trees which we know we'll never render. r=longsonr
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 15 Sep 2019 16:09:28 +0000 - rev 493293
Push
114086 by aciure@mozilla.com at Sun, 15 Sep 2019 21:45:19 +0000
Bug 1579181 - Don't keep <use> shadow trees which we know we'll never render. r=longsonr
This partially addresses the regression, but not fully. With this patch we don't
maintain shadow trees for nodes that we know won't get rendered.
This works fast in WebKit / Blink because of a bug in their implementation which
doesn't synchronize style attributes, introduced in [1].
You can see this clearly if you click on the bug's test-case and inspect the
<use> shadow trees (there's no style="stroke:orange" whatsoever).
They can kinda get away with it because they don't properly implement SVG 2. In
particular, in Blink / WebKit, the style of the element in the <use> shadow tree
is the style of the referenced element, which means that even if the style
attribute isn't properly synced it's ~ok since it doesn't end up mattering for
styling.
Easiest test-case for the behavior difference is:
```
<!doctype html>
<style>
rect:hover {
fill: green;
}
</style>
<svg width=300 height=300>
<g id="canvas">
<rect fill=red width=100 height=100></rect>
</g>
<g>
<use x=200 href="#canvas"></use>
</g>
</svg>
```
Where Firefox will properly update each square independently when hovered, but
Blink / WebKit won't.
This used to work faster because in this particular test-case we have 3 hidden
<use> elements whose href is the #canvas, which is basically everything.
Before moving to shadow trees we'd do it using anonymous content, and since we
never got a frame we'd never clone the subtree in the first case.
This case was faster before
bug 1450250, but this approach makes other cases
slow that were fixed by that bug, like
bug 1485402.
So I'll try to optimize shadow tree syncing instead, I guess, but there's no
good reason not to land this in the meantime IMHO.
[1]: https://chromium.googlesource.com/chromium/src/+/f4b022e64bbe0c74f07ee9209aa4033bddece145%5E%21/third_party/WebKit/WebCore/svg/SVGElement.cpp
Differential Revision:
https://phabricator.services.mozilla.com/D45953
7e6ac55da4ff1ed35e1890b07dc331822a22e8eb: Bug 1566697 - Fix unified build problem. r=longsonr
Cameron McCormack <cam@mcc.id.au> - Wed, 17 Jul 2019 06:13:49 +0000 - rev 483068
Push
113703 by archaeopteryx@coole-files.de at Wed, 17 Jul 2019 16:57:18 +0000
Bug 1566697 - Fix unified build problem. r=longsonr
Differential Revision:
https://phabricator.services.mozilla.com/D38262
07e44731e886fa27c919a6dc9f2c46105bf04ae5: Bug 1555851 - Detect motion path measurement failures. r=longsonr
Cameron McCormack <cam@mcc.id.au> - Tue, 09 Jul 2019 01:26:52 +0000 - rev 481777
Push
113636 by rgurzau@mozilla.com at Tue, 09 Jul 2019 10:11:06 +0000
Bug 1555851 - Detect motion path measurement failures. r=longsonr
Differential Revision:
https://phabricator.services.mozilla.com/D37337
09b3d826af112c35179e87ea0ac804d787cbc2ba: Bug 1557245 - Support overflow:visible for foreignObject r=longsonr
violet <violet.bugreport@gmail.com> - Tue, 25 Jun 2019 18:03:47 +0000 - rev 480119
Push
113524 by shindli@mozilla.com at Wed, 26 Jun 2019 09:40:36 +0000
Bug 1557245 - Support overflow:visible for foreignObject r=longsonr
Differential Revision:
https://phabricator.services.mozilla.com/D35760
66cb2acf5a9e406f9c32b20cb522fb3b12b1c5e5: Bug 1561352: Rewrite WPT test viewBox-scaling-text-001.html to not depend on Ahem font having X-with-diacritics character. r=longsonr
Daniel Holbert <dholbert@cs.stanford.edu> - Tue, 25 Jun 2019 18:02:21 +0000 - rev 480074
Push
113520 by aiakab@mozilla.com at Tue, 25 Jun 2019 22:10:20 +0000
Bug 1561352: Rewrite WPT test viewBox-scaling-text-001.html to not depend on Ahem font having X-with-diacritics character. r=longsonr
Differential Revision:
https://phabricator.services.mozilla.com/D35833
4d57aaf5c4298fc9549df0b4f5ab375839daaf8b: Bug 1544432 part 2: Add WPT for text being scaled up via SVG viewBox. r=longsonr
Daniel Holbert <dholbert@cs.stanford.edu> - Fri, 21 Jun 2019 10:16:08 -0700 - rev 479956
Push
113509 by dholbert@mozilla.com at Tue, 25 Jun 2019 06:29:41 +0000
Bug 1544432 part 2: Add WPT for text being scaled up via SVG viewBox. r=longsonr
7bb92957787da8256bbb345662c6b8b1d8e5fbba: Bug 1544432 part 1: Scale around (0,0) when transforming SVG text from run user space to user space. r=longsonr
Alex Henrie <alexhenrie24@gmail.com> - Thu, 20 Jun 2019 09:41:55 -0700 - rev 479955
Push
113509 by dholbert@mozilla.com at Tue, 25 Jun 2019 06:29:41 +0000
Bug 1544432 part 1: Scale around (0,0) when transforming SVG text from run user space to user space. r=longsonr
268277536047b0724243e48eea3fa1dee11ea6db: Bug 1529572 - Should resolve absolute units r=longsonr
violet <violet.bugreport@gmail.com> - Sun, 23 Jun 2019 12:51:05 +0000 - rev 479908
Push
113504 by ncsoregi@mozilla.com at Mon, 24 Jun 2019 15:34:16 +0000
Bug 1529572 - Should resolve absolute units r=longsonr
Firefox only failure.
Differential Revision:
https://phabricator.services.mozilla.com/D35614
8b13b43158a46b7cf48c7e3d25adf4b92cf67448: Bug 1559096. Document the unexpected aspects of BackgroundClipRenderingObserver. r=longsonr
Jonathan Watt <jwatt@jwatt.org> - Thu, 06 Jun 2019 14:12:01 -0700 - rev 479827
Push
113493 by jwatt@jwatt.org at Sat, 22 Jun 2019 01:49:28 +0000
Bug 1559096. Document the unexpected aspects of BackgroundClipRenderingObserver. r=longsonr
Differential Revision:
https://phabricator.services.mozilla.com/D34875
321cf20e1134c328e659e8061908f81eef9788b8: Bug 1559096. Rename SVGObserverUtils::mInObserverList. r=longsonr
Jonathan Watt <jwatt@jwatt.org> - Thu, 06 Jun 2019 11:12:21 -0700 - rev 479826
Push
113493 by jwatt@jwatt.org at Sat, 22 Jun 2019 01:49:28 +0000
Bug 1559096. Rename SVGObserverUtils::mInObserverList. r=longsonr
Differential Revision:
https://phabricator.services.mozilla.com/D34852
104948fb0613ffcc470c946277dbedfb3483672b: Bug 1559096. Rename SVGObserverUtils::GetAndObservePaintServer argument. r=longsonr
Jonathan Watt <jwatt@jwatt.org> - Thu, 06 Jun 2019 11:05:38 -0700 - rev 479825
Push
113493 by jwatt@jwatt.org at Sat, 22 Jun 2019 01:49:28 +0000
Bug 1559096. Rename SVGObserverUtils::GetAndObservePaintServer argument. r=longsonr
Differential Revision:
https://phabricator.services.mozilla.com/D34851
74e7a89b8d26daebae7c0a622cce47747e2c81b7: Bug 1560179 - Image should not accept eSHAPE r=longsonr
violet <violet.bugreport@gmail.com> - Thu, 20 Jun 2019 13:14:08 +0000 - rev 479675
Push
113481 by csabou@mozilla.com at Thu, 20 Jun 2019 22:48:57 +0000
Bug 1560179 - Image should not accept eSHAPE r=longsonr
Differential Revision:
https://phabricator.services.mozilla.com/D35396
13d68d184214d83e413d7ed769a82443f9f05162: Bug 1325319 - Implement isPointInFill() and isPointInStroke() for SVGGeometryElement r=longsonr,bzbarsky
violet <violet.bugreport@gmail.com> - Wed, 19 Jun 2019 21:14:55 +0000 - rev 479629
Push
113474 by rmaries@mozilla.com at Thu, 20 Jun 2019 11:21:48 +0000
Bug 1325319 - Implement isPointInFill() and isPointInStroke() for SVGGeometryElement r=longsonr,bzbarsky
Differential Revision:
https://phabricator.services.mozilla.com/D33592
74a548477a4cc8630ea4642ddfa0da452b1de22c: Bug 1559344: Reinstate earlier behavior of invalidating children-only transform (and repainting) when viewBox changes. r=longsonr
Daniel Holbert <dholbert@cs.stanford.edu> - Fri, 14 Jun 2019 19:21:01 +0000 - rev 478939
Push
113448 by apavel@mozilla.com at Sat, 15 Jun 2019 10:07:35 +0000
Bug 1559344: Reinstate earlier behavior of invalidating children-only transform (and repainting) when viewBox changes. r=longsonr
In
bug 1556511's patch, I removed an invalidation that we'd been doing in
response to viewBox changes, because I thought that the patch's newly-added
reflow-request would make the invalidation unnecessary. But this was wrong --
the invalidation is still necessary, for cases where the requested reflow
doesn't end up resizing any frames. Such a reflow won't make us repaint
anything, and yet the viewBox change typically *does* need to trigger a repaint
due to impacting the transform for the SVG contents.
So, this patch reverts that part of
bug 1556511's patch, and returns us to
triggering a repaint in response to viewBox changes.
Differential Revision:
https://phabricator.services.mozilla.com/D35067
96b0fd9c79cd30dfe59597a8a77564862eb30091: Bug 1032124 - Use the referenced element to check whether to ignore a mutation event r=emilio,longsonr
violet <violet.bugreport@gmail.com> - Thu, 13 Jun 2019 20:02:42 +0000 - rev 478782
Push
113435 by shindli@mozilla.com at Fri, 14 Jun 2019 03:43:52 +0000
Bug 1032124 - Use the referenced element to check whether to ignore a mutation event r=emilio,longsonr
Using `nsContentUtils::IsInSameAnonymousTree(this, aElement)` to check will ignore all mutation notification for anonymous <use> which will happen when <use> is nested. This is the cause that second-level <use> isn't properly synced with element mutation.
We should use the referenced element instead of `this` in the check condition.
Differential Revision:
https://phabricator.services.mozilla.com/D34284
4ef53fac3b048ddc027b9d139bb3be8ab626f55c: Bug 1558356 - Add WPT for xml:space="" on an ancestor element. r=longsonr
Cameron McCormack <cam@mcc.id.au> - Tue, 11 Jun 2019 12:07:51 +0000 - rev 478301
Push
113419 by dluca@mozilla.com at Wed, 12 Jun 2019 12:45:34 +0000
Bug 1558356 - Add WPT for xml:space="" on an ancestor element. r=longsonr
Differential Revision:
https://phabricator.services.mozilla.com/D34436
e70086c9a4773b135365147e3feae222a85e0368: Bug 1557637 - Correct resolve <image> size when specified size is auto and intrinsic size is missing r=longsonr
violet <violet.bugreport@gmail.com> - Sat, 08 Jun 2019 00:33:36 +0000 - rev 477942
Push
113386 by nbeleuzu@mozilla.com at Sat, 08 Jun 2019 09:51:50 +0000
Bug 1557637 - Correct resolve <image> size when specified size is auto and intrinsic size is missing r=longsonr
https://www.w3.org/TR/css3-images/#default-sizing-algorithm
Differential Revision:
https://phabricator.services.mozilla.com/D34119
bab948f512c2f5ffe5a6638676143c7063bf2ad3: Bug 1556511 part 2: Add a test variant that uses SVG embedded in an `<object>` element. r=longsonr
Daniel Holbert <dholbert@cs.stanford.edu> - Fri, 07 Jun 2019 13:37:51 +0000 - rev 477868
Push
113380 by apavel@mozilla.com at Fri, 07 Jun 2019 22:16:42 +0000
Bug 1556511 part 2: Add a test variant that uses SVG embedded in an `<object>` element. r=longsonr
Differential Revision:
https://phabricator.services.mozilla.com/D34108
aba9b5d525af1b48929de552224626799931ff3e: Bug 1556511 part 1: Mark the outer SVG frame as needing a reflow, when its viewBox attribute changes. r=longsonr
Daniel Holbert <dholbert@cs.stanford.edu> - Fri, 07 Jun 2019 04:28:51 +0000 - rev 477867
Push
113380 by apavel@mozilla.com at Fri, 07 Jun 2019 22:16:42 +0000
Bug 1556511 part 1: Mark the outer SVG frame as needing a reflow, when its viewBox attribute changes. r=longsonr
The viewBox attribute establishes an aspect ratio, which may influence the size
of the outer SVG element. So when the viewBox attribute changes, we have to
reflow to potentially update the frame size. This patch achieves this by
sharing an existing codepath for handling changes to width & height.
Differential Revision:
https://phabricator.services.mozilla.com/D33898
967c30311690aa759c57271883dadb641e47db4b: Bug 1556713 - Transform dirtyRect down to <image> r=longsonr
violet <violet.bugreport@gmail.com> - Thu, 06 Jun 2019 14:54:40 +0000 - rev 477810
Push
113376 by dvarga@mozilla.com at Fri, 07 Jun 2019 16:29:10 +0000
Bug 1556713 - Transform dirtyRect down to <image> r=longsonr
aDirtyRect in PaintSVG() is in outer <svg> coordinate. Image painting
API needs dirty rect in image coordinate. We need to transform it.
Differential Revision:
https://phabricator.services.mozilla.com/D33813
d055d72f5e77f8ffd30331ed093800e87da8151a: Bug 1556713 - Transform dirtyRect down to <image> r=longsonr
violet <violet.bugreport@gmail.com> - Thu, 06 Jun 2019 14:54:40 +0000 - rev 477778
Push
113376 by dvarga@mozilla.com at Fri, 07 Jun 2019 16:29:10 +0000
Bug 1556713 - Transform dirtyRect down to <image> r=longsonr
aDirtyRect in PaintSVG() is in outer <svg> coordinate. Image painting
API needs dirty rect in image coordinate. We need to transform it.
Differential Revision:
https://phabricator.services.mozilla.com/D33813
8d1253667f3ab95eff3ef08b614a4cac1e9bf3cc: Bug 1556147 - SVGImageElement::BuildPath should never be called r=longsonr
violet <violet.bugreport@gmail.com> - Sat, 01 Jun 2019 16:06:33 +0000 - rev 476720
Push
113311 by btara@mozilla.com at Tue, 04 Jun 2019 16:10:59 +0000
Bug 1556147 - SVGImageElement::BuildPath should never be called r=longsonr
SVGImageElement isn't really a SVGGeometryElement, we did that just for
better code sharing. BuildPath() won't be called for <image>.
Differential Revision:
https://phabricator.services.mozilla.com/D33400
4ab1e25f7904160717fe15da393603757fb366a2: Bug 1555758 - Fallback to GetComputedStyleNoFlush for BuildPath r=longsonr,emilio
violet <violet.bugreport@gmail.com> - Fri, 31 May 2019 13:17:46 +0000 - rev 476423
Push
113285 by aiakab@mozilla.com at Fri, 31 May 2019 22:31:43 +0000
Bug 1555758 - Fallback to GetComputedStyleNoFlush for BuildPath r=longsonr,emilio
It turns out the `BuildPath()` method will still be exposed by DOM
API via `getTotalLength()`. So we need to fallback to `GetComputedStyleNoFlush()`
to handle display:none problem, and if the element doesn't even belong
to a document, we further fallback to 0.
`BuildPath()` being affected also means `GetStrokeWidth()`, etc. will also
be indirectly exposed to DOM API in some obscure cases. Let's add a utility
to handle the fallback.
Differential Revision:
https://phabricator.services.mozilla.com/D33247
b6fa96d10a09ed745f77ca332075b9dfeef803c9: Bug 1555795 - Check IsInner() to ensure it is an outer svg r=longsonr
violet <violet.bugreport@gmail.com> - Fri, 31 May 2019 09:59:04 +0000 - rev 476383
Push
113271 by archaeopteryx@coole-files.de at Fri, 31 May 2019 17:09:51 +0000
Bug 1555795 - Check IsInner() to ensure it is an outer svg r=longsonr
Differential Revision:
https://phabricator.services.mozilla.com/D33246
58a92f5eff76adb20b44e6a37c58e63387be6b62: Bug 1555030 - Add NS_FRAME_SVG_LAYOUT into SVGViewFrame and nsSVGStopFrame. r=dholbert,longsonr
Boris Chiou <boris.chiou@gmail.com> - Wed, 29 May 2019 23:50:55 +0000 - rev 476269
Push
113263 by nbeleuzu@mozilla.com at Fri, 31 May 2019 04:08:20 +0000
Bug 1555030 - Add NS_FRAME_SVG_LAYOUT into SVGViewFrame and nsSVGStopFrame. r=dholbert,longsonr
To avoid hitting the assertion for ResizeObserver, which calls GetBBox()
for all SVG elements.
Note:
If the target has SVG layout and its primary frame cannot be queries as
nsSVGDisplayableFrame, we return a default gfxRect(). And always
returning a default gfxRect() on <view> or <stop> element makes ResizeObserver
doesn't report it (because it is always not active). This behavior
is the same as what Google Chrome has. (i.e. No event is fired.)
Differential Revision:
https://phabricator.services.mozilla.com/D32904
33a7cec553b2b79b4067416fab3191d19243c3bf: Bug 1554457 - Obtain style from frame rather than GetComputedStyleNoFlush r=emilio,longsonr,birtles
violet <violet.bugreport@gmail.com> - Mon, 27 May 2019 05:06:47 +0000 - rev 475698
Push
113228 by dluca@mozilla.com at Tue, 28 May 2019 09:48:00 +0000
Bug 1554457 - Obtain style from frame rather than GetComputedStyleNoFlush r=emilio,longsonr,birtles
These usecases are almost the same as the geometry property stuff. It'd
be better to use `GetPrimaryFrame()->Style()` consistently rather than
using `GetComputedStyleNoFlush()` here.
Differential Revision:
https://phabricator.services.mozilla.com/D32613
0922f98398e2b3d3c51f9cad01b082f161ffdeb6: Bug 1554568 - Should resolve font-size of inner svg from itself r=longsonr
violet <violet.bugreport@gmail.com> - Mon, 27 May 2019 06:46:53 +0000 - rev 475697
Push
113228 by dluca@mozilla.com at Tue, 28 May 2019 09:48:00 +0000
Bug 1554568 - Should resolve font-size of inner svg from itself r=longsonr
Resolving length for inner <svg> is exactly the same as other ordinary
element. We should not pass the context to `GetAnimValue()`, otherwise
font-size will be obtained from the enclosing viewport of the inner
<svg> rather than the inner <svg> itself.
Differential Revision:
https://phabricator.services.mozilla.com/D32657
d0646b8b69e78adfa6f7893b3c96884d0d717b9b: Bug 1383650 - Remove some redundant attribute observing logic r=longsonr
violet <violet.bugreport@gmail.com> - Sat, 25 May 2019 11:17:49 +0000 - rev 475569
Push
113210 by dvarga@mozilla.com at Sat, 25 May 2019 21:41:26 +0000
Bug 1383650 - Remove some redundant attribute observing logic r=longsonr
Since geometry property values are computed from CSS, which also
takes care of change hint via `CalcDifference`, we can just remove
some logic to observe attribute change for `x`, `y`, etc.
Differential Revision:
https://phabricator.services.mozilla.com/D32564
b0a0359fdadb1c7dcd39656c449f3a072f49d66d: Bug 1383650 - Support geometry property for SVG image element r=longsonr
violet <violet.bugreport@gmail.com> - Fri, 24 May 2019 12:40:12 +0000 - rev 475404
Push
113208 by cbrindusan@mozilla.com at Fri, 24 May 2019 21:57:39 +0000
Bug 1383650 - Support geometry property for SVG image element r=longsonr
The only different part is to resolve intrinsic image size. This patch
implements explicit requirements of the spec, but an edge case is tricky.
It's not clear per spec what the intrinsic image size is for an SVG
without explicit width/height, something like:
<svg>
<image href="data:image/svg+xml,<svg xmlns='http://www.w3.org/2000/svg'><rect width='40' height='90' fill='red' /></svg>"/>
</svg>
Chrome treats the intrinsic size of the href svg as the default size of
a replaced element (300x150), our image/VectorImage.cpp doesn't resolve
size in this case.
We can handle this particular case in some seperate bug if necessary, I think.
Differential Revision:
https://phabricator.services.mozilla.com/D32415
f5242bd1605a4955756dc26bc7b828a9b176114f: Bug 1383650 - Remove obsolete check that is wrong in SVG2 r=longsonr
violet <violet.bugreport@gmail.com> - Thu, 23 May 2019 07:24:59 +0000 - rev 475161
Push
113193 by dvarga@mozilla.com at Thu, 23 May 2019 16:04:39 +0000
Bug 1383650 - Remove obsolete check that is wrong in SVG2 r=longsonr
Differential Revision:
https://phabricator.services.mozilla.com/D32008
f9ec440d652a96149cd68945bfb638e8e4944394: Bug 1383650 - Add reftest for rect, circle, ellipse and foreignObject r=longsonr
violet <violet.bugreport@gmail.com> - Thu, 16 May 2019 13:21:22 +0000 - rev 474721
Push
113168 by rmaries@mozilla.com at Tue, 21 May 2019 16:39:23 +0000
Bug 1383650 - Add reftest for rect, circle, ellipse and foreignObject r=longsonr
Differential Revision:
https://phabricator.services.mozilla.com/D30807
b05458d3fe67c7e8e368c4d415a6774be4c33dcc: Bug 1383650 - Use CSS to layout foreignObject r=longsonr
violet <violet.bugreport@gmail.com> - Thu, 16 May 2019 13:21:22 +0000 - rev 474720
Push
113168 by rmaries@mozilla.com at Tue, 21 May 2019 16:39:23 +0000
Bug 1383650 - Use CSS to layout foreignObject r=longsonr
Should also update layout code for foreignObject to use CSS geometry property.
Differential Revision:
https://phabricator.services.mozilla.com/D30806
94c0cc0049815467d23d4a778b68438607dc0c98: Bug 1383650 - Optimize attribute mapping by not parsing same thing twice r=longsonr
violet <violet.bugreport@gmail.com> - Thu, 16 May 2019 13:21:21 +0000 - rev 474719
Push
113168 by rmaries@mozilla.com at Tue, 21 May 2019 16:39:23 +0000
Bug 1383650 - Optimize attribute mapping by not parsing same thing twice r=longsonr
Geometry properties are the most used SVG attributes. When authors specify
them as attributes, we have to parse them in SVG side. So we don't want to
parse them in CSS side again, otherwise the introduced performance loss
is relatively high.
With this optimization, this feature implementation doesn't slow down
overall performace even if there are thousands of geometry elements.
Differential Revision:
https://phabricator.services.mozilla.com/D30778
5514f80c4f48f8dca61cdfc88e2225244c236d19: Bug 1383650 - Notify style system when SMIL animation changes length r=birtles,longsonr
violet <violet.bugreport@gmail.com> - Thu, 16 May 2019 13:21:20 +0000 - rev 474718
Push
113168 by rmaries@mozilla.com at Tue, 21 May 2019 16:39:23 +0000
Bug 1383650 - Notify style system when SMIL animation changes length r=birtles,longsonr
When animating geometry attribute, we need to notify style system about the change of SMIL override style.
Differential Revision:
https://phabricator.services.mozilla.com/D30361
af7326dc7145fb2305b315fe46c00d78c9298f35: Bug 1383650 - Add conversion utilities to get CSS counterpart of SVG unit and AttrEnum r=longsonr
violet <violet.bugreport@gmail.com> - Thu, 16 May 2019 13:21:21 +0000 - rev 474717
Push
113168 by rmaries@mozilla.com at Tue, 21 May 2019 16:39:23 +0000
Bug 1383650 - Add conversion utilities to get CSS counterpart of SVG unit and AttrEnum r=longsonr
We need some utilities to convert SVG unit and attrenum to CSS unit and property id.
This is useful when we need to pass parsed geometry property directly to CSS.
Differential Revision:
https://phabricator.services.mozilla.com/D30777
bda0f207ac29d986f2419f74c5b26b77888cc15f: Bug 1383650 - Invalidate path cache when geometry changed via CSS r=longsonr
violet <violet.bugreport@gmail.com> - Thu, 16 May 2019 13:21:20 +0000 - rev 474715
Push
113168 by rmaries@mozilla.com at Tue, 21 May 2019 16:39:23 +0000
Bug 1383650 - Invalidate path cache when geometry changed via CSS r=longsonr
We cached the path of an element. Previously we only need to invalidate
the cached path if an geometry attribute is changed. Now we also need
to invalidate if the corresponding CSS is changed.
Differential Revision:
https://phabricator.services.mozilla.com/D30472
c6d19171ee1226562c32bc68826fcb8cf0a010be: Bug 1383650 - Resolve SVG geometry metrics from CSS r=longsonr,emilio
violet <violet.bugreport@gmail.com> - Thu, 16 May 2019 13:21:20 +0000 - rev 474714
Push
113168 by rmaries@mozilla.com at Tue, 21 May 2019 16:39:23 +0000
Bug 1383650 - Resolve SVG geometry metrics from CSS r=longsonr,emilio
This patch makes SVG retrieve metrics from CSS style.
It doesn't handle <svg> element because geometry properties for
outer <svg> element has been partially implemented long ago, it
needs special change.
It doesn't deal with the impact on SMIL.
Differential Revision:
https://phabricator.services.mozilla.com/D29992
b3152421e832cf876396bb7e7c1ad874cb174c90: Bug 1383650 - Map SVG geometry attributes to CSS r=longsonr
violet <violet.bugreport@gmail.com> - Thu, 16 May 2019 13:21:19 +0000 - rev 474713
Push
113168 by rmaries@mozilla.com at Tue, 21 May 2019 16:39:23 +0000
Bug 1383650 - Map SVG geometry attributes to CSS r=longsonr
This patch maps SVG geometry attributes to CSS property, so that the
values set via SVG attribute will be known by CSS.
It doesn't deal with how the value is used.
Differential Revision:
https://phabricator.services.mozilla.com/D29960
0118148f15342961169411101578d60e8eef1ef3: Bug 1383650 - Add reftest for rect, circle, ellipse and foreignObject r=longsonr
violet <violet.bugreport@gmail.com> - Thu, 16 May 2019 00:55:53 +0000 - rev 474037
Push
113120 by dvarga@mozilla.com at Thu, 16 May 2019 04:21:05 +0000
Bug 1383650 - Add reftest for rect, circle, ellipse and foreignObject r=longsonr
Differential Revision:
https://phabricator.services.mozilla.com/D30807
447c9248342b3ab04801d4684013042140085b23: Bug 1383650 - Use CSS to layout foreignObject r=longsonr
violet <violet.bugreport@gmail.com> - Thu, 16 May 2019 00:55:25 +0000 - rev 474036
Push
113120 by dvarga@mozilla.com at Thu, 16 May 2019 04:21:05 +0000
Bug 1383650 - Use CSS to layout foreignObject r=longsonr
Should also update layout code for foreignObject to use CSS geometry property.
Differential Revision:
https://phabricator.services.mozilla.com/D30806
6730776560c028a402e7112569e6ca8bf6cd742b: Bug 1383650 - Optimize attribute mapping by not parsing same thing twice r=longsonr
violet <violet.bugreport@gmail.com> - Thu, 16 May 2019 00:54:46 +0000 - rev 474035
Push
113120 by dvarga@mozilla.com at Thu, 16 May 2019 04:21:05 +0000
Bug 1383650 - Optimize attribute mapping by not parsing same thing twice r=longsonr
Geometry properties are the most used SVG attributes. When authors specify
them as attributes, we have to parse them in SVG side. So we don't want to
parse them in CSS side again, otherwise the introduced performance loss
is relatively high.
With this optimization, this feature implementation doesn't slow down
overall performace even if there are thousands of geometry elements.
Differential Revision:
https://phabricator.services.mozilla.com/D30778
a7b8e6460fb8b1245507e9e15deadc1e62674102: Bug 1383650 - Notify style system when SMIL animation changes length r=birtles,longsonr
violet <violet.bugreport@gmail.com> - Thu, 16 May 2019 00:58:56 +0000 - rev 474034
Push
113120 by dvarga@mozilla.com at Thu, 16 May 2019 04:21:05 +0000
Bug 1383650 - Notify style system when SMIL animation changes length r=birtles,longsonr
When animating geometry attribute, we need to notify style system about the change of SMIL override style.
Differential Revision:
https://phabricator.services.mozilla.com/D30361
e864696f6cf80910479dce91eed090a6455a4e2f: Bug 1383650 - Add conversion utilities to get CSS counterpart of SVG unit and AttrEnum r=longsonr
violet <violet.bugreport@gmail.com> - Thu, 16 May 2019 00:53:45 +0000 - rev 474033
Push
113120 by dvarga@mozilla.com at Thu, 16 May 2019 04:21:05 +0000
Bug 1383650 - Add conversion utilities to get CSS counterpart of SVG unit and AttrEnum r=longsonr
We need some utilities to convert SVG unit and attrenum to CSS unit and property id.
This is useful when we need to pass parsed geometry property directly to CSS.
Differential Revision:
https://phabricator.services.mozilla.com/D30777
7bc3bff991c45a6e9caefe5fb4791aeba7d29256: Bug 1383650 - Invalidate path cache when geometry changed via CSS r=longsonr
violet <violet.bugreport@gmail.com> - Thu, 16 May 2019 00:50:15 +0000 - rev 474031
Push
113120 by dvarga@mozilla.com at Thu, 16 May 2019 04:21:05 +0000
Bug 1383650 - Invalidate path cache when geometry changed via CSS r=longsonr
We cached the path of an element. Previously we only need to invalidate
the cached path if an geometry attribute is changed. Now we also need
to invalidate if the corresponding CSS is changed.
Differential Revision:
https://phabricator.services.mozilla.com/D30472
f1f7b4ad95474592279f9d5f9e337ce94240bdbd: Bug 1383650 - Resolve SVG geometry metrics from CSS r=longsonr,emilio
violet <violet.bugreport@gmail.com> - Thu, 16 May 2019 00:47:37 +0000 - rev 474030
Push
113120 by dvarga@mozilla.com at Thu, 16 May 2019 04:21:05 +0000
Bug 1383650 - Resolve SVG geometry metrics from CSS r=longsonr,emilio
This patch makes SVG retrieve metrics from CSS style.
It doesn't handle <svg> element because geometry properties for
outer <svg> element has been partially implemented long ago, it
needs special change.
It doesn't deal with the impact on SMIL.
Differential Revision:
https://phabricator.services.mozilla.com/D29992
18b030b3166027a1a1e3d35ed779bdc4d7c6ab85: Bug 1383650 - Map SVG geometry attributes to CSS r=longsonr
violet <violet.bugreport@gmail.com> - Thu, 16 May 2019 00:47:24 +0000 - rev 474029
Push
113120 by dvarga@mozilla.com at Thu, 16 May 2019 04:21:05 +0000
Bug 1383650 - Map SVG geometry attributes to CSS r=longsonr
This patch maps SVG geometry attributes to CSS property, so that the
values set via SVG attribute will be known by CSS.
It doesn't deal with how the value is used.
Differential Revision:
https://phabricator.services.mozilla.com/D29960
027695189d656e036946b9774921fb8e2e09a1f8: Bug 1551137 - <svg:mpath> should work in Shadow DOM. r=longsonr
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 13 May 2019 17:28:59 +0000 - rev 473637
Push
113093 by apavel@mozilla.com at Mon, 13 May 2019 22:09:34 +0000
Bug 1551137 - <svg:mpath> should work in Shadow DOM. r=longsonr
Differential Revision:
https://phabricator.services.mozilla.com/D30894
