Bug 1566697 - Fix unified build problem. r=longsonr Differential Revision: https://phabricator.services.mozilla.com/D38262

Bug 1555851 - Detect motion path measurement failures. r=longsonr Differential Revision: https://phabricator.services.mozilla.com/D37337

Bug 1557245 - Support overflow:visible for foreignObject r=longsonr Differential Revision: https://phabricator.services.mozilla.com/D35760

Bug 1561352: Rewrite WPT test viewBox-scaling-text-001.html to not depend on Ahem font having X-with-diacritics character. r=longsonr Differential Revision: https://phabricator.services.mozilla.com/D35833

Bug 1544432 part 2: Add WPT for text being scaled up via SVG viewBox. r=longsonr

Bug 1544432 part 1: Scale around (0,0) when transforming SVG text from run user space to user space. r=longsonr

Bug 1529572 - Should resolve absolute units r=longsonr Firefox only failure. Differential Revision: https://phabricator.services.mozilla.com/D35614

Bug 1559096. Document the unexpected aspects of BackgroundClipRenderingObserver. r=longsonr Differential Revision: https://phabricator.services.mozilla.com/D34875

Bug 1559096. Rename SVGObserverUtils::mInObserverList. r=longsonr Differential Revision: https://phabricator.services.mozilla.com/D34852

Bug 1559096. Rename SVGObserverUtils::GetAndObservePaintServer argument. r=longsonr Differential Revision: https://phabricator.services.mozilla.com/D34851

Bug 1560179 - Image should not accept eSHAPE r=longsonr Differential Revision: https://phabricator.services.mozilla.com/D35396

Bug 1325319 - Implement isPointInFill() and isPointInStroke() for SVGGeometryElement r=longsonr,bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D33592

Bug 1559344: Reinstate earlier behavior of invalidating children-only transform (and repainting) when viewBox changes. r=longsonr In bug 1556511's patch, I removed an invalidation that we'd been doing in response to viewBox changes, because I thought that the patch's newly-added reflow-request would make the invalidation unnecessary. But this was wrong -- the invalidation is still necessary, for cases where the requested reflow doesn't end up resizing any frames. Such a reflow won't make us repaint anything, and yet the viewBox change typically *does* need to trigger a repaint due to impacting the transform for the SVG contents. So, this patch reverts that part of bug 1556511's patch, and returns us to triggering a repaint in response to viewBox changes. Differential Revision: https://phabricator.services.mozilla.com/D35067

Bug 1032124 - Use the referenced element to check whether to ignore a mutation event r=emilio,longsonr Using `nsContentUtils::IsInSameAnonymousTree(this, aElement)` to check will ignore all mutation notification for anonymous <use> which will happen when <use> is nested. This is the cause that second-level <use> isn't properly synced with element mutation. We should use the referenced element instead of `this` in the check condition. Differential Revision: https://phabricator.services.mozilla.com/D34284

Bug 1558356 - Add WPT for xml:space="" on an ancestor element. r=longsonr Differential Revision: https://phabricator.services.mozilla.com/D34436

Bug 1557637 - Correct resolve <image> size when specified size is auto and intrinsic size is missing r=longsonr https://www.w3.org/TR/css3-images/#default-sizing-algorithm Differential Revision: https://phabricator.services.mozilla.com/D34119

Bug 1556511 part 2: Add a test variant that uses SVG embedded in an `<object>` element. r=longsonr Differential Revision: https://phabricator.services.mozilla.com/D34108

Bug 1556511 part 1: Mark the outer SVG frame as needing a reflow, when its viewBox attribute changes. r=longsonr The viewBox attribute establishes an aspect ratio, which may influence the size of the outer SVG element. So when the viewBox attribute changes, we have to reflow to potentially update the frame size. This patch achieves this by sharing an existing codepath for handling changes to width & height. Differential Revision: https://phabricator.services.mozilla.com/D33898

Bug 1556713 - Transform dirtyRect down to <image> r=longsonr aDirtyRect in PaintSVG() is in outer <svg> coordinate. Image painting API needs dirty rect in image coordinate. We need to transform it. Differential Revision: https://phabricator.services.mozilla.com/D33813

Bug 1556713 - Transform dirtyRect down to <image> r=longsonr aDirtyRect in PaintSVG() is in outer <svg> coordinate. Image painting API needs dirty rect in image coordinate. We need to transform it. Differential Revision: https://phabricator.services.mozilla.com/D33813

Bug 1556147 - SVGImageElement::BuildPath should never be called r=longsonr SVGImageElement isn't really a SVGGeometryElement, we did that just for better code sharing. BuildPath() won't be called for <image>. Differential Revision: https://phabricator.services.mozilla.com/D33400

Bug 1555758 - Fallback to GetComputedStyleNoFlush for BuildPath r=longsonr,emilio It turns out the `BuildPath()` method will still be exposed by DOM API via `getTotalLength()`. So we need to fallback to `GetComputedStyleNoFlush()` to handle display:none problem, and if the element doesn't even belong to a document, we further fallback to 0. `BuildPath()` being affected also means `GetStrokeWidth()`, etc. will also be indirectly exposed to DOM API in some obscure cases. Let's add a utility to handle the fallback. Differential Revision: https://phabricator.services.mozilla.com/D33247

Bug 1555795 - Check IsInner() to ensure it is an outer svg r=longsonr Differential Revision: https://phabricator.services.mozilla.com/D33246

Bug 1555030 - Add NS_FRAME_SVG_LAYOUT into SVGViewFrame and nsSVGStopFrame. r=dholbert,longsonr To avoid hitting the assertion for ResizeObserver, which calls GetBBox() for all SVG elements. Note: If the target has SVG layout and its primary frame cannot be queries as nsSVGDisplayableFrame, we return a default gfxRect(). And always returning a default gfxRect() on <view> or <stop> element makes ResizeObserver doesn't report it (because it is always not active). This behavior is the same as what Google Chrome has. (i.e. No event is fired.) Differential Revision: https://phabricator.services.mozilla.com/D32904

Bug 1554457 - Obtain style from frame rather than GetComputedStyleNoFlush r=emilio,longsonr,birtles These usecases are almost the same as the geometry property stuff. It'd be better to use `GetPrimaryFrame()->Style()` consistently rather than using `GetComputedStyleNoFlush()` here. Differential Revision: https://phabricator.services.mozilla.com/D32613

Bug 1554568 - Should resolve font-size of inner svg from itself r=longsonr Resolving length for inner <svg> is exactly the same as other ordinary element. We should not pass the context to `GetAnimValue()`, otherwise font-size will be obtained from the enclosing viewport of the inner <svg> rather than the inner <svg> itself. Differential Revision: https://phabricator.services.mozilla.com/D32657

Bug 1383650 - Remove some redundant attribute observing logic r=longsonr Since geometry property values are computed from CSS, which also takes care of change hint via `CalcDifference`, we can just remove some logic to observe attribute change for `x`, `y`, etc. Differential Revision: https://phabricator.services.mozilla.com/D32564

Bug 1383650 - Support geometry property for SVG image element r=longsonr The only different part is to resolve intrinsic image size. This patch implements explicit requirements of the spec, but an edge case is tricky. It's not clear per spec what the intrinsic image size is for an SVG without explicit width/height, something like: <svg> <image href="data:image/svg+xml,<svg xmlns='http://www.w3.org/2000/svg'><rect width='40' height='90' fill='red' /></svg>"/> </svg> Chrome treats the intrinsic size of the href svg as the default size of a replaced element (300x150), our image/VectorImage.cpp doesn't resolve size in this case. We can handle this particular case in some seperate bug if necessary, I think. Differential Revision: https://phabricator.services.mozilla.com/D32415

Bug 1383650 - Remove obsolete check that is wrong in SVG2 r=longsonr Differential Revision: https://phabricator.services.mozilla.com/D32008

Bug 1383650 - Add reftest for rect, circle, ellipse and foreignObject r=longsonr Differential Revision: https://phabricator.services.mozilla.com/D30807

Bug 1383650 - Use CSS to layout foreignObject r=longsonr Should also update layout code for foreignObject to use CSS geometry property. Differential Revision: https://phabricator.services.mozilla.com/D30806

Bug 1383650 - Optimize attribute mapping by not parsing same thing twice r=longsonr Geometry properties are the most used SVG attributes. When authors specify them as attributes, we have to parse them in SVG side. So we don't want to parse them in CSS side again, otherwise the introduced performance loss is relatively high. With this optimization, this feature implementation doesn't slow down overall performace even if there are thousands of geometry elements. Differential Revision: https://phabricator.services.mozilla.com/D30778

Bug 1383650 - Notify style system when SMIL animation changes length r=birtles,longsonr When animating geometry attribute, we need to notify style system about the change of SMIL override style. Differential Revision: https://phabricator.services.mozilla.com/D30361

Bug 1383650 - Add conversion utilities to get CSS counterpart of SVG unit and AttrEnum r=longsonr We need some utilities to convert SVG unit and attrenum to CSS unit and property id. This is useful when we need to pass parsed geometry property directly to CSS. Differential Revision: https://phabricator.services.mozilla.com/D30777

Bug 1383650 - Invalidate path cache when geometry changed via CSS r=longsonr We cached the path of an element. Previously we only need to invalidate the cached path if an geometry attribute is changed. Now we also need to invalidate if the corresponding CSS is changed. Differential Revision: https://phabricator.services.mozilla.com/D30472

Bug 1383650 - Resolve SVG geometry metrics from CSS r=longsonr,emilio This patch makes SVG retrieve metrics from CSS style. It doesn't handle <svg> element because geometry properties for outer <svg> element has been partially implemented long ago, it needs special change. It doesn't deal with the impact on SMIL. Differential Revision: https://phabricator.services.mozilla.com/D29992

Bug 1383650 - Map SVG geometry attributes to CSS r=longsonr This patch maps SVG geometry attributes to CSS property, so that the values set via SVG attribute will be known by CSS. It doesn't deal with how the value is used. Differential Revision: https://phabricator.services.mozilla.com/D29960

Bug 1383650 - Add reftest for rect, circle, ellipse and foreignObject r=longsonr Differential Revision: https://phabricator.services.mozilla.com/D30807

Bug 1383650 - Use CSS to layout foreignObject r=longsonr Should also update layout code for foreignObject to use CSS geometry property. Differential Revision: https://phabricator.services.mozilla.com/D30806

Bug 1383650 - Optimize attribute mapping by not parsing same thing twice r=longsonr Geometry properties are the most used SVG attributes. When authors specify them as attributes, we have to parse them in SVG side. So we don't want to parse them in CSS side again, otherwise the introduced performance loss is relatively high. With this optimization, this feature implementation doesn't slow down overall performace even if there are thousands of geometry elements. Differential Revision: https://phabricator.services.mozilla.com/D30778

Bug 1383650 - Notify style system when SMIL animation changes length r=birtles,longsonr When animating geometry attribute, we need to notify style system about the change of SMIL override style. Differential Revision: https://phabricator.services.mozilla.com/D30361

Bug 1383650 - Add conversion utilities to get CSS counterpart of SVG unit and AttrEnum r=longsonr We need some utilities to convert SVG unit and attrenum to CSS unit and property id. This is useful when we need to pass parsed geometry property directly to CSS. Differential Revision: https://phabricator.services.mozilla.com/D30777

Bug 1383650 - Invalidate path cache when geometry changed via CSS r=longsonr We cached the path of an element. Previously we only need to invalidate the cached path if an geometry attribute is changed. Now we also need to invalidate if the corresponding CSS is changed. Differential Revision: https://phabricator.services.mozilla.com/D30472

Bug 1383650 - Resolve SVG geometry metrics from CSS r=longsonr,emilio This patch makes SVG retrieve metrics from CSS style. It doesn't handle <svg> element because geometry properties for outer <svg> element has been partially implemented long ago, it needs special change. It doesn't deal with the impact on SMIL. Differential Revision: https://phabricator.services.mozilla.com/D29992

Bug 1383650 - Map SVG geometry attributes to CSS r=longsonr This patch maps SVG geometry attributes to CSS property, so that the values set via SVG attribute will be known by CSS. It doesn't deal with how the value is used. Differential Revision: https://phabricator.services.mozilla.com/D29960

Bug 1551137 - <svg:mpath> should work in Shadow DOM. r=longsonr Differential Revision: https://phabricator.services.mozilla.com/D30894

Bug 1133175 - Remove SVGTests.hasExtension. r=bz,longsonr

Bug 608812 - Add blurry reftest r=longsonr Differential Revision: https://phabricator.services.mozilla.com/D29621

Bug 608812 - Remove a bunch of WPT meta files that are no longer valid r=longsonr Differential Revision: https://phabricator.services.mozilla.com/D29366

Bug 608812 - Should snap subpixel value for outer svg and anon child r=longsonr We should snap subpixel value at nsDisplayTransform::GetResultingTransformMatrix for outer svg and the anon child. This will solve blurry rendering for subpixel position when webrender is __not__ enabled. Differential Revision: https://phabricator.services.mozilla.com/D29344