searching for reviewer(liuche)
c0b095a6a2c93620a65721f6eb63005760ede156: Bug 1480589 - Extend lifetime of MediaRecorder telemetry probes to FF68. r=liuche
Bryce Van Dyk <bvandyk@mozilla.com> - Thu, 02 Aug 2018 21:21:45 +0000 - rev 430080
Push 106058 by dluca@mozilla.com at Fri, 03 Aug 2018 22:10:07 +0000
Bug 1480589 - Extend lifetime of MediaRecorder telemetry probes to FF68. r=liuche Extend lifetime of MEDIA_RECORDER_RECORDING_DURATION, MEDIA_RECORDER_TRACK_ENCODER_INIT_TIMEOUT_TYPE, and SCALARS_MEDIARECORDER.RECORDING_COUNT telemetry probes. This allows continued monitoring of MediaRecorder usage in the wild. See Bug 1400757 for the original introduction of these probes. Differential Revision: https://phabricator.services.mozilla.com/D2687
631f5d3fa8100c06fa309e0e3d7bcf2de932a019: Bug 1471194 - Remove the expiring scalar Telemetry probe 'worker_restart_count', since it has served its purpose well. r=liuche
Mike de Boer <mdeboer@mozilla.com> - Thu, 12 Jul 2018 12:56:04 +0200 - rev 427105
Push 105407 by csabou@mozilla.com at Wed, 18 Jul 2018 17:23:40 +0000
Bug 1471194 - Remove the expiring scalar Telemetry probe 'worker_restart_count', since it has served its purpose well. r=liuche We've been able to validate that the sessionstore worker restarts, as implemented in bug 1402267, are working as expected and that worker threads are indeed _not_ infallible during the main process' lifetime. MozReview-Commit-ID: Le8AJhlWMn8
e8f77174972db4484e9475db1c9c9e1b20444e2a: Bug 1442068 - Add diagnostic probe for tab switch spinners r=liuche
Doug Thayer <dothayer@mozilla.com> - Thu, 01 Mar 2018 15:03:03 -0800 - rev 407877
Push 100792 by nbeleuzu@mozilla.com at Tue, 13 Mar 2018 10:37:01 +0000
Bug 1442068 - Add diagnostic probe for tab switch spinners r=liuche We currently have a few probes which measure how long tab switch spinners are displayed, but we have little information into their source. In diagnosing and attempting to lower the number of spinners that users see, we could use more information about their source to help prioritize and narrow in on regions of code. MozReview-Commit-ID: Cw4ejOM9ZSl
a82647c958da3525ac24ec5b9410d4c8b01644f3: Bug 1444209 - Update expiration date for mobile session restore failure telemetry. r=liuche
Jan Henning <jh+bugzilla@buttercookie.de> - Thu, 08 Mar 2018 22:17:40 +0100 - rev 407467
Push 100696 by nerli@mozilla.com at Sat, 10 Mar 2018 10:16:05 +0000
Bug 1444209 - Update expiration date for mobile session restore failure telemetry. r=liuche MozReview-Commit-ID: FgwH8uyvqSe
6e1f082117d3efedacb6c8bef29f9b6bf500e922: Bug 1436039 - Increase max time on Debugger's source load telemetry;r=jdescottes,liuche,datareview=liuche
yulia <ystartsev@mozilla.com> - Tue, 06 Feb 2018 15:56:19 +0100 - rev 402985
Push 99696 by nbeleuzu@mozilla.com at Thu, 08 Feb 2018 19:36:57 +0000
Bug 1436039 - Increase max time on Debugger's source load telemetry;r=jdescottes,liuche,datareview=liuche MozReview-Commit-ID: 1fuTv4fPn3B
556d77fe66b04cfc382d559a18c941517b8b5d73: Bug 1428320 - Extend the indexedDB storage type telemetry to version 62. r=liuche
Johann Hofmann <jhofmann@mozilla.com> - Fri, 05 Jan 2018 12:53:54 +0100 - rev 401896
Push 99456 by shindli@mozilla.com at Wed, 31 Jan 2018 22:39:20 +0000
Bug 1428320 - Extend the indexedDB storage type telemetry to version 62. r=liuche Because of a small correction in how we measure this data, I'd like to get more releases worth of information for this. MozReview-Commit-ID: JAAsQly6Is8
1e6ae314e8763c5925b376aa3e84ff888bf09cde: Bug 1432488 - bump migration data telemetry probes, r=dthayer,liuche
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Tue, 23 Jan 2018 23:32:04 +0100 - rev 400705
Push 99217 by rgurzau@mozilla.com at Thu, 25 Jan 2018 11:03:13 +0000
Bug 1432488 - bump migration data telemetry probes, r=dthayer,liuche MozReview-Commit-ID: 1PH4HlIdVBD
4c77dabfbe191ba33424e5ae055a6baea7a8844e: Bug 1432482 - Extend the lifetime of the FX_TAB_REMOTE_NAVIGATION_DELAY_MS probe to Firefox 66. r=Gijs,liuche, data-review=liuche
Mike Conley <mconley@mozilla.com> - Tue, 23 Jan 2018 17:55:36 -0500 - rev 400704
Push 99217 by rgurzau@mozilla.com at Thu, 25 Jan 2018 11:03:13 +0000
Bug 1432482 - Extend the lifetime of the FX_TAB_REMOTE_NAVIGATION_DELAY_MS probe to Firefox 66. r=Gijs,liuche, data-review=liuche MozReview-Commit-ID: 1HTGcBahL7G
530fe27864deac533d13664cf6f833af9d8d4e50: Bug 1345077 - Part 2 - Add telemetry on permission requests from third party origins, handling user input and insecure contexts. r=florian,liuche
Johann Hofmann <jhofmann@mozilla.com> - Wed, 10 Jan 2018 21:07:59 +0100 - rev 400502
Push 99180 by archaeopteryx@coole-files.de at Wed, 24 Jan 2018 12:24:59 +0000
Bug 1345077 - Part 2 - Add telemetry on permission requests from third party origins, handling user input and insecure contexts. r=florian,liuche MozReview-Commit-ID: 4ARIxa6gwCg
4c6d55c85948994725e9335f6867a8ad2bfaa81c: Bug 1429986 - send telemetry data when users attempt to play mkv file. r=jwwang,liuche
Alfredo.Yang <ayang@mozilla.com> - Fri, 12 Jan 2018 15:40:52 +0800 - rev 399772
Push 99021 by dluca@mozilla.com at Thu, 18 Jan 2018 09:49:46 +0000
Bug 1429986 - send telemetry data when users attempt to play mkv file. r=jwwang,liuche MozReview-Commit-ID: Ah3pXC4cJ7n
7c67b6dd2450bfacbffc44b8eff0444aa4cfcf73: Bug 1428796 - Make devtools entry point telemetry never expire. r=Harald,liuche
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 08 Jan 2018 08:06:39 -0800 - rev 399762
Push 99021 by dluca@mozilla.com at Thu, 18 Jan 2018 09:49:46 +0000
Bug 1428796 - Make devtools entry point telemetry never expire. r=Harald,liuche MozReview-Commit-ID: 9SUYvq7doWw
e25f027b4c50b358d649cabcf1b69d76b70e5410: Update and reassign some expiring Telemetry probes in gfx. (bug 1430657, r=liuche)
David Anderson <danderson@mozilla.com> - Wed, 17 Jan 2018 19:21:39 -0800 - rev 399718
Push 99014 by danderson@mozilla.com at Thu, 18 Jan 2018 04:13:57 +0000
Update and reassign some expiring Telemetry probes in gfx. (bug 1430657, r=liuche)
6e299e057fd4396cd4900c82336df2c2c511fce4: Bug 1429765 - Extend lifetime of MediaRecorder telemetry probes. r=chutten,liuche
Bryce Van Dyk <bvandyk@mozilla.com> - Thu, 11 Jan 2018 09:11:32 -0500 - rev 399163
Push 98907 by ccoroiu@mozilla.com at Sat, 13 Jan 2018 10:06:46 +0000
Bug 1429765 - Extend lifetime of MediaRecorder telemetry probes. r=chutten,liuche Extend lifetime of MEDIA_RECORDER_RECORDING_DURATION, MEDIA_RECORDER_TRACK_ENCODER_INIT_TIMEOUT_TYPE, and SCALARS_MEDIARECORDER.RECORDING_COUNT telemetry probes. This allows continued monitoring of MediaRecorder usage in the wild. See Bug 1400757 for the original introduction of these probes. MozReview-Commit-ID: FzM2Awhv25H
809a14e1c12b4ccca6c328f80719c0f0787128e6: Bug 1429510 - Make last shutdown time a scalar. r=chutten,liuche
Georg Fritzsche <georg.fritzsche@googlemail.com> - Thu, 11 Jan 2018 06:06:00 +0200 - rev 399006
Push 98885 by archaeopteryx@coole-files.de at Fri, 12 Jan 2018 19:52:51 +0000
Bug 1429510 - Make last shutdown time a scalar. r=chutten,liuche
7e989a375aa8c57296632b88656a1931b762a331: Bug 1425967 - extend TAB_COUNT probe to last until 65, r=liuche,mconley
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Wed, 03 Jan 2018 17:25:41 +0000 - rev 398334
Push 98725 by ebalazs@mozilla.com at Tue, 09 Jan 2018 10:16:39 +0000
Bug 1425967 - extend TAB_COUNT probe to last until 65, r=liuche,mconley MozReview-Commit-ID: AwHpPIrvOgE
96fefb68548f4da89ce0dcc50ec27822cb2515fb: Bug 1428131 Bump Orbot and Graphite Telemetry probes r=liuche
Tom Ritter <tom@mozilla.com> - Thu, 04 Jan 2018 12:52:22 -0600 - rev 398331
Push 98725 by ebalazs@mozilla.com at Tue, 09 Jan 2018 10:16:39 +0000
Bug 1428131 Bump Orbot and Graphite Telemetry probes r=liuche MozReview-Commit-ID: Gw9Yf9r3LFc
c01ea7a845672c90d3ef85168bad3ed5848825d6: Bug 1425957 - Extend webextension telemetry probes for another 3 releases, r=liuche
Bob Silverberg <bsilverberg@mozilla.com> - Tue, 19 Dec 2017 13:35:36 -0500 - rev 398325
Push 98725 by ebalazs@mozilla.com at Tue, 09 Jan 2018 10:16:39 +0000
Bug 1425957 - Extend webextension telemetry probes for another 3 releases, r=liuche We are still using the data from these probes to help guide us in the development of the APIs in question, so would like to keep them in place until version 63. MozReview-Commit-ID: AC1k40XZGkf
2e333b0f2cd4c6e17d7a974d6e754a0a7cbed6f8: Bug 1424908 - extend telemetry probes for page action panel usage/customization, r=liuche
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Tue, 12 Dec 2017 14:12:17 -0600 - rev 398324
Push 98725 by ebalazs@mozilla.com at Tue, 09 Jan 2018 10:16:39 +0000
Bug 1424908 - extend telemetry probes for page action panel usage/customization, r=liuche MozReview-Commit-ID: D1g6yVdGIRt
b16d13518be9798d8e0d652bd374587c68453241: Bug 1425970 - Extend BUSY_TAB_ABANDONED probe lifetime until v65. r=jaws,liuche, data-review=liuche
Mike Conley <mconley@mozilla.com> - Thu, 04 Jan 2018 10:51:16 -0500 - rev 398317
Push 98725 by ebalazs@mozilla.com at Tue, 09 Jan 2018 10:16:39 +0000
Bug 1425970 - Extend BUSY_TAB_ABANDONED probe lifetime until v65. r=jaws,liuche, data-review=liuche MozReview-Commit-ID: Fk1zCk9dkDf
7fc6865ed3f2c5e6c864929c6e9be8852c962321: Bug 1423185 - Update document for the event when user finish first run on-boarding. r=liuche
Nevin Chen <cnevinchen@gmail.com> - Tue, 05 Dec 2017 21:27:57 +0800 - rev 398032
Push 98666 by archaeopteryx@coole-files.de at Sat, 06 Jan 2018 00:02:40 +0000
Bug 1423185 - Update document for the event when user finish first run on-boarding. r=liuche Data review request comment: 1. What questions will you answer with this data? We want to know when the user exit on-boarding. So we can start to A/B testing on other contextual hints. We don't want to overlap them. 2. Why does Mozilla need to answer these questions? Are there benefits for users? We need this information to know if users had done on-boarding 3. What alternative methods did you consider to answer these questions? Why were they not sufficient? I can't think of any. 4. Can current instrumentation answer these questions? No 5. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories on the found on the Mozilla wiki. I can't find one for Android 6. How long will this data be collected? Choose one of the following: We want to permanently monitor this data. (Joe Cheng) 5. What populations will you measure? All Fennec users 6. Which release channels? All channels 7.Which countries? All countries 8. Which locales? All locales 9. Any other filters? Please describe in detail below. No 10.Please provide a general description of how you will analyze this data. We'd like to use Leanplum to cross-reference those events 11.Where do you intend to share the results of your analysis? We'll use it internally MozReview-Commit-ID: 2s7Hnc97dhp
4ab7f0a683377a5f517918917a3e7250212c8176: Bug 1406011 - Update the document for defaultBrowser in core ping. r=liuche
Nevin Chen <cnevinchen@gmail.com> - Tue, 05 Dec 2017 16:45:45 +0800 - rev 395573
Push 98151 by cbrindusan@mozilla.com at Fri, 08 Dec 2017 10:13:49 +0000
Bug 1406011 - Update the document for defaultBrowser in core ping. r=liuche MozReview-Commit-ID: 6T9rF2B1T9O
5189909a58bb4d41e2ea93451a4e9d80e41e25ee: Bug 1417361: Rename OnCardLongClickListener.onClick -> onLongClick. r=liuche
Michael Comella <michael.l.comella@gmail.com> - Tue, 28 Nov 2017 17:29:53 -0800 - rev 394500
Push 97895 by rgurzau@mozilla.com at Fri, 01 Dec 2017 11:01:19 +0000
Bug 1417361: Rename OnCardLongClickListener.onClick -> onLongClick. r=liuche This should make the code slightly simpler to follow. MozReview-Commit-ID: HrAv39eCtzb
508c22743a6d797f75448f5e780369dc6322f98c: Bug 1417361: Use anchor for context menu on tablet. r=liuche
Michael Comella <michael.l.comella@gmail.com> - Tue, 28 Nov 2017 16:35:54 -0800 - rev 394499
Push 97895 by rgurzau@mozilla.com at Fri, 01 Dec 2017 11:01:19 +0000
Bug 1417361: Use anchor for context menu on tablet. r=liuche This uses the same anchors as the old code so should be low risk. MozReview-Commit-ID: 7pA3SSRghv0
418fcd00bb5760fb571ec677a9b9cd2278ec715a: Bug 1416971: Update Pocket MORE link. r=liuche
Michael Comella <michael.l.comella@gmail.com> - Mon, 27 Nov 2017 11:26:57 -0800 - rev 393886
Push 97751 by nbeleuzu@mozilla.com at Tue, 28 Nov 2017 10:08:51 +0000
Bug 1416971: Update Pocket MORE link. r=liuche Updated URL is specified in comment 1. MozReview-Commit-ID: 3S6vJ4E7jYO
78be743420f1baa228dee39b59aeb4dc36505d5c: Bug 1415266: Enable Pocket by default. r=liuche
Michael Comella <michael.l.comella@gmail.com> - Tue, 07 Nov 2017 11:09:13 -0800 - rev 390643
Push 97096 by nbeleuzu@mozilla.com at Wed, 08 Nov 2017 10:58:22 +0000
Bug 1415266: Enable Pocket by default. r=liuche MozReview-Commit-ID: CJXNQpsYTf6
12a1cc903ec7d177a6b54b914367cbfa3b048a83: Bug 1412164 - add tour_type and timestamp column for onboarding telemetry;r=Fischer,liuche
Fred Lin <gasolin@gmail.com> - Fri, 27 Oct 2017 10:20:34 +0800 - rev 389780
Push 96914 by acraciun@mozilla.com at Thu, 02 Nov 2017 09:57:40 +0000
Bug 1412164 - add tour_type and timestamp column for onboarding telemetry;r=Fischer,liuche MozReview-Commit-ID: aqeoxjR7Tu
457d6f0b078967099e6db73320d006949984c53d: Bug 1410221: Rm duplicated code in openContextMenu. r=liuche
Michael Comella <michael.l.comella@gmail.com> - Mon, 23 Oct 2017 15:06:03 -0700 - rev 389524
Push 96866 by ncsoregi@mozilla.com at Wed, 01 Nov 2017 10:29:43 +0000
Bug 1410221: Rm duplicated code in openContextMenu. r=liuche I verified this worked by checking the UITelemetry logs. MozReview-Commit-ID: IlD8CuxsUSA
c71c194a8765e95c6fd10cb44260b4f21b5b6c6c: Bug 1410221: Rm unnecessary context param from ActivityStreamContextMenu.show. r=liuche
Michael Comella <michael.l.comella@gmail.com> - Mon, 23 Oct 2017 14:57:57 -0700 - rev 389523
Push 96866 by ncsoregi@mozilla.com at Wed, 01 Nov 2017 10:29:43 +0000
Bug 1410221: Rm unnecessary context param from ActivityStreamContextMenu.show. r=liuche MozReview-Commit-ID: LvPCaFbwGEV
e010ad5fb52a107f35ee76f11f5dba82651d34fc: Bug 1410221: Move TopSite openContextMenu to StreamRecyclerAdapter with listener. r=liuche
Michael Comella <michael.l.comella@gmail.com> - Mon, 23 Oct 2017 14:50:17 -0700 - rev 389522
Push 96866 by ncsoregi@mozilla.com at Wed, 01 Nov 2017 10:29:43 +0000
Bug 1410221: Move TopSite openContextMenu to StreamRecyclerAdapter with listener. r=liuche We do this so we can bind the listener to the `parent` View argument in onCreateViewHolder. This is the last commit required to fix this bug. In practice, top sites should never cause a crash because they should never be off-screen on rotation but this is just for correctness/safety. MozReview-Commit-ID: 5P1HiR6woTH
6923f1c704e29e341d4c4d788fa84b2c229b6d91: Bug 1410221: Rm unused StreamHighlightItemRowContextMenuListener. r=liuche
Michael Comella <michael.l.comella@gmail.com> - Mon, 23 Oct 2017 14:22:39 -0700 - rev 389521
Push 96866 by ncsoregi@mozilla.com at Wed, 01 Nov 2017 10:29:43 +0000
Bug 1410221: Rm unused StreamHighlightItemRowContextMenuListener. r=liuche MozReview-Commit-ID: LgPtdDMdjVV
35600a494a24575fa9b6d858cebd7a57b83b02bc: Bug 1410221: Pass in parent snackbarAnchor for WebpageItemRow. r=liuche
Michael Comella <michael.l.comella@gmail.com> - Mon, 23 Oct 2017 14:05:39 -0700 - rev 389520
Push 96866 by ncsoregi@mozilla.com at Wed, 01 Nov 2017 10:29:43 +0000
Bug 1410221: Pass in parent snackbarAnchor for WebpageItemRow. r=liuche MozReview-Commit-ID: 76VLKcEPQWF
ee7541fb487ab41b9bd2a35c73aeb018d91081e7: Bug 1398972 - Update Histograms.json r=liuche
Doug Thayer <dothayer@mozilla.com> - Tue, 31 Oct 2017 11:39:18 -0700 - rev 389487
Push 96866 by ncsoregi@mozilla.com at Wed, 01 Nov 2017 10:29:43 +0000
Bug 1398972 - Update Histograms.json r=liuche Since the user can now block Flash and ask the browser to remember that decision, the histogram that collects user's choices on this has to be updated with a fourth option. MozReview-Commit-ID: J4r6nJIiaeQ
38345cd61a3dd70fafc8e8bb3128b0ac8eb6ac41: Bug 1411657: Disable Pocket by default. r=liuche
Michael Comella <michael.l.comella@gmail.com> - Wed, 25 Oct 2017 12:05:17 -0700 - rev 388364
Push 96616 by acraciun@mozilla.com at Thu, 26 Oct 2017 09:35:17 +0000
Bug 1411657: Disable Pocket by default. r=liuche From product (bug 1411657 comment 0): Activity Stream may be pushed to a later release on desktop. With that, we want the Pocket stories feature to be put behind a feature flag on Firefox Android,so we can launch the feature across all platforms simultaneously. MozReview-Commit-ID: 3KmZir3tGPc
4dc6374aca242ffbc01a5fa6db11c6f9933cd0f7: Bug 1411657: Use resources when getting default Pocket value. r=liuche
Michael Comella <michael.l.comella@gmail.com> - Wed, 25 Oct 2017 12:02:14 -0700 - rev 388363
Push 96616 by acraciun@mozilla.com at Thu, 26 Oct 2017 09:35:17 +0000
Bug 1411657: Use resources when getting default Pocket value. r=liuche This is an existing bug that previously had no impact because the values were duplicated. Now that I'm going to change the value, the bug has to be fixed. I opted not to fix the bug for the other top sites features in order to minimize the scope of this change. MozReview-Commit-ID: L9bnEMfvpDG
31d0a593571153790ce504f907e141910ca9f264: Bug 1389424 - enable onboarding telemetry via ping-centre;r=emtwo,Fischer,liuche
gasolin <gasolin@gmail.com> - Thu, 31 Aug 2017 10:19:04 +0800 - rev 386945
Push 96346 by ryanvm@gmail.com at Thu, 19 Oct 2017 01:04:51 +0000
Bug 1389424 - enable onboarding telemetry via ping-centre;r=emtwo,Fischer,liuche MozReview-Commit-ID: KWRCnD4lFh9
c94d9d435a0de59b65e89aee2a9ff8d06698dec2: Bug 1389424 - enable onboarding telemetry via ping-centre;r=emtwo,Fischer,liuche
gasolin <gasolin@gmail.com> - Thu, 31 Aug 2017 10:19:04 +0800 - rev 386785
Push 96311 by archaeopteryx@coole-files.de at Wed, 18 Oct 2017 09:52:02 +0000
Bug 1389424 - enable onboarding telemetry via ping-centre;r=emtwo,Fischer,liuche MozReview-Commit-ID: KWRCnD4lFh9
d8c1c8894971b78c12f6ea4f6ce7d99fa200b227: Bug 1402267 - Add a scalar telemetry probe that tracks SessionFile worker restarts. data-r=liuche, r=chutten,liuche,ttaubert
Mike de Boer <mdeboer@mozilla.com> - Tue, 17 Oct 2017 12:04:37 +0200 - rev 386753
Push 96301 by archaeopteryx@coole-files.de at Tue, 17 Oct 2017 22:06:44 +0000
Bug 1402267 - Add a scalar telemetry probe that tracks SessionFile worker restarts. data-r=liuche, r=chutten,liuche,ttaubert MozReview-Commit-ID: F3kCfz18kcQ
5ede138b6e27cfd84d87e65e039623a5dc683121: Bug 1404535: Add telemetry that times nr_ice_gather. r+drno r=chutten,drno,liuche
Byron Campen [:bwc] <docfaraday@gmail.com> - Fri, 29 Sep 2017 17:49:32 -0500 - rev 386039
Push 96159 by archaeopteryx@coole-files.de at Fri, 13 Oct 2017 09:55:12 +0000
Bug 1404535: Add telemetry that times nr_ice_gather. r+drno r=chutten,drno,liuche MozReview-Commit-ID: I4nH8sZNX5g
c4492a71092ec7ea0962b1c3f323406891f4a870: Bug 1392951 - Implement telemetry probe for home page setup. r=liuche,mconley
Evan Tseng <evan@tseng.io> - Fri, 06 Oct 2017 16:13:05 +0800 - rev 385674
Push 96097 by archaeopteryx@coole-files.de at Thu, 12 Oct 2017 10:04:11 +0000
Bug 1392951 - Implement telemetry probe for home page setup. r=liuche,mconley - Send a ping when user type in "Home page" box. - String is longer than 4 letters and with at least one ".". - String is not deleted after 3 seconds. - Send a ping when "Use Current Page" is clicked. - Send a ping when "Use Bookmark" is clicked. - Send the number of "|" is detected in "Home page" box. MozReview-Commit-ID: 6bYK0eCkYym
ffd9345660e51ee97c0d753f6e73cbe4e51f8e41: Bug 1395409: Add testActivityStreamPocketReferrer. r=liuche
Michael Comella <michael.l.comella@gmail.com> - Wed, 30 Aug 2017 17:33:08 -0700 - rev 384600
Push 95817 by archaeopteryx@coole-files.de at Thu, 05 Oct 2017 09:47:56 +0000
Bug 1395409: Add testActivityStreamPocketReferrer. r=liuche MozReview-Commit-ID: FlcMG5IewRH
8ba3c0e7b8f7479754578d29c3150668b731c975: Bug 1403755: Rm code to insert blanks into top sites. r=liuche
Michael Comella <michael.l.comella@gmail.com> - Thu, 28 Sep 2017 14:09:48 -0700 - rev 384294
Push 95763 by archaeopteryx@coole-files.de at Wed, 04 Oct 2017 09:18:29 +0000
Bug 1403755: Rm code to insert blanks into top sites. r=liuche This code was being mistakenly activated when getting top sites for Activity Stream. This is the first removal of old top sites code and will mean we can't go back to old top sites by flipping the `ActivityStream.isEnabled` flag. Since we're planning to ship AS, this shouldn't matter. MozReview-Commit-ID: 9VB0RqNHmE0
0db210721aa4cc46bd0566aa54406e8cd94b2bf2: Bug 1405404: Add 'de' to list of pocket whitelisted locales. r=liuche
Michael Comella <michael.l.comella@gmail.com> - Tue, 03 Oct 2017 10:29:49 -0700 - rev 384285
Push 95763 by archaeopteryx@coole-files.de at Wed, 04 Oct 2017 09:18:29 +0000
Bug 1405404: Add 'de' to list of pocket whitelisted locales. r=liuche This is used in multi-locale builds, e.g. [1] where all German is "de" but in [2], we have a separate l10n repo for en-GB. [1]: https://hg.mozilla.org/releases/l10n/mozilla-beta/de [2]: https://hg.mozilla.org/releases/l10n/mozilla-beta/en-GB MozReview-Commit-ID: CXw9aFH9psz
0bf07287d61448f027f4f8de2e587a634bb70ec8: Bug 1405404: Add 'de' to list of pocket whitelisted locales. r=liuche
Michael Comella <michael.l.comella@gmail.com> - Tue, 03 Oct 2017 10:29:49 -0700 - rev 384281
Push 95763 by archaeopteryx@coole-files.de at Wed, 04 Oct 2017 09:18:29 +0000
Bug 1405404: Add 'de' to list of pocket whitelisted locales. r=liuche This is used in multi-locale builds, e.g. [1] where all German is "de" but in [2], we have a separate l10n repo for en-GB. [1]: https://hg.mozilla.org/releases/l10n/mozilla-beta/de [2]: https://hg.mozilla.org/releases/l10n/mozilla-beta/en-GB MozReview-Commit-ID: CXw9aFH9psz
747862bc5edb9495b95f03d3f98c06db5be36609: Bug 1404460: Add test for pocket locale enabling. r=liuche
Michael Comella <michael.l.comella@gmail.com> - Mon, 02 Oct 2017 18:36:41 -0700 - rev 384128
Push 95706 by archaeopteryx@coole-files.de at Tue, 03 Oct 2017 09:46:41 +0000
Bug 1404460: Add test for pocket locale enabling. r=liuche MozReview-Commit-ID: LHdQuICvVjE
bb2d7ca31f697313925ba16516df21b530a53c36: Bug 1404460: Hide Pocket preference if Pocket not available in locale. r=liuche
Michael Comella <michael.l.comella@gmail.com> - Mon, 02 Oct 2017 17:35:03 -0700 - rev 384127
Push 95706 by archaeopteryx@coole-files.de at Tue, 03 Oct 2017 09:46:41 +0000
Bug 1404460: Hide Pocket preference if Pocket not available in locale. r=liuche When changing locales, an open dialog will not refresh but clicking on the "Top sites" preference again (to display the dialog) will show the correct dialog for the current locale. MozReview-Commit-ID: 6UJvDIJZJtc
bc59c8db72973a11bfc445d1c9a8cd09c05a299a: Bug 1404460: Add POCKET_ENABLED_TO_LOCALE to asUserPrefs telemetry. r=liuche
Michael Comella <michael.l.comella@gmail.com> - Mon, 02 Oct 2017 17:01:10 -0700 - rev 384126
Push 95706 by archaeopteryx@coole-files.de at Tue, 03 Oct 2017 09:46:41 +0000
Bug 1404460: Add POCKET_ENABLED_TO_LOCALE to asUserPrefs telemetry. r=liuche After speaking with liuche, we decided it'd be better to add a bit to determine this rather than combining it with the isPocketEnabled field (which would be loss of data) or cross-referencing the locale of the submitted event when checking the Pocket value during telemetry analysis (which is hard to get right and likely to get out of date). MozReview-Commit-ID: JKFrdEsEbyp
141096343631b51eeb22501095e276d6cc75714c: Bug 1404460: Only show Pocket stories in specified locales. r=liuche
Michael Comella <michael.l.comella@gmail.com> - Mon, 02 Oct 2017 15:59:42 -0700 - rev 384125
Push 95706 by archaeopteryx@coole-files.de at Tue, 03 Oct 2017 09:46:41 +0000
Bug 1404460: Only show Pocket stories in specified locales. r=liuche Ideally, we'd centralize all queries as to which options are user specified. However, I wanted to do the smallest change so we can uplift so I filed bug 1405161 for this centralization. I opted not to include the "de" locale that is included on desktop because it does not appear we ever get the "de" locale on Firefox for Android [1]. I tested this patch by changing the system locale between locales with Pocket on my device (en-US, en-GB, de-DE) and locales without Pocket (ko-KR). The locale switching system makes this refresh automatically without extra code. I also intend to test via the in-app locale switcher but that will take time because I can't do artifact builds with multi-locale so I'm pushing this for review before I'm finished. Follow-up changes: - Add to telemetry - Hiding the preference in the undesired locales. - A test for isPocketEnabledByLocaleInner (useful to document how this is intended to work for locales with variants, different scripts, etc.) [1]: https://sql.telemetry.mozilla.org/queries/4613#table MozReview-Commit-ID: 7AVQ8fWub8I
aece6300bbea935dc825ec784f015606c0389528: Bug 1402026: Correct formatting for AS telemetry bulleted lists. r=liuche
Michael Comella <michael.l.comella@gmail.com> - Wed, 27 Sep 2017 15:10:02 -0700 - rev 383400
Push 95563 by archaeopteryx@coole-files.de at Thu, 28 Sep 2017 10:18:03 +0000
Bug 1402026: Correct formatting for AS telemetry bulleted lists. r=liuche Apparently, if you don't have whitespace above the bulleted list, it won't format as a list. MozReview-Commit-ID: LiLpSNScBxR
cd12463f904316353f0f6a7c0a08095039f447e7: Bug 1402026: Add interaction extra to AS telemetry. r=liuche
Michael Comella <michael.l.comella@gmail.com> - Wed, 27 Sep 2017 15:07:28 -0700 - rev 383399
Push 95563 by archaeopteryx@coole-files.de at Thu, 28 Sep 2017 10:18:03 +0000
Bug 1402026: Add interaction extra to AS telemetry. r=liuche MozReview-Commit-ID: EOr8Z8KRPGq
55432b5c3cd8fb491a4be297b60eb5a31d8662ff: Bug 1402026: Correct top site context menu telemetry note. r=liuche
Michael Comella <michael.l.comella@gmail.com> - Wed, 27 Sep 2017 15:01:42 -0700 - rev 383398
Push 95563 by archaeopteryx@coole-files.de at Thu, 28 Sep 2017 10:18:03 +0000
Bug 1402026: Correct top site context menu telemetry note. r=liuche The top sites menu button was removed in a previous iteration and long-click is used to access the context menu now. MozReview-Commit-ID: KzTg4Py8o8W