searching for reviewer(jwalden)
58d5d2a329f5cdb6b7a4d2f866d142340b4e7686: Bug 1595690 - Change JSOp enum storage type to uint8_t. r=jwalden
Jan de Mooij <jdemooij@mozilla.com> - Thu, 14 Nov 2019 19:21:07 +0000 - rev 502122
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1595690 - Change JSOp enum storage type to uint8_t. r=jwalden A bit more efficient when saving a JSOp in a data structure. It's also compatible with jsbytecode. Differential Revision: https://phabricator.services.mozilla.com/D52627
dd340ac5da49b543871350ff1f7e56e51cae4059: Bug 1560355 - Part 3: Add support for "numberingSystem" and "calendar" options. r=jwalden
André Bargull <andre.bargull@gmail.com> - Thu, 07 Nov 2019 16:31:12 +0000 - rev 501112
Push 114168 by dluca@mozilla.com at Sun, 10 Nov 2019 03:08:55 +0000
Bug 1560355 - Part 3: Add support for "numberingSystem" and "calendar" options. r=jwalden Currently restricted to Nightly-only, because the spec PR still contains bugs and there are no test262 tests for this feature (except for tests to ensure the properties are retrieved from the options object). Differential Revision: https://phabricator.services.mozilla.com/D51855
c4ad6acd96906f2846156c7985729b74ebd38c0e: Bug 1560355 - Part 2: Use LanguageTag to add "collation" keyword to Collator locale. r=jwalden
André Bargull <andre.bargull@gmail.com> - Thu, 07 Nov 2019 14:24:53 +0000 - rev 501111
Push 114168 by dluca@mozilla.com at Sun, 10 Nov 2019 03:08:55 +0000
Bug 1560355 - Part 2: Use LanguageTag to add "collation" keyword to Collator locale. r=jwalden Use ApplyUnicodeExtensionToTag to add the collation keyword instead of manually splicing the keyword into the language tag. Differential Revision: https://phabricator.services.mozilla.com/D51854
ba3307f474601809431832d35b1dc925b2471847: Bug 1560355 - Part 1: Change ApplyUnicodeExtensionToTag to accept a list of Unicode extension keywords. r=jwalden
André Bargull <andre.bargull@gmail.com> - Thu, 07 Nov 2019 14:24:28 +0000 - rev 501110
Push 114168 by dluca@mozilla.com at Sun, 10 Nov 2019 03:08:55 +0000
Bug 1560355 - Part 1: Change ApplyUnicodeExtensionToTag to accept a list of Unicode extension keywords. r=jwalden This will allow us to reuse this function to insert the calendar and numberingSystem options into the locale in part 3. Differential Revision: https://phabricator.services.mozilla.com/D51853
21014b340630d71f88d4733d98de5101b5007a00: Bug 1590641 - Test external string sizes in byteSize-of-string.js. r=jwalden
Jan de Mooij <jdemooij@mozilla.com> - Tue, 05 Nov 2019 17:36:08 +0000 - rev 500793
Push 114166 by apavel@mozilla.com at Thu, 07 Nov 2019 10:04:01 +0000
Bug 1590641 - Test external string sizes in byteSize-of-string.js. r=jwalden Bug 1590776 fixed memory reporting for external strings allocated by the newExternalString testing function so we can now add some tests. Differential Revision: https://phabricator.services.mozilla.com/D50612
bcffd4566969028da643328db4d897efdf97027c: Bug 1592588 - Part 7: Change mozilla::Range to mozilla::Span. r=jwalden
André Bargull <andre.bargull@gmail.com> - Thu, 31 Oct 2019 16:37:39 +0000 - rev 500058
Push 114164 by aiakab@mozilla.com at Tue, 05 Nov 2019 10:06:15 +0000
Bug 1592588 - Part 7: Change mozilla::Range to mozilla::Span. r=jwalden This is more or less restricted to using `Span::data` and `Span::size` instead of the equivalent counterparts from `Range`. For example span iterators aren't used in non-debug code, because the generated code when using span iterators is ridiculously large. Differential Revision: https://phabricator.services.mozilla.com/D51122
47f2c65173c3d30572e649ed33ec8c7e704c45fb: Bug 1592588 - Part 6: Add missing() and present() methods to LanguageSubtag. r=jwalden
André Bargull <andre.bargull@gmail.com> - Thu, 31 Oct 2019 16:29:18 +0000 - rev 500057
Push 114164 by aiakab@mozilla.com at Tue, 05 Nov 2019 10:06:15 +0000
Bug 1592588 - Part 6: Add missing() and present() methods to LanguageSubtag. r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D51121
f5677f3749eedbf656ee40e67a2598077dc010a7: Bug 1592588 - Part 5: Improve generated code for case conversions. r=jwalden
André Bargull <andre.bargull@gmail.com> - Thu, 31 Oct 2019 16:28:53 +0000 - rev 500056
Push 114164 by aiakab@mozilla.com at Tue, 05 Nov 2019 10:06:15 +0000
Bug 1592588 - Part 5: Improve generated code for case conversions. r=jwalden Two minor changes for slightly improved generated assembly: - Use addition/subtraction in AsciiTo[Upper,Lower]Case to ensure the compiler emits `lea` instead of `mov + bitop`. - Avoid dead SIMD code generation in LanguageTagSubtag case conversion methods. Differential Revision: https://phabricator.services.mozilla.com/D51120
60449bcbcfa436edde56b4c9ebdb8e7ddde1b296: Bug 1592588 - Part 4: Don't case normalise language, script, and region subtags when parsing. r=jwalden
André Bargull <andre.bargull@gmail.com> - Thu, 31 Oct 2019 16:28:28 +0000 - rev 500055
Push 114164 by aiakab@mozilla.com at Tue, 05 Nov 2019 10:06:15 +0000
Bug 1592588 - Part 4: Don't case normalise language, script, and region subtags when parsing. r=jwalden Similar to the previous parts, case normalisation for language, script, and region subtags now happen as part of the canonicalisation process. `LanguageTagParser::internalParseBaseName()` no longer needs to differentiate between parsing a normal base name or a base name within a transform extension, therefore we can remove its `BaseNameParsing` argument. The three `ParseStandalone` functions can now use the shared `IsStructurallyValid` functions, reducing duplicate code. Subtag canonicalisation in LanguageTagGenerated.cpp now needs to check for case normalised tags, so some additional assertions were added. Differential Revision: https://phabricator.services.mozilla.com/D51119
4ed0b50bf6f7a4e569ad2312397283567719427c: Bug 1592588 - Part 3: Don't case normalise variant subtags when parsing. r=jwalden
André Bargull <andre.bargull@gmail.com> - Thu, 31 Oct 2019 16:28:04 +0000 - rev 500054
Push 114164 by aiakab@mozilla.com at Tue, 05 Nov 2019 10:06:15 +0000
Bug 1592588 - Part 3: Don't case normalise variant subtags when parsing. r=jwalden Moves the case normalisation for variant subtags out of the language tag parser and into the canonicalisation method. Additionally duplicate variants are now checked after all variant subtags have been case normalised and sorted, which makes the duplicate variant check O(n) instead of O(n²). In our implementation we're always canonicalising language tags directly after parsing them, so there's no user observable difference when duplicate variants are checked. Differential Revision: https://phabricator.services.mozilla.com/D51118
973b95af894d84ea4ebb6a194547e088c2905142: Bug 1592588 - Part 2: Don't case normalise extension and private-use subtags when parsing. r=jwalden
André Bargull <andre.bargull@gmail.com> - Thu, 31 Oct 2019 16:27:39 +0000 - rev 500053
Push 114164 by aiakab@mozilla.com at Tue, 05 Nov 2019 10:06:15 +0000
Bug 1592588 - Part 2: Don't case normalise extension and private-use subtags when parsing. r=jwalden Case normalisation for extension and private-use subtags now happens in `LanguageTag::canonicalizeExtensions`. The `IsStructurallyValid` functions were updated to only test for structural validity, now finally matching their name. And `LanguageTagParser::extension(...)` was inlined, because it no longer also needs to perform case normalisation, which makes it small enough for an inline function. Differential Revision: https://phabricator.services.mozilla.com/D51117
7c1d1077fddf774d99478f97ce8aa79a4a4a8be3: Bug 1592588 - Part 1: Add a separate function to retrieve the Unicode extension from a LanguageTag. r=jwalden
André Bargull <andre.bargull@gmail.com> - Thu, 31 Oct 2019 16:27:15 +0000 - rev 500052
Push 114164 by aiakab@mozilla.com at Tue, 05 Nov 2019 10:06:15 +0000
Bug 1592588 - Part 1: Add a separate function to retrieve the Unicode extension from a LanguageTag. r=jwalden `unicodeExtensionIndex()` is already checking for 'U' in preparation for part 2. Differential Revision: https://phabricator.services.mozilla.com/D51115
53abc22d3299d3039c85b6ca1930ed55dfe93231: Bug 1590643 - Be more consistent about arena_id_t arguments in MallocProvider.h. r=jwalden
Jan de Mooij <jdemooij@mozilla.com> - Wed, 30 Oct 2019 15:51:04 +0000 - rev 500010
Push 114164 by aiakab@mozilla.com at Tue, 05 Nov 2019 10:06:15 +0000
Bug 1590643 - Be more consistent about arena_id_t arguments in MallocProvider.h. r=jwalden Add separate pod_arena_* overloads and remove the optional arena_id_t arguments. This makes both the naming and argument order more consistent with similar code elsewhere (for example js_pod_arena_malloc, AllocPolicyBase::pod_arena_malloc). Differential Revision: https://phabricator.services.mozilla.com/D50785
f4e5d28686830f13c7d178a1adcda17270e809cf: Bug 1592893 - Fix some Clang warnings about unused things in non-unified JS engine builds. r=jwalden
Jan de Mooij <jdemooij@mozilla.com> - Thu, 31 Oct 2019 07:00:50 +0000 - rev 499937
Push 114164 by aiakab@mozilla.com at Tue, 05 Nov 2019 10:06:15 +0000
Bug 1592893 - Fix some Clang warnings about unused things in non-unified JS engine builds. r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D51236
26eaf3f0479b535b44156377ab328c79b48237ac: Bug 1590641 - Test external string sizes in byteSize-of-string.js. r=jwalden
Jan de Mooij <jdemooij@mozilla.com> - Fri, 25 Oct 2019 21:17:27 +0000 - rev 499410
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1590641 - Test external string sizes in byteSize-of-string.js. r=jwalden Bug 1590776 fixed memory reporting for external strings allocated by the newExternalString testing function so we can now add some tests. Differential Revision: https://phabricator.services.mozilla.com/D50612
48201e9f33381abe1a82ffc95ec38abcc71f4ec4: Bug 1426865 - Fix formatting of macros in RecordReplay. r=jwalden
Philip Chimento <philip.chimento@gmail.com> - Sun, 27 Oct 2019 22:34:11 +0000 - rev 499393
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1426865 - Fix formatting of macros in RecordReplay. r=jwalden This has nothing to do with the bug, but it was driving me up the wall. Differential Revision: https://phabricator.services.mozilla.com/D50269
104b2ee49a3954b3969212d82c705b37fdacf121: Bug 1426865 - Add -Wno-attributes to GCC builds. r=jwalden,dmajor
Philip Chimento <philip.chimento@gmail.com> - Sun, 27 Oct 2019 22:06:53 +0000 - rev 499392
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1426865 - Add -Wno-attributes to GCC builds. r=jwalden,dmajor This suppresses the warning for GCC builds that was previously suppressed by the JS_BROKEN_GCC_ATTRIBUTE_WARNING macro. Depends on D49099 Differential Revision: https://phabricator.services.mozilla.com/D49230
681462911841fd4585cc778d641fb03bcc93f3fa: Bug 1590776 - Store the external-string-sizeOf callback with the finalize callback instead of per-runtime. r=jwalden,bzbarsky
Jan de Mooij <jdemooij@mozilla.com> - Thu, 24 Oct 2019 08:49:39 +0000 - rev 499069
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1590776 - Store the external-string-sizeOf callback with the finalize callback instead of per-runtime. r=jwalden,bzbarsky This renames the JSStringFinalizer struct to JSExternalStringCallbacks, makes it a virtual class, and adds a size-of callback to it (to replace the per-runtime callback). This will make it possible to implement this callback easily for the NewExternalString testing function (which we want for bug 1590641) without having to move this testing function to shell/js.cpp Differential Revision: https://phabricator.services.mozilla.com/D50234
02f8ab4ff12457cba2ed3744e45e62867847ad80: Bug 1330776 - Stop null-terminating JS strings, remove JSFlatString. r=jwalden,sfink
Jan de Mooij <jdemooij@mozilla.com> - Wed, 23 Oct 2019 11:23:50 +0000 - rev 498683
Push 114159 by shindli@mozilla.com at Thu, 24 Oct 2019 09:49:00 +0000
Bug 1330776 - Stop null-terminating JS strings, remove JSFlatString. r=jwalden,sfink JS strings can contain null bytes so relying on null-termination generally isn't the best idea. The (relatively few) places that did rely on null termination have been fixed in separate patches/bugs. This saves memory and avoids malloc/free for strings that now fit inline (because this bumps the length limits for thin-inline and fat-inline strings). It also simplifies dependent strings and external strings because we can remove both JSUndependedString and JSExternalString::ensureFlat. Differential Revision: https://phabricator.services.mozilla.com/D49905
1bf14b34d546a2352049809f87a261f1ee461322: Bug 1583269 - Part 5: Updating ICU requires a clobber. r=jwalden
André Bargull <andre.bargull@gmail.com> - Sat, 19 Oct 2019 01:40:06 +0000 - rev 498525
Push 114159 by shindli@mozilla.com at Thu, 24 Oct 2019 09:49:00 +0000
Bug 1583269 - Part 5: Updating ICU requires a clobber. r=jwalden Depends on D49447 Differential Revision: https://phabricator.services.mozilla.com/D49448
1e653dca5610a0389af758ea3ed391dbf0eeb240: Bug 1583269 - Part 4: Update language tag mappings for CLDR 36. r=jwalden
André Bargull <andre.bargull@gmail.com> - Sat, 19 Oct 2019 01:39:59 +0000 - rev 498524
Push 114159 by shindli@mozilla.com at Thu, 24 Oct 2019 09:49:00 +0000
Bug 1583269 - Part 4: Update language tag mappings for CLDR 36. r=jwalden Depends on D49445 Differential Revision: https://phabricator.services.mozilla.com/D49447
4e58a7aca4cdce2c1ae1d32d382647ddeda4f3d3: Bug 1583269 - Part 3: Update tests after ICU update. r=jwalden
André Bargull <andre.bargull@gmail.com> - Tue, 22 Oct 2019 08:36:58 +0000 - rev 498523
Push 114159 by shindli@mozilla.com at Thu, 24 Oct 2019 09:49:00 +0000
Bug 1583269 - Part 3: Update tests after ICU update. r=jwalden js/src/tests/jstests.list - Enable now passing test262 tests. non262/Intl/RelativeTimeFormat/format.js - "minute" and "hour" are now supported in 'text' contexts for relative time formatting. - Also see the now passing test262 tests. non262/Intl/NumberFormat/currency-sign-accounting.js non262/Intl/NumberFormat/sign-display.js - Referenced ICU bug has been fixed in ICU 65. non262/Intl/NumberFormat/notation-compact-short.js - 万亿 is preferred over 兆 in mainland China; CLDR sources were updated accordingly. non262/Intl/NumberFormat/notation-engineering.js non262/Intl/NumberFormat/notation-scientific.js - ICU removed "E0" suffix for non-finite numbers in engineering and scientific contexts. Differential Revision: https://phabricator.services.mozilla.com/D49445
b6ae6f738d81f876c26e93f8ba351d2bad3214ad: Bug 1583269 - Part 2: Update in-tree ICU to release 65.1. r=jwalden
André Bargull <andre.bargull@gmail.com> - Sat, 19 Oct 2019 01:25:24 +0000 - rev 498522
Push 114159 by shindli@mozilla.com at Thu, 24 Oct 2019 09:49:00 +0000
Bug 1583269 - Part 2: Update in-tree ICU to release 65.1. r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D49443
860578ad643054d780aaa798348569f80f701f10: Bug 1583269 - Part 1: Remove custom patch to add thread-safety to icu::TimeZone::adoptDefault. r=jwalden
André Bargull <andre.bargull@gmail.com> - Sat, 19 Oct 2019 01:23:08 +0000 - rev 498521
Push 114159 by shindli@mozilla.com at Thu, 24 Oct 2019 09:49:00 +0000
Bug 1583269 - Part 1: Remove custom patch to add thread-safety to icu::TimeZone::adoptDefault. r=jwalden The custom patch is no longer necessary now that <https://unicode-org.atlassian.net/browse/ICU-20595> has been fixed. Also inline `icu::TimeZone::recreateDefault` into its sole caller and then remove this API addition. Differential Revision: https://phabricator.services.mozilla.com/D49441
5a4e6f45d1affce3aacc7b4ad09548fed647fa60: Bug 1587590 - Update double-conversion to upstream revision 4a51e73. r=jwalden
Ryan VanderMeulen <ryanvm@gmail.com> - Fri, 11 Oct 2019 02:46:45 +0000 - rev 498356
Push 114157 by nbeleuzu@mozilla.com at Mon, 21 Oct 2019 22:00:13 +0000
Bug 1587590 - Update double-conversion to upstream revision 4a51e73. r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D48759
28171f948a0874143e59c9551712b8fa08e50f55: Bug 1584027 - Don't include filename in exception message if it's invalid UTF-8. r=jwalden
Jan de Mooij <jdemooij@mozilla.com> - Sun, 20 Oct 2019 09:34:09 +0000 - rev 498306
Push 114157 by nbeleuzu@mozilla.com at Mon, 21 Oct 2019 22:00:13 +0000
Bug 1584027 - Don't include filename in exception message if it's invalid UTF-8. r=jwalden Fuzzers can trigger this in the JS shell and until we enforce filenames are valid UTF-8 we have to deal with it somehow. Differential Revision: https://phabricator.services.mozilla.com/D49630
523a65f865b0d57464f3b534a20377f33d7871f3: Bug 1589254, rename .xul test files in js/ to .xhtml r=jwalden
Emma Malysz <emalysz@mozilla.com> - Thu, 17 Oct 2019 20:13:16 +0000 - rev 498097
Push 114157 by nbeleuzu@mozilla.com at Mon, 21 Oct 2019 22:00:13 +0000
Bug 1589254, rename .xul test files in js/ to .xhtml r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D49656
383e2052153e8f58da4f4e1b80005cee58ca4761: Bug 1433306 - Part 4: Reimport test262 tests. r=jwalden
André Bargull <andre.bargull@gmail.com> - Wed, 16 Oct 2019 16:03:56 +0000 - rev 497877
Push 114154 by btara@mozilla.com at Thu, 17 Oct 2019 09:58:40 +0000
Bug 1433306 - Part 4: Reimport test262 tests. r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D40439
78466d478f09067e38de5ce3b61efbc9bb357705: Bug 1433306 - Part 3: Enable test262 tests for Intl.ListFormat. r=jwalden
André Bargull <andre.bargull@gmail.com> - Wed, 16 Oct 2019 16:03:29 +0000 - rev 497876
Push 114154 by btara@mozilla.com at Thu, 17 Oct 2019 09:58:40 +0000
Bug 1433306 - Part 3: Enable test262 tests for Intl.ListFormat. r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D40438
d701e5149249ff718fd7acb7dac19770603d57e9: Bug 1433306 - Part 2: Implement Intl.ListFormat stage 3 proposal. r=jwalden
André Bargull <andre.bargull@gmail.com> - Wed, 16 Oct 2019 16:05:06 +0000 - rev 497875
Push 114154 by btara@mozilla.com at Thu, 17 Oct 2019 09:58:40 +0000
Bug 1433306 - Part 2: Implement Intl.ListFormat stage 3 proposal. r=jwalden "disjunction" and "unit" types aren't yet supported, because ICU doesn't provide a C-API for this functionality. "short" and "narrow" styles aren't supported for the same reason. Differential Revision: https://phabricator.services.mozilla.com/D40437
b818a65ca8da9bcc6ee5f821a1ae2f1d10e4c52b: Bug 1433306 - Part 1: Handle RelativeTimeFormat in getInternals and some clean-ups. r=jwalden
André Bargull <andre.bargull@gmail.com> - Wed, 16 Oct 2019 16:02:43 +0000 - rev 497874
Push 114154 by btara@mozilla.com at Thu, 17 Oct 2019 09:58:40 +0000
Bug 1433306 - Part 1: Handle RelativeTimeFormat in getInternals and some clean-ups. r=jwalden RelativeTimeFormat.cpp doesn't call `getInternals()` with an unresolved internals object, so this didn't blow up in the past. Drive-by fixes: - Remove the unused "methodName" argument from `getRelativeTimeFormatInternals`. Differential Revision: https://phabricator.services.mozilla.com/D40436
916eaf6f094e1ad86b28cd17b1cec49dcfa4b7ca: Bug 1588551 - Fix Vector::erase documentation comment r=jwalden
Jon Coppeard <jcoppeard@mozilla.com> - Tue, 15 Oct 2019 17:38:13 +0000 - rev 497857
Push 114154 by btara@mozilla.com at Thu, 17 Oct 2019 09:58:40 +0000
Bug 1588551 - Fix Vector::erase documentation comment r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D49321
2252a3f67ea36fa387c20ee38157f39931718764: Bug 1586991 part 20 - Don't rely on null-terminated strings in PrintHelpString. r=jwalden
Jan de Mooij <jdemooij@mozilla.com> - Wed, 16 Oct 2019 06:13:07 +0000 - rev 497776
Push 114154 by btara@mozilla.com at Thu, 17 Oct 2019 09:58:40 +0000
Bug 1586991 part 20 - Don't rely on null-terminated strings in PrintHelpString. r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D49271
99503df61d8e9f7b8bcbe5d38b341cd6d4a5c78f: Bug 1586991 part 19 - Use linear strings instead of flat strings in CTypes. r=jwalden
Jan de Mooij <jdemooij@mozilla.com> - Wed, 16 Oct 2019 06:12:33 +0000 - rev 497775
Push 114154 by btara@mozilla.com at Thu, 17 Oct 2019 09:58:40 +0000
Bug 1586991 part 19 - Use linear strings instead of flat strings in CTypes. r=jwalden Also simplify the code a bit by using js::CopyChars instead of manual char conversion/copying. Differential Revision: https://phabricator.services.mozilla.com/D49269
f9bb6a94cf050dfeeecf5b67539e07349f1e9d12: Bug 1586991 part 18 - Remove AssertHeapIsIdleOrStringIsFlat, use AssertHeapIsIdle instead. r=jwalden
Jan de Mooij <jdemooij@mozilla.com> - Wed, 16 Oct 2019 06:12:33 +0000 - rev 497774
Push 114154 by btara@mozilla.com at Thu, 17 Oct 2019 09:58:40 +0000
Bug 1586991 part 18 - Remove AssertHeapIsIdleOrStringIsFlat, use AssertHeapIsIdle instead. r=jwalden This appears to be green on Linux64 debug so apparently we no longer call these functions during GC. Depends on D49255 Differential Revision: https://phabricator.services.mozilla.com/D49257
d504123bd5277ed54d1466aacc1426a96e2426f8: Bug 1373089 - Part 7: Remove separate sets for DateFormat and NumberFormat available locales. r=jwalden
André Bargull <andre.bargull@gmail.com> - Tue, 15 Oct 2019 08:46:48 +0000 - rev 497605
Push 114154 by btara@mozilla.com at Thu, 17 Oct 2019 09:58:40 +0000
Bug 1373089 - Part 7: Remove separate sets for DateFormat and NumberFormat available locales. r=jwalden Because: - udat_countAvailable and unum_countAvailable directly return the result of uloc_countAvailable, - and udat_getAvailable and unum_getAvailable directly return the result of uloc_getAvailable, we don't need to keep the list of DateFormat and NumberFormat available locales in separate hash-sets, but instead can reuse the set used for ULocale. Differential Revision: https://phabricator.services.mozilla.com/D49171
8d6a70e38898b04d81175c68ee71a7cc78b12958: Bug 1373089 - Part 6: Move default locale computation to C++. r=jwalden
André Bargull <andre.bargull@gmail.com> - Tue, 15 Oct 2019 08:46:22 +0000 - rev 497604
Push 114154 by btara@mozilla.com at Thu, 17 Oct 2019 09:58:40 +0000
Bug 1373089 - Part 6: Move default locale computation to C++. r=jwalden When we move the default locale computation to C++, we don't have to worry about keeping the last-ditch locale and old-style locale mappings synchronised between JS and C++ code. Differential Revision: https://phabricator.services.mozilla.com/D40385
40a509a1f81f67555bac5893a1b42f17ac4ac49d: Bug 1373089 - Part 5: Remove no longer used functions. r=jwalden
André Bargull <andre.bargull@gmail.com> - Tue, 15 Oct 2019 08:45:59 +0000 - rev 497603
Push 114154 by btara@mozilla.com at Thu, 17 Oct 2019 09:58:40 +0000
Bug 1373089 - Part 5: Remove no longer used functions. r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D40384
9f6157252362d1af7941fbe07ddbc953a0a5cea3: Bug 1373089 - Part 4: Move BestAvailableLocale function to C++. r=jwalden
André Bargull <andre.bargull@gmail.com> - Tue, 15 Oct 2019 08:45:52 +0000 - rev 497602
Push 114154 by btara@mozilla.com at Thu, 17 Oct 2019 09:58:40 +0000
Bug 1373089 - Part 4: Move BestAvailableLocale function to C++. r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D40383
72e1f59d79d78ed3975f41c1dc39c4441f3eca34: Bug 1373089 - Part 3: Add available-locales set to SharedIntlData. r=jwalden
André Bargull <andre.bargull@gmail.com> - Tue, 15 Oct 2019 08:45:50 +0000 - rev 497601
Push 114154 by btara@mozilla.com at Thu, 17 Oct 2019 09:58:40 +0000
Bug 1373089 - Part 3: Add available-locales set to SharedIntlData. r=jwalden This will allow to share these hash-sets across multiple globals. Differential Revision: https://phabricator.services.mozilla.com/D40382
07abc37fc7536a67a3d545a7889f4ad8becb87ed: Bug 1373089 - Part 2: Add LanguageTag::toString function. r=jwalden
André Bargull <andre.bargull@gmail.com> - Tue, 15 Oct 2019 08:45:48 +0000 - rev 497600
Push 114154 by btara@mozilla.com at Thu, 17 Oct 2019 09:58:40 +0000
Bug 1373089 - Part 2: Add LanguageTag::toString function. r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D40381
949651526ead7cda8d2651f9dd2a94d9c530749a: Bug 1373089 - Part 1: Inline DefaultLocaleIgnoringAvailableLocales into its sole caller. r=jwalden
André Bargull <andre.bargull@gmail.com> - Tue, 15 Oct 2019 08:44:34 +0000 - rev 497599
Push 114154 by btara@mozilla.com at Thu, 17 Oct 2019 09:58:40 +0000
Bug 1373089 - Part 1: Inline DefaultLocaleIgnoringAvailableLocales into its sole caller. r=jwalden Both caches (localeCandidateCache and localeCache) are keyed on the same value, so when there's a cache miss, it always happens in both caches at the same time. That means the caching in DefaultLocaleIgnoringAvailableLocales can be removed and instead we can directly inline the code into its sole caller. Differential Revision: https://phabricator.services.mozilla.com/D40380
6d243ec1c977468dae1cb67915b49ee7a338b47d: Bug 1586706: Use QuoteString for JSString to char* conversion to ensure NUL characters don't cut off the result string. r=jwalden
André Bargull <andre.bargull@gmail.com> - Tue, 15 Oct 2019 08:52:49 +0000 - rev 497598
Push 114154 by btara@mozilla.com at Thu, 17 Oct 2019 09:58:40 +0000
Bug 1586706: Use QuoteString for JSString to char* conversion to ensure NUL characters don't cut off the result string. r=jwalden QuoteString always returns an ASCII string, so we can also change JS_ReportErrorNumberUTF8 to JS_ReportErrorNumberASCII in a few places. Differential Revision: https://phabricator.services.mozilla.com/D48527
e74ef3365a93e0bf5e1897f94c020a7929c99439: Bug 1586991 part 16 - Use JS_CopyStringCharsZ for the warning's stack trace in HandleInterrupt. r=jwalden
Jan de Mooij <jdemooij@mozilla.com> - Mon, 14 Oct 2019 20:39:49 +0000 - rev 497585
Push 114154 by btara@mozilla.com at Thu, 17 Oct 2019 09:58:40 +0000
Bug 1586991 part 16 - Use JS_CopyStringCharsZ for the warning's stack trace in HandleInterrupt. r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D49145
97a0a8d8732927b4ae529c0c48063204260fdf3b: Bug 1586991 part 15 - Use JS_CopyStringCharsZ in a number of places that need null-terminated strings. r=jwalden
Jan de Mooij <jdemooij@mozilla.com> - Mon, 14 Oct 2019 20:38:30 +0000 - rev 497584
Push 114154 by btara@mozilla.com at Thu, 17 Oct 2019 09:58:40 +0000
Bug 1586991 part 15 - Use JS_CopyStringCharsZ in a number of places that need null-terminated strings. r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D49142
8ce133a5cddd101e482f38340d0bbd1533a619db: Bug 1586991 part 14 - Remove unnecessary null chars from stack-allocated buffers in StaticStrings::init. r=jwalden
Jan de Mooij <jdemooij@mozilla.com> - Mon, 14 Oct 2019 12:55:31 +0000 - rev 497583
Push 114154 by btara@mozilla.com at Thu, 17 Oct 2019 09:58:40 +0000
Bug 1586991 part 14 - Remove unnecessary null chars from stack-allocated buffers in StaticStrings::init. r=jwalden Depends on D48498 Differential Revision: https://phabricator.services.mozilla.com/D48499
a2a4d95f674e4c5cef4df5b4def241231db8cc21: Bug 1586991 part 13 - Stop (unnecessarily) flattening strings in some JS shell functions. r=jwalden
Jan de Mooij <jdemooij@mozilla.com> - Mon, 14 Oct 2019 11:24:49 +0000 - rev 497582
Push 114154 by btara@mozilla.com at Thu, 17 Oct 2019 09:58:40 +0000
Bug 1586991 part 13 - Stop (unnecessarily) flattening strings in some JS shell functions. r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D48498
d947c2da3f5dd50ebb83afcff91df92ad7e513d7: Bug 1586991 part 12 - Use JSLinearString instead of JSFlatString in some more places. r=jwalden
Jan de Mooij <jdemooij@mozilla.com> - Fri, 11 Oct 2019 00:39:03 +0000 - rev 497581
Push 114154 by btara@mozilla.com at Thu, 17 Oct 2019 09:58:40 +0000
Bug 1586991 part 12 - Use JSLinearString instead of JSFlatString in some more places. r=jwalden Depends on D48496 Differential Revision: https://phabricator.services.mozilla.com/D48497
1c3c4eeab4b111922da5469ea02a60981ba9fa29: Bug 1588473 - Move |length > UINT32_CHAR_BUFFER_LENGTH| check from isIndexSlow slow path to the fast path. r=jwalden
Jan de Mooij <jdemooij@mozilla.com> - Tue, 15 Oct 2019 06:08:15 +0000 - rev 497577
Push 114154 by btara@mozilla.com at Thu, 17 Oct 2019 09:58:40 +0000
Bug 1588473 - Move |length > UINT32_CHAR_BUFFER_LENGTH| check from isIndexSlow slow path to the fast path. r=jwalden We also have to handle |length == 0| there so by checking the upper bound too we make it possible for C++ compilers to combine them into a single branch. Differential Revision: https://phabricator.services.mozilla.com/D49135
3f78bde9ec15dd3a57bee51d9bc0d9848d67d96f: Bug 1586991 part 11 - Return JSLinearString instead of JSFlatString from jit::StringFromCharCode. r=jwalden
Jan de Mooij <jdemooij@mozilla.com> - Tue, 15 Oct 2019 06:08:15 +0000 - rev 497576
Push 114154 by btara@mozilla.com at Thu, 17 Oct 2019 09:58:40 +0000
Bug 1586991 part 11 - Return JSLinearString instead of JSFlatString from jit::StringFromCharCode. r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D48496