Bug 1595690 - Change JSOp enum storage type to uint8_t. r=jwalden A bit more efficient when saving a JSOp in a data structure. It's also compatible with jsbytecode. Differential Revision: https://phabricator.services.mozilla.com/D52627

Bug 1560355 - Part 3: Add support for "numberingSystem" and "calendar" options. r=jwalden Currently restricted to Nightly-only, because the spec PR still contains bugs and there are no test262 tests for this feature (except for tests to ensure the properties are retrieved from the options object). Differential Revision: https://phabricator.services.mozilla.com/D51855

Bug 1560355 - Part 2: Use LanguageTag to add "collation" keyword to Collator locale. r=jwalden Use ApplyUnicodeExtensionToTag to add the collation keyword instead of manually splicing the keyword into the language tag. Differential Revision: https://phabricator.services.mozilla.com/D51854

Bug 1560355 - Part 1: Change ApplyUnicodeExtensionToTag to accept a list of Unicode extension keywords. r=jwalden This will allow us to reuse this function to insert the calendar and numberingSystem options into the locale in part 3. Differential Revision: https://phabricator.services.mozilla.com/D51853

Bug 1590641 - Test external string sizes in byteSize-of-string.js. r=jwalden Bug 1590776 fixed memory reporting for external strings allocated by the newExternalString testing function so we can now add some tests. Differential Revision: https://phabricator.services.mozilla.com/D50612

Bug 1592588 - Part 7: Change mozilla::Range to mozilla::Span. r=jwalden This is more or less restricted to using `Span::data` and `Span::size` instead of the equivalent counterparts from `Range`. For example span iterators aren't used in non-debug code, because the generated code when using span iterators is ridiculously large. Differential Revision: https://phabricator.services.mozilla.com/D51122

Bug 1592588 - Part 6: Add missing() and present() methods to LanguageSubtag. r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D51121

Bug 1592588 - Part 5: Improve generated code for case conversions. r=jwalden Two minor changes for slightly improved generated assembly: - Use addition/subtraction in AsciiTo[Upper,Lower]Case to ensure the compiler emits `lea` instead of `mov + bitop`. - Avoid dead SIMD code generation in LanguageTagSubtag case conversion methods. Differential Revision: https://phabricator.services.mozilla.com/D51120

Bug 1592588 - Part 4: Don't case normalise language, script, and region subtags when parsing. r=jwalden Similar to the previous parts, case normalisation for language, script, and region subtags now happen as part of the canonicalisation process. `LanguageTagParser::internalParseBaseName()` no longer needs to differentiate between parsing a normal base name or a base name within a transform extension, therefore we can remove its `BaseNameParsing` argument. The three `ParseStandalone` functions can now use the shared `IsStructurallyValid` functions, reducing duplicate code. Subtag canonicalisation in LanguageTagGenerated.cpp now needs to check for case normalised tags, so some additional assertions were added. Differential Revision: https://phabricator.services.mozilla.com/D51119

Bug 1592588 - Part 3: Don't case normalise variant subtags when parsing. r=jwalden Moves the case normalisation for variant subtags out of the language tag parser and into the canonicalisation method. Additionally duplicate variants are now checked after all variant subtags have been case normalised and sorted, which makes the duplicate variant check O(n) instead of O(n²). In our implementation we're always canonicalising language tags directly after parsing them, so there's no user observable difference when duplicate variants are checked. Differential Revision: https://phabricator.services.mozilla.com/D51118

Bug 1592588 - Part 2: Don't case normalise extension and private-use subtags when parsing. r=jwalden Case normalisation for extension and private-use subtags now happens in `LanguageTag::canonicalizeExtensions`. The `IsStructurallyValid` functions were updated to only test for structural validity, now finally matching their name. And `LanguageTagParser::extension(...)` was inlined, because it no longer also needs to perform case normalisation, which makes it small enough for an inline function. Differential Revision: https://phabricator.services.mozilla.com/D51117

Bug 1592588 - Part 1: Add a separate function to retrieve the Unicode extension from a LanguageTag. r=jwalden `unicodeExtensionIndex()` is already checking for 'U' in preparation for part 2. Differential Revision: https://phabricator.services.mozilla.com/D51115

Bug 1590643 - Be more consistent about arena_id_t arguments in MallocProvider.h. r=jwalden Add separate pod_arena_* overloads and remove the optional arena_id_t arguments. This makes both the naming and argument order more consistent with similar code elsewhere (for example js_pod_arena_malloc, AllocPolicyBase::pod_arena_malloc). Differential Revision: https://phabricator.services.mozilla.com/D50785

Bug 1592893 - Fix some Clang warnings about unused things in non-unified JS engine builds. r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D51236

Bug 1590641 - Test external string sizes in byteSize-of-string.js. r=jwalden Bug 1590776 fixed memory reporting for external strings allocated by the newExternalString testing function so we can now add some tests. Differential Revision: https://phabricator.services.mozilla.com/D50612

Bug 1426865 - Fix formatting of macros in RecordReplay. r=jwalden This has nothing to do with the bug, but it was driving me up the wall. Differential Revision: https://phabricator.services.mozilla.com/D50269

Bug 1426865 - Add -Wno-attributes to GCC builds. r=jwalden,dmajor This suppresses the warning for GCC builds that was previously suppressed by the JS_BROKEN_GCC_ATTRIBUTE_WARNING macro. Depends on D49099 Differential Revision: https://phabricator.services.mozilla.com/D49230

Bug 1590776 - Store the external-string-sizeOf callback with the finalize callback instead of per-runtime. r=jwalden,bzbarsky This renames the JSStringFinalizer struct to JSExternalStringCallbacks, makes it a virtual class, and adds a size-of callback to it (to replace the per-runtime callback). This will make it possible to implement this callback easily for the NewExternalString testing function (which we want for bug 1590641) without having to move this testing function to shell/js.cpp Differential Revision: https://phabricator.services.mozilla.com/D50234

Bug 1330776 - Stop null-terminating JS strings, remove JSFlatString. r=jwalden,sfink JS strings can contain null bytes so relying on null-termination generally isn't the best idea. The (relatively few) places that did rely on null termination have been fixed in separate patches/bugs. This saves memory and avoids malloc/free for strings that now fit inline (because this bumps the length limits for thin-inline and fat-inline strings). It also simplifies dependent strings and external strings because we can remove both JSUndependedString and JSExternalString::ensureFlat. Differential Revision: https://phabricator.services.mozilla.com/D49905

Bug 1583269 - Part 5: Updating ICU requires a clobber. r=jwalden Depends on D49447 Differential Revision: https://phabricator.services.mozilla.com/D49448

Bug 1583269 - Part 4: Update language tag mappings for CLDR 36. r=jwalden Depends on D49445 Differential Revision: https://phabricator.services.mozilla.com/D49447

Bug 1583269 - Part 3: Update tests after ICU update. r=jwalden js/src/tests/jstests.list - Enable now passing test262 tests. non262/Intl/RelativeTimeFormat/format.js - "minute" and "hour" are now supported in 'text' contexts for relative time formatting. - Also see the now passing test262 tests. non262/Intl/NumberFormat/currency-sign-accounting.js non262/Intl/NumberFormat/sign-display.js - Referenced ICU bug has been fixed in ICU 65. non262/Intl/NumberFormat/notation-compact-short.js - 万亿 is preferred over 兆 in mainland China; CLDR sources were updated accordingly. non262/Intl/NumberFormat/notation-engineering.js non262/Intl/NumberFormat/notation-scientific.js - ICU removed "E0" suffix for non-finite numbers in engineering and scientific contexts. Differential Revision: https://phabricator.services.mozilla.com/D49445

Bug 1583269 - Part 2: Update in-tree ICU to release 65.1. r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D49443

Bug 1583269 - Part 1: Remove custom patch to add thread-safety to icu::TimeZone::adoptDefault. r=jwalden The custom patch is no longer necessary now that <https://unicode-org.atlassian.net/browse/ICU-20595> has been fixed. Also inline `icu::TimeZone::recreateDefault` into its sole caller and then remove this API addition. Differential Revision: https://phabricator.services.mozilla.com/D49441

Bug 1587590 - Update double-conversion to upstream revision 4a51e73. r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D48759

Bug 1584027 - Don't include filename in exception message if it's invalid UTF-8. r=jwalden Fuzzers can trigger this in the JS shell and until we enforce filenames are valid UTF-8 we have to deal with it somehow. Differential Revision: https://phabricator.services.mozilla.com/D49630

Bug 1589254, rename .xul test files in js/ to .xhtml r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D49656

Bug 1433306 - Part 4: Reimport test262 tests. r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D40439

Bug 1433306 - Part 3: Enable test262 tests for Intl.ListFormat. r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D40438

Bug 1433306 - Part 2: Implement Intl.ListFormat stage 3 proposal. r=jwalden "disjunction" and "unit" types aren't yet supported, because ICU doesn't provide a C-API for this functionality. "short" and "narrow" styles aren't supported for the same reason. Differential Revision: https://phabricator.services.mozilla.com/D40437

Bug 1433306 - Part 1: Handle RelativeTimeFormat in getInternals and some clean-ups. r=jwalden RelativeTimeFormat.cpp doesn't call `getInternals()` with an unresolved internals object, so this didn't blow up in the past. Drive-by fixes: - Remove the unused "methodName" argument from `getRelativeTimeFormatInternals`. Differential Revision: https://phabricator.services.mozilla.com/D40436

Bug 1588551 - Fix Vector::erase documentation comment r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D49321

Bug 1586991 part 20 - Don't rely on null-terminated strings in PrintHelpString. r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D49271

Bug 1586991 part 19 - Use linear strings instead of flat strings in CTypes. r=jwalden Also simplify the code a bit by using js::CopyChars instead of manual char conversion/copying. Differential Revision: https://phabricator.services.mozilla.com/D49269

Bug 1586991 part 18 - Remove AssertHeapIsIdleOrStringIsFlat, use AssertHeapIsIdle instead. r=jwalden This appears to be green on Linux64 debug so apparently we no longer call these functions during GC. Depends on D49255 Differential Revision: https://phabricator.services.mozilla.com/D49257

Bug 1373089 - Part 7: Remove separate sets for DateFormat and NumberFormat available locales. r=jwalden Because: - udat_countAvailable and unum_countAvailable directly return the result of uloc_countAvailable, - and udat_getAvailable and unum_getAvailable directly return the result of uloc_getAvailable, we don't need to keep the list of DateFormat and NumberFormat available locales in separate hash-sets, but instead can reuse the set used for ULocale. Differential Revision: https://phabricator.services.mozilla.com/D49171

Bug 1373089 - Part 6: Move default locale computation to C++. r=jwalden When we move the default locale computation to C++, we don't have to worry about keeping the last-ditch locale and old-style locale mappings synchronised between JS and C++ code. Differential Revision: https://phabricator.services.mozilla.com/D40385

Bug 1373089 - Part 5: Remove no longer used functions. r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D40384

Bug 1373089 - Part 4: Move BestAvailableLocale function to C++. r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D40383

Bug 1373089 - Part 3: Add available-locales set to SharedIntlData. r=jwalden This will allow to share these hash-sets across multiple globals. Differential Revision: https://phabricator.services.mozilla.com/D40382

Bug 1373089 - Part 2: Add LanguageTag::toString function. r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D40381

Bug 1373089 - Part 1: Inline DefaultLocaleIgnoringAvailableLocales into its sole caller. r=jwalden Both caches (localeCandidateCache and localeCache) are keyed on the same value, so when there's a cache miss, it always happens in both caches at the same time. That means the caching in DefaultLocaleIgnoringAvailableLocales can be removed and instead we can directly inline the code into its sole caller. Differential Revision: https://phabricator.services.mozilla.com/D40380

Bug 1586706: Use QuoteString for JSString to char* conversion to ensure NUL characters don't cut off the result string. r=jwalden QuoteString always returns an ASCII string, so we can also change JS_ReportErrorNumberUTF8 to JS_ReportErrorNumberASCII in a few places. Differential Revision: https://phabricator.services.mozilla.com/D48527

Bug 1586991 part 16 - Use JS_CopyStringCharsZ for the warning's stack trace in HandleInterrupt. r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D49145

Bug 1586991 part 15 - Use JS_CopyStringCharsZ in a number of places that need null-terminated strings. r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D49142

Bug 1586991 part 14 - Remove unnecessary null chars from stack-allocated buffers in StaticStrings::init. r=jwalden Depends on D48498 Differential Revision: https://phabricator.services.mozilla.com/D48499

Bug 1586991 part 13 - Stop (unnecessarily) flattening strings in some JS shell functions. r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D48498

Bug 1586991 part 12 - Use JSLinearString instead of JSFlatString in some more places. r=jwalden Depends on D48496 Differential Revision: https://phabricator.services.mozilla.com/D48497

Bug 1588473 - Move |length > UINT32_CHAR_BUFFER_LENGTH| check from isIndexSlow slow path to the fast path. r=jwalden We also have to handle |length == 0| there so by checking the upper bound too we make it possible for C++ compilers to combine them into a single branch. Differential Revision: https://phabricator.services.mozilla.com/D49135

Bug 1586991 part 11 - Return JSLinearString instead of JSFlatString from jit::StringFromCharCode. r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D48496