searching for reviewer(jaws)
b5656f3353165e991e563acd3a0b276df4de7e65: Bug 1552780 - Add missing --grey-90-a60 variable r=jaws
Rob Wu <rob@robwu.nl> - Fri, 24 May 2019 19:43:05 +0000 - rev 475467
Push 113209 by aciure@mozilla.com at Sat, 25 May 2019 09:44:12 +0000
Bug 1552780 - Add missing --grey-90-a60 variable r=jaws Differential Revision: https://phabricator.services.mozilla.com/D32127
bf05610afb50c70199bf562ec75c6b9e8874849e: Bug 1553041 - Add waitForStateStop to try to fix intermittent. r=jaws
Michael Kaply <mozilla@kaply.com> - Wed, 22 May 2019 14:02:58 +0000 - rev 475018
Push 113187 by btara@mozilla.com at Thu, 23 May 2019 04:45:24 +0000
Bug 1553041 - Add waitForStateStop to try to fix intermittent. r=jaws Differential Revision: https://phabricator.services.mozilla.com/D32005
1e40a8e7a40409f7098c442b9023be5703d106cd: Bug 1550131 - Remove about:logins master password login notifications when the user logs in. r=jaws
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Tue, 21 May 2019 13:15:53 +0000 - rev 474744
Push 113171 by aiakab@mozilla.com at Tue, 21 May 2019 21:56:33 +0000
Bug 1550131 - Remove about:logins master password login notifications when the user logs in. r=jaws Depends on D31699 Differential Revision: https://phabricator.services.mozilla.com/D31700
9dbb7bb20ca334f6eaf8925a48df005006c745eb: Bug 1550131 - Show a notification when master password login is cancelled while about:logins is open. r=jaws
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Tue, 21 May 2019 13:15:46 +0000 - rev 474743
Push 113171 by aiakab@mozilla.com at Tue, 21 May 2019 21:56:33 +0000
Bug 1550131 - Show a notification when master password login is cancelled while about:logins is open. r=jaws Depends on D31698 Differential Revision: https://phabricator.services.mozilla.com/D31699
d84f90dcd58473413b5600543c6781aff060118c: Bug 1550131 - Expose an iterator for AboutLoginsParent subscribers. r=jaws
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Tue, 21 May 2019 13:15:44 +0000 - rev 474742
Push 113171 by aiakab@mozilla.com at Tue, 21 May 2019 21:56:33 +0000
Bug 1550131 - Expose an iterator for AboutLoginsParent subscribers. r=jaws Differential Revision: https://phabricator.services.mozilla.com/D31698
97eabc06294643214ff8d88a432e39c9e2242391: Bug 1550131 - Remove about:logins master password login notifications when the user logs in. r=jaws
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Mon, 20 May 2019 02:56:08 +0000 - rev 474602
Push 113165 by dvarga@mozilla.com at Tue, 21 May 2019 04:23:23 +0000
Bug 1550131 - Remove about:logins master password login notifications when the user logs in. r=jaws Depends on D31699 Differential Revision: https://phabricator.services.mozilla.com/D31700
32ff6a0b84360340e1e2fff213a8e0065586272a: Bug 1550131 - Show a notification when master password login is cancelled while about:logins is open. r=jaws
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Mon, 20 May 2019 02:56:05 +0000 - rev 474601
Push 113165 by dvarga@mozilla.com at Tue, 21 May 2019 04:23:23 +0000
Bug 1550131 - Show a notification when master password login is cancelled while about:logins is open. r=jaws Depends on D31698 Differential Revision: https://phabricator.services.mozilla.com/D31699
b562886d574d225ceeae632b98285110fdc80a64: Bug 1550131 - Expose an iterator for AboutLoginsParent subscribers. r=jaws
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Mon, 20 May 2019 02:56:01 +0000 - rev 474600
Push 113165 by dvarga@mozilla.com at Tue, 21 May 2019 04:23:23 +0000
Bug 1550131 - Expose an iterator for AboutLoginsParent subscribers. r=jaws Differential Revision: https://phabricator.services.mozilla.com/D31698
04ddaab38b6008fbf9fc6b863a3a373a10b47b9b: Bug 1446639 - Update policy tests to show URLs. r=jaws
Michael Kaply <mozilla@kaply.com> - Mon, 20 May 2019 15:12:06 +0000 - rev 474548
Push 113165 by dvarga@mozilla.com at Tue, 21 May 2019 04:23:23 +0000
Bug 1446639 - Update policy tests to show URLs. r=jaws Differential Revision: https://phabricator.services.mozilla.com/D31657
5142d8acf5e7a44966ddf03f08a4d03aac29ec7f: Bug 1551202 - Support dark theme for radio input at abuse reports r=jaws
Rob Wu <rob@robwu.nl> - Sat, 18 May 2019 05:47:16 +0000 - rev 474431
Push 113153 by apavel@mozilla.com at Sat, 18 May 2019 21:48:51 +0000
Bug 1551202 - Support dark theme for radio input at abuse reports r=jaws - Put every color in a variable name. - Add `label:hover` so that the radio input provides visual feedback upon hover. - Implement "pressed" (`[type="radio"]:active`) and `:focus{border:0}` to match Photon's design guidelines at https://design.firefox.com/photon/components/radio-buttons.html - Implement dark theme for radio inputs (using creative freedom as there is no Photon guideline for this). Differential Revision: https://phabricator.services.mozilla.com/D31510
5dd4697aa1a177aa9f6e950c197b67893b142c1e: Bug 1551202 - Update <message-bar> to fully match Photon's style r=jaws
Rob Wu <rob@robwu.nl> - Sat, 18 May 2019 12:28:55 +0000 - rev 474430
Push 113153 by apavel@mozilla.com at Sat, 18 May 2019 21:48:51 +0000
Bug 1551202 - Update <message-bar> to fully match Photon's style r=jaws - Update info.svg to adjust color based on the fill color. - Use button colors as defined by Photon (without this, the background of the non-generic buttons are almost indistinguishable when dark themes are enabled). - Small refactor of message-bar.css to put all type-specific declarations in one location. Differential Revision: https://phabricator.services.mozilla.com/D31509
2519b62544a9dae3fb29c59294420498ca637f8f: Bug 1551202 - Support dark theme at HTML about:addons r=jaws
Rob Wu <rob@robwu.nl> - Sat, 18 May 2019 05:47:15 +0000 - rev 474429
Push 113153 by apavel@mozilla.com at Sat, 18 May 2019 21:48:51 +0000
Bug 1551202 - Support dark theme at HTML about:addons r=jaws Most colors have been replaced with a variable that has the same color value. The exception is the border color at the add-on details. `--grey-90-a20` was replaced with `--in-content-box-border-color`, whose value is `--grey-90-a30`. This is close enough. Differential Revision: https://phabricator.services.mozilla.com/D31508
70b0d5a417b826c34f76cc244a303200fc4de885: Bug 1551202 - Support dark theme for radio input at abuse reports r=jaws
Rob Wu <rob@robwu.nl> - Fri, 17 May 2019 18:48:03 +0000 - rev 474388
Push 113152 by dluca@mozilla.com at Sat, 18 May 2019 10:33:03 +0000
Bug 1551202 - Support dark theme for radio input at abuse reports r=jaws - Put every color in a variable name. - Add `label:hover` so that the radio input provides visual feedback upon hover. - Implement "pressed" (`[type="radio"]:active`) and `:focus{border:0}` to match Photon's design guidelines at https://design.firefox.com/photon/components/radio-buttons.html - Implement dark theme for radio inputs (using creative freedom as there is no Photon guideline for this). Differential Revision: https://phabricator.services.mozilla.com/D31510
1454297813951e8531bed6673e41fb38425b9def: Bug 1551202 - Update <message-bar> to fully match Photon's style r=jaws
Rob Wu <rob@robwu.nl> - Fri, 17 May 2019 16:57:13 +0000 - rev 474387
Push 113152 by dluca@mozilla.com at Sat, 18 May 2019 10:33:03 +0000
Bug 1551202 - Update <message-bar> to fully match Photon's style r=jaws - Update info.svg to adjust color based on the fill color. - Use button colors as defined by Photon (without this, the background of the non-generic buttons are almost indistinguishable when dark themes are enabled). - Small refactor of message-bar.css to put all type-specific declarations in one location. Differential Revision: https://phabricator.services.mozilla.com/D31509
5f5daca84fbeb06f7df1569b18ad49da977b024e: Bug 1551202 - Support dark theme at HTML about:addons r=jaws
Rob Wu <rob@robwu.nl> - Fri, 17 May 2019 16:58:02 +0000 - rev 474386
Push 113152 by dluca@mozilla.com at Sat, 18 May 2019 10:33:03 +0000
Bug 1551202 - Support dark theme at HTML about:addons r=jaws Most colors have been replaced with a variable that has the same color value. The exception is the border color at the add-on details. `--grey-90-a20` was replaced with `--in-content-box-border-color`, whose value is `--grey-90-a30`. This is close enough. Differential Revision: https://phabricator.services.mozilla.com/D31508
f99a22d1e5a9c4723f558fb2dda3917e742ed5e3: Bug 1547006 - Add a regression test to ensure that the Picture-in-Picture toggle is not displayed in fullscreen mode. r=jaws
Mike Conley <mconley@mozilla.com> - Fri, 17 May 2019 20:08:01 +0000 - rev 474381
Push 113152 by dluca@mozilla.com at Sat, 18 May 2019 10:33:03 +0000
Bug 1547006 - Add a regression test to ensure that the Picture-in-Picture toggle is not displayed in fullscreen mode. r=jaws Differential Revision: https://phabricator.services.mozilla.com/D28561
e5a6c78aa9a36747bfcae767d654bd0b35833bea: Bug 1550143 - Open links included in the abuse report panel using a null triggeringPrincipal. r=mstriemer,jaws
Luca Greco <lgreco@mozilla.com> - Fri, 17 May 2019 10:41:11 +0000 - rev 474374
Push 113152 by dluca@mozilla.com at Sat, 18 May 2019 10:33:03 +0000
Bug 1550143 - Open links included in the abuse report panel using a null triggeringPrincipal. r=mstriemer,jaws Differential Revision: https://phabricator.services.mozilla.com/D30400
6d47ff50d4ac244474605754fab7a39bb3180b40: Bug 1550526 - Create deck with tabs for HTML about:addons details r=robwu,jaws
Mark Striemer <mstriemer@mozilla.com> - Wed, 15 May 2019 19:20:04 +0000 - rev 474172
Push 113134 by ncsoregi@mozilla.com at Thu, 16 May 2019 22:01:33 +0000
Bug 1550526 - Create deck with tabs for HTML about:addons details r=robwu,jaws Differential Revision: https://phabricator.services.mozilla.com/D29895
01fcbba06f1c5a79a6881c4a4378b0bd2476e22e: Bug 1550521 - Remove private browsing help message with settings hidden r=jaws
Mark Striemer <mstriemer@mozilla.com> - Tue, 14 May 2019 17:36:10 +0000 - rev 473815
Push 113111 by cbrindusan@mozilla.com at Tue, 14 May 2019 21:55:14 +0000
Bug 1550521 - Remove private browsing help message with settings hidden r=jaws Differential Revision: https://phabricator.services.mozilla.com/D30747
e3fc2a2d52de73e82fbf2fe0d4de1afed118d056: Bug 1550529 - Load tabprompts.css as document stylesheet in the XUL about:addons page. r=jaws
Luca Greco <lgreco@mozilla.com> - Mon, 13 May 2019 20:29:48 +0000 - rev 473679
Push 113102 by apavel@mozilla.com at Tue, 14 May 2019 04:24:11 +0000
Bug 1550529 - Load tabprompts.css as document stylesheet in the XUL about:addons page. r=jaws Differential Revision: https://phabricator.services.mozilla.com/D30655
9053b1f316ff269aba9b7b4bcbea0b97f9ca733c: Bug 1550526 - Create deck with tabs for HTML about:addons details r=robwu,jaws
Mark Striemer <mstriemer@mozilla.com> - Mon, 13 May 2019 19:05:26 +0000 - rev 473669
Push 113102 by apavel@mozilla.com at Tue, 14 May 2019 04:24:11 +0000
Bug 1550526 - Create deck with tabs for HTML about:addons details r=robwu,jaws Differential Revision: https://phabricator.services.mozilla.com/D29895
3fc09d5a4f225b2164b2a4ade0c2b1545f999903: Bug 1546997 - Expand add-on card with single click r=jaws
Mark Striemer <mstriemer@mozilla.com> - Sat, 11 May 2019 03:12:18 +0000 - rev 473603
Push 113093 by apavel@mozilla.com at Mon, 13 May 2019 22:09:34 +0000
Bug 1546997 - Expand add-on card with single click r=jaws These originally changed to double click with the HTML version but it was decided to stick with the single click and hover styles from the XUL version. Differential Revision: https://phabricator.services.mozilla.com/D30740
ef1a01ffef86fc60b349353c86e78e8c5b2af8b3: Bug 1551070 - Follow-up: re-enable browser_updateLogin.js on asan. rs=jaws DONTBUILD
Sebastian Hengst <archaeopteryx@coole-files.de> - Mon, 13 May 2019 07:26:11 +0200 - rev 473568
Push 113089 by malexandru@mozilla.com at Mon, 13 May 2019 08:28:31 +0000
Bug 1551070 - Follow-up: re-enable browser_updateLogin.js on asan. rs=jaws DONTBUILD
12d0981bc456c88396f3819aa64aa81d8f67cb66: Bug 1551070 - Check for type of remote content process depending on preference browser.tabs.remote.separatePrivilegedContentProcess in browser_updateLogin.js. r=jaws
Sebastian Hengst <archaeopteryx@coole-files.de> - Mon, 13 May 2019 05:13:33 +0000 - rev 473567
Push 113089 by malexandru@mozilla.com at Mon, 13 May 2019 08:28:31 +0000
Bug 1551070 - Check for type of remote content process depending on preference browser.tabs.remote.separatePrivilegedContentProcess in browser_updateLogin.js. r=jaws Also fixes bug 1551042. Differential Revision: https://phabricator.services.mozilla.com/D30831
9cd89ffdb9337a72ef1cab251e298596b7da96b4: Bug 1550863 - Fix disabled menu item styles in HTML about:addons r=jaws
Mark Striemer <mstriemer@mozilla.com> - Fri, 10 May 2019 21:04:01 +0000 - rev 473490
Push 113084 by rmaries@mozilla.com at Sat, 11 May 2019 10:04:51 +0000
Bug 1550863 - Fix disabled menu item styles in HTML about:addons r=jaws Differential Revision: https://phabricator.services.mozilla.com/D30718
3665b343720dbbdf145769089959b4cecaf81c2d: Bug 1535592 - Don't resizeToContent until all content is modified. r=jaws
Michael Kaply <mozilla@kaply.com> - Fri, 10 May 2019 21:02:37 +0000 - rev 473474
Push 113084 by rmaries@mozilla.com at Sat, 11 May 2019 10:04:51 +0000
Bug 1535592 - Don't resizeToContent until all content is modified. r=jaws Differential Revision: https://phabricator.services.mozilla.com/D30721
a1c80c3d3855ecc1f6281cb8cd5cfaa161326896: Bug 1550669 - Add a second row to autocomplete items for logins that shows origins. r=jaws
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Fri, 10 May 2019 17:58:10 +0000 - rev 473449
Push 113082 by dvarga@mozilla.com at Fri, 10 May 2019 21:54:38 +0000
Bug 1550669 - Add a second row to autocomplete items for logins that shows origins. r=jaws Based on a patch by Jared Wein <jwein@mozilla.com> Differential Revision: https://phabricator.services.mozilla.com/D27719
d87eef05591be2cb8b211a2ca26ef41e7b042f99: Bug 1547573 - fix sorting in and add test for themes dropdown in customize mode, r=jaws
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Thu, 09 May 2019 18:22:53 +0000 - rev 473329
Push 113072 by nbeleuzu@mozilla.com at Fri, 10 May 2019 02:59:17 +0000
Bug 1547573 - fix sorting in and add test for themes dropdown in customize mode, r=jaws Differential Revision: https://phabricator.services.mozilla.com/D30392
407fc9248a911ea70e74e44efa709b63af804607: Bug 1544928 - Allow to optionally report an extension on addon uninstall. r=flod,jaws,mstriemer
Luca Greco <lgreco@mozilla.com> - Mon, 06 May 2019 18:38:23 +0000 - rev 472763
Push 113048 by shindli@mozilla.com at Tue, 07 May 2019 09:56:38 +0000
Bug 1544928 - Allow to optionally report an extension on addon uninstall. r=flod,jaws,mstriemer Depends on D29121 Differential Revision: https://phabricator.services.mozilla.com/D29122
8f6b0e4004271985c3e14d28e9f3c608dc1d498e: Bug 1544928 - Add Report extension in browserAction context menu. r=flod,jaws,mstriemer
Luca Greco <lgreco@mozilla.com> - Mon, 06 May 2019 18:38:19 +0000 - rev 472761
Push 113048 by shindli@mozilla.com at Tue, 07 May 2019 09:56:38 +0000
Bug 1544928 - Add Report extension in browserAction context menu. r=flod,jaws,mstriemer Depends on D27294 Differential Revision: https://phabricator.services.mozilla.com/D29120
2547daf183e553ec60d8cb5ccbfb47358a17fb4d: Bug 1533166 - Move getSubmitMessage function into pwmgr_common.js to avoid duplication, r=jaws
Yuan Cheng <chengy12@msu.edu> - Mon, 06 May 2019 17:37:21 +0000 - rev 472738
Push 113042 by opoprus@mozilla.com at Mon, 06 May 2019 22:36:56 +0000
Bug 1533166 - Move getSubmitMessage function into pwmgr_common.js to avoid duplication, r=jaws Differential Revision: https://phabricator.services.mozilla.com/D30086
914bcc5d82716ce7ae91b90202b754ead0db06aa: Bug 1546973 - Add download related policies. r=jaws,flod
Michael Kaply <mozilla@kaply.com> - Fri, 03 May 2019 17:53:32 +0000 - rev 472569
Push 113025 by malexandru@mozilla.com at Fri, 03 May 2019 22:03:16 +0000
Bug 1546973 - Add download related policies. r=jaws,flod Differential Revision: https://phabricator.services.mozilla.com/D29277
59549c837955397b4d7da4f1c1f1656868f7f05b: Bug 1334012 - Move Login AutoComplete to its own interface. r=jaws
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Fri, 03 May 2019 00:08:12 +0000 - rev 472426
Push 113012 by dluca@mozilla.com at Fri, 03 May 2019 13:13:31 +0000
Bug 1334012 - Move Login AutoComplete to its own interface. r=jaws Differential Revision: https://phabricator.services.mozilla.com/D29694
a3cfd676266ff5e83cc3721444f12e888338bcb7: Bug 1545296 - Suppress mouse button events firing in content when clicking on the Picture-in-Picture toggle. r=jaws
Mike Conley <mconley@mozilla.com> - Thu, 02 May 2019 17:51:30 +0000 - rev 472370
Push 113004 by rgurzau@mozilla.com at Fri, 03 May 2019 04:25:36 +0000
Bug 1545296 - Suppress mouse button events firing in content when clicking on the Picture-in-Picture toggle. r=jaws Differential Revision: https://phabricator.services.mozilla.com/D29422
8049711eaaf944348ba3097264b98af40ed337f1: Bug 1334012 - Move Login AutoComplete to its own interface. r=jaws
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Thu, 02 May 2019 18:46:57 +0000 - rev 472364
Push 113004 by rgurzau@mozilla.com at Fri, 03 May 2019 04:25:36 +0000
Bug 1334012 - Move Login AutoComplete to its own interface. r=jaws Differential Revision: https://phabricator.services.mozilla.com/D29694
be001f8ade5a8e8fcd9c6e32f987a829b589d7e3: Bug 1548096 - Make PictureInPictureChild process trusted events only. r=jaws
Mike Conley <mconley@mozilla.com> - Wed, 01 May 2019 13:48:02 +0000 - rev 472120
Push 112980 by nerli@mozilla.com at Wed, 01 May 2019 21:59:08 +0000
Bug 1548096 - Make PictureInPictureChild process trusted events only. r=jaws Differential Revision: https://phabricator.services.mozilla.com/D29403
eb532b01e59209fdbd14b37baa2ab65317bd3e0a: Bug 1547614 View History Sidebar menu is missing label for in Library toolbutton r=jaws
Mohd Umar Alam <umaralam48@gmail.com> - Tue, 30 Apr 2019 13:04:47 +0000 - rev 471954
Push 112971 by ccoroiu@mozilla.com at Tue, 30 Apr 2019 21:59:18 +0000
Bug 1547614 View History Sidebar menu is missing label for in Library toolbutton r=jaws Differential Revision: https://phabricator.services.mozilla.com/D29133
a0006c759073f072bdd65ea28334e244716a6880: Bug 1543129 - fix buttons disappearing in customize mode after using 'restore defaults', r=jaws
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Mon, 29 Apr 2019 13:36:04 +0000 - rev 471741
Push 112948 by shindli@mozilla.com at Mon, 29 Apr 2019 21:58:23 +0000
Bug 1543129 - fix buttons disappearing in customize mode after using 'restore defaults', r=jaws Differential Revision: https://phabricator.services.mozilla.com/D28719
edceab8a8ace306709f93fee5aec3fc70dae3a74: Bug 1535683 - Part 2: Private browsing in HTML about:addons r=mixedpuppy,flod,jaws
Mark Striemer <mstriemer@mozilla.com> - Sat, 27 Apr 2019 00:30:41 +0000 - rev 471625
Push 112929 by nbeleuzu@mozilla.com at Sat, 27 Apr 2019 09:55:23 +0000
Bug 1535683 - Part 2: Private browsing in HTML about:addons r=mixedpuppy,flod,jaws Differential Revision: https://phabricator.services.mozilla.com/D27138
e88ce46ff45d146ead9b75b223de740d3c46c8ba: Bug 1547020 - Locking useDownloadDir shouldn't lock file chooser. r=jaws
Michael Kaply <mozilla@kaply.com> - Fri, 26 Apr 2019 19:47:08 +0000 - rev 471595
Push 112929 by nbeleuzu@mozilla.com at Sat, 27 Apr 2019 09:55:23 +0000
Bug 1547020 - Locking useDownloadDir shouldn't lock file chooser. r=jaws Differential Revision: https://phabricator.services.mozilla.com/D28874
33363b7f728c5f4a61ccf7f890ab6f1140a5ef95: Bug 1533533-Add a label to hide synced tabs sidebar when it is shown r=sfoster,jaws,flod
Mohd Umar Alam <umaralam48@gmail.com> - Fri, 26 Apr 2019 06:10:43 +0000 - rev 471452
Push 112923 by rmaries@mozilla.com at Fri, 26 Apr 2019 16:20:49 +0000
Bug 1533533-Add a label to hide synced tabs sidebar when it is shown r=sfoster,jaws,flod Differential Revision: https://phabricator.services.mozilla.com/D28177
00fcbf4c4aac4f492e7734d0eac68b25f50e79ba: Bug 1546521 - Removes unused variable sNewCertErrorPageEnabled r=jaws
Mariana Meireles <marianameireles@protonmail.com> - Thu, 25 Apr 2019 13:17:23 +0000 - rev 471315
Push 112913 by opoprus@mozilla.com at Thu, 25 Apr 2019 22:21:16 +0000
Bug 1546521 - Removes unused variable sNewCertErrorPageEnabled r=jaws Differential Revision: https://phabricator.services.mozilla.com/D28820
63fcd49131d7303b868a34241024d4a72ed1aafc: Bug 1538983 Rework highlightable buttons r=jaws
Andrew Swan <aswan@mozilla.com> - Fri, 19 Apr 2019 14:08:33 -0700 - rev 471290
Push 112911 by aswan@mozilla.com at Thu, 25 Apr 2019 20:48:08 +0000
Bug 1538983 Rework highlightable buttons r=jaws Our standard <button> binding has been carrying around an extra <label> just to support search highlighting in about:preferences. This patch removes that overhead by moving the tweaks that about:preferences needs into a custom element used only within about:preferences. Differential Revision: https://phabricator.services.mozilla.com/D28511
3aa8d3744f88586cbd2e0cac7743d91c29d0a130: Bug 1546482 - clean up added toolbars properly so editcontrols test passes, r=jaws
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Wed, 24 Apr 2019 14:51:09 +0000 - rev 471141
Push 112895 by cbrindusan@mozilla.com at Wed, 24 Apr 2019 22:47:15 +0000
Bug 1546482 - clean up added toolbars properly so editcontrols test passes, r=jaws Differential Revision: https://phabricator.services.mozilla.com/D28661
d566c68b2876efaf676c4f8c69817547547ea948: Bug 1544501 - Convert the ToolbarContextMenu to use strings from Fluent r=jaws,flod
Christian Frey <christianhfrey@gmail.com> - Wed, 24 Apr 2019 10:49:15 +0000 - rev 471094
Push 112895 by cbrindusan@mozilla.com at Wed, 24 Apr 2019 22:47:15 +0000
Bug 1544501 - Convert the ToolbarContextMenu to use strings from Fluent r=jaws,flod Differential Revision: https://phabricator.services.mozilla.com/D28281
c9f0730a57a6a938339c0d8868704080bb584357: Bug 1545554 - Hide Picture-in-Picture toggle when in fullscreen mode. r=jaws
Mike Conley <mconley@mozilla.com> - Wed, 24 Apr 2019 01:41:59 +0000 - rev 470817
Push 112879 by aciure@mozilla.com at Wed, 24 Apr 2019 04:31:08 +0000
Bug 1545554 - Hide Picture-in-Picture toggle when in fullscreen mode. r=jaws Differential Revision: https://phabricator.services.mozilla.com/D28527
44a66721dea767d7b832c7b5665121fad4205fe2: Bug 1546150 - Fix contrast of preferences search tooltip. r=jaws
Tim Nguyen <ntim.bugs@gmail.com> - Tue, 23 Apr 2019 22:33:56 +0000 - rev 470809
Push 112879 by aciure@mozilla.com at Wed, 24 Apr 2019 04:31:08 +0000
Bug 1546150 - Fix contrast of preferences search tooltip. r=jaws Differential Revision: https://phabricator.services.mozilla.com/D28383
f8541439e10186980ecea712820310b08144ec96: Bug 1185000 - Show a dismissed password manager doorhanger when credit card numbers are detected. r=jaws
prathiksha <prathikshaprasadsuman@gmail.com> - Fri, 19 Apr 2019 13:52:58 -0700 - rev 470315
Push 112861 by mozilla@noorenberghe.ca at Mon, 22 Apr 2019 01:42:51 +0000
Bug 1185000 - Show a dismissed password manager doorhanger when credit card numbers are detected. r=jaws In certain straight-forward cases where we detect a credit card number being used with password fields we will show a dismissed password manager doorhanger. The user can still choose to save in case the valid credit card number is actually their username or password. 1) If the Luhn checksum matches on the username field (see CreditCard.jsm) AND the password is 3 numerical digits (don't handle 4 for now even though it's used by Visa since there are banks that use 4 digits passwords for online banking still). 2) If the Luhn checksum matches on the password value AND we detect that the type=password field is a credit card field via autocomplete=cc-number. ** We must include the @autocomplete check otherwise sites will abuse this loophole on legit login forms and set autocomplete=cc-number on their password fields to avoid saving. For both of these cases we should `dismissed:true` doorhanger, rather than not showing one at all, in case there are false-negatives. Differential Revision: https://phabricator.services.mozilla.com/D25485
076077f53326a60ce878f3057cfeb00db15c927a: Bug 1545399 - Update the Preferences' setControllingExtensionDescription to only alter the DOM when needed. r=jaws
Zibi Braniecki <zbraniecki@mozilla.com> - Sun, 21 Apr 2019 00:50:41 +0000 - rev 470304
Push 112859 by rmaries@mozilla.com at Sun, 21 Apr 2019 10:34:53 +0000
Bug 1545399 - Update the Preferences' setControllingExtensionDescription to only alter the DOM when needed. r=jaws Differential Revision: https://phabricator.services.mozilla.com/D28170
e9be442c871e173a409f3b969f5bcea0e1ae4d71: Bug 1185000 - Show a dismissed password manager doorhanger when credit card numbers are detected. r=jaws
prathiksha <prathikshaprasadsuman@gmail.com> - Fri, 19 Apr 2019 13:52:58 -0700 - rev 470298
Push 112855 by mozilla@noorenberghe.ca at Sat, 20 Apr 2019 12:17:22 +0000
Bug 1185000 - Show a dismissed password manager doorhanger when credit card numbers are detected. r=jaws In certain straight-forward cases where we detect a credit card number being used with password fields we will show a dismissed password manager doorhanger. The user can still choose to save in case the valid credit card number is actually their username or password. 1) If the Luhn checksum matches on the username field (see CreditCard.jsm) AND the password is 3 numerical digits (don't handle 4 for now even though it's used by Visa since there are banks that use 4 digits passwords for online banking still). 2) If the Luhn checksum matches on the password value AND we detect that the type=password field is a credit card field via autocomplete=cc-number. ** We must include the @autocomplete check otherwise sites will abuse this loophole on legit login forms and set autocomplete=cc-number on their password fields to avoid saving. For both of these cases we should `dismissed:true` doorhanger, rather than not showing one at all, in case there are false-negatives. Differential Revision: https://phabricator.services.mozilla.com/D25485