searching for reviewer(janv)
7943aaba33624296d3942c13cd261991fa6af082: Bug 1592204 - P2 - Ignore the unknown files in repositories; r=janv
Tom Tung <ttung@mozilla.com> - Tue, 12 Nov 2019 07:52:14 +0000 - rev 501550
Push 114170 by malexandru@mozilla.com at Tue, 12 Nov 2019 21:58:32 +0000
Bug 1592204 - P2 - Ignore the unknown files in repositories; r=janv Differential Revision: https://phabricator.services.mozilla.com/D51872
a6786e02d33794542dbf0a3de5614943807a3ff4: Bug 1592204 - P1 - Ignore the unknown files in origin directories; r=asuth,janv
Tom Tung <ttung@mozilla.com> - Mon, 11 Nov 2019 13:50:03 +0000 - rev 501549
Push 114170 by malexandru@mozilla.com at Tue, 12 Nov 2019 21:58:32 +0000
Bug 1592204 - P1 - Ignore the unknown files in origin directories; r=asuth,janv Differential Revision: https://phabricator.services.mozilla.com/D51669
e8efb1f8fa3df5de2021ba54293e588557e91b17: Bug 1591990 - Enable local storage tests for Fission r=janv
Yaron Tausky <ytausky@mozilla.com> - Thu, 31 Oct 2019 15:28:13 +0000 - rev 500575
Push 114166 by apavel@mozilla.com at Thu, 07 Nov 2019 10:04:01 +0000
Bug 1591990 - Enable local storage tests for Fission r=janv These tests now pass when run under Fission. Differential Revision: https://phabricator.services.mozilla.com/D51105
617567f745c2494bc969f279219b4d53b6194d1e: Bug 1586189 - Re-implement waitForMessage based on waitForContentEvent; r=mccr8,janv
Simon Giesecke <sgiesecke@mozilla.com> - Wed, 30 Oct 2019 15:26:25 +0000 - rev 499797
Push 114163 by aiakab@mozilla.com at Thu, 31 Oct 2019 10:03:38 +0000
Bug 1586189 - Re-implement waitForMessage based on waitForContentEvent; r=mccr8,janv Differential Revision: https://phabricator.services.mozilla.com/D49752
4980beb4ea2a84f6f8f81c4daae45f0a173bf19c: Bug 1576593 - P2 - Change the way for tunneling quota information to SQLite; r=janv
Tom Tung <ttung@mozilla.com> - Fri, 25 Oct 2019 12:02:10 +0000 - rev 499243
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1576593 - P2 - Change the way for tunneling quota information to SQLite; r=janv Differential Revision: https://phabricator.services.mozilla.com/D48183
2cf7f9254640214a3184481d42ae94d973cc673c: Bug 1576593 - P1 - Move IntString to QuotaCommon and introduce IntCString to be used by IDB and DOM Cache; r=janv
Tom Tung <ttung@mozilla.com> - Wed, 23 Oct 2019 08:52:47 +0000 - rev 499242
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1576593 - P1 - Move IntString to QuotaCommon and introduce IntCString to be used by IDB and DOM Cache; r=janv Differential Revision: https://phabricator.services.mozilla.com/D49575
dddb97ff7ed9140ec0934f723f4446e3ada0067d: Bug 1577107 - Avoid following the prototype chain r=janv
Yaron Tausky <ytausky@mozilla.com> - Fri, 27 Sep 2019 13:36:25 +0000 - rev 495610
Push 114140 by dvarga@mozilla.com at Wed, 02 Oct 2019 18:04:51 +0000
Bug 1577107 - Avoid following the prototype chain r=janv With this commit we no longer follow the value's prototype chain when creating index updates in IndexedDB. Differential Revision: https://phabricator.services.mozilla.com/D44438
bc7ab9de3675177e47056a541879aee9e2aa0415: Bug 1561611 - Removing the code for collecting unexpected filenames in origin directories; r=chutten,janv
Tom Tung <ttung@mozilla.com> - Fri, 27 Sep 2019 17:16:08 +0000 - rev 495405
Push 114134 by ccoroiu@mozilla.com at Mon, 30 Sep 2019 09:57:15 +0000
Bug 1561611 - Removing the code for collecting unexpected filenames in origin directories; r=chutten,janv Differential Revision: https://phabricator.services.mozilla.com/D36021
e91773704fbd766da1e8657b2a579713c0c54a75: Bug 1577107 - Avoid following the prototype chain r=janv
Yaron Tausky <ytausky@mozilla.com> - Fri, 13 Sep 2019 09:35:09 +0000 - rev 495203
Push 114134 by ccoroiu@mozilla.com at Mon, 30 Sep 2019 09:57:15 +0000
Bug 1577107 - Avoid following the prototype chain r=janv With this commit we no longer follow the value's prototype chain when creating index updates in IndexedDB. Differential Revision: https://phabricator.services.mozilla.com/D44438
48603e8781d805261425b2bbb93ea0bcee4af13a: Bug 1581278 part 3. Stop incorrectly rejecting promises in storage manager. r=janv
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 19 Sep 2019 18:18:28 +0000 - rev 494504
Push 114122 by csabou@mozilla.com at Mon, 23 Sep 2019 21:59:47 +0000
Bug 1581278 part 3. Stop incorrectly rejecting promises in storage manager. r=janv Differential Revision: https://phabricator.services.mozilla.com/D46384
845c6cac22129cefe7cce8a9ddda771e07ef1003: Bug 1093064 - Repeat garbage collection until ref count becomes 0 r=janv
Simon Giesecke <sgiesecke@mozilla.com> - Fri, 13 Sep 2019 14:02:20 +0000 - rev 493093
Push 114082 by dvarga@mozilla.com at Fri, 13 Sep 2019 21:51:00 +0000
Bug 1093064 - Repeat garbage collection until ref count becomes 0 r=janv Differential Revision: https://phabricator.services.mozilla.com/D42609
2d435f837f1ca5785b797c9bddda814648d88f71: Bug 1580238 - Extend the release for the prob of initialization time on QM and add another one to catch the longest time; r=janv,sg
Tom Tung <shes050117@gmail.com> - Wed, 11 Sep 2019 13:55:50 +0000 - rev 492881
Push 114078 by nerli@mozilla.com at Thu, 12 Sep 2019 22:41:47 +0000
Bug 1580238 - Extend the release for the prob of initialization time on QM and add another one to catch the longest time; r=janv,sg Differential Revision: https://phabricator.services.mozilla.com/D45501
b3f5d14640620f4c28631dcc182c11c5c794ea44: Bug 1577202 - Replace assertion for missing mDirectoryLock by a regular failure. r=janv
Simon Giesecke <sgiesecke@mozilla.com> - Wed, 11 Sep 2019 08:17:46 +0000 - rev 492616
Push 114069 by aiakab@mozilla.com at Wed, 11 Sep 2019 16:08:52 +0000
Bug 1577202 - Replace assertion for missing mDirectoryLock by a regular failure. r=janv Differential Revision: https://phabricator.services.mozilla.com/D44681
2c5b36e69041914a1347be2814f3ab2b9c70ca9a: Bug 1093064 - Increase number of GC iterations r=ttung,janv
Simon Giesecke <sgiesecke@mozilla.com> - Thu, 08 Aug 2019 07:55:18 +0000 - rev 486936
Push 113858 by rmaries@mozilla.com at Thu, 08 Aug 2019 23:21:39 +0000
Bug 1093064 - Increase number of GC iterations r=ttung,janv Differential Revision: https://phabricator.services.mozilla.com/D40183
837a81caab2606b6c7a481c7f0ec991f6e25d906: Bug 1516333 - Part 2: Add LS unit test for uri encoding edge cases; r=janv
Eden Chuang <echuang@mozilla.com> - Fri, 07 Jun 2019 08:18:37 +0200 - rev 477680
Push 113370 by jvarga@mozilla.com at Fri, 07 Jun 2019 06:57:32 +0000
Bug 1516333 - Part 2: Add LS unit test for uri encoding edge cases; r=janv Differential Revision: https://phabricator.services.mozilla.com/D33617
d413f486759891bcaacb1d7e4ec9180fe4319ffb: Bug 1516333 - Part 1: Move group and origin re-escaping from QuotaManager::GetQuotaObject to GetQuotaObjectFromNameAndParameters in TelemetryVFS.cpp; r=janv,asuth
Eden Chuang <echuang@mozilla.com> - Fri, 07 Jun 2019 08:04:57 +0200 - rev 477679
Push 113369 by jvarga@mozilla.com at Fri, 07 Jun 2019 06:09:56 +0000
Bug 1516333 - Part 1: Move group and origin re-escaping from QuotaManager::GetQuotaObject to GetQuotaObjectFromNameAndParameters in TelemetryVFS.cpp; r=janv,asuth Differential Revision: https://phabricator.services.mozilla.com/D33769
29bdbbe89264b91d1bd4205c45536c9222a8d6ee: Bug 1546752 - Stop creating, writing, and reading the .metadata file in QuotaManager except the upgrades; r=janv
Tom Tung <shes050117@gmail.com> - Mon, 20 May 2019 14:13:27 +0000 - rev 474533
Push 113164 by dvarga@mozilla.com at Mon, 20 May 2019 22:19:47 +0000
Bug 1546752 - Stop creating, writing, and reading the .metadata file in QuotaManager except the upgrades; r=janv The main goal of this issue is to reduce IO during the storage initialization and stop creating .metadata file since we already have .metadata-v2 file to track the information for the origin directory. Therefore, this patch only stop create, write, and read the .metadata file. And, leaving the work for removing it to the next minor upgrade. Differential Revision: https://phabricator.services.mozilla.com/D28824
695621ee868dc607e49f848c72be87fe7a14c909: Bug 1514600 - P1 - Notify LS to cleanup the gUsages while storage initialization fails; r=janv
Tom Tung <shes050117@gmail.com> - Mon, 29 Apr 2019 10:49:58 +0000 - rev 474368
Push 113152 by dluca@mozilla.com at Sat, 18 May 2019 10:33:03 +0000
Bug 1514600 - P1 - Notify LS to cleanup the gUsages while storage initialization fails; r=janv Differential Revision: https://phabricator.services.mozilla.com/D27502
9437ce7f56f17a5f38e3c64f165005845a50fc69: Bug 1535298 - Capture and ignore the exception for not having a host from a principal URI; r=janv,johannh
Tom Tung <shes050117@gmail.com> - Tue, 14 May 2019 16:49:03 +0000 - rev 473813
Push 113111 by cbrindusan@mozilla.com at Tue, 14 May 2019 21:55:14 +0000
Bug 1535298 - Capture and ignore the exception for not having a host from a principal URI; r=janv,johannh Protocols, likes about:, moz-extension, ... etc, don't have a host. Thus, an exception will be returned if they are accessed. To avoid from that, this patch catches this bug a try-catch. Differential Revision: https://phabricator.services.mozilla.com/D29821
158510da415deb7ae973e79f1658b305d75ac96b: Bug 1481164 - Dispatch to the Background thread even when the Connection is a nullptr in IdleConnectionRunnable::Run(); r=janv
Tom Tung <shes050117@gmail.com> - Tue, 23 Apr 2019 18:05:41 +0000 - rev 471079
Push 112895 by cbrindusan@mozilla.com at Wed, 24 Apr 2019 22:47:15 +0000
Bug 1481164 - Dispatch to the Background thread even when the Connection is a nullptr in IdleConnectionRunnable::Run(); r=janv Differential Revision: https://phabricator.services.mozilla.com/D28520
de1c51fce80e5bee60661bff92e2006970ecd760: Bug 1539538 - Introduce UnsafePtr r=froydnj,janv
Yaron Tausky <ytausky@mozilla.com> - Tue, 09 Apr 2019 14:41:57 +0000 - rev 468592
Push 112738 by nbeleuzu@mozilla.com at Tue, 09 Apr 2019 22:28:41 +0000
Bug 1539538 - Introduce UnsafePtr r=froydnj,janv This commit adds a smart pointer class that verifies that no dangling pointers remain after the pointee went out of scope. This verification is opt-in and can be controlled both statically and dynamically by the pointee. Differential Revision: https://phabricator.services.mozilla.com/D25200
02b7484f316b1936479d4e28789c9c6dbf3fad9c: Bug 1507229 - Argument sanity check at CreateMutableFile() to avoid assertion failure r=janv
violet <violet.bugreport@gmail.com> - Fri, 22 Mar 2019 14:01:31 +0000 - rev 465822
Push 112523 by shindli@mozilla.com at Sat, 23 Mar 2019 09:54:29 +0000
Bug 1507229 - Argument sanity check at CreateMutableFile() to avoid assertion failure r=janv CreateMutableFile() doesn't allow empty name, we should check it before further processing to avoid assertion failure. Differential Revision: https://phabricator.services.mozilla.com/D23999
7bf89a70ca2059034470bcd61508c8c229621d1d: Bug 1529301 - P0 - Change some code to align the clang format; r=janv
Tom Tung <shes050117@gmail.com> - Thu, 21 Mar 2019 08:53:48 +0000 - rev 465634
Push 112518 by apavel@mozilla.com at Fri, 22 Mar 2019 16:53:03 +0000
Bug 1529301 - P0 - Change some code to align the clang format; r=janv Differential Revision: https://phabricator.services.mozilla.com/D24226
7a0c015fcc50407349ec27b25ad0c002edca0f60: Bug 1535619 - add meta information to create bugs for files in dom/localstorage/ in 'Core :: DOM: Web Storage' r=janv
Sebastian Hengst <archaeopteryx@coole-files.de> - Fri, 15 Mar 2019 14:01:58 +0000 - rev 464591
Push 112465 by aciure@mozilla.com at Sun, 17 Mar 2019 09:50:10 +0000
Bug 1535619 - add meta information to create bugs for files in dom/localstorage/ in 'Core :: DOM: Web Storage' r=janv Differential Revision: https://phabricator.services.mozilla.com/D23670
29e28daebae57e16db9d32017e7f34eb968d02fb: Bug 1516277 - Add local execution mode to nsThread r=janv,froydnj
Yaron Tausky <ytausky@mozilla.com> - Wed, 06 Mar 2019 16:26:07 +0000 - rev 462658
Push 112326 by ccoroiu@mozilla.com at Thu, 07 Mar 2019 04:41:19 +0000
Bug 1516277 - Add local execution mode to nsThread r=janv,froydnj Differential Revision: https://phabricator.services.mozilla.com/D21241
44d83d32e254ccdb9441b8c0388262e436918da5: Bug 1516277 - Add local execution mode to nsThread r=janv,froydnj
Yaron Tausky <ytausky@mozilla.com> - Wed, 06 Mar 2019 13:53:16 +0000 - rev 462639
Push 112326 by ccoroiu@mozilla.com at Thu, 07 Mar 2019 04:41:19 +0000
Bug 1516277 - Add local execution mode to nsThread r=janv,froydnj Differential Revision: https://phabricator.services.mozilla.com/D21241
4389ed44ce098d81136244e70a941d812ea73221: Bug 1515605 - Enable ESLint for dom/localstorage (manual changes). r=janv
Mark Banner <standard8@mozilla.com> - Fri, 21 Dec 2018 10:13:00 +0000 - rev 451674
Push 110713 by rgurzau@mozilla.com at Fri, 21 Dec 2018 16:40:07 +0000
Bug 1515605 - Enable ESLint for dom/localstorage (manual changes). r=janv Differential Revision: https://phabricator.services.mozilla.com/D15073
a535962417c0d37bd82387093238f6457109e279: Bug 1515605 - Enable ESLint for dom/localstorage (automatic changes). r=janv
Mark Banner <standard8@mozilla.com> - Fri, 21 Dec 2018 10:12:45 +0000 - rev 451673
Push 110713 by rgurzau@mozilla.com at Fri, 21 Dec 2018 16:40:07 +0000
Bug 1515605 - Enable ESLint for dom/localstorage (automatic changes). r=janv Differential Revision: https://phabricator.services.mozilla.com/D15072
fd8d109b37c1cc5642971fc254bfa60153f5d98d: Bug 1502871 - Get RefPtr to transaction before using it; r=janv
Yaron Tausky <ytausky@mozilla.com> - Thu, 20 Dec 2018 13:39:46 +0000 - rev 451544
Push 110693 by nbeleuzu@mozilla.com at Thu, 20 Dec 2018 22:05:28 +0000
Bug 1502871 - Get RefPtr to transaction before using it; r=janv Avoid use-after-free by getting a RefPtr to a transaction before calling content code that could cause its deallocation. Differential Revision: https://phabricator.services.mozilla.com/D14427
fd65b14ab7e8aba272dd49f84af229b3ecef6e0a: Bug 1286798 - Part 53: Review code comments; r=janv,mrbkap,mccr8
Andrew Sutherland <asutherland@asutherland.org> - Mon, 05 Nov 2018 14:04:39 -0500 - rev 448806
Push 110253 by jvarga@mozilla.com at Thu, 29 Nov 2018 20:50:49 +0000
Bug 1286798 - Part 53: Review code comments; r=janv,mrbkap,mccr8
6214aafc061f09377c40eca490cc12621169c892: Bug 1286798 - Part 35: Implement database shadowing; r=asuth,janv
Jan Varga <jan.varga@gmail.com> - Thu, 29 Nov 2018 21:49:07 +0100 - rev 448788
Push 110253 by jvarga@mozilla.com at Thu, 29 Nov 2018 20:50:49 +0000
Bug 1286798 - Part 35: Implement database shadowing; r=asuth,janv This adds synchronization to the global database used by previous local storage implementation. This patch was enhanced by asuth to bind attached database path. Places has shown that argument binding is necessary. (Profiles may include usernames in their path which can have cool emoji and such.)
2620df4a91da32a75123274b2f603e45e78ca3df: Bug 1286798 - Part 26: Implement a lazy data migration from old webappsstore.sqlite; r=asuth,janv
Jan Varga <jan.varga@gmail.com> - Thu, 29 Nov 2018 21:48:38 +0100 - rev 448779
Push 110253 by jvarga@mozilla.com at Thu, 29 Nov 2018 20:50:49 +0000
Bug 1286798 - Part 26: Implement a lazy data migration from old webappsstore.sqlite; r=asuth,janv This patch was enhanced by asuth to bind attached database path. Places has shown that argument binding is necessary. (Profiles may include usernames in their path which can have cool emoji and such.)
75c28b78f8ee02018ccaec9c2f4035d46182d10e: Bug 1286798 - Part 10: Support for storage events; r=asuth,janv
Jan Varga <jan.varga@gmail.com> - Thu, 29 Nov 2018 21:47:45 +0100 - rev 448763
Push 110253 by jvarga@mozilla.com at Thu, 29 Nov 2018 20:50:49 +0000
Bug 1286798 - Part 10: Support for storage events; r=asuth,janv Storage events are fired either directly after getting response from synchronous SetItem call or through observers. When a new onstorage event listener is added, we sycnhronously register an observer in the parent process. There's always only one observer actor per content process. PBackgroundLSDatabase is now managed by a new PBackgroundLSObject protocol. PBackgroundLSObject is needed to eliminate the need to pass the principal info and document URI everytime a write operation occurs. Preparation of an observer shares some states with preparation of a datastore, so common stuff now lives in LSRequestBase and preparation of a datastore now implements a nested state machine. This patch was enhanced by asuth to drop observers only when the last storage listener is removed. EventListenerRemoved is invoked on any removal, not just the final removal, so we need to make sure it's the final removal before dropping observer.
0b0a03cf7b64cc9cc6eff36c3ae7f56f010e944c: Bug 1286798 - Part 6: Fix a dead lock in the single process case; r=asuth,janv
Jan Varga <jan.varga@gmail.com> - Thu, 29 Nov 2018 21:47:30 +0100 - rev 448759
Push 110253 by jvarga@mozilla.com at Thu, 29 Nov 2018 20:50:49 +0000
Bug 1286798 - Part 6: Fix a dead lock in the single process case; r=asuth,janv Expose the nested main event target, so it can be used in the single process case by the parent side to process runnables which need to run on the main thread. After this change we don't have use hacks like getting profile directory path on the child side and sending it to the parent. The parent side can now do it freely even in the single process case. This patch was enhanced by asuth to not tunnel the nested main event target through IPC.
2317749c5abfb7eab139a2545d2fa5362d2309f0: Bug 1496801 - Set persist mode on ExtensionStorageIDB for extensions with the unlimitedStorage permission. r=mixedpuppy,janv
Luca Greco <lgreco@mozilla.com> - Sat, 17 Nov 2018 20:07:28 +0000 - rev 447908
Push 110089 by btara@mozilla.com at Fri, 23 Nov 2018 21:42:24 +0000
Bug 1496801 - Set persist mode on ExtensionStorageIDB for extensions with the unlimitedStorage permission. r=mixedpuppy,janv Differential Revision: https://phabricator.services.mozilla.com/D7915
78f4415212432c196010505418aaa0ffdeeb7677: Bug 1425146 - P2 - Add a test reproducing the reported issue to verify that a Cache directory without a padding file and with an old version of the database doesn't break the storage initialization; r=janv
Tom Tung <shes050117@gmail.com> - Thu, 25 Oct 2018 16:34:56 +0200 - rev 443294
Push 109338 by shes050117@gmail.com at Mon, 29 Oct 2018 11:04:18 +0000
Bug 1425146 - P2 - Add a test reproducing the reported issue to verify that a Cache directory without a padding file and with an old version of the database doesn't break the storage initialization; r=janv An issue for missing the "response_padding_size" column in cache.sqlite was reported in bug 1425146 comment 39. This test reproduces it and is mainly to ensure that a Cache directory which lacks a directory padding file and contains an old version of cache.sqlite can still be initialized successfully.
52646a13f5de473e342c6c1ff2719137fcd43ac4: Bug 1425146 - P1 - Ensure the schema for the cache.sqlite is up to date beforing accessing it; r=janv
Tom Tung <shes050117@gmail.com> - Fri, 07 Sep 2018 10:28:30 +0200 - rev 443293
Push 109338 by shes050117@gmail.com at Mon, 29 Oct 2018 11:04:18 +0000
Bug 1425146 - P1 - Ensure the schema for the cache.sqlite is up to date beforing accessing it; r=janv Bug 1290481 introduces the padding mechanism, but there was a corner case which weren't handled correctly. It created a chance to access cache database before acutally checking the database version and schema upgrade. If the schema of cache.sqlite is too old and the padding file disappear, it breaks origins initialization. This patch ensure the schema is updated to the newest before accessing it.
c768d21501f987b2bef5293994c5b772b48991b0: Bug 1395102 - P4 - Reuse the code for MaybeUpgradeClients() in the upgrade helpers; r=janv
Tom Tung <shes050117@gmail.com> - Fri, 19 Oct 2018 11:36:08 +0200 - rev 442291
Push 109133 by shes050117@gmail.com at Mon, 22 Oct 2018 07:23:27 +0000
Bug 1395102 - P4 - Reuse the code for MaybeUpgradeClients() in the upgrade helpers; r=janv This patch moves MaybeUpgradeClients to RepositoryOperationBase class from UpgradeStorageFrom1_0To2_0Helper and UpgradeStorageFrom2_0To2_1Helper so that lines of code can be reused.
47335300b3377e6a3c696fb9392d30d567a2bac6: Bug 1395102 - P3 - Reuse the code for QuotaManager::UpgradeStorageFromxxToxx(); r=janv
Tom Tung <shes050117@gmail.com> - Wed, 17 Oct 2018 15:37:16 +0200 - rev 442290
Push 109133 by shes050117@gmail.com at Mon, 22 Oct 2018 07:23:27 +0000
Bug 1395102 - P3 - Reuse the code for QuotaManager::UpgradeStorageFromxxToxx(); r=janv This patch adds a new function QM::UpgradeStorage() to reuse lines of code in QM:UpgradeStorageFrom0_0To1_0(), QM:UpgradeStorageFrom1_0To2_0(), and QM:UpgradeStorageFrom2_0To2_1().
a0de0c0ec6b01e9d74cd2bcfe6333e1cbaf566dc: Bug 1395102 - P2 - Rename the intermediate class in P1 to RepositoryOperationBase; r=janv
Tom Tung <shes050117@gmail.com> - Wed, 17 Oct 2018 14:29:55 +0200 - rev 442289
Push 109133 by shes050117@gmail.com at Mon, 22 Oct 2018 07:23:27 +0000
Bug 1395102 - P2 - Rename the intermediate class in P1 to RepositoryOperationBase; r=janv To do this, it also rename the StorageDirectoryHelper to StorageOperationBase to align with classes naming. Bsides, this patch renames RepositoryOperationBase::DoUpgrade() to RepositoryOperationBase::ProcessRepository().
0d01e0a4de9550efec739bfe912b0cdb50057941: Bug 1395102 - P1 - Introduce a intermediate helper class to reuse code for upgrading origin directories; r=janv
Tom Tung <shes050117@gmail.com> - Thu, 18 Oct 2018 11:12:28 +0200 - rev 442288
Push 109133 by shes050117@gmail.com at Mon, 22 Oct 2018 07:23:27 +0000
Bug 1395102 - P1 - Introduce a intermediate helper class to reuse code for upgrading origin directories; r=janv This patch mainly create a new helper class and it inherits from StorageDirectoraryHelper to reuse the code in CreateOrUpgradeDirectoryMetadataHelper::CreateOrUpgradeMetadataFiles(), UpgradeStorageFrom0_0To1_0Helper::DoUpgrade(), UpgradeStorageFrom1_0To2_0Helper::DoUpgrade(), UpgradeStorageFrom2_0To2_1Helper::DoUpgrade().
daed617054ce114772d208c79bbe8cd8d858d310: Bug 1481716 - Add a telemetry probe to track how long does the QM take for initializing repositories; r=janv, data-review=francois
Tom Tung <shes050117@gmail.com> - Mon, 13 Aug 2018 10:34:10 +0200 - rev 441429
Push 108978 by shes050117@gmail.com at Tue, 16 Oct 2018 12:06:46 +0000
Bug 1481716 - Add a telemetry probe to track how long does the QM take for initializing repositories; r=janv, data-review=francois This patch adds a telemetry probe to track the time for initializing both the default and the temporary repositories.
6de689423ff668027dd71205bfa21f3dfa3fb05c: Bug 1389380 - Add a test for storage pressure event; r=janv
Tom Tung <shes050117@gmail.com> - Thu, 04 Oct 2018 10:32:41 +0200 - rev 439612
Push 108631 by shes050117@gmail.com at Thu, 04 Oct 2018 15:24:37 +0000
Bug 1389380 - Add a test for storage pressure event; r=janv A storage pressure event should be fired when the current usage is greater than the global limit. Currently, the QuotaManger checks the usage and the limit in two different cases, and this test verfiies both cases do fire a storage pressure event with a correct value of usage. The first one is that a quota client is asking for writting a new storage into the disk, but it will make the currnet usage become greater than the global limit. The other one is that the calculating limit is less than the current usage while initilaizing the temporary storage.
4f495d81e201cd809515bdd76bab7292fa76f5df: Bug 1389378 - A test for verifying persisted origins bounded by the global limit; r=janv
Tom Tung <shes050117@gmail.com> - Mon, 17 Sep 2018 11:21:41 +0200 - rev 439606
Push 108626 by shes050117@gmail.com at Thu, 04 Oct 2018 14:17:08 +0000
Bug 1389378 - A test for verifying persisted origins bounded by the global limit; r=janv Bug 1372116 reported that PersistOp() didn't create an originInfo object for the persisting origin if the temporary storage had been initialized. The test verifies that no matter the temporary storage was initialized or not the PersistOp should hanlde the originInfo object properly so that the persisting origin will be bounded by the global limit.
75a2cc1386416e4d20da45bf63027540f73c1c04: Bug 1495687 - Introduce initTemporaryStorage to nsIQuotaManagerService for testing; r=janv
Tom Tung <shes050117@gmail.com> - Tue, 02 Oct 2018 16:08:43 +0200 - rev 439605
Push 108626 by shes050117@gmail.com at Thu, 04 Oct 2018 14:17:08 +0000
Bug 1495687 - Introduce initTemporaryStorage to nsIQuotaManagerService for testing; r=janv
3ed04fa44d07ed2a7c8734f24e0d198c6002b743: Bug 1389390 - Add a test to verify a persisted origin won't be evicted; r=janv
Tom Tung <shes050117@gmail.com> - Tue, 25 Sep 2018 17:14:53 +0200 - rev 438951
Push 108457 by shes050117@gmail.com at Mon, 01 Oct 2018 14:09:44 +0000
Bug 1389390 - Add a test to verify a persisted origin won't be evicted; r=janv Bug 1298392 introduced persist() to QuotaManager. This patch intends to verify that normally the oldest origin will be evicted if the global limit is reached, but if the oldest origin is persisted, then it won't be evicted.
3206c9b8db975f6b30bc4ee1a70402ccfdc68e36: Bug 1488401 - Remove the remnants of the DiskSpaceWatcher r=asuth,janv,smaug
Gabriele Svelto <gsvelto@mozilla.com> - Thu, 13 Sep 2018 06:40:51 +0000 - rev 436194
Push 107816 by nerli@mozilla.com at Thu, 13 Sep 2018 22:18:58 +0000
Bug 1488401 - Remove the remnants of the DiskSpaceWatcher r=asuth,janv,smaug Differential Revision: https://phabricator.services.mozilla.com/D4933
4ffdf21d17fa654eab1398d6579304a52d456755: Bug 1379411 - Apply CheckedInt to infoLength for preventing it from overflowing in the future; r=janv
Tom Tung <shes050117@gmail.com> - Tue, 11 Sep 2018 12:39:14 +0200 - rev 436125
Push 107789 by shes050117@gmail.com at Thu, 13 Sep 2018 08:10:03 +0000
Bug 1379411 - Apply CheckedInt to infoLength for preventing it from overflowing in the future; r=janv CheckedInt propagates the mIsValid in each add operation so that it avoids having a bunch of code for the overflow check in each add operation. Furthermore, it avoids mismatching parameters between the computing result and the additional overflow check. This patch uses it based on advantages described above.
0ae703cca0f392b3c1cdd1a98f019e50ff7f86a7: Bug 1485971 - Followup for enabling test on Beta and Release for bug 1482812; r=janv
Tom Tung <shes050117@gmail.com> - Fri, 24 Aug 2018 15:16:26 +0200 - rev 433443
Push 107069 by shes050117@gmail.com at Mon, 27 Aug 2018 07:45:16 +0000
Bug 1485971 - Followup for enabling test on Beta and Release for bug 1482812; r=janv Bug 1482812 enabled the check for whether origin is valid in both Beta and Release channels, but it didn't enable the test under the quota folder. That test verified the check does work while executing storage.persist() if the origin hasn't been initialized yet. Thus, this patch removes the pref to verify this check does work for storage.persist() on Beta and the Release channels.
c2a1d27fb7a9777e1f08719f0c59e104eb325d53: Bug 1483042 - Remove more ~RefPtr that fire after a Rooted has been unwrapped for a return value, r=janv
Steve Fink <sfink@mozilla.com> - Mon, 13 Aug 2018 14:51:20 -0700 - rev 433034
Push 106956 by sfink@mozilla.com at Thu, 23 Aug 2018 14:05:01 +0000
Bug 1483042 - Remove more ~RefPtr that fire after a Rooted has been unwrapped for a return value, r=janv