Bug 1519501 - Generalize a bit GenerateServoStyleConsts and rename to RunCbindgen. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D16399

Bug 1518954 - Three-value position syntax uses calc() as its computed value representation. r=heycam This restores the previous behavior of using calc(). Note that background-position / object-position, which test this, weren't hitting the assertion because they use another codepath. I didn't add more extensive tests for this because it's well tested for those two properties, and because this is legacy anyway, see the comment in the test. I did add the assertion to the codepath those two properties hit. Differential Revision: https://phabricator.services.mozilla.com/D16176

Bug 1518263 - Use Intl.NumberFormat objects to format numbers in about:memory rather than hand-rolling formatting code or using toLocaleString that will create a fresh formatter object every time it's called. r=heycam

Bug 1517511 - Simplify computed::LengthOrPercentage and friends. r=heycam This is a first step to share LengthOrPercentage representation between Rust and Gecko. We need to preserve whether the value came from a calc() expression, for now at least, since we do different things depending on whether we're calc or not right now. See https://github.com/w3c/csswg-drafts/issues/3482 and dependent bugs for example. That means that the gecko conversion code needs to handle calc() in a bit of an awkward way until I change it to not be needed (patches for that incoming in the next few weeks I hope). I need to add a hack to exclude other things from the PartialEq implementation because the new conversion code is less lossy than the old one, and we relied on the lousiness in AnimationValue comparison (in order to start transitions and such, in [1] for example). I expect to remove that manual PartialEq implementation as soon as I'm done with the conversion. The less lossy conversion does fix a few serialization bugs for animation values though, like not loosing 0% values in calc() when interpolating lengths and percentages, see the two modified tests: * property-types.js * test_animation_properties.html Differential Revision: https://phabricator.services.mozilla.com/D15793

Bug 1517682 - Drop layout.css.background-blend-mode.enabled pref. r=heycam It was enabled by default in bug 970600. Depends on D15707 Differential Revision: https://phabricator.services.mozilla.com/D15708

Bug 1517682 - Drop layout.css.scroll-behavior.property-enabled pref. r=heycam It was enabled by default in bug 1041833 (for desktops) and bug 1087562 (for Fennect). Depends on D15706 Differential Revision: https://phabricator.services.mozilla.com/D15707

Bug 1517682 - Drop layout.css.mix-blend-mode.enabled pref. r=heycam It was enabled by default in bug 952643. Depends on D15705 Differential Revision: https://phabricator.services.mozilla.com/D15706

Bug 1517682 - Drop layout.css.isolation.enabled pref. r=heycam It was enabled by default in bug 1091885. Depends on D15704 Differential Revision: https://phabricator.services.mozilla.com/D15705

Bug 1517682 - Drop layout.css.image-orientation.enabled pref. r=heycam It was enabled by default in bug 825771. Depends on D15703 Differential Revision: https://phabricator.services.mozilla.com/D15704

Bug 1517682 - Drop layout.css.color-adjust.enabled pref. r=heycam It was enabled by default in bug 1209273. Depends on D15702 Differential Revision: https://phabricator.services.mozilla.com/D15703

Bug 1517682 - Drop layout.css.box-decoration-break.enabled pref. r=heycam It was enabled by default in bug 1006326. Differential Revision: https://phabricator.services.mozilla.com/D15702

Bug 1515556 comment fix-ups for the tree reformat (layout/) r=Ehsan,heycam Differential Revision: https://phabricator.services.mozilla.com/D13125

Bug 1513920 - Make <use> shadow trees lookup keyframe rules in the containing tree. r=heycam The same thing we do for rule matching. Differential Revision: https://phabricator.services.mozilla.com/D14548

Bug 1512026 - Handle nested slots correctly in slotted matching and invalidation. r=heycam The patch and test should be pretty much self-descriptive. Differential Revision: https://phabricator.services.mozilla.com/D14063

Bug 1513387: Add braces & newlines to re-wrap some return statements that clang-format unwrapped, in layout/svg. r=heycam This patch shouldn't affect behavior; it's just making the existing control flow clearer and more debuggable. Differential Revision: https://phabricator.services.mozilla.com/D14216

Bug 1513012 - Move overflow to use cbindgen. r=heycam It's one of the most annoying / hacky mako bits we have. Differential Revision: https://phabricator.services.mozilla.com/D14084

Bug 1513058 - Deduplicate a bit the malloc_size_of code for hashmaps / hashsets. r=heycam This allows to experiment with other hash maps easily rather than depending on what hashglobe::fake::HashMap dereferences to. In particular I wrote it while trying to get a build working with hashbrown. Differential Revision: https://phabricator.services.mozilla.com/D14098

Bug 1511730 patch 3 - Verify there are no frame state bit conflicts within groups. r=heycam Without patch 1, this correctly triggers: Assertion failure: !(bitsUsedPerGroup[group] & bit) (BULLET_FRAME_HAS_FONT_INFLATION must not use a bit already declared within its group), at /home/dbaron/builds/mozilla-central/mozilla/layout/generic/nsFrameStateBits.h:594 Differential Revision: https://phabricator.services.mozilla.com/D13779

Bug 1511730 patch 2 - Refactor the frame state group macros so that there's a unique header for every group. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D13778

Bug 1511730 patch 1 - But nsBulletFrame-specific state bits in the correct group. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D13777

Bug 1509717 - Use cbindgen for border-style and outline-style. r=heycam I'm pretty sure the FIXME I left in the outline-style code is a bug, but I want to clean this up further and I didn't want to fix it without adding a test. Differential Revision: https://phabricator.services.mozilla.com/D12859

Bug 1509717 - Move BorderStyle to border.rs. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D12858

Bug 775618 - Implement page-break-{before,after} as legacy shorthands for {before,after}. r=heycam This is all the style-system work needed for this. This implements the concept of legacy shorthands, teaches tests to understand it, and adds a few more tests for these properties in particular. The WPT even caught a few WebKit / Blink bugs: https://bugs.chromium.org/p/chromium/issues/detail?id=906336 https://bugs.webkit.org/show_bug.cgi?id=191803 This doesn't change the layout behavior for page-break-before: always, since it'd stop breaking in multicol and such. Similarly, break-before / break-after: column and page still behave the same, I'll file followups for those given comment 22. Differential Revision: https://phabricator.services.mozilla.com/D12211

Bug 775618 - Introduce the concept of legacy shorthands. r=heycam We need this because there's a weird mapping between these properties' values ('always' maps to 'page'). See https://drafts.csswg.org/css-cascade-4/#legacy-shorthand. Differential Revision: https://phabricator.services.mozilla.com/D12213

Bug 775618 - Introduce break-inside, and alias page-break-inside to it. r=heycam This property has no weird value mapping, so we can just do this. Differential Revision: https://phabricator.services.mozilla.com/D12212

Bug 1509664 - Change Text Rendering constants to enum classes in nsStyleConsts.h. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D12839

Bug 1504918. Prevent TextNodeCorrespondenceRecorder::TraverseAndRecord crash. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D11107

Bug 1507305 - Use Servo to serialize most of the already-exposed shorthands. r=heycam Skip mask and text-decoration for now since there's a single test-case failing for each that seem worth fixing in a different bug: * For mask, there's the case of setting mask: url(foo.svg#bar), which we test we serialize absolutely. But given we're uncomputing it we don't serialize the resolved URL. Chrome doesn't either so we could just change the test, but even if we decided to do it we probably should do it in a separate bug. * For text-decoration, we need to resolve the value, when it's an interpolation between currentcolor and other color. Right now that returns the empty string which is not great: https://searchfox.org/mozilla-central/rev/d850d799a0009f851b5535580e0a8b4bb2c591d7/servo/components/style/values/specified/color.rs#194 So I need to come up with something. Probably we need to implement the "hard" version of the serialization code that doesn't reuse the animation machinery. Definitely a separate bug though. While at it, also serialize all <position> longhands with Servo, so that I can clean up the tests. Differential Revision: https://phabricator.services.mozilla.com/D11948

Bug 1507305 - Add a mechanism to serialize shorthands for getComputedStyle(). r=heycam This implements the mechanism reusing the animation machinery for now, so it asserts in a few cases that this wouldn't handle correctly. For shorthands that have colors and other bits we'd need a more sophisticated mechanism with a bit more code (that resolves colors and such), but it'd look something like this regardless, and we should have this in any case. Differential Revision: https://phabricator.services.mozilla.com/D11944

Bug 1507311 - Make the serialization of the mask shorthand more compact. r=heycam This helps to preserve the old longhand form when possible (mask used to be a longhand), which will be relevant when we serialize this for the computed value. Differential Revision: https://phabricator.services.mozilla.com/D11943

Bug 1507309 - Simplify background-repeat. r=heycam This way we always serialize in the shortest form, and take less space. This is useful because when serializing uncomputed values we'd like to compare to the initial value to avoid serializing parts of a shorthand, but with the existing implementation we would generate always a second keyword, which means that we'll never match it. This also matches Chrome and WebKit, incidentally, so I'm pretty confident the behavior change when serializing specified style is web-compatible. Differential Revision: https://phabricator.services.mozilla.com/D11941

Bug 1507127 - Also move page-break-inside outside of mako. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D11876

Bug 1507127 - Move the page-break-{before,after} properties to not use mako. r=heycam And respect the computed value of `left` / `right` / etc. Differential Revision: https://phabricator.services.mozilla.com/D11872

Bug 1433439 - Don't expose non-content-accessible pseudo-elements from getComputedStyle. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D11830

Bug 1499961 - Indicate position-change reflow hint when RecomputePosition() bails out - r=dbaron,heycam If a frame cannot be repositioned, the reflow request should hint at the position change, so that if that frame is a reflow root, the next reflow won't just start from there and not set the new position. Updated incorrect comment about nsChangeHint_ReflowChangesSizeOrPosition always requiring nsChangeHint_ClearAncestorIntrinsics. Differential Revision: https://phabricator.services.mozilla.com/D9065

Bug 1505949 - layout/style/{BorrowedTypeList.h,ServoArcTypeList.h,ServoBoxedTypeList.h} content should remain on a single line r=heycam Make sure that clang-format doesn't touch it Differential Revision: https://phabricator.services.mozilla.com/D11387

Bug 1505565 - Split up push_applicable_declarations. r=heycam Introduce RuleCollector, which contains all the state we need during the cascade, and allows to reuse a bit of code. Differential Revision: https://phabricator.services.mozilla.com/D11233

Bug 1505816 - Cleanup text-align. r=heycam Use derive(FromPrimitive) instead. Differential Revision: https://phabricator.services.mozilla.com/D11332

Bug 1505213 - Allow ::slotted()::placeholder. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D11132

Bug 1505618 - Add Servo's rustfmt.toml to the servo/ directory. r=heycam

Bug 1504034 - followup post-review nit. r=heycam

Bug 1479173 - Add a static constexpr function returns an nsCSSPropertyIDSet being consist of CSS properties set can be run on the compositor. r=heycam,birtles Also add a script to generate the CSS properties set by looking at CanAnimateOnCompositor flag in servo's property definitions. Differential Revision: https://phabricator.services.mozilla.com/D10687

Bug 1479173 - Add a static constexpr function returns an nsCSSPropertyIDSet being consist of CSS properties set can be run on the compositor. r=heycam,birtles Also add a script to generate the CSS properties set by looking at CanAnimateOnCompositor flag in servo's property definitions. Differential Revision: https://phabricator.services.mozilla.com/D10687

Bug 1462233 - Implement the env() function with hardcoded zeros for safe-area-inset. r=heycam,firefox-style-system-reviewers Intent to Implement and Ship: https://groups.google.com/d/msg/mozilla.dev.platform/EVKyR1B87T0/_l-_qK8SAAAJ Differential Revision: https://phabricator.services.mozilla.com/D9609

Bug 1504536 - Simplify the SVG animation code. r=hiro,heycam It's overly generic for no good reason. Differential Revision: https://phabricator.services.mozilla.com/D10844

Bug 1502751 - Don't keep a separate list of ignored-when-colors-disabled longhands. r=heycam Most of the change is moving sets around to be static functions on LonghandIdSet. I think I like that pattern, but I can also make the new set a global static and add mako code to be `pub` or something. Though I think the LonghandIdSet::foo().contains(..) pattern is nice to read :) Differential Revision: https://phabricator.services.mozilla.com/D10653

Bug 1502893 - Don't match document author rules if not needed for revalidation. r=heycam,firefox-style-system-reviewers When you're in a ShadowRoot and can share style with a sibling, the sharing code is smart enough to skip document author rules. But then it could get confused if you also include document rules, since revalidation selectors are matched against these. This is not a correctness issue, because we're matching more than what we need, and avoid sharing if we failed. Also fix the detection for user rules in any_applicable_rule_data. Differential Revision: https://phabricator.services.mozilla.com/D10117

Bug 1502617 - Support ::before / ::after on ::slotted pseudos. r=heycam See https://github.com/w3c/csswg-drafts/issues/3150 for the issue that would expand this to all pseudos. Differential Revision: https://phabricator.services.mozilla.com/D9994

Bug 1502936 - Fix SVGUseElement::GetFrame to not get confused. r=heycam Should've noticed in bug 1502658 that GetFrame() was dead, to verify its assumptions... Oh well. Differential Revision: https://phabricator.services.mozilla.com/D10109

Bug 1502510: Provide missing image file for calc-background-position and calc-background-size reftests. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D9951