searching for reviewer(heycam)
66ff290649f7: Bug 1544170 Part 1 - Notify record/replay system about parsed style sheets, r=heycam.
Brian Hackett <bhackett1024@gmail.com> - Fri, 12 Apr 2019 16:33:00 -1000 - rev 470215
Push 112849 by bhackett@mozilla.com at Sat, 20 Apr 2019 02:36:08 +0000
Bug 1544170 Part 1 - Notify record/replay system about parsed style sheets, r=heycam. Differential Revision: https://phabricator.services.mozilla.com/D27408
2099599a5ad5: Bug 1544546 - Un-fill the styleset and drop the cascade data when removing a pres shell. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 19 Apr 2019 04:32:12 +0000 - rev 470171
Push 112843 by aiakab@mozilla.com at Fri, 19 Apr 2019 09:50:22 +0000
Bug 1544546 - Un-fill the styleset and drop the cascade data when removing a pres shell. r=heycam This should keep memory usage a bit more under control when loosing a pres shell. Differential Revision: https://phabricator.services.mozilla.com/D27571
a7b03452b97f: Bug 1544548 - Insert quirks.css later so that we hit the cascade data cache more often. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 15 Apr 2019 21:58:46 +0200 - rev 469692
Push 112816 by cbrindusan@mozilla.com at Wed, 17 Apr 2019 09:52:45 +0000
Bug 1544548 - Insert quirks.css later so that we hit the cascade data cache more often. r=heycam Bug 1535788 moved the quirks.css insertion earlier, so the order will not match when the commonish case where the document gets a shell and then knows the compat mode, which means that we hit the cascade data cache a bit less often. I'll also fix the order of the preference sheet vs. the quirks sheet in a followup, right now whatever gets first ends ups earlier on the list. Differential Revision: https://phabricator.services.mozilla.com/D27578
6ff81d173403: Bug 1542935 - Document::CompatibilityModeChanged should call EnsureStyleFlush. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 15 Apr 2019 05:27:37 +0000 - rev 469489
Push 112797 by ncsoregi@mozilla.com at Mon, 15 Apr 2019 15:29:43 +0000
Bug 1542935 - Document::CompatibilityModeChanged should call EnsureStyleFlush. r=heycam Following the reasoning from the previous commit. Selectors may become case sensitive or case insensitive as a result of this operation, something I forgot about when writing the patch for bug 1535788. Now Document::CompatibilityModeChanged is actually only called if the compatibility mode actually changes, and thus we always need to restyle. The Stylist already takes care of fully invalidating the document when it changes (via mark_origins_dirty and co.), so we technically just need to guarantee that a style flush will happen. In practice I doubt this call will have any effect in practice given how early in the document's lifetime the compatibility mode can change, but still I think it's worth landing. Depends on D27416 Differential Revision: https://phabricator.services.mozilla.com/D27417
3b45bccf61cf: Bug 1542935 - Re-introduce a call to EnsureStyleFlush from PresShell::Init to fix an Android scrolling regression. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 15 Apr 2019 05:26:27 +0000 - rev 469488
Push 112797 by ncsoregi@mozilla.com at Mon, 15 Apr 2019 15:29:43 +0000
Bug 1542935 - Re-introduce a call to EnsureStyleFlush from PresShell::Init to fix an Android scrolling regression. r=heycam Sorry for the vague commit message, but I haven't dug yet on why or how the Android code is depending on this. This call used to be part of nsPresContext::CompatibilityModeChanged, which unconditionally called PresShell::EnsureStyleFlush. This was not (in theory, at least) always necessary. There's there's no point in ensuring a style flush is going to happen if styles haven't changed, and CompatibilityModeChanged() didn't actually guarantee that the compat mode was different at all before my patch. Styles only change if the compat mode actually changes (since then selectors become case-sensitive or case-insensitive), or more obviously when you insert or remove the quirks.css stylesheet, and in that case ApplicableStylesChanged makes sure that the flush happens. Yet here we are, and not having that early call to EnsureStyleFlush, even in the case there's no quirks mode or quirks sheet change or anything of that sort (this happens even on XUL docs, which are always FullStandards) makes the first (and only the first) browsing session in Geckoview have terrible scrolling performance. I'm calling it a day for today, will investigate as time permits in bug 1544185. Differential Revision: https://phabricator.services.mozilla.com/D27416
587b7bc9ad81: Bug 1543304 - Add MOZ_DBG support for nsCSSPropertyID and nsCSSPropertyIDSet; r=heycam
Brian Birtles <birtles@gmail.com> - Sun, 14 Apr 2019 23:48:05 +0000 - rev 469446
Push 112792 by ncsoregi@mozilla.com at Mon, 15 Apr 2019 09:49:11 +0000
Bug 1543304 - Add MOZ_DBG support for nsCSSPropertyID and nsCSSPropertyIDSet; r=heycam Differential Revision: https://phabricator.services.mozilla.com/D26856
fa9332a8ea93: Bug 1543304 - Add iterators to nsCSSPropertyIDSet; r=heycam
Brian Birtles <birtles@gmail.com> - Sun, 14 Apr 2019 23:47:51 +0000 - rev 469445
Push 112792 by ncsoregi@mozilla.com at Mon, 15 Apr 2019 09:49:11 +0000
Bug 1543304 - Add iterators to nsCSSPropertyIDSet; r=heycam Differential Revision: https://phabricator.services.mozilla.com/D26855
8a857aaa693a: Bug 1543501 - Make MOZ_DBG() work on Android. r=heycam
Botond Ballo <botond@mozilla.com> - Fri, 12 Apr 2019 16:48:51 +0000 - rev 469312
Push 112780 by btara@mozilla.com at Fri, 12 Apr 2019 22:09:00 +0000
Bug 1543501 - Make MOZ_DBG() work on Android. r=heycam stderr does not go anywhere by default on Android. Debugging output is conventionally sent to the Android log via special functions like __android_log_print. We already have logic for handling this in nsCRTGlue's printf_stderr, but I don't think we can use that in MFBT. Differential Revision: https://phabricator.services.mozilla.com/D26985
daaf43ea3783: Bug 1543501 - Print a 'token' that allows output from MOZ_DBG() to be easily grepped for among other output. r=heycam
Botond Ballo <botond@mozilla.com> - Fri, 12 Apr 2019 16:49:56 +0000 - rev 469311
Push 112780 by btara@mozilla.com at Fri, 12 Apr 2019 22:09:00 +0000
Bug 1543501 - Print a 'token' that allows output from MOZ_DBG() to be easily grepped for among other output. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D26984
56e1556e963d: Bug 1543841 - Remove newlines for the #content and #test nodes in `./mach addtest` templates r=heycam
Brian Grinstead <bgrinstead@mozilla.com> - Fri, 12 Apr 2019 05:04:50 +0000 - rev 469291
Push 112780 by btara@mozilla.com at Fri, 12 Apr 2019 22:09:00 +0000
Bug 1543841 - Remove newlines for the #content and #test nodes in `./mach addtest` templates r=heycam Differential Revision: https://phabricator.services.mozilla.com/D27188
e3828f221fd4: Bug 1543841 - Update `./mach addtest` templates to stop using [type] attribute on stylesheets r=heycam
Brian Grinstead <bgrinstead@mozilla.com> - Fri, 12 Apr 2019 05:04:14 +0000 - rev 469290
Push 112780 by btara@mozilla.com at Fri, 12 Apr 2019 22:09:00 +0000
Bug 1543841 - Update `./mach addtest` templates to stop using [type] attribute on stylesheets r=heycam Differential Revision: https://phabricator.services.mozilla.com/D27181
0fd4c1a6ade5: Bug 1543762 - Flush less in cross-document getComputedStyle situations. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 12 Apr 2019 10:04:33 +0000 - rev 469252
Push 112776 by shindli@mozilla.com at Fri, 12 Apr 2019 16:20:17 +0000
Bug 1543762 - Flush less in cross-document getComputedStyle situations. r=heycam I wrote this while looking at bug 1537903, but actually it doesn't help there, since all the extra time is spent actually computing styles. I think this is still worth landing it though. The reasoning for not caring of this case is that we mint an style anyway out of the blue anyway. There's no point in restyling the whole document. Differential Revision: https://phabricator.services.mozilla.com/D27124
11fb8048959d: Bug 1543398 - Don't pass unknown descriptors to Servo. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 12 Apr 2019 05:08:18 +0000 - rev 469251
Push 112776 by shindli@mozilla.com at Fri, 12 Apr 2019 16:20:17 +0000
Bug 1543398 - Don't pass unknown descriptors to Servo. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D26914
3a101d5a14bb: Bug 1542178 - Serialize more non-problematic properties with Servo. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 10 Apr 2019 12:11:04 +0000 - rev 468801
Push 112755 by dvarga@mozilla.com at Wed, 10 Apr 2019 22:06:41 +0000
Bug 1542178 - Serialize more non-problematic properties with Servo. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D26786
5ce09292f6bf: Bug 1542178 - Fix ToResolvedValue implementation for caret-color, and serialize some color properties with Servo. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 10 Apr 2019 12:10:49 +0000 - rev 468800
Push 112755 by dvarga@mozilla.com at Wed, 10 Apr 2019 22:06:41 +0000
Bug 1542178 - Fix ToResolvedValue implementation for caret-color, and serialize some color properties with Servo. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D26785
11dcdb94e2fa: Bug 1542178 - Use ToResolvedValue for computed style serialization. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 10 Apr 2019 12:10:40 +0000 - rev 468799
Push 112755 by dvarga@mozilla.com at Wed, 10 Apr 2019 22:06:41 +0000
Bug 1542178 - Use ToResolvedValue for computed style serialization. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D26784
79752758fc82: Bug 1542178 - Derive ToResolvedValue. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 10 Apr 2019 12:10:26 +0000 - rev 468798
Push 112755 by dvarga@mozilla.com at Wed, 10 Apr 2019 22:06:41 +0000
Bug 1542178 - Derive ToResolvedValue. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D26783
b8e84c48c672: Bug 1542178 - Add derive code for a new ToResolvedValue trait, and a few trivial implementations. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 10 Apr 2019 12:10:11 +0000 - rev 468797
Push 112755 by dvarga@mozilla.com at Wed, 10 Apr 2019 22:06:41 +0000
Bug 1542178 - Add derive code for a new ToResolvedValue trait, and a few trivial implementations. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D26782
7fbaca51f682: Bug 1542178 - Serialize more non-problematic properties with Servo. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 10 Apr 2019 12:11:04 +0000 - rev 468780
Push 112755 by dvarga@mozilla.com at Wed, 10 Apr 2019 22:06:41 +0000
Bug 1542178 - Serialize more non-problematic properties with Servo. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D26786
e5a602010961: Bug 1542178 - Fix ToResolvedValue implementation for caret-color, and serialize some color properties with Servo. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 10 Apr 2019 12:10:49 +0000 - rev 468779
Push 112755 by dvarga@mozilla.com at Wed, 10 Apr 2019 22:06:41 +0000
Bug 1542178 - Fix ToResolvedValue implementation for caret-color, and serialize some color properties with Servo. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D26785
152985a87c01: Bug 1542178 - Use ToResolvedValue for computed style serialization. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 10 Apr 2019 12:10:40 +0000 - rev 468778
Push 112755 by dvarga@mozilla.com at Wed, 10 Apr 2019 22:06:41 +0000
Bug 1542178 - Use ToResolvedValue for computed style serialization. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D26784
7da7a8bc596a: Bug 1542178 - Derive ToResolvedValue. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 10 Apr 2019 12:10:26 +0000 - rev 468777
Push 112755 by dvarga@mozilla.com at Wed, 10 Apr 2019 22:06:41 +0000
Bug 1542178 - Derive ToResolvedValue. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D26783
0a7766ece186: Bug 1542178 - Add derive code for a new ToResolvedValue trait, and a few trivial implementations. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 10 Apr 2019 12:10:11 +0000 - rev 468776
Push 112755 by dvarga@mozilla.com at Wed, 10 Apr 2019 22:06:41 +0000
Bug 1542178 - Add derive code for a new ToResolvedValue trait, and a few trivial implementations. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D26782
07a87bbee9ca: Bug 1540220 - Cleanup a bit the lazy style resolution APIs. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 09 Apr 2019 18:05:04 +0000 - rev 468626
Push 112738 by nbeleuzu@mozilla.com at Tue, 09 Apr 2019 22:28:41 +0000
Bug 1540220 - Cleanup a bit the lazy style resolution APIs. r=heycam There are some that only have one caller, and some slightly confusing naming. Hopefully make it a bit clearer. Differential Revision: https://phabricator.services.mozilla.com/D25457
dfef5e9b459d: Bug 1542179 - Handle the non-generic path earlier in the derive code. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 09 Apr 2019 01:48:18 +0000 - rev 468547
Push 112733 by csabou@mozilla.com at Tue, 09 Apr 2019 16:30:22 +0000
Bug 1542179 - Handle the non-generic path earlier in the derive code. r=heycam No need to build the match body if there are no generics. This should hopefully save some work too. Depends on D26289 Differential Revision: https://phabricator.services.mozilla.com/D26290
7f7030e4c60d: Bug 1542179 - Share more code between ToAnimatedValue and ToComputedValue derive. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 09 Apr 2019 09:37:26 +0000 - rev 468546
Push 112733 by csabou@mozilla.com at Tue, 09 Apr 2019 16:30:22 +0000
Bug 1542179 - Share more code between ToAnimatedValue and ToComputedValue derive. r=heycam I'm going to add a ToResolvedValue, and I don't want to add more copy-pasta. This shouldn't change behavior. Differential Revision: https://phabricator.services.mozilla.com/D26289
05cee7dc3b5c: Bug 1542762 - Use an explicit stack to measure rule tree memory usage. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 09 Apr 2019 00:11:03 +0000 - rev 468475
Push 112724 by nerli@mozilla.com at Tue, 09 Apr 2019 10:03:26 +0000
Bug 1542762 - Use an explicit stack to measure rule tree memory usage. r=heycam A patch of mine that makes us measure the rule tree more often triggers this. Differential Revision: https://phabricator.services.mozilla.com/D26595
334b4e0ab3f5: Bug 1541952 - Move ApplicableStylesChanged() to Document. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 06 Apr 2019 19:25:25 +0000 - rev 468336
Push 112710 by dvarga@mozilla.com at Mon, 08 Apr 2019 16:30:07 +0000
Bug 1541952 - Move ApplicableStylesChanged() to Document. r=heycam It's the right place for it to be now that it owns the StyleSet. Differential Revision: https://phabricator.services.mozilla.com/D26213
08f256aa338a: Bug 760345 - Make color and text-decoration-line not early properties. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 04 Apr 2019 23:04:50 +0000 - rev 468295
Push 112700 by cbrindusan@mozilla.com at Sun, 07 Apr 2019 09:40:07 +0000
Bug 760345 - Make color and text-decoration-line not early properties. r=heycam The text-decoration-line is a drive-by thing, but I can put it in a separate patch if you want. It was needed for Servo (to compute -servo-text-decorations-in-effect), but I moved Servo away from that model a while ago. Differential Revision: https://phabricator.services.mozilla.com/D26254
0550767ec778: Bug 760345 - Remove the last usage of lossy currentcolor. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 06 Apr 2019 17:47:58 +0000 - rev 468294
Push 112700 by cbrindusan@mozilla.com at Sun, 07 Apr 2019 09:40:07 +0000
Bug 760345 - Remove the last usage of lossy currentcolor. r=heycam We don't have lossy currentcolor in the style system anymore, except for a single property -moz-font-smoothing-background-color. I could've converted it into a proper StyleColor and thread down all the necessary information to the font metrics code. But it doesn't really seem worth it given it's not exposed to the web, so I just did the simplest thing, which is making currentcolor compute to transparent to that specific property. This patch also removes the stores_complex_colors_lossily code and related, since now we always can cache computed colors. Differential Revision: https://phabricator.services.mozilla.com/D26187
1ea4b3582033: Bug 760345 - Remove the last usage of lossy currentcolor. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 04 Apr 2019 22:06:03 +0000 - rev 468101
Push 112682 by btara@mozilla.com at Fri, 05 Apr 2019 09:57:50 +0000
Bug 760345 - Remove the last usage of lossy currentcolor. r=heycam We don't have lossy currentcolor in the style system anymore, except for a single property -moz-font-smoothing-background-color. I could've converted it into a proper StyleColor and thread down all the necessary information to the font metrics code. But it doesn't really seem worth it given it's not exposed to the web, so I just did the simplest thing, which is making currentcolor compute to transparent to that specific property. This patch also removes the stores_complex_colors_lossily code and related, since now we always can cache computed colors. Differential Revision: https://phabricator.services.mozilla.com/D26187
1b9a86e36a4c: Bug 1541925 - Avoid accounting for @font-face rules the style set when there's no pres shell. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 04 Apr 2019 21:40:55 +0000 - rev 468084
Push 112682 by btara@mozilla.com at Fri, 05 Apr 2019 09:57:50 +0000
Bug 1541925 - Avoid accounting for @font-face rules the style set when there's no pres shell. r=heycam This preserves the behavior of not having FontFace objects for @font-face rules in display: none iframes. Note, however that we may want to always track stylesheets to both not have this limitation and to fix bug 1471231 & co. But that's a separate bug in any case. The assertion that is failing ultimately in this bug is not really relevant anymore, so remove it while at it. Differential Revision: https://phabricator.services.mozilla.com/D26196
4fedc80c2609: Bug 1541546 - Use only the new name for StyleColor. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 04 Apr 2019 11:35:33 +0000 - rev 468000
Push 112673 by ccoroiu@mozilla.com at Thu, 04 Apr 2019 22:20:03 +0000
Bug 1541546 - Use only the new name for StyleColor. r=heycam That is, change all uses of StyleComplexColor to just StyleColor. Differential Revision: https://phabricator.services.mozilla.com/D25977
bab32ba95bcc: Bug 1541546 - Use the rust color representation. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 04 Apr 2019 11:35:16 +0000 - rev 467999
Push 112673 by ccoroiu@mozilla.com at Thu, 04 Apr 2019 22:20:03 +0000
Bug 1541546 - Use the rust color representation. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D25976
51298369fb0b: Bug 1541546 - Expose colors via cbindgen. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 04 Apr 2019 11:34:56 +0000 - rev 467998
Push 112673 by ccoroiu@mozilla.com at Thu, 04 Apr 2019 22:20:03 +0000
Bug 1541546 - Expose colors via cbindgen. r=heycam Also s/Foreground/CurrentColor. Differential Revision: https://phabricator.services.mozilla.com/D25975
895863144707: Bug 1541546 - Use only the new name for StyleColor. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 04 Apr 2019 11:35:33 +0000 - rev 467975
Push 112667 by aiakab@mozilla.com at Thu, 04 Apr 2019 16:12:45 +0000
Bug 1541546 - Use only the new name for StyleColor. r=heycam That is, change all uses of StyleComplexColor to just StyleColor. Differential Revision: https://phabricator.services.mozilla.com/D25977
4da6fb98e8f9: Bug 1541546 - Use the rust color representation. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 04 Apr 2019 11:35:16 +0000 - rev 467974
Push 112667 by aiakab@mozilla.com at Thu, 04 Apr 2019 16:12:45 +0000
Bug 1541546 - Use the rust color representation. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D25976
ba71816514eb: Bug 1541546 - Expose colors via cbindgen. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 04 Apr 2019 11:34:56 +0000 - rev 467973
Push 112667 by aiakab@mozilla.com at Thu, 04 Apr 2019 16:12:45 +0000
Bug 1541546 - Expose colors via cbindgen. r=heycam Also s/Foreground/CurrentColor. Differential Revision: https://phabricator.services.mozilla.com/D25975
f98617ff7cf5: Bug 1490401 - MatchMedia should work inside display: none iframes. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 04 Apr 2019 11:25:31 +0000 - rev 467972
Push 112667 by aiakab@mozilla.com at Thu, 04 Apr 2019 16:12:45 +0000
Bug 1490401 - MatchMedia should work inside display: none iframes. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D25926
3fcf01363983: Bug 1541126 - Invalidate ShadowRoot style data when the document's compat mode changes. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 03 Apr 2019 23:52:19 +0000 - rev 467941
Push 112667 by aiakab@mozilla.com at Thu, 04 Apr 2019 16:12:45 +0000
Bug 1541126 - Invalidate ShadowRoot style data when the document's compat mode changes. r=heycam This testcase triggers a case which I hoped I wouldn't need to handle: The presence of a shadow root in the tree already by the time our compatibility mode changes. Just invalidate ShadowRoot data when this happens the same way we invalidate the document style data. Differential Revision: https://phabricator.services.mozilla.com/D25928
625e9335159c: Bug 1540385 - Fix revalidation in <svg:use> subtree. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 04 Apr 2019 03:46:55 +0000 - rev 467940
Push 112667 by aiakab@mozilla.com at Thu, 04 Apr 2019 16:12:45 +0000
Bug 1540385 - Fix revalidation in <svg:use> subtree. r=heycam So as to avoid incorrectly sharing styles across elements. Differential Revision: https://phabricator.services.mozilla.com/D25918
f7f603959f6c: Bug 1529182 - Include stroke in SVG <text> bounding box. r=longsonr,heycam
Alex Henrie <alexhenrie24@gmail.com> - Thu, 04 Apr 2019 06:38:40 +0000 - rev 467927
Push 112667 by aiakab@mozilla.com at Thu, 04 Apr 2019 16:12:45 +0000
Bug 1529182 - Include stroke in SVG <text> bounding box. r=longsonr,heycam I think I found another mistake in the SVG text code that could explain the regression: If the text is drawn with a stroke, shouldn't the stroke be included in the bounding box? Differential Revision: https://phabricator.services.mozilla.com/D26074
60c20a0f320c: Bug 1535788 - Make the Document own the StyleSet. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 03 Apr 2019 07:02:00 +0000 - rev 467757
Push 112658 by aciure@mozilla.com at Thu, 04 Apr 2019 04:41:45 +0000
Bug 1535788 - Make the Document own the StyleSet. r=heycam This is the last step to be able to call matchMedia on display: none iframes. This is green, except for some startup preference query tests that I'm going to address in a blocking bug (making LangGroupFontPrefs global, basically). The setup is similar to the ShadowRoot one, except we don't eagerly keep the StyleSet around up-to-date, we only fill it if it ever had a pres context. Differential Revision: https://phabricator.services.mozilla.com/D23903
bc2d8bd355ab: Bug 1370646 - Honor the maxTextRunSize if it's within reasonable range r=heycam
violet <violet.bugreport@gmail.com> - Wed, 03 Apr 2019 01:00:38 +0000 - rev 467739
Push 112658 by aciure@mozilla.com at Thu, 04 Apr 2019 04:41:45 +0000
Bug 1370646 - Honor the maxTextRunSize if it's within reasonable range r=heycam If the maximal and minimal font-size in a SVGTextFrame have a huge difference, previously we chose mFontSizeScaleFactor to satisfy the minimal one. That's problematic, because the maximal one might be a reasonable size, while the minimal one is extremely small. We should honor the maximal one if this is the case. Differential Revision: https://phabricator.services.mozilla.com/D24494
15e33e8c7fcc: Bug 1540074 - Make sure to unstyle XBL children before removing the old XBL binding. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 02 Apr 2019 18:50:29 +0200 - rev 467702
Push 112657 by emilio@crisal.io at Thu, 04 Apr 2019 00:29:54 +0000
Bug 1540074 - Make sure to unstyle XBL children before removing the old XBL binding. r=heycam This bug is happening because we resolve the child of the content generating the first-line frame inheriting from the XBL marquee's anonymous content (which isn't affected by the all:inherit rule and thus is non-floating). Then we go through frame construction, and remove the <marquee> binding, which makes the anonymous content go away, but don't restyle the children again. The correct first-letter style without the binding is floating, but we don't realize while constructing the frame tree. We do realize of that afterwards though, when reparenting the styles, and inherit from the right thing, and thus get the right floating style. But there's nothing saving us now, since the first-letter frame is in-flow already. The fix is clearing the style of children before removing the binding, the same way we do before adding it. FlushStyleBindings removes the current XBL binding. That shuffles the flattened tree. We need to ensure the styles are gone on children before that to avoid getting into a bad state. AutoStyleElement already does that, just slightly too late if there's a pre-existing binding, so moving it up a bit does the trick.
005d447749ec: Bug 1370646 - Honor the maxTextRunSize if it's within reasonable range r=heycam
violet <violet.bugreport@gmail.com> - Fri, 29 Mar 2019 07:01:10 +0000 - rev 466733
Push 112600 by opoprus@mozilla.com at Fri, 29 Mar 2019 22:13:12 +0000
Bug 1370646 - Honor the maxTextRunSize if it's within reasonable range r=heycam If the maximal and minimal font-size in a SVGTextFrame have a huge difference, previously we chose mFontSizeScaleFactor to satisfy the minimal one. That's problematic, because the maximal one might be a reasonable size, while the minimal one is extremely small. We should honor the maximal one if this is the case. Differential Revision: https://phabricator.services.mozilla.com/D24494
4eb705fd67f6: Bug 1141387 - Set image.animation_mode=none to avoid the animated GIF is advanced to the next frame. r=heycam
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Fri, 29 Mar 2019 05:58:25 +0000 - rev 466730
Push 112600 by opoprus@mozilla.com at Fri, 29 Mar 2019 22:13:12 +0000
Bug 1141387 - Set image.animation_mode=none to avoid the animated GIF is advanced to the next frame. r=heycam The animated GIF in background-blending-image-color-gif.html has two animation frames, the one is a red rectangle, the other is a green rectangle. The reftest is supposed to take the snapshot during the time where the animation frame is the red rectangle (the first frame) and the frame duration is 1000ms. So if we take over 1000ms there for some reasons, say on slow platforms, before taking the snapshot, the reftet fails. Differential Revision: https://phabricator.services.mozilla.com/D24843
208cf2d82f55: Bug 1535612 - CSSKeyframeList::RemoveRule should clear parent references when removed. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 20 Mar 2019 09:50:51 +0000 - rev 465813
Push 112523 by shindli@mozilla.com at Sat, 23 Mar 2019 09:54:29 +0000
Bug 1535612 - CSSKeyframeList::RemoveRule should clear parent references when removed. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D23729
e02bd4f99157: Bug 1536586 - Simplify a bit our generated bindings by getting rid of FooBorrowed and FooBorrowedMut. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 21 Mar 2019 17:00:27 +0000 - rev 465497
Push 112510 by apavel@mozilla.com at Fri, 22 Mar 2019 10:06:40 +0000
Bug 1536586 - Simplify a bit our generated bindings by getting rid of FooBorrowed and FooBorrowedMut. r=heycam This reduces a lot the boilerplate that's needed in order to add simple binding functions. This starts using &Foo and Option<&Foo> instead, and as a result we need to remove the servo_function_signatures test, which is a bit unfortunate. I think it's worth though, this causes problems on some platforms (see bug 1534844), and messing up the functions signature is not something that I've ever seen (other than bug 1308234, which already had all the FooBorrowed mess which I'm removing). Also, cbindgen understands references and Option<&Foo>, so it will be the way to go in the future. After this patch we can also remove HasSimpleFFI, but I've kept it for now since I still use it in a few places, and this patch is quite big on its own. Differential Revision: https://phabricator.services.mozilla.com/D24092
a2ff272ceb42: Bug 1535384 part 10. Remove MOZ_CAN_RUN_SCRIPT_BOUNDARY for FontFaceSetForEachCallback. r=heycam
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 19 Mar 2019 04:36:18 +0000 - rev 465352
Push 112500 by ncsoregi@mozilla.com at Thu, 21 Mar 2019 10:53:17 +0000
Bug 1535384 part 10. Remove MOZ_CAN_RUN_SCRIPT_BOUNDARY for FontFaceSetForEachCallback. r=heycam This code should all go away (bug 1311198), but in the meantime... Differential Revision: https://phabricator.services.mozilla.com/D23781