Bug 1587468 - Update failure_derive and malloc_size_of_derive. r=heycam This removes an old version of synstructure. Differential Revision: https://phabricator.services.mozilla.com/D53364

Bug 1596712 - Use only Origin during the cascade, rather than CascadeLevel. r=heycam The micro-benchmark `style-attr-1.html` regressed slightly with my patch, after the CascadeLevel size increase. This benchmark is meant to test for the "changing the style attribute doesn't cause selector-matching" optimization (which, mind you, keeps working). But in the process it creates 10k rules which form a perfect path in the rule tree and that we put into a SmallVec during the cascade, and the benchmark spends most of the time pushing to that SmallVec and iterating the declarations (as there's only one property to apply). So we could argue that the regression is minor and is not what the benchark is supposed to be testing, but given I did the digging... :) My patch made CascadeLevel bigger, which means that we create a somewhat bigger vector in this case. Thankfully it also removed the dependency in the CascadeLevel, so we can stop using that and use just Origin which is one byte to revert the perf regression. Differential Revision: https://phabricator.services.mozilla.com/D53181

Bug 1596642 - Use `rev` instead of both `branch` and `tag` for specifying rkv dependency version, r=heycam Differential Revision: https://phabricator.services.mozilla.com/D53152

Bug 1487212 - When hyphenation resources are compressed in omnijar, load them into shared memory and share among all content processes. r=heycam,froydnj Differential Revision: https://phabricator.services.mozilla.com/D52835

Bug 1590167 - Add Rust implementation of hyphenation (mapped_hyph) and hook up in place of libhyphen. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D49967

Bug 1588431 - Optimize storage of ApplicableDeclaration again. r=heycam So that we don't regress perf. Differential Revision: https://phabricator.services.mozilla.com/D52576

Bug 1588431 - Fix cascade order of shadow parts. r=heycam This moves the shadow cascade order into the cascade level, and refactors the code a bit for that. Differential Revision: https://phabricator.services.mozilla.com/D49988

Bug 1588431 - Split collect_style_attribute_and_animation_rules. r=heycam Animations are their own cascade level per https://drafts.csswg.org/css-cascade-4/#cascade-origin Differential Revision: https://phabricator.services.mozilla.com/D52575

Bug 1590167 - Add Rust implementation of hyphenation (mapped_hyph) and hook up in place of libhyphen. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D49967

Bug 1594995 - Part 1: Update neqo dependencies to specify a rev instead of a version, and run `./mach vendor rust` on a clean central tip, r=heycam Differential Revision: https://phabricator.services.mozilla.com/D52316

Bug 1590167 - Add Rust implementation of hyphenation (mapped_hyph) and hook up in place of libhyphen. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D49967

Bug 1594949 - Fix assertion of gfx::Path when changing offset-path on some svg frames. r=heycam 1. Use Nothing() for motion path in IncrementScaleResytleCountIfNeeded. Since motion path only produces 2d translate and 2d rotate, so it shouldn't have any impact on BaseMatrix::ScaleFactors(). We use Nothing() to avoid any redundant calculation. 2. Drop SVGTextFrame::DidSetComputedStyle() because nsFrame::DidSetComputedStyle() should have handled ScheduleReflowSVGNonDisplayText well. 3. Let nsSVGForeignObjectFrame::DidSetComputedStyle() call their parents' DidSetComputedStyle. This makes sure we update the frame properly. Differential Revision: https://phabricator.services.mozilla.com/D52290

Bug 1590167 - Add Rust implementation of hyphenation (mapped_hyph) and hook up in place of libhyphen. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D49967

Bug 1590167 - Add Rust implementation of hyphenation (mapped_hyph) and hook up in place of libhyphen. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D49967

Bug 1593865 - Leak shared memory for the lifetime of the process. r=heycam Seems less gnarly than the alternatives, and we'd only free it until shutdown so not much worse, actually. Differential Revision: https://phabricator.services.mozilla.com/D51871

Bug 1484780 - Cache gfx::Path to avoid building and flattening path at each restyle cycle. r=heycam In most cases, we run an animation on an object by changing its offset-distance/offset-rotate, but keep its offset-path the same. Building and flattening the path is sometime expensive, especially for large path, so caching it makes sense to us and have a significant performance improvement. This is for the main thread motion path animations. Note: Even though we support compositor animations for motion path, nsIFrame::GetTransformMatrix() is still called during the animations for other usages, so we may still build the gfx::Path on the main thread without this patch, so this improvement becomes necessary for most cases. Differential Revision: https://phabricator.services.mozilla.com/D46667

Bug 1593865 - Leak shared memory for the lifetime of the process. r=heycam Seems less gnarly than the alternatives, and we'd only free it until shutdown so not much worse, actually. Differential Revision: https://phabricator.services.mozilla.com/D51871

Bug 1593009 - Make zoom: 0 mean the same as zoom: 1. r=heycam This matches the WebKit implementation, and is clearly a violation of the rules we generally use for ranges in CSS. But it seems to be depended-on legacy behavior, see the linked WebKit bug, this bug, and bug 1593317. Differential Revision: https://phabricator.services.mozilla.com/D51539

Bug 1581637 - Part 7 - Add new vendored crates required by neqo and neqo_glue. r=heycam this is automatically generated by 'mach vendor rust'. Differential Revision: https://phabricator.services.mozilla.com/D47227

Bug 1581637 - Part 6 - Add neqo-necko API. r=mayhemer,heycam Differential Revision: https://phabricator.services.mozilla.com/D47226

Bug 1587385 - Give a better info (not error) message if a webfont is not used because of font-display timeout. r=heycam This is not an error in the same way as a download failure, and should not be reported as one. An Info message is sufficient. Also suppress "unknown" location in messages about @font-face rules, as it is not useful, pending a proper fix (bug 1450903). Differential Revision: https://phabricator.services.mozilla.com/D50346

Bug 1578319: Telemetry for total time spent in layout per Refresh Driver tick. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D44427

Bug 1581637 - Part 7 - Add new vendored crates required by neqo and neqo_glue. r=heycam this is automatically generated by 'mach vendor rust'. Differential Revision: https://phabricator.services.mozilla.com/D47227

Bug 1581637 - Part 6 - Add neqo-necko API. r=mayhemer,heycam Differential Revision: https://phabricator.services.mozilla.com/D47226

Bug 1590185 Part 3 - Add --paged command line argument to layout debugger. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D49994

Bug 1590185 Part 1 - Remove obsolete member variables in nsLayoutDebuggingTools. r=heycam Bug 1566215 Part 3 moved these features to layoutdebug.js. https://hg.mozilla.org/mozilla-central/rev/f84c119572a1f4d8b20ac05c0bd8cefe4fe70fef Differential Revision: https://phabricator.services.mozilla.com/D49992

Bug 1590191 - Trigger image loads for <area> cursor styles. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D49998

Bug 1513282 - Don't crash in some first-line + display: contents edge cases. r=heycam ... where we've lost track of the display: contents style already since the ancestor has become display: none, but the first-line belongs to a higher ancestor that hasn't. Pretty nasty. Differential Revision: https://phabricator.services.mozilla.com/D48368

Bug 1585882 - Fix the case where where a node with an up-to-date style loses its frame due to a DOM mutation of siblings. r=heycam This fixes another edge-case that I thought of while debugging this, I think this makes our behavior correct now. The comment and test-case should be self-descriptive. Differential Revision: https://phabricator.services.mozilla.com/D48135

Bug 1585882 - Fix needs_frame() check to account for the case where an ancestor of us has been reconstructed regularly, not via lazy frame construction. r=heycam This is a pre-existing bug, and this would be enough to fix the website, but this is still not 100% correct. More on that in a second. Differential Revision: https://phabricator.services.mozilla.com/D48134

Bug 1585217 - Make the layout debugger with -autoclose handle content process crashes. r=heycam This means that you can use it as a very light-weight crashtest harness by using: MOZ_GDB_SLEEP=0 ./mach run -layoutdebug <file> -autoclose Right now we just never exit otherwise. Differential Revision: https://phabricator.services.mozilla.com/D47715

Bug 1585217 - Make the layout debugger with -autoclose handle content process crashes. r=heycam This means that you can use it as a very light-weight crashtest harness by using: MOZ_GDB_SLEEP=0 ./mach run -layoutdebug <file> -autoclose Right now we just never exit otherwise. Differential Revision: https://phabricator.services.mozilla.com/D47715

Bug 1585217 - Make the layout debugger with -autoclose handle content process crashes. r=heycam This means that you can use it as a very light-weight crashtest harness by using: MOZ_GDB_SLEEP=0 ./mach run -layoutdebug <file> -autoclose Right now we just never exit otherwise. Differential Revision: https://phabricator.services.mozilla.com/D47715

Bug 1582119 - Enable CSS use counters in use counter test. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D46557

Bug 1578151 - Factor out the "containing block did not really change" code from CalcStyleDifference. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D44351

Bug 1582627 - Always serialize aspect-ratio and font shorthand with spaces around the slash. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D46568

Bug 1581607: Add 'mozilla-beta' branch to talos-perf-reftest's defaults. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D46056

Bug 1581204 - Remove unused DTDs from layout. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D45901

Bug 1549273: Green up talos-perf-reftest-singletons on windows10-aarch64; add mozilla-beta branch to defaults. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D45877

Bug 1580307 - Avoid justify-items from the cached scrollbar assertions. r=heycam justify-items' initial value is `legacy` and the computed value depends on the parent's value. We don't use flex / grid in the scrollbars, so just avoid asserting about this property. Differential Revision: https://phabricator.services.mozilla.com/D45673

Bug 1580015 - part2 : add test 'test_webvtt_infinite_processing_loop.html'. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D45567

Bug 1580015 - part1 : do not reentry function 'processCues()'. r=heycam Accessing `offsetXXX` attributes of element, it would trigger reflow, and sometime it would result in a re-entry of `processCue()` because we would call `processCue()` when `resizecaption` occurs. One specifical case is that, assigning CSS properties `min-width` and `max-width` at the same video element, in thise case, when we re-enter the `processCues()` and access `offsetXXX`. It seems that the layout system would reprocess those properites again and again and dispatch `resizecaption` when we access `offsetXXX`, which causes an infinite loop, starting from receving `resizecaption`, then calling `processCue()`, accessing `offSetXXX`, triggering reflow, sending `resizecaption` event again. Therefore, we should stop revisiting `processCues()` if we're already running a processing, we should run a processing once at a time. Differential Revision: https://phabricator.services.mozilla.com/D45421

Bug 1577139 - Remove LengthPercentage::was_calc. r=heycam There should not be any behavior change between specifying a percentage using % or calc(%) per the resolution of https://github.com/w3c/csswg-drafts/issues/3482. Differential Revision: https://phabricator.services.mozilla.com/D43747

Bug 1543639 - Fix svg-glyph-extents reftest timeouts when running on Fennec with webcompat extension installed. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D45028

Bug 1574718 - followup: Also actually unlink it. r=heycam MANUAL PUSH: Minor post-landing follow-up.

Bug 1574718 - Cycle-collect inline-sheet cache. r=heycam This is an oversight from the initial implementation of the cache. Differential Revision: https://phabricator.services.mozilla.com/D43975

Bug 1577743 - Remove dead argument from nsStyledElement::ReparseStyleAttribute. r=heycam And remove the NodeInfoChanged override that used to call it. This is dead since we removed the old style system. Was used to force a reparse on cross-style-back-end adoption. Differential Revision: https://phabricator.services.mozilla.com/D44134

Bug 1576553 - Add reftest. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D43411

Bug 1576553 - Partial ligatures need to be drawn if either GLYPH_FILL or GLYPH_STROKE is in effect. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D43409

Bug 1576553 - Add reftest. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D43411