searching for reviewer(glandium)
f01d761796534e46b655e27a634d65ffa5934be9: Bug 1564097 - Set HOST_LINKER when host OS is Windows too. r=glandium
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Wed, 13 Nov 2019 11:48:25 +0000 - rev 501903
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1564097 - Set HOST_LINKER when host OS is Windows too. r=glandium When running Cargo on Windows, `HOST_LINKER` is required by `cargo-host-linker.bat`. So we should use windows.configure to set HOST_LINKER when host OS is Windows and target OS isn't Windows. Differential Revision: https://phabricator.services.mozilla.com/D37241
d65ec56af99764c4370edc565668ce1ec638ee01: Bug 1539133 - Explicitly say not being able to mmap is likely OOM. r=decoder,glandium
Gian-Carlo Pascutto <gcp@mozilla.com> - Tue, 12 Nov 2019 00:04:46 +0000 - rev 501754
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1539133 - Explicitly say not being able to mmap is likely OOM. r=decoder,glandium Differential Revision: https://phabricator.services.mozilla.com/D43929
17ccc480d16a4cc7bd6ca9deb7929984c824657a: Bug 1582192 - add a job to build a wasi sysroot; r=glandium
Nathan Froyd <froydnj@mozilla.com> - Tue, 12 Nov 2019 00:10:38 +0000 - rev 501592
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1582192 - add a job to build a wasi sysroot; r=glandium When we start compiling things to wasm during the build process, we're going to need a basic sysroot. This new job builds just such a sysroot. Differential Revision: https://phabricator.services.mozilla.com/D50993
d3c959c0b75a1fc446a8809d78d82ae4eacdb55b: Bug 1593502 - Build system does not add -isysroot to the command-line flags for compiler invocations when the provided_compiler has additional flags r=glandium
Ricky Stewart <rstewart@mozilla.com> - Tue, 12 Nov 2019 00:28:17 +0000 - rev 501584
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1593502 - Build system does not add -isysroot to the command-line flags for compiler invocations when the provided_compiler has additional flags r=glandium Differential Revision: https://phabricator.services.mozilla.com/D52414
d3885b9d42d38e9685e2f430d99200ec7b719a2c: Bug 1587116 - only include sys/auxv.h on platforms where it might exist r=glandium
Landry Breuil <landry@openbsd.org> - Tue, 12 Nov 2019 07:10:12 +0000 - rev 501548
Push 114170 by malexandru@mozilla.com at Tue, 12 Nov 2019 21:58:32 +0000
Bug 1587116 - only include sys/auxv.h on platforms where it might exist r=glandium Differential Revision: https://phabricator.services.mozilla.com/D51803
5f0b392beadb7300abdaa3e5e1cc1c0d5a9f0791: Bug 1565902 - Test the impact of removing startup dll readahead r=glandium
Doug Thayer <dothayer@mozilla.com> - Tue, 12 Nov 2019 04:00:00 +0000 - rev 501544
Push 114170 by malexandru@mozilla.com at Tue, 12 Nov 2019 21:58:32 +0000
Bug 1565902 - Test the impact of removing startup dll readahead r=glandium We haven't tested this in recent times, and it would be good to understand what the impact is looking at telemetry measures of startup in Nightly. This doesn't rip out everything, but we will need to do that if we determine that the readahead has a neutral / negative effect. Differential Revision: https://phabricator.services.mozilla.com/D50512
b8a7b94df40c3c942a80edac91c2656f9daf11a9: Bug 1594955 - Restore autoconf subprocess environ in old.configure r=glandium
Māris Fogels <mars@mozilla.com> - Fri, 08 Nov 2019 02:16:05 +0000 - rev 501313
Push 114168 by dluca@mozilla.com at Sun, 10 Nov 2019 03:08:55 +0000
Bug 1594955 - Restore autoconf subprocess environ in old.configure r=glandium Restore the env= argument to the subprocess.Popen() call that runs autoconf in old.configure. The argument appears to have been removed by accident in changeset f47e966507eb. Differential Revision: https://phabricator.services.mozilla.com/D52293
ec3308aa7246d40c57b9b1da9194ef461ee9c52e: Bug 1594598 - Use uint8_t* to avoid a bunch of casts. r=glandium
Nicholas Nethercote <nnethercote@mozilla.com> - Wed, 06 Nov 2019 23:56:48 +0000 - rev 501007
Push 114166 by apavel@mozilla.com at Thu, 07 Nov 2019 10:04:01 +0000
Bug 1594598 - Use uint8_t* to avoid a bunch of casts. r=glandium Currently the PHC code uses char* and uintptr_t in various address computations. This patch changes it to use uint8_t* instead, which is clearer than char* and avoids the need for various casts. Differential Revision: https://phabricator.services.mozilla.com/D43840
ba5dde550477b6902efd0185b33bf9dd22bba06d: Bug 1594598 - Improve some PHC comments. r=glandium
Nicholas Nethercote <nnethercote@mozilla.com> - Wed, 06 Nov 2019 23:56:48 +0000 - rev 501006
Push 114166 by apavel@mozilla.com at Thu, 07 Nov 2019 10:04:01 +0000
Bug 1594598 - Improve some PHC comments. r=glandium Differential Revision: https://phabricator.services.mozilla.com/D43838
f17d8e2af670fb037e668575e1813702c3e25eee: Bug 1594598 - Tweak the control flow in MaybePageAlloc()'s loop. r=glandium
Nicholas Nethercote <nnethercote@mozilla.com> - Wed, 06 Nov 2019 23:52:31 +0000 - rev 501005
Push 114166 by apavel@mozilla.com at Thu, 07 Nov 2019 10:04:01 +0000
Bug 1594598 - Tweak the control flow in MaybePageAlloc()'s loop. r=glandium This reduces the indentation level by one for most of the loop body. Differential Revision: https://phabricator.services.mozilla.com/D43837
99e7c9afdf92bda5f2f1f519a828b39c7c3007ee: Bug 1594598 - Fix some broken PHC_LOGGING code. r=glandium
Nicholas Nethercote <nnethercote@mozilla.com> - Wed, 06 Nov 2019 23:52:15 +0000 - rev 501004
Push 114166 by apavel@mozilla.com at Thu, 07 Nov 2019 10:04:01 +0000
Bug 1594598 - Fix some broken PHC_LOGGING code. r=glandium Differential Revision: https://phabricator.services.mozilla.com/D42267
0f08e0fe895640a0260b979ca4977d954ac0f8b0: Bug 1581637 - Part 12 - Add extra-bindgen-flags r=glandium
Dragana Damjanovic <dd.mozilla@gmail.com> - Fri, 01 Nov 2019 14:55:57 +0000 - rev 500219
Push 114164 by aiakab@mozilla.com at Tue, 05 Nov 2019 10:06:15 +0000
Bug 1581637 - Part 12 - Add extra-bindgen-flags r=glandium Differential Revision: https://phabricator.services.mozilla.com/D47229
65689d355c82e4a6699612afbae55e77ad21414f: Bug 1591249 - Bump coreaudio-sys to 0.2.3. r=glandium
Chun-Min Chang <chun.m.chang@gmail.com> - Thu, 31 Oct 2019 20:14:00 +0000 - rev 500129
Push 114164 by aiakab@mozilla.com at Tue, 05 Nov 2019 10:06:15 +0000
Bug 1591249 - Bump coreaudio-sys to 0.2.3. r=glandium The current coreaudio-sys in gecko is a custom 0.2.2 version that used to avoid the cross-compiling issue mentioned in bug 1569003. The issue has been fixed in the coreaudio-sys 0.2.3, so we should follow the upstream instead of using a custom version. As a result, the coreaudio-sys would generate API bindings based on the MacOS SDK defined in the build settings. Differential Revision: https://phabricator.services.mozilla.com/D50531
3a458217248db4f5a1f9d18480aea606006959aa: Bug 1581637 - Part 12 - Add extra-bindgen-flags r=glandium
Dragana Damjanovic <dd.mozilla@gmail.com> - Wed, 30 Oct 2019 20:57:03 +0000 - rev 499876
Push 114163 by aiakab@mozilla.com at Thu, 31 Oct 2019 10:03:38 +0000
Bug 1581637 - Part 12 - Add extra-bindgen-flags r=glandium Differential Revision: https://phabricator.services.mozilla.com/D47229
7cfa759188e063716b5caa77a2d4c3b096ba31c6: Bug 1569728 - manually instantiate some basic_string members for libstdc++ compat; r=glandium
Nathan Froyd <froydnj@mozilla.com> - Wed, 30 Oct 2019 13:47:19 -0400 - rev 499658
Push 114162 by nfroyd@mozilla.com at Wed, 30 Oct 2019 17:48:15 +0000
Bug 1569728 - manually instantiate some basic_string members for libstdc++ compat; r=glandium Differential Revision: https://phabricator.services.mozilla.com/D41370
3e3c05f82262d1c9c44ff5931c9ce2b74d5e5bee: Bug 1584296 - add C++17 bits to fake compiler definitions in test_toolchain_configure.py; r=glandium
Nathan Froyd <froydnj@mozilla.com> - Mon, 28 Oct 2019 20:58:15 +0000 - rev 499522
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1584296 - add C++17 bits to fake compiler definitions in test_toolchain_configure.py; r=glandium Separating these changes out into a separate patch/bug makes them a little easier to verify. Turning on C++17 support should then be just a matter of updating expected results. Differential Revision: https://phabricator.services.mozilla.com/D47324
18f60bc21ff84e75c3b413cd2fcf2d357910c338: Bug 1590890 - Disable bindgen when building coreaudio-sys. r=glandium
Chun-Min Chang <chun.m.chang@gmail.com> - Mon, 28 Oct 2019 22:04:16 +0000 - rev 499519
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1590890 - Disable bindgen when building coreaudio-sys. r=glandium Revert the coreaudio-sys dependency changed in bug 1589514, which causes a trouble when compiling with sccache Differential Revision: https://phabricator.services.mozilla.com/D50529
5ffff1f76af292e4c76758d684b99e864853e492: Bug 1586996 - Use upstream winapi instead of froydnj's aarch64 branch. r=glandium
Cameron McCormack <cam@mcc.id.au> - Wed, 23 Oct 2019 05:55:49 +0000 - rev 498651
Push 114159 by shindli@mozilla.com at Thu, 24 Oct 2019 09:49:00 +0000
Bug 1586996 - Use upstream winapi instead of froydnj's aarch64 branch. r=glandium Differential Revision: https://phabricator.services.mozilla.com/D48483
bdf7addb1a8f408eaf38607ce08fc3e898a88802: Bug 1587180 - 3. Have lintpref understand the value field r=glandium
Kristen Wright <kwright@mozilla.com> - Fri, 18 Oct 2019 22:31:38 +0000 - rev 498407
Push 114158 by ncsoregi@mozilla.com at Tue, 22 Oct 2019 09:53:30 +0000
Bug 1587180 - 3. Have lintpref understand the value field r=glandium Teaches Lintpref to look at `value` matches when considering possible duplicates. Differential Revision: https://phabricator.services.mozilla.com/D49362
a3b383ec343b88e708733b62a9a43cfdc310b66e: Bug 1587180 - 2. Improve Lintpref's pattern-matching r=glandium
Kristen Wright <kwright@mozilla.com> - Thu, 17 Oct 2019 23:26:36 +0000 - rev 498406
Push 114158 by ncsoregi@mozilla.com at Tue, 22 Oct 2019 09:53:30 +0000
Bug 1587180 - 2. Improve Lintpref's pattern-matching r=glandium Replaces the basic pattern-matching in the linter with a more robust regexp. This regexp can strip `name` and `value` from the pref, which will be useful in part 3 of bug 1587180. Differential Revision: https://phabricator.services.mozilla.com/D49361
fbcb7dcd82acfc9196c0dfd60e28248c25a4583b: Bug 1587913 - Fix rust target detection for rustc 1.38. r=firefox-build-system-reviewers,glandium
Chris Manchester <cmanchester@mozilla.com> - Wed, 16 Oct 2019 22:16:13 +0000 - rev 497922
Push 114154 by btara@mozilla.com at Thu, 17 Oct 2019 09:58:40 +0000
Bug 1587913 - Fix rust target detection for rustc 1.38. r=firefox-build-system-reviewers,glandium Differential Revision: https://phabricator.services.mozilla.com/D48996
ec7e9fc63c07c8dae8c6899cb4531b9b3e8e0469: Bug 1575883 - Handle SIGXCPU in Gecko. r=kinetik,glandium
Paul Adenot <paul@paul.cx> - Fri, 11 Oct 2019 16:02:36 +0000 - rev 497470
Push 114152 by dvarga@mozilla.com at Tue, 15 Oct 2019 11:14:34 +0000
Bug 1575883 - Handle SIGXCPU in Gecko. r=kinetik,glandium This allows installing a SIGXCPU handler, which will simply set an atomic to true when reached. Another function allows querying this atomic. Finally, another function allows demoting the current thread from real-time priority. This is per-process currently, as there is only one audio callback thread that is set to RT scheduling per process, servicing all HTMLMediaElements and MSGs. Whenever any of those go over the soft limit, the thread is demoted. Differential Revision: https://phabricator.services.mozilla.com/D43404
cd1f46e85c51f6fac89a5add35537581db9a6e80: Bug 1573211 - Update to clang 9.0.0 r=glandium
David Major <dmajor@mozilla.com> - Sat, 21 Sep 2019 16:26:53 +0200 - rev 496878
Push 114146 by dmajor@mozilla.com at Wed, 09 Oct 2019 17:52:49 +0000
Bug 1573211 - Update to clang 9.0.0 r=glandium Updates all clang 8.0.1 to version 9.0.0, except for the mingw builds which suffer from bug 1548624 and will be handled separately later. Differential Revision: https://phabricator.services.mozilla.com/D44160 MANUAL PUSH: Rebuild clang toolchains without stalling autoland
ea19d193ebbbe579e517e7da0d26b6390eb011e2: Bug 1550108 - Pull in secondary lz4 libraries r=glandium
Doug Thayer <dothayer@mozilla.com> - Fri, 04 Oct 2019 20:44:08 +0000 - rev 496390
Push 114143 by rgurzau@mozilla.com at Mon, 07 Oct 2019 09:35:08 +0000
Bug 1550108 - Pull in secondary lz4 libraries r=glandium I opted to go with what I perceived as the more expedient route of leaving lz4 roughly where it is and just adding to that. The biggest complication was xxhash, which is included elsewhere. I'm not generally proficient with build-related things though so my solution may be wrong and not just ugly. Differential Revision: https://phabricator.services.mozilla.com/D30640
0fd41e9dbd2a56e544d6b836e066fbbbd9f78b84: Bug 1550108 - Pull in secondary lz4 libraries r=glandium
Doug Thayer <dothayer@mozilla.com> - Fri, 27 Sep 2019 22:15:01 +0000 - rev 495487
Push 114134 by ccoroiu@mozilla.com at Mon, 30 Sep 2019 09:57:15 +0000
Bug 1550108 - Pull in secondary lz4 libraries r=glandium I opted to go with what I perceived as the more expedient route of leaving lz4 roughly where it is and just adding to that. The biggest complication was xxhash, which is included elsewhere. I'm not generally proficient with build-related things though so my solution may be wrong and not just ugly. Differential Revision: https://phabricator.services.mozilla.com/D30640
de0fe40466cb3a451ba0680179cd6373d4d94baf: Bug 1573211 - Update to clang 9.0.0 r=glandium
David Major <dmajor@mozilla.com> - Sat, 21 Sep 2019 16:26:53 +0200 - rev 494789
Push 114128 by sledru@mozilla.com at Wed, 25 Sep 2019 12:19:52 +0000
Bug 1573211 - Update to clang 9.0.0 r=glandium Updates all clang 8.0.1 to version 9.0.0, except for the mingw builds which suffer from bug 1548624 and will be handled separately later. Differential Revision: https://phabricator.services.mozilla.com/D44160 MANUAL PUSH: Rebuild clang toolchains without stalling autoland
3cc4fb5ab0a75e01066371d42965016f1b2634d7: Bug 1582078 - Fix the .mozbuild creation prompt r=glandium
Gabriele Svelto <gsvelto@mozilla.com> - Tue, 24 Sep 2019 00:54:23 +0000 - rev 494643
Push 114125 by cbrindusan@mozilla.com at Tue, 24 Sep 2019 16:12:51 +0000
Bug 1582078 - Fix the .mozbuild creation prompt r=glandium Differential Revision: https://phabricator.services.mozilla.com/D46267
328d3abf28b5bbd2101b1d8de72cc67031305ae2: Bug 1578677 - Support --enable-rust-simd for standalone SpiderMonkey builds. r=glandium
Henri Sivonen <hsivonen@hsivonen.fi> - Tue, 24 Sep 2019 00:26:55 +0000 - rev 494638
Push 114125 by cbrindusan@mozilla.com at Tue, 24 Sep 2019 16:12:51 +0000
Bug 1578677 - Support --enable-rust-simd for standalone SpiderMonkey builds. r=glandium Differential Revision: https://phabricator.services.mozilla.com/D46144
da59174f5098e7f63f9a480fd06a8bf02e36b8d9: Bug 1566315 - Linter for StaticPrefList.yaml r=njn,ahal,glandium
Kristen Wright <kwright@mozilla.com> - Tue, 24 Sep 2019 00:09:08 +0000 - rev 494606
Push 114123 by csabou@mozilla.com at Tue, 24 Sep 2019 03:53:15 +0000
Bug 1566315 - Linter for StaticPrefList.yaml r=njn,ahal,glandium Linter that checks for duplicates between StaticPrefList.yaml and all.js. Also a starting point for other prefs linting tasks. Differential Revision: https://phabricator.services.mozilla.com/D42340
5d82bc2f1e9e79d110a4bacd433ba20c5ccb59c7: Bug 1578535 - base arm64-related build images off debian10; r=glandium
Nathan Froyd <froydnj@mozilla.com> - Wed, 18 Sep 2019 02:58:56 +0000 - rev 494452
Push 114120 by malexandru@mozilla.com at Mon, 23 Sep 2019 09:52:13 +0000
Bug 1578535 - base arm64-related build images off debian10; r=glandium Our build toolchains don't contain libstdc++ headers for aarch64, so our aarch64 builds rely on whatever libstdc++ headers the system has installed. To bring in newer headers on our aarch64 builds, then, we need to update the system images for those builds, which this patch does. Depends on D45861 Differential Revision: https://phabricator.services.mozilla.com/D45862
0621d05839f67e04c7fd97f52283fa0f9a71676c: Bug 1578535 - explicitly install libstdc++-$VERSION-dev packages; r=glandium
Nathan Froyd <froydnj@mozilla.com> - Fri, 20 Sep 2019 19:42:28 +0000 - rev 494451
Push 114120 by malexandru@mozilla.com at Mon, 23 Sep 2019 09:52:13 +0000
Bug 1578535 - explicitly install libstdc++-$VERSION-dev packages; r=glandium On older Debian versions, `libstdc++-$VERSION-dev` is implicitly brought in by other development packages. On newer versions, this dependency has been removed. Let's go ahead and explicitly declare which version we want to install for each Debian version. Differential Revision: https://phabricator.services.mozilla.com/D45861
4257e5fc864312e762ca9c12aef8af060d4b409b: Bug 1579775 - Extend testing of `#filter slashslash`. r=glandium
Nicholas Nethercote <nnethercote@mozilla.com> - Wed, 18 Sep 2019 02:44:32 +0000 - rev 494055
Push 114104 by opoprus@mozilla.com at Thu, 19 Sep 2019 10:02:13 +0000
Bug 1579775 - Extend testing of `#filter slashslash`. r=glandium Depends on D45152 Differential Revision: https://phabricator.services.mozilla.com/D45153
eab10ea49e974b00e6b436f92404c368608832c8: Bug 1579775 - Improve some comments in preprocessor.py. r=glandium
Nicholas Nethercote <nnethercote@mozilla.com> - Wed, 18 Sep 2019 02:43:48 +0000 - rev 494054
Push 114104 by opoprus@mozilla.com at Thu, 19 Sep 2019 10:02:13 +0000
Bug 1579775 - Improve some comments in preprocessor.py. r=glandium In particular, there was some weird use of blank lines. Differential Revision: https://phabricator.services.mozilla.com/D45152
dddf2cc00b9d6fff13fb533a82176d40aa660cd5: Bug 1580899 - Remove MOZ_PGO from mozconfigs; r=glandium
Mike Shal <mshal@mozilla.com> - Wed, 18 Sep 2019 18:29:00 +0000 - rev 493978
Push 114103 by csabou@mozilla.com at Thu, 19 Sep 2019 04:08:02 +0000
Bug 1580899 - Remove MOZ_PGO from mozconfigs; r=glandium Setting this flag still attempts to build with 1-tier PGO, unless we detect that 3-tier PGO is enabled. Since we should be using 3-tier PGO everywhere, the flag should be redundant in our automation mozconfigs. It can still be used locally in a mozconfig to do a 1-tier PGO build. Depends on D46069 Differential Revision: https://phabricator.services.mozilla.com/D46070
ccb280eb90230719b0d297c0e09bdc796c1208e1: Bug 1490601 part 1 - Move encoding_c and encoding_c_mem to jsrust_shared. r=glandium
Henri Sivonen <hsivonen@hsivonen.fi> - Wed, 18 Sep 2019 08:26:27 +0000 - rev 493739
Push 114101 by nerli@mozilla.com at Wed, 18 Sep 2019 22:01:41 +0000
Bug 1490601 part 1 - Move encoding_c and encoding_c_mem to jsrust_shared. r=glandium Note: This changeset does not yet make it possible to propagate the simd-accel feature to encoding_rs in standalone SpiderMonkey builds. Differential Revision: https://phabricator.services.mozilla.com/D41355
40b7ff3abf52af8c00ada93eb8c2725f64259670: Bug 834505 undef GetCurrentTime() from windows-h-wrapper.template.h r=glandium
Karl Tomlinson <karlt+@karlt.net> - Wed, 18 Sep 2019 02:52:20 +0000 - rev 493703
Push 114097 by malexandru@mozilla.com at Wed, 18 Sep 2019 10:10:26 +0000
Bug 834505 undef GetCurrentTime() from windows-h-wrapper.template.h r=glandium GetCurrentTime is declared in WinBase.h https://github.com/tpn/winsdk-10/blob/master/Include/10.0.10240.0/um/WinBase.h#L91 Documentation for functions declared in winbase.h instruct to include Windows.h. e.g. https://docs.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-copyfile Other macro declarations in winbase.h such as CopyFile() are already adjusted with this wrapper via windows-h-unicode.decls.h A similar, but different, static inline could be provided but is not required. Differential Revision: https://phabricator.services.mozilla.com/D45288
5d538cd3182010a6f9d470884e5c5d2c03b8e1f0: Bug 1579969 - Don't add export dependency on .cargo/config when testing; r=glandium
Mike Shal <mshal@mozilla.com> - Mon, 09 Sep 2019 23:56:10 +0000 - rev 492427
Push 114056 by malexandru@mozilla.com at Tue, 10 Sep 2019 10:03:56 +0000
Bug 1579969 - Don't add export dependency on .cargo/config when testing; r=glandium Bug 1578254 added a dependency on .cargo/config to export, which happens to work in the python/mozbuild/mozbuild/test/backend/test_build.py test cases because DEPTH=., and make finds the checked-in file .cargo/config in topsrcdir because VPATH points there. After removing VPATH in bug 1496746, the test no longer finds the file in topsrcdir, and doesn't have a rule to build it since that exists in the top-level moz.build file. Differential Revision: https://phabricator.services.mozilla.com/D45261
4eca3ebf1aa8febce0353699fc93f2f362d76660: Bug 1579502 - Move libxul's Makefile.in to the right place after bug 1573566 r=glandium
David Major <dmajor@mozilla.com> - Mon, 09 Sep 2019 23:51:35 +0000 - rev 492416
Push 114056 by malexandru@mozilla.com at Tue, 10 Sep 2019 10:03:56 +0000
Bug 1579502 - Move libxul's Makefile.in to the right place after bug 1573566 r=glandium `hg mv toolkit/library/Makefile.in toolkit/library/build/` to account for https://hg.mozilla.org/integration/autoland/rev/14329e051f16. Otherwise the count-ctors flag and the orderfile flags won't be picked up. Differential Revision: https://phabricator.services.mozilla.com/D45127
e302a2dfc55b5cd44961ab7e55d549205a3c6d1c: Bug 1579430 - mark some elfhack methods as `override`; r=glandium
Nathan Froyd <froydnj@mozilla.com> - Mon, 09 Sep 2019 23:54:34 +0000 - rev 492412
Push 114056 by malexandru@mozilla.com at Tue, 10 Sep 2019 10:03:56 +0000
Bug 1579430 - mark some elfhack methods as `override`; r=glandium This change silences a couple of clang warnings. Differential Revision: https://phabricator.services.mozilla.com/D45007
b2e49b3d407e3e716596cc07c98fbc75523f2ecf: Bug 1496746 - Remove VPATH; r=glandium
Mike Shal <mshal@mozilla.com> - Mon, 09 Sep 2019 17:44:47 +0000 - rev 492369
Push 114055 by rgurzau@mozilla.com at Tue, 10 Sep 2019 03:33:46 +0000
Bug 1496746 - Remove VPATH; r=glandium Having a full VPATH for the srcdir sometimes causes make to grab the wrong prerequisite for a rule, in particular if we have a file in the srcdir and also generate a file of the same name in the objdir. We don't really need VPATH anymore though, since most of the information comes from mozbuild, where we can explicitly list the path to the srcdir or objdir as necessary. Differential Revision: https://phabricator.services.mozilla.com/D42968
e6bda07fa9bb323eeac5ab961b167e92e6a76443: Bug 1577826 - [eslint] Ensure setup runs subprocess with byte strings in env r=glandium
Andrew Halberstadt <ahalberstadt@mozilla.com> - Wed, 04 Sep 2019 23:50:26 +0000 - rev 491786
Push 114033 by ccoroiu@mozilla.com at Thu, 05 Sep 2019 16:21:04 +0000
Bug 1577826 - [eslint] Ensure setup runs subprocess with byte strings in env r=glandium Differential Revision: https://phabricator.services.mozilla.com/D44482
7f09f747bec7226d2d67575662b775586145cb07: Bug 1577826 - [mozbuild] Create an 'ensure_subprocess_env' utility function, r=glandium
Andrew Halberstadt <ahalberstadt@mozilla.com> - Wed, 04 Sep 2019 23:49:33 +0000 - rev 491785
Push 114033 by ccoroiu@mozilla.com at Thu, 05 Sep 2019 16:21:04 +0000
Bug 1577826 - [mozbuild] Create an 'ensure_subprocess_env' utility function, r=glandium Differential Revision: https://phabricator.services.mozilla.com/D44667
55974feb88c138191b1a82cc4bd77f1bd1534d0f: Bug 1411613 - mark certain allocation functions as non-throwing; r=glandium
Nathan Froyd <froydnj@mozilla.com> - Wed, 04 Sep 2019 23:40:15 +0000 - rev 491778
Push 114033 by ccoroiu@mozilla.com at Thu, 05 Sep 2019 16:21:04 +0000
Bug 1411613 - mark certain allocation functions as non-throwing; r=glandium glibc marks various allocation functions as `throw()`. This addition hasn't been a problem until we tried to enable C++17, where clang started complaining that we were redeclaring functions with mismatched exception specifications. Peculiarly, glibc declares virtually everything we redeclare as `throw()`, but clang only complains about the mismatches for a particular subset of functions. The approach taken in this patch is to add another potentially defined macro to malloc_decls.h, `NOTHROW_MALLOC_DECL`. This macro works exactly like `MALLOC_DECL`, except that clients can define `NOTHROW_MALLOC_DECL` to add appropriate `throw()` specifiers when declaring functions at global scope, and thereby avoid mismatched exception specifications. Differential Revision: https://phabricator.services.mozilla.com/D44045
67c70ab3695bc303c5d200fad8a13d0940a89ddd: Bug 1578775: Remove LIBCXX_LIBCPPABI_VERSION from build-clang.py r=glandium
David Major <dmajor@mozilla.com> - Wed, 04 Sep 2019 12:01:59 -0400 - rev 491620
Push 114030 by dmajor@mozilla.com at Wed, 04 Sep 2019 16:00:56 +0000
Bug 1578775: Remove LIBCXX_LIBCPPABI_VERSION from build-clang.py r=glandium This build workaround was made unnecessary (and in fact harmful) by https://github.com/llvm/llvm-project/commit/2d0b4d6bb3c12278d60ef7c957c0dba77d81dc95#diff-140d2deaecabaad987b883a1de1c2aa4 which landed in LLVM 9. It seems that we don't need this anyway even on our current LLVM 8 builds, so landing this separately in preparation for bug 1573211. Reviewed as part of a larger patch in https://phabricator.services.mozilla.com/D44160#1342283 MANUAL PUSH: This may cause a toolchain rebuild.
9fe5cd7003d5f7f7fbc75db3e0222e9668a2e7a2: Bug 1578198 - [configure] Ensure wrapped_subprocess uses text env with Python 3 r=glandium
Andrew Halberstadt <ahalberstadt@mozilla.com> - Wed, 04 Sep 2019 02:37:48 +0000 - rev 491616
Push 114028 by cbrindusan@mozilla.com at Wed, 04 Sep 2019 09:49:25 +0000
Bug 1578198 - [configure] Ensure wrapped_subprocess uses text env with Python 3 r=glandium Differential Revision: https://phabricator.services.mozilla.com/D44483
139e9fd6792de61600875e6efce3355b2ac3e469: Bug 1547519 - Fix jemalloc redirections for MinGW build r=glandium
Tom Ritter <tom@mozilla.com> - Wed, 04 Sep 2019 02:40:08 +0000 - rev 491613
Push 114028 by cbrindusan@mozilla.com at Wed, 04 Sep 2019 09:49:25 +0000
Bug 1547519 - Fix jemalloc redirections for MinGW build r=glandium In the MinGW build, calls to malloc inside mozglue were not being redirected as defined in the .def file. We create aliases for the redirected functions to correctly redirect them inside mozglue. An alternate solution for this exists. Rather than creating the importlib during the linking step for mozglue, we could have used dlltool to create it, and then provided it during linking. This would allow mozglue to know that it should redirect calls to malloc to je_malloc as specified in the .def file. Differential Revision: https://phabricator.services.mozilla.com/D38407
37276c20441289f74d6c245e50cfe530252533f5: Bug 1547519 - Rename NS_STRINGIFY to MOZ_STRINGIFY, move to mfbt, and unify stragglers r=glandium
Tom Ritter <tom@mozilla.com> - Wed, 04 Sep 2019 02:40:32 +0000 - rev 491612
Push 114028 by cbrindusan@mozilla.com at Wed, 04 Sep 2019 09:49:25 +0000
Bug 1547519 - Rename NS_STRINGIFY to MOZ_STRINGIFY, move to mfbt, and unify stragglers r=glandium Differential Revision: https://phabricator.services.mozilla.com/D39961
df07b41272758003312c199bbf6c1668896e7b6a: Bug 1577908 - [mach] Disable suggested command execution until Python 3 migration is finished, r=glandium
Andrew Halberstadt <ahalberstadt@mozilla.com> - Tue, 03 Sep 2019 03:46:16 +0000 - rev 491293
Push 114020 by rmaries@mozilla.com at Tue, 03 Sep 2019 09:51:48 +0000
Bug 1577908 - [mach] Disable suggested command execution until Python 3 migration is finished, r=glandium The mach driver will now run all misspelled commands with Python 3. That means we can't automatically execute the suggested command anymore, as it may need to run against Python 2. Ideally we could figure out a way to check the command against the 'mach' whitelist, but until then, let's just disable automatic execution. Worst case scenario we can turn it back on after the migration has finished. Differential Revision: https://phabricator.services.mozilla.com/D44282
be0a796cb4fd38cff3c27fb46e25b2d297e45237: Bug 1576433 - Enable SIMD in libjpeg for PowerPC. r=glandium
Cameron Kaiser <spectre@floodgap.com> - Tue, 03 Sep 2019 00:15:52 +0000 - rev 491289
Push 114020 by rmaries@mozilla.com at Tue, 03 Sep 2019 09:51:48 +0000
Bug 1576433 - Enable SIMD in libjpeg for PowerPC. r=glandium Differential Revision: https://phabricator.services.mozilla.com/D43352
59610f7142a7b87a9c701edafe227491a5e1d531: Bug 1577501 - [mach] Make sure ./mach help <command> uses the correct Python, r=glandium
Andrew Halberstadt <ahalberstadt@mozilla.com> - Tue, 03 Sep 2019 00:39:22 +0000 - rev 491287
Push 114020 by rmaries@mozilla.com at Tue, 03 Sep 2019 09:51:48 +0000
Bug 1577501 - [mach] Make sure ./mach help <command> uses the correct Python, r=glandium Some commands use external argument parsers, so invoking |mach help <command>| will import external modules (which may only be Python 2 compatible). This makes sure that we detect the actual subcommand we're generating help for and use the proper Python. A much simpler solution would have been to run |mach help| with Python 2 all the time. However, as we convert things to Python 3 this would have meant that Python 3 only code would blow up. This would have forced us to continue supporting Python 2, even for Python 3-only commands. Differential Revision: https://phabricator.services.mozilla.com/D43989