searching for reviewer(glandium)
efea3ffc7499ffa1a8d5b3f7d6d6f132a79feaff: Bug 1567619 - Avoid double stat in preprocessed file installs; r=glandium
Mike Shal <mshal@mozilla.com> - Tue, 23 Jul 2019 03:03:36 +0000 - rev 483855
Push 113755 by cbrindusan@mozilla.com at Wed, 24 Jul 2019 04:05:07 +0000
Bug 1567619 - Avoid double stat in preprocessed file installs; r=glandium Followup to bug 1566044. Differential Revision: https://phabricator.services.mozilla.com/D38763
2d10b185d498a5503b342ceeea909cb21ea9612f: Bug 1567968 - remove manual setting of MOZ_LTO from x86-64 win64 mozconfigs; r=glandium
Nathan Froyd <froydnj@mozilla.com> - Tue, 23 Jul 2019 02:59:41 +0000 - rev 483831
Push 113755 by cbrindusan@mozilla.com at Wed, 24 Jul 2019 04:05:07 +0000
Bug 1567968 - remove manual setting of MOZ_LTO from x86-64 win64 mozconfigs; r=glandium When we turned on xLTO, we removed the manual adding of Rust-side LTO flags for Win64: https://hg.mozilla.org/mozilla-central/rev/402b26b7e514#l10.12 and replaced it with automatic detection of "are we doing PGO on Windows" in configure: https://hg.mozilla.org/mozilla-central/rev/8ba3c1292475b96e2ccb46c3232c929863451ff6#l1.10 The problem is that we manually turned on xLTO in a number of different windows configurations: https://hg.mozilla.org/mozilla-central/rev/402b26b7e514#l11.1 https://hg.mozilla.org/mozilla-central/rev/402b26b7e514#l12.1 https://hg.mozilla.org/mozilla-central/rev/402b26b7e514#l13.1 Which I think we shouldn't have done: making the above change turns on xLTO for non-shippable builds as well. We should just let PGO-ness (i.e. shippable builds) take care of turning on xLTO for us. Note that we leave the aarch64 configs as they are; they were doing LTO prior to the xLTO change and it's fine to leave them doing xLTO after. Differential Revision: https://phabricator.services.mozilla.com/D38901
17f882a36bf99ac083d6479538b09f45a238e8d2: Bug 1565193 - Require Rust 1.36 r=glandium
Simon Sapin <simon.sapin@exyr.org> - Fri, 19 Jul 2019 04:50:22 +0000 - rev 483696
Push 113748 by rmaries@mozilla.com at Mon, 22 Jul 2019 21:58:54 +0000
Bug 1565193 - Require Rust 1.36 r=glandium MozReview-Commit-ID: GjcKBjZvTPr Differential Revision: https://phabricator.services.mozilla.com/D37709
14a0bf639210de3d594dd1c147f08337d2ac1d5a: Bug 1567065 - Enable PHC on Linux64 Nightly builds. r=glandium
Nicholas Nethercote <nnethercote@mozilla.com> - Fri, 19 Jul 2019 11:28:46 +0000 - rev 483654
Push 113742 by ccoroiu@mozilla.com at Mon, 22 Jul 2019 10:08:17 +0000
Bug 1567065 - Enable PHC on Linux64 Nightly builds. r=glandium Depends on D38444 Differential Revision: https://phabricator.services.mozilla.com/D38453
d62fe3697c36240555b133b15d8d8fd7d3e1b7e3: Bug 1567069 - Set valid _DEPEND_CFLAG for host compiler when target and host are different type. r=glandium
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Thu, 18 Jul 2019 07:46:03 +0000 - rev 483605
Push 113734 by nbeleuzu@mozilla.com at Sat, 20 Jul 2019 21:45:35 +0000
Bug 1567069 - Set valid _DEPEND_CFLAG for host compiler when target and host are different type. r=glandium Actually we set _DEPEND_CFLAGS to both host and target compiler. But if host and target are different compiler type, we may pass invalid option. Differential Revision: https://phabricator.services.mozilla.com/D38457
161dc1283019ebe5686a7e9e86e787dfaa390fa3: Bug 1523276 - Disable PHC for the moment. r=glandium
Nicholas Nethercote <nnethercote@mozilla.com> - Thu, 18 Jul 2019 10:46:37 +1000 - rev 483377
Push 113719 by nnethercote@mozilla.com at Fri, 19 Jul 2019 00:17:17 +0000
Bug 1523276 - Disable PHC for the moment. r=glandium Differential Revision: https://phabricator.services.mozilla.com/D38444
3c6a53b1fb24398feda73b787489612aac61cc66: Bug 1523276 - Implement PHC, a probabilistic heap checker. r=glandium,gsvelto
Nicholas Nethercote <nnethercote@mozilla.com> - Wed, 03 Jul 2019 09:26:11 +1000 - rev 483376
Push 113719 by nnethercote@mozilla.com at Fri, 19 Jul 2019 00:17:17 +0000
Bug 1523276 - Implement PHC, a probabilistic heap checker. r=glandium,gsvelto Differential Revision: https://phabricator.services.mozilla.com/D25021
5382cec9e30609f76ad88a1fe6150e1c589b7f3b: Bug 1564724 - Remove the old hand-written StaticPrefList.h. r=glandium
Nicholas Nethercote <nnethercote@mozilla.com> - Thu, 18 Jul 2019 04:15:55 +0000 - rev 483261
Push 113709 by csabou@mozilla.com at Thu, 18 Jul 2019 09:58:26 +0000
Bug 1564724 - Remove the old hand-written StaticPrefList.h. r=glandium Differential Revision: https://phabricator.services.mozilla.com/D37816
3d0e35ab6850e792933737ac827b08ebd1fa49a6: Bug 1564724 - Generate StaticPrefList.h from StaticPrefList.yaml. r=glandium
Nicholas Nethercote <nnethercote@mozilla.com> - Thu, 18 Jul 2019 00:08:20 +0000 - rev 483251
Push 113708 by aciure@mozilla.com at Thu, 18 Jul 2019 03:50:35 +0000
Bug 1564724 - Generate StaticPrefList.h from StaticPrefList.yaml. r=glandium This commit introduces StaticPrefList.yaml, which encodes the same information as StaticPrefList.h. The .yaml file was generated with a script, which is not part of this commit because it only needs to be used once. (I will attach it to the bug, however.) The commit doesn't remove StaticPrefList.h, I will do that in the next commit. (This makes things it easier to rerun the header-to-YAML script if/when necessary.) The commit does modify the comment at the top of StaticPrefList.h; that modified comment can also be seen at the top of StaticPrefList.yaml. This commit also adds a script that converts the YAML to a header file. This script becomes part of the build. I have done my best to verify that the conversion is correct by comparing the original .h file with the one generated from the YAML file. They are identical, modulo removed comments and the processing of preprocessor directives. Differential Revision: https://phabricator.services.mozilla.com/D37526
63d7dc4650c30e7c6262c510a6f1041e18d0c054: Bug 1564724 - Tweak StaticPrefList.h. r=glandium
Nicholas Nethercote <nnethercote@mozilla.com> - Wed, 17 Jul 2019 22:36:35 +0000 - rev 483246
Push 113708 by aciure@mozilla.com at Thu, 18 Jul 2019 03:50:35 +0000
Bug 1564724 - Tweak StaticPrefList.h. r=glandium Minor things to ease the transition to StaticPrefList.yaml. - Rename apz_touch_drag_enabled() to the correct apz_drag_touch_enabled(), and media_mwf_low_latency_force_disabled() to the correct media_wmf_low_latency_force_disabled(). - Change some trailing C-style comments to C++-style comments. This makes life easier for the script I wrote to convert StaticPrefList.h to StaticPrefList.yaml, which will be used for the next patch. - Avoid comments on #define lines, because they aren't handled in the YAML input. - Convert a multi-line `#if` condition to a single line, because Preprocessor.py doesn't handle multi-line conditions. - Remove one unnecessary `#undef PREF_VALUE` directive. - Move intl.charset.detector.iso2022jp.allowed to the correct section, so the YAML processing script won't complain. - Change an `int` pref to `int32_t`, again so the YAML processing script won't complain. - Change OS_OPENBSD to XP_OPENBSD, because the former isn't defined for preprocessor.py. (It's also only defined in C/C++ when chromium-config.h is included, which isn't always the case.) Differential Revision: https://phabricator.services.mozilla.com/D37815
421f7c517432f07eb91321cc6c5bff26d83427e2: Bug 1566409 - Force the deactivation of the llvm binding generation r=glandium
Sylvestre Ledru <sledru@mozilla.com> - Wed, 17 Jul 2019 05:07:53 +0000 - rev 483072
Push 113703 by archaeopteryx@coole-files.de at Wed, 17 Jul 2019 16:57:18 +0000
Bug 1566409 - Force the deactivation of the llvm binding generation r=glandium Differential Revision: https://phabricator.services.mozilla.com/D38176
3554b78bd8f085af0fbfcff74f4588e35e0463fd: Bug 1514801 - refactor clang based checker - KungFuDeathGripChecker. r=glandium
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Wed, 17 Jul 2019 05:05:30 +0000 - rev 483071
Push 113703 by archaeopteryx@coole-files.de at Wed, 17 Jul 2019 16:57:18 +0000
Bug 1514801 - refactor clang based checker - KungFuDeathGripChecker. r=glandium Differential Revision: https://phabricator.services.mozilla.com/D38187
9b45b5d3aa3ce3a61087847f24191ea0284d194f: Bug 1526744 - Read files in chunks when calculating md5 in find_dupes. r=glandium
Rob Lemley <rob@thunderbird.net> - Sat, 13 Jul 2019 01:31:52 +0000 - rev 482782
Push 113692 by nerli@mozilla.com at Mon, 15 Jul 2019 21:50:20 +0000
Bug 1526744 - Read files in chunks when calculating md5 in find_dupes. r=glandium Reduce RAM needed by find-dupes.py by reading files in chunks when calculating md5 checksums. Differential Revision: https://phabricator.services.mozilla.com/D37758
11e9387ad7dcce2e9111075f1d6b7babc5c3678a: Bug 1458385: Repackage windows builds on linux. r=glandium,Callek
Tom Prince <mozilla@hocat.ca> - Thu, 11 Jul 2019 16:40:25 +0000 - rev 482459
Push 113674 by dvarga@mozilla.com at Fri, 12 Jul 2019 10:08:07 +0000
Bug 1458385: Repackage windows builds on linux. r=glandium,Callek This only uses cross-platform tools, so switch to running these on linux, which cuts the runtime down from ~20m to ~3m. Differential Revision: https://phabricator.services.mozilla.com/D1080
44487d4ee1b764f3eca4a307e41675ab3482f22f: Bug 1458385: Update linux-upx to 3.9.5; r=glandium
Tom Prince <mozilla@hocat.ca> - Thu, 11 Jul 2019 16:40:20 +0000 - rev 482458
Push 113674 by dvarga@mozilla.com at Fri, 12 Jul 2019 10:08:07 +0000
Bug 1458385: Update linux-upx to 3.9.5; r=glandium This matches the version that exists in mozilla-build (see Bug 1501403). Differential Revision: https://phabricator.services.mozilla.com/D26413
f4439e9cad8decfc5f7e0e55859bfd21fc31b0d9: Bug 1458385: Make linux64-upx toolchain tier 1; r=glandium
Tom Prince <mozilla@hocat.ca> - Thu, 11 Jul 2019 16:40:16 +0000 - rev 482457
Push 113674 by dvarga@mozilla.com at Fri, 12 Jul 2019 10:08:07 +0000
Bug 1458385: Make linux64-upx toolchain tier 1; r=glandium This also switches it to use the generic toolchain build image, as it is no longer being used exclusively by mingw builds. Differential Revision: https://phabricator.services.mozilla.com/D24230
6fe86a878b81a330efb24e6a046285fffbf5162e: Bug 1458385: Package mar and mbsdiff as a toolchain; r=glandium
Tom Prince <mozilla@hocat.ca> - Thu, 11 Jul 2019 16:40:13 +0000 - rev 482456
Push 113674 by dvarga@mozilla.com at Fri, 12 Jul 2019 10:08:07 +0000
Bug 1458385: Package mar and mbsdiff as a toolchain; r=glandium Differential Revision: https://phabricator.services.mozilla.com/D24229
66f52bda7e14e26235bd0a43bb68ad11775046e4: Bug 1458385: Set mar-channel-id from taskcluster rather than based on update-channel; r=glandium
Tom Prince <mozilla@hocat.ca> - Thu, 11 Jul 2019 16:40:00 +0000 - rev 482453
Push 113674 by dvarga@mozilla.com at Fri, 12 Jul 2019 10:08:07 +0000
Bug 1458385: Set mar-channel-id from taskcluster rather than based on update-channel; r=glandium Taskgraph needs to know the correct mar-channel, so allow it to pass it into the build, rather than keying off the update-channel in configure. This will allow using a `mar` binary that doesn't have the mar-channel configured in. Differential Revision: https://phabricator.services.mozilla.com/D37480
e4dd9975c68a50c3409512d92b2df40103bac9d1: Bug 1562358 - Move fallible.h into MFBT. r=glandium
Jed Davis <jld@mozilla.com> - Wed, 10 Jul 2019 01:51:15 +0000 - rev 482045
Push 113647 by aciure@mozilla.com at Wed, 10 Jul 2019 09:46:39 +0000
Bug 1562358 - Move fallible.h into MFBT. r=glandium Differential Revision: https://phabricator.services.mozilla.com/D36541
4f0a64853706007f23f6b0e65304218e90a6c706: Bug 1563378 - Update builders to rustc 1.36. r=glandium
Chris Manchester <cmanchester@mozilla.com> - Tue, 09 Jul 2019 22:02:47 +0000 - rev 482019
Push 113647 by aciure@mozilla.com at Wed, 10 Jul 2019 09:46:39 +0000
Bug 1563378 - Update builders to rustc 1.36. r=glandium Differential Revision: https://phabricator.services.mozilla.com/D37341
9e8eb6b8650f8a25b96d33482f5469327e5268d4: Bug 1563378 - Bump OOM hook version for the rust update to 1.36. r=glandium
Chris Manchester <cmanchester@mozilla.com> - Tue, 09 Jul 2019 05:15:44 +0000 - rev 482018
Push 113647 by aciure@mozilla.com at Wed, 10 Jul 2019 09:46:39 +0000
Bug 1563378 - Bump OOM hook version for the rust update to 1.36. r=glandium Differential Revision: https://phabricator.services.mozilla.com/D37342
5bf39249f6e47f4ceda3054c5fc598bc4be3cf57: Bug 1562358 - Move fallible.h into MFBT. r=glandium
Jed Davis <jld@mozilla.com> - Tue, 02 Jul 2019 09:08:21 +0000 - rev 481925
Push 113647 by aciure@mozilla.com at Wed, 10 Jul 2019 09:46:39 +0000
Bug 1562358 - Move fallible.h into MFBT. r=glandium Differential Revision: https://phabricator.services.mozilla.com/D36541
471550ac81dccd22b7d7e12c2978187b67198e32: Bug 1545095: Disable LeakSanitizer runtime in asan builds r=glandium
Wander Lairson Costa <wander.lairson@gmail.com> - Tue, 09 Jul 2019 05:19:47 +0000 - rev 481899
Push 113647 by aciure@mozilla.com at Wed, 10 Jul 2019 09:46:39 +0000
Bug 1545095: Disable LeakSanitizer runtime in asan builds r=glandium In newer docker versions the LeakSanitizer will fail unless it runs in a privileged container. During the gecko build process in asan builds, the support tools built as part of the build process will also run with LeakSanitizer by default, but there is no need for such. We then disable runtime leak sanitizer in asan builds to avoid erros in builds inside a docker container. Differential Revision: https://phabricator.services.mozilla.com/D37295
c3c853745453f187d60d195a04c5d877f04de896: Bug 1562389 - Better detect non-clang-cl native windows clang. r=glandium
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 08 Jul 2019 10:35:40 +0000 - rev 481639
Push 113632 by nbeleuzu@mozilla.com at Tue, 09 Jul 2019 03:54:50 +0000
Bug 1562389 - Better detect non-clang-cl native windows clang. r=glandium When building Gecko/Android/aarch64 on Windows, `--target` parameter may not be incorrect value. Although `check_compiler`'s `info` is target compiler, clang on Windows is always detected as `clang-cl`, not `clang`. ``` c:/Users/mkato/.mozbuild/clang/bin/clang.exe -E -dM - < /dev/null ... #define _MSC_VER 1916 ``` So even if using clang on Windows, not clang-cl, we should detect as 'clang' correctly Differential Revision: https://phabricator.services.mozilla.com/D36422
4762f5a28a7287d48d3f6c90fe7a9e7b2b8c0c10: Bug 770286: Prevent git LF-to-CRLF autoconversion r=glandium
Kagami Sascha Rosylight <saschanaz@outlook.com> - Sat, 06 Jul 2019 02:36:03 +0000 - rev 481530
Push 113617 by dvarga@mozilla.com at Sat, 06 Jul 2019 09:38:11 +0000
Bug 770286: Prevent git LF-to-CRLF autoconversion r=glandium Currently git for Windows converts LF to CRLF by default, so this change prevents that to match the mercurial behavior. Differential Revision: https://phabricator.services.mozilla.com/D32001
7dbb546e613875cec06e1615c42dd7c4266fe170: Bug 1562389 - Better detect non-clang-cl native windows clang r=glandium
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Thu, 04 Jul 2019 01:28:12 +0000 - rev 481247
Push 113603 by ncsoregi@mozilla.com at Thu, 04 Jul 2019 09:55:46 +0000
Bug 1562389 - Better detect non-clang-cl native windows clang r=glandium When building Gecko/Android/aarch64 on Windows, `--target` parameter may not be incorrect value. Although `check_compiler`'s `info` is target compiler, clang on Windows is always detected as `clang-cl`, not `clang`. ``` c:/Users/mkato/.mozbuild/clang/bin/clang.exe -E -dM - < /dev/null ... #define _MSC_VER 1916 ``` So even if using clang on Windows, not clang-cl, we should detect as 'clang' correctly Differential Revision: https://phabricator.services.mozilla.com/D36422
dd7650cf9cd911bba0e759373b732886a840e4c1: Bug 1562045 - Disable jemalloc on mingw-clang builds for now r=glandium
Tom Ritter <tom@mozilla.com> - Thu, 27 Jun 2019 22:00:31 +0000 - rev 480482
Push 113551 by aiakab@mozilla.com at Fri, 28 Jun 2019 10:13:48 +0000
Bug 1562045 - Disable jemalloc on mingw-clang builds for now r=glandium Differential Revision: https://phabricator.services.mozilla.com/D36251
861e83cc1b9bc119f70c7a714eb8c9b4d0e3b34c: Bug 1557785 - Switch backslashes to forward-slashes in JARLOG_FILE_AB_CD for Windows; r=glandium
Mike Shal <mshal@mozilla.com> - Wed, 19 Jun 2019 22:06:11 +0000 - rev 480110
Push 113523 by csabou@mozilla.com at Wed, 26 Jun 2019 04:02:15 +0000
Bug 1557785 - Switch backslashes to forward-slashes in JARLOG_FILE_AB_CD for Windows; r=glandium Our version of mozmake in Windows has issues with how it shells out to commands that contain double-quote characters. For example: FOO="bar" $(PYTHON) script.py behaves differently than: FOO='bar' $(PYTHON) script.py With a double-quote anywhere in the command-line, backslashes get slurped, so Z:\task/foo becomes Z:task/foo, and python fails to open the file. The backslash comes from the WORKSPACE variable in Taskcluster, which is used in many places, so it seems prudent here to simply convert the backslash to a forward-slash as a workaround for the issue. Another possible workaround is to change WORKSPACE to use forward-slashes, and work around any potential issues with that. Differential Revision: https://phabricator.services.mozilla.com/D34801
dcf33acba09527474a11e107f71583916fc86cbe: Bug 1561350 - Fix libclang detection for clang-cl 9 r=glandium
David Major <dmajor@mozilla.com> - Tue, 25 Jun 2019 20:39:01 +0000 - rev 480095
Push 113523 by csabou@mozilla.com at Wed, 26 Jun 2019 04:02:15 +0000
Bug 1561350 - Fix libclang detection for clang-cl 9 r=glandium In the clang-cl 9 case where we have semicolon-separated paths, the `dirs` variable is never read, so the libclang detection fails. Differential Revision: https://phabricator.services.mozilla.com/D35825
1d5517788ccb535a9d6573e4db1c81417386af2a: Bug 1561069 - fix mistranslation in preprocess_libffi_asm.py; r=glandium
Nathan Froyd <froydnj@mozilla.com> - Mon, 24 Jun 2019 21:26:32 +0000 - rev 479982
Push 113511 by aciure@mozilla.com at Tue, 25 Jun 2019 09:44:15 +0000
Bug 1561069 - fix mistranslation in preprocess_libffi_asm.py; r=glandium When we converted our libffi assembly preprocessing to use `GENERATED_FILES`, we translated `sed 's%/F[dpa][^ ]*%%g'` to use the Python regular expression `'F[dpa][^ ]*'`. Note that we missed the leading `/` in the sed expression; omitting that leading slash causes no end of trouble if you have particular expressions in your assembly file, such as "FastFailCode". (I'm a little surprised this hasn't bitten us yet.) The straightfoward fix is to add the leading slash. But wait, the rabbit hole goes deeper. The actual bit from libffi's `msvcc.sh` that this was trying to translate was: ``` echo "$cl -nologo -EP $includes $defines $src > $ppsrc" "$cl" -nologo -EP $includes $defines $src > $ppsrc || exit $? output="$(echo $output | sed 's%/F[dpa][^ ]*%%g')" args="-nologo $safeseh $single $output $ppsrc" echo "$ml $args" eval "\"$ml\" $args" result=$? ``` Note that the sed expression is operating on `$output`, which is a completely *separate* thing from the output from the result of preprocessing. In `msvcc.sh`, `$output` is actually some arguments that are supposed to be passed to the assembler, per the above and the only place in the script that sets `$output` to a non-trivial value: ``` -o) outdir="$(dirname $2)" base="$(basename $2|sed 's/\.[^.]*//g')" if [ -n "$single" ]; then output="-Fo$2" else output="-Fe$2" fi if [ -n "$assembly" ]; then args="$args $output" else args="$args $output -Fd$outdir/$base -Fp$outdir/$base -Fa$outdir/$base" fi ``` Presumably the sed expression is attempting to remove `-Fd` and friends from `$args` instead of `$output`, but failing badly at doing so. In any event, the regex substitution the script is doing is unnecessary and, with the current code, actively harmful. Let's remove the regular expression substitution entirely. Differential Revision: https://phabricator.services.mozilla.com/D35705
757d5565859254a998fb14c73ebd403648345638: Bug 1557265 - Include gbm.h to build Wayland dmabuf backend, r=glandium
Martin Stransky <stransky@redhat.com> - Thu, 20 Jun 2019 21:52:42 +0000 - rev 479791
Push 113488 by shindli@mozilla.com at Fri, 21 Jun 2019 09:45:11 +0000
Bug 1557265 - Include gbm.h to build Wayland dmabuf backend, r=glandium Depends on D34857 Differential Revision: https://phabricator.services.mozilla.com/D34858
add34d86fd69d265f2313cac624e65ab3ede770c: Bug 1557265 - Remove HAVE_LIBDRM defines as libdrm is mandatory now, r=glandium
Martin Stransky <stransky@redhat.com> - Thu, 20 Jun 2019 21:52:40 +0000 - rev 479790
Push 113488 by shindli@mozilla.com at Fri, 21 Jun 2019 09:45:11 +0000
Bug 1557265 - Remove HAVE_LIBDRM defines as libdrm is mandatory now, r=glandium Depends on D33918 Differential Revision: https://phabricator.services.mozilla.com/D34857
54f8d7c37934272ac097e53e1bcda0deba29d202: Bug 1557265 - [Wayland] Require libdrm to build Wayland backend, r=glandium
Martin Stransky <stransky@redhat.com> - Thu, 20 Jun 2019 21:51:15 +0000 - rev 479789
Push 113488 by shindli@mozilla.com at Fri, 21 Jun 2019 09:45:11 +0000
Bug 1557265 - [Wayland] Require libdrm to build Wayland backend, r=glandium Differential Revision: https://phabricator.services.mozilla.com/D33918
dbcf19f02605cc52b484ce857f258d1caba70ae9: Bug 1555355 - Enable arena randomization for the Arraybuffer and String arenas r=glandium,jandem
Tom Ritter <tom@mozilla.com> - Thu, 20 Jun 2019 17:06:49 +0000 - rev 479731
Push 113488 by shindli@mozilla.com at Fri, 21 Jun 2019 09:45:11 +0000
Bug 1555355 - Enable arena randomization for the Arraybuffer and String arenas r=glandium,jandem Differential Revision: https://phabricator.services.mozilla.com/D33212
5e797f74091ad5195fda457ba351902128ab52ab: Bug 1557265 - Include gbm.h to build Wayland dmabuf backend, r=glandium
Martin Stransky <stransky@redhat.com> - Thu, 20 Jun 2019 18:05:29 +0000 - rev 479726
Push 113488 by shindli@mozilla.com at Fri, 21 Jun 2019 09:45:11 +0000
Bug 1557265 - Include gbm.h to build Wayland dmabuf backend, r=glandium Depends on D34857 Differential Revision: https://phabricator.services.mozilla.com/D34858
f10c947516e07370615fe8534f81255093f844db: Bug 1557265 - Remove HAVE_LIBDRM defines as libdrm is mandatory now, r=glandium
Martin Stransky <stransky@redhat.com> - Thu, 20 Jun 2019 18:05:27 +0000 - rev 479725
Push 113488 by shindli@mozilla.com at Fri, 21 Jun 2019 09:45:11 +0000
Bug 1557265 - Remove HAVE_LIBDRM defines as libdrm is mandatory now, r=glandium Depends on D33918 Differential Revision: https://phabricator.services.mozilla.com/D34857
f7e5ef31a50b7b9080f28a53150f16b393d448db: Bug 1557265 - [Wayland] Require libdrm to build Wayland backend, r=glandium
Martin Stransky <stransky@redhat.com> - Thu, 20 Jun 2019 18:05:25 +0000 - rev 479724
Push 113488 by shindli@mozilla.com at Fri, 21 Jun 2019 09:45:11 +0000
Bug 1557265 - [Wayland] Require libdrm to build Wayland backend, r=glandium Differential Revision: https://phabricator.services.mozilla.com/D33918
7b180f98ba3edadcdfcc72682fb5d6a0cff97ae8: Bug 1557265 - Include gbm.h to build Wayland dmabuf backend, r=glandium
Martin Stransky <stransky@redhat.com> - Wed, 19 Jun 2019 22:22:01 +0000 - rev 479628
Push 113474 by rmaries@mozilla.com at Thu, 20 Jun 2019 11:21:48 +0000
Bug 1557265 - Include gbm.h to build Wayland dmabuf backend, r=glandium Depends on D34857 Differential Revision: https://phabricator.services.mozilla.com/D34858
0739231e045620177d264d44fc4901d3348c61df: Bug 1557265 - Remove HAVE_LIBDRM defines as libdrm is mandatory now, r=glandium
Martin Stransky <stransky@redhat.com> - Wed, 19 Jun 2019 21:55:35 +0000 - rev 479627
Push 113474 by rmaries@mozilla.com at Thu, 20 Jun 2019 11:21:48 +0000
Bug 1557265 - Remove HAVE_LIBDRM defines as libdrm is mandatory now, r=glandium Depends on D33918 Differential Revision: https://phabricator.services.mozilla.com/D34857
5fc2424b9085bce67dde56b2870d834ce2111d60: Bug 1557265 - [Wayland] Require libdrm to build Wayland backend, r=glandium
Martin Stransky <stransky@redhat.com> - Wed, 19 Jun 2019 21:55:33 +0000 - rev 479626
Push 113474 by rmaries@mozilla.com at Thu, 20 Jun 2019 11:21:48 +0000
Bug 1557265 - [Wayland] Require libdrm to build Wayland backend, r=glandium Differential Revision: https://phabricator.services.mozilla.com/D33918
c277d00251889e2017973fb2ca116c8e576eab4c: Bug 1376408 - Randomize free region selection for small allocations in a run r=glandium
Tom Ritter <tom@mozilla.com> - Tue, 18 Jun 2019 21:18:23 +0000 - rev 479137
Push 113465 by cbrindusan@mozilla.com at Wed, 19 Jun 2019 03:59:07 +0000
Bug 1376408 - Randomize free region selection for small allocations in a run r=glandium This allows freelist randomization on a per-arena basis, by supplying parameters to arena creation. It uses an xorshift PRNG with a 128-bit state. It is not cryptographically secure. An attacker who can observe outputs of the RNG, or read its state, is already in a position to bypass the randomization applied. At the same time we make its state 128 bit to prevent a trivial bypass if one or two outputs are observed. The way a run selects masks to check has not been modified, so the randomization is limited to at most 32 bits in the current mask being tested. It should be noted that while allocations from the same run may now be non deterministic (up to the maximum entropy as previously stated), an attacker who can perform multiple allocations will still be able to allocate a targeted free region (for example while exploiting a use after free vulnerability in the DOM). Non deterministic allocations will only impede an attacker who has less control over how they allocate a targeted free region, and may provide some benefit during exploitation of a heap based buffer overflow vulnerability where the attacker wishes to construct a precise layout of regions pre overflow. Differential Revision: https://phabricator.services.mozilla.com/D32219
e07990ce888f791eea18cfb2ad28e26c88137f2f: Bug 1557907 - Fix `jemalloc_replace_dynamic()`. r=glandium
Nicholas Nethercote <nnethercote@mozilla.com> - Thu, 13 Jun 2019 20:42:19 +0000 - rev 478787
Push 113435 by shindli@mozilla.com at Fri, 14 Jun 2019 03:43:52 +0000
Bug 1557907 - Fix `jemalloc_replace_dynamic()`. r=glandium `jemalloc_replace_dynamic()` is badly broken. If you install a malloc table other than the default at startup (e.g. DMD's or PHC's), when you call `jemalloc_replace_dynamic()` it installs a new allocator that wraps the *default* allocator, and then when you call `jemalloc_replace_dynamic(nullptr)` it switches back to the *default* allocator. This commits makes numerous improvements. - It removes the "flip-flopping" between malloc tables, which didn't really work and isn't necessary. - `jemalloc_replace_dynamic()` now switches between the *original* malloc table and the new one, rather than the *default* malloc table and the new one. - It renames various things, to make the names shorter and clearer. - It clearly documents the dangers and limitations of `jemalloc_replace_dynamic()`. - It removes and inlines `profiler::Init()`, because there was only one call site. - It rearranges `install_memory_counter()` so the control flow is simpler. Differential Revision: https://phabricator.services.mozilla.com/D34266
a0f2ce7616f5d419fdc17d7bca52505f51c7621d: Bug 1558996 - Require rust 1.35 r=glandium
Chris Manchester <cmanchester@mozilla.com> - Thu, 13 Jun 2019 06:02:05 +0000 - rev 478740
Push 113435 by shindli@mozilla.com at Fri, 14 Jun 2019 03:43:52 +0000
Bug 1558996 - Require rust 1.35 r=glandium Differential Revision: https://phabricator.services.mozilla.com/D34794
315b40a42b276dd6650bb2db08842bde3cea5a44: Bug 1558365 - Simplify `PtrInfoTag`. r=glandium
Nicholas Nethercote <nnethercote@mozilla.com> - Wed, 12 Jun 2019 07:38:30 +0000 - rev 478416
Push 113422 by aciure@mozilla.com at Wed, 12 Jun 2019 21:46:30 +0000
Bug 1558365 - Simplify `PtrInfoTag`. r=glandium This makes it less mozjemalloc-specific, which is helpful for PHC. No non-test code uses the extra detail anyway. Differential Revision: https://phabricator.services.mozilla.com/D34441
b314f6c6148efb8909c3483eb2a49117049a06cd: Bug 1556646 part 2 - Rename JS_POSIX_NSPR to JS_WITHOUT_NSPR and remove --enable-posix-nspr-emulation configure flag. r=sfink,glandium
Jan de Mooij <jdemooij@mozilla.com> - Sat, 08 Jun 2019 09:10:59 +0000 - rev 477975
Push 113389 by ncsoregi@mozilla.com at Sun, 09 Jun 2019 09:14:13 +0000
Bug 1556646 part 2 - Rename JS_POSIX_NSPR to JS_WITHOUT_NSPR and remove --enable-posix-nspr-emulation configure flag. r=sfink,glandium Stand-alone JS builds now default to without-NSPR on all platforms. Note that the JS shell builds we do in automation pass --enable-nspr-build so they shouldn't be affected by the JS shell changes. Differential Revision: https://phabricator.services.mozilla.com/D33933
af7f8f492855b898e2ac58e481f51e67a6bfb6bf: Bug 1523162 - Remove WebRtc_GetCPUFeaturesARM from cpu_features.cc; r=glandium
Dan Minor <dminor@mozilla.com> - Tue, 04 Jun 2019 08:51:40 +0000 - rev 476764
Push 113311 by btara@mozilla.com at Tue, 04 Jun 2019 16:10:59 +0000
Bug 1523162 - Remove WebRtc_GetCPUFeaturesARM from cpu_features.cc; r=glandium Differential Revision: https://phabricator.services.mozilla.com/D33484
eec771e04586c7d67fa96f7d4850323bd50143a5: Bug 1553731 - Part 2: Generate FrameIdList.h and FrameTypeList.h from Python. r=mats,glandium
Cameron McCormack <cam@mcc.id.au> - Sat, 01 Jun 2019 08:03:40 +0000 - rev 476534
Push 113288 by ncsoregi@mozilla.com at Sat, 01 Jun 2019 21:38:17 +0000
Bug 1553731 - Part 2: Generate FrameIdList.h and FrameTypeList.h from Python. r=mats,glandium Differential Revision: https://phabricator.services.mozilla.com/D32604
b8669aa5a820bd291c7ce9b9a61be1c97bff7506: Bug 1553731 - Part 2: Generate FrameIdList.h and FrameTypeList.h from Python. r=mats,glandium
Cameron McCormack <cam@mcc.id.au> - Sat, 01 Jun 2019 01:04:46 +0000 - rev 476515
Push 113287 by dvarga@mozilla.com at Sat, 01 Jun 2019 09:47:25 +0000
Bug 1553731 - Part 2: Generate FrameIdList.h and FrameTypeList.h from Python. r=mats,glandium Differential Revision: https://phabricator.services.mozilla.com/D32604
18ace6e657295cd901ec574d67639977362ac94f: Bug 1553781: When the remote service finds an instance to remote to it doesn't clean up the startup lock. r=glandium
Dave Townsend <dtownsend@oxymoronical.com> - Thu, 30 May 2019 17:53:36 +0000 - rev 476261
Push 113263 by nbeleuzu@mozilla.com at Fri, 31 May 2019 04:08:20 +0000
Bug 1553781: When the remote service finds an instance to remote to it doesn't clean up the startup lock. r=glandium This fixes the issue in a few redundant ways: * nsProfileLock is made to properly clean itself up when destroyed. * nsRemoteService makes sure the unlock when destroyed. * nsAppRunner unlocks when a remote client has been found. Differential Revision: https://phabricator.services.mozilla.com/D32360
e1a84cfd134ed470e6d63c712ab0244b7218415e: Bug 1508976 - Produce a multi-architecture GeckoView "fat AAR". r=glandium
Nick Alexander <nalexander@mozilla.com> - Thu, 30 May 2019 15:22:09 +0000 - rev 476235
Push 113262 by nbeleuzu@mozilla.com at Thu, 30 May 2019 21:52:09 +0000
Bug 1508976 - Produce a multi-architecture GeckoView "fat AAR". r=glandium This follows the model set down for EME artifacts: - a new tier is added that uses a new Python build action to fetch and artifacts - the action unpacks the fetched artifacts and moves specific inputs into places expected by the build and packager - in automation, MOZ_ARTIFACT_TASK* is used to ensure the artifacts come from the correct tasks In this case, the artifact fetching is done entirely in a new Python build action that internally uses `mach artifact install --job ...`. The action also verifies that the fetched artifacts are compatible and that we're not assembling a fat AAR that is nonsensical. The specific inputs are not used in the Fennec APK that is produced; they're only used in the GeckoView AAR that is produced. The artifact fetching itself required tweaking to fetch only `target.maven.zip` artifacts and to not unpack them. The specific inputs used are the native libraries (libs/$ARCH/*.so) and the architecture-specific preference files ($ARCH/greprefs.js and defaults/pref/$ARCH/geckoview-prefs.js). None of these inputs are impacted by l10n. Differential Revision: https://phabricator.services.mozilla.com/D31572