searching for reviewer(froydnj)
cc7e68d7565f8383a487b56cdc99d7f562366501: Bug 1559403 - Implement nsIStringInputStream.setUTF8Data. r=froydnj
Masatoshi Kimura <VYV03354@nifty.ne.jp> - Fri, 14 Jun 2019 15:48:41 +0000 - rev 479005
Push 113448 by apavel@mozilla.com at Sat, 15 Jun 2019 10:07:35 +0000
Bug 1559403 - Implement nsIStringInputStream.setUTF8Data. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D35027
595c5084ff826edbc6bc6b7df11b2e9e35549c9a: Bug 1557161 - enable rkv consumers to migrate LMDB environments across architecture changes r=lina,keeler,froydnj
Myk Melez <myk@mykzilla.org> - Thu, 13 Jun 2019 19:14:59 +0000 - rev 478760
Push 113435 by shindli@mozilla.com at Fri, 14 Jun 2019 03:43:52 +0000
Bug 1557161 - enable rkv consumers to migrate LMDB environments across architecture changes r=lina,keeler,froydnj Differential Revision: https://phabricator.services.mozilla.com/D33863
6206d686e569c29a22135102ec10c61ce01b5327: Bug 1558653. Stop using [array] in nsIConsoleService. r=froydnj
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 12 Jun 2019 18:10:19 +0000 - rev 478537
Push 113423 by aciure@mozilla.com at Thu, 13 Jun 2019 03:53:27 +0000
Bug 1558653. Stop using [array] in nsIConsoleService. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D34666
fb3638ac59a068fbfd30b5d8af6dcff612e5fd8d: Bug 1557171 - Wrap the sys/cachectl.h system header on mips linux. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Fri, 07 Jun 2019 00:02:18 +0000 - rev 478340
Push 113419 by dluca@mozilla.com at Wed, 12 Jun 2019 12:45:34 +0000
Bug 1557171 - Wrap the sys/cachectl.h system header on mips linux. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D33883
df638043c67bca7a8bfaf53abb581a92b25b4944: Bug 1556173: Fix test_profile_reset.js on dev-edition builds. r=froydnj
Dave Townsend <dtownsend@oxymoronical.com> - Mon, 10 Jun 2019 17:55:12 +0000 - rev 478320
Push 113419 by dluca@mozilla.com at Wed, 12 Jun 2019 12:45:34 +0000
Bug 1556173: Fix test_profile_reset.js on dev-edition builds. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D34002
29fdbc50c0a1427ef1d62745f1c4ba5c43710f16: Bug 1553929: Make some attempt to correctly match default profiles after profiles.ini has been manually edited by the user. r=froydnj
Dave Townsend <dtownsend@oxymoronical.com> - Tue, 11 Jun 2019 17:32:17 +0000 - rev 478311
Push 113419 by dluca@mozilla.com at Wed, 12 Jun 2019 12:45:34 +0000
Bug 1553929: Make some attempt to correctly match default profiles after profiles.ini has been manually edited by the user. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D34038
ce509bb0895aac04378f959a5c6627fb10b384d8: Bug 1557161 - enable rkv consumers to migrate LMDB environments across architecture changes r=lina,keeler,froydnj
Myk Melez <myk@mykzilla.org> - Mon, 10 Jun 2019 18:14:46 +0000 - rev 478113
Push 113405 by nerli@mozilla.com at Tue, 11 Jun 2019 03:22:35 +0000
Bug 1557161 - enable rkv consumers to migrate LMDB environments across architecture changes r=lina,keeler,froydnj Differential Revision: https://phabricator.services.mozilla.com/D33863
7ca8fe32a5d993f0eef763e0f8e17268f2798aad: Bug 1556831: Have safe mode write out the normal compatibility version. r=froydnj
Dave Townsend <dtownsend@oxymoronical.com> - Tue, 04 Jun 2019 09:57:59 -0700 - rev 477818
Push 113377 by dtownsend@mozilla.com at Fri, 07 Jun 2019 17:35:13 +0000
Bug 1556831: Have safe mode write out the normal compatibility version. r=froydnj When launching into safe mode we write out a compatibility.ini with an invalid compatibility version in it. This is to ensure that on the next startup we flush the caches. This is unnecessary though, we already have a flag we can set in compatibility.ini in order to request a flush on next startup. This patch switches to doing that so the version check on startup continues to work. Differential Revision: https://phabricator.services.mozilla.com/D33699
60ce5565ab9a8cef6347fd680593d81ab5555054: Bug 1553272 - Eliminate the unnecessary ProtocolState object, r=froydnj
Nika Layzell <nika@thelayzells.com> - Thu, 06 Jun 2019 14:57:34 +0000 - rev 477666
Push 113366 by ncsoregi@mozilla.com at Thu, 06 Jun 2019 22:41:06 +0000
Bug 1553272 - Eliminate the unnecessary ProtocolState object, r=froydnj The vast majority of the virtual methods which were used on ProtocolState were actually methods which only had meaningful implementations on the toplevel protocol. This patch adds a new field to IProtocol holding a direct pointer to the protocol's `IToplevelProtocol`, and the methods formerly implemented with ProtocolState now directly call the corresponding method on IToplevelProtocol. IToplevelProtocol then shadows these methods with the toplevel protocol implementation, meaning that the right code is run in the right places. In addition, some state was maintained for protocols inside of the separate ProtocolState allocation, and this patch moves that state back into the actor itself. Differential Revision: https://phabricator.services.mozilla.com/D32044
7ccf4682332352a0a00c072d5ed04a5d1e5957cb: Bug 1556832: Comparing compatibility versions goes on to check the build IDs when the version is newer. r=froydnj
Dave Townsend <dtownsend@oxymoronical.com> - Tue, 04 Jun 2019 10:44:16 -0700 - rev 477577
Push 113363 by dtownsend@mozilla.com at Thu, 06 Jun 2019 19:12:13 +0000
Bug 1556832: Comparing compatibility versions goes on to check the build IDs when the version is newer. r=froydnj When comparing compatibility versions we first compare the version part. If that shows us to be a downgrade then we stop checking at that point. But we must also stop checking if it shows us to be an upgrade since we don't need to check the build IDs at that point. This also applies to the check for the app build ID. This means that a newer version with an older build id will appear to be a downgrade. This is problematic for safe mode because when safe mode runs it sets the compatibility version to "Safe Mode" (bug 1556831) to ensure that caches are invalidated on next startup. On the next run the Firefox version is considered as newer than "Safe Mode" so we would move on to comparing the build IDs. But the Firefox build ID gets version compared to "" (since there isn't a build ID part in "Safe Mode"). Since build ID's are larger than 32-bit numbers we trigger bug 1556829 and the actual comparison depends on the value of the build ID truncated to 32-bits. This seems to often be negative and so lower than the apparent previous build ID causing us to think this is a downgrade. Cue nfroydnj saying I told you so because if I'd written this as a more traditional compare function as he suggested I probably would have caught this. Differential Revision: https://phabricator.services.mozilla.com/D33702
b3627356da9891d4f5ed2df1dc93ad2f5a9ed24b: Bug 1556829: Convert version numbers larger or smaller than the 32-bit limit to 0. r=froydnj
Dave Townsend <dtownsend@oxymoronical.com> - Tue, 04 Jun 2019 13:23:04 -0700 - rev 477575
Push 113361 by dtownsend@mozilla.com at Thu, 06 Jun 2019 18:41:10 +0000
Bug 1556829: Convert version numbers larger or smaller than the 32-bit limit to 0. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D33700
fc21b0bcbf127471f27c92a10554ba27eba01d95: Bug 1556831: Have safe mode write out the normal compatibility version. r=froydnj
Dave Townsend <dtownsend@oxymoronical.com> - Tue, 04 Jun 2019 09:57:59 -0700 - rev 477571
Push 113357 by dtownsend@mozilla.com at Thu, 06 Jun 2019 18:15:28 +0000
Bug 1556831: Have safe mode write out the normal compatibility version. r=froydnj When launching into safe mode we write out a compatibility.ini with an invalid compatibility version in it. This is to ensure that on the next startup we flush the caches. This is unnecessary though, we already have a flag we can set in compatibility.ini in order to request a flush on next startup. This patch switches to doing that so the version check on startup continues to work. Differential Revision: https://phabricator.services.mozilla.com/D33699
eca88f6069a7859a93bf064f8274a4df919091c0: Bug 1557164 - Don't use integrated assembler with clang on mips*. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Thu, 06 Jun 2019 00:46:18 +0000 - rev 477546
Push 113351 by shindli@mozilla.com at Thu, 06 Jun 2019 10:13:05 +0000
Bug 1557164 - Don't use integrated assembler with clang on mips*. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D33865
d779cd26a8f09726eaf210bb4bcf7b6c62724c33: Bug 1556612: Hardcode considering this an upgrade if the last build to run was run in safe mode. r=froydnj
Dave Townsend <dtownsend@oxymoronical.com> - Wed, 05 Jun 2019 16:17:16 +0000 - rev 477465
Push 113340 by aiakab@mozilla.com at Wed, 05 Jun 2019 22:07:26 +0000
Bug 1556612: Hardcode considering this an upgrade if the last build to run was run in safe mode. r=froydnj When safe mode runs it writes out "Safe Mode" as the compatibility version (bug 1556831). Due to bug 1556832 and bug 1556829 this makes us think that the next run is a downgrade. This is the simplest possible fix that should be totally safe to upload to release. Differential Revision: https://phabricator.services.mozilla.com/D33698
94a2d681edb4edaca48c87c059e94db2fba2f954: Bug 1537586 - Address build failure with --disable-printing r=bobowen,froydnj
sotaro <sotaro.ikeda.g@gmail.com> - Wed, 05 Jun 2019 01:25:36 +0000 - rev 477377
Push 113327 by malexandru@mozilla.com at Wed, 05 Jun 2019 10:00:10 +0000
Bug 1537586 - Address build failure with --disable-printing r=bobowen,froydnj Make nsIWebBrowserPrint included unconditionally for addressing nsIDocShell.rs build failure. Remove direct_call of PPrinting and PRemotePrintJob. Their ipdl are built unconditionally, but their derived classes are not built with --disable-printing. Differential Revision: https://phabricator.services.mozilla.com/D33391
11427e893b96e3342f524b80e6bcbac7e4200499: Bug 1555530 - Don't use integrated assembler with clang on ppc64 and s390x. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Wed, 05 Jun 2019 00:34:33 +0000 - rev 477373
Push 113327 by malexandru@mozilla.com at Wed, 05 Jun 2019 10:00:10 +0000
Bug 1555530 - Don't use integrated assembler with clang on ppc64 and s390x. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D33728
7f6e7c86447a946fc2ee19a43e2228edd1bf4bd0: Bug 1539806 - Hook zydis into our source code and build system. r=froydnj
Lars T Hansen <lhansen@mozilla.com> - Tue, 02 Apr 2019 12:43:08 +0200 - rev 476711
Push 113308 by lhansen@mozilla.com at Tue, 04 Jun 2019 10:01:59 +0000
Bug 1539806 - Hook zydis into our source code and build system. r=froydnj This changes check_spidermonkey_style.py to account for Zydis and makes the spidermonkey moz.build aware of the one in zydis. Differential Revision: https://phabricator.services.mozilla.com/D27850
c44e595b046835b68df9613a068d745c437a5993: Bug 1539806 - Incorporate the Zydis disassembler source. r=froydnj, r=mhoye
Lars T Hansen <lhansen@mozilla.com> - Tue, 02 Apr 2019 10:44:54 +0200 - rev 476710
Push 113308 by lhansen@mozilla.com at Tue, 04 Jun 2019 10:01:59 +0000
Bug 1539806 - Incorporate the Zydis disassembler source. r=froydnj, r=mhoye The Zydis disassembler is a configurable MIT-licensed decoder and formatter for x64 and x86. The code comes from two github repositories: https://github.com/zyantific/zydis https://github.com/zyantific/zycore-c In accompanying licensing material (included in this patch) the authors are identified as these: Copyright (c) 2014-2019 Florian Bernd Copyright (c) 2014-2019 Joel Höner We will use Zydis to disassemble code generated by the Cranelift JIT. This source has been taken from the master branch of Zydis on github and incorporated here in the manner described in README.md in this directory. Effectively: a subset of files have been incorporated and the files are in new locations in a flatter tree. README.md has instructions for repeating the job. The files in the root Zydis directory js/src/zydis are largely authored by me but in some cases incorporate code from the Zydis repository on github and are therefore given a Zydis copyright when appropriate.
23f5c0544d7bd2e6ceab83657a63e85c9c95ff85: Bug 1527371 - Show linker time breakdown for xul.dll r=froydnj
David Major <dmajor@mozilla.com> - Fri, 31 May 2019 17:13:34 +0000 - rev 476633
Push 113305 by cbrindusan@mozilla.com at Tue, 04 Jun 2019 03:54:43 +0000
Bug 1527371 - Show linker time breakdown for xul.dll r=froydnj COFF-flavored lld collects timing stats about various phases of linking. This might be useful to have in logs. I left it off in developer builds to avoid spamming tight edit-compile cycles. Differential Revision: https://phabricator.services.mozilla.com/D33319
3e9737d36c9608a4a4774df49a4c84492bb41bcc: Bug 1556257 - Add Funtoo support to mach bootstrap. r=froydnj
Jeremy Lempereur <jeremy.lempereur@gmail.com> - Mon, 03 Jun 2019 01:15:09 +0000 - rev 476612
Push 113305 by cbrindusan@mozilla.com at Tue, 04 Jun 2019 03:54:43 +0000
Bug 1556257 - Add Funtoo support to mach bootstrap. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D33425
fa8fbc9069ea5269d565e849950e115797195a1b: Bug 1555917 - Exception handler and crash reporter client cleanup r=froydnj
Gabriele Svelto <gsvelto@mozilla.com> - Fri, 31 May 2019 21:54:03 +0000 - rev 476532
Push 113288 by ncsoregi@mozilla.com at Sat, 01 Jun 2019 21:38:17 +0000
Bug 1555917 - Exception handler and crash reporter client cleanup r=froydnj This patch includes multiple changes cleaning up various aspects of the crash reporter client and exception handler: * Some Unix-specific code was moved out from the base crashreporter client code and into the appropriate platform implementation * Functions used to open files in the crashreporter client now accept C++ `std::ios` flags instead of unreadable booleans * Useless character conversion routines were removed from the minidump-analyzer * Crash annotations are not serialized into a huge string anymore every time they change. They are all written out individually during an exception. * `WriteEscapedMozCrashReason()` uses the exception-safe `my_strlen()` instead of plain `strlen()` * The Windows-specific DLL-blocklist shutdown was removed from the Linux & macOS Breakpad callbacks * The `CrashReporterHost`, `CrashReporterClient` and `CrashReporterMetadataShmem` classes now take `nsACString` references instead of `nsCString` ones since they never modify their contents Differential Revision: https://phabricator.services.mozilla.com/D33267
57fd8dc8fcddc2f7aa36b4e8f971b6f6b171b7a1: Bug 1555117: Ignore attempts to reset the profile when a new profile had to be created for the install. r=froydnj
Dave Townsend <dtownsend@oxymoronical.com> - Fri, 31 May 2019 16:49:56 +0000 - rev 476456
Push 113285 by aiakab@mozilla.com at Fri, 31 May 2019 22:31:43 +0000
Bug 1555117: Ignore attempts to reset the profile when a new profile had to be created for the install. r=froydnj Since bug 1518587 when a command line argument or environment variable requests a profile refresh but no existing profile is selected we would just exit thinking that there is some problem here. But it turns out that the installer sometimes passes this argument when it doesn't know that the new install will not use the existing profiles. So instead we just ignore attempts to refresh when we create a new profile. To do this we just have to remove the checks that bail out and continue to create the new profile, nsAppRunner will see that a new profile has been created and cancel the attempted refresh anyway: https://searchfox.org/mozilla-central/rev/ddb81c7a43ffada1f6cb4200c4f625e50e44dcf3/toolkit/xre/nsAppRunner.cpp#2021 Differential Revision: https://phabricator.services.mozilla.com/D32891
93ae54d47ca448966196d502670b0cfc771a4ef2: Bug 1196094 - use e10s when doing PGO profiling, r=froydnj
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Fri, 31 May 2019 14:18:05 +0000 - rev 476436
Push 113285 by aiakab@mozilla.com at Fri, 31 May 2019 22:31:43 +0000
Bug 1196094 - use e10s when doing PGO profiling, r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D32329
4b78f4fb473c487bb403987db4cbe011426ccb42: Bug 1196094 - disable _exit in child processes when generating profile information, r=froydnj
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Fri, 31 May 2019 14:17:47 +0000 - rev 476435
Push 113285 by aiakab@mozilla.com at Fri, 31 May 2019 22:31:43 +0000
Bug 1196094 - disable _exit in child processes when generating profile information, r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D33269
34cd2957213ea88d524d2daacf15fb56f55bca7c: Bug 1508976 - Post: Include all targets in about:buildconfig in GeckoView fat AAR. r=froydnj
Nick Alexander <nalexander@mozilla.com> - Thu, 30 May 2019 15:22:28 +0000 - rev 476237
Push 113262 by nbeleuzu@mozilla.com at Thu, 30 May 2019 21:52:09 +0000
Bug 1508976 - Post: Include all targets in about:buildconfig in GeckoView fat AAR. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D15773
e9cddb23f947853bffeb1cac51cbcadcc3e294e8: Bug 1553363 - Generalize the *_impl goop for allocation functions in mozglue. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Wed, 29 May 2019 22:49:42 +0000 - rev 476154
Push 113250 by shindli@mozilla.com at Thu, 30 May 2019 03:52:44 +0000
Bug 1553363 - Generalize the *_impl goop for allocation functions in mozglue. r=froydnj The current situation is suboptimal, where we have the same goop repeated in multiple files, and where things kinda sorta work out fine thanks to the linker for files that would have been forbidden, except when the linker doesn't do its job, which apparently happen on mingwclang builds. This change only really covers C++ code using operator new/delete, and not things that would be using malloc/free, because it's easier. malloc/free is left for a followup. Differential Revision: https://phabricator.services.mozilla.com/D32119
0a53924e724918efd09679b74fd3f48b737084bd: Bug 1552080 - Rejigger a bit rust features so that rusttests still link. r=froydnj
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 27 May 2019 14:56:08 +0200 - rev 476120
Push 113250 by shindli@mozilla.com at Thu, 30 May 2019 03:52:44 +0000
Bug 1552080 - Rejigger a bit rust features so that rusttests still link. r=froydnj We cannot compile with just feature(gecko + debug_assertions), since that's how debug rusttests get compiled and they don't have the refcount logging stuff. We were getting away with it for the pre-existing usage of the style crate, because it wasn't used during any test and presumably the linker didn't complain. But servo_arc is definitely used in tests. Differential Revision: https://phabricator.services.mozilla.com/D32691
3bff8c732fb4e011627822d2033e436273e035af: Bug 1554006 - Update builders to rustc 1.35. r=froydnj
Chris Manchester <cmanchester@mozilla.com> - Wed, 29 May 2019 16:05:13 +0000 - rev 476090
Push 113247 by shindli@mozilla.com at Wed, 29 May 2019 21:58:37 +0000
Bug 1554006 - Update builders to rustc 1.35. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D32932
c6c250b477a0fb9ce3f61f0b5067c49f79cc8a2c: Bug 1554006 - Bump max OOM hook version for the rust update to 1.35. r=froydnj
Chris Manchester <cmanchester@mozilla.com> - Wed, 29 May 2019 16:01:37 +0000 - rev 476087
Push 113247 by shindli@mozilla.com at Wed, 29 May 2019 21:58:37 +0000
Bug 1554006 - Bump max OOM hook version for the rust update to 1.35. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D32931
6d643940d96eff4a21d25146b03898f1ffc36128: bug 1555110 - Backed out changeset a187487af38a to disable cert_storage on non-nightly builds r=jcj,froydnj
Dana Keeler <dkeeler@mozilla.com> - Wed, 29 May 2019 00:11:53 +0000 - rev 475972
Push 113240 by nerli@mozilla.com at Wed, 29 May 2019 09:56:33 +0000
bug 1555110 - Backed out changeset a187487af38a to disable cert_storage on non-nightly builds r=jcj,froydnj There are ongoing lmdb issues we need to sort out before we can ship cert_storage (see e.g. bug 1538541 and bug 1550174). Differential Revision: https://phabricator.services.mozilla.com/D32885
a47c0e5f3520d3ffed8cd580cd25c90089508e83: Bug 1554029: Downgrade detection fails for changes from non-minor to minor versions. r=froydnj
Dave Townsend <dtownsend@oxymoronical.com> - Tue, 28 May 2019 19:21:23 +0000 - rev 475963
Push 113240 by nerli@mozilla.com at Wed, 29 May 2019 09:56:33 +0000
Bug 1554029: Downgrade detection fails for changes from non-minor to minor versions. r=froydnj We build compatibility versions as `<appversion>_<appbuildid>/<platformbuildid>`. where the build ID's by default are a numeric representation of the date that the build happened. Previously we attempted to mangle this into a valid toolkit version by converting to `<appversion>.<appbuildid>.<platformbuildid>` if the build IDs were the expected length. We also split each build ID into two version parts since the version comparator couldn't handle their full size. This mangling fails when comparing a major version with a new patch version: `<majorversion>.<appbuildid>.<platformbuildid>` gets compared to `<majorversion>.1.<appbuildid>.<platformbuildid>`. Unless that patch version (1 here) was greater than the build ID (currently in the tens of millions) the patch release would appear to be older than the previous version. This changes this so rather than attempting to mangle the entire string into a single toolkit version we split out the string into their components. First we compare the app versions using the version comparator which is definitely the correct thing to do. For the build IDs we check if they are entirely numeric (which is the case for the date based default) and if so just compare them numerically. We assume that if the IDs aren't numeric then they are something defined by a custom build of Firefox, we can't know what form that takes so I've chosen to fallback to just using the version comparator since it will handle things such as `"build1" < "build10"` and it should be straightforward for anything more complex to choose a form that works. Differential Revision: https://phabricator.services.mozilla.com/D32552
258c332f0058feb9706055b6ba30c73f6dcd2857: Bug 1554029: Downgrade detection fails for changes from non-minor to minor versions. r=froydnj
Dave Townsend <dtownsend@oxymoronical.com> - Fri, 24 May 2019 14:16:55 -0700 - rev 475930
Push 113239 by dtownsend@mozilla.com at Wed, 29 May 2019 02:55:37 +0000
Bug 1554029: Downgrade detection fails for changes from non-minor to minor versions. r=froydnj We build compatibility versions as `<appversion>_<appbuildid>/<platformbuildid>`. where the build ID's by default are a numeric representation of the date that the build happened. Previously we attempted to mangle this into a valid toolkit version by converting to `<appversion>.<appbuildid>.<platformbuildid>` if the build IDs were the expected length. We also split each build ID into two version parts since the version comparator couldn't handle their full size. This mangling fails when comparing a major version with a new patch version: `<majorversion>.<appbuildid>.<platformbuildid>` gets compared to `<majorversion>.1.<appbuildid>.<platformbuildid>`. Unless that patch version (1 here) was greater than the build ID (currently in the tens of millions) the patch release would appear to be older than the previous version. This changes this so rather than attempting to mangle the entire string into a single toolkit version we split out the string into their components. First we compare the app versions using the version comparator which is definitely the correct thing to do. For the build IDs we check if they are entirely numeric (which is the case for the date based default) and if so just compare them numerically. We assume that if the IDs aren't numeric then they are something defined by a custom build of Firefox, we can't know what form that takes so I've chosen to fallback to just using the version comparator since it will handle things such as `"build1" < "build10"` and it should be straightforward for anything more complex to choose a form that works. Differential Revision: https://phabricator.services.mozilla.com/D32552
b5ef7dff7b38ae2a1ad24839728de132df882710: Bug 1555179: Use 0 in place of out of range numbers in version comparisons. r=froydnj
Dave Townsend <dtownsend@oxymoronical.com> - Tue, 28 May 2019 16:37:45 -0700 - rev 475929
Push 113239 by dtownsend@mozilla.com at Wed, 29 May 2019 02:55:37 +0000
Bug 1555179: Use 0 in place of out of range numbers in version comparisons. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D32926
2b3b18ec9bf0aa3e210354fa3d4f4b36f1de378b: Bug 1554039 - Add some missing debug info to the valgrind docker image. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Fri, 24 May 2019 13:38:51 +0000 - rev 475784
Push 113228 by dluca@mozilla.com at Tue, 28 May 2019 09:48:00 +0000
Bug 1554039 - Add some missing debug info to the valgrind docker image. r=froydnj Some debug info for system packages are not available to valgrind in the valgrind docker image, some of which are for libraries actively used by Firefox. Not all of them, unfortunately, have debug info available, but some of them do and we add them all. We could skip a few that are not really useful, but that doesn't make a significant difference to the docker image size (~0.3%). Differential Revision: https://phabricator.services.mozilla.com/D32419
8b110b9889c34d70465d2a2b98b1747ae03f3c3f: Bug 1196094 - use e10s when doing PGO profiling, r=froydnj
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Mon, 27 May 2019 09:05:21 +0000 - rev 475701
Push 113228 by dluca@mozilla.com at Tue, 28 May 2019 09:48:00 +0000
Bug 1196094 - use e10s when doing PGO profiling, r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D32329
70f7e631e8c7869e8e90fd02fad994a284002882: Bug 1552643 - P3. rename medium_high_event_queue.enabled pref. r=froydnj
Jean-Yves Avenard <jyavenard@mozilla.com> - Sun, 26 May 2019 15:00:09 +0000 - rev 475632
Push 113215 by ccoroiu@mozilla.com at Sun, 26 May 2019 21:21:21 +0000
Bug 1552643 - P3. rename medium_high_event_queue.enabled pref. r=froydnj To make it more inline other preferences naming. Differential Revision: https://phabricator.services.mozilla.com/D32251
04a96dcba578937dee05b09d7eb431d507768345: Bug 1554162 - Enable ESLint for startupcache/. r=froydnj
Mark Banner <standard8@mozilla.com> - Sat, 25 May 2019 02:07:26 +0000 - rev 475568
Push 113210 by dvarga@mozilla.com at Sat, 25 May 2019 21:41:26 +0000
Bug 1554162 - Enable ESLint for startupcache/. r=froydnj Depends on D32493 Differential Revision: https://phabricator.services.mozilla.com/D32494
e30c1aa75529e8920aeec4030db6f348397d11fd: Bug 1552643 - P3. rename medium_high_event_queue.enabled pref. r=froydnj
Jean-Yves Avenard <jyavenard@mozilla.com> - Sat, 25 May 2019 02:03:21 +0000 - rev 475542
Push 113209 by aciure@mozilla.com at Sat, 25 May 2019 09:44:12 +0000
Bug 1552643 - P3. rename medium_high_event_queue.enabled pref. r=froydnj To make it more inline other preferences naming. Differential Revision: https://phabricator.services.mozilla.com/D32251
15293a40e833a9b6159d7e4114f7167a3a39e85b: Bug 1553270 - Part 2: Allow getting a protocol's name from its ProtocolID, r=froydnj
Nika Layzell <nika@thelayzells.com> - Fri, 24 May 2019 22:36:49 +0000 - rev 475506
Push 113209 by aciure@mozilla.com at Sat, 25 May 2019 09:44:12 +0000
Bug 1553270 - Part 2: Allow getting a protocol's name from its ProtocolID, r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D32043
c93779f1157a9bb1579e9ea09ac316bf29a9f332: Bug 1553270 - Part 1: Store the protocol ID on IProtocol directly, r=froydnj
Nika Layzell <nika@thelayzells.com> - Fri, 24 May 2019 20:21:35 +0000 - rev 475505
Push 113209 by aciure@mozilla.com at Sat, 25 May 2019 09:44:12 +0000
Bug 1553270 - Part 1: Store the protocol ID on IProtocol directly, r=froydnj This allows for the getter to be used in IProtocol's destructor, and generally brings IProtocol more in line with IToplevelProtocol. Differential Revision: https://phabricator.services.mozilla.com/D32042
23783673beca86fe55fac7ef985dea39dabb49ab: Bug 1553856: LazyIdleThread should set names for the nsThreads it spawns r=froydnj
Randell Jesup <rjesup@wgate.com> - Fri, 24 May 2019 12:50:05 +0000 - rev 475434
Push 113209 by aciure@mozilla.com at Sat, 25 May 2019 09:44:12 +0000
Bug 1553856: LazyIdleThread should set names for the nsThreads it spawns r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D32385
cd5d8525541fc8a324498043cc250a87632dc72a: Bug 1471698 - Remove our binutils-corruption-avoiding workaround for mingw-clang r=froydnj
Tom Ritter <tom@mozilla.com> - Wed, 22 May 2019 13:40:36 +0000 - rev 475297
Push 113198 by aciure@mozilla.com at Fri, 24 May 2019 04:03:55 +0000
Bug 1471698 - Remove our binutils-corruption-avoiding workaround for mingw-clang r=froydnj Depends on D31347 Differential Revision: https://phabricator.services.mozilla.com/D31349
61ae24d322cb05bec32cf7620778f15a2e6908e5: Bug 1552549 - Update rand dependency to 0.6 r=kats,froydnj,nika,jkt,jcj
Dzmitry Malyshau <dmalyshau@mozilla.com> - Thu, 23 May 2019 19:54:25 +0000 - rev 475288
Push 113198 by aciure@mozilla.com at Fri, 24 May 2019 04:03:55 +0000
Bug 1552549 - Update rand dependency to 0.6 r=kats,froydnj,nika,jkt,jcj Update rand version in u2fhid and xpcom Differential Revision: https://phabricator.services.mozilla.com/D31669
44b529f579ea09f0955fdc16b34999350860f526: Bug 1553567: Use MaxValue to initialize/reset nsThread::mCurrentEventLoopDepth, not -1. r=froydnj
Jim Blandy <jimb@mozilla.com> - Thu, 23 May 2019 10:22:57 +0000 - rev 475205
Push 113196 by aciure@mozilla.com at Thu, 23 May 2019 22:38:40 +0000
Bug 1553567: Use MaxValue to initialize/reset nsThread::mCurrentEventLoopDepth, not -1. r=froydnj Since the purpose of mCurrentEventLoopDepth is to be ordered in comparison with mNestedEventLoopDepth, it's a bit deceptive to give it a value that would appear to be less than any reasonable depth but is, because the variables in question are unsigned, actually greater than any reasonable depth. Using mozilla::MaxValue<uint32_t>::value is clearer. Differential Revision: https://phabricator.services.mozilla.com/D32198
ef47b8762dab330849f0c375f52f8a687e19fe78: Bug 1553116 - Get the arm64 hardening flag out of the way of l10n builds r=froydnj
David Major <dmajor@mozilla.com> - Thu, 23 May 2019 10:23:04 +0000 - rev 475195
Push 113196 by aciure@mozilla.com at Thu, 23 May 2019 22:38:40 +0000
Bug 1553116 - Get the arm64 hardening flag out of the way of l10n builds r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D32165
7a5f5a8174f74faf91e6be592b0047936b3d7ae9: Bug 1530650 - Add --cap-lints warn to RUSTFLAGS when not building with --enable-warnings-as-errors. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Wed, 22 May 2019 12:59:01 +0000 - rev 475083
Push 113193 by dvarga@mozilla.com at Thu, 23 May 2019 16:04:39 +0000
Bug 1530650 - Add --cap-lints warn to RUSTFLAGS when not building with --enable-warnings-as-errors. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D32080
a234872a4356abb2002ce4d4a04467a983d3dc8e: Bug 1551842 - Add new clang-tidy checkers from clang 8.0.0. r=sylvestre,froydnj
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Wed, 22 May 2019 14:55:45 +0000 - rev 475027
Push 113187 by btara@mozilla.com at Thu, 23 May 2019 04:45:24 +0000
Bug 1551842 - Add new clang-tidy checkers from clang 8.0.0. r=sylvestre,froydnj Differential Revision: https://phabricator.services.mozilla.com/D31229
56fea0bcb2c46e4f2fee062479799f491f5f0a29: Bug 1553226 - Don't attempt to read annotations associated with Flash process crashes r=froydnj
Gabriele Svelto <gsvelto@mozilla.com> - Wed, 22 May 2019 13:04:41 +0000 - rev 475008
Push 113187 by btara@mozilla.com at Thu, 23 May 2019 04:45:24 +0000
Bug 1553226 - Don't attempt to read annotations associated with Flash process crashes r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D32133
dafb8769ab4899016e24b7b30f0014918c3ec943: Bug 1553037 - clang-based disable static-analysis in `MOZ_REALLY_CRASH`. r=froydnj
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Wed, 22 May 2019 12:50:43 +0000 - rev 475004
Push 113187 by btara@mozilla.com at Thu, 23 May 2019 04:45:24 +0000
Bug 1553037 - clang-based disable static-analysis in `MOZ_REALLY_CRASH`. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D32132
7de6c5aab8b4ee7d66e5080b2cefc2a1123dbef9: Bug 1471698 - Remove our binutils-corruption-avoiding workaround for mingw-clang r=froydnj
Tom Ritter <tom@mozilla.com> - Tue, 21 May 2019 17:57:06 +0000 - rev 474999
Push 113187 by btara@mozilla.com at Thu, 23 May 2019 04:45:24 +0000
Bug 1471698 - Remove our binutils-corruption-avoiding workaround for mingw-clang r=froydnj Depends on D31347 Differential Revision: https://phabricator.services.mozilla.com/D31349