searching for reviewer(froydnj)
635be62762b9f8fa94f3cb38e81d356a6b8f22bb: Bug 1596953 - Add valgrind to android-build image. r=froydnj
Jesse Schwartzentruber <truber@mozilla.com> - Mon, 18 Nov 2019 20:38:11 +0000 - rev 502484
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1596953 - Add valgrind to android-build image. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D53287
855640e1c096c294c882261ee141b6ce4689d0b8: Bug 1596562: Add ParamTraits specializations for mozilla::Vector and std::vector; r=froydnj,bwc
Aaron Klotz <aklotz@mozilla.com> - Mon, 18 Nov 2019 19:45:41 +0000 - rev 502461
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1596562: Add ParamTraits specializations for mozilla::Vector and std::vector; r=froydnj,bwc While the need for adding `mozilla::Vector` is self-evident, we also need `std::vector` so that we can send some pre-existing telemetry data structures that use it. The new implementations are basically modified from the `nsTArray` specializations. Note that the `mozilla::Vector` specialization does support any type of allocator, so we still check for OOM failures in that case. This patch also removes the specialization for `std::vector` that lives in WebRTC in favour of the centralized implementation. Differential Revision: https://phabricator.services.mozilla.com/D53085
65114b5cb9ee40f8f8a168e56b090ddad54f9465: Bug 1564083: The profile command line argument should match a profile with the same root directory and use its local directory. r=froydnj
Dave Townsend <dtownsend@oxymoronical.com> - Mon, 18 Nov 2019 19:27:51 +0000 - rev 502458
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1564083: The profile command line argument should match a profile with the same root directory and use its local directory. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D52736
eb382c9e27fb60efddc8061d9e2837f33056cf33: Bug 1597150 - Bump RLBox library to the latest version. r=froydnj
shravanrn@gmail.com <shravanrn@gmail.com> - Mon, 18 Nov 2019 18:24:44 +0000 - rev 502448
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1597150 - Bump RLBox library to the latest version. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D53374
1603f5abc56e6c2483e46ce577f6450e4c58733b: Bug 1420363 - Write crash annotations as JSON r=froydnj,agi
Gabriele Svelto <gsvelto@mozilla.com> - Sat, 16 Nov 2019 08:29:07 +0000 - rev 502316
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1420363 - Write crash annotations as JSON r=froydnj,agi This patch rolls up all the required changes for this purpose. Since the whole crash reporting flow must understand the new format it's not possible to land this as separate patches as individually they would be broken. This patch includes the following changes: * Changes to the crash reporting machinery to write out annotations as JSON, these includes changes to the DLL blocklist code that must be run at crash time. * Modifications to the crash reporter client so that it can read and submit the new format; this includes platform-specific changes to the Breakpad libraries it uses for submitting crashes. * Modifications to the minidump-analyzer to understand and process the new format correctly. * Modifications to the crash manager to understand and process the new format correctly. * Modifications to GeckoView's crash handler to understand and submit the new format correctly. * Added new tests to cover the new format and modified existing ones to accomodate the new one. Differential Revision: https://phabricator.services.mozilla.com/D46848
5258157edfeea095a4d96b65f819e2b6143af6c0: Bug 1595629 - Note intentional crashes in NS_DEBUG_ABORT and nsTerminator. r=froydnj
Andrew McCreight <continuation@gmail.com> - Sat, 16 Nov 2019 01:38:22 +0000 - rev 502309
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1595629 - Note intentional crashes in NS_DEBUG_ABORT and nsTerminator. r=froydnj This will prevent the leak checker from reporting a missing log for that process, which results in incorrect starring on TreeHerder. Both of these failures should be detected as a failure. Differential Revision: https://phabricator.services.mozilla.com/D53095
4d53b9239b4ab051163f46a826e1497242214d5b: Bug 1594998 - Make standalone SpiderMonkey use libxul-like panic. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Fri, 15 Nov 2019 13:14:42 +0000 - rev 502294
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1594998 - Make standalone SpiderMonkey use libxul-like panic. r=froydnj This moves the parts of toolkit/library/rust/shared/lib.rs related to panic hooking to a new mozglue subdirectory, which will be used for things that can be statically linked to e.g. libxul, rather than in a "shared library". The panic hook is disabled when building spidermonkey via the mozjs_sys crate. Differential Revision: https://phabricator.services.mozilla.com/D52793
bd42216f7b6309c683bcc8d9d63c26a834d08d04: Bug 1594577 - Record hangs which precede forced shutdowns r=froydnj
Doug Thayer <dothayer@mozilla.com> - Thu, 14 Nov 2019 21:35:42 +0000 - rev 502283
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1594577 - Record hangs which precede forced shutdowns r=froydnj In short - if a user forcibly terminates the browser because it seems to be permanently hung, we currently do not get a change to record the hang. This is unfortunate, because these likely represent the most egregious hangs in terms of user frustration. This patch seeks to address that. If a hang exceeds 8192ms (the current definition of a "permahang" in existing BHR terms), then we decide to immediately persist it to disk, in case we never get a chance to return to the main thread and submit it. On the next start of the browser, we read the file from disk on a background thread, and just submit it using the normal mechanism. Regarding the handling of the file itself, I tried to do the simplest thing I could - as far as I can tell there is no standard simple serialization mechanism available directly to C++ in Gecko, so I just serialized it by hand. I didn't take any special care with endianness or anything as I can't think of a situation in which we really care at all about these files being transferable between architectures. I directly used PR_Write / PR_Read instead of doing something fancy like memory mapping the file, because I don't think performance is a critical concern here and it offers a simple protection against reading out of bounds. Differential Revision: https://phabricator.services.mozilla.com/D52566
7b0f2fb77033c4eb66cd8ffbfdf7dcc52b7802eb: Bug 1596573 - Correct the documentation for custom use counters; r=froydnj
Edgar Chen <echen@mozilla.com> - Fri, 15 Nov 2019 13:39:13 +0000 - rev 502172
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1596573 - Correct the documentation for custom use counters; r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D53083
2412ec5c8ea76986e25a3620774c41f4416381c4: Bug 838896 - Increase the crash reporter client comment size limit to 10000 characters; r=froydnj
Gabriele Svelto <gsvelto@mozilla.com> - Fri, 15 Nov 2019 13:49:55 +0000 - rev 502169
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 838896 - Increase the crash reporter client comment size limit to 10000 characters; r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D53154
f6bcd354c056b2a8cabae55a656fb0f38eb01664: Bug 1594656 - Don't display seccomp-bpf info on non-Linux. r=jld,froydnj
Gian-Carlo Pascutto <gcp@mozilla.com> - Fri, 15 Nov 2019 09:34:36 +0000 - rev 502125
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1594656 - Don't display seccomp-bpf info on non-Linux. r=jld,froydnj Differential Revision: https://phabricator.services.mozilla.com/D53034
7a28c229e654d10ca9ab630e42753954390e67a7: Bug 1594998 - Make standalone SpiderMonkey use libxul-like panic. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Fri, 15 Nov 2019 00:21:32 +0000 - rev 502089
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1594998 - Make standalone SpiderMonkey use libxul-like panic. r=froydnj This moves the parts of toolkit/library/rust/shared/lib.rs related to panic hooking to a new mozglue subdirectory, which will be used for things that can be statically linked to e.g. libxul, rather than in a "shared library". The panic hook is disabled when building spidermonkey via the mozjs_sys crate. Differential Revision: https://phabricator.services.mozilla.com/D52793
d519e5920a23a531269fec72a0ef440674692603: Bug 1487212 - When hyphenation resources are compressed in omnijar, load them into shared memory and share among all content processes. r=heycam,froydnj
Jonathan Kew <jkew@mozilla.com> - Thu, 14 Nov 2019 20:05:58 +0000 - rev 502059
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1487212 - When hyphenation resources are compressed in omnijar, load them into shared memory and share among all content processes. r=heycam,froydnj Differential Revision: https://phabricator.services.mozilla.com/D52835
7a519aeac6438c53c2eec583b75a25f12dbf695c: Bug 1596341 - Fix nasm putting garbage in the .debug_loc section on elf32. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Thu, 14 Nov 2019 20:59:03 +0000 - rev 502049
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1596341 - Fix nasm putting garbage in the .debug_loc section on elf32. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D52972
868a55980ae8e0f6bda936e9a5c0cbb2311a5717: Bug 1595906 - Allow opting out of hardening compile flags on a granular basis r=froydnj
Ricky Stewart <rstewart@mozilla.com> - Thu, 14 Nov 2019 17:13:28 +0000 - rev 502006
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1595906 - Allow opting out of hardening compile flags on a granular basis r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D52756
512d489d83e128358c960823d75b22bd59cb7163: Bug 1582297 - Suppress IPC "pipe error" messages if the cause was probably the other process exiting. r=froydnj
Jed Davis <jld@mozilla.com> - Tue, 12 Nov 2019 21:04:40 +0000 - rev 502002
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1582297 - Suppress IPC "pipe error" messages if the cause was probably the other process exiting. r=froydnj There are two issues here: 1. These error messages occur even during normal channel shutdown, because that's tracked in the mozilla::ipc::MessageChannel layer, which the ipc/chromium code can't access. 2. If we get this kind of error when the channel wasn't intentionally closed, it almost certainly means that the other process crashed. In that case, having error messages from a different process and a likely unrelated subsystem just leads to confusion and misfiled bugs. (Also complicating things: on Unix a closed channel often, but not always, results in an end-of-file indication, which already isn't logged; on Windows it's always a broken pipe error, which causes a much larger amount of log spam.) Bonus fix: the error that contains a fd number is clarified to avoid having it mistaken for an error code. Differential Revision: https://phabricator.services.mozilla.com/D52727
8b0098a03143ee4f81ae2f78d31ac960a62c1a8c: Bug 1596276 - Switch Linux coverage opt builds to use GCC 7. r=froydnj
Marco Castelluccio <mcastelluccio@mozilla.com> - Thu, 14 Nov 2019 15:52:26 +0000 - rev 501970
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1596276 - Switch Linux coverage opt builds to use GCC 7. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D52935
23293a56f4790a29a30f35739c4ad72c60d74ff2: Bug 1596244 - Report a fake leak instead of crashing if NSS fails to shut down. r=froydnj,keeler
Andrew McCreight <continuation@gmail.com> - Thu, 14 Nov 2019 14:51:53 +0000 - rev 501941
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1596244 - Report a fake leak instead of crashing if NSS fails to shut down. r=froydnj,keeler Some kinds of leaks prevent NSS to not shut down properly, and right now if that happens we crash. This interferes with our existing leak checking code, so in this patch I make it not crash if we are already leak checking. The failure is reported as a fake leak, so the test should still fail when testing. Differential Revision: https://phabricator.services.mozilla.com/D52914
4cf8f3f89042f4622a349e2fd75a849155ffa75b: Bug 1594998 - Make standalone SpiderMonkey use libxul-like panic. r=froydnj,jandem
Mike Hommey <mh+mozilla@glandium.org> - Wed, 13 Nov 2019 22:07:08 +0000 - rev 501850
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1594998 - Make standalone SpiderMonkey use libxul-like panic. r=froydnj,jandem This moves the parts of toolkit/library/rust/shared/lib.rs related to panic hooking to a new mozglue subdirectory, which will be used for things that can be statically linked to e.g. libxul, rather than in a "shared library". The panic hook is disabled when building spidermonkey via the mozjs_sys crate. Differential Revision: https://phabricator.services.mozilla.com/D52793
351b6e9f017b4587adaaf4de0d2b209338f1a4a6: Bug 1595750 - Add MakeBackInserter function to create a back-inserting output iterator for nsTArray. r=froydnj
Simon Giesecke <sgiesecke@mozilla.com> - Wed, 13 Nov 2019 09:06:42 +0000 - rev 501724
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1595750 - Add MakeBackInserter function to create a back-inserting output iterator for nsTArray. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D52685
0dd20dae7caac58c51562d1ab9fd0b51792a8d2d: Bug 1591417: part 3) Add `nsTStringRepr<T>::EqualsLatin1`. r=froydnj
Mirko Brodesser <mbrodesser@mozilla.com> - Tue, 12 Nov 2019 15:20:25 +0000 - rev 501718
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1591417: part 3) Add `nsTStringRepr<T>::EqualsLatin1`. r=froydnj Needed to compare with `nsTextFragment::Get1b()` which returns latin1-encoded characters. Used in a subsequent review. Differential Revision: https://phabricator.services.mozilla.com/D52343
b98e3a2058c06d33994a43e5637009fc910968eb: Bug 1590907 - Remove obsolete macro MOZ_HAVE_BITSCAN64. r=froydnj
Philip Chimento <philip.chimento@gmail.com> - Tue, 12 Nov 2019 21:59:25 +0000 - rev 501681
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1590907 - Remove obsolete macro MOZ_HAVE_BITSCAN64. r=froydnj This macro seems to have been introduced in https://bugzilla.mozilla.org/attachment.cgi?id=772469&action=diff but there doesn't seem to be any mention of it anywhere else. Currently it's only checked in order to #undef it if it's defined. Differential Revision: https://phabricator.services.mozilla.com/D51770
7edb2cd99ae5d26020e939561d161ab7ea1dab2b: Bug 1595633 - Enable 'pointer-overflow' UBSan check. r=froydnj
Tyson Smith <twsmith@mozilla.com> - Tue, 12 Nov 2019 16:29:37 +0000 - rev 501598
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1595633 - Enable 'pointer-overflow' UBSan check. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D52608
65d0d0d8a021ac18665523c9488f017de79a2fea: Bug 1595828 - Fix some include guards. r=froydnj
Andrew McCreight <continuation@gmail.com> - Tue, 12 Nov 2019 17:27:20 +0000 - rev 501590
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1595828 - Fix some include guards. r=froydnj The formatting change presumably happens because clang-format treats include guards differently. Differential Revision: https://phabricator.services.mozilla.com/D52698
c96a028aaafa76b8a8ea4d5393f64f7781bae819: Bug 1595812 - Fix include guard in IntentionalCrash.h. r=froydnj
Andrew McCreight <continuation@gmail.com> - Tue, 12 Nov 2019 16:13:14 +0000 - rev 501589
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1595812 - Fix include guard in IntentionalCrash.h. r=froydnj The include guard needs to happen before any non-trivial tokens. I guess this change made clang-format decide the other ifdefs aren't actually nested, so it dropped the indents. Differential Revision: https://phabricator.services.mozilla.com/D52691
9b131da7e0ccbc84f00677481a3701e3a6264371: Bug 1595750 - Add MakeBackInserter function to create a back-inserting output iterator for nsTArray. r=froydnj
Simon Giesecke <sgiesecke@mozilla.com> - Tue, 12 Nov 2019 15:52:24 +0000 - rev 501588
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1595750 - Add MakeBackInserter function to create a back-inserting output iterator for nsTArray. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D52685
8984a9fbc4e0467503a14ea3f312c53327e4d21b: Bug 1595805 - Disable LTO on macosx fuzzy builds r=froydnj
Dzmitry Malyshau <dmalyshau@mozilla.com> - Tue, 12 Nov 2019 16:41:23 +0000 - rev 501587
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1595805 - Disable LTO on macosx fuzzy builds r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D52688
8d28c3108fc018c92e3af80254cef8671961e038: Bug 1583353 - [mozbuild.reader] Don't return root moz.build twice in 'all_mozbuild_paths', r=froydnj
Andrew Halberstadt <ahalberstadt@mozilla.com> - Tue, 05 Nov 2019 15:38:32 +0000 - rev 501568
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1583353 - [mozbuild.reader] Don't return root moz.build twice in 'all_mozbuild_paths', r=froydnj Despite what the comment says, the finder *does* pick up the root moz.build. So we end up processing it twice. This was never caught before because we only ever used this function to read Sphinx related variables, of which the root moz.build contains none. Differential Revision: https://phabricator.services.mozilla.com/D51832
5bd5020154a171493756d63edf6047a607994dc5: Bug 1562642 - add missing license in xpcom/ r=froydnj
Sylvestre Ledru <sledru@mozilla.com> - Mon, 11 Nov 2019 21:44:32 +0000 - rev 501554
Push 114170 by malexandru@mozilla.com at Tue, 12 Nov 2019 21:58:32 +0000
Bug 1562642 - add missing license in xpcom/ r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D52579
c7f52a048eeb736f701a09e398ea96bd64f825a3: Bug 1576051 - Vendor the the RLBox Lucet sandbox library and its dependencies r=froydnj
shravanrn@gmail.com <shravanrn@gmail.com> - Mon, 11 Nov 2019 09:19:52 +0000 - rev 501478
Push 114170 by malexandru@mozilla.com at Tue, 12 Nov 2019 21:58:32 +0000
Bug 1576051 - Vendor the the RLBox Lucet sandbox library and its dependencies r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D43709
fb230e0d5681a6d6b2a6e9c5036d8d0889642354: Bug 1572619 - Include RLBox Lucet integration repo to use wasm library sandboxes r=froydnj
shravanrn@gmail.com <shravanrn@gmail.com> - Mon, 11 Nov 2019 09:19:37 +0000 - rev 501477
Push 114170 by malexandru@mozilla.com at Tue, 12 Nov 2019 21:58:32 +0000
Bug 1572619 - Include RLBox Lucet integration repo to use wasm library sandboxes r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D43030
db942d515d8e34b57032187c6a08085a5a43a6d4: Bug 1576054 - Use forked rust/nix that removes references to newer libc functions setns, process_vm_writv, process_vm_readv. References to these functions create missing symbols in gkrust, which is configured to a build failure in Firefox r=froydnj
shravanrn@gmail.com <shravanrn@gmail.com> - Mon, 11 Nov 2019 09:19:29 +0000 - rev 501476
Push 114170 by malexandru@mozilla.com at Tue, 12 Nov 2019 21:58:32 +0000
Bug 1576054 - Use forked rust/nix that removes references to newer libc functions setns, process_vm_writv, process_vm_readv. References to these functions create missing symbols in gkrust, which is configured to a build failure in Firefox r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D44341
e847a6cb715f4ab4dbc0db13ec1bbad421809259: Bug 1583192 - Re-apply bug 1330495 after bug 1581145. r=froydnj
Jan Beich <jbeich@FreeBSD.org> - Mon, 11 Nov 2019 13:41:11 +0000 - rev 501472
Push 114170 by malexandru@mozilla.com at Tue, 12 Nov 2019 21:58:32 +0000
Bug 1583192 - Re-apply bug 1330495 after bug 1581145. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D52442
620c4222c7f31635da807e4e37b95b9bb56081d7: Bug 1572337: Don't call TimeStamp::Now() within SuspendAndSample r=froydnj
Randell Jesup <rjesup@wgate.com> - Fri, 08 Nov 2019 21:18:06 +0000 - rev 501373
Push 114169 by ncsoregi@mozilla.com at Mon, 11 Nov 2019 12:39:11 +0000
Bug 1572337: Don't call TimeStamp::Now() within SuspendAndSample r=froydnj Avoids deadlocks on Windows due to Now() taking a lock; if done while we've paused a thread that holds the lock we will deadlock. Differential Revision: https://phabricator.services.mozilla.com/D52392
ca47cdea9beb09443b0811c010db012abfefdd04: Bug 1594015: Ensure that threads with odd ProcessNextEvent loops get correct event delays r=froydnj
Randell Jesup <rjesup@wgate.com> - Fri, 08 Nov 2019 21:07:52 +0000 - rev 501369
Push 114169 by ncsoregi@mozilla.com at Mon, 11 Nov 2019 12:39:11 +0000
Bug 1594015: Ensure that threads with odd ProcessNextEvent loops get correct event delays r=froydnj Socket Thread and Worker Threads use custom event loops and don't wait in calls to ProcessNextEvent all the time; this can lead to odd Responsiveness numbers. Differential Revision: https://phabricator.services.mozilla.com/D51835
e25cefd5d1d17abef94cada5e8f37b8aa81c3010: Bug 1572337: Make GetRunningEventDelay handle threadpools r=froydnj
Randell Jesup <rjesup@wgate.com> - Fri, 08 Nov 2019 21:07:45 +0000 - rev 501368
Push 114169 by ncsoregi@mozilla.com at Mon, 11 Nov 2019 12:39:11 +0000
Bug 1572337: Make GetRunningEventDelay handle threadpools r=froydnj Threadpools run an event that then runs other events, so we need to tweak things for GetRunningEventDelay() Differential Revision: https://phabricator.services.mozilla.com/D44058
1eedae351266e7800e143d87a7e50aa163d9af50: Bug 1572337: Monitor running event delays and start times r=froydnj
Randell Jesup <rjesup@wgate.com> - Fri, 08 Nov 2019 21:07:36 +0000 - rev 501367
Push 114169 by ncsoregi@mozilla.com at Mon, 11 Nov 2019 12:39:11 +0000
Bug 1572337: Monitor running event delays and start times r=froydnj This lets us determine the time that an event has been running, and the time that the event spent queued - which can be used to figure out 'jank' at the time the event was queued. For PrioritizedEventQueues, only if such queuing would delay an input event then the queuing delay is reported. Differential Revision: https://phabricator.services.mozilla.com/D41279
efd3b5328173b4000d4c9e7cd6940870552a501a: Bug 1594839 - Enable 'integer-divide-by-zero' UBSan check. r=froydnj
Tyson Smith <twsmith@mozilla.com> - Fri, 08 Nov 2019 18:54:51 +0000 - rev 501333
Push 114168 by dluca@mozilla.com at Sun, 10 Nov 2019 03:08:55 +0000
Bug 1594839 - Enable 'integer-divide-by-zero' UBSan check. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D52218
268bb05a7a9a0984c6c2715e9ff76513bb96c5fc: Bug 1594051 - Perform fallible alloc when copying buffer from StartupCache r=froydnj
Doug Thayer <dothayer@mozilla.com> - Thu, 07 Nov 2019 20:00:48 +0000 - rev 501156
Push 114168 by dluca@mozilla.com at Sun, 10 Nov 2019 03:08:55 +0000
Bug 1594051 - Perform fallible alloc when copying buffer from StartupCache r=froydnj This effectively used to be a fallible alloc inside nsZipArchive. Differential Revision: https://phabricator.services.mozilla.com/D52199
40f4f1079552d8d5793bd82f141cf098e4cc2275: Bug 1513855: Make sure that quit-application-granted and quit-application notifications are always sent. r=froydnj
Dave Townsend <dtownsend@oxymoronical.com> - Thu, 07 Nov 2019 17:00:06 +0000 - rev 501118
Push 114168 by dluca@mozilla.com at Sun, 10 Nov 2019 03:08:55 +0000
Bug 1513855: Make sure that quit-application-granted and quit-application notifications are always sent. r=froydnj We only run the main event loop if at least one window is open. There are various cases where this doesn't happen, such as -silent. By the time we get there though some components have started and require appropriate notifications to tell them to shutdown safely. This patch sends the quit-application-granted and quit-application notifications in the case that there were no windows open and nsAppStartup::Quit hasn't already been called when we come to run the event loop. Differential Revision: https://phabricator.services.mozilla.com/D51736
36b9d7d55eaef1dec87bb58c0086e4fb6fb69a83: Bug 1593844 - Add moz.configure bits to specify a LUCETC binary r=froydnj
Ricky Stewart <rstewart@mozilla.com> - Thu, 07 Nov 2019 16:11:09 +0000 - rev 501107
Push 114168 by dluca@mozilla.com at Sun, 10 Nov 2019 03:08:55 +0000
Bug 1593844 - Add moz.configure bits to specify a LUCETC binary r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D51927
25f074eb507493b25d145c16787022d5f9926bde: Bug 1594015: Ensure that threads with odd ProcessNextEvent loops get correct event delays r=froydnj
Randell Jesup <rjesup@wgate.com> - Thu, 07 Nov 2019 12:53:41 +0000 - rev 501075
Push 114167 by csabou@mozilla.com at Fri, 08 Nov 2019 00:35:25 +0000
Bug 1594015: Ensure that threads with odd ProcessNextEvent loops get correct event delays r=froydnj Socket Thread and Worker Threads use custom event loops and don't wait in calls to ProcessNextEvent all the time; this can lead to odd Responsiveness numbers. Differential Revision: https://phabricator.services.mozilla.com/D51835
00da7156d3fa29a438c6ad3b7686abc7765ada35: Bug 1572337: Make GetRunningEventDelay handle threadpools r=froydnj
Randell Jesup <rjesup@wgate.com> - Thu, 07 Nov 2019 12:53:32 +0000 - rev 501065
Push 114167 by csabou@mozilla.com at Fri, 08 Nov 2019 00:35:25 +0000
Bug 1572337: Make GetRunningEventDelay handle threadpools r=froydnj Threadpools run an event that then runs other events, so we need to tweak things for GetRunningEventDelay() Differential Revision: https://phabricator.services.mozilla.com/D44058
ea6d5b4b038bc762f8b01647f6e19df8a45f7167: Bug 1572337: Monitor running event delays and start times r=froydnj
Randell Jesup <rjesup@wgate.com> - Thu, 07 Nov 2019 12:53:28 +0000 - rev 501063
Push 114167 by csabou@mozilla.com at Fri, 08 Nov 2019 00:35:25 +0000
Bug 1572337: Monitor running event delays and start times r=froydnj This lets us determine the time that an event has been running, and the time that the event spent queued - which can be used to figure out 'jank' at the time the event was queued. For PrioritizedEventQueues, only if such queuing would delay an input event then the queuing delay is reported. Differential Revision: https://phabricator.services.mozilla.com/D41279
a28ede26dc520600e02610bba43006292bb81ffb: Bug 1593844 - Add moz.configure bits to specify a LUCETC binary r=froydnj
Ricky Stewart <rstewart@mozilla.com> - Wed, 06 Nov 2019 22:33:11 +0000 - rev 501000
Push 114166 by apavel@mozilla.com at Thu, 07 Nov 2019 10:04:01 +0000
Bug 1593844 - Add moz.configure bits to specify a LUCETC binary r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D51927
3e505f5da731722349ef01eb2de1dc2fdb97ebe2: Bug 1593486 - Cleanup spidermonkey test code in mach. r=froydnj
Ted Campbell <tcampbell@mozilla.com> - Wed, 06 Nov 2019 18:53:07 +0000 - rev 500919
Push 114166 by apavel@mozilla.com at Thu, 07 Nov 2019 10:04:01 +0000
Bug 1593486 - Cleanup spidermonkey test code in mach. r=froydnj Remove some overly clever code and make the spidermonkey-related tests more consistent with each other. Differential Revision: https://phabricator.services.mozilla.com/D51901
5a944fda161554a5a356fa9e139e488262717c85: Bug 1593703 - disable clang based static-analysis for build-linux64-base-toolchains-clang/*. r=froydnj
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Wed, 06 Nov 2019 18:29:09 +0000 - rev 500917
Push 114166 by apavel@mozilla.com at Thu, 07 Nov 2019 10:04:01 +0000
Bug 1593703 - disable clang based static-analysis for build-linux64-base-toolchains-clang/*. r=froydnj With Bug 1579189 we are going to raise the minimum clang version to 5. But in clang 5 and clang 6 an issue has been introduced where the `Decl` nodes from the `AST` don't contain all of the annotation attributes. The missing attributes can cause static analysis failures. We are therefore going to disable the static analysis for the base-toolchain clang builds as a workaround. Differential Revision: https://phabricator.services.mozilla.com/D52025
7ff1ec6ba22266fee6a0312c7e32c5f04d5b9c7a: Bug 1593972 - Make the update-breakpad.sh script work with python3 r=froydnj
Gabriele Svelto <gsvelto@mozilla.com> - Wed, 06 Nov 2019 15:56:27 +0000 - rev 500869
Push 114166 by apavel@mozilla.com at Thu, 07 Nov 2019 10:04:01 +0000
Bug 1593972 - Make the update-breakpad.sh script work with python3 r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D51802
c12be2522c46f47901e77bdbe2362f68bc89ac80: Bug 1594267 - Make OutOfLinePoisoner::poison be MOZ_NEVER_INLINE r=froydnj
David Major <dmajor@mozilla.com> - Wed, 06 Nov 2019 14:10:15 +0000 - rev 500857
Push 114166 by apavel@mozilla.com at Thu, 07 Nov 2019 10:04:01 +0000
Bug 1594267 - Make OutOfLinePoisoner::poison be MOZ_NEVER_INLINE r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D51960
7edd630eb6c497e32341be35bf5da80838f1dc15: Bug 1594401 - Enable hashtable assertions on fuzzing builds. r=froydnj
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 06 Nov 2019 13:37:56 +0000 - rev 500849
Push 114166 by apavel@mozilla.com at Thu, 07 Nov 2019 10:04:01 +0000
Bug 1594401 - Enable hashtable assertions on fuzzing builds. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D51996