Bug 1596953 - Add valgrind to android-build image. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D53287

Bug 1596562: Add ParamTraits specializations for mozilla::Vector and std::vector; r=froydnj,bwc While the need for adding `mozilla::Vector` is self-evident, we also need `std::vector` so that we can send some pre-existing telemetry data structures that use it. The new implementations are basically modified from the `nsTArray` specializations. Note that the `mozilla::Vector` specialization does support any type of allocator, so we still check for OOM failures in that case. This patch also removes the specialization for `std::vector` that lives in WebRTC in favour of the centralized implementation. Differential Revision: https://phabricator.services.mozilla.com/D53085

Bug 1564083: The profile command line argument should match a profile with the same root directory and use its local directory. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D52736

Bug 1597150 - Bump RLBox library to the latest version. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D53374

Bug 1420363 - Write crash annotations as JSON r=froydnj,agi This patch rolls up all the required changes for this purpose. Since the whole crash reporting flow must understand the new format it's not possible to land this as separate patches as individually they would be broken. This patch includes the following changes: * Changes to the crash reporting machinery to write out annotations as JSON, these includes changes to the DLL blocklist code that must be run at crash time. * Modifications to the crash reporter client so that it can read and submit the new format; this includes platform-specific changes to the Breakpad libraries it uses for submitting crashes. * Modifications to the minidump-analyzer to understand and process the new format correctly. * Modifications to the crash manager to understand and process the new format correctly. * Modifications to GeckoView's crash handler to understand and submit the new format correctly. * Added new tests to cover the new format and modified existing ones to accomodate the new one. Differential Revision: https://phabricator.services.mozilla.com/D46848

Bug 1595629 - Note intentional crashes in NS_DEBUG_ABORT and nsTerminator. r=froydnj This will prevent the leak checker from reporting a missing log for that process, which results in incorrect starring on TreeHerder. Both of these failures should be detected as a failure. Differential Revision: https://phabricator.services.mozilla.com/D53095

Bug 1594998 - Make standalone SpiderMonkey use libxul-like panic. r=froydnj This moves the parts of toolkit/library/rust/shared/lib.rs related to panic hooking to a new mozglue subdirectory, which will be used for things that can be statically linked to e.g. libxul, rather than in a "shared library". The panic hook is disabled when building spidermonkey via the mozjs_sys crate. Differential Revision: https://phabricator.services.mozilla.com/D52793

Bug 1594577 - Record hangs which precede forced shutdowns r=froydnj In short - if a user forcibly terminates the browser because it seems to be permanently hung, we currently do not get a change to record the hang. This is unfortunate, because these likely represent the most egregious hangs in terms of user frustration. This patch seeks to address that. If a hang exceeds 8192ms (the current definition of a "permahang" in existing BHR terms), then we decide to immediately persist it to disk, in case we never get a chance to return to the main thread and submit it. On the next start of the browser, we read the file from disk on a background thread, and just submit it using the normal mechanism. Regarding the handling of the file itself, I tried to do the simplest thing I could - as far as I can tell there is no standard simple serialization mechanism available directly to C++ in Gecko, so I just serialized it by hand. I didn't take any special care with endianness or anything as I can't think of a situation in which we really care at all about these files being transferable between architectures. I directly used PR_Write / PR_Read instead of doing something fancy like memory mapping the file, because I don't think performance is a critical concern here and it offers a simple protection against reading out of bounds. Differential Revision: https://phabricator.services.mozilla.com/D52566

Bug 1596573 - Correct the documentation for custom use counters; r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D53083

Bug 838896 - Increase the crash reporter client comment size limit to 10000 characters; r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D53154

Bug 1594656 - Don't display seccomp-bpf info on non-Linux. r=jld,froydnj Differential Revision: https://phabricator.services.mozilla.com/D53034

Bug 1594998 - Make standalone SpiderMonkey use libxul-like panic. r=froydnj This moves the parts of toolkit/library/rust/shared/lib.rs related to panic hooking to a new mozglue subdirectory, which will be used for things that can be statically linked to e.g. libxul, rather than in a "shared library". The panic hook is disabled when building spidermonkey via the mozjs_sys crate. Differential Revision: https://phabricator.services.mozilla.com/D52793

Bug 1487212 - When hyphenation resources are compressed in omnijar, load them into shared memory and share among all content processes. r=heycam,froydnj Differential Revision: https://phabricator.services.mozilla.com/D52835

Bug 1596341 - Fix nasm putting garbage in the .debug_loc section on elf32. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D52972

Bug 1595906 - Allow opting out of hardening compile flags on a granular basis r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D52756

Bug 1582297 - Suppress IPC "pipe error" messages if the cause was probably the other process exiting. r=froydnj There are two issues here: 1. These error messages occur even during normal channel shutdown, because that's tracked in the mozilla::ipc::MessageChannel layer, which the ipc/chromium code can't access. 2. If we get this kind of error when the channel wasn't intentionally closed, it almost certainly means that the other process crashed. In that case, having error messages from a different process and a likely unrelated subsystem just leads to confusion and misfiled bugs. (Also complicating things: on Unix a closed channel often, but not always, results in an end-of-file indication, which already isn't logged; on Windows it's always a broken pipe error, which causes a much larger amount of log spam.) Bonus fix: the error that contains a fd number is clarified to avoid having it mistaken for an error code. Differential Revision: https://phabricator.services.mozilla.com/D52727

Bug 1596276 - Switch Linux coverage opt builds to use GCC 7. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D52935

Bug 1596244 - Report a fake leak instead of crashing if NSS fails to shut down. r=froydnj,keeler Some kinds of leaks prevent NSS to not shut down properly, and right now if that happens we crash. This interferes with our existing leak checking code, so in this patch I make it not crash if we are already leak checking. The failure is reported as a fake leak, so the test should still fail when testing. Differential Revision: https://phabricator.services.mozilla.com/D52914

Bug 1594998 - Make standalone SpiderMonkey use libxul-like panic. r=froydnj,jandem This moves the parts of toolkit/library/rust/shared/lib.rs related to panic hooking to a new mozglue subdirectory, which will be used for things that can be statically linked to e.g. libxul, rather than in a "shared library". The panic hook is disabled when building spidermonkey via the mozjs_sys crate. Differential Revision: https://phabricator.services.mozilla.com/D52793

Bug 1595750 - Add MakeBackInserter function to create a back-inserting output iterator for nsTArray. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D52685

Bug 1591417: part 3) Add `nsTStringRepr<T>::EqualsLatin1`. r=froydnj Needed to compare with `nsTextFragment::Get1b()` which returns latin1-encoded characters. Used in a subsequent review. Differential Revision: https://phabricator.services.mozilla.com/D52343

Bug 1590907 - Remove obsolete macro MOZ_HAVE_BITSCAN64. r=froydnj This macro seems to have been introduced in https://bugzilla.mozilla.org/attachment.cgi?id=772469&action=diff but there doesn't seem to be any mention of it anywhere else. Currently it's only checked in order to #undef it if it's defined. Differential Revision: https://phabricator.services.mozilla.com/D51770

Bug 1595633 - Enable 'pointer-overflow' UBSan check. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D52608

Bug 1595828 - Fix some include guards. r=froydnj The formatting change presumably happens because clang-format treats include guards differently. Differential Revision: https://phabricator.services.mozilla.com/D52698

Bug 1595812 - Fix include guard in IntentionalCrash.h. r=froydnj The include guard needs to happen before any non-trivial tokens. I guess this change made clang-format decide the other ifdefs aren't actually nested, so it dropped the indents. Differential Revision: https://phabricator.services.mozilla.com/D52691

Bug 1595750 - Add MakeBackInserter function to create a back-inserting output iterator for nsTArray. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D52685

Bug 1595805 - Disable LTO on macosx fuzzy builds r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D52688

Bug 1583353 - [mozbuild.reader] Don't return root moz.build twice in 'all_mozbuild_paths', r=froydnj Despite what the comment says, the finder *does* pick up the root moz.build. So we end up processing it twice. This was never caught before because we only ever used this function to read Sphinx related variables, of which the root moz.build contains none. Differential Revision: https://phabricator.services.mozilla.com/D51832

Bug 1562642 - add missing license in xpcom/ r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D52579

Bug 1576051 - Vendor the the RLBox Lucet sandbox library and its dependencies r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D43709

Bug 1572619 - Include RLBox Lucet integration repo to use wasm library sandboxes r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D43030

Bug 1576054 - Use forked rust/nix that removes references to newer libc functions setns, process_vm_writv, process_vm_readv. References to these functions create missing symbols in gkrust, which is configured to a build failure in Firefox r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D44341

Bug 1583192 - Re-apply bug 1330495 after bug 1581145. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D52442

Bug 1572337: Don't call TimeStamp::Now() within SuspendAndSample r=froydnj Avoids deadlocks on Windows due to Now() taking a lock; if done while we've paused a thread that holds the lock we will deadlock. Differential Revision: https://phabricator.services.mozilla.com/D52392

Bug 1594015: Ensure that threads with odd ProcessNextEvent loops get correct event delays r=froydnj Socket Thread and Worker Threads use custom event loops and don't wait in calls to ProcessNextEvent all the time; this can lead to odd Responsiveness numbers. Differential Revision: https://phabricator.services.mozilla.com/D51835

Bug 1572337: Make GetRunningEventDelay handle threadpools r=froydnj Threadpools run an event that then runs other events, so we need to tweak things for GetRunningEventDelay() Differential Revision: https://phabricator.services.mozilla.com/D44058

Bug 1572337: Monitor running event delays and start times r=froydnj This lets us determine the time that an event has been running, and the time that the event spent queued - which can be used to figure out 'jank' at the time the event was queued. For PrioritizedEventQueues, only if such queuing would delay an input event then the queuing delay is reported. Differential Revision: https://phabricator.services.mozilla.com/D41279

Bug 1594839 - Enable 'integer-divide-by-zero' UBSan check. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D52218

Bug 1594051 - Perform fallible alloc when copying buffer from StartupCache r=froydnj This effectively used to be a fallible alloc inside nsZipArchive. Differential Revision: https://phabricator.services.mozilla.com/D52199

Bug 1513855: Make sure that quit-application-granted and quit-application notifications are always sent. r=froydnj We only run the main event loop if at least one window is open. There are various cases where this doesn't happen, such as -silent. By the time we get there though some components have started and require appropriate notifications to tell them to shutdown safely. This patch sends the quit-application-granted and quit-application notifications in the case that there were no windows open and nsAppStartup::Quit hasn't already been called when we come to run the event loop. Differential Revision: https://phabricator.services.mozilla.com/D51736

Bug 1593844 - Add moz.configure bits to specify a LUCETC binary r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D51927

Bug 1594015: Ensure that threads with odd ProcessNextEvent loops get correct event delays r=froydnj Socket Thread and Worker Threads use custom event loops and don't wait in calls to ProcessNextEvent all the time; this can lead to odd Responsiveness numbers. Differential Revision: https://phabricator.services.mozilla.com/D51835

Bug 1572337: Make GetRunningEventDelay handle threadpools r=froydnj Threadpools run an event that then runs other events, so we need to tweak things for GetRunningEventDelay() Differential Revision: https://phabricator.services.mozilla.com/D44058

Bug 1572337: Monitor running event delays and start times r=froydnj This lets us determine the time that an event has been running, and the time that the event spent queued - which can be used to figure out 'jank' at the time the event was queued. For PrioritizedEventQueues, only if such queuing would delay an input event then the queuing delay is reported. Differential Revision: https://phabricator.services.mozilla.com/D41279

Bug 1593844 - Add moz.configure bits to specify a LUCETC binary r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D51927

Bug 1593486 - Cleanup spidermonkey test code in mach. r=froydnj Remove some overly clever code and make the spidermonkey-related tests more consistent with each other. Differential Revision: https://phabricator.services.mozilla.com/D51901

Bug 1593703 - disable clang based static-analysis for build-linux64-base-toolchains-clang/*. r=froydnj With Bug 1579189 we are going to raise the minimum clang version to 5. But in clang 5 and clang 6 an issue has been introduced where the `Decl` nodes from the `AST` don't contain all of the annotation attributes. The missing attributes can cause static analysis failures. We are therefore going to disable the static analysis for the base-toolchain clang builds as a workaround. Differential Revision: https://phabricator.services.mozilla.com/D52025

Bug 1593972 - Make the update-breakpad.sh script work with python3 r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D51802

Bug 1594267 - Make OutOfLinePoisoner::poison be MOZ_NEVER_INLINE r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D51960

Bug 1594401 - Enable hashtable assertions on fuzzing builds. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D51996