Bug 1559403 - Implement nsIStringInputStream.setUTF8Data. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D35027

Bug 1557161 - enable rkv consumers to migrate LMDB environments across architecture changes r=lina,keeler,froydnj Differential Revision: https://phabricator.services.mozilla.com/D33863

Bug 1558653. Stop using [array] in nsIConsoleService. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D34666

Bug 1557171 - Wrap the sys/cachectl.h system header on mips linux. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D33883

Bug 1556173: Fix test_profile_reset.js on dev-edition builds. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D34002

Bug 1553929: Make some attempt to correctly match default profiles after profiles.ini has been manually edited by the user. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D34038

Bug 1557161 - enable rkv consumers to migrate LMDB environments across architecture changes r=lina,keeler,froydnj Differential Revision: https://phabricator.services.mozilla.com/D33863

Bug 1556831: Have safe mode write out the normal compatibility version. r=froydnj When launching into safe mode we write out a compatibility.ini with an invalid compatibility version in it. This is to ensure that on the next startup we flush the caches. This is unnecessary though, we already have a flag we can set in compatibility.ini in order to request a flush on next startup. This patch switches to doing that so the version check on startup continues to work. Differential Revision: https://phabricator.services.mozilla.com/D33699

Bug 1553272 - Eliminate the unnecessary ProtocolState object, r=froydnj The vast majority of the virtual methods which were used on ProtocolState were actually methods which only had meaningful implementations on the toplevel protocol. This patch adds a new field to IProtocol holding a direct pointer to the protocol's `IToplevelProtocol`, and the methods formerly implemented with ProtocolState now directly call the corresponding method on IToplevelProtocol. IToplevelProtocol then shadows these methods with the toplevel protocol implementation, meaning that the right code is run in the right places. In addition, some state was maintained for protocols inside of the separate ProtocolState allocation, and this patch moves that state back into the actor itself. Differential Revision: https://phabricator.services.mozilla.com/D32044

Bug 1556832: Comparing compatibility versions goes on to check the build IDs when the version is newer. r=froydnj When comparing compatibility versions we first compare the version part. If that shows us to be a downgrade then we stop checking at that point. But we must also stop checking if it shows us to be an upgrade since we don't need to check the build IDs at that point. This also applies to the check for the app build ID. This means that a newer version with an older build id will appear to be a downgrade. This is problematic for safe mode because when safe mode runs it sets the compatibility version to "Safe Mode" (bug 1556831) to ensure that caches are invalidated on next startup. On the next run the Firefox version is considered as newer than "Safe Mode" so we would move on to comparing the build IDs. But the Firefox build ID gets version compared to "" (since there isn't a build ID part in "Safe Mode"). Since build ID's are larger than 32-bit numbers we trigger bug 1556829 and the actual comparison depends on the value of the build ID truncated to 32-bits. This seems to often be negative and so lower than the apparent previous build ID causing us to think this is a downgrade. Cue nfroydnj saying I told you so because if I'd written this as a more traditional compare function as he suggested I probably would have caught this. Differential Revision: https://phabricator.services.mozilla.com/D33702

Bug 1556829: Convert version numbers larger or smaller than the 32-bit limit to 0. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D33700

Bug 1556831: Have safe mode write out the normal compatibility version. r=froydnj When launching into safe mode we write out a compatibility.ini with an invalid compatibility version in it. This is to ensure that on the next startup we flush the caches. This is unnecessary though, we already have a flag we can set in compatibility.ini in order to request a flush on next startup. This patch switches to doing that so the version check on startup continues to work. Differential Revision: https://phabricator.services.mozilla.com/D33699

Bug 1557164 - Don't use integrated assembler with clang on mips*. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D33865

Bug 1556612: Hardcode considering this an upgrade if the last build to run was run in safe mode. r=froydnj When safe mode runs it writes out "Safe Mode" as the compatibility version (bug 1556831). Due to bug 1556832 and bug 1556829 this makes us think that the next run is a downgrade. This is the simplest possible fix that should be totally safe to upload to release. Differential Revision: https://phabricator.services.mozilla.com/D33698

Bug 1537586 - Address build failure with --disable-printing r=bobowen,froydnj Make nsIWebBrowserPrint included unconditionally for addressing nsIDocShell.rs build failure. Remove direct_call of PPrinting and PRemotePrintJob. Their ipdl are built unconditionally, but their derived classes are not built with --disable-printing. Differential Revision: https://phabricator.services.mozilla.com/D33391

Bug 1555530 - Don't use integrated assembler with clang on ppc64 and s390x. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D33728

Bug 1539806 - Hook zydis into our source code and build system. r=froydnj This changes check_spidermonkey_style.py to account for Zydis and makes the spidermonkey moz.build aware of the one in zydis. Differential Revision: https://phabricator.services.mozilla.com/D27850

Bug 1539806 - Incorporate the Zydis disassembler source. r=froydnj, r=mhoye The Zydis disassembler is a configurable MIT-licensed decoder and formatter for x64 and x86. The code comes from two github repositories: https://github.com/zyantific/zydis https://github.com/zyantific/zycore-c In accompanying licensing material (included in this patch) the authors are identified as these: Copyright (c) 2014-2019 Florian Bernd Copyright (c) 2014-2019 Joel Höner We will use Zydis to disassemble code generated by the Cranelift JIT. This source has been taken from the master branch of Zydis on github and incorporated here in the manner described in README.md in this directory. Effectively: a subset of files have been incorporated and the files are in new locations in a flatter tree. README.md has instructions for repeating the job. The files in the root Zydis directory js/src/zydis are largely authored by me but in some cases incorporate code from the Zydis repository on github and are therefore given a Zydis copyright when appropriate.

Bug 1527371 - Show linker time breakdown for xul.dll r=froydnj COFF-flavored lld collects timing stats about various phases of linking. This might be useful to have in logs. I left it off in developer builds to avoid spamming tight edit-compile cycles. Differential Revision: https://phabricator.services.mozilla.com/D33319

Bug 1556257 - Add Funtoo support to mach bootstrap. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D33425

Bug 1555917 - Exception handler and crash reporter client cleanup r=froydnj This patch includes multiple changes cleaning up various aspects of the crash reporter client and exception handler: * Some Unix-specific code was moved out from the base crashreporter client code and into the appropriate platform implementation * Functions used to open files in the crashreporter client now accept C++ `std::ios` flags instead of unreadable booleans * Useless character conversion routines were removed from the minidump-analyzer * Crash annotations are not serialized into a huge string anymore every time they change. They are all written out individually during an exception. * `WriteEscapedMozCrashReason()` uses the exception-safe `my_strlen()` instead of plain `strlen()` * The Windows-specific DLL-blocklist shutdown was removed from the Linux & macOS Breakpad callbacks * The `CrashReporterHost`, `CrashReporterClient` and `CrashReporterMetadataShmem` classes now take `nsACString` references instead of `nsCString` ones since they never modify their contents Differential Revision: https://phabricator.services.mozilla.com/D33267

Bug 1555117: Ignore attempts to reset the profile when a new profile had to be created for the install. r=froydnj Since bug 1518587 when a command line argument or environment variable requests a profile refresh but no existing profile is selected we would just exit thinking that there is some problem here. But it turns out that the installer sometimes passes this argument when it doesn't know that the new install will not use the existing profiles. So instead we just ignore attempts to refresh when we create a new profile. To do this we just have to remove the checks that bail out and continue to create the new profile, nsAppRunner will see that a new profile has been created and cancel the attempted refresh anyway: https://searchfox.org/mozilla-central/rev/ddb81c7a43ffada1f6cb4200c4f625e50e44dcf3/toolkit/xre/nsAppRunner.cpp#2021 Differential Revision: https://phabricator.services.mozilla.com/D32891

Bug 1196094 - use e10s when doing PGO profiling, r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D32329

Bug 1196094 - disable _exit in child processes when generating profile information, r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D33269

Bug 1508976 - Post: Include all targets in about:buildconfig in GeckoView fat AAR. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D15773

Bug 1553363 - Generalize the *_impl goop for allocation functions in mozglue. r=froydnj The current situation is suboptimal, where we have the same goop repeated in multiple files, and where things kinda sorta work out fine thanks to the linker for files that would have been forbidden, except when the linker doesn't do its job, which apparently happen on mingwclang builds. This change only really covers C++ code using operator new/delete, and not things that would be using malloc/free, because it's easier. malloc/free is left for a followup. Differential Revision: https://phabricator.services.mozilla.com/D32119

Bug 1552080 - Rejigger a bit rust features so that rusttests still link. r=froydnj We cannot compile with just feature(gecko + debug_assertions), since that's how debug rusttests get compiled and they don't have the refcount logging stuff. We were getting away with it for the pre-existing usage of the style crate, because it wasn't used during any test and presumably the linker didn't complain. But servo_arc is definitely used in tests. Differential Revision: https://phabricator.services.mozilla.com/D32691

Bug 1554006 - Update builders to rustc 1.35. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D32932

Bug 1554006 - Bump max OOM hook version for the rust update to 1.35. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D32931

bug 1555110 - Backed out changeset a187487af38a to disable cert_storage on non-nightly builds r=jcj,froydnj There are ongoing lmdb issues we need to sort out before we can ship cert_storage (see e.g. bug 1538541 and bug 1550174). Differential Revision: https://phabricator.services.mozilla.com/D32885

Bug 1554029: Downgrade detection fails for changes from non-minor to minor versions. r=froydnj We build compatibility versions as `<appversion>_<appbuildid>/<platformbuildid>`. where the build ID's by default are a numeric representation of the date that the build happened. Previously we attempted to mangle this into a valid toolkit version by converting to `<appversion>.<appbuildid>.<platformbuildid>` if the build IDs were the expected length. We also split each build ID into two version parts since the version comparator couldn't handle their full size. This mangling fails when comparing a major version with a new patch version: `<majorversion>.<appbuildid>.<platformbuildid>` gets compared to `<majorversion>.1.<appbuildid>.<platformbuildid>`. Unless that patch version (1 here) was greater than the build ID (currently in the tens of millions) the patch release would appear to be older than the previous version. This changes this so rather than attempting to mangle the entire string into a single toolkit version we split out the string into their components. First we compare the app versions using the version comparator which is definitely the correct thing to do. For the build IDs we check if they are entirely numeric (which is the case for the date based default) and if so just compare them numerically. We assume that if the IDs aren't numeric then they are something defined by a custom build of Firefox, we can't know what form that takes so I've chosen to fallback to just using the version comparator since it will handle things such as `"build1" < "build10"` and it should be straightforward for anything more complex to choose a form that works. Differential Revision: https://phabricator.services.mozilla.com/D32552

Bug 1554029: Downgrade detection fails for changes from non-minor to minor versions. r=froydnj We build compatibility versions as `<appversion>_<appbuildid>/<platformbuildid>`. where the build ID's by default are a numeric representation of the date that the build happened. Previously we attempted to mangle this into a valid toolkit version by converting to `<appversion>.<appbuildid>.<platformbuildid>` if the build IDs were the expected length. We also split each build ID into two version parts since the version comparator couldn't handle their full size. This mangling fails when comparing a major version with a new patch version: `<majorversion>.<appbuildid>.<platformbuildid>` gets compared to `<majorversion>.1.<appbuildid>.<platformbuildid>`. Unless that patch version (1 here) was greater than the build ID (currently in the tens of millions) the patch release would appear to be older than the previous version. This changes this so rather than attempting to mangle the entire string into a single toolkit version we split out the string into their components. First we compare the app versions using the version comparator which is definitely the correct thing to do. For the build IDs we check if they are entirely numeric (which is the case for the date based default) and if so just compare them numerically. We assume that if the IDs aren't numeric then they are something defined by a custom build of Firefox, we can't know what form that takes so I've chosen to fallback to just using the version comparator since it will handle things such as `"build1" < "build10"` and it should be straightforward for anything more complex to choose a form that works. Differential Revision: https://phabricator.services.mozilla.com/D32552

Bug 1555179: Use 0 in place of out of range numbers in version comparisons. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D32926

Bug 1554039 - Add some missing debug info to the valgrind docker image. r=froydnj Some debug info for system packages are not available to valgrind in the valgrind docker image, some of which are for libraries actively used by Firefox. Not all of them, unfortunately, have debug info available, but some of them do and we add them all. We could skip a few that are not really useful, but that doesn't make a significant difference to the docker image size (~0.3%). Differential Revision: https://phabricator.services.mozilla.com/D32419

Bug 1196094 - use e10s when doing PGO profiling, r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D32329

Bug 1552643 - P3. rename medium_high_event_queue.enabled pref. r=froydnj To make it more inline other preferences naming. Differential Revision: https://phabricator.services.mozilla.com/D32251

Bug 1554162 - Enable ESLint for startupcache/. r=froydnj Depends on D32493 Differential Revision: https://phabricator.services.mozilla.com/D32494

Bug 1552643 - P3. rename medium_high_event_queue.enabled pref. r=froydnj To make it more inline other preferences naming. Differential Revision: https://phabricator.services.mozilla.com/D32251

Bug 1553270 - Part 2: Allow getting a protocol's name from its ProtocolID, r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D32043

Bug 1553270 - Part 1: Store the protocol ID on IProtocol directly, r=froydnj This allows for the getter to be used in IProtocol's destructor, and generally brings IProtocol more in line with IToplevelProtocol. Differential Revision: https://phabricator.services.mozilla.com/D32042

Bug 1553856: LazyIdleThread should set names for the nsThreads it spawns r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D32385

Bug 1471698 - Remove our binutils-corruption-avoiding workaround for mingw-clang r=froydnj Depends on D31347 Differential Revision: https://phabricator.services.mozilla.com/D31349

Bug 1552549 - Update rand dependency to 0.6 r=kats,froydnj,nika,jkt,jcj Update rand version in u2fhid and xpcom Differential Revision: https://phabricator.services.mozilla.com/D31669

Bug 1553567: Use MaxValue to initialize/reset nsThread::mCurrentEventLoopDepth, not -1. r=froydnj Since the purpose of mCurrentEventLoopDepth is to be ordered in comparison with mNestedEventLoopDepth, it's a bit deceptive to give it a value that would appear to be less than any reasonable depth but is, because the variables in question are unsigned, actually greater than any reasonable depth. Using mozilla::MaxValue<uint32_t>::value is clearer. Differential Revision: https://phabricator.services.mozilla.com/D32198

Bug 1553116 - Get the arm64 hardening flag out of the way of l10n builds r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D32165

Bug 1530650 - Add --cap-lints warn to RUSTFLAGS when not building with --enable-warnings-as-errors. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D32080

Bug 1551842 - Add new clang-tidy checkers from clang 8.0.0. r=sylvestre,froydnj Differential Revision: https://phabricator.services.mozilla.com/D31229

Bug 1553226 - Don't attempt to read annotations associated with Flash process crashes r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D32133

Bug 1553037 - clang-based disable static-analysis in `MOZ_REALLY_CRASH`. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D32132

Bug 1471698 - Remove our binutils-corruption-avoiding workaround for mingw-clang r=froydnj Depends on D31347 Differential Revision: https://phabricator.services.mozilla.com/D31349