searching for reviewer(evilpie)
7dd1ac96a354295013e0c78eccf7e880ae645b3f: Bug 1580733 - Fix AppConstants module getter, r=evilpie,mconley
Martin Stransky <stransky@redhat.com> - Fri, 04 Oct 2019 17:29:03 +0000 - rev 496432
Push
114143 by rgurzau@mozilla.com at Mon, 07 Oct 2019 09:35:08 +0000
Bug 1580733 - Fix AppConstants module getter, r=evilpie,mconley
Differential Revision:
https://phabricator.services.mozilla.com/D47899
9912dd6288bb69697d7f0dfe65de85d547b0252b: Bug 1572147 - Part 3: Remove includes to builtin/String.h. r=evilpie
André Bargull <andre.bargull@gmail.com> - Wed, 07 Aug 2019 20:06:30 +0000 - rev 486939
Push
113858 by rmaries@mozilla.com at Thu, 08 Aug 2019 23:21:39 +0000
Bug 1572147 - Part 3: Remove includes to builtin/String.h. r=evilpie
Multiple files were including builtin/String.h, but not actually using any
function definitions from builtin/String.h.
Depends on D41040
Differential Revision:
https://phabricator.services.mozilla.com/D41041
2c4b730d8f589a9f7559f5b0e3838555efc09678: Bug 1572147 - Part 2: Remove unused includes from builtin/String.h. r=evilpie
André Bargull <andre.bargull@gmail.com> - Wed, 07 Aug 2019 20:04:41 +0000 - rev 486938
Push
113858 by rmaries@mozilla.com at Thu, 08 Aug 2019 23:21:39 +0000
Bug 1572147 - Part 2: Remove unused includes from builtin/String.h. r=evilpie
Depends on D41039
Differential Revision:
https://phabricator.services.mozilla.com/D41040
51f7b87d0e6b9d6503e7c4162c9c54ebc7955ad0: Bug 1572147 - Part 1: Remove no longer used String functions from self-hosting global. r=evilpie
André Bargull <andre.bargull@gmail.com> - Wed, 07 Aug 2019 20:00:31 +0000 - rev 486937
Push
113858 by rmaries@mozilla.com at Thu, 08 Aug 2019 23:21:39 +0000
Bug 1572147 - Part 1: Remove no longer used String functions from self-hosting global. r=evilpie
These functions were only exposed for the String generics.
Differential Revision:
https://phabricator.services.mozilla.com/D41039
edb8832eafa11ea93d652b277ac192f7ae0a2c19: Bug 1544834 - Replace deprecated generics in test code r=evilpie
Rob Wu <rob@robwu.nl> - Wed, 17 Apr 2019 19:03:19 +0000 - rev 470066
Push
112843 by aiakab@mozilla.com at Fri, 19 Apr 2019 09:50:22 +0000
Bug 1544834 - Replace deprecated generics in test code r=evilpie
- `Array.map` becomes `Array.from`
- Array copying via `Array.slice` becomes `Array.from`.
- `Array.forEach` that did not rely on closures becomes `for`-`of` loops.
- Anything else: `Array.X` becomes `Array.prototype.X`.
Complex cases:
dom/bindings/test/TestInterfaceJS.js and
dom/bindings/test/test_exception_options_from_jsimplemented.html
use `Array.indexOf` to generate an error with a specific error message.
Switched to `Array.prototype.forEach` to generate the same error.
js/src/jit-test/tests/basic/exception-column-number.js
In this test `Array.indexOf()` is used to generate an error. Since the
exact message doesn't matter, I switched to `Array.from()`.
Intentionally not changed:
editor/libeditor/tests/browserscope/lib/richtext/richtext/js/range.js
Did not modify because this is 3rd-party code and the code uses
feature detection as a fall back when Array generics are not used.
testing/talos/talos/tests/dromaeo/lib/mootools.js
Did not modify because mootools adds the `Array.slice` method to the
`Array` object.
Not changed because they check the implementation of Array generics:
js/src/jit-test/tests/basic/arrayNatives.js
js/src/jit-test/tests/basic/bug563243.js
js/src/jit-test/tests/basic/bug618853.js
js/src/jit-test/tests/basic/bug830967.js
js/src/jit-test/tests/jaeger/recompile/bug656753.js
js/src/jit-test/tests/self-hosting/alternate-static-and-instance-array-extras.js
js/src/tests/non262/Array/generics.js
js/src/tests/non262/Array/regress-415540.js
js/src/tests/non262/extensions/regress-355497.js
js/src/tests/non262/extensions/typedarray-set-neutering.js
Depends on D27802
Differential Revision:
https://phabricator.services.mozilla.com/D27803
0d59dd598e5eb0b7b4618d68d6884c947eb658d6: Bug 1544834 - Replace non-test uses of deprecated Array generics r=evilpie,dao
Rob Wu <rob@robwu.nl> - Wed, 17 Apr 2019 19:03:17 +0000 - rev 470065
Push
112843 by aiakab@mozilla.com at Fri, 19 Apr 2019 09:50:22 +0000
Bug 1544834 - Replace non-test uses of deprecated Array generics r=evilpie,dao
- `Array.forEach` becomes for-of loop or `array.forEach`.
- `Array.slice(a)` or `Array.slice(a, 0)` becomes `Array.from(a)`.
- `Array.map` becomes `Array.from`
- `Array` copy + concatenation becomes Array literal + spread syntax.
- All other `Array.X(a, ...)` become `Array.prototype.X.call` or `Array.from(a).X(...)`
Differential Revision:
https://phabricator.services.mozilla.com/D27802
5954caed00725de4045f1de7e91c546aaff77d9d: Bug 1527592 - Preserve callable/constructor flags when returning a dead object proxy from Compartment::wrap. r=evilpie,jorendorff
Jan de Mooij <jdemooij@mozilla.com> - Tue, 19 Feb 2019 10:11:27 +0000 - rev 459874
Push
112018 by btara@mozilla.com at Tue, 19 Feb 2019 17:39:20 +0000
Bug 1527592 - Preserve callable/constructor flags when returning a dead object proxy from Compartment::wrap. r=evilpie,jorendorff
Differential Revision:
https://phabricator.services.mozilla.com/D19945
0cd43ecd2fb63432c6b7b1da6f2f3debbb76d4b7: Bug 1525674 part 4 - Move Ion's Iterator{More,Close} code to the MacroAssembler and use it in Baseline instead of ICs. r=evilpie
Jan de Mooij <jdemooij@mozilla.com> - Fri, 08 Feb 2019 08:18:37 +0000 - rev 458250
Push
111791 by csabou@mozilla.com at Fri, 08 Feb 2019 16:20:14 +0000
Bug 1525674 part 4 - Move Ion's Iterator{More,Close} code to the MacroAssembler and use it in Baseline instead of ICs. r=evilpie
Differential Revision:
https://phabricator.services.mozilla.com/D18929
279c4a04e2d99d4f6da4cc52c25fa2ef1c4ba5ed: Bug 1525674 part 3 - Rename JSObject::ITER_CLASS_NFIXED_SLOTS to PropertyIteratorObject::NUM_FIXED_SLOTS. r=evilpie
Jan de Mooij <jdemooij@mozilla.com> - Fri, 08 Feb 2019 08:18:07 +0000 - rev 458249
Push
111791 by csabou@mozilla.com at Fri, 08 Feb 2019 16:20:14 +0000
Bug 1525674 part 3 - Rename JSObject::ITER_CLASS_NFIXED_SLOTS to PropertyIteratorObject::NUM_FIXED_SLOTS. r=evilpie
Differential Revision:
https://phabricator.services.mozilla.com/D18928
44a103afdb3a2509edc5e69bb4c388988dfaf89c: Bug 1525674 part 2 - Make js::IteratorMore (and the JIT-inlined equivalent) infallible. r=evilpie
Jan de Mooij <jdemooij@mozilla.com> - Fri, 08 Feb 2019 08:17:35 +0000 - rev 458248
Push
111791 by csabou@mozilla.com at Fri, 08 Feb 2019 16:20:14 +0000
Bug 1525674 part 2 - Make js::IteratorMore (and the JIT-inlined equivalent) infallible. r=evilpie
This also removes some dead BaselineInspector code.
Differential Revision:
https://phabricator.services.mozilla.com/D18927
661d858eb94f6a564fb6845e024dbf83e632c9a0: Bug 1525674 part 1 - Change the enumerate proxy trap to return the jsid vector instead of an iterator. r=bzbarsky,evilpie
Jan de Mooij <jdemooij@mozilla.com> - Fri, 08 Feb 2019 08:17:00 +0000 - rev 458247
Push
111791 by csabou@mozilla.com at Fri, 08 Feb 2019 16:20:14 +0000
Bug 1525674 part 1 - Change the enumerate proxy trap to return the jsid vector instead of an iterator. r=bzbarsky,evilpie
In vm/Iteration.cpp this inlines some functions because there's a single
caller now. Follow-up patches will do additional cleanup/optimization.
Differential Revision:
https://phabricator.services.mozilla.com/D18926
512b845fbed7e63220042976786e032cd0f88bcd: Bug 1521677. Change defineProperties to handle non-configurable properties on WindowProxy like defineProperty does. r=evilpie
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 06 Feb 2019 16:55:08 +0000 - rev 457468
Push
111729 by rgurzau@mozilla.com at Wed, 06 Feb 2019 22:00:03 +0000
Bug 1521677. Change defineProperties to handle non-configurable properties on WindowProxy like defineProperty does. r=evilpie
We want to indicate "we didn't actually manage to define your properties as
non-configurable" but we don't want to throw exceptions when people try to
Object.defineProperties with a non-configurable property in the list on a
WindowProxy.
Though maybe we should just silently ignore the "can't define non-configurable
on WindowProxy" bits in defineProperties and just return the object anyway?
The reason we do the "return null" bit in defineProperty is so that Caja and
the like can detect it, but if they're not using defineProperties to start with
they may not need to detect this "failure". On the other hand, Mark Miller
thinks the detection will be needed...
Differential Revision:
https://phabricator.services.mozilla.com/D17516
4694d772971d6dce45e4c47dde6b25c770b11d59: Bug 1522068 - Baseline-compile JSOP_SETINTRINSIC. r=evilpie
Jan de Mooij <jdemooij@mozilla.com> - Fri, 25 Jan 2019 10:59:37 +0000 - rev 455435
Push
111469 by ccoroiu@mozilla.com at Fri, 25 Jan 2019 21:56:18 +0000
Bug 1522068 - Baseline-compile JSOP_SETINTRINSIC. r=evilpie
Differential Revision:
https://phabricator.services.mozilla.com/D17497
4b3fc8b9128035c63821078328c73fbc525d1950: Bug 1517690 - Fix BaselineInspector to match new CacheIR ops for WindowProxy unwrapping. r=evilpie
Jan de Mooij <jdemooij@mozilla.com> - Fri, 04 Jan 2019 17:47:39 +0000 - rev 452591
Push
110924 by shindli@mozilla.com at Fri, 04 Jan 2019 21:50:35 +0000
Bug 1517690 - Fix BaselineInspector to match new CacheIR ops for WindowProxy unwrapping. r=evilpie
Differential Revision:
https://phabricator.services.mozilla.com/D15729
4f9a88ca20ebd876c51948bc171269502865c3ee: Bug 1509768 - Handle the case that String#replace is called with a empty string pattern on a rope. r=evilpie
Tooru Fujisawa <arai_a@mac.com> - Tue, 27 Nov 2018 19:18:52 +0900 - rev 448202
Push
110137 by arai_a@mac.com at Tue, 27 Nov 2018 10:19:07 +0000
Bug 1509768 - Handle the case that String#replace is called with a empty string pattern on a rope. r=evilpie
32915637657a5e92dbdd8abec557c1f229b70cd1: Bug 1505511 - Part 2: Use ClassSpec in WeakSetObject. r=evilpie
Tooru Fujisawa <arai_a@mac.com> - Tue, 20 Nov 2018 20:21:32 +0900 - rev 447197
Push
109995 by arai_a@mac.com at Tue, 20 Nov 2018 11:21:51 +0000
Bug 1505511 - Part 2: Use ClassSpec in WeakSetObject. r=evilpie
a5d9fa8dc136d167e53b1ae4a7b494d2e691dd60: Bug 1505511 - Part 1: Use ClassSpec in WeakMapObject. r=evilpie
Tooru Fujisawa <arai_a@mac.com> - Tue, 20 Nov 2018 20:21:32 +0900 - rev 447196
Push
109995 by arai_a@mac.com at Tue, 20 Nov 2018 11:21:51 +0000
Bug 1505511 - Part 1: Use ClassSpec in WeakMapObject. r=evilpie
80235331ce5f2bc78444739b388e5d64b7970eb9: Bug 1499335 - Support module specifiers containing inline data in the shell r=evilpie
Jon Coppeard <jcoppeard@mozilla.com> - Mon, 22 Oct 2018 13:33:02 +0100 - rev 442309
Push
109142 by jcoppeard@mozilla.com at Mon, 22 Oct 2018 12:35:30 +0000
Bug 1499335 - Support module specifiers containing inline data in the shell r=evilpie
cf105c387f2dc5053f26f0cb4429b97982d6fb65: Bug 1500267 - Record op in SetPropIRGenerator CacheIR logs r=evilpie
Matthew Gaudet <mgaudet@mozilla.com> - Fri, 19 Oct 2018 15:10:55 +0000 - rev 442192
Push
109116 by dvarga@mozilla.com at Sat, 20 Oct 2018 10:33:59 +0000
Bug 1500267 - Record op in SetPropIRGenerator CacheIR logs r=evilpie
Depends on D9167
Differential Revision:
https://phabricator.services.mozilla.com/D9168
609976e5c798f029adf1339e4298d0747fb360bc: Bug 1500052 - Fix iterator cache to check getDenseInitializedLength() == 0 instead of hasEmptyElements(). r=evilpie
Jan de Mooij <jdemooij@mozilla.com> - Thu, 18 Oct 2018 14:24:45 +0000 - rev 441962
Push
109079 by csabou@mozilla.com at Thu, 18 Oct 2018 22:00:48 +0000
Bug 1500052 - Fix iterator cache to check getDenseInitializedLength() == 0 instead of hasEmptyElements(). r=evilpie
hasEmptyElements() is too pessimistic: arrays often have no elements but aren't
using the empty elements singleton.
Differential Revision:
https://phabricator.services.mozilla.com/D9083
7c5bf03859d2fb592ff5cca51552f2d1c0000893: Bug 1494647: Add flags section to CacheIR spew, and report dictionary mode r=evilpie
Matthew Gaudet <mgaudet@mozilla.com> - Mon, 15 Oct 2018 15:14:29 -0400 - rev 441435
Push
108984 by mgaudet@mozilla.com at Tue, 16 Oct 2018 13:17:48 +0000
Bug 1494647: Add flags section to CacheIR spew, and report dictionary mode r=evilpie
Differential Revision:
https://phabricator.services.mozilla.com/D8761
d912f4d60ea470d68383eb2f011993700bf4f7bf: Bug 1496863 - Remove an obsolete comment. r=evilpie
Jeff Walden <jwalden@mit.edu> - Thu, 04 Oct 2018 14:43:21 -0500 - rev 441023
Push
108890 by jwalden@mit.edu at Sat, 13 Oct 2018 01:02:18 +0000
Bug 1496863 - Remove an obsolete comment. r=evilpie
da12058b40be74451c19a1e4f37436c6bab190d8: Bug 1496863 - Use precise capture-lists for the various lambdas in CharacterEncoding.cpp, rather than using [&] and capturing everything willy-nilly by reference. r=evilpie
Jeff Walden <jwalden@mit.edu> - Thu, 04 Oct 2018 14:40:22 -0500 - rev 441022
Push
108890 by jwalden@mit.edu at Sat, 13 Oct 2018 01:02:18 +0000
Bug 1496863 - Use precise capture-lists for the various lambdas in CharacterEncoding.cpp, rather than using [&] and capturing everything willy-nilly by reference. r=evilpie
ed81d578d775d533862151e376c098df7c951a6f: Bug 1496863 - Add a constexpr char16_t unicode::REPLACEMENT_CHARACTER, and change the two (!) separate const char16_t variables of the same value in CharacterEncoding.cpp with it. r=evilpie
Jeff Walden <jwalden@mit.edu> - Thu, 04 Oct 2018 13:31:49 -0400 - rev 441021
Push
108890 by jwalden@mit.edu at Sat, 13 Oct 2018 01:02:18 +0000
Bug 1496863 - Add a constexpr char16_t unicode::REPLACEMENT_CHARACTER, and change the two (!) separate const char16_t variables of the same value in CharacterEncoding.cpp with it. r=evilpie
e3d6fb688839a56647d975ddaaa60fbeb6fd910f: Bug 1490348 - Improve CacheIR Spew for arrays r=evilpie
Matthew Gaudet <mgaudet@mozilla.com> - Thu, 20 Sep 2018 09:00:11 +0000 - rev 437530
Push
108083 by apavel@mozilla.com at Thu, 20 Sep 2018 22:03:01 +0000
Bug 1490348 - Improve CacheIR Spew for arrays r=evilpie
Differential Revision:
https://phabricator.services.mozilla.com/D6048
3aa7f81bfcb559a6f060283e5884177764129151: Bug 1490632 - Always use braces for if/for/while statements in js/ipc. r=evilpie
Jan de Mooij <jdemooij@mozilla.com> - Wed, 12 Sep 2018 20:04:14 +0000 - rev 436203
Push
107816 by nerli@mozilla.com at Thu, 13 Sep 2018 22:18:58 +0000
Bug 1490632 - Always use braces for if/for/while statements in js/ipc. r=evilpie
Differential Revision:
https://phabricator.services.mozilla.com/D5661
a946ea065650ac0422ad82c272496ff6290f5410: Bug 1488698 - Always use braces for if/for/while statements in js/src/jit, part 6. r=evilpie
Jan de Mooij <jdemooij@mozilla.com> - Thu, 06 Sep 2018 11:55:35 +0200 - rev 435727
Push
107708 by jandemooij@gmail.com at Tue, 11 Sep 2018 14:33:28 +0000
Bug 1488698 - Always use braces for if/for/while statements in js/src/jit, part 6. r=evilpie
bc503aa87b272bdcef98a35c9759e25a15031241: Bug 1488698 - Always use braces for if/for/while statements in js/src/proxy. r=evilpie
Jan de Mooij <jdemooij@mozilla.com> - Thu, 06 Sep 2018 10:43:19 +0200 - rev 435702
Push
107708 by jandemooij@gmail.com at Tue, 11 Sep 2018 14:33:28 +0000
Bug 1488698 - Always use braces for if/for/while statements in js/src/proxy. r=evilpie
506e668e28645f38b226ea203aed38b5b5f0b0e5: Bug 1488698 - Always use braces for if/for/while statements in js/src/builtin, part 3. r=evilpie
Jan de Mooij <jdemooij@mozilla.com> - Thu, 06 Sep 2018 10:17:41 +0200 - rev 435692
Push
107708 by jandemooij@gmail.com at Tue, 11 Sep 2018 14:33:28 +0000
Bug 1488698 - Always use braces for if/for/while statements in js/src/builtin, part 3. r=evilpie
ed3c662bb21dd708601519540c99e939abb12cff: Bug 1469019 - Object.fromEntries. r=evilpie, r=peterv
Jason Orendorff <jorendorff@mozilla.com> - Tue, 14 Aug 2018 13:25:30 -0500 - rev 432437
Push
106737 by jorendorff@mozilla.com at Mon, 20 Aug 2018 18:46:54 +0000
Bug 1469019 - Object.fromEntries. r=evilpie, r=peterv
fb7b47d50f5944c47791fe20ae21033393ec6957: Bug 1483806 - Guard CACHEIR_SPEW only member variable in NewObjectIRGenerator. r=evilpie
Matthew Gaudet <mgaudet@mozilla.com> - Thu, 16 Aug 2018 15:41:32 -0700 - rev 432125
Push
106641 by ryanvm@gmail.com at Fri, 17 Aug 2018 14:58:51 +0000
Bug 1483806 - Guard CACHEIR_SPEW only member variable in NewObjectIRGenerator. r=evilpie
45dd8818d922150a499cf1477455679b9819e475: Bug 1482364: Allow bitwise value comparison for strict-equals even when object emulates undefined. r=evilpie
André Bargull <andre.bargull@gmail.com> - Fri, 10 Aug 2018 02:58:54 -0700 - rev 431400
Push
106449 by ebalazs@mozilla.com at Tue, 14 Aug 2018 15:17:23 +0000
Bug 1482364: Allow bitwise value comparison for strict-equals even when object emulates undefined. r=evilpie
7791fe11b664cf5a1a19e99b32c92e228d8d0c27: Bug 1481229 part 2 - Always use the unwrapped object in Logging::formatObject. r=evilpie
Jan de Mooij <jdemooij@mozilla.com> - Tue, 07 Aug 2018 14:06:45 +0200 - rev 430322
Push
106123 by jandemooij@gmail.com at Tue, 07 Aug 2018 12:07:24 +0000
Bug 1481229 part 2 - Always use the unwrapped object in Logging::formatObject. r=evilpie
de88f2fd6d4d8895a8c3d174e630fbec58e628d1: Bug 1481229 part 1 - Remove unnecessary realm entering in JavaScriptShared::findObjectById. r=evilpie
Jan de Mooij <jdemooij@mozilla.com> - Tue, 07 Aug 2018 14:06:45 +0200 - rev 430321
Push
106123 by jandemooij@gmail.com at Tue, 07 Aug 2018 12:07:24 +0000
Bug 1481229 part 1 - Remove unnecessary realm entering in JavaScriptShared::findObjectById. r=evilpie
ToWindowProxyIfWindow does not rely on the current realm in any way.
16f5d9f58faab689ee88ebf568c5c504b2ac72ba: Bug 1477375 Ensure we actually disable all CacheIR Stubs when requested with --cache-ir-stubs=off. r=evilpie
Matthew Gaudet <mgaudet@mozilla.com> - Fri, 20 Jul 2018 15:47:40 -0400 - rev 427883
Push
105568 by cbrindusan@mozilla.com at Mon, 23 Jul 2018 22:53:36 +0000
Bug 1477375 Ensure we actually disable all CacheIR Stubs when requested with --cache-ir-stubs=off. r=evilpie
bb9cb191c067fad734ece7f89708de01fb66b341: Bug 1475177 - Change sendCommand xpcshell function to only accept plain JSFunction callbacks. r=evilpie
Jan de Mooij <jdemooij@mozilla.com> - Mon, 16 Jul 2018 14:02:16 +0200 - rev 426709
Push
105295 by jandemooij@gmail.com at Mon, 16 Jul 2018 12:03:36 +0000
Bug 1475177 - Change sendCommand xpcshell function to only accept plain JSFunction callbacks. r=evilpie
f490048b0495e8f2e6682ab2209d1172ea1cdbe7: Bug 1473255 - Restore caller realm in the interpreter after calling a JITted function. r=evilpie
Jan de Mooij <jdemooij@mozilla.com> - Thu, 05 Jul 2018 09:28:13 +0200 - rev 425140
Push
104983 by jandemooij@gmail.com at Thu, 05 Jul 2018 07:28:55 +0000
Bug 1473255 - Restore caller realm in the interpreter after calling a JITted function. r=evilpie
3030106b14f744524cfc33fec360e45396893e66: Bug 1471788: Apply ToNumber conversion even when the typed array write is out-of-bounds. r=evilpie
André Bargull <andre.bargull@gmail.com> - Fri, 29 Jun 2018 13:46:04 -0700 - rev 424483
Push
104833 by dluca@mozilla.com at Sat, 30 Jun 2018 00:01:48 +0000
Bug 1471788: Apply ToNumber conversion even when the typed array write is out-of-bounds. r=evilpie
f4aac816ce53532447a6794ff37a9952bc063307: Bug 1470890 - handle deserialization failure gracefully in JS IPC; r=evilpie
Alex Gaynor <agaynor@mozilla.com> - Wed, 27 Jun 2018 16:10:41 +0300 - rev 423898
Push
104687 by archaeopteryx@coole-files.de at Wed, 27 Jun 2018 13:13:13 +0000
Bug 1470890 - handle deserialization failure gracefully in JS IPC; r=evilpie
Summary: This primarily affects the efficiency of fuzzing.
Reviewers: evilpie
Reviewed By: evilpie
Bug #: 1470890
Differential Revision:
https://phabricator.services.mozilla.com/D1797
7b27e3b7aa9c2629744eba48da51dc85cae1ed90: Bug 1468816 - Add result to UnaryArith CacheIR spew. r=evilpie
Matthew Gaudet <mgaudet@mozilla.com> - Thu, 14 Jun 2018 11:38:21 -0700 - rev 423497
Push
104600 by csabou@mozilla.com at Mon, 25 Jun 2018 18:15:02 +0000
Bug 1468816 - Add result to UnaryArith CacheIR spew. r=evilpie
91899c39ed9ed09aebc5883c30ed79a194c38d9a: Bug 1470181 - handle deserialization failure gracefully in JS IPC; r=evilpie
Alex Gaynor <agaynor@mozilla.com> - Thu, 21 Jun 2018 18:47:08 +0000 - rev 423313
Push
104534 by ccoroiu@mozilla.com at Fri, 22 Jun 2018 10:01:10 +0000
Bug 1470181 - handle deserialization failure gracefully in JS IPC; r=evilpie
This primarily effects the efficiency of fuzzing.
Differential Revision:
https://phabricator.services.mozilla.com/D1751
e8d4a24e47a943db327206a4680fb75c156f9086: Bug 859782 - Firefox cannot start without /proc (chroot). r=sfink,evilpie,jld
Richard Pospesel <richard@torproject.org> - Tue, 19 Jun 2018 08:00:58 -0600 - rev 422956
Push
104406 by jedavis@mozilla.com at Tue, 19 Jun 2018 14:01:34 +0000
Bug 859782 - Firefox cannot start without /proc (chroot). r=sfink,evilpie,jld
Firefox uses the current stack frame address and the stack size
as a sort of heuristic for various things in the javascript
engine. The js::GetNativeStackBaseImpl() function is used to
get the base stack address (ie the address from which the stack
grows, so this can be either the first or last memory address of
the stack memory space depending on the CPU architecture).
On Linux, this function is implemented using the pthreads APIs.
For non-main threads, the queried thread info is stored in
memory. The main thread does not have this information on hand,
so it gets the stack memory range via the /proc/self/maps file
( see glibc's pthread_get_attr_np.c ).
Fortunately (per discussions with the firefox devs in #jsapi)
the base address only needs to be approximation. In reality,
environment variables, args, and other things are stored in space
between the end/beginning of the mapped stack memory and the 'top'
of the stack space used by stack frames.
We can get the top of this usable stack from __libc_stack_end,
which is a void* set by glibc during program initialization.
Non-main threads still get their stack-base through the usual
pthreads APIs.
db80d5a4d8e9f5d9f4356661cf8290f9f2b20ce1: Bug 1468406 part 3 - Add some obj->as<Foo>() casts to eliminate some JSObject::realm() calls. r=evilpie
Jan de Mooij <jdemooij@mozilla.com> - Mon, 18 Jun 2018 12:41:28 -0700 - rev 422855
Push
104378 by jandemooij@gmail.com at Mon, 18 Jun 2018 19:42:18 +0000
Bug 1468406 part 3 - Add some obj->as<Foo>() casts to eliminate some JSObject::realm() calls. r=evilpie
d2931773b28b393aa565dca8da2f4a765fbbdacf: Bug 1468252 part 6 - Use isSelfHostingZone instead of isSelfHostingGlobal in getNonWrapperObjectForCurrentCompartment. r=evilpie
Jan de Mooij <jdemooij@mozilla.com> - Thu, 14 Jun 2018 09:07:31 -0700 - rev 422546
Push
104289 by jandemooij@gmail.com at Thu, 14 Jun 2018 16:13:19 +0000
Bug 1468252 part 6 - Use isSelfHostingZone instead of isSelfHostingGlobal in getNonWrapperObjectForCurrentCompartment. r=evilpie
09901c91248bf67c695540ac0bebf2212802feeb: Bug 1468252 part 2 - Rename GetOriginalEval to GetRealmOriginalEval, remove scope argument. r=evilpie
Jan de Mooij <jdemooij@mozilla.com> - Thu, 14 Jun 2018 09:07:30 -0700 - rev 422542
Push
104289 by jandemooij@gmail.com at Thu, 14 Jun 2018 16:13:19 +0000
Bug 1468252 part 2 - Rename GetOriginalEval to GetRealmOriginalEval, remove scope argument. r=evilpie
db248a2fb2024b0da563724cdb0abd85857d8919: Bug 1468137 - Remove JS_Get*Prototype APIs; use JS::GetRealm*Prototype instead. r=evilpie
Jan de Mooij <jdemooij@mozilla.com> - Wed, 13 Jun 2018 12:47:40 -0700 - rev 422427
Push
104257 by jandemooij@gmail.com at Wed, 13 Jun 2018 19:49:58 +0000
Bug 1468137 - Remove JS_Get*Prototype APIs; use JS::GetRealm*Prototype instead. r=evilpie
6f29a4a9da707b28058a425749a7d7335fe5ae68: Bug 1465860 - Don't crash in JS IPC on invalid object id. r=evilpie
Alex Gaynor <agaynor@mozilla.com> - Thu, 31 May 2018 16:29:03 -0400 - rev 421383
Push
104043 by aiakab@mozilla.com at Tue, 05 Jun 2018 22:11:53 +0000
Bug 1465860 - Don't crash in JS IPC on invalid object id. r=evilpie
Instead, return an error up to the caller, who can return an IPC error, which
will kill the child. This is significantly friendlier to fuzzing.
MozReview-Commit-ID: C67xSqUeN1i
8af7dd4fb5e201208f018e484c93b101e2fa3212: Bug 1464134 part 4 - Rename CompileCompartment to CompileRealm. r=evilpie
Jan de Mooij <jdemooij@mozilla.com> - Wed, 30 May 2018 16:53:49 +0200 - rev 420459
Push
103816 by jandemooij@gmail.com at Wed, 30 May 2018 14:56:56 +0000
Bug 1464134 part 4 - Rename CompileCompartment to CompileRealm. r=evilpie
d99b7e4e8cd9b6f7afece1e166d9a881a192b926: Bug 1461938 part 40 - Use private inheritance. r=evilpie
Jan de Mooij <jdemooij@mozilla.com> - Fri, 25 May 2018 11:12:04 +0200 - rev 419795
Push
103625 by jandemooij@gmail.com at Fri, 25 May 2018 09:12:37 +0000
Bug 1461938 part 40 - Use private inheritance. r=evilpie
72b513e25bec2ed1aeee15c47eaf98d533e68fb9: Bug 1461938 part 29 - Move validAccessPtr to JS::Realm. r=evilpie
Jan de Mooij <jdemooij@mozilla.com> - Wed, 23 May 2018 19:45:03 +0200 - rev 419490
Push
103552 by jandemooij@gmail.com at Wed, 23 May 2018 17:51:29 +0000
Bug 1461938 part 29 - Move validAccessPtr to JS::Realm. r=evilpie