searching for reviewer(emilio)
3ec96c0dd69655f71c67e434e589fe745dc05200: Bug 1597348: When reflow is interrupted, purge flex items' cached measurements during the same traversal that we use to mark ancestor-chain as dirty. r=emilio
Daniel Holbert <dholbert@cs.stanford.edu> - Mon, 18 Nov 2019 19:19:42 +0000 - rev 502457
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1597348: When reflow is interrupted, purge flex items' cached measurements during the same traversal that we use to mark ancestor-chain as dirty. r=emilio This means we no longer have any use for the frame state bit "NS_STATE_FLEX_MEASUREMENTS_INTERRUPTED". Now, if a flex container has N children and only the last child is interrupted, we'll only purge the last child's measurement (and we'll do it promptly at the end of the whole interrupted reflow). Differential Revision: https://phabricator.services.mozilla.com/D53687
b42230b2ad6e97d7399a608d5297348a1906a754: Bug 1597177: Make flex containers check for interruptions a bit earlier (right after the measurement whose interruption they care about). r=emilio
Daniel Holbert <dholbert@cs.stanford.edu> - Mon, 18 Nov 2019 18:16:59 +0000 - rev 502449
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1597177: Make flex containers check for interruptions a bit earlier (right after the measurement whose interruption they care about). r=emilio Differential Revision: https://phabricator.services.mozilla.com/D53670
34f0f8db631a206ab5115baa73c13bcd7c2f36ea: Bug 1579929: When a reflow is interrupted, don't purge flex item measurements until the next time they're needed in a later non-interrupted reflow. r=emilio
Daniel Holbert <dholbert@cs.stanford.edu> - Mon, 18 Nov 2019 06:49:06 +0000 - rev 502376
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1579929: When a reflow is interrupted, don't purge flex item measurements until the next time they're needed in a later non-interrupted reflow. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D53313
44a3e5f050de4aff4e3080532319595185f1db3a: Bug 1586444 - Avoid styling scrollbar part children of object elements with vertical-align. r=emilio
Cameron McCormack <cam@mcc.id.au> - Sun, 17 Nov 2019 23:17:34 +0000 - rev 502359
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1586444 - Avoid styling scrollbar part children of object elements with vertical-align. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D53124
998d992ca22bda687da401a82ddb42afc10af96a: Bug 1594946 - Treat 3d translate/scale as 2d if the value can be expressed as 2d. r=emilio
Boris Chiou <boris.chiou@gmail.com> - Fri, 15 Nov 2019 19:38:24 +0000 - rev 502273
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1594946 - Treat 3d translate/scale as 2d if the value can be expressed as 2d. r=emilio For the individual transform properties if they spec a value that can be expressed as 2d we treat as 2d and serialize accordingly. We drop Translate::Translate and Scale::Scale, and then rename Translate::Translate3D as Translate::Translate, Scale::Scale3D as Scale::Scale. So now we use Translate::Translate to represent 2d and 3d translation, and Scale::Scale to represent 2d and 3d scale. There is no difference between 2d and 3d translate/scale in Gecko because we always convert them into 3d format to layers (on the compositor thread), so this change makes things simpler. Differential Revision: https://phabricator.services.mozilla.com/D52931
6514e3ddd69bd92dad544554768b5fa3c4960613: Bug 1592189 - Remove SpecialColorKeyword enum and merge into SystemColor r=emilio
Sam Mauldin <sam@mauldin.me> - Thu, 14 Nov 2019 00:17:23 +0000 - rev 501896
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1592189 - Remove SpecialColorKeyword enum and merge into SystemColor r=emilio Move all the entires of SpecialColorKeyword into SystemColor and rearrange their computation to match. Add the new SystemColor entries into the property list of nsXPLookAndFeel. Differential Revision: https://phabricator.services.mozilla.com/D50903
9f96406e2da19b6d4e9f89163ff51c4e529779ae: Bug 1586144 - Factor dynamic toolbar max height into layout metrics. r=emilio,botond
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Thu, 14 Nov 2019 06:00:05 +0000 - rev 501889
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1586144 - Factor dynamic toolbar max height into layout metrics. r=emilio,botond Now * nsPresContext::mVisibleArea is excluding the toolbar max height so that ICB is now static regardless of the dynamic toolbar transition * nsPresContext::mSizeForViewportUnits is introduced to resolve viewport units which is including the toolbar max height That means that with the dynamic toolbar max height; mVisibleArea < mSizeForViewportUnits See https://github.com/bokand/URLBarSizing for more detail backgrounds of this change. Depends on D50417 Differential Revision: https://phabricator.services.mozilla.com/D50418
96695741c87a1557ed6122a5606fa22cc43408fb: Bug 1562642 - add missing license in layout/style/tools/ r=emilio
Sylvestre Ledru <sledru@mozilla.com> - Wed, 13 Nov 2019 09:27:25 +0000 - rev 501721
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1562642 - add missing license in layout/style/tools/ r=emilio Depends on D52592 Differential Revision: https://phabricator.services.mozilla.com/D52593
b30cd570f78dccede3891c605aefaaacfc80816f: Bug 1356712 - Remove bogus assertions. r=emilio
Mats Palmgren <mats@mozilla.com> - Tue, 12 Nov 2019 19:09:13 +0000 - rev 501639
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1356712 - Remove bogus assertions. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D52678
84bbca86710f4006bb192a4847b9ab3522b826da: Bug 1595103 - [css-pseudo] Skip all ::marker boxes when finding content for a ::first-letter. r=emilio
Mats Palmgren <mats@mozilla.com> - Mon, 11 Nov 2019 19:28:34 +0000 - rev 501507
Push 114170 by malexandru@mozilla.com at Tue, 12 Nov 2019 21:58:32 +0000
Bug 1595103 - [css-pseudo] Skip all ::marker boxes when finding content for a ::first-letter. r=emilio Per discussion in: https://github.com/w3c/csswg-drafts/issues/4503 Differential Revision: https://phabricator.services.mozilla.com/D52544
d9fa29c55c42606dd014abe3816667384d19288e: Bug 1492582 - Don't create scroll frames for windows that don't need them. r=emilio
Brendan Dahl <bdahl@mozilla.com> - Fri, 08 Nov 2019 23:34:08 +0000 - rev 501407
Push 114169 by ncsoregi@mozilla.com at Mon, 11 Nov 2019 12:39:11 +0000
Bug 1492582 - Don't create scroll frames for windows that don't need them. r=emilio When browser.xhtml switches to an <html> root element, the frame structure changed and caused performance regressions on talos for tart and tresize. browser.xhtml doesn't need scrolling, so we can disable it and keep performance on par with XUL <window>. Differential Revision: https://phabricator.services.mozilla.com/D50675
bbf62ef50e529b304b8fab6a211cd244ff0291f1: Bug 1492582 - Don't create scroll frames for windows that don't need them. r=emilio
Brendan Dahl <bdahl@mozilla.com> - Thu, 07 Nov 2019 16:21:23 +0000 - rev 501105
Push 114168 by dluca@mozilla.com at Sun, 10 Nov 2019 03:08:55 +0000
Bug 1492582 - Don't create scroll frames for windows that don't need them. r=emilio When browser.xhtml switches to an <html> root element, the frame structure changed and caused performance regressions on talos for tart and tresize. browser.xhtml doesn't need scrolling, so we can disable it and keep performance on par with XUL <window>. Differential Revision: https://phabricator.services.mozilla.com/D50675
f2c17f2a388c97c41f16be6f944cd2aa776d3fd2: Bug 1593752 - When inserting canonical <body> element, reframe root element only if their used WritingModes are different. r=emilio
Ting-Yu Lin <tlin@mozilla.com> - Wed, 06 Nov 2019 05:50:12 +0000 - rev 500787
Push 114166 by apavel@mozilla.com at Thu, 07 Nov 2019 10:04:01 +0000
Bug 1593752 - When inserting canonical <body> element, reframe root element only if their used WritingModes are different. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D51889
ff9cd9a275796006bc19d706b77b7319fd335d0c: Bug 1592389 - Rename Mozfield / Mozfieldtext to Field and Fieldtext r=emilio
Sam Mauldin <sam@mauldin.me> - Sat, 02 Nov 2019 21:28:49 +0000 - rev 500283
Push 114164 by aiakab@mozilla.com at Tue, 05 Nov 2019 10:06:15 +0000
Bug 1592389 - Rename Mozfield / Mozfieldtext to Field and Fieldtext r=emilio Split off of Bug 1590894 Rename these to support unprefixed version Also add alias to keep compatibility Differential Revision: https://phabricator.services.mozilla.com/D50989
7e71a2643d865295c23182d7fd5bb76311c93490: Bug 1429305 - Use serde to serialize LengthPercentage and StyleRayFunction. r=emilio
Boris Chiou <boris.chiou@gmail.com> - Thu, 31 Oct 2019 21:35:05 +0000 - rev 500101
Push 114164 by aiakab@mozilla.com at Tue, 05 Nov 2019 10:06:15 +0000
Bug 1429305 - Use serde to serialize LengthPercentage and StyleRayFunction. r=emilio We need to pass these two types into the compositor, so we need a better way to serialize these rust types. We use serde and bincode to serialize/deserialize them, and use ByteBuf to pass the &[u8] data through IPC. We define StyleVecU8 for FFI usage only. Differential Revision: https://phabricator.services.mozilla.com/D50688
ec25a8482342f3e432f2fdfcddd42a6ed88bd249: Bug 1592389 - Rename Mozfield / Mozfieldtext to Field and Fieldtext r=emilio
Sam Mauldin <sam@mauldin.me> - Wed, 30 Oct 2019 05:51:38 +0000 - rev 499739
Push 114163 by aiakab@mozilla.com at Thu, 31 Oct 2019 10:03:38 +0000
Bug 1592389 - Rename Mozfield / Mozfieldtext to Field and Fieldtext r=emilio Split off of Bug 1590894 Rename these to support unprefixed version Also add alias to keep compatibility Differential Revision: https://phabricator.services.mozilla.com/D50989
f05adbd31552e043baf72befdc5fa92e38819d90: Bug 1575734 - Adjust reftest fuzziness for webkit-text-stroke-property-001.html. r=emilio
Nicolas Silva <nsilva@mozilla.com> - Mon, 28 Oct 2019 13:42:50 +0000 - rev 499582
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1575734 - Adjust reftest fuzziness for webkit-text-stroke-property-001.html. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D50799
2ad86db20795ad16575d25bf512c1f0ebb8bd2ae: Bug 1590971 - Move getAnimations from Document to DocumentOrShadowRoot; r=emilio,baku
Brian Birtles <birtles@gmail.com> - Tue, 29 Oct 2019 07:13:22 +0000 - rev 499566
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1590971 - Move getAnimations from Document to DocumentOrShadowRoot; r=emilio,baku This updates the Gecko implementation to match the following change to the Web Animations spec: https://github.com/w3c/csswg-drafts/commit/792453b952ecf4623fab33263426d86792a1cb26#diff-4c9f5c055fb219a7fcad23a9a7a80b64 Differential Revision: https://phabricator.services.mozilla.com/D50768
b46a40b2287cbb660157bcc4eed53c5ca7e6f012: Bug 1588025 - Make the custom content container a font inflation root. r=emilio
Ting-Yu Lin <tlin@mozilla.com> - Mon, 28 Oct 2019 20:42:06 +0000 - rev 499556
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1588025 - Make the custom content container a font inflation root. r=emilio font-inflation-1e.html is adapted from font-inflation-1a.html with the writing-mode set on <html> instead of <body>. It can trigger the assertion "current writing mode should match that of our flow root" in nsFontInflationData::FindFontInflationDataFor(). The root cause is: nsCanvasFrame can generate the position:absolute custom content container to contain elements like AccessibleCaret. When the container is constructed, the container's writing-mode is always horizontal-rl, which is getting from nsCanvasFrame that uses ViewportFrame's style. If <html> has a vertical writing-mode, custom content container's used mWritingMode becomes orthogonal to ViewportFrame, because <html>'s used mWritingMode is propagated all the way up to ViewportFrame. This patch solves the above issue by making the custom content container a font inflation root, so FindFontInflationDataFor() stops at it instead of finding all the way up to the ViewportFrame. Differential Revision: https://phabricator.services.mozilla.com/D48942
0d1ad0f881d163541c3d01bc0ddc3b89c8a48dc2: Bug 1561227 Part 2: Define and fire an internal event when BrowserChild has finished resizing. r=botond,emilio
Brad Werth <bwerth@mozilla.com> - Fri, 25 Oct 2019 21:05:48 +0000 - rev 499361
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1561227 Part 2: Define and fire an internal event when BrowserChild has finished resizing. r=botond,emilio This event is useful for tests that resize the RDM pane and need to know when all resolution adjusting effects are complete. Differential Revision: https://phabricator.services.mozilla.com/D47364
4c212479e5caad8c8d5620c0963fb7eff7d1275f: Bug 1561227 Part 1: Make nsDocumentViewer send a new event before setting full zoom levels on the pres contexts. r=emilio
Brad Werth <bwerth@mozilla.com> - Fri, 25 Oct 2019 21:05:42 +0000 - rev 499360
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1561227 Part 1: Make nsDocumentViewer send a new event before setting full zoom levels on the pres contexts. r=emilio The PreFullZoomChange event gives listeners an opportunity to capture state before the viewport full zoom changes. Responsive Design Mode uses this to save and later restore the resolution of the RDM pane. Differential Revision: https://phabricator.services.mozilla.com/D48621
3f3c83611ba568212e71167744dce7db2d11c947: Bug 1591622 - Improve BUGZILLA_COMPONENT metadata for web-platform-tests css/ subdirectory. r=emilio
L. David Baron <dbaron@dbaron.org> - Sat, 26 Oct 2019 17:26:36 +0000 - rev 499359
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1591622 - Improve BUGZILLA_COMPONENT metadata for web-platform-tests css/ subdirectory. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D50685
712c3e31d0973065313696223ec9fe2b40f1761d: Bug 1587645 Part 1 - Remove ScrollFrameHelper::GetFrameForDir(). r=emilio
Ting-Yu Lin <tlin@mozilla.com> - Fri, 25 Oct 2019 20:01:39 +0000 - rev 499333
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1587645 Part 1 - Remove ScrollFrameHelper::GetFrameForDir(). r=emilio After bug 1102175, the root scroll frame always obtains its used WritingMode from either body element or root element. The `if (mIsRoot) {}` block in `GetFrameForDir()` becomes redundant, so does `GetFrameForDir()` itself. Differential Revision: https://phabricator.services.mozilla.com/D49817
cfcf797940499df388b85b0000acf6ef2e1969b4: Bug 1561227 Part 2: Define and fire an internal event when BrowserChild has finished resizing. r=botond,emilio
Brad Werth <bwerth@mozilla.com> - Thu, 24 Oct 2019 23:42:52 +0000 - rev 499311
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1561227 Part 2: Define and fire an internal event when BrowserChild has finished resizing. r=botond,emilio This event is useful for tests that resize the RDM pane and need to know when all resolution adjusting effects are complete. Differential Revision: https://phabricator.services.mozilla.com/D47364
97be65338edfd0f6f220acaded6502a7f844c4e1: Bug 1561227 Part 1: Make nsDocumentViewer send a new event before setting full zoom levels on the pres contexts. r=emilio
Brad Werth <bwerth@mozilla.com> - Thu, 24 Oct 2019 23:42:50 +0000 - rev 499310
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1561227 Part 1: Make nsDocumentViewer send a new event before setting full zoom levels on the pres contexts. r=emilio The PreFullZoomChange event gives listeners an opportunity to capture state before the viewport full zoom changes. Responsive Design Mode uses this to save and later restore the resolution of the RDM pane. Differential Revision: https://phabricator.services.mozilla.com/D48621
740e4d4bdfff8725438e7234d21f69fc8685cfae: Bug 1588860 - add missing quote r=emilio
Andreea Pavel <apavel@mozilla.com> - Fri, 25 Oct 2019 22:02:25 +0300 - rev 499299
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1588860 - add missing quote r=emilio
a7f3501e9f4cdb991ea8202e80196dd96df46aef: Bug 1588860 - invert condition in update-the-rendering.html expectancy on a CLOSED TREE r=emilio
Andreea Pavel <apavel@mozilla.com> - Fri, 25 Oct 2019 21:43:43 +0300 - rev 499297
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1588860 - invert condition in update-the-rendering.html expectancy on a CLOSED TREE r=emilio
fe035a7f97c942a31aa820709a0cc0b64fd8fd11: Bug 1588860 - update update-the-rendering.html expectancies r=botond,emilio
Andreea Pavel <apavel@mozilla.com> - Fri, 25 Oct 2019 18:09:53 +0000 - rev 499294
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1588860 - update update-the-rendering.html expectancies r=botond,emilio Differential Revision: https://phabricator.services.mozilla.com/D50217
f8b8e593316fe9f39ae4fabc72c0308000824582: Bug 1561227 Part 2: Define and fire an internal event when BrowserChild has finished resizing. r=botond,emilio
Brad Werth <bwerth@mozilla.com> - Thu, 24 Oct 2019 16:48:40 +0000 - rev 499153
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1561227 Part 2: Define and fire an internal event when BrowserChild has finished resizing. r=botond,emilio This event is useful for tests that resize the RDM pane and need to know when all resolution adjusting effects are complete. Differential Revision: https://phabricator.services.mozilla.com/D47364
849e1cf51a8fb895860497b3d9addf1a2ccb7af6: Bug 1561227 Part 1: Make nsDocumentViewer send a new event before setting full zoom levels on the pres contexts. r=emilio
Brad Werth <bwerth@mozilla.com> - Thu, 24 Oct 2019 16:48:14 +0000 - rev 499152
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1561227 Part 1: Make nsDocumentViewer send a new event before setting full zoom levels on the pres contexts. r=emilio The PreFullZoomChange event gives listeners an opportunity to capture state before the viewport full zoom changes. Responsive Design Mode uses this to save and later restore the resolution of the RDM pane. Differential Revision: https://phabricator.services.mozilla.com/D48621
54471d01065b459d156c6a4e1a241bc8f40daf0c: Bug 1590639 part 6: Fix non-unified build issues in layout/inspector. r=emilio
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 24 Oct 2019 17:15:32 +0000 - rev 499131
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1590639 part 6: Fix non-unified build issues in layout/inspector. r=emilio This patch: - Gives ServoStyleRuleMap.cpp an include for Element.h (to provide that type). - Gives inDeepTreeWalker.cpp a mozilla::dom prefix for its one use of Document. - Gives inLayoutUtils.cpp a "using" decl for mozilla::dom, so we can compile with the many un-namespaced "Document" and "Element" usages in that file. Depends on D50167 Differential Revision: https://phabricator.services.mozilla.com/D50168
5b8a4bd4937a2fc64cefda21933a1489559426bc: Bug 1590639 part 5: Fix non-unified build issues in layout/svg. r=emilio
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 23 Oct 2019 08:16:45 +0000 - rev 499130
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1590639 part 5: Fix non-unified build issues in layout/svg. r=emilio This patch: - Gives SVGFELeafFrame.cpp and SVGFEUnstyledLeafFrame.cpp the correct namespace-prefixing in some static_cast operation, and changes the capturing variable to be "auto*" to avoid repeating the long typename. - Gives nsSVGContainerFrame.cpp, nsSVGIntegrationUtils.cpp, and nsSVGSwitchFrame.cpp a "using namespace mozilla::dom" decl, so that their multiple unprefixed SVGElement* usages become valid. - Gives nsFilterInstance.h a forward-decl for WrFiltersHolder (which it uses in function declarations) - Gives nsFilterInstance.cpp an include for nsSVGIntegrationUtils.h to provide the WrFiltersHolder type (which it uses). - Gives nsSVGPatternFrame.h mozilla-namespace prefixes before all its SVGAniated* type usages, to make them valid. Depends on D50166 Differential Revision: https://phabricator.services.mozilla.com/D50167
9d5a94668e7dcd5ec183cd62743ed263bca5ef53: Bug 1590639 part 4: Fix non-unified build issues in layout/style. r=emilio
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 23 Oct 2019 08:14:54 +0000 - rev 499129
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1590639 part 4: Fix non-unified build issues in layout/style. r=emilio This patch: - Gives layout/generic/AnonymousContentKey.h an include for `<stdint.h>` to provide the uint8_t type, and TypedEnumBits.h to provide the MOZ_MAKE_ENUM_CLASS_BITWISE_OPERATORS macro. (This is a change in another directory, but it's needed in order for layout/style/ServoStyleSet.cpp to build successfully.) - Adds a missing "nsINode" forward-decl to dom/base/IdentifierMapEntry.h, because it uses that type in function declarations. (This change is needed in order for layout/style/CachedInheritingStyles.cpp to build successfully.) - Gives CSSStyleRule.cpp an include for PseudoStyleType.h, nsCSSPseudoElements.h, and CSSEnabledState.h because it uses those types. - Gives GeckoBindings.cpp an include for gfxTextRun.h, to provide the definition of type gfxFontGroup (so GeckoBindings can call GetFirstValidFont() on an object of that type). - Gives Loader.h an include for nsIContentInlines.h, to provide the inline function IsInUAWidget(). - Gives Rule.cpp an include for HoldDropJSObjects.h, to provide DropJSObjects(). - Gives nsImageLoader.cpp an include for DocumentInlines.h (and Document.h for good measure), to provide the inline function GetPresContext(). - Gives nsStyleStruct.cpp an include for DocumentInlines.h, to provide inline function Document::GetPresContext(). - Gives nsStyleTransformMatrix.h an include for Units.h (instead of gfxPoint.h, which isn't useful) to provide the CSSPoint type. - Gives nsStyleTransformMatrix.h an include for ServoStyleConsts.h, to provide LengthPercentage and the various StyleRotate/StyleScale/StyleTransform/etc types. (These can't be easily forward-declared, because some of them are legitimate types whereas others are type aliases. We could theoretically forward-declare all of the underlying types and then repeat the type aliases, but that'd be verbose and unmaintainable.) Depends on D50165 Differential Revision: https://phabricator.services.mozilla.com/D50166
7932e22365f49295618bee753d2e78a44dad69a8: Bug 1585880 - Ensure pointer-events inherits into scrollbar parts. r=emilio
Cameron McCormack <cam@mcc.id.au> - Wed, 16 Oct 2019 08:20:56 +0000 - rev 498650
Push 114159 by shindli@mozilla.com at Thu, 24 Oct 2019 09:49:00 +0000
Bug 1585880 - Ensure pointer-events inherits into scrollbar parts. r=emilio Like visibility, we rely on pointer-events values inheriting down into scrollbar part elements. So don't cached NAC styles for scrollbar parts if we have a non-initial value for pointer-events, and adjust the UA style sheet rules to ensure it is always inherited. Differential Revision: https://phabricator.services.mozilla.com/D49359
98575a5ca794cb67b8d569e8a95188a30532e336: Bug 992384 - Make sure we always propagate root element's mWritingMode. r=emilio
Ting-Yu Lin <tlin@mozilla.com> - Fri, 18 Oct 2019 09:16:01 +0000 - rev 498266
Push 114157 by nbeleuzu@mozilla.com at Mon, 21 Oct 2019 22:00:13 +0000
Bug 992384 - Make sure we always propagate root element's mWritingMode. r=emilio Bug 1102175 Part 1 only handles HTML documents correctly because they always have a body element (even if the <body> tag is not written explicitly in the document). For SVG documents and all other documents lacking <body> element, we always want to propagate mWritingMode from the root element, which is our old behavior prior to Bug 1102175. Note that mDocElementContainingBlock (i.e. nsCanvasFrame) is using viewport's style, so we need to use the root element's computed style to compute WritingMode for propagating. Differential Revision: https://phabricator.services.mozilla.com/D49695
52a520cb41e2fac41a1fa3d24f6639ce0349cd18: Bug 1587577 - Remove support for the mfenced element. r=emilio
Frederic Wang <fred.wang@free.fr> - Thu, 17 Oct 2019 15:53:31 +0000 - rev 498068
Push 114157 by nbeleuzu@mozilla.com at Mon, 21 Oct 2019 22:00:13 +0000
Bug 1587577 - Remove support for the mfenced element. r=emilio See https://groups.google.com/forum/#!topic/mozilla.dev.platform/DHO72glZxA0 Differential Revision: https://phabricator.services.mozilla.com/D49320
e9387d7085357dc80e34ee1aaf49c4f813135311: Bug 1587572 - Remove support for the mfrac@bevelled attribute. r=emilio
Frederic Wang <fred.wang@free.fr> - Thu, 17 Oct 2019 09:41:06 +0000 - rev 498022
Push 114157 by nbeleuzu@mozilla.com at Mon, 21 Oct 2019 22:00:13 +0000
Bug 1587572 - Remove support for the mfrac@bevelled attribute. r=emilio See https://groups.google.com/forum/#!topic/mozilla.dev.platform/9pEvlYn-Xyw Differential Revision: https://phabricator.services.mozilla.com/D49299
4f934e73d44c0c4ee0e09aa5e4d463b435f4f322: Bug 1468131 - Avoid a ubsan complaint in GetTrimmableWhitespaceCount r=emilio
David Major <dmajor@mozilla.com> - Tue, 15 Oct 2019 22:59:51 +0000 - rev 497904
Push 114154 by btara@mozilla.com at Thu, 17 Oct 2019 09:58:40 +0000
Bug 1468131 - Avoid a ubsan complaint in GetTrimmableWhitespaceCount r=emilio ubsan was complaining about the expression ``` const char* str = aFrag->Get1b() + aStartOffset; ``` when `aFrag->Get1b() == nullptr` and `aStartOffset == -1`, because the addition generates an invalid pointer. Due to other logic in the function, we would never dereference that pointer, so it was reasonably harmless, but this patch silences the complaint. Differential Revision: https://phabricator.services.mozilla.com/D49345
fe2312ad6c4fd03510106cfdbe51480ffcff031d: Bug 1587570 - Remove support for the subscriptshift and superscriptshift attributes. r=emilio
Frederic Wang <fred.wang@free.fr> - Wed, 16 Oct 2019 11:57:13 +0000 - rev 497834
Push 114154 by btara@mozilla.com at Thu, 17 Oct 2019 09:58:40 +0000
Bug 1587570 - Remove support for the subscriptshift and superscriptshift attributes. r=emilio See https://groups.google.com/forum/#!topic/mozilla.dev.platform/CAqw0Nxw6Pg Differential Revision: https://phabricator.services.mozilla.com/D48766
972db326c3754792b29dfa649d7dc18950431421: Bug 1587570 - Remove support for the subscriptshift and superscriptshift attributes. r=emilio
Frederic Wang <fred.wang@free.fr> - Wed, 16 Oct 2019 07:57:38 +0000 - rev 497790
Push 114154 by btara@mozilla.com at Thu, 17 Oct 2019 09:58:40 +0000
Bug 1587570 - Remove support for the subscriptshift and superscriptshift attributes. r=emilio See https://groups.google.com/forum/#!topic/mozilla.dev.platform/CAqw0Nxw6Pg Differential Revision: https://phabricator.services.mozilla.com/D48766
aca2b79cc52a12dee6e49c09d6a580ddb4937863: Bug 1587235 - Report missing include filename in ServoBindings.toml. r=emilio
Cameron McCormack <cam@mcc.id.au> - Wed, 09 Oct 2019 10:44:29 +0000 - rev 497541
Push 114152 by dvarga@mozilla.com at Tue, 15 Oct 2019 11:14:34 +0000
Bug 1587235 - Report missing include filename in ServoBindings.toml. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D48625
deb30855228644a17c206a99d45ab248f05f542c: Bug 1588066 - Remove remaining references to textbox. r=surkov,emilio,webdriver-reviewers,bgrins,whimboo
Tim Nguyen <ntim.bugs@gmail.com> - Mon, 14 Oct 2019 07:41:35 +0000 - rev 497455
Push 114152 by dvarga@mozilla.com at Tue, 15 Oct 2019 11:14:34 +0000
Bug 1588066 - Remove remaining references to textbox. r=surkov,emilio,webdriver-reviewers,bgrins,whimboo Differential Revision: https://phabricator.services.mozilla.com/D48958
7fc0a96a5ca10811216de69f4f54b7a13e3fee28: Bug 1588290 - Added missing include of WindowProxyHolder.h to nsGlobalWindowInner.h. r=emilio a=bustage-fix
Jorg K <jorgk@jorgk.com> - Sat, 12 Oct 2019 18:21:47 +0200 - rev 497368
Push 114148 by shindli@mozilla.com at Mon, 14 Oct 2019 10:49:50 +0000
Bug 1588290 - Added missing include of WindowProxyHolder.h to nsGlobalWindowInner.h. r=emilio a=bustage-fix MANUAL PUSH: bustage fix for Thunderbird
6fb1aac6edac2d306141cf141c31292c6165070d: Bug 1587624 - Add a console log when we propagate principal writing-mode from <body>. r=emilio
Ting-Yu Lin <tlin@mozilla.com> - Thu, 10 Oct 2019 17:58:33 +0000 - rev 497352
Push 114148 by shindli@mozilla.com at Mon, 14 Oct 2019 10:49:50 +0000
Bug 1587624 - Add a console log when we propagate principal writing-mode from <body>. r=emilio I use `warningFlag` instead of `infoFlag` because even if the principal writing-mode propagation is written in the spec, its effect might surprise the developers. Differential Revision: https://phabricator.services.mozilla.com/D48774
f0ce1a1f84cba2d5313fa46adbc8e04edec85835: Bug 1587905 - Remove useless variable 'subdocFrame' declaration & assignation r=emilio
Sylvestre Ledru <sledru@mozilla.com> - Fri, 11 Oct 2019 07:34:05 +0000 - rev 497248
Push 114148 by shindli@mozilla.com at Mon, 14 Oct 2019 10:49:50 +0000
Bug 1587905 - Remove useless variable 'subdocFrame' declaration & assignation r=emilio Differential Revision: https://phabricator.services.mozilla.com/D48889
91cbf903d83bb329b355f5dcffe3968b8890c474: Bug 1587368 - servo: Update html5ever to 0.24. r=emilio
Anthony Ramine <nox@nox.paris> - Fri, 27 Sep 2019 13:24:49 +0200 - rev 496955
Push 114147 by ccoroiu@mozilla.com at Thu, 10 Oct 2019 09:56:56 +0000
Bug 1587368 - servo: Update html5ever to 0.24. r=emilio
f927a9563d591a9478abf1b72e4411f71084c7a8: Bug 1587368 - servo: WebIDL codegen: Replace cmake with a single Python script. r=emilio
Simon Sapin <simon.sapin@exyr.org> - Fri, 27 Sep 2019 06:37:54 +0200 - rev 496954
Push 114147 by ccoroiu@mozilla.com at Thu, 10 Oct 2019 09:56:56 +0000
Bug 1587368 - servo: WebIDL codegen: Replace cmake with a single Python script. r=emilio When playing around with Cargo’s new timing visualization: https://internals.rust-lang.org/t/exploring-crate-graph-build-times-with-cargo-build-ztimings/10975/21 … I was surprised to see the `script` crate’s build script take 76 seconds. I did not expect WebIDL bindings generation to be *that* computationally intensive. It turns out almost all of this time is overhead. The build script uses CMake to generate bindings for each WebIDL file in parallel, but that causes a lot of work to be repeated 366 times: * Starting up a Python VM * Importing (parts of) the Python standard library * Importing ~16k lines of our Python code * Recompiling the latter to bytecode, since we used `python -B` to disable writing `.pyc` file * Deserializing with `cPickle` and recreating in memory the results of parsing all WebIDL files ---- This commit remove the use of CMake and cPickle for the `script` crate. Instead, all WebIDL bindings generation is done sequentially in a single Python process. This takes 2 to 3 seconds.
7deccd22ae6a97169e9e895e2baddf587a24965a: Bug 1587368 - servo: Fix error message for invalid combination of style crate feature flags. r=emilio
Simon Sapin <simon.sapin@exyr.org> - Wed, 25 Sep 2019 15:11:00 +0200 - rev 496953
Push 114147 by ccoroiu@mozilla.com at Thu, 10 Oct 2019 09:56:56 +0000
Bug 1587368 - servo: Fix error message for invalid combination of style crate feature flags. r=emilio Instead of ``cannot find value `engine` in this scope`` https://github.com/servo/servo/issues/24284
259e2fe150bbdb83e924c4d1107da4c7d8176a69: Bug 1587368 - servo: Uncomment more stuff related to box construction. r=emilio
Anthony Ramine <nox@nox.paris> - Thu, 19 Sep 2019 11:58:07 +0200 - rev 496952
Push 114147 by ccoroiu@mozilla.com at Thu, 10 Oct 2019 09:56:56 +0000
Bug 1587368 - servo: Uncomment more stuff related to box construction. r=emilio
59f0469f5a486ddea7543100b3f335706b072955: Bug 1513325 - Remove textbox binding. r=emilio,dao
Tim Nguyen <ntim.bugs@gmail.com> - Wed, 09 Oct 2019 09:27:28 +0000 - rev 496931
Push 114147 by ccoroiu@mozilla.com at Thu, 10 Oct 2019 09:56:56 +0000
Bug 1513325 - Remove textbox binding. r=emilio,dao Differential Revision: https://phabricator.services.mozilla.com/D38955