searching for reviewer(ehsan)
776f4bc4d6113d1b6e301761f3c77fe33fb8df25: Bug 1596238, Make NodeIterator less AddRef/Release heavy by trying to avoid use of strong pointer when the node is skipped because of whatToShow, r=Ehsan
Olli Pettay <Olli.Pettay@helsinki.fi> - Thu, 14 Nov 2019 17:29:27 +0000 - rev 502009
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1596238, Make NodeIterator less AddRef/Release heavy by trying to avoid use of strong pointer when the node is skipped because of whatToShow, r=Ehsan TreeWalker could use some similar changes, but that is a different bug. TreeWalker does use TestNode method too, which is why the new argument is optional. A new bug will be filed for TreeWalker. Differential Revision: https://phabricator.services.mozilla.com/D53016
78ff9f5d93b7cf17c312cb3bba6aa83992142f40: Bug 1593644 - Also enable permissions.desktop-notification.postPrompt.enabled. r=Ehsan
Johann Hofmann <jhofmann@mozilla.com> - Wed, 06 Nov 2019 17:20:46 +0000 - rev 501467
Push 114170 by malexandru@mozilla.com at Tue, 12 Nov 2019 21:58:32 +0000
Bug 1593644 - Also enable permissions.desktop-notification.postPrompt.enabled. r=Ehsan This is being enabled alongside dom.webnotifications.requireuserinteraction to ensure a good user experience when automatically denying notification prompts. Depends on D51595 Differential Revision: https://phabricator.services.mozilla.com/D51597
cd21f493559b0dca5e1ac73f47ab5414162cc9f9: Bug 1593644 - Enable dom.webnotifications.requireuserinteraction on Release. r=Ehsan
Johann Hofmann <jhofmann@mozilla.com> - Wed, 06 Nov 2019 17:20:14 +0000 - rev 501466
Push 114170 by malexandru@mozilla.com at Tue, 12 Nov 2019 21:58:32 +0000
Bug 1593644 - Enable dom.webnotifications.requireuserinteraction on Release. r=Ehsan Differential Revision: https://phabricator.services.mozilla.com/D51595
6cc550e9edcde95eaba889aa340da4f9781dfb09: Bug 1588745 - part 7: Remove `AutoScriptBlocker` from `TextControlState::SetValue()` r=Ehsan
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 01 Nov 2019 21:10:17 +0000 - rev 500303
Push 114164 by aiakab@mozilla.com at Tue, 05 Nov 2019 10:06:15 +0000
Bug 1588745 - part 7: Remove `AutoScriptBlocker` from `TextControlState::SetValue()` r=Ehsan For allowing `TextEditor` to dispatch DOM events synchronously, we should remove `AutoScriptBlocker` in `TextControlState::SetValue()` right now. According to the comment around the `AutoScriptBlocker`, `PrepareEditor()` may be called while setting value. Therefore, this patch makes `AutoTextControlHandlingState` call it if `PrepareEditor()` is called while handling `SetValue()` and when the top most `SetValue()` ends its job. Depends on D51396 Differential Revision: https://phabricator.services.mozilla.com/D51397
7608c252368ea6389d33d820fc2fbb9207dd2130: Bug 1588745 - part 6: Post processing of setting value with TextEditor should be done before dispatching "input" event r=Ehsan
Masayuki Nakano <masayuki@d-toybox.com> - Sun, 03 Nov 2019 02:50:00 +0000 - rev 500302
Push 114164 by aiakab@mozilla.com at Tue, 05 Nov 2019 10:06:15 +0000
Bug 1588745 - part 6: Post processing of setting value with TextEditor should be done before dispatching "input" event r=Ehsan Currently, "input" event is fired when the `AutoScriptBlocker` in `SetValue()` is deleted. So, for keeping same behavior, the post processing after calling `TextEditor` methods should be done before editor dispatches "input" event. Fortunately, `TextInputListener::OnEditActionHandled()` is a good chance to do that. Therefore, this patch makes it notify `TextControlState` and `AutoTextControlHandlingState`. Note that ideally, each method of `TextEditor` should return `NS_ERROR_OUT_OF_MEMORY` coming from `AutoTextControlHandlingState::OnEditActionHandled()`. However, it requires a lot of changes in editor classes, and the case is really rare since editor does not use fallible allocation. Therefore, it must be okay to crash in editor if `OnEditActionHandled()` returns `NS_ERROR_OUT_OF_MEMORY`. Depends on D51395 Differential Revision: https://phabricator.services.mozilla.com/D51396
7754b00fcfc82f9c98eafd780b90de4b4fc7cc1c: Bug 1588745 - part 5: Split `TextControlState::SetValue()` r=Ehsan
Masayuki Nakano <masayuki@d-toybox.com> - Sat, 02 Nov 2019 23:23:54 +0000 - rev 500301
Push 114164 by aiakab@mozilla.com at Tue, 05 Nov 2019 10:06:15 +0000
Bug 1588745 - part 5: Split `TextControlState::SetValue()` r=Ehsan `TextControlState::SetValue()` does 4 things. 1. Committing composition if there is and if possible. 2. Setting value with `TextEditor` if text editor and frame are available. 3. Setting value without `TextEditor` otherwise. 4. Notifying value changed. We can split #2 and #3 from it now because `AutoTextControlHandlingState` manages nested actions. Therefore, this patch creates `SetValueWithTextEditor()` and `SetValueWithoutTextEditor()` which take `AutoTextControlHandlingState`. Depends on D51394 Differential Revision: https://phabricator.services.mozilla.com/D51395
041047456efaad17ede7547324c20c579b96bbd6: Bug 1588745 - part 4: Make `TextControlState` reuse its instance by itself r=Ehsan
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 01 Nov 2019 20:51:48 +0000 - rev 500300
Push 114164 by aiakab@mozilla.com at Tue, 05 Nov 2019 10:06:15 +0000
Bug 1588745 - part 4: Make `TextControlState` reuse its instance by itself r=Ehsan Currently, only `HTMLInputElement` reuses `TextControlState` instance since `HTMLTextAreaElement` had the instance as a member rather than allocate it. Now, all instances are allocated in the heap independently for guaranteeing their lifetime. So, the reuse mechanism should be managed by `TextControlState` itself. Depends on D51393 Differential Revision: https://phabricator.services.mozilla.com/D51394
5915226eefd509a7916d5534eef0e2942d14596e: Bug 1588745 - part 3: Make `TextControlState` not deleted actually while it handles something r=Ehsan
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 01 Nov 2019 20:49:12 +0000 - rev 500299
Push 114164 by aiakab@mozilla.com at Tue, 05 Nov 2019 10:06:15 +0000
Bug 1588745 - part 3: Make `TextControlState` not deleted actually while it handles something r=Ehsan Currently, nobody guarantees that `TextControlState` won't be deleted while it handles something with `MOZ_CAN_RUN_SCRIPT` methods. This patch hides its destructor (and constructor) for making only `TextControlState` itself can delete its instances. Then, if instance owner wants to delete it while handling action(s), the oldest `AutoHandlingState` will delete the `TextControlState`. Depends on D51392 Differential Revision: https://phabricator.services.mozilla.com/D51393
191c2592d268a7bd4e510d02d71b87e3764800ea: Bug 1588745 - part 2: Move some `TextControlState` members to stack only class r=Ehsan
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 01 Nov 2019 20:47:35 +0000 - rev 500298
Push 114164 by aiakab@mozilla.com at Tue, 05 Nov 2019 10:06:15 +0000
Bug 1588745 - part 2: Move some `TextControlState` members to stack only class r=Ehsan Some members of `TextControlState` are initialized and restored in same block scopes. Therefore, with creating new stack only class and storing latest one with a new member variable, we can store all of them in the stack. Depends on D51391 Differential Revision: https://phabricator.services.mozilla.com/D51392
88c5fa54553b1c8d4b1cdd919821b0ee8ea582b7: Bug 1588745 - part 1: Rename `nsTextEditorState` to `mozilla::TextControlState` r=Ehsan
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 01 Nov 2019 20:43:11 +0000 - rev 500297
Push 114164 by aiakab@mozilla.com at Tue, 05 Nov 2019 10:06:15 +0000
Bug 1588745 - part 1: Rename `nsTextEditorState` to `mozilla::TextControlState` r=Ehsan It should be in `mozilla` namespace and it manages not only `TextEditor`, manages selection, selection controller and callback from editor. so that I think it stores state of "text control widget". Therefore, I name it to `TextControlState`. And cleaning up the cpp file. Differential Revision: https://phabricator.services.mozilla.com/D51391
d3d3f36ec041a16ad1037362edbaae5213dd5f37: Bug 1593424 - Check content blocking log entry count in browser_socialtracking.js test. r=Ehsan
Nihanth Subramanya <nhnt11@gmail.com> - Sat, 02 Nov 2019 20:40:53 +0000 - rev 500282
Push 114164 by aiakab@mozilla.com at Tue, 05 Nov 2019 10:06:15 +0000
Bug 1593424 - Check content blocking log entry count in browser_socialtracking.js test. r=Ehsan Differential Revision: https://phabricator.services.mozilla.com/D51497
d0f91ad7450c157ed94c5fd70b51f80d8ad3303b: Bug 1584479 - Part 2: Update socialtracking test. r=Ehsan
Nihanth Subramanya <nhnt11@gmail.com> - Sat, 02 Nov 2019 09:53:51 +0000 - rev 500263
Push 114164 by aiakab@mozilla.com at Tue, 05 Nov 2019 10:06:15 +0000
Bug 1584479 - Part 2: Update socialtracking test. r=Ehsan Differential Revision: https://phabricator.services.mozilla.com/D51444
3ff3e93332d0ead5eb222f7f64b890fbc936edc6: Bug 1584479 - Part 1: Add flag for blocked social cookies in the content blocking log. r=Ehsan,droeh
Nihanth Subramanya <nhnt11@gmail.com> - Fri, 01 Nov 2019 23:24:25 +0000 - rev 500262
Push 114164 by aiakab@mozilla.com at Tue, 05 Nov 2019 10:06:15 +0000
Bug 1584479 - Part 1: Add flag for blocked social cookies in the content blocking log. r=Ehsan,droeh Differential Revision: https://phabricator.services.mozilla.com/D47427
0edb227865459d4fb59da0771dad10130e4d7b64: Bug 1584479 - Part 2: Update socialtracking test. r=Ehsan
Nihanth Subramanya <nhnt11@gmail.com> - Fri, 01 Nov 2019 22:02:12 +0000 - rev 500233
Push 114164 by aiakab@mozilla.com at Tue, 05 Nov 2019 10:06:15 +0000
Bug 1584479 - Part 2: Update socialtracking test. r=Ehsan Differential Revision: https://phabricator.services.mozilla.com/D51444
7e03b392edb3bf50a9a4dc1ff08bda0a4e5bdd04: Bug 1584479 - Part 1: Add flag for blocked social cookies in the content blocking log. r=Ehsan,droeh
Nihanth Subramanya <nhnt11@gmail.com> - Fri, 01 Nov 2019 21:02:09 +0000 - rev 500232
Push 114164 by aiakab@mozilla.com at Tue, 05 Nov 2019 10:06:15 +0000
Bug 1584479 - Part 1: Add flag for blocked social cookies in the content blocking log. r=Ehsan,droeh Differential Revision: https://phabricator.services.mozilla.com/D47427
6f0135a82d10e5983f99b5cbbb23130d0c9f7324: Bug 1592959 - Warn about non-user interaction Notification requests. r=Ehsan
Johann Hofmann <jhofmann@mozilla.com> - Fri, 01 Nov 2019 09:55:06 +0000 - rev 500163
Push 114164 by aiakab@mozilla.com at Tue, 05 Nov 2019 10:06:15 +0000
Bug 1592959 - Warn about non-user interaction Notification requests. r=Ehsan Differential Revision: https://phabricator.services.mozilla.com/D51260
d7c5b5d38982d0a46e24f185e0d6761b4334d805: Bug 1586189 - Fix behaviour of ThirdPartyUtil::IsThirdPartyWindow with Fission. r=ttung,Ehsan,kmag
Simon Giesecke <sgiesecke@mozilla.com> - Thu, 31 Oct 2019 08:31:39 +0000 - rev 499933
Push 114164 by aiakab@mozilla.com at Tue, 05 Nov 2019 10:06:15 +0000
Bug 1586189 - Fix behaviour of ThirdPartyUtil::IsThirdPartyWindow with Fission. r=ttung,Ehsan,kmag Differential Revision: https://phabricator.services.mozilla.com/D49157
a71343689fd39977144dc88dca6ef30bb01ef158: Bug 1592083 - Convert certList to raw array for nsITransportSecurityInfo r=keeler,Ehsan,kershaw
Sean Feng <sefeng@mozilla.com> - Tue, 29 Oct 2019 17:20:07 +0000 - rev 499689
Push 114163 by aiakab@mozilla.com at Thu, 31 Oct 2019 10:03:38 +0000
Bug 1592083 - Convert certList to raw array for nsITransportSecurityInfo r=keeler,Ehsan,kershaw This patch converts the certList attribute of nsITransportSecurityInfo from nsIX509CertList to Array<nsIx509Cert> Differential Revision: https://phabricator.services.mozilla.com/D48745
15bc385e8692899a10c4d4247af3dc472a0d8aaa: Tests for wbr element Bug 584141 r=Ehsan
Nour <nsaffour@gmail.com> - Tue, 29 Oct 2019 20:35:23 +0000 - rev 499687
Push 114163 by aiakab@mozilla.com at Thu, 31 Oct 2019 10:03:38 +0000
Tests for wbr element Bug 584141 r=Ehsan added tests for Bug 584141 selection across wbr elements Differential Revision: https://phabricator.services.mozilla.com/D49193
cfcbab38d04c23d7355c151909b868acb7cb864e: Bug 969980 - Use case folding for case-insensitive searches. r=Ehsan
Alex Henrie <alexhenrie24@gmail.com> - Tue, 29 Oct 2019 19:56:56 +0000 - rev 499678
Push 114163 by aiakab@mozilla.com at Thu, 31 Oct 2019 10:03:38 +0000
Bug 969980 - Use case folding for case-insensitive searches. r=Ehsan Differential Revision: https://phabricator.services.mozilla.com/D50940
32af5afdcfe30752a0d896e1c9aae10b3f7d3d6e: Bug 1589754 - Rename nsGlobalWindowInner::GetTopLevelPrincipal r=Ehsan
Rob Wu <rob@robwu.nl> - Thu, 24 Oct 2019 12:57:21 +0000 - rev 499395
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1589754 - Rename nsGlobalWindowInner::GetTopLevelPrincipal r=Ehsan Differential Revision: https://phabricator.services.mozilla.com/D50068
956451c71574bec00e8dbf8a0b507e9fd28711e5: Bug 1591490 - Use the NS_IS_SURROGATE_PAIR macro everywhere. r=Ehsan
Alex Henrie <alexhenrie24@gmail.com> - Sun, 27 Oct 2019 05:05:51 +0000 - rev 499376
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1591490 - Use the NS_IS_SURROGATE_PAIR macro everywhere. r=Ehsan Differential Revision: https://phabricator.services.mozilla.com/D50697
61ea36deed375342d6c19d08c635b1cbeeb74cd3: Bug 1422056 - nsPermissionManager: Disabled OA stripping for private browsing and added OA strip prefs. r=johannh,Ehsan
Paul Zuehlcke <pzuhlcke@mozilla.com> - Fri, 25 Oct 2019 10:26:45 +0000 - rev 499234
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1422056 - nsPermissionManager: Disabled OA stripping for private browsing and added OA strip prefs. r=johannh,Ehsan Differential Revision: https://phabricator.services.mozilla.com/D48664
5458333aaa269cfe6f331329f176d92d66f61906: Bug 1591087 - Add some more HTML*Element sizeof assertions, r=Ehsan
Olli Pettay <Olli.Pettay@helsinki.fi> - Thu, 24 Oct 2019 23:41:49 +0000 - rev 499203
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1591087 - Add some more HTML*Element sizeof assertions, r=Ehsan Differential Revision: https://phabricator.services.mozilla.com/D50475
ec5ffc5cb2a8b8881a7ce24111932cf08690e897: Bug 1570159 - CreatePairwiseWhitelistURI return success when it cannot get host from the top-level page. r=Ehsan
DimiDL <dlee@mozilla.com> - Fri, 25 Oct 2019 07:31:12 +0000 - rev 499201
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1570159 - CreatePairwiseWhitelistURI return success when it cannot get host from the top-level page. r=Ehsan Before this patch, when we cannot get the host name from the top-level page, for example, aboout page, UrlClassifeirCommon::CreatePairwiseWhitelistURI returns an error. After this patch, when |GetHost| fails, we returns NS_OK to just skip looking up whiltelist for this URI. Note that the lookup against blacklist tables will still be performed. Differential Revision: https://phabricator.services.mozilla.com/D49983
dd540d2cdc4d382052d87bdb78755665573acdf4: Bug 1589786 - Handle surrogate pairs in nsFind. r=Ehsan
Alex Henrie <alexhenrie24@gmail.com> - Fri, 25 Oct 2019 01:15:07 +0000 - rev 499196
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1589786 - Handle surrogate pairs in nsFind. r=Ehsan Differential Revision: https://phabricator.services.mozilla.com/D49822
0063a5b2f5b3092f9330c4cd9795e6e39f42fa15: Bug 1589786 - Handle surrogate pairs in nsFind. r=Ehsan
Alex Henrie <alexhenrie24@gmail.com> - Thu, 24 Oct 2019 13:38:32 +0000 - rev 499113
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1589786 - Handle surrogate pairs in nsFind. r=Ehsan Differential Revision: https://phabricator.services.mozilla.com/D49822
3daed546d6cfc40fccc82e34e8cafb2d5c24626a: Bug 1590417 - Remove unused HTMLMediaElement::GetTopLevelPrincipal r=Ehsan
Rob Wu <rob@robwu.nl> - Wed, 23 Oct 2019 18:13:40 +0000 - rev 499090
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1590417 - Remove unused HTMLMediaElement::GetTopLevelPrincipal r=Ehsan Differential Revision: https://phabricator.services.mozilla.com/D50069
120203cf34b01f7f4c8c104a3bbd1cad00b89ba7: Bug 1589754 - Rename nsGlobalWindowInner::GetTopLevelPrincipal r=Ehsan
Rob Wu <rob@robwu.nl> - Wed, 23 Oct 2019 18:14:44 +0000 - rev 499075
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1589754 - Rename nsGlobalWindowInner::GetTopLevelPrincipal r=Ehsan Differential Revision: https://phabricator.services.mozilla.com/D50068
d68244d4b2dc69acbd0d6f0d4620089a6ffeef8c: Bug 1584898 - Free nsPipe memory on a separate thread, r=Ehsan
Andrea Marchesini <amarchesini@mozilla.com> - Thu, 24 Oct 2019 11:08:43 +0000 - rev 499071
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1584898 - Free nsPipe memory on a separate thread, r=Ehsan Differential Revision: https://phabricator.services.mozilla.com/D50278
613ca59a8e616c68b20128ea1fbc98d02890c945: Tests for wbr element Bug 584141 r=Ehsan
Nour <nsaffour@gmail.com> - Mon, 21 Oct 2019 20:04:44 +0000 - rev 498419
Push 114158 by ncsoregi@mozilla.com at Tue, 22 Oct 2019 09:53:30 +0000
Tests for wbr element Bug 584141 r=Ehsan added tests for Bug 584141 selection across wbr elements Differential Revision: https://phabricator.services.mozilla.com/D49193
11e5baee978e8f98fa3795e430dd60c7600c9e8c: Bug 1580315 - Convert certList to raw array for nsITransportSecurityInfo r=keeler,Ehsan,kershaw
Sean Feng <sefeng@mozilla.com> - Mon, 21 Oct 2019 19:49:01 +0000 - rev 498417
Push 114158 by ncsoregi@mozilla.com at Tue, 22 Oct 2019 09:53:30 +0000
Bug 1580315 - Convert certList to raw array for nsITransportSecurityInfo r=keeler,Ehsan,kershaw This patch converts the certList attribute of nsITransportSecurityInfo from nsIX509CertList to Array<nsIx509Cert> Differential Revision: https://phabricator.services.mozilla.com/D48745
e50facddb3c9758fd9effdccea0d80bd8ce1d264: Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan
Sylvestre Ledru <sledru@mozilla.com> - Mon, 21 Oct 2019 14:13:44 +0000 - rev 498367
Push 114157 by nbeleuzu@mozilla.com at Mon, 21 Oct 2019 22:00:13 +0000
Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan Please note that it is the first reformat with clang-format 9 I only saw a fix in the .mm file # ignore-this-changeset Differential Revision: https://phabricator.services.mozilla.com/D49056
5f75bd13473c4f547a56fbe85d30a4d7a0aa8235: Bug 1588899 - P2. Make HTTP classification flags available to DocumentChannelChild, since we use them to determine which content blocking events to fire. r=baku,Ehsan
Jean-Yves Avenard <jyavenard@mozilla.com> - Sat, 19 Oct 2019 07:04:15 +0000 - rev 498281
Push 114157 by nbeleuzu@mozilla.com at Mon, 21 Oct 2019 22:00:13 +0000
Bug 1588899 - P2. Make HTTP classification flags available to DocumentChannelChild, since we use them to determine which content blocking events to fire. r=baku,Ehsan Differential Revision: https://phabricator.services.mozilla.com/D49335
f2df73fda46859150605f33bcdaeb49ab7037720: Bug 1588899 - P1. Move classification flags related method to nsIClassifiedChannel. r=Ehsan,baku
Jean-Yves Avenard <jyavenard@mozilla.com> - Sat, 19 Oct 2019 04:30:24 +0000 - rev 498280
Push 114157 by nbeleuzu@mozilla.com at Mon, 21 Oct 2019 22:00:13 +0000
Bug 1588899 - P1. Move classification flags related method to nsIClassifiedChannel. r=Ehsan,baku This is where it should have been in the first place. Those attributes belong there. Differential Revision: https://phabricator.services.mozilla.com/D49577
ab0ed4869416de1b5bc777d97949351c48b61913: Tests for wbr element Bug 584141 r=Ehsan
Nour <nsaffour@gmail.com> - Fri, 18 Oct 2019 17:12:28 +0000 - rev 498237
Push 114157 by nbeleuzu@mozilla.com at Mon, 21 Oct 2019 22:00:13 +0000
Tests for wbr element Bug 584141 r=Ehsan added tests for Bug 584141 selection across wbr elements Differential Revision: https://phabricator.services.mozilla.com/D49193
80ffb5ef8efb71442034e56a093a4367ac06cdf6: Bug 584141 Added WBR frame class implementing nsFrame and overriding thepeekOffset* methods. r=dbaron,Ehsan
Nour <nsaffour@gmail.com> - Mon, 14 Oct 2019 19:35:23 +0000 - rev 498236
Push 114157 by nbeleuzu@mozilla.com at Mon, 21 Oct 2019 22:00:13 +0000
Bug 584141 Added WBR frame class implementing nsFrame and overriding thepeekOffset* methods. r=dbaron,Ehsan The wbr element represents a line break opportunity. Before the change double clicking on a text that contains a wbr element did not select the whole sentence. After the change, the presence of a wbr element in the selection does not affect the selection functionality. Differential Revision: https://phabricator.services.mozilla.com/D47558
4b1c5a268d2e5bcc6bc981ce4c20c32fe8c5e17b: Bug 1587905 - Remove useless variable 'typeTest' declaration & assignation r=Ehsan
Sylvestre Ledru <sledru@mozilla.com> - Thu, 10 Oct 2019 22:48:49 +0000 - rev 497245
Push 114148 by shindli@mozilla.com at Mon, 14 Oct 2019 10:49:50 +0000
Bug 1587905 - Remove useless variable 'typeTest' declaration & assignation r=Ehsan Differential Revision: https://phabricator.services.mozilla.com/D48887
e547233969e4527a3e9b49d250f11af75c582383: Bug 1584690 - append nonexistent hash to `ContentBlockingLog`; r=Ehsan
Liang-Heng Chen <xeonchen@gmail.com> - Fri, 04 Oct 2019 22:23:20 +0000 - rev 496714
Push 114146 by dmajor@mozilla.com at Wed, 09 Oct 2019 17:52:49 +0000
Bug 1584690 - append nonexistent hash to `ContentBlockingLog`; r=Ehsan Differential Revision: https://phabricator.services.mozilla.com/D47746
8de293399b5af8933eefeb4deea308c9f4707622: Bug 1586871 - Ensure we have optional data before derefing in BrowserParent r=Ehsan
Barret Rennie <barret@brennie.ca> - Mon, 07 Oct 2019 20:51:02 +0000 - rev 496656
Push 114145 by apavel@mozilla.com at Tue, 08 Oct 2019 11:00:56 +0000
Bug 1586871 - Ensure we have optional data before derefing in BrowserParent r=Ehsan Previously we assumed that we could trust the `OnLocationChange`, `OnStateChange`, and `OnSecurityChange` IPC messages from the BrowserChild to BrowserParent to always contain their optional data if the message was top-level. However, if a content process becomes compromised, this could be used to DOS the parent process by maliciously sending these messages to the parent process with invalid data. Now we explicitly check that the data is valid before derefing. Differential Revision: https://phabricator.services.mozilla.com/D48423
2c0229c483d89a8073d426f13cc03ab9e59e23a7: Bug 1578304 - Correctly set content title from onLocationChange event r=Ehsan
Barret Rennie <barret@brennie.ca> - Mon, 07 Oct 2019 19:13:23 +0000 - rev 496640
Push 114145 by apavel@mozilla.com at Tue, 08 Oct 2019 11:00:56 +0000
Bug 1578304 - Correctly set content title from onLocationChange event r=Ehsan Differential Revision: https://phabricator.services.mozilla.com/D48413
7214f827b7fb017fd9ee1a81b9e54f2d97e5f8c1: Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan
Sylvestre Ledru <sledru@mozilla.com> - Sun, 06 Oct 2019 18:29:55 +0000 - rev 496451
Push 114143 by rgurzau@mozilla.com at Mon, 07 Oct 2019 09:35:08 +0000
Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan # ignore-this-changeset Differential Revision: https://phabricator.services.mozilla.com/D47737
a219d05a2791832d81fc18d28d5aa5063ddcea59: Bug 1554805 - Never set firstPartyDomain on origin attributes for moz-extension. r=rpl,Ehsan,tjr
Johann Hofmann <jhofmann@mozilla.com> - Sun, 06 Oct 2019 15:43:39 +0000 - rev 496446
Push 114143 by rgurzau@mozilla.com at Mon, 07 Oct 2019 09:35:08 +0000
Bug 1554805 - Never set firstPartyDomain on origin attributes for moz-extension. r=rpl,Ehsan,tjr Differential Revision: https://phabricator.services.mozilla.com/D47425
1d05fb3ba169a38a7b58354e1a8114f8778f69dc: Bug 1585443 - Remove IsCanonicalizedIP assertion. r=Ehsan
dimi <dlee@mozilla.com> - Fri, 04 Oct 2019 23:26:11 +0000 - rev 496434
Push 114143 by rgurzau@mozilla.com at Mon, 07 Oct 2019 09:35:08 +0000
Bug 1585443 - Remove IsCanonicalizedIP assertion. r=Ehsan Top-level URL and third-party URL can be an IP address, remove IsCanonicalizedIP assertion and do not fragment a domain when the domain is an IP address Differential Revision: https://phabricator.services.mozilla.com/D47916
843690981959e08dc2587d29e14148773a34a312: Bug 1580416 - P2. Add a testcase to test a match can be found when whitelisted URI is eTLD. r=Ehsan
dimi <dlee@mozilla.com> - Fri, 27 Sep 2019 08:50:44 +0000 - rev 495602
Push 114140 by dvarga@mozilla.com at Wed, 02 Oct 2019 18:04:51 +0000
Bug 1580416 - P2. Add a testcase to test a match can be found when whitelisted URI is eTLD. r=Ehsan Differential Revision: https://phabricator.services.mozilla.com/D47213
a1237d4bad3deefcd6e7d9a27422403da1477e31: Bug 1580416 - P1. Use a different fragment method when the URI is a pairwiseWhitelistedURI. r=Ehsan
DimiL <dlee@mozilla.com> - Fri, 27 Sep 2019 13:22:18 +0000 - rev 495601
Push 114140 by dvarga@mozilla.com at Wed, 02 Oct 2019 18:04:51 +0000
Bug 1580416 - P1. Use a different fragment method when the URI is a pairwiseWhitelistedURI. r=Ehsan This patch does the following to support matching a whitelisted URI when its domain is eTLD+1: 1. add an URIType to indicate whether a URI is generated by UrlClassifierCommoon::CreatePairwiseWhiteListURI(), which crafts a whitelist URL like "toplevel.page/?resource=third.party.domain" 2. call LookupCache::GetLookupWhitelistFragments() if URIType is nsIUrlClassifierFeature::pairwiseWhitelistedURI before initiating a lookup. 3. implement LookupCache::GetLookupWhitelistFragments() which creates an additional fragment by removing the leading component of third.party.domain Differential Revision: https://phabricator.services.mozilla.com/D47212
c0fb66a739a3ea04ecb0b0e68a7953c6f5f5aa9d: Bug 1579835, part 3 - Fix ChromeUtils::RequestProcInfo() with Fission. r=Ehsan
Andrew McCreight <continuation@gmail.com> - Wed, 25 Sep 2019 22:40:44 +0000 - rev 495413
Push 114134 by ccoroiu@mozilla.com at Mon, 30 Sep 2019 09:57:15 +0000
Bug 1579835, part 3 - Fix ChromeUtils::RequestProcInfo() with Fission. r=Ehsan Differential Revision: https://phabricator.services.mozilla.com/D45376
feba8126032f55aaee9accdfa97eb269e363818e: Bug 1402957 - Removed URI based nsIPermissionManager methods. r=johannh,Ehsan
Paul Zuehlcke <pzuhlcke@mozilla.com> - Fri, 27 Sep 2019 14:55:53 +0000 - rev 495380
Push 114134 by ccoroiu@mozilla.com at Mon, 30 Sep 2019 09:57:15 +0000
Bug 1402957 - Removed URI based nsIPermissionManager methods. r=johannh,Ehsan Differential Revision: https://phabricator.services.mozilla.com/D47254
dd0a4d7624da68fd7d4cb138626c12774b6536ca: Bug 1579591, clear pending timeouts in BrowserUsageTelemetry.jsm to avoid leaks during testing, r=Ehsan
Olli Pettay <Olli.Pettay@helsinki.fi> - Thu, 26 Sep 2019 13:37:15 +0000 - rev 495197
Push 114133 by shindli@mozilla.com at Thu, 26 Sep 2019 21:40:49 +0000
Bug 1579591, clear pending timeouts in BrowserUsageTelemetry.jsm to avoid leaks during testing, r=Ehsan Differential Revision: https://phabricator.services.mozilla.com/D47250
89c94db8a4bebe3560b030d48d7608c875174ee1: Bug 1564248 - Re-add contentblocking.exceptions and extend the measurement to 75. r=Ehsan
Johann Hofmann <jhofmann@mozilla.com> - Thu, 26 Sep 2019 08:09:17 +0000 - rev 495134
Push 114133 by shindli@mozilla.com at Thu, 26 Sep 2019 21:40:49 +0000
Bug 1564248 - Re-add contentblocking.exceptions and extend the measurement to 75. r=Ehsan Differential Revision: https://phabricator.services.mozilla.com/D47073