searching for reviewer(dholbert)
18126d4319d709898392059b4d6625f7e2a8ef1f: Bug 1549620 - [css-grid] Take box-sizing:border-box into account when calculating the input sizes for repeat(auto-fill/fit) track count. r=dholbert
Mats Palmgren <mats@mozilla.com> - Sat, 14 Sep 2019 00:17:16 +0000 - rev 493244
Push 114084 by btara@mozilla.com at Sat, 14 Sep 2019 21:30:15 +0000
Bug 1549620 - [css-grid] Take box-sizing:border-box into account when calculating the input sizes for repeat(auto-fill/fit) track count. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D45708
20d20876ee64770dc3aa7a2d6b7959cfa0d25959: Bug 1540203 - Tweak scroll anchor selection to allow to select everything but inline-fragmentable, non-text boxes. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 13 Sep 2019 22:26:48 +0000 - rev 493236
Push 114084 by btara@mozilla.com at Sat, 14 Sep 2019 21:30:15 +0000
Bug 1540203 - Tweak scroll anchor selection to allow to select everything but inline-fragmentable, non-text boxes. r=dholbert Per the discussion in https://github.com/w3c/csswg-drafts/issues/4247. Differential Revision: https://phabricator.services.mozilla.com/D44647
4fe410147ca0dfd93c3335ac8ee39c0496b3d27c: Bug 1579671 - Remove assertion that fails for subgrid. r=dholbert
Mats Palmgren <mats@mozilla.com> - Fri, 13 Sep 2019 02:47:43 +0000 - rev 493024
Push 114081 by btara@mozilla.com at Fri, 13 Sep 2019 15:49:27 +0000
Bug 1579671 - Remove assertion that fails for subgrid. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D45235
f3fff7c1f2ba76b11c1a4edee5046cc51d7d76bc: Bug 1488828: For collapsed select controls in the content process, set the number of rows to the maximum instead of 1. r=dholbert
James Teh <jteh@mozilla.com> - Fri, 13 Sep 2019 03:59:51 +0000 - rev 492982
Push 114081 by btara@mozilla.com at Fri, 13 Sep 2019 15:49:27 +0000
Bug 1488828: For collapsed select controls in the content process, set the number of rows to the maximum instead of 1. r=dholbert The number of rows for the select dropdown can't be calculated in the content process because the dropdown has to be rendered in the parent process. Therefore, we previously set the number of rows to 1 in this case. That meant that the page up and page down keys only moved one item at a time for a collapsed select control, making them effectively useless. Instead, set the number of rows to the maximum in this case. Differential Revision: https://phabricator.services.mozilla.com/D45154
0579d0d5f0c09ec2e9f8b12742114d92ee2217da: Bug 1562057 - Make empty <select> elements the same size as size-contained ones. r=dholbert
Florian Rivoal <moz@florian.rivoal.net> - Wed, 11 Sep 2019 20:37:55 +0000 - rev 492727
Push 114071 by ncsoregi@mozilla.com at Thu, 12 Sep 2019 06:16:52 +0000
Bug 1562057 - Make empty <select> elements the same size as size-contained ones. r=dholbert Per the css-contain specification, size contained element must be sized as if they were empty. The code added to handle size containment shortciruits the (inline) size calculations, and returns 0. However, an empty <select> element is rendered as if it contained a &nbsp; and some padding gets added to it by the UA stylesheet (forms.css). This causes reftest that check that size-contained <select> elements and empty ones look the same. This commit fixes this by also shortcircuiting the (inline) size calculations and returning 0 for empty <select> elements. Replacing the &nbsp; by a zero width space would not have been enough, since padding would still be added. It would have been possible to add it in the inline size calculations of size-contained <select> elements as well, but this padding serves not purpose when the element is empty, so removing it from there has no downside, and shortcircuitig both cases is simpler (and marginally faster) than adding the padding in both cases. Differential Revision: https://phabricator.services.mozilla.com/D45144
9ef1dd77e6b24a408aaac059537ffcf6fa268450: Bug 1561546 - Update theme when nsXPLookAndFeel prefs change. r=dholbert,jmathies
Adam Gashlin <agashlin@mozilla.com> - Wed, 11 Sep 2019 18:35:44 +0000 - rev 492716
Push 114071 by ncsoregi@mozilla.com at Thu, 12 Sep 2019 06:16:52 +0000
Bug 1561546 - Update theme when nsXPLookAndFeel prefs change. r=dholbert,jmathies Also causes removing a pref to take effect immediately, and prevents losing all color pref overrides when the theme changes. Differential Revision: https://phabricator.services.mozilla.com/D44416
43ce5f2968ea046eeea78089e4f80efc09c8fb8a: Bug 1574222 - Serialize getComputedStyle on text-decoration properly. r=emilio,dholbert
Boris Chiou <boris.chiou@gmail.com> - Tue, 10 Sep 2019 21:52:26 +0000 - rev 492585
Push 114068 by aiakab@mozilla.com at Wed, 11 Sep 2019 09:57:04 +0000
Bug 1574222 - Serialize getComputedStyle on text-decoration properly. r=emilio,dholbert The wpt will be updated in https://github.com/web-platform-tests/wpt/pull/18866. Besides, there are some other test cases use text-decoration, so we have to update them as well. The rule is: if the test case is not related to old `text-decoration` longhand, we use `text-decoration-line` instead. If the test case is for testing the change of `text-decoration` from longhand to shorthand, we should use the correct serialization. Differential Revision: https://phabricator.services.mozilla.com/D44909
f02aa8a0f9e6da1b28b3732600c4de2693c674fe: Bug 1248227 - Add crashtest. r=dholbert
Mats Palmgren <mats@mozilla.com> - Tue, 10 Sep 2019 03:36:29 +0000 - rev 492429
Push 114056 by malexandru@mozilla.com at Tue, 10 Sep 2019 10:03:56 +0000
Bug 1248227 - Add crashtest. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D45278
d8c98c89a57d169e321c55d55730132bcc178301: Bug 1579624 - Turn on "layout.css.line-height.normal-as-resolved-value.enabled" in all channels. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 08 Sep 2019 06:56:12 +0000 - rev 492151
Push 114044 by csabou@mozilla.com at Sun, 08 Sep 2019 21:45:35 +0000
Bug 1579624 - Turn on "layout.css.line-height.normal-as-resolved-value.enabled" in all channels. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D45129
bb59a0c3716298bd4645885b530d501809715541: Bug 1308587 Part 2 - Remove -moz prefix for all multi-column properties in testing and css files. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Thu, 05 Sep 2019 21:37:32 +0000 - rev 491931
Push 114036 by nerli@mozilla.com at Fri, 06 Sep 2019 09:46:47 +0000
Bug 1308587 Part 2 - Remove -moz prefix for all multi-column properties in testing and css files. r=dholbert This patch is generated by the following script: ``` function remove_column_prefix() { echo "Renaming $1 to $2" find .\ -type f\ ! -path "./obj*"\ ! -path "./.git"\ ! -path "./.hg"\ \( -name "*.html" -or\ -name "*.xhtml" -or\ -name "*.xht" -or\ -name "*.xul" -or\ -name "*.xml" -or\ -name "*.css" \)\ -exec sed -i -e "s/$1/$2/g" "{}" \; } remove_column_prefix "-moz-columns" "columns" remove_column_prefix "-moz-column-width" "column-width" remove_column_prefix "-moz-column-count" "column-count" remove_column_prefix "-moz-column-fill" "column-fill" remove_column_prefix "-moz-column-gap" "column-gap" remove_column_prefix "-moz-column-rule" "column-rule" remove_column_prefix "-moz-column-rule-width" "column-rule-width" remove_column_prefix "-moz-column-rule-color" "column-rule-color" remove_column_prefix "-moz-column-rule-style" "column-rule-style" ``` Note: after running the above script, I reverted one minor change to the file multicol-nested-column-rule-001.xht in the theoretically read-only directory layout/reftests/w3c-css/received/css-multicol/. Differential Revision: https://phabricator.services.mozilla.com/D44870
a31610c04020a76fdce6f31835788229ea2c30c1: Bug 1308587 Part 1 - Manually remove "-moz" prefixed multi-column properties in some tests. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Thu, 05 Sep 2019 21:32:05 +0000 - rev 491930
Push 114036 by nerli@mozilla.com at Fri, 06 Sep 2019 09:46:47 +0000
Bug 1308587 Part 1 - Manually remove "-moz" prefixed multi-column properties in some tests. r=dholbert In the next part, the patch generated by a script removes "-moz" prefix to all multi-column properties. However, some of the tests already have standard multi-column properties specified. To avoid duplicating CSS multi-column rules in these files (after applying the next part), I manually remove the prefixed rules beforehand as many as possible. Differential Revision: https://phabricator.services.mozilla.com/D44869
e99be10fe186f9a92d445874f08e371fdcd572fe: Bug 1573711 - Account for baseline offset (potential effect of vertical-align property) when computing skip-ink intercepts. r=dholbert
Jonathan Kew <jkew@mozilla.com> - Sat, 31 Aug 2019 04:32:55 +0000 - rev 491135
Push 114017 by dluca@mozilla.com at Mon, 02 Sep 2019 21:47:39 +0000
Bug 1573711 - Account for baseline offset (potential effect of vertical-align property) when computing skip-ink intercepts. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D44297
4b798ea49b3a88f6b01148a66f9b9987b6fad40a: Bug 1576933 - Update test expectations given the failure rate. r=dholbert
Cosmin Sabou <csabou@mozilla.com> - Fri, 30 Aug 2019 02:12:02 +0000 - rev 490765
Push 114002 by shindli@mozilla.com at Fri, 30 Aug 2019 09:43:28 +0000
Bug 1576933 - Update test expectations given the failure rate. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D44087
e0253dcb76b1cc3fa4e89658ef0f772996dde5cb: Bug 1577364 - Remove the NS_TABLE_CELL_HAS_PCT_OVER_BSIZE frame bit since it's not used. r=dholbert
Mats Palmgren <mats@mozilla.com> - Thu, 29 Aug 2019 21:22:25 +0000 - rev 490756
Push 114002 by shindli@mozilla.com at Fri, 30 Aug 2019 09:43:28 +0000
Bug 1577364 - Remove the NS_TABLE_CELL_HAS_PCT_OVER_BSIZE frame bit since it's not used. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D43864
003d1c976fc63ae7866e29faa7ea54676a61ebcd: Bug 1547533 - Update test expectations because of recent failures. r=dholbert
Cosmin Sabou <csabou@mozilla.com> - Thu, 29 Aug 2019 22:17:12 +0000 - rev 490743
Push 114001 by csabou@mozilla.com at Fri, 30 Aug 2019 04:44:11 +0000
Bug 1547533 - Update test expectations because of recent failures. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D44062
e7511b57c48e74f369ab71162adc6699a2f9ee99: Bug 1576355 - Don't try to optimize position style changes for rel.pos. grid items. r=dholbert
Mats Palmgren <mats@mozilla.com> - Mon, 26 Aug 2019 20:00:35 +0000 - rev 490097
Push 113979 by csabou@mozilla.com at Tue, 27 Aug 2019 09:55:53 +0000
Bug 1576355 - Don't try to optimize position style changes for rel.pos. grid items. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D43387
4db791aec1af4bfc925e098247b72632f4b6e767: Bug 1576356 - Use an AutoTArray to collect intercepts, to avoid heap allocation except in extreme cases. r=dholbert
Jonathan Kew <jkew@mozilla.com> - Mon, 26 Aug 2019 18:14:16 +0000 - rev 489913
Push 113976 by malexandru@mozilla.com at Mon, 26 Aug 2019 23:07:04 +0000
Bug 1576356 - Use an AutoTArray to collect intercepts, to avoid heap allocation except in extreme cases. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D43331
cdcb21809ab62d6dcdfdd63f4371ac2b26d60d63: Bug 1561450 - Suppress scroll anchoring adjustments from scroll event listeners. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 23 Aug 2019 22:29:49 +0000 - rev 489760
Push 113964 by dluca@mozilla.com at Sat, 24 Aug 2019 21:59:36 +0000
Bug 1561450 - Suppress scroll anchoring adjustments from scroll event listeners. r=dholbert See https://github.com/w3c/csswg-drafts/issues/4239 This fixes what is in my opinion one of the biggest issues of scroll anchoring as specified / currently implemented. It's trivial to flush layout on a scroll handler and create scroll adjustments, which in turn would trigger other scroll events to be fired. This situation, which is what has happened in most of the scroll anchoring regressions I've fixed, at best gets pages to get stuck in an infinite CPU loop. At worst, it causes scrolling to be unusable because the page keeps reacting to scroll events. An alternative, slightly more elegant but not clear to me if 100% implementable approach would be bug 1529702. This should enormously reduce the need for scroll anchoring suppression triggers[1], I'd think, which in turn would allow me to investigate removing some of that complexity. https://drafts.csswg.org/css-scroll-anchoring/#suppression-triggers The setup to set / unset the boolean is a bit awkward but I couldn't come up with anything better. Differential Revision: https://phabricator.services.mozilla.com/D43233
d029cad70073d1a8018aa993b17d378287af7400: Bug 1571897 - Add a crashtest. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Thu, 22 Aug 2019 22:20:39 +0000 - rev 489515
Push 113949 by ncsoregi@mozilla.com at Fri, 23 Aug 2019 09:59:00 +0000
Bug 1571897 - Add a crashtest. r=dholbert According to the bug, this happens only on Android. Differential Revision: https://phabricator.services.mozilla.com/D43137
3ba2717d59ffe26de1907378f01b4c0a6e1b5968: Bug 1575315 - Add noncharacter codepoints to those for which we never attempt font fallback. r=dholbert
Jonathan Kew <jkew@mozilla.com> - Thu, 22 Aug 2019 20:59:57 +0000 - rev 489497
Push 113949 by ncsoregi@mozilla.com at Fri, 23 Aug 2019 09:59:00 +0000
Bug 1575315 - Add noncharacter codepoints to those for which we never attempt font fallback. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D42730
5b03a028f23a58feb8d549174437b473a612545c: Bug 1573249 followup, clang-format nits. r=dholbert
Jonathan Kew <jkew@mozilla.com> - Wed, 21 Aug 2019 19:37:24 +0000 - rev 489397
Push 113945 by nerli@mozilla.com at Thu, 22 Aug 2019 16:14:24 +0000
Bug 1573249 followup, clang-format nits. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D42938
b46b8640c800669c6ef4011f7f180b4a8c16d43d: Bug 1575608 - Avoid some signed -> unsigned conversions for box-ordinal-group. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 21 Aug 2019 18:35:31 +0000 - rev 489308
Push 113942 by aciure@mozilla.com at Thu, 22 Aug 2019 04:06:52 +0000
Bug 1575608 - Avoid some signed -> unsigned conversions for box-ordinal-group. r=dholbert This is consistent with the `order` property anyhow, and allows to simplify some code. Negatives are still not parsed, but rust uses a similar representation for all CSS <integer> values and so should C++. Differential Revision: https://phabricator.services.mozilla.com/D42912
81d923353e5ef3f1d577e26f14a79d22f989d2cd: Bug 1575377 - Remove BlockReflowInput::mHasUnconstrainedBSize, and update documents. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Wed, 21 Aug 2019 19:53:08 +0000 - rev 489278
Push 113942 by aciure@mozilla.com at Thu, 22 Aug 2019 04:06:52 +0000
Bug 1575377 - Remove BlockReflowInput::mHasUnconstrainedBSize, and update documents. r=dholbert The flag's original form `mUnconstrainedHeight` was added in nsBlockReflowState.h in https://github.com/mozilla/gecko-dev/commit/e580331b374a463035740a1214af8e49d0452d9b Nowadays, we often check available block-size in reflow directly in nsBlockFrame. Differential Revision: https://phabricator.services.mozilla.com/D42733
e8e037a5fb87ff0d9294a4deb47601cfea528b22: Bug 1572302 - Update the expected result for skip-ink-multiline-position. r=dholbert
Ryan VanderMeulen <ryanvm@gmail.com> - Wed, 21 Aug 2019 18:18:18 +0000 - rev 489244
Push 113942 by aciure@mozilla.com at Thu, 22 Aug 2019 04:06:52 +0000
Bug 1572302 - Update the expected result for skip-ink-multiline-position. r=dholbert Somehow, updating lz4 from version 1.9.1 to 1.9.2 makes this test reliably pass. Differential Revision: https://phabricator.services.mozilla.com/D42927
7cb671e5543fcb8ec67a6286bffadbfc1ee1eb31: Bug 1573249 - patch 3 - Add reftests for ignoring skip-ink behavior on CJK text. r=dholbert
Jonathan Kew <jkew@mozilla.com> - Wed, 21 Aug 2019 11:04:19 +0000 - rev 489233
Push 113941 by aciure@mozilla.com at Wed, 21 Aug 2019 21:59:00 +0000
Bug 1573249 - patch 3 - Add reftests for ignoring skip-ink behavior on CJK text. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D42683
d895db733402981e0074ec203b57784b229b8b82: Bug 1573249 - patch 2 - Don't apply skip-ink to runs of CJK text, because it looks bad with many fonts. r=dholbert
Jonathan Kew <jkew@mozilla.com> - Wed, 21 Aug 2019 15:07:20 +0000 - rev 489232
Push 113941 by aciure@mozilla.com at Wed, 21 Aug 2019 21:59:00 +0000
Bug 1573249 - patch 2 - Don't apply skip-ink to runs of CJK text, because it looks bad with many fonts. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D42529
ab9106acfa78902d08d8db70ba25f49fda8d00ae: Bug 1573249 - patch 1 - Clean up some management of the GlyphRun array in gfxTextRun. r=dholbert
Jonathan Kew <jkew@mozilla.com> - Wed, 21 Aug 2019 15:07:08 +0000 - rev 489231
Push 113941 by aciure@mozilla.com at Wed, 21 Aug 2019 21:59:00 +0000
Bug 1573249 - patch 1 - Clean up some management of the GlyphRun array in gfxTextRun. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D42528
bdba80dae6e2e2ae62405f8d9a723d3a2834ef9e: Bug 1573249 - patch 3 - Add reftests for ignoring skip-ink behavior on CJK text. r=dholbert
Jonathan Kew <jkew@mozilla.com> - Wed, 21 Aug 2019 09:39:02 +0000 - rev 489153
Push 113940 by dvarga@mozilla.com at Wed, 21 Aug 2019 16:57:53 +0000
Bug 1573249 - patch 3 - Add reftests for ignoring skip-ink behavior on CJK text. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D42683
21306e3f8d31af3d1957415acbe5ca1425cddb1a: Bug 1573249 - patch 2 - Don't apply skip-ink to runs of CJK text, because it looks bad with many fonts. r=dholbert
Jonathan Kew <jkew@mozilla.com> - Wed, 21 Aug 2019 09:39:02 +0000 - rev 489152
Push 113940 by dvarga@mozilla.com at Wed, 21 Aug 2019 16:57:53 +0000
Bug 1573249 - patch 2 - Don't apply skip-ink to runs of CJK text, because it looks bad with many fonts. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D42529
3576d5b9f2db1053ca2f32181ac2a30b98eaeb7d: Bug 1573249 - patch 1 - Clean up some management of the GlyphRun array in gfxTextRun. r=dholbert
Jonathan Kew <jkew@mozilla.com> - Tue, 20 Aug 2019 18:06:13 +0000 - rev 489151
Push 113940 by dvarga@mozilla.com at Wed, 21 Aug 2019 16:57:53 +0000
Bug 1573249 - patch 1 - Clean up some management of the GlyphRun array in gfxTextRun. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D42528
8ab443aeac30888c0bbc3988b4a82ecbbd806f42: Bug 1574927 - Account for the advance of (otherwise-ignored) vertical-upright glyph runs when collecting skip-ink intercepts. r=dholbert
Jonathan Kew <jkew@mozilla.com> - Mon, 19 Aug 2019 21:54:12 +0000 - rev 489037
Push 113937 by malexandru@mozilla.com at Wed, 21 Aug 2019 03:54:54 +0000
Bug 1574927 - Account for the advance of (otherwise-ignored) vertical-upright glyph runs when collecting skip-ink intercepts. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D42527
484d23bf528e24656be57a9d24c75273cdb4834f: Bug 1573922: Part 2: adding firefox specific reftests for skip-ink r=dholbert
Charlie Marlow <cmarlow@mozilla.com> - Fri, 16 Aug 2019 22:34:18 +0000 - rev 488627
Push 113914 by nbeleuzu@mozilla.com at Sat, 17 Aug 2019 21:54:15 +0000
Bug 1573922: Part 2: adding firefox specific reftests for skip-ink r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D42241
5cb4998b4586014eec3b741ac61d4d92a8cf1a77: Bug 1573922: Part 1: adding web-platform reftests for "text-decoration-skip-ink" in vertical writing-modes r=dholbert
Charlie Marlow <cmarlow@mozilla.com> - Fri, 16 Aug 2019 22:34:55 +0000 - rev 488626
Push 113914 by nbeleuzu@mozilla.com at Sat, 17 Aug 2019 21:54:15 +0000
Bug 1573922: Part 1: adding web-platform reftests for "text-decoration-skip-ink" in vertical writing-modes r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D42167
68e4d6939b344a065d8b3cf4a946c93fa4ebb15b: Bug 1574392: fix for crash caused by a zero length textblob r=dholbert
Charlie Marlow <cmarlow@mozilla.com> - Fri, 16 Aug 2019 20:57:45 +0000 - rev 488606
Push 113914 by nbeleuzu@mozilla.com at Sat, 17 Aug 2019 21:54:15 +0000
Bug 1574392: fix for crash caused by a zero length textblob r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D42347
400b06aac33e27a53b1ff0da585cd57035661d4c: Bug 1568536 - Don't propagate viewport styles from display: none or display: contents elements. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 16 Aug 2019 11:43:36 +0000 - rev 488538
Push 113913 by malexandru@mozilla.com at Fri, 16 Aug 2019 22:02:18 +0000
Bug 1568536 - Don't propagate viewport styles from display: none or display: contents elements. r=dholbert Resolution is at: * https://github.com/w3c/csswg-drafts/issues/3779#issuecomment-481762912 Tests are at https://chromium-review.googlesource.com/c/chromium/src/+/1547974, I'll make sure to wait until they're in the tree and ensure they're passing. Note that we need to ensure in the frame constructor that the document element is styled _before_ calling UpdateViewportScrollStylesOverride(). This saves duplicated work (since ResolveStyleLazily throws away the style). ResolveStyleLazily already returns out of date styles, unless the element is not styled yet, or is in a `display: none` subtree, in which case it computes and returns a new (up-to-date) style. So the switch to the FFI call only should change behavior for the display: none subtree case (since we ensure the unstyled case isn't hit by styling the document earlier). But that case is one of the cases we're interested in changing, conveniently. Depends on D40080 Differential Revision: https://phabricator.services.mozilla.com/D39204
9cd5f82e915c28e57a8c35a3fe1dd9d3a75c7f71: Bug 1554777 - Re-enable test. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 07 Aug 2019 23:14:03 +0000 - rev 488484
Push 113910 by ccoroiu@mozilla.com at Fri, 16 Aug 2019 16:28:54 +0000
Bug 1554777 - Re-enable test. r=dholbert I think they should pass after the last few patches. Differential Revision: https://phabricator.services.mozilla.com/D41007
791d6cda0dddf0478ba8a13f6cef42177261b309: Backed out changeset 4d8eb840fc2e (bug 1574101) so it can reland without unrelated reformatting changes r=dholbert CLOSED TREE
Noemi Erli <nerli@mozilla.com> - Fri, 16 Aug 2019 01:00:14 +0300 - rev 488362
Push 113906 by ncsoregi@mozilla.com at Fri, 16 Aug 2019 04:07:24 +0000
Backed out changeset 4d8eb840fc2e (bug 1574101) so it can reland without unrelated reformatting changes r=dholbert CLOSED TREE
4678b2d85df43ab5869f50df5ce616ef484ebcd6: Bug 1573974: update text-decoration-valid test case r=dholbert,emilio
Charlie Marlow <cmarlow@mozilla.com> - Thu, 15 Aug 2019 18:39:23 +0000 - rev 488324
Push 113906 by ncsoregi@mozilla.com at Fri, 16 Aug 2019 04:07:24 +0000
Bug 1573974: update text-decoration-valid test case r=dholbert,emilio This patch adds some subtests that exercise the new `text-decoration-thickness` subproperty. It also adjusts the expected serialization for some existing subtests (`currentcolor` and `solid`) which are simply setting a subproperty to its initial value, and therefore should serialize to the shorthand's own effective initial value, which is "none". Differential Revision: https://phabricator.services.mozilla.com/D42058
3e28d08b5a9e279915aae2544cd1280b6487e8bd: Bug 1573724 followup: update devtools css db to reflect that `text-underline-offset: from-font` is supported. r=dholbert
Charlie Marlow <cmarlow@mozilla.com> - Wed, 14 Aug 2019 18:22:10 +0000 - rev 488094
Push 113900 by cbrindusan@mozilla.com at Thu, 15 Aug 2019 09:53:50 +0000
Bug 1573724 followup: update devtools css db to reflect that `text-underline-offset: from-font` is supported. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D42008
46d4a0a31945df4cb4c2d6bf391ae988f0d11c0c: Bug 1573725 followup: update devtools css db to reflect that `text-decoration-thickness: from-font` is supported. r=dholbert
Charlie Marlow <cmarlow@mozilla.com> - Wed, 14 Aug 2019 18:20:40 +0000 - rev 488093
Push 113900 by cbrindusan@mozilla.com at Thu, 15 Aug 2019 09:53:50 +0000
Bug 1573725 followup: update devtools css db to reflect that `text-decoration-thickness: from-font` is supported. r=dholbert DONTBUILD because this will still fail xpcshell tests until the next commit which adds `from-font` to the other new property, `text-underline-offset`. Differential Revision: https://phabricator.services.mozilla.com/D42005
ac9ebd3dead055213bc09572a1afe54b1530d988: Bug 1572800: Part 1: Enable text-decoration-skip-ink by default on Nightly (and early-beta and earlier) r=dholbert
Charlie Marlow <cmarlow@mozilla.com> - Wed, 14 Aug 2019 17:49:19 +0000 - rev 488089
Push 113900 by cbrindusan@mozilla.com at Thu, 15 Aug 2019 09:53:50 +0000
Bug 1572800: Part 1: Enable text-decoration-skip-ink by default on Nightly (and early-beta and earlier) r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D41881
97d2c247864301ab241167615ddeee864297aa8b: Bug 1572800: Part 0: Add text-decoration-skip-ink: none to currently failing test cases r=dholbert
Charlie Marlow <cmarlow@mozilla.com> - Wed, 14 Aug 2019 17:14:20 +0000 - rev 488088
Push 113900 by cbrindusan@mozilla.com at Thu, 15 Aug 2019 09:53:50 +0000
Bug 1572800: Part 0: Add text-decoration-skip-ink: none to currently failing test cases r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D41880
27209bcee14fe4bdbfb87c1f128035b3d1cb7f96: Bug 1573725: turn on the pref for text-decoration-thickness on by default (in early-beta and earlier) r=dholbert
Charlie Marlow <cmarlow@mozilla.com> - Wed, 14 Aug 2019 16:46:18 +0000 - rev 488084
Push 113900 by cbrindusan@mozilla.com at Thu, 15 Aug 2019 09:53:50 +0000
Bug 1573725: turn on the pref for text-decoration-thickness on by default (in early-beta and earlier) r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D41883
3f93f3c645b92d2cec2137f831f555eeab79360f: Bug 1573724: turn text-underline-offset pref on by default (in early-beta and earlier) r=dholbert
Charlie Marlow <cmarlow@mozilla.com> - Wed, 14 Aug 2019 16:45:14 +0000 - rev 488083
Push 113900 by cbrindusan@mozilla.com at Thu, 15 Aug 2019 09:53:50 +0000
Bug 1573724: turn text-underline-offset pref on by default (in early-beta and earlier) r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D41882
dee7db615c4e59d244fdd679a1eeef1c03187c2e: Bug 1569648 - Remove a bogus assertion. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 14 Aug 2019 16:41:20 +0000 - rev 488082
Push 113900 by cbrindusan@mozilla.com at Thu, 15 Aug 2019 09:53:50 +0000
Bug 1569648 - Remove a bogus assertion. r=dholbert There's no guarantee at all that the filter URI is valid, it just so happens that for regular CSS filters we bail out earlier. A bogus base URI makes relative uris just invalid, which triggers this assert. The assert was gracefully handled anyway, so no big deal. Differential Revision: https://phabricator.services.mozilla.com/D41952
34bc9228d814dcd95beb0a673883f10263f17b75: Bug 1569825 - Hide some 'display' values in devtools auto-completion that we want to discourage authors from using. r=dholbert
Mats Palmgren <mats@mozilla.com> - Wed, 14 Aug 2019 14:35:56 +0000 - rev 487970
Push 113895 by btara@mozilla.com at Wed, 14 Aug 2019 22:08:04 +0000
Bug 1569825 - Hide some 'display' values in devtools auto-completion that we want to discourage authors from using. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D39810
8c8c8cc13b27c828124880b7726109f4aee3aeef: Bug 1559715 r=dholbert,mstange
longsonr <longsonr@gmail.com> - Sun, 04 Aug 2019 19:43:37 +0000 - rev 487278
Push 113866 by csabou@mozilla.com at Fri, 09 Aug 2019 22:18:05 +0000
Bug 1559715 r=dholbert,mstange Differential Revision: https://phabricator.services.mozilla.com/D36874
ae11564c4d7f867c69e3d147efba82af53ae441a: Bug 1547759 - Ensure that we call ApplyRelativePositioning after the frame's new size has been set so it works correctly for RTL. r=jfkthame,dholbert
L. David Baron <dbaron@dbaron.org> - Thu, 08 Aug 2019 20:04:40 +0000 - rev 487071
Push 113859 by rmaries@mozilla.com at Fri, 09 Aug 2019 03:53:37 +0000
Bug 1547759 - Ensure that we call ApplyRelativePositioning after the frame's new size has been set so it works correctly for RTL. r=jfkthame,dholbert Differential Revision: https://phabricator.services.mozilla.com/D40568
9e23c2da81e3027bb4fea4a25fe68be230743227: Bug 1571567 - Fix no-fallthrough errors in /layout. r=dholbert
Jared Wein <jwein@mozilla.com> - Thu, 08 Aug 2019 15:18:39 +0000 - rev 487005
Push 113859 by rmaries@mozilla.com at Fri, 09 Aug 2019 03:53:37 +0000
Bug 1571567 - Fix no-fallthrough errors in /layout. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D40876
fbdf6b75a4846dee11bd6aa87617d3c9a4e5b379: Bug 1571567 - Fix no-fallthrough errors in /layout. r=dholbert
Jared Wein <jwein@mozilla.com> - Thu, 08 Aug 2019 01:38:51 +0000 - rev 486965
Push 113859 by rmaries@mozilla.com at Fri, 09 Aug 2019 03:53:37 +0000
Bug 1571567 - Fix no-fallthrough errors in /layout. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D40876