searching for reviewer(dbaron)
0dc7546c4a8a75dda043edc312305a6ceba0ad53: Bug 1593170. Check if contentRootElement is a dead wrapper before using it. r=mattwoodrow,dbaron
Timothy Nikkel <tnikkel@gmail.com> - Mon, 18 Nov 2019 11:27:00 +0000 - rev 502491
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1593170. Check if contentRootElement is a dead wrapper before using it. r=mattwoodrow,dbaron With the fission changes everything is more async, meaning some tests can run longer. Some crashtests navigate to a new location meaning the original root element we have a variable for is no longer around, and chrome isn't allowed to keep content nodes alive, so we are left holding a dead wrapper that throws if we try to access anything on it. So we check if contentRootElement has become a dead wrapper (and null it out) any time we try to access it and it could have become dead. Generally the existing code already handled a null contentRootElement. Differential Revision: https://phabricator.services.mozilla.com/D52829
d511975b764e8f5e97c4511dc39c9aa103e30793: Bug 1593170. Check if contentRootElement is a dead wrapper before using it. r=mattwoodrow,dbaron
Timothy Nikkel <tnikkel@gmail.com> - Mon, 18 Nov 2019 00:49:07 +0000 - rev 502365
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1593170. Check if contentRootElement is a dead wrapper before using it. r=mattwoodrow,dbaron With the fission changes everything is more async, meaning some tests can run longer. Some crashtests navigate to a new location meaning the original root element we have a variable for is no longer around, and chrome isn't allowed to keep content nodes alive, so we are left holding a dead wrapper that throws if we try to access anything on it. So we check if contentRootElement has become a dead wrapper (and null it out) any time we try to access it and it could have become dead. Generally the existing code already handled a null contentRootElement. Differential Revision: https://phabricator.services.mozilla.com/D52829
0acd7eb3e16791362f3e8949d45668896beff6df: Bug 1584040 - Allow assertions in outline-in-frameset.xhtml crashtest; r=dbaron
Geoff Brown <gbrown@mozilla.com> - Tue, 05 Nov 2019 19:19:59 +0000 - rev 500690
Push 114166 by apavel@mozilla.com at Thu, 07 Nov 2019 10:04:01 +0000
Bug 1584040 - Allow assertions in outline-in-frameset.xhtml crashtest; r=dbaron Accept assertions to avoid intermittent test failures due to assertion count mismatches. Differential Revision: https://phabricator.services.mozilla.com/D50660
272775d127445bbbd2cbe9895828e198f79f2b8a: Bug 1588760 - Move css-lists reftests into WPT r=dbaron
Oriol Brufau <oriol-bugzilla@hotmail.com> - Fri, 01 Nov 2019 04:27:32 +0000 - rev 500120
Push 114164 by aiakab@mozilla.com at Tue, 05 Nov 2019 10:06:15 +0000
Bug 1588760 - Move css-lists reftests into WPT r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D49278
30f66e8e2c19ea27480c0aab29a66ddb60a61173: Bug 1590185 Part 2 - Support paged mode layout in layout debugger. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Tue, 29 Oct 2019 19:51:42 +0000 - rev 499680
Push 114163 by aiakab@mozilla.com at Thu, 31 Oct 2019 10:03:38 +0000
Bug 1590185 Part 2 - Support paged mode layout in layout debugger. r=dbaron This patch adds a menu item in "Toggle" -> "Paged Mode". If the item is toggled, after finishing loading the document, the document will be forced into paged mode. The print settings in `nsLayoutDebuggingTools::SetPagedMode()` are similar to `setupPrintMode()` in reftest-content.js. Remove the hack in nsDocumentViewer::InitInternal() because we don't want to set a new document when mIsPageMode = false. Differential Revision: https://phabricator.services.mozilla.com/D49993
80ffb5ef8efb71442034e56a093a4367ac06cdf6: Bug 584141 Added WBR frame class implementing nsFrame and overriding thepeekOffset* methods. r=dbaron,Ehsan
Nour <nsaffour@gmail.com> - Mon, 14 Oct 2019 19:35:23 +0000 - rev 498236
Push 114157 by nbeleuzu@mozilla.com at Mon, 21 Oct 2019 22:00:13 +0000
Bug 584141 Added WBR frame class implementing nsFrame and overriding thepeekOffset* methods. r=dbaron,Ehsan The wbr element represents a line break opportunity. Before the change double clicking on a text that contains a wbr element did not select the whole sentence. After the change, the presence of a wbr element in the selection does not affect the selection functionality. Differential Revision: https://phabricator.services.mozilla.com/D47558
77357e0aa88eadf3a4b73e181a410913303929f3: Bug 1584859 - Make smooth scrolling conditional on reduced motion settings. r=dbaron
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 13 Oct 2019 09:16:26 +0000 - rev 497356
Push 114148 by shindli@mozilla.com at Mon, 14 Oct 2019 10:49:50 +0000
Bug 1584859 - Make smooth scrolling conditional on reduced motion settings. r=dbaron We could put this change itself behind a pref too, if we considered that worth it. But probably not so. Differential Revision: https://phabricator.services.mozilla.com/D48010
1703ed8928713ba27d051495eb6668fc23068765: Bug 1426010 - Ship column-span. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Thu, 03 Oct 2019 18:25:27 +0000 - rev 496801
Push 114146 by dmajor@mozilla.com at Wed, 09 Oct 2019 17:52:49 +0000
Bug 1426010 - Ship column-span. r=dbaron Enable layout.css.column-span.enabled in all channels. Differential Revision: https://phabricator.services.mozilla.com/D47352
5921da6981097a5b1cb16335a0d7d22136239693: Bug 1579565 Part 2 - Skip block-end side if the frame has a column-span sibling. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Thu, 03 Oct 2019 17:26:06 +0000 - rev 496210
Push 114143 by rgurzau@mozilla.com at Mon, 07 Oct 2019 09:35:08 +0000
Bug 1579565 Part 2 - Skip block-end side if the frame has a column-span sibling. r=dbaron Also, clean up the wording and variable names when aReflowInput is used. Differential Revision: https://phabricator.services.mozilla.com/D47676
614dba91c0b17f628c5e32021c6cbb768bd2ac94: Bug 1579565 Part 1 - Skip applying the child block's block-end margin when placing it if it has a later sibling across column-span split. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Thu, 03 Oct 2019 17:28:48 +0000 - rev 496209
Push 114143 by rgurzau@mozilla.com at Mon, 07 Oct 2019 09:35:08 +0000
Bug 1579565 Part 1 - Skip applying the child block's block-end margin when placing it if it has a later sibling across column-span split. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D47675
bbd6585e5a80c45a03f2eb8046fb0a53d6a6569a: Bug 1547160 - Update comments for expected column-span test failures. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Fri, 27 Sep 2019 19:00:36 +0000 - rev 495434
Push 114134 by ccoroiu@mozilla.com at Mon, 30 Sep 2019 09:57:15 +0000
Bug 1547160 - Update comments for expected column-span test failures. r=dbaron multicol-span-all-margin-bottom-001.xht and multicol-span-none-001.xht have been patched upstream. They should pass after we import from wpt. DONTBUILD because this is a comment-only change. Differential Revision: https://phabricator.services.mozilla.com/D47340
d55ef63221849c2c4c9bdaf89a74c2e7b60cc34a: Bug 1575054 - Disable column balancing for nested multicol containers of depth more than two. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Thu, 26 Sep 2019 22:07:53 +0000 - rev 495270
Push 114134 by ccoroiu@mozilla.com at Mon, 30 Sep 2019 09:57:15 +0000
Bug 1575054 - Disable column balancing for nested multicol containers of depth more than two. r=dbaron That is, for the multicol container of depth two and more, we lay them out by using "column-fill:auto" and "column-count:1". I've check bug 725376 comment 9 for the previous approaches. Thanks to bug 1555818, this solution is feasible because the fragmentation with "column-fill:auto" is now possible. Differential Revision: https://phabricator.services.mozilla.com/D47011
e10a3c2499439232e95ecff9b90c3689c48d7ae2: Bug 1575054 - Disable column balancing for nested multicol containers of depth more than two. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Tue, 24 Sep 2019 21:38:00 +0000 - rev 495228
Push 114134 by ccoroiu@mozilla.com at Mon, 30 Sep 2019 09:57:15 +0000
Bug 1575054 - Disable column balancing for nested multicol containers of depth more than two. r=dbaron That is, for the multicol container of depth two and more, we lay them out by using "column-fill:auto" and "column-count:1". I've check bug 725376 comment 9 for the previous approaches. Thanks to bug 1555818, this solution is feasible because the fragmentation with "column-fill:auto" is now possible. Differential Revision: https://phabricator.services.mozilla.com/D47011
5837862212545b9ca4c7f20bee817a75389d832e: Bug 1583639 Part 4 - Stop creating more columns in column-fill:auto mode if there's still block-size left in multicol container. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Wed, 25 Sep 2019 23:36:41 +0000 - rev 495031
Push 114131 by dluca@mozilla.com at Thu, 26 Sep 2019 09:47:34 +0000
Bug 1583639 Part 4 - Stop creating more columns in column-fill:auto mode if there's still block-size left in multicol container. r=dbaron This patch makes fragmentation in "column-fill:auto" mode possible. Note that we only bail out of creating more column contents when "column-fill:auto" mode is set from the styles, i.e. when mForceAuto is false. That is because when mForceAuto is true, we usually in the case where we have gave up balancing, and we really want to create overflow columns. Note: without `!aConfig.mForceAuto` check, 673770.html can generated assertions, and the frame tree contains dangling Overflow-lines and ExcessOverflowContainersList. Differential Revision: https://phabricator.services.mozilla.com/D47005
1c897f0c159a6c9cf322eae35b2c1eb3539d8a56: Bug 1583639 Part 3 - Keep the optimal used numColumns in column-fill:auto mode without resetting it to INT32_MAX. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Wed, 25 Sep 2019 06:41:10 +0000 - rev 495030
Push 114131 by dluca@mozilla.com at Thu, 26 Sep 2019 09:47:34 +0000
Bug 1583639 Part 3 - Keep the optimal used numColumns in column-fill:auto mode without resetting it to INT32_MAX. r=dbaron mUsedColCount is used in balancing mode to check whether we have created the maximum number of columns when the content cannot fit. Similarly, mUsedColCount can also be useful in "column-fill:auto" mode to improve the fragmentation story in the next patch. This patch doesn't change the behavior (yet). Differential Revision: https://phabricator.services.mozilla.com/D47004
d410846efdeb16b202c781d184ebaf4fd458891c: Bug 1583639 Part 2 - Rename mBalanceColCount to mUsedColCount in nsColumnSetFrame::ReflowConfig. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Wed, 25 Sep 2019 06:43:19 +0000 - rev 495029
Push 114131 by dluca@mozilla.com at Thu, 26 Sep 2019 09:47:34 +0000
Bug 1583639 Part 2 - Rename mBalanceColCount to mUsedColCount in nsColumnSetFrame::ReflowConfig. r=dbaron In next patch, this variable won't be set to INT32_MAX in "column-fill:auto" mode, and it will be used in Part 4. Hence the rename. Differential Revision: https://phabricator.services.mozilla.com/D47003
9913d2611eadecb26b227edee28fdbfac96b07b7: Bug 1583639 Part 1 - De-indent an else-block inside the while-loop in nsColumnSetFrame::ReflowChild. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Tue, 24 Sep 2019 21:09:20 +0000 - rev 495028
Push 114131 by dluca@mozilla.com at Thu, 26 Sep 2019 09:47:34 +0000
Bug 1583639 Part 1 - De-indent an else-block inside the while-loop in nsColumnSetFrame::ReflowChild. r=dbaron The associated if-block has a "break" statement at the end of the scope to break the while-loop, making the else-block redundant. Differential Revision: https://phabricator.services.mozilla.com/D47002
8d46f84b818dce78694859a991f328f2960cdc4e: Bug 1482778 - Include captions within table outlines. r=dbaron
Cameron McCormack <cam@mcc.id.au> - Sun, 22 Sep 2019 23:42:04 +0000 - rev 494457
Push 114120 by malexandru@mozilla.com at Mon, 23 Sep 2019 09:52:13 +0000
Bug 1482778 - Include captions within table outlines. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D45802
88f20e24fa39cd939b5bf6003ec43014f722f8b7: Bug 1575016 - Update a comment that describes minimum 1px block-size for column-content blocks. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Sat, 21 Sep 2019 08:38:54 +0000 - rev 494456
Push 114120 by malexandru@mozilla.com at Mon, 23 Sep 2019 09:52:13 +0000
Bug 1575016 - Update a comment that describes minimum 1px block-size for column-content blocks. r=dbaron Fragmentation spec already has a paragraph describing this behavior. DONTBUILD because this is a comment only change. Differential Revision: https://phabricator.services.mozilla.com/D46691
1278aa29cad02f46b268c300165eda92582a3d56: Bug 1575964 Part 2 - Fix RTL column positions when column-span is enabled. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Tue, 17 Sep 2019 01:12:30 +0000 - rev 493467
Push 114090 by rgurzau@mozilla.com at Tue, 17 Sep 2019 09:38:30 +0000
Bug 1575964 Part 2 - Fix RTL column positions when column-span is enabled. r=dbaron Since column-contents' positions are moved, we need to fix ColumnSet's overflow areas as well. Differential Revision: https://phabricator.services.mozilla.com/D44279
754f6bc92d676472b74bc94f62384b93e97ee335: Bug 1575964 Part 1 - Separate a fixup logic which is redundant if column-span is enabled. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Mon, 16 Sep 2019 18:45:34 +0000 - rev 493466
Push 114090 by rgurzau@mozilla.com at Tue, 17 Sep 2019 09:38:30 +0000
Bug 1575964 Part 1 - Separate a fixup logic which is redundant if column-span is enabled. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D44278
c4b6564e69a26a0d6feea803071ba4416c55743d: Bug 1523582 Part 5 - Update test expectations. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Mon, 09 Sep 2019 17:42:18 +0000 - rev 492386
Push 114055 by rgurzau@mozilla.com at Tue, 10 Sep 2019 03:33:46 +0000
Bug 1523582 Part 5 - Update test expectations. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D44029
edaa11a265471c4710893a1a260886bcaf3ac957: Bug 1523582 Part 4 - Support comment at the end of line in failures.list, and regenerate reftest.list. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Mon, 09 Sep 2019 17:42:16 +0000 - rev 492385
Push 114055 by rgurzau@mozilla.com at Tue, 10 Sep 2019 03:33:46 +0000
Bug 1523582 Part 4 - Support comment at the end of line in failures.list, and regenerate reftest.list. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D44028
be8883d72832f83fab1f4bb4bb1c1f5adfa59070: Bug 1523582 Part 3 - Adjust GetLogicalSkipSides() to check non-fluid continuations. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Mon, 09 Sep 2019 17:42:14 +0000 - rev 492384
Push 114055 by rgurzau@mozilla.com at Tue, 10 Sep 2019 03:33:46 +0000
Bug 1523582 Part 3 - Adjust GetLogicalSkipSides() to check non-fluid continuations. r=dbaron Frames split by column-span are linked together by non-fluid continuations. We want GetLogicalSkipSides() to recognize that. The documentation in nsIFrame::GetLogicalSkipSides() already uses *continuation* rather than *in-flow*, so no need to adjust the wording. However, after patching GetLogicalSkipSides(), the first column-content after a column-span split starts to skip the block-start side because it has a previous continuation. We want the content in the first column to consider applying its block-start margin. Hence the modification in BlockReflowInput's constructor. (Note that the first column-content is always a block-start margin-root, which is fixed in the previous part.) This is necessary to avoid breaking testing/web-platform/tests/css/css-multicol/multicol-span-all-margin-bottom-001.xht In multicol-span-all-children-height-006.html, add "margin-top: 1em;" to the container to expose the bug if we still check GetPrevInFlow() rather than GetPrevContinuation() when computing applyBStartMargin in nsBlockFrame::ReflowBlockFrame(). Differential Revision: https://phabricator.services.mozilla.com/D43905
1e447195b68c5012751e90497ba97a6421e3669e: Bug 1523582 Part 2 - Make -moz-column-content a BFC when column-span is enabled. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Mon, 09 Sep 2019 17:42:12 +0000 - rev 492383
Push 114055 by rgurzau@mozilla.com at Tue, 10 Sep 2019 03:33:46 +0000
Bug 1523582 Part 2 - Make -moz-column-content a BFC when column-span is enabled. r=dbaron Based on CSS working group's resolution in https://github.com/w3c/csswg-drafts/issues/2582#issuecomment-402619872, column-boxes are BFC. Add NS_BLOCK_FORMATTING_CONTEXT_STATE_BITS to -moz-column-content, but only for the new multicol layout. Differential Revision: https://phabricator.services.mozilla.com/D43904
1533c2919c7c92860c1db544336bfeb70f3965d1: Bug 1523582 Part 1 - Use NOISY_BLOCK_DIR_MARGINS to control log print in nsBlockReflowContext. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Mon, 09 Sep 2019 17:42:10 +0000 - rev 492382
Push 114055 by rgurzau@mozilla.com at Tue, 10 Sep 2019 03:33:46 +0000
Bug 1523582 Part 1 - Use NOISY_BLOCK_DIR_MARGINS to control log print in nsBlockReflowContext. r=dbaron nsBlockDebugFlags.h defines NOISY_BLOCK_DIR_MARGINS, which is used in nsBlockFrame. Include it in nsBlockReflowContext.cpp so that when NOISY_BLOCK_DIR_MARGINS is defined, the log is printed in nsBlockReflowContext.cpp as well. Remove unused NOISY_MAX_ELEMENT_SIZE and REALLY_NOISY_MAX_ELEMENT_SIZE. Differential Revision: https://phabricator.services.mozilla.com/D43903
2345d813f59d8ceedd6a61f630e9df09620296e8: Bug 1577072 followup: Use an even larger line-height in our "bigger-than-one" text-input line-height reftest, to accommodate bigger widgets on Debian. r=dbaron
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 04 Sep 2019 22:13:07 +0000 - rev 491752
Push 114033 by ccoroiu@mozilla.com at Thu, 05 Sep 2019 16:21:04 +0000
Bug 1577072 followup: Use an even larger line-height in our "bigger-than-one" text-input line-height reftest, to accommodate bigger widgets on Debian. r=dbaron Previous commit on this bug bumped up the test from a line-height of 1.5 to 1.8, but that's still not taller than the default widget height on Debian. But 2.5 does seem to be sufficiently tall to produce a size difference. Differential Revision: https://phabricator.services.mozilla.com/D44719
dc0a13baf8c30e816302c8604915510bbaff6f46: Bug 1577390 - Wait a bit before loading document in Layout Debugger when profiling. r=dbaron
Cameron McCormack <cam@mcc.id.au> - Fri, 30 Aug 2019 23:12:58 +0000 - rev 491067
Push 114014 by btara@mozilla.com at Mon, 02 Sep 2019 09:53:36 +0000
Bug 1577390 - Wait a bit before loading document in Layout Debugger when profiling. r=dbaron That gives the profiler a chance to attach to a newly created content process. There's no API for waiting for the profiler to be ready in a just-created process, unfortunately. Differential Revision: https://phabricator.services.mozilla.com/D43898
7d029a9d6c0de272be77e49114555e493b480a05: Bug 1577072: Use a slightly larger line-height in our "bigger-than-one" text-input line-height reftest, to accommodate bigger widgets on Debian. r=dbaron
Daniel Holbert <dholbert@cs.stanford.edu> - Fri, 30 Aug 2019 23:25:39 +0000 - rev 490976
Push 114010 by dluca@mozilla.com at Sat, 31 Aug 2019 09:58:00 +0000
Bug 1577072: Use a slightly larger line-height in our "bigger-than-one" text-input line-height reftest, to accommodate bigger widgets on Debian. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D43787
86ef6dc7a0bce946387d5e0e066d2808f109c3d5: Bug 1573329 - Add web-platform reftests for multicol breaking. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Tue, 27 Aug 2019 22:36:42 +0000 - rev 490336
Push 113989 by btara@mozilla.com at Wed, 28 Aug 2019 09:49:25 +0000
Bug 1573329 - Add web-platform reftests for multicol breaking. r=dbaron These tests are fixed by bug 1575106, Differential Revision: https://phabricator.services.mozilla.com/D43676
400cbd23462116d9e80ebe1765248da6e60b1fcd: Bug 1575106 Part 4 - Add reftests, crashtests, and adjust test expectations. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Mon, 26 Aug 2019 06:10:34 +0000 - rev 489890
Push 113976 by malexandru@mozilla.com at Mon, 26 Aug 2019 23:07:04 +0000
Bug 1575106 Part 4 - Add reftests, crashtests, and adjust test expectations. r=dbaron 1346454-1.html and 1346454-2.html are moved to keep the list sorted. Differential Revision: https://phabricator.services.mozilla.com/D43129
66042c8f7236383f5f4c89832567f359b62e4d32: Bug 1575106 Part 3 - Use unconstrained block-size to measure last column, and revise condition to create overflow columns. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Mon, 26 Aug 2019 07:03:36 +0000 - rev 489889
Push 113976 by malexandru@mozilla.com at Mon, 26 Aug 2019 23:07:04 +0000
Bug 1575106 Part 3 - Use unconstrained block-size to measure last column, and revise condition to create overflow columns. r=dbaron This patch changes behavior only if column-span is enabled. It fixes a lot of fuzzing test cases which will be added in the next part. It changes the column balancing behavior in the following ways. 1) By using unconstrained block-size to measure the last column in the first balancing iteration, we can guarantee that mKnownFeasibleBSize has the correct feasible block-size. 2) Always reflow one more time if the content cannot fit in the available content block-size. Due to 1), the content (last column) always returns fully complete in the first balancing iteration even if it's in an inner column with a constrained available block-size. We need to reflow again to get the correct *incomplete* reflow status so that the outer column can create next-in-flows for the inner column. 3) ColumnSet gives up balancing only when ColumnSetWrapper is running out of block-size. When a ColumnSetWrapper has constrained block-size, i.e. it's in a fragmentation context like pages or nested columns, we prioritize fragmenting ColumnSetWrapper over creating overflow columns within the nsColumnSet. Differential Revision: https://phabricator.services.mozilla.com/D43128
d72dc86143743f69ce3ca27f8f572a33f8c6dccb: Bug 1575106 Part 2 - Rename blockReflowInput to childReflowInput in nsBlockFrame::ReflowBlockFrame(). r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Mon, 26 Aug 2019 06:10:21 +0000 - rev 489888
Push 113976 by malexandru@mozilla.com at Mon, 26 Aug 2019 23:07:04 +0000
Bug 1575106 Part 2 - Rename blockReflowInput to childReflowInput in nsBlockFrame::ReflowBlockFrame(). r=dbaron Every time I read the code, the name `blockReflowInput` makes me think the variable is an instance of `BlockReflowInput`, but it is not. Differential Revision: https://phabricator.services.mozilla.com/D43127
95b4fc380349b04326fb0378085daaf0f55324ae: Bug 1575106 Part 1 - Use a variable to indicate ColumnSet is measuring the feasible block-size. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Mon, 26 Aug 2019 06:10:11 +0000 - rev 489887
Push 113976 by malexandru@mozilla.com at Mon, 26 Aug 2019 23:07:04 +0000
Bug 1575106 Part 1 - Use a variable to indicate ColumnSet is measuring the feasible block-size. r=dbaron That is when ColumnSet gives its last ::moz-column-content unbounded available block-size in the very first balancing iteration. Note that the last column's available block-size isn't really *unbounded* yet, but we'll make it happen in the next part. Differential Revision: https://phabricator.services.mozilla.com/D43126
a1e72b9b205ded6511b0231371c6ab5b31dea957: Bug 1569077 - Part 3: Add --capture-profile argument to the layout debugger. r=dbaron
Cameron McCormack <cam@mcc.id.au> - Sun, 25 Aug 2019 23:38:30 +0000 - rev 489813
Push 113971 by dluca@mozilla.com at Mon, 26 Aug 2019 09:49:12 +0000
Bug 1569077 - Part 3: Add --capture-profile argument to the layout debugger. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D39469
38eb6450911610c73a6aee5f80ca1035e30caef6: Bug 1569077 - Part 2: Add --autoclose argument to the layout debugger. r=dbaron
Cameron McCormack <cam@mcc.id.au> - Sun, 25 Aug 2019 23:38:28 +0000 - rev 489812
Push 113971 by dluca@mozilla.com at Mon, 26 Aug 2019 09:49:12 +0000
Bug 1569077 - Part 2: Add --autoclose argument to the layout debugger. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D39468
8a7e48b3e117939cab046dac642c601e8b2eb4ef: Bug 1569077 - Part 1: Refactor layout debugger command line handling. r=dbaron
Cameron McCormack <cam@mcc.id.au> - Sun, 25 Aug 2019 23:38:26 +0000 - rev 489811
Push 113971 by dluca@mozilla.com at Mon, 26 Aug 2019 09:49:12 +0000
Bug 1569077 - Part 1: Refactor layout debugger command line handling. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D39467
a8646f9a5ab1293561f85ebf1d4f5655e87b06d1: Bug 1568001 - Add crashtests fixed by bug 1420528. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Wed, 21 Aug 2019 19:08:46 +0000 - rev 489276
Push 113942 by aciure@mozilla.com at Thu, 22 Aug 2019 04:06:52 +0000
Bug 1568001 - Add crashtests fixed by bug 1420528. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D42931
af26c6064d12531a81869fdb0341d6bbf841979a: Bug 1575305 Part 4 - Improve column set log. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Wed, 21 Aug 2019 00:25:07 +0000 - rev 489100
Push 113939 by dvarga@mozilla.com at Wed, 21 Aug 2019 11:58:12 +0000
Bug 1575305 Part 4 - Improve column set log. r=dbaron 1. Add `this` to the log so that it's easier to debug a nested column balancing 2. Print the struct fields the same as their names. Differential Revision: https://phabricator.services.mozilla.com/D42711
7f6f92f75e0157d59009513939b2284b52498a8b: Bug 1575305 Part 3 - Initialize colBSize with available block-size when column-span is enabled. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Wed, 21 Aug 2019 00:24:09 +0000 - rev 489099
Push 113939 by dvarga@mozilla.com at Wed, 21 Aug 2019 11:58:12 +0000
Bug 1575305 Part 3 - Initialize colBSize with available block-size when column-span is enabled. r=dbaron nsBlockFrame already prepares the available block-size for ColumnSetFrame with ColumnSetWrapper's block-size and max-block-size applied. (ColumnSet's computed block-size and max block-size is always unconstrained when column-span is enabled.) Differential Revision: https://phabricator.services.mozilla.com/D42710
d786ae0b7dd3046069fd7ef70f113f053ff90ae5: Bug 1575305 Part 2 - Remove the unused border-padding variable in nsBlockFrame::FindBestBalanceBSize(). r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Wed, 21 Aug 2019 00:24:00 +0000 - rev 489098
Push 113939 by dvarga@mozilla.com at Wed, 21 Aug 2019 11:58:12 +0000
Bug 1575305 Part 2 - Remove the unused border-padding variable in nsBlockFrame::FindBestBalanceBSize(). r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D42709
f9187f13c5d3e70729bb281d506fb02319231668: Bug 1575305 Part 1 - Remove an unneeded condition used for ::-moz-column-content. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Tue, 20 Aug 2019 22:29:55 +0000 - rev 489097
Push 113939 by dvarga@mozilla.com at Wed, 21 Aug 2019 11:58:12 +0000
Bug 1575305 Part 1 - Remove an unneeded condition used for ::-moz-column-content. r=dbaron Before bug 1411422, a ::-moz-column-content has height:100%, so it could go into this path if ColumnSet's available block-size is unconstrained. However, after bug 1411422, height:100% was removed for ::-moz-column-content. That is, its computed block-size is unconstrained, so it can't go into this path. This applies regardless of whether column-span is enabled or not. Differential Revision: https://phabricator.services.mozilla.com/D42708
c670f40348ee7794f031ef7f84019592d56154cd: Bug 1570556 - Remove call to pango_fc_font_map_shutdown, which was moved out of public headers in Pango 1.44. r=dbaron
Jonathan Kew <jkew@mozilla.com> - Thu, 15 Aug 2019 20:10:41 +0000 - rev 488477
Push 113910 by ccoroiu@mozilla.com at Fri, 16 Aug 2019 16:28:54 +0000
Bug 1570556 - Remove call to pango_fc_font_map_shutdown, which was moved out of public headers in Pango 1.44. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D42127
e9611b9cff9a7a9bf7ce21a1384d017bf9c02fbe: Bug 1569701 Part 2 - Use ColumnSetWrapper's effective computed content block-size to impose constraint for ColumnSet. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Thu, 15 Aug 2019 16:59:13 +0000 - rev 488288
Push 113906 by ncsoregi@mozilla.com at Fri, 16 Aug 2019 04:07:24 +0000
Bug 1569701 Part 2 - Use ColumnSetWrapper's effective computed content block-size to impose constraint for ColumnSet. r=dbaron Run broken-column-rule-1.html with column-span enabled because it was regressed by Bug 1548100 Part 2, but fixed by this patch. Differential Revision: https://phabricator.services.mozilla.com/D41907
6d5655c8638d8683fe22521583bddd575c668575: Bug 1569701 Part 1 - Make BlockReflowInput::mConsumedBSize a constant, and delete it assessor method. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Thu, 15 Aug 2019 16:49:14 +0000 - rev 488287
Push 113906 by ncsoregi@mozilla.com at Fri, 16 Aug 2019 04:07:24 +0000
Bug 1569701 Part 1 - Make BlockReflowInput::mConsumedBSize a constant, and delete it assessor method. r=dbaron We always pass consumed block-size into BlockReflowInput's constructor in nsBlockFrame::Reflow(). By making mConsumedBSize a constant, its assessor method becomes redundant. Update the documentation to reflect the reality that ConsumedBSize() accumulates content block-size from all previous *continuations*, which was done in Bug 1506293 Part 2. Differential Revision: https://phabricator.services.mozilla.com/D41906
e56e6ed91e5af309cbca9ce38252f03530d81b79: Bug 1569701 Part 0 - Use nscoord instead of int for contentBEnd in nsColumnSetFrame::ReflowChildren(). r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Wed, 14 Aug 2019 23:17:06 +0000 - rev 488286
Push 113906 by ncsoregi@mozilla.com at Fri, 16 Aug 2019 04:07:24 +0000
Bug 1569701 Part 0 - Use nscoord instead of int for contentBEnd in nsColumnSetFrame::ReflowChildren(). r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D41905
15849d06fab7a070e56badc4664fb945313f0ed9: Bug 1573761 - Add a web-platform reftest multicol-breaking-nobackground-004.html r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Wed, 14 Aug 2019 23:16:01 +0000 - rev 488172
Push 113904 by ncsoregi@mozilla.com at Thu, 15 Aug 2019 19:41:00 +0000
Bug 1573761 - Add a web-platform reftest multicol-breaking-nobackground-004.html r=dbaron For a better symmetry between the multicol-breaking tests and their no background variants, this patch adds a nobackground test for multicol-breaking-004.html. This tests the same things as multicol-breaking-004.html, but with two things removed: outer column's blue column-rules and inner columns' background. Differential Revision: https://phabricator.services.mozilla.com/D41903
6760ce3f266d394ef04dfffb5965f59f2a913ed8: Bug 1571849 - In ColumnSetFrame, use mParentReflowInput to get the ColumnSetWrapperFrame's reflow input. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Mon, 12 Aug 2019 06:41:51 +0000 - rev 487406
Push 113876 by aiakab@mozilla.com at Mon, 12 Aug 2019 16:26:30 +0000
Bug 1571849 - In ColumnSetFrame, use mParentReflowInput to get the ColumnSetWrapperFrame's reflow input. r=dbaron In ColumnSetFrame's reflow methods, mCBReflowInput is equal to mParentReflowInput in most of the cases. However, a multicol <button> has the HTMLButtonControl as the outermost frame, where ColumnSetWrapper is its -moz-button-content anonymous child. In this case, mCBReflowInput is HTMLButtonControl's reflow input. To get the correct computedBSize of ColumnSetWrapper, we need to use mParentReflowInput. Differential Revision: https://phabricator.services.mozilla.com/D41497
f719a2df1b9620b000575eb2ddb289988904f634: Bug 1572912 - Enable column-span preference to fix existing test failures. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Mon, 12 Aug 2019 04:32:34 +0000 - rev 487403
Push 113875 by aiakab@mozilla.com at Mon, 12 Aug 2019 10:02:54 +0000
Bug 1572912 - Enable column-span preference to fix existing test failures. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D41496
54d0d836b0970a9db8af7844326fdc0d72845d64: Bug 1569252 Part 2 - Let mHasColumnSpanSiblings propagate to all the continuations. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Wed, 07 Aug 2019 20:20:25 +0000 - rev 486882
Push 113856 by ncsoregi@mozilla.com at Thu, 08 Aug 2019 09:38:55 +0000
Bug 1569252 Part 2 - Let mHasColumnSpanSiblings propagate to all the continuations. r=dbaron We want mHasColumnSpanSiblings to propagate to all the continuations (both fixed ones or fluid ones) in nsFrame::Init() so that we don't need to traverse all the way to FirstInFlow() for the bit in nsBlockFrame::ComputeFinalBSize(). For the last ColumnSet or the last non-column-span wrapper, we'll need to unset the bit for them manually after constructing them. Differential Revision: https://phabricator.services.mozilla.com/D40761