Bug 1547162 Part 3 - Strip "-moz" prefix for all column properties in the received tests, and mark multicol-span-000-ref.xht pass. r=dbaron multicol-span-000.xht passes because the id in <div id="column-span">123456</div> was incorrect replaced by "-moz-column-span". Strip the "-moz" prefix fixed it. Except failures.list, other files were modified mechanically by running import-tests.py against https://github.com/web-platform-tests/wpt commit 15f199c91a72b0d51bf0a12b3b77827ecb5051ff (the same commit in received/import.log). Differential Revision: https://phabricator.services.mozilla.com/D30406

Bug 1547162 Part 2 - Remove all the column properties from gPrefixedProperties in import-tests.py. r=dbaron Also, build gPrefixRegexp and replace lines only if gPrefixedProperties is non-empty. Otherwise, the import tests are messed up due to bogus gPrefixRegexp. Differential Revision: https://phabricator.services.mozilla.com/D30405

Bug 1547162 Part 1 - Remove unused variables and imports in import-test.py. r=dbaron This is discovered by running "flake8 import-tests.py" locally. Differential Revision: https://phabricator.services.mozilla.com/D30404

Bug 1548118 Part 4 - Always mark inner ColumnSetWrapper's children dirty before reflowing it if the outer ColumnSetWrapper is balancing. r=dbaron ColumnSetFrame always tries to reflow column content regardless of it's dirtiness. Making ColumnSetWrapperFrame's children dirty can have the same effect. Differential Revision: https://phabricator.services.mozilla.com/D29435

Bug 1548118 Part 3 - Remove margin-bottom from column-balancing-nested-001.html and its reference. r=dbaron Per bug 1487927, margin-bottom value is not always rendered as expected with our column balancing algorithm. I'd like to remove it from column-balancing-nested-001.html, and add <br> to separate each cases. Differential Revision: https://phabricator.services.mozilla.com/D30287

Bug 1548118 Part 2 - Extract computing column balancing depth logic to a function. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D29434

Bug 1548118 Part 1 - Advance the column count at the end of the while loop. r=dbaron We use `columnCount == aConfig.mBalanceColCount - 1` in other places to determine if we are at the last column. Advancing the column count at the end of the loop make the condition consistent. Differential Revision: https://phabricator.services.mozilla.com/D29433

Bug 1548118 Part 3 - Always mark inner ColumnSetWrapper's children dirty before reflowing it if the outer ColumnSetWrapper is balancing. r=dbaron ColumnSetFrame always tries to reflow column content regardless of it's dirtiness. Making ColumnSetWrapperFrame's children dirty can have the same effect. Differential Revision: https://phabricator.services.mozilla.com/D29435

Bug 1548118 Part 2 - Extract computing column balancing depth logic to a function. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D29434

Bug 1548118 Part 1 - Advance the column count at the end of the while loop. r=dbaron We use `columnCount == aConfig.mBalanceColCount - 1` in other places to determine if we are at the last column. Advancing the column count at the end of the loop make the condition consistent. Differential Revision: https://phabricator.services.mozilla.com/D29433

Bug 1547852: Only enable dynamic reflow roots up through early beta. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D29288

Bug 1547606 - Mark multicol-span-all-margin-bottom-001.xht fail for Android x86 non-e10s. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D29234

Bug 1547086 Part 2 - Enable column-span preference to fix existing test failures. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D28893

Bug 1547086 Part 1 - Improve import-test.py, and regenerate received/reftest.list. r=dbaron import.log and reftest.list are generated automatically. I run import-test.py on Linux, and the filenames in import.log are not sorted properly, so I make them sort case-insensitively to reproduce the exact same order in import.log. Differential Revision: https://phabricator.services.mozilla.com/D29064

Bug 1411422 - Make percentage block size children work without "height:100%" in ::-moz-column-set and ::-moz-column-content. r=dbaron After introducing column-span, the ColumnSetWrapperFrame can have more than one ColumnSetFrame children if there's any column-span:all child. Thus we cannot use "height:100%" to pass block size information down to the -moz-column-content's children. Skip column span wrapper in nsIFrame::IsBlockWrapper() so that the percentage column-span:all works. Before this patch, the height of column contents are set to 100% of the multicol container, so if the previous in-flows of column content anonymous boxes consume all the height, later in-flows's height are all 0. In this patch, we don't restrict column-content's height, so their height are calculated based on their children's height. column-contain-1a.html passes because it can now correctly calculate the union of all the column content's rect to find the correct sticky positioning. Differential Revision: https://phabricator.services.mozilla.com/D27627

Bug 1544285 - tools/ automated ESLint no-throw-literal fixes. r=dbaron Result of running: $ mach eslint -funix tools/ | sed -Ee 's/:.+//' - | xargs sed -E \ -e 's/throw ((["`])[^"]+\2);/throw new Error(\1);/g' \ -e 's/throw ((["`])[^"]+\2 \+ [^ ";]+);/throw new Error(\1);/g' \ -e 's/throw \(/throw new Error(/g' -i Differential Revision: https://phabricator.services.mozilla.com/D27450

Bug 1118168 - Always call GetColFrame on the nsTableFrame's first-in-flow. r=dbaron

Bug 1489295 Part 4 - Remove InitAndWrapInColumnSetFrameIfNeeded(). r=dbaron The last consumer of the method is removed in Part 3. Depends on D24396 Differential Revision: https://phabricator.services.mozilla.com/D24470

Bug 1489295 Part 3 - Implement column-span:all for <button>. r=dbaron We need to pull outerFrame one level up to the outer scope because it's needed when calling FinishBuildingColumns(). The patch is very similar to implementing column-span:all for <fieldset> in bug 1535200. Differential Revision: https://phabricator.services.mozilla.com/D24396

Bug 1489295 Part 2 - Clean up the naming of a 'nsStyleContext' variable in ConstructFrameFromItemInternal(). r=dbaron Rename outerSC to outerStyle because nsStyleContext was gone. Depends on D24394 Differential Revision: https://phabricator.services.mozilla.com/D24395

Bug 1489295 Part 1 - Rename frame construction data bit that creates flex/grid/column. r=dbaron After supporting column-span, the top-level container for multicol layout is no longer the ColumnSetFrame, so remove the "SET" suffix from FCDATA_ALLOW_GRID_FLEX_COLUMNSET bit to make it sound more general. Also, update the document and add an assertion. Differential Revision: https://phabricator.services.mozilla.com/D24394

Bug 1535200 Part 2 - Implement column-span:all for fieldset elements. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D23618

Bug 1533885 - Bail out from MaybeRecreateForColumnSpan if aFrameList is empty. r=dbaron The test case triggers MOZ_ASSERT(!IsFramePartOfIBSplit(aParentFrame)) in MaybeRecreateForColumnSpan() because WipeContainingBlock() returns early when the FrameConstructionItemList is empty. Thus, it doesn't wipe the aParentFrame even if it's part of an IB split. An empty FrameConstructionItemList constructs no frames. Therefore, MaybeRecreateForColumnSpan() doesn't need to do anything if aFrameList is empty since an empty frame list cannot contain any column-span. Differential Revision: https://phabricator.services.mozilla.com/D23820

Bug 1501665 - No bug: Add comment with rationale behind choice of default viewport. r=dbaron DONTBUILD CLOSED TREE Especially in view of the patches for bug 1501665, which seem to have some- what misunderstood the reason for the choice of viewport width here. Differential Revision: https://phabricator.services.mozilla.com/D20950

Bug 1501665 - No bug: Add comment with rationale behind choice of default viewport. r=dbaron Especially in view of the patches for bug 1501665, which seem to have some- what misunderstood the reason for the choice of viewport width here. Differential Revision: https://phabricator.services.mozilla.com/D20950

Bug 1530048 part 2: Add test to verify that table, td, and th draw borders using 'currentColor'. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D21249

Bug 1530048 part 1: Remove quirks-mode-only UA stylesheet rule that made table borders gray. r=dbaron This quirk was originally for compatibility with IE, but IE doesn't have this special behavior anymore (in quirks-mode or in standards-mode). And Blink/WebKit have yet another set of behaviors, which are also not quirks-mode-dependent, and vary depending on the part of the table: https://bugs.chromium.org/p/chromium/issues/detail?id=935708 https://bugs.chromium.org/p/chromium/issues/detail?id=935729 Differential Revision: https://phabricator.services.mozilla.com/D21175

Bug 1531740 - make reftest-analyzer.xhtml stricter finding images r=dbaron Depends on D21688 Differential Revision: https://phabricator.services.mozilla.com/D21689

Bug 1530008 - make reftest-analyzer.xhtml work with local WPT output r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D21688

Bug 1465457 - Load osx theme reftests over chrome r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D20586

Bug 1465457 - Add support for chrome reftests r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D20585

Bug 1468021 - Handle anonymous content when comparing using DoCompareTreePosition. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D20596

Bug 1527725 - Exclude ColumnSetWrapperFrame from the first letter style consistency check in nsBlockFrame. r=dbaron If there's ::first-letter pseudo element on the multicol container, ColumnSetWrapperFrame will have the first letter style, but it won't get the NS_BLOCK_HAS_FIRST_LETTER_STYLE bit during frame construction. The actual first-letter frame construction happens under -moz-column-content anonymous block. This patch excludes ColumnSetWrapperFrame from the debug check to meet the expectation. Add a reftest to make sure ::first-letter and ::first-line still work after introducing ColumnSetWrapperFrame, and no assertion is fired. Differential Revision: https://phabricator.services.mozilla.com/D20757

Bug 1524382 - Flush all out-of-flow frames before destroying the frame list when reframing multicol container. r=dbaron aFrameList can contain placeholder frames. If we decide to nuke aFrameList, we need to destroy the out-of-flow frames gracefully. In this case, out-of-flow frames are still in nsFrameConstructorState's absolute item lists. To rely on nsPlaceholderFrame::DestroyFrom() to remove its out-of-flow frame properly, we manually flush all the frame insertions for all the lists in aState before destroying aFrameList. Differential Revision: https://phabricator.services.mozilla.com/D19460

Bug 1508420: Add mochitest for conditions that disqualify a frame from becoming a dynamic reflow root. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D14669

Bug 1520722 Part 2 - When removing bidi continuations, go no further than the block which needs resolution. r=dbaron When doing bidi resolution for column-content blocks, we may still traverse the parent chain up in RemoveBidiContinuation, reach nsColumnSetFrame, and accidentally convert nsColumnSetFrame's continuation into fluid ones. Differential Revision: https://phabricator.services.mozilla.com/D17551

Bug 1520722 Part 1 - Remove NS_BLOCK_NEEDS_BIDI_RESOLUTION flag from ColumnSpanWrapperFrame. r=dbaron Calling nsBlockFrame::ResolveBidi() on ColumnSpanWrapperFrame may cause nsColumnSetFrame's non-fluid continuations being converted into fluid ones in JoinInlineAncestors(). Since ColumnSpanWrapperFrame can only have nsColumnSetFrame and column-span wrappers kids, no need to perform bidi resolution. This doesn't affect column contents because they'll inherit "unicode-bidi" from ColumnSetWrapperFrame in ua.css. Differential Revision: https://phabricator.services.mozilla.com/D17550

Bug 1504053 - Reframe multi-column container if inserting a subtree with a column-span child. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D16077

Bug 1517264 - Add support for wrench reftest parsing in the reftest-analyzer. r=dbaron The wrench reftest suite runs reftests on the standalone webrender project, and emits output that is compatible with the reftest analyzer. However, the output takes a slightly different path through taskcluster (the job runs via generic-worker rather than mozharness) and so doesn't have the "(INFO|ERROR) -" prefix that the analyzer expects. This patch loosens that restriction so that these logs can be parsed properly. Differential Revision: https://phabricator.services.mozilla.com/D15577

Bug 1517264 - Add a mechanism to regression-test the reftest parsing code. r=dbaron This code has gotten tweaked a number of times over the years to support new log formats, but there's always the risk that a tweak will break old log formats. So this patch adds a small test function that can be run by anybody making changes to ensure old logs still parse fine. A few current log samples are tested thusly. Differential Revision: https://phabricator.services.mozilla.com/D15576

Bug 1516739 - Stop reparenting absolute/fixed positioned blocks when constructing multicol container. r=dbaron The crash happens when we try to reparent the absolute/fixed positioned children to the non-column-span wrapper's absolute list. When constructing the multicol container, we want it to be the absolute/fixed position container, not the moz-column-content anonymous blocks. Hence the modification in AppendFramesToParent() and ConstructBlock(). Delete AdjustAbsoluteContainingBlock() because we'd like to reparent absolute/fixed children to non-first continuation of block descendant of multicol. And it doesn't crash anymore today. Differential Revision: https://phabricator.services.mozilla.com/D16728

Bug 1517067: Allow table-caption boxes to be dynamic reflow roots. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D17006

Bug 1305957 part 7 - Adjust scroll offset to match change in relative position of scroll anchor after reflow. r=hiro,dbaron This commit implements anchor offset adjustment. When the position of a frame that is an anchor is changed during reflow, we notify the anchor container. The anchor container will then post a reflow callback. Then when reflow is completed, the anchor container will perform a scroll to keep the anchor node in the same relative position. Differential Revision: https://phabricator.services.mozilla.com/D13270

Bug 1305957 part 5 - Add implementation of scroll anchor selection and invalidation. r=hiro,dbaron,dholbert This commit implements candidate selection for a scroll frame using a frame tree traversal. It roughly tries to follow the algorithm given in the scroll anchoring draft specification, adapted to operate on the frame tree [1]. Some details, such as not selecting an anchor if the user hasn't scrolled are not currently in the specification but will be to match Blink's implementation. Once a scroll anchor has been selected, we maintain a bit on it and its ancestor frame's states. This is used in a later commit to detect changes to position during a reflow so the scroll frame can perform an adjustment. A scroll anchor will be invalidated when the user scrolls the frame or the scroll anchor is destroyed. Later commits will add logic to drive selection and invalidation appropriately. [1] https://drafts.csswg.org/css-scroll-anchoring/#anchor-node-selection Differential Revision: https://phabricator.services.mozilla.com/D13268

Bug 1305957 part 7 - Adjust scroll offset to match change in relative position of scroll anchor after reflow. r=hiro,dbaron This commit implements anchor offset adjustment. When the position of a frame that is an anchor is changed during reflow, we notify the anchor container. The anchor container will then post a reflow callback. Then when reflow is completed, the anchor container will perform a scroll to keep the anchor node in the same relative position. Differential Revision: https://phabricator.services.mozilla.com/D13270

Bug 1305957 part 5 - Add implementation of scroll anchor selection and invalidation. r=hiro,dbaron,dholbert This commit implements candidate selection for a scroll frame using a frame tree traversal. It roughly tries to follow the algorithm given in the scroll anchoring draft specification, adapted to operate on the frame tree [1]. Some details, such as not selecting an anchor if the user hasn't scrolled are not currently in the specification but will be to match Blink's implementation. Once a scroll anchor has been selected, we maintain a bit on it and its ancestor frame's states. This is used in a later commit to detect changes to position during a reflow so the scroll frame can perform an adjustment. A scroll anchor will be invalidated when the user scrolls the frame or the scroll anchor is destroyed. Later commits will add logic to drive selection and invalidation appropriately. [1] https://drafts.csswg.org/css-scroll-anchoring/#anchor-node-selection Differential Revision: https://phabricator.services.mozilla.com/D13268

Bug 1506314 - Fix reframing ColumnSetWrapperFrame when it already has column-span children. r=dbaron If a ColumnSetWrapperFrame already has column-span children, ColumnSetWrapperFrame::GetContentInsertionFrame() will return itself to let WipeContainingBlock() aware this is the case to reframe. To make this work, we need to move the reframe condition prior to check NS_FRAME_HAS_MULTI_COLUMN_ANCESTOR bit because the top level ColumnSetWrapperFrame never has NS_FRAME_HAS_MULTI_COLUMN_ANCESTOR bit set. Differential Revision: https://phabricator.services.mozilla.com/D14819

Bug 1507196 - Find first ColumnSetFrame in the child lists of ColumnSetWrapperFrame (and it's continuations). r=dbaron ColumnSetFrame is always created by nsCSSFrameConstructor::BeginBuildingColumns(). We search for it in the possible child lists of ColumnSetWrapperFrame and its continuations. Differential Revision: https://phabricator.services.mozilla.com/D14501

Bug 1511535 - Add a crashtest that sets "column-span:all" to an element under "position:fixed" subtree. r=dbaron The <iframe> in the test case is getting the "column-span:all" style, but it's under a position:fixed frame subtree. After the patch in bug 1507244 landed, NS_FRAME_HAS_MULTI_COLUMN_ANCESTOR won't be added incorrectly to the out-of-flow subtree. Differential Revision: https://phabricator.services.mozilla.com/D14626

Bug 1507244 Part 2 - Suppress column-span descendants under a new block formatting context. r=dbaron Bug 1506163 fixed only part of the issue. There are more types of frames such as table, grid, flex, etc. that create their own block formatting context. Instead of propagating NS_FRAME_HAS_MULTI_COLUMN_ANCESTOR to the children, we explicit carry the bit over to block and inline frames by checking that their parent doesn't suppress column-span descendants. Also, remove the unused "onload" from <body> in the tests. Differential Revision: https://phabricator.services.mozilla.com/D13597