searching for reviewer(chmanchester)
1367114a0633863badba4331e7f1c9ddbd84d1ee: Bug 1580028 - Always merge PGO profile data in the run task; r=firefox-build-system-reviewers,chmanchester
Mike Shal <mshal@mozilla.com> - Tue, 10 Sep 2019 21:56:15 +0000 - rev 492578
Push 114065 by opoprus@mozilla.com at Wed, 11 Sep 2019 03:58:50 +0000
Bug 1580028 - Always merge PGO profile data in the run task; r=firefox-build-system-reviewers,chmanchester If the run task generates bad profile data, the merge step in the profile-use task will fail. However, retrying the profile-use task doesn't fix the problem, and there isn't a straightforward way to retry the run task in this situation. Instead we can add a clang toolchain to all the run tasks, and perform the merge there. This means the output from the run task will always be a successfully merged file called 'merged.profdata', and we no longer need to perform the merge as part of the profile-use build as a GENERATED_FILES step. Depends on D45262 Differential Revision: https://phabricator.services.mozilla.com/D45263
cd30108f1996bb4aa938459a846392ac2dc37908: Bug 1580028 - Move pgo_flags to later in lto-pgo.configure; r=firefox-build-system-reviewers,chmanchester
Mike Shal <mshal@mozilla.com> - Tue, 10 Sep 2019 02:41:06 +0000 - rev 492577
Push 114065 by opoprus@mozilla.com at Wed, 11 Sep 2019 03:58:50 +0000
Bug 1580028 - Move pgo_flags to later in lto-pgo.configure; r=firefox-build-system-reviewers,chmanchester This is needed in the following patch, but the diff is more clear with this split out. Differential Revision: https://phabricator.services.mozilla.com/D45262
4f254e8fe9dc080c942ecd8408be2d2961541cbb: Bug 1575680 - Move node invocations to misc tier; r=firefox-build-system-reviewers,chmanchester
Mike Shal <mshal@mozilla.com> - Mon, 09 Sep 2019 17:44:56 +0000 - rev 492573
Push 114065 by opoprus@mozilla.com at Wed, 11 Sep 2019 03:58:50 +0000
Bug 1575680 - Move node invocations to misc tier; r=firefox-build-system-reviewers,chmanchester These were originally in exports because having it in the same tier as the install rule interacted poorly with VPATH. Now that we no longer have a generic VPATH rule, make can handle the rules properly with everything in misc. Differential Revision: https://phabricator.services.mozilla.com/D42969
1286d4b97efd3623db92b28472707c6fc4496d55: Bug 1579156 - Fix binding tests after bug 1573566. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Tue, 10 Sep 2019 02:55:03 +0000 - rev 492426
Push 114056 by malexandru@mozilla.com at Tue, 10 Sep 2019 10:03:56 +0000
Bug 1579156 - Fix binding tests after bug 1573566. r=chmanchester The build system has no clue that there is something to build in dom/bindings/test. It's currently all handled via make rules generated by the backend, but ideally, this would all be handled by the frontend emitting appropriate GeneratedFiles and Sources objects. In the meanwhile, we just force the make backend to recurse through dom/bindings/test. Differential Revision: https://phabricator.services.mozilla.com/D45124
63eed8246c0669537a5bde2c25a3e9228ed3445a: Bug 1572236: Support sccache in Google Storage r=chmanchester,dustin
Wander Lairson Costa <wander.lairson@gmail.com> - Mon, 09 Sep 2019 16:51:42 +0000 - rev 492377
Push 114055 by rgurzau@mozilla.com at Tue, 10 Sep 2019 03:33:46 +0000
Bug 1572236: Support sccache in Google Storage r=chmanchester,dustin With the migration from AWS to GCP, we also need to migrate sccache buckets from S3 to Google Storage. The problem is how we deal with regions, since there isn't an exact correspondence on the region names between the two cloud providers. To make the transition smoother, docker-worker (and soon generic-worker) provides a new environment variable called TASKCLUSTER_WORKER_LOCATION, with information about the cloud provider the task is running on. Using this new variable, we configure sccache to use the corresponding storage service of the cloud provider where the task runs. The bucket names in Google Storage are shorter because GCS imposes a limit of 30 characteres for the names. Ref: https://github.com/taskcluster/taskcluster-rfcs/pull/148/files Differential Revision: https://phabricator.services.mozilla.com/D44845
749e0b246c06988a8081f622d6fea13dec9acf2b: Bug 1577411 - Don't build breakpad host tools on Windows host when building GeckoView. r=firefox-build-system-reviewers,chmanchester
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Wed, 04 Sep 2019 17:58:35 +0000 - rev 492316
Push 114051 by rgurzau@mozilla.com at Mon, 09 Sep 2019 21:51:12 +0000
Bug 1577411 - Don't build breakpad host tools on Windows host when building GeckoView. r=firefox-build-system-reviewers,chmanchester Bug 1558372 allows to build crash reporter for Android even if host isn't Linux. But when using Windows host, it is still broken. Host libraries and tools in `toolkit/crashreporter/google-breakpad/src/common` is only for Linux host and macOS host. So if using Windows host, it isn't buildable. So I would like to exclude this if host is windows. Also, `toolkit/crashreporter/google-breakpad/src/tools/linux/dump_syms` is only for Linux host. Differential Revision: https://phabricator.services.mozilla.com/D43923
38cfc033a3a8e811816d10eee8693b46a5c9269c: Bug 1579131 - Enable Leanplum/MMA in Android aarch64 builds. r=chmanchester
Nick Alexander <nalexander@mozilla.com> - Thu, 05 Sep 2019 18:08:30 +0000 - rev 491897
Push 114036 by nerli@mozilla.com at Fri, 06 Sep 2019 09:46:47 +0000
Bug 1579131 - Enable Leanplum/MMA in Android aarch64 builds. r=chmanchester This is not the minimal patch for this issue. The minimal patch is a one-liner that adds `MOZ_ANDORID_MMA=1` to mobile/android/config/mozconfigs/android-aarch64/nightly. However, the underlying issue is that the mozconfigs have not stayed internally consistent. To reduce the likelihood of a repeat of this inconsistency, it would be best to extract the shared flags and reduce duplication and the risk for inconsistent updates. There's two ways to do that: teach `moz.configure` to have the correct defaults or share some small stanza across mozconfigs. The former is non-trivial and not worth the risk at this time. The latter is trivial but more effort than this is worth. Here's something in the middle: making all the mozconfigs have minimal differences with the mainline mozconfig for `android-api-16`. This at least allows easy auditing of the mozconfigs with `diff`. Differential Revision: https://phabricator.services.mozilla.com/D44865
d2bdeab3b280bd01bbcef4279ba2d05895e82cfd: Bug 1534533 - Add geckodriver toolchain tasks. r=chmanchester
Nick Alexander <nalexander@mozilla.com> - Wed, 28 Aug 2019 20:54:06 +0000 - rev 490499
Push 113995 by ccoroiu@mozilla.com at Thu, 29 Aug 2019 04:13:32 +0000
Bug 1534533 - Add geckodriver toolchain tasks. r=chmanchester There was quite a bit of discussion of this in `#build` on IRC, and the consensus was that geckodriver should be built as a stand-alone Rust crate and not as part of Firefox/Gecko (say, as a new --enable-project target). This follows that approach, and the expression, modeled off of cbindgen but updated to cross compile from a Linux host to all targets, is pretty straight-forward. A sparse profile would be nice, but the way that the Gecko Cargo workspace works means that the profile must accumulate Rust code from many locations. If we want to, eventually testing/geckodriver can be removed from the top-level Rust workspace, the geckodriver-signing tasks migrated to these toolchain tasks, consumers migrated to the signing tasks, and geckodriver removed from the "common" test archive. Differential Revision: https://phabricator.services.mozilla.com/D43646
ded4116115e840093904991347a4aca03c9b0a9b: Bug 1534533 - Pre: Remove bzip2 dependency from geckodriver. r=chmanchester,whimboo
Nick Alexander <nalexander@mozilla.com> - Wed, 28 Aug 2019 20:53:16 +0000 - rev 490498
Push 113995 by ccoroiu@mozilla.com at Thu, 29 Aug 2019 04:13:32 +0000
Bug 1534533 - Pre: Remove bzip2 dependency from geckodriver. r=chmanchester,whimboo The `zip` dependency doesn't appear to require `bzip2`, and `bzip2` is tricky to cross-compile, so the feature set is restricted to ease the build task. Differential Revision: https://phabricator.services.mozilla.com/D43645
17bb41227a5ad6e14eda7f3f3fff5b70365f9b6c: Bug 1577046 - Tie extra-bindgen-flags file creation to cranelift. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Tue, 27 Aug 2019 23:19:17 +0000 - rev 490339
Push 113989 by btara@mozilla.com at Wed, 28 Aug 2019 09:49:25 +0000
Bug 1577046 - Tie extra-bindgen-flags file creation to cranelift. r=chmanchester We only recurse into js/src/rust when jsrust is built, which it may not be in Gecko builds. But cranelift, which may be enabled either way, needs the extra-bindgen-flags file. Differential Revision: https://phabricator.services.mozilla.com/D43699
56248ad240922ef2c7bca41eda522a0bf374be28: Bug 1575804 - Don't decode the result from get_cmd_output. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Mon, 26 Aug 2019 22:05:51 +0000 - rev 490117
Push 113979 by csabou@mozilla.com at Tue, 27 Aug 2019 09:55:53 +0000
Bug 1575804 - Don't decode the result from get_cmd_output. r=chmanchester Also don't pass universal_newlines to check_cmd_output. That was added to make python 3 happier when check_cmd_output still returned bytes, to hint subprocess to return a unicode string, but now that check_cmd_output does the decoding, that's not needed anymore. Differential Revision: https://phabricator.services.mozilla.com/D43205
9e0c871919f09f693a7f148bc23ac066c6446a2e: Bug 1575760 - Generate .cargo/config as part of the build rather than as a configure subst file. r=firefox-build-system-reviewers,chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Thu, 22 Aug 2019 21:27:24 +0000 - rev 490114
Push 113979 by csabou@mozilla.com at Tue, 27 Aug 2019 09:55:53 +0000
Bug 1575760 - Generate .cargo/config as part of the build rather than as a configure subst file. r=firefox-build-system-reviewers,chmanchester We'll require preprocessing that configure subst files don't allow in the next change, so prepare for that. Differential Revision: https://phabricator.services.mozilla.com/D43011
f266a7b397c1195d05fc1802e3be1c2eef71c427: Bug 1562686 - use AWS_IAM_CREDENTIALS_URL for all S3 sccache invocations r=chmanchester
Dustin J. Mitchell <dustin@mozilla.com> - Fri, 23 Aug 2019 12:39:25 +0000 - rev 489637
Push 113958 by dvarga@mozilla.com at Fri, 23 Aug 2019 21:54:58 +0000
Bug 1562686 - use AWS_IAM_CREDENTIALS_URL for all S3 sccache invocations r=chmanchester Differential Revision: https://phabricator.services.mozilla.com/D41454
ccd4c2bcbd7a44a78cec78c6ddfd1a74dc6efce9: Bug 1574056 - Make `mach vendor rust` use now native `cargo vendor`. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Thu, 22 Aug 2019 21:46:40 +0000 - rev 489504
Push 113949 by ncsoregi@mozilla.com at Fri, 23 Aug 2019 09:59:00 +0000
Bug 1574056 - Make `mach vendor rust` use now native `cargo vendor`. r=chmanchester Note that cargo vendor always uses the native version even when cargo-vendor was already installed, so there is no concern wrt that. Differential Revision: https://phabricator.services.mozilla.com/D43007
36d42617dfd2bb6908009998ec2813c411fa1778: Bug 1560700 - Remove now unused allow_unknown argument to split_triplet. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Tue, 13 Aug 2019 22:30:38 +0000 - rev 489317
Push 113942 by aciure@mozilla.com at Thu, 22 Aug 2019 04:06:52 +0000
Bug 1560700 - Remove now unused allow_unknown argument to split_triplet. r=chmanchester Differential Revision: https://phabricator.services.mozilla.com/D41482
fe7b9445e1d342a1031251fb0ff5ee092d729706: Bug 1562686 - use AWS_IAM_CREDENTIALS_URL for all S3 sccache invocations r=chmanchester
Dustin J. Mitchell <dustin@mozilla.com> - Tue, 20 Aug 2019 14:03:12 +0000 - rev 489185
Push 113941 by aciure@mozilla.com at Wed, 21 Aug 2019 21:59:00 +0000
Bug 1562686 - use AWS_IAM_CREDENTIALS_URL for all S3 sccache invocations r=chmanchester Differential Revision: https://phabricator.services.mozilla.com/D41454
e4eb5e085f39229c979cceebf6a8219bb442344e: Bug 1550146 - Part 1: Do less (no mozharness.zip) in local `mach package`. r=chmanchester
Nick Alexander <nalexander@mozilla.com> - Wed, 21 Aug 2019 03:22:14 +0000 - rev 489111
Push 113940 by dvarga@mozilla.com at Wed, 21 Aug 2019 16:57:53 +0000
Bug 1550146 - Part 1: Do less (no mozharness.zip) in local `mach package`. r=chmanchester Differential Revision: https://phabricator.services.mozilla.com/D41449
91eca815c9fc0b5f8a5445a5345ad5ea0d834bc6: Bug 1562686 - use AWS_IAM_CREDENTIALS_URL for all S3 sccache invocations r=chmanchester
Dustin J. Mitchell <dustin@mozilla.com> - Fri, 16 Aug 2019 17:17:02 +0000 - rev 488588
Push 113914 by nbeleuzu@mozilla.com at Sat, 17 Aug 2019 21:54:15 +0000
Bug 1562686 - use AWS_IAM_CREDENTIALS_URL for all S3 sccache invocations r=chmanchester Differential Revision: https://phabricator.services.mozilla.com/D41454
4da1734351e65e6c1fdf045505097df653aa38be: bug 1540655: mozbuild: add puppeteer test flavor; r=firefox-build-system-reviewers,chmanchester
Andreas Tolfsen <ato@sny.no> - Fri, 16 Aug 2019 12:58:19 +0000 - rev 488526
Push 113910 by ccoroiu@mozilla.com at Fri, 16 Aug 2019 16:28:54 +0000
bug 1540655: mozbuild: add puppeteer test flavor; r=firefox-build-system-reviewers,chmanchester The Puppeteer test flavour are functional tests for the CDP-based Puppeteer library from Google, that we want to run against our implementation of CDP for Firefox. They are distinct from the Firefox Puppeteer tests based on Marionette. Differential Revision: https://phabricator.services.mozilla.com/D37012
8f22cff02e356e5f64aac10aa1edc334f251e107: bug 1540655: build, remote: add mach command for vendoring Puppeteer; r=firefox-build-system-reviewers,chmanchester
Andreas Tolfsen <ato@sny.no> - Fri, 16 Aug 2019 12:58:06 +0000 - rev 488522
Push 113910 by ccoroiu@mozilla.com at Fri, 16 Aug 2019 16:28:54 +0000
bug 1540655: build, remote: add mach command for vendoring Puppeteer; r=firefox-build-system-reviewers,chmanchester Introduces "./mach remote vendor-puppeteer" for vendoring the Puppeteer client without dependencies into remote/test/puppeteer/. The particular checkout of Puppeteer is https://github.com/andreastt/puppeteer/tree/firefox, which contains a couple of hotfixes we need for the client to work with the Firefox implementation of CDP. The remote agent targets a specific version of Puppeteer, so it is not suitable for this to be vendored under third_party/. We also wouldn't want other code in central to accidentally use a patched fork. The vendoring process is not part of "./mach vendor" because it does not yet have Node.js support, and implementing that for mach is outside the scope of getting the Puppeteer tests running with the remote agent. Differential Revision: https://phabricator.services.mozilla.com/D37007
c02aa182735b12c584d7e9eff3a366d6e28c73e3: Bug 1570411 - Add --without-fennec to make `mach package` not produce Fennec APK. r=chmanchester
Nick Alexander <nalexander@mozilla.com> - Wed, 14 Aug 2019 20:40:00 +0000 - rev 488126
Push 113900 by cbrindusan@mozilla.com at Thu, 15 Aug 2019 09:53:50 +0000
Bug 1570411 - Add --without-fennec to make `mach package` not produce Fennec APK. r=chmanchester When working on GeckoView, there's no need to produce a Fennec APK. This commit avoids doing that work at `mach package` time. There are many other things we'd like to stop doing as we remove Fennec from the tree, so we add a general flag to guard such things. Depends on D41447 Differential Revision: https://phabricator.services.mozilla.com/D41448
8c67b494e207a626fd6638ad9de3b01ad61c66e2: bug 1540655: mozbuild: add puppeteer test flavor; r=firefox-build-system-reviewers,chmanchester
Andreas Tolfsen <ato@sny.no> - Wed, 14 Aug 2019 14:58:04 +0000 - rev 487948
Push 113895 by btara@mozilla.com at Wed, 14 Aug 2019 22:08:04 +0000
bug 1540655: mozbuild: add puppeteer test flavor; r=firefox-build-system-reviewers,chmanchester The Puppeteer test flavour are functional tests for the CDP-based Puppeteer library from Google, that we want to run against our implementation of CDP for Firefox. They are distinct from the Firefox Puppeteer tests based on Marionette. Differential Revision: https://phabricator.services.mozilla.com/D37012
b96dede008ada64edc0ba61c96335c5f08afc23a: bug 1540655: build, remote: add mach command for vendoring Puppeteer; r=firefox-build-system-reviewers,chmanchester
Andreas Tolfsen <ato@sny.no> - Wed, 14 Aug 2019 14:57:51 +0000 - rev 487944
Push 113895 by btara@mozilla.com at Wed, 14 Aug 2019 22:08:04 +0000
bug 1540655: build, remote: add mach command for vendoring Puppeteer; r=firefox-build-system-reviewers,chmanchester Introduces "./mach remote vendor-puppeteer" for vendoring the Puppeteer client without dependencies into remote/test/puppeteer/. The particular checkout of Puppeteer is https://github.com/andreastt/puppeteer/tree/firefox, which contains a couple of hotfixes we need for the client to work with the Firefox implementation of CDP. The remote agent targets a specific version of Puppeteer, so it is not suitable for this to be vendored under third_party/. We also wouldn't want other code in central to accidentally use a patched fork. The vendoring process is not part of "./mach vendor" because it does not yet have Node.js support, and implementing that for mach is outside the scope of getting the Puppeteer tests running with the remote agent. Differential Revision: https://phabricator.services.mozilla.com/D37007
a2bb68055aa638a2625f238b3d2994d994dad2ea: Bug 1569887 - Use a fetch task artifact to get llvm-dsymutil source. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Tue, 30 Jul 2019 21:10:09 +0000 - rev 485509
Push 113807 by malexandru@mozilla.com at Wed, 31 Jul 2019 09:58:15 +0000
Bug 1569887 - Use a fetch task artifact to get llvm-dsymutil source. r=chmanchester Differential Revision: https://phabricator.services.mozilla.com/D39848
04d91a1c7fbf8cfa4b5dc63490dbe62206f9b95c: Bug 1569075 - Rename FileAvoidWrite mode argument. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Tue, 30 Jul 2019 21:03:12 +0000 - rev 485505
Push 113807 by malexandru@mozilla.com at Wed, 31 Jul 2019 09:58:15 +0000
Bug 1569075 - Rename FileAvoidWrite mode argument. r=chmanchester It causes confusion because it's the mode used to _read_ the overwritten file. Make that more obvious by renaming to `readmode`. Differential Revision: https://phabricator.services.mozilla.com/D39445
87a78f2858b6ae791b3118ea9c0fa0d557d788ca: Bug 1561146 - Enable PGO for Windows aarch64 builds; r=firefox-build-system-reviewers,chmanchester
Mike Shal <mshal@mozilla.com> - Tue, 23 Jul 2019 23:42:47 +0000 - rev 483940
Push 113759 by malexandru@mozilla.com at Wed, 24 Jul 2019 09:58:20 +0000
Bug 1561146 - Enable PGO for Windows aarch64 builds; r=firefox-build-system-reviewers,chmanchester This build re-uses the PGO profile from the win64 build in the win64-aarch64-shippable-no-eme part of the aarch64 build. Even though the profile isn't generated on the smae platform, we still get enough of a performance win to make this worthwhile. Note that the pgo_flags() in configure need to be tweaked slightly since we don't supprt the -fprofile-generate flag for aarch64 (we don't build the clang_rt.profile lib there). So we always want to return the flags namespace to make sure we get the use_* versions of flags, which we do need. Differential Revision: https://phabricator.services.mozilla.com/D38928
f1652ed369104a026b74d778e593f5ec4418aa32: Bug 1561774 - Copy win64-aarch64-opt test artifacts into the shippable build; r=firefox-build-system-reviewers,chmanchester
Mike Shal <mshal@mozilla.com> - Wed, 17 Jul 2019 20:38:38 +0000 - rev 483581
Push 113733 by apavel@mozilla.com at Sat, 20 Jul 2019 10:14:36 +0000
Bug 1561774 - Copy win64-aarch64-opt test artifacts into the shippable build; r=firefox-build-system-reviewers,chmanchester In order to run tests against the win64-aarch64-shippable build, we need the test packages from the aarch64-no-eme build since the tests aren't compiled during the -shippable stage. Since packages like cppunittest and the target.test_packages.json file won't be generated correctly in the -shippable stage, we disable the package-step tests there by setting MOZ_AUTOMATION_PACKAGE_TESTS to 0 in the environment. Differential Revision: https://phabricator.services.mozilla.com/D37895
d054815d79717771b9894b85136929ebcc90ef5e: Bug 1566960 - Remove unused Windows stuff from rules.mk r=firefox-build-system-reviewers,chmanchester
Tom Ritter <tom@mozilla.com> - Wed, 17 Jul 2019 22:17:02 +0000 - rev 483325
Push 113717 by opoprus@mozilla.com at Thu, 18 Jul 2019 22:06:59 +0000
Bug 1566960 - Remove unused Windows stuff from rules.mk r=firefox-build-system-reviewers,chmanchester Differential Revision: https://phabricator.services.mozilla.com/D38396
bc97fe6dbaa2b29a6da418934abe9d2d8f9424bd: Bug 1566687 - Use mac-cross clang for all macosx builds. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Wed, 17 Jul 2019 21:49:16 +0000 - rev 483192
Push 113708 by aciure@mozilla.com at Thu, 18 Jul 2019 03:50:35 +0000
Bug 1566687 - Use mac-cross clang for all macosx builds. r=chmanchester We've been lucky that non-sanitizer cross-builds for macosx have not required the clang runtime so far, but they soon will. And it's only available in the mac-cross clang toolchain, so we need to use that on all macosx builds. Differential Revision: https://phabricator.services.mozilla.com/D38260
39b9c735cbaad07544f2419b6ecf5df6b6b5fc37: Bug 1564909 - Test binaries do not need to manually include libatomic. r=chmanchester
Ted Campbell <tcampbell@mozilla.com> - Wed, 17 Jul 2019 19:04:03 +0000 - rev 483170
Push 113708 by aciure@mozilla.com at Thu, 18 Jul 2019 03:50:35 +0000
Bug 1564909 - Test binaries do not need to manually include libatomic. r=chmanchester These configurations are already taken care of in js/src/build/moz.build and do not need to duplicated. Depends on D37567 Differential Revision: https://phabricator.services.mozilla.com/D37568
6f5ee39ab5c66db919bcf36f83f5c028f9ea6a72: Bug 1564909 - Add js-standalone.mozbuild. r=bbouvier,chmanchester
Ted Campbell <tcampbell@mozilla.com> - Wed, 17 Jul 2019 19:09:45 +0000 - rev 483169
Push 113708 by aciure@mozilla.com at Thu, 18 Jul 2019 03:50:35 +0000
Bug 1564909 - Add js-standalone.mozbuild. r=bbouvier,chmanchester Consolidate build settings required by standalone builds into a single mozbuild script. A full Gecko build does not use these settings and thus we cannot simply put them in js/src/build/moz.build Differential Revision: https://phabricator.services.mozilla.com/D37567
dd1bb21a227127142713e46d9c9ff5f51207118b: Bug 1473498 - [mach] Fix Py3 compatibility issues in telemetry.py r=firefox-build-system-reviewers,chmanchester
Andrew Halberstadt <ahalberstadt@mozilla.com> - Tue, 16 Jul 2019 20:53:18 +0000 - rev 483113
Push 113708 by aciure@mozilla.com at Thu, 18 Jul 2019 03:50:35 +0000
Bug 1473498 - [mach] Fix Py3 compatibility issues in telemetry.py r=firefox-build-system-reviewers,chmanchester Depends on D36104 Differential Revision: https://phabricator.services.mozilla.com/D38193
c4a97f2e3303f9c5353768cff094ede98217eecd: Bug 1473498 - [mach] Fix Python 3 decorator compatibility r=firefox-build-system-reviewers,chmanchester
Andrew Halberstadt <ahalberstadt@mozilla.com> - Tue, 16 Jul 2019 20:42:34 +0000 - rev 483112
Push 113708 by aciure@mozilla.com at Thu, 18 Jul 2019 03:50:35 +0000
Bug 1473498 - [mach] Fix Python 3 decorator compatibility r=firefox-build-system-reviewers,chmanchester Differential Revision: https://phabricator.services.mozilla.com/D36104
5cf39e5f78c969ad3620fdaf6317e5b6c43f939b: Bug 1566309 - Upgrade mac builds to rust 1.36. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Wed, 17 Jul 2019 00:05:11 +0000 - rev 483031
Push 113703 by archaeopteryx@coole-files.de at Wed, 17 Jul 2019 16:57:18 +0000
Bug 1566309 - Upgrade mac builds to rust 1.36. r=chmanchester Differential Revision: https://phabricator.services.mozilla.com/D38156
d332c122652f88ac6a4a911ba0ee7cb91d73508d: Bug 1561774 - Copy win64-aarch64-opt test artifacts into the shippable build; r=firefox-build-system-reviewers,chmanchester
Mike Shal <mshal@mozilla.com> - Tue, 16 Jul 2019 18:47:25 +0000 - rev 483019
Push 113703 by archaeopteryx@coole-files.de at Wed, 17 Jul 2019 16:57:18 +0000
Bug 1561774 - Copy win64-aarch64-opt test artifacts into the shippable build; r=firefox-build-system-reviewers,chmanchester In order to run tests against the win64-aarch64-shippable build, we need the test packages from the aarch64-no-eme build since the tests aren't compiled during the -shippable stage. Since packages like cppunittest and the target.test_packages.json file won't be generated correctly in the -shippable stage, we disable the package-step tests there by setting MOZ_AUTOMATION_PACKAGE_TESTS to 0 in the environment. Differential Revision: https://phabricator.services.mozilla.com/D37895
155d964c8be4afdc5de4a49033b8df1c81c79178: Bug 1561474 - Use sparse-profile on Windows generate tasks; r=firefox-build-system-reviewers,chmanchester
Mike Shal <mshal@mozilla.com> - Mon, 15 Jul 2019 21:47:19 +0000 - rev 482852
Push 113694 by malexandru@mozilla.com at Tue, 16 Jul 2019 04:14:31 +0000
Bug 1561474 - Use sparse-profile on Windows generate tasks; r=firefox-build-system-reviewers,chmanchester Depends on D37807 Differential Revision: https://phabricator.services.mozilla.com/D37808
423da1d755f57c6f0149f6a5f3eb76f3bc5d6e30: Bug 1563797 - Use 'backports.shutil_which' instead of 'which' in the build system r=firefox-build-system-reviewers,chmanchester
Andrew Halberstadt <ahalberstadt@mozilla.com> - Thu, 11 Jul 2019 14:04:39 +0000 - rev 482400
Push 113667 by ncsoregi@mozilla.com at Thu, 11 Jul 2019 23:12:26 +0000
Bug 1563797 - Use 'backports.shutil_which' instead of 'which' in the build system r=firefox-build-system-reviewers,chmanchester Credit: Callek for figuring out an issue in 'make check' making the binary absolute in mozbuild.base. Differential Revision: https://phabricator.services.mozilla.com/D37319
2ad7b1da6d22bb5667ef2ac731eaf751de98ebfc: Bug 1563053 - Wildcard profraw files for Android PGO; r=firefox-build-system-reviewers,chmanchester
Mike Shal <mshal@mozilla.com> - Tue, 09 Jul 2019 19:56:45 +0000 - rev 482240
Push 113654 by aiakab@mozilla.com at Wed, 10 Jul 2019 22:00:37 +0000
Bug 1563053 - Wildcard profraw files for Android PGO; r=firefox-build-system-reviewers,chmanchester This adds support for the Android process writing out multiple profraw files and pulling them all from the device. We currently only generate a single profraw file, but if that changes in the future we should be able to get a PGO build using the full set of files now. Depends on D36840 Differential Revision: https://phabricator.services.mozilla.com/D36841
3b86e1396fd28aaf4704d36ed842d002dca16759: Bug 1563053 - Put all Android PGO outputs in a separate directory; r=firefox-build-system-reviewers,chmanchester
Mike Shal <mshal@mozilla.com> - Tue, 09 Jul 2019 20:13:35 +0000 - rev 482239
Push 113654 by aiakab@mozilla.com at Wed, 10 Jul 2019 22:00:37 +0000
Bug 1563053 - Put all Android PGO outputs in a separate directory; r=firefox-build-system-reviewers,chmanchester If we end up generating multiple profraw files in the future, it will help to have them all in a separate directory so that we can just 'adb pull' the whole directory at once. Depends on D36839 Differential Revision: https://phabricator.services.mozilla.com/D36840
83a66863401bc89e1d20494713555d7464c61c45: Bug 1563158 - Properly handle imply_option dependency loops when `when` is involved. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Tue, 09 Jul 2019 22:04:01 +0000 - rev 482015
Push 113647 by aciure@mozilla.com at Wed, 10 Jul 2019 09:46:39 +0000
Bug 1563158 - Properly handle imply_option dependency loops when `when` is involved. r=chmanchester This is an extension of the relaxation added in bug 1529799. Differential Revision: https://phabricator.services.mozilla.com/D36716
3416303a9b4a7c49272e956f9a83395e4e4ad985: Bug 1473498 - [mach] Enable test_logger with Python 3 r=firefox-build-system-reviewers,chmanchester
Andrew Halberstadt <ahalberstadt@mozilla.com> - Tue, 02 Jul 2019 20:59:46 +0000 - rev 481048
Push 113588 by malexandru@mozilla.com at Wed, 03 Jul 2019 09:51:25 +0000
Bug 1473498 - [mach] Enable test_logger with Python 3 r=firefox-build-system-reviewers,chmanchester Depends on D36101 Differential Revision: https://phabricator.services.mozilla.com/D36102
7123c3146d812a050e52941c008c3b549abcde0c: Bug 1473498 - [mach] Enable test_config with Python 3 r=firefox-build-system-reviewers,chmanchester
Andrew Halberstadt <ahalberstadt@mozilla.com> - Tue, 02 Jul 2019 20:59:03 +0000 - rev 481047
Push 113588 by malexandru@mozilla.com at Wed, 03 Jul 2019 09:51:25 +0000
Bug 1473498 - [mach] Enable test_config with Python 3 r=firefox-build-system-reviewers,chmanchester Depends on D36100 Differential Revision: https://phabricator.services.mozilla.com/D36101
152598dd91a82111b96bbf85e33e787702e19214: Bug 1473498 - [mach] Enable test_entry_points with Python 3 r=firefox-build-system-reviewers,chmanchester
Andrew Halberstadt <ahalberstadt@mozilla.com> - Tue, 02 Jul 2019 20:58:14 +0000 - rev 481046
Push 113588 by malexandru@mozilla.com at Wed, 03 Jul 2019 09:51:25 +0000
Bug 1473498 - [mach] Enable test_entry_points with Python 3 r=firefox-build-system-reviewers,chmanchester Differential Revision: https://phabricator.services.mozilla.com/D36100
54ea59c8c99db1796013ddedc00135f9cd0be7f1: Bug 1473498 - [mach] Enable test_dispatcher with python 3 r=firefox-build-system-reviewers,chmanchester
Andrew Halberstadt <ahalberstadt@mozilla.com> - Tue, 02 Jul 2019 21:27:35 +0000 - rev 481045
Push 113588 by malexandru@mozilla.com at Wed, 03 Jul 2019 09:51:25 +0000
Bug 1473498 - [mach] Enable test_dispatcher with python 3 r=firefox-build-system-reviewers,chmanchester This test is working with minimal effort. Let's get it running to prevent future regressions. Differential Revision: https://phabricator.services.mozilla.com/D36098
5a867f13f12e246e386a7f5050ce1d80e958c5d9: Bug 1560755 - Merge Android PGO profile data in run task; r=firefox-build-system-reviewers,chmanchester
Mike Shal <mshal@mozilla.com> - Tue, 02 Jul 2019 21:51:23 +0000 - rev 481016
Push 113587 by aciure@mozilla.com at Wed, 03 Jul 2019 04:10:52 +0000
Bug 1560755 - Merge Android PGO profile data in run task; r=firefox-build-system-reviewers,chmanchester Android profile runs don't always fully write out the profile data. In this case, the corrupted profile data is successfully uploaded, but future profile-use PGO builds try to merge the data and fail. Retrying the profile-use builds doesn't help, since they all pull from the same job that published the corrupt data. We can detect this in the run task by using llvm-profdata merge, and if the merge fails the task can automatically be retried. Note that the data gets redundantly merged in the profile-use build, but it may not be possible to run the merge in the run task on all platforms (eg: OSX), so we have to keep the merge there as well. Differential Revision: https://phabricator.services.mozilla.com/D36294
fae8c77ea4ad7880b7297c564376b3aaa1a9da93: Bug 1562768 - Enable 3-tier PGO in Linux32 devedition builds; r=firefox-build-system-reviewers,chmanchester
Mike Shal <mshal@mozilla.com> - Tue, 02 Jul 2019 01:13:35 +0000 - rev 480959
Push 113585 by aciure@mozilla.com at Tue, 02 Jul 2019 21:57:44 +0000
Bug 1562768 - Enable 3-tier PGO in Linux32 devedition builds; r=firefox-build-system-reviewers,chmanchester Depends on D36543 Differential Revision: https://phabricator.services.mozilla.com/D36544
3e6f208a59d30ef4028e1b305b85a08aac2fabc9: Bug 1562768 - Remove redundant linux64/devedition mozconfig PGO settings; r=firefox-build-system-reviewers,chmanchester
Mike Shal <mshal@mozilla.com> - Tue, 02 Jul 2019 01:13:21 +0000 - rev 480958
Push 113585 by aciure@mozilla.com at Tue, 02 Jul 2019 21:57:44 +0000
Bug 1562768 - Remove redundant linux64/devedition mozconfig PGO settings; r=firefox-build-system-reviewers,chmanchester Bug 1553065 made this redundant by putting the profile-use mozconfig settings in build/unix/mozconfig.unix. We no longer need them in each leaf mozconfig. Differential Revision: https://phabricator.services.mozilla.com/D36543
9bc355a1aea3bdfdc04bc6c14a657b5e6aa6a972: Bug 1562725 - export UPLOAD_PATH in run-profileserver.sh; r=firefox-build-system-reviewers,chmanchester
Mike Shal <mshal@mozilla.com> - Mon, 01 Jul 2019 20:32:35 +0000 - rev 480875
Push 113579 by dluca@mozilla.com at Tue, 02 Jul 2019 09:47:28 +0000
Bug 1562725 - export UPLOAD_PATH in run-profileserver.sh; r=firefox-build-system-reviewers,chmanchester When adding Windows compatibility in bug 1557785, we stopped exported UPLOAD_PATH by default. UPLOAD_PATH is used by profileserver.py to determine where to store the logs; when it is unset, the logs go to stdout and the artifacts aren't created. We should always export UPLOAD_PATH to get the same logging behavior on all platforms. Differential Revision: https://phabricator.services.mozilla.com/D36521
4cb7eb5b8a428f82b8db1fd60e591a3a06e142b8: Bug 1557762 - ensure we define NS_FREE_PERMANENT_DATA for single-stage pgo builds, r=chmanchester
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Fri, 28 Jun 2019 16:38:14 +0000 - rev 480612
Push 113558 by shindli@mozilla.com at Fri, 28 Jun 2019 23:24:53 +0000
Bug 1557762 - ensure we define NS_FREE_PERMANENT_DATA for single-stage pgo builds, r=chmanchester Differential Revision: https://phabricator.services.mozilla.com/D35469
455dff329fcc9d8fa0647ca662ce5c8451004c87: Bug 1557762 - ensure we define NS_FREE_PERMANENT_DATA for single-stage pgo builds, r=chmanchester
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Thu, 27 Jun 2019 19:53:07 +0000 - rev 480444
Push 113549 by rmaries@mozilla.com at Fri, 28 Jun 2019 03:49:03 +0000
Bug 1557762 - ensure we define NS_FREE_PERMANENT_DATA for single-stage pgo builds, r=chmanchester Differential Revision: https://phabricator.services.mozilla.com/D35469