searching for reviewer(bzbarsky)
c37ca68a24e5a38192a1ef8ccf01c406ccc511ce: Bug 1546736 Part 4 - Only capture web socket stacks for net monitor when the docshell/worker is being watched by the devtools, r=bzbarsky.
Brian Hackett <bhackett1024@gmail.com> - Wed, 08 May 2019 09:31:19 -1000 - rev 474189
Push 113137 by bhackett@mozilla.com at Thu, 16 May 2019 22:59:07 +0000
Bug 1546736 Part 4 - Only capture web socket stacks for net monitor when the docshell/worker is being watched by the devtools, r=bzbarsky.
2e2f3fc37e2eca6e5451c04d395ccf435c3a067c: Bug 1392411 Part 1 - Report stacks to net monitor when creating web sockets, r=bzbarsky.
Brian Hackett <bhackett1024@gmail.com> - Fri, 19 Apr 2019 07:37:08 -1000 - rev 474186
Push 113137 by bhackett@mozilla.com at Thu, 16 May 2019 22:59:07 +0000
Bug 1392411 Part 1 - Report stacks to net monitor when creating web sockets, r=bzbarsky.
134b0641a7aabf9f41a42678d74c497592b0fc49: Bug 1546736 Part 3 - Only capture worker script and XHR stacks for net monitor when devtools are watching the worker, r=bzbarsky.
Brian Hackett <bhackett1024@gmail.com> - Wed, 08 May 2019 09:30:17 -1000 - rev 474092
Push 113129 by bhackett@mozilla.com at Thu, 16 May 2019 17:27:00 +0000
Bug 1546736 Part 3 - Only capture worker script and XHR stacks for net monitor when devtools are watching the worker, r=bzbarsky.
4d7e10772f554bda346bc5f256ea2bbc9f0cd618: Bug 1546736 Part 1 - Keep track of whether docshells and workers are being watched by the devtools, r=bzbarsky.
Brian Hackett <bhackett1024@gmail.com> - Wed, 08 May 2019 09:27:32 -1000 - rev 474090
Push 113129 by bhackett@mozilla.com at Thu, 16 May 2019 17:27:00 +0000
Bug 1546736 Part 1 - Keep track of whether docshells and workers are being watched by the devtools, r=bzbarsky.
181465d74bc486fee79406d4270b2372d5aea1e5: Bug 1392408 Part 4 - Report stacks to net monitor when opening XHRs from worker, r=bzbarsky.
Brian Hackett <bhackett1024@gmail.com> - Thu, 02 May 2019 08:34:49 -1000 - rev 474089
Push 113129 by bhackett@mozilla.com at Thu, 16 May 2019 17:27:00 +0000
Bug 1392408 Part 4 - Report stacks to net monitor when opening XHRs from worker, r=bzbarsky.
51b73cca09ea7dfe1511bede8409dd2260d404aa: Bug 1313741 - Use AppConstants in DOM and XPConnect tests instead of manual detection. r=bzbarsky
Ryan VanderMeulen <ryanvm@gmail.com> - Tue, 14 May 2019 21:01:05 +0000 - rev 473843
Push 113113 by rgurzau@mozilla.com at Wed, 15 May 2019 09:32:06 +0000
Bug 1313741 - Use AppConstants in DOM and XPConnect tests instead of manual detection. r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D30973
2d94f58711b3c1b501d72ed05845198fc3aeb6e8: Bug 1547892 - Load video element in VideoDocument slightly later during load. r=bzbarsky
Chris Pearce <cpearce@mozilla.com> - Tue, 14 May 2019 04:27:49 +0000 - rev 473730
Push 113104 by aiakab@mozilla.com at Tue, 14 May 2019 09:49:04 +0000
Bug 1547892 - Load video element in VideoDocument slightly later during load. r=bzbarsky Currently when we create the video inside a VideoDocument, the PresShell isn't created yet. This means the video element can't access information about the compositor, which means it doesn't know whether it can create a hardware accelerated video decoder, and so we end up falling back to using a software decoder. So this patch moves the creation of the video element to slightly later in the load of a VideoDocument, so that the PresShell is available when we create the VideoDocument's video element. This means VideoDocuments's video decoder can be hardware accelerated Differential Revision: https://phabricator.services.mozilla.com/D30614
292fec00f80015bbfabdf07c15a3b35184b8b1c0: Bug 1550590 - nsIScriptChannel isn't used by script. r=bzbarsky
Andrew McCreight <continuation@gmail.com> - Fri, 10 May 2019 04:32:24 +0000 - rev 473438
Push 113082 by dvarga@mozilla.com at Fri, 10 May 2019 21:54:38 +0000
Bug 1550590 - nsIScriptChannel isn't used by script. r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D30606
a93ed2a80220b9ba15fb9b59ea79b5f1ee8f7693: Bug 1545823 - Implement non-standard CSSStyleSheet.rules, CSSStyleSheet.addRule and CSSStyleSheet.removeRule. r=bzbarsky
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 09 May 2019 12:32:52 +0000 - rev 473203
Push 113068 by nerli@mozilla.com at Thu, 09 May 2019 15:38:15 +0000
Bug 1545823 - Implement non-standard CSSStyleSheet.rules, CSSStyleSheet.addRule and CSSStyleSheet.removeRule. r=bzbarsky It's not worth dying on this hill. Both Blink and WebKit pass the tests. (Well, WebKit actually fails one of the latest ones I wrote, cssRules and rules are not the same JS object, WebKit returns a new rule list. I'll file) Spec PR in https://github.com/w3c/csswg-drafts/pull/3900. Differential Revision: https://phabricator.services.mozilla.com/D30348
fdff2d33f119d6ea14594af60846df80c76506d2: Bug 1392408 Part 3 - Report stacks to net monitor when loading worker scripts, r=bzbarsky.
Brian Hackett <bhackett1024@gmail.com> - Thu, 02 May 2019 08:34:27 -1000 - rev 472668
Push 113036 by bhackett@mozilla.com at Mon, 06 May 2019 15:23:38 +0000
Bug 1392408 Part 3 - Report stacks to net monitor when loading worker scripts, r=bzbarsky.
7cebca65fa314ed2de10a68badf691563d3b2e58: Bug 1392408 Part 2 - Encapsulate threadsafe main/worker stacks in WorkerStackHolder, r=bzbarsky.
Brian Hackett <bhackett1024@gmail.com> - Thu, 02 May 2019 08:25:43 -1000 - rev 472667
Push 113036 by bhackett@mozilla.com at Mon, 06 May 2019 15:23:38 +0000
Bug 1392408 Part 2 - Encapsulate threadsafe main/worker stacks in WorkerStackHolder, r=bzbarsky.
a08af741bd23f9837b6dc6aa74829fbe933568e4: Bug 1548773: Remove support for typemustmatch r=bzbarsky
Frederik Braun <fbraun@mozilla.com> - Sun, 05 May 2019 14:41:59 +0000 - rev 472642
Push 113030 by ccoroiu@mozilla.com at Mon, 06 May 2019 04:28:40 +0000
Bug 1548773: Remove support for typemustmatch r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D29803
49a573cb12dbf46b578966b93e0d878d73c9b73f: Bug 1548449 - Don't render stuff in plaintext documents without a viewport. r=bzbarsky
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 02 May 2019 19:55:41 +0000 - rev 472369
Push 113004 by rgurzau@mozilla.com at Fri, 03 May 2019 04:25:36 +0000
Bug 1548449 - Don't render stuff in plaintext documents without a viewport. r=bzbarsky I'm still wondering why is bing.com doing this but oh well. This should address the regression and probably even improve it. I don't think these documents are observable from content (at least I haven't found how) so this should be safe. Let me know if you want me to just wrap the whole stylesheet in an `@media (width > 0) and (height > 0)` rule or such. Differential Revision: https://phabricator.services.mozilla.com/D29640
9c3b9f800a0ce8207d7716582206a2a4b2fe67e5: Bug 1392408 Part 4 - Report stacks to net monitor when opening XHRs from worker, r=bzbarsky.
Brian Hackett <bhackett1024@gmail.com> - Thu, 02 May 2019 08:34:49 -1000 - rev 472323
Push 113003 by bhackett@mozilla.com at Fri, 03 May 2019 01:22:02 +0000
Bug 1392408 Part 4 - Report stacks to net monitor when opening XHRs from worker, r=bzbarsky.
2a64ecfab240530e811d8123dcb1f0276716b0f8: Bug 1392408 Part 3 - Report stacks to net monitor when loading worker scripts, r=bzbarsky.
Brian Hackett <bhackett1024@gmail.com> - Thu, 02 May 2019 08:34:27 -1000 - rev 472322
Push 113003 by bhackett@mozilla.com at Fri, 03 May 2019 01:22:02 +0000
Bug 1392408 Part 3 - Report stacks to net monitor when loading worker scripts, r=bzbarsky.
b765eaf69bcb947cedacfefd424a43fa403f0aa4: Bug 1392408 Part 2 - Encapsulate threadsafe main/worker stacks in WorkerStackHolder, r=bzbarsky.
Brian Hackett <bhackett1024@gmail.com> - Thu, 02 May 2019 08:25:43 -1000 - rev 472321
Push 113003 by bhackett@mozilla.com at Fri, 03 May 2019 01:22:02 +0000
Bug 1392408 Part 2 - Encapsulate threadsafe main/worker stacks in WorkerStackHolder, r=bzbarsky.
cd9081aac4bff641d2020f3ac884ec3d1d63b9a2: Bug 1392408 Part 4 - Report stacks to net monitor when opening XHRs from worker, r=bzbarsky.
Brian Hackett <bhackett1024@gmail.com> - Fri, 19 Apr 2019 07:20:13 -1000 - rev 472290
Push 112990 by bhackett@mozilla.com at Thu, 02 May 2019 16:29:50 +0000
Bug 1392408 Part 4 - Report stacks to net monitor when opening XHRs from worker, r=bzbarsky.
d88d5959f4a6b92219874bf2cb4bc7a4d61488c8: Bug 1392408 Part 3 - Report stacks to net monitor when loading worker scripts, r=bzbarsky.
Brian Hackett <bhackett1024@gmail.com> - Fri, 19 Apr 2019 07:19:38 -1000 - rev 472289
Push 112990 by bhackett@mozilla.com at Thu, 02 May 2019 16:29:50 +0000
Bug 1392408 Part 3 - Report stacks to net monitor when loading worker scripts, r=bzbarsky.
01fd757e335ba59e1efa5e9dd39e6e6f68cfc840: Bug 1392408 Part 2 - Encapsulate threadsafe main/worker stacks in WorkerStackHolder, r=bzbarsky.
Brian Hackett <bhackett1024@gmail.com> - Fri, 19 Apr 2019 07:18:38 -1000 - rev 472288
Push 112990 by bhackett@mozilla.com at Thu, 02 May 2019 16:29:50 +0000
Bug 1392408 Part 2 - Encapsulate threadsafe main/worker stacks in WorkerStackHolder, r=bzbarsky.
64c7dcfa24aea95f09ac9430cc40a594e02f6c0a: Bug 1548026 - Noop download button's changed callback when unloaded. r=bzbarsky
Brendan Dahl <bdahl@mozilla.com> - Tue, 30 Apr 2019 20:29:00 +0000 - rev 472057
Push 112974 by ccoroiu@mozilla.com at Wed, 01 May 2019 04:27:55 +0000
Bug 1548026 - Noop download button's changed callback when unloaded. r=bzbarsky Temporary workaround to prevent wrapper assertions in torn-down window. Differential Revision: https://phabricator.services.mozilla.com/D29410
5df5f0db2284956f3afe587cc931d471051d8700: Bug 1514655 - Always wrap plain text documents. r=bzbarsky
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 30 Apr 2019 19:41:40 +0000 - rev 472051
Push 112974 by ccoroiu@mozilla.com at Wed, 01 May 2019 04:27:55 +0000
Bug 1514655 - Always wrap plain text documents. r=bzbarsky This matches other UAs. Differential Revision: https://phabricator.services.mozilla.com/D14848
cec93c8315e9f80cdc187dc967e9758634a59c4c: Bug 1335740 - getUserMedia() Add 2 prefs to control A) NotAllowedError in http (pref'd on), and B) [SecureContext] navigator.mediaDevices (pref'd off) r=bzbarsky,pehrsons
Jan-Ivar Bruaroey <jib@mozilla.com> - Tue, 30 Apr 2019 15:20:59 +0000 - rev 471996
Push 112971 by ccoroiu@mozilla.com at Tue, 30 Apr 2019 21:59:18 +0000
Bug 1335740 - getUserMedia() Add 2 prefs to control A) NotAllowedError in http (pref'd on), and B) [SecureContext] navigator.mediaDevices (pref'd off) r=bzbarsky,pehrsons Differential Revision: https://phabricator.services.mozilla.com/D19549
5159ad4a890bf2e2fd94972d798ac9e22f929168: Bug 1536154 - Update JS_updateMallocCounter callers to use the new API r=bzbarsky
Jon Coppeard <jcoppeard@mozilla.com> - Wed, 24 Apr 2019 15:58:42 +0100 - rev 471906
Push 112962 by jcoppeard@mozilla.com at Tue, 30 Apr 2019 15:28:48 +0000
Bug 1536154 - Update JS_updateMallocCounter callers to use the new API r=bzbarsky This updates existing callers to use the new JS::AddAssociatedMemory API and adds calls to RemoveAssociatedMemory in finalizers. The associated memory doesn't need to be exact, so some simplifiations are made, e.g. in CanvasRenderingContext2D where we don't wait for memory to be allocated but update the number of bytes when the dimensions change, and for stream blobs where the value returned by SizeOfIncludingThis changes over the lifetime of the object. Differential Revision: https://phabricator.services.mozilla.com/D28692
b6ca67e7684f4f9409b8e22e0b52afa8e1de2dab: Bug 1536154 - Eagerly run finalizer for any dead reflector JSObject when creating a new reflector for a DOM native r=bzbarsky
Jon Coppeard <jcoppeard@mozilla.com> - Wed, 24 Apr 2019 15:58:39 +0100 - rev 471905
Push 112962 by jcoppeard@mozilla.com at Tue, 30 Apr 2019 15:28:48 +0000
Bug 1536154 - Eagerly run finalizer for any dead reflector JSObject when creating a new reflector for a DOM native r=bzbarsky Currently incremental GC can run the finalizer for a dead reflector for a native after a new reflector for that native has been created and attached. This leads to the confusing situation where there are two reflectors that contain pointers to the same native (which has a pointer to the new one). This is a problem for memory accounting because the JS engine sees the size of the native at finalization time but does not see updates to this size after a new reflector is created. Thus the engine's idea of the size of a native can become incorrect and the memory accounting can become unbalanced. Consider the following situation: 1. Native object created of size 20MB 2. Reflector 1 created 3. Reflector 1 becomes unreachable 4. Reflector 2 created 5. Native size changes to 40MB 6. Reflector 1 finalized The memory associated with reflector 1 will be: 20MB (step 2), -20MB (step 6) The memory associated with reflector 2 will be: 20MB (step 4), 40MB (step 5) The memory associated with reflector 1 ends up negative (which should not be possible) and the total is also wrong. The patch runs the finalizer for any dead reflector when creating a new one. This ensures that finalizer sees the correct state. The native object pointer is cleared when this happens so when the GC later runs the finalizer again it is a no-op. This situation occurs pretty rarely so I don't think there is much overhead to running the finalizer more than once. This also allows us to tighten up the assertions in the finalizer. Differential Revision: https://phabricator.services.mozilla.com/D28690
5b4e6fb7da207e42d34df45c76159167e85b00b2: Bug 1522817 - Expose possibly-gray global object before passing it into the JS API in Document::AdoptNode r=bzbarsky
Jon Coppeard <jcoppeard@mozilla.com> - Mon, 29 Apr 2019 16:06:08 +0100 - rev 471862
Push 112957 by jcoppeard@mozilla.com at Tue, 30 Apr 2019 08:56:35 +0000
Bug 1522817 - Expose possibly-gray global object before passing it into the JS API in Document::AdoptNode r=bzbarsky Currently Document::AdoptNode gets the JS global object, but in a way that does not expose it first, so it's possible for this to pass a gray object in here. From the comments it seems like this doesn't matter, but it does break our invariant that no gray objects are passed into the API. Differential Revision: https://phabricator.services.mozilla.com/D29210
87f038262ac3d4431a569c1fad9bee5668a332de: Bug 1440537 - Don't propagate flushes across docgroup boundaries. r=bzbarsky
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 19 Apr 2019 19:04:35 +0200 - rev 471799
Push 112953 by shindli@mozilla.com at Tue, 30 Apr 2019 04:15:04 +0000
Bug 1440537 - Don't propagate flushes across docgroup boundaries. r=bzbarsky We don't need to flush layout in the parent document if the parent and child documents can't observe each other. This will also match our behavior in a Fission world. I'm not attached to the name of the function, better ideas welcome. Differential Revision: https://phabricator.services.mozilla.com/D28217
f6766ba4ac77c6757c4e4db7598a2e685f23fcf6: Bug 1440537 - SwapFrameLoaders should flush frames. r=bzbarsky
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 29 Apr 2019 18:45:03 +0000 - rev 471789
Push 112948 by shindli@mozilla.com at Mon, 29 Apr 2019 21:58:23 +0000
Bug 1440537 - SwapFrameLoaders should flush frames. r=bzbarsky swapFrameLoaders relies on frame information, but doesn't ensure it's up-to-date. The test for this (test_swapFrameLoaders.xul) is relying right now on one of flushes from the inner documents to also flush the parent document and thus ensure there's a frame created. With the patch for this bug, that flush no longer propagates to the parent document, and the test fails because we throw in: https://searchfox.org/mozilla-central/rev/66086345467c69685434dd1c5177b30a7511b1a5/dom/base/nsFrameLoader.cpp#1634 This API could probably be made to work without that requirement, but it's probably not worth it. For now just flush. Differential Revision: https://phabricator.services.mozilla.com/D29160
f7c39167006152340a7347a16c349bb54a8d1711: Bug 1440537 - Don't propagate flushes across docgroup boundaries. r=bzbarsky
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 19 Apr 2019 19:04:35 +0200 - rev 471656
Push 112933 by rmaries@mozilla.com at Sat, 27 Apr 2019 21:51:53 +0000
Bug 1440537 - Don't propagate flushes across docgroup boundaries. r=bzbarsky We don't need to flush layout in the parent document if the parent and child documents can't observe each other. This will also match our behavior in a Fission world. I'm not attached to the name of the function, better ideas welcome. Differential Revision: https://phabricator.services.mozilla.com/D28217
5b63c5b38dcc382a4fa0afdbbf67b147057c4fac: Bug 1440537 - Fix a cross-origin navigation test to navigate reliably. r=bzbarsky
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 25 Apr 2019 22:36:39 +0200 - rev 471653
Push 112933 by rmaries@mozilla.com at Sat, 27 Apr 2019 21:51:53 +0000
Bug 1440537 - Fix a cross-origin navigation test to navigate reliably. r=bzbarsky This subtest (of test_iframe_sandbox_navigation.html) starts intermittently failing with my first patch of this bug. It relied on the pres-context being created when sendMouseEvent is called in order to navigate away (we only navigate away by clicking a link if there's a link handler). sendMouseEvent calls getBoundingClientRect() which used to do this. It no longer does though. I could make sendMouseEvent do that automatically using SpecialPowers or such, or from the DOMWindowUtils code, but I think I'd prefer not to do that. This is the only test that wasn't trivially fixable, and this awkwardness can be removed when bug 1218456 is fixed. Differential Revision: https://phabricator.services.mozilla.com/D28910
a07956b430eb080767e43e1ecea50821be0de1a2: Bug 1440537 - Fix docshell swap test to not rely on cross-docgroup flushing. r=bzbarsky
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 20 Apr 2019 19:42:30 +0200 - rev 471652
Push 112933 by rmaries@mozilla.com at Sat, 27 Apr 2019 21:51:53 +0000
Bug 1440537 - Fix docshell swap test to not rely on cross-docgroup flushing. r=bzbarsky This flush used to happen from snapshotWindow's innerWidth / innerHeight / scroll* getters. Differential Revision: https://phabricator.services.mozilla.com/D28303
99b3585a6840e5b74bb827ce07d7ac8a24a6ca42: Bug 1529757 - Add JS::GetFunctionRealm and use it in GetPrototypeFromConstructor. r=jorendorff,bzbarsky
Jan de Mooij <jdemooij@mozilla.com> - Fri, 26 Apr 2019 07:46:04 +0000 - rev 471465
Push 112923 by rmaries@mozilla.com at Fri, 26 Apr 2019 16:20:49 +0000
Bug 1529757 - Add JS::GetFunctionRealm and use it in GetPrototypeFromConstructor. r=jorendorff,bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D27867
7a5177cca40350267da21fdd3dd0025a172db51f: Bug 1546329 - Remove dead skins code. r=bzbarsky
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 24 Apr 2019 13:18:50 +0200 - rev 471306
Push 112913 by opoprus@mozilla.com at Thu, 25 Apr 2019 22:21:16 +0000
Bug 1546329 - Remove dead skins code. r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com//D28459
24ad41213ce44bef9fe3d7f8af56ad9ca38e941f: Bug 1545699 - Don't sync-reload chrome:// user-agent stylesheets from nsChromeRegistry. r=bzbarsky
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 19 Apr 2019 16:30:00 +0200 - rev 471303
Push 112913 by opoprus@mozilla.com at Thu, 25 Apr 2019 22:21:16 +0000
Bug 1545699 - Don't sync-reload chrome:// user-agent stylesheets from nsChromeRegistry. r=bzbarsky We assume in a bunch of other places that user agent stylesheets don't really change dynamically. It's not clear to me what this code is trying to accomplish or how is it supposed to work in a multi-process world, but I've left the author stylesheets code for now... Also, I'm pretty sure the styleset doesn't handle null sheets, so add a null-check to the author stylesheets. Differential Revision: https://phabricator.services.mozilla.com/D28211
db8e013ac78c8b0b4436fd86f867ce75e0064b5a: Bug 1546467 - Preserve reflectors of custom elements when they already have one. r=bzbarsky
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 23 Apr 2019 21:01:39 +0000 - rev 470793
Push 112879 by aciure@mozilla.com at Wed, 24 Apr 2019 04:31:08 +0000
Bug 1546467 - Preserve reflectors of custom elements when they already have one. r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D28542
395ab8c29a55bdf2aafae140e7787deb550c1580: Bug 806072 - Make nsIDOMWindow builtinclass. r=bzbarsky
Andrew McCreight <continuation@gmail.com> - Sun, 21 Apr 2019 02:39:10 +0000 - rev 470307
Push 112859 by rmaries@mozilla.com at Sun, 21 Apr 2019 10:34:53 +0000
Bug 806072 - Make nsIDOMWindow builtinclass. r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D28285
bbdaf05c9d16b95a9bea1bf1125d69fb58aacd81: Bug 1545516 - Don't flush parent document layout for detached frames from EnsureSizeAndPositionUpToDate. r=dholbert,bzbarsky
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 20 Apr 2019 14:41:55 +0000 - rev 470299
Push 112856 by dvarga@mozilla.com at Sat, 20 Apr 2019 21:53:58 +0000
Bug 1545516 - Don't flush parent document layout for detached frames from EnsureSizeAndPositionUpToDate. r=dholbert,bzbarsky And add a test for the same not happening already for normal flushes. Differential Revision: https://phabricator.services.mozilla.com/D28192
edbf9758ea946df5063e84c397c43208c555fd74: Bug 1281135 - Make <link disabled> work and HTMLLinkElement.disabled reflect that attribute. r=bzbarsky
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 19 Apr 2019 13:31:05 +0000 - rev 470204
Push 112847 by dluca@mozilla.com at Fri, 19 Apr 2019 21:51:54 +0000
Bug 1281135 - Make <link disabled> work and HTMLLinkElement.disabled reflect that attribute. r=bzbarsky ...instead of forwarding to the sheet like HTMLStyleElement does. I've proposed this behavior in: https://github.com/whatwg/html/issues/3840#issuecomment-480894419 I think this is one of the sane behaviors we can have, what Blink / WebKit do makes no sense to me. Alternative potentially-sane behavior is making the initial value of the stylesheet's disabled bit the same as the content attribute, and both reflect and forward the attribute from the setter. That means that setAttribute does something different than setting `disabled`, which means that you can get into all sorts of funny states when reloading the sheet... So I rather not do that. Differential Revision: https://phabricator.services.mozilla.com/D26573
ef991fe893a435f4416bde5f518135655a9740e1: Bug 1281135 - Make <link disabled> work and HTMLLinkElement.disabled reflect that attribute. r=bzbarsky
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 18 Apr 2019 07:48:55 +0000 - rev 470152
Push 112843 by aiakab@mozilla.com at Fri, 19 Apr 2019 09:50:22 +0000
Bug 1281135 - Make <link disabled> work and HTMLLinkElement.disabled reflect that attribute. r=bzbarsky ...instead of forwarding to the sheet like HTMLStyleElement does. I've proposed this behavior in: https://github.com/whatwg/html/issues/3840#issuecomment-480894419 I think this is one of the sane behaviors we can have, what Blink / WebKit do makes no sense to me. Alternative potentially-sane behavior is making the initial value of the stylesheet's disabled bit the same as the content attribute, and both reflect and forward the attribute from the setter. That means that setAttribute does something different than setting `disabled`, which means that you can get into all sorts of funny states when reloading the sheet... So I rather not do that. Differential Revision: https://phabricator.services.mozilla.com/D26573
ee03e8a4f6cd04cfc183a4ed2012c872cb021df0: Bug 144795 - Move HTMLDocument.cookie getter/setter to Document; r=bzbarsky
Ehsan Akhgari <ehsan@mozilla.com> - Thu, 18 Apr 2019 08:55:00 +0000 - rev 470076
Push 112843 by aiakab@mozilla.com at Fri, 19 Apr 2019 09:50:22 +0000
Bug 144795 - Move HTMLDocument.cookie getter/setter to Document; r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D27931
0e369b6ee8ff31b69fd546ffabfb4fc4133a8b87: Bug 1328138 - Disable the XMLDocument.async API on trunk; r=bzbarsky
Ehsan Akhgari <ehsan@mozilla.com> - Wed, 17 Apr 2019 19:46:05 +0000 - rev 469992
Push 112839 by apavel@mozilla.com at Thu, 18 Apr 2019 21:50:57 +0000
Bug 1328138 - Disable the XMLDocument.async API on trunk; r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D27730
66f817c81f0d91fa8a909ee93345c3a67184c6ba: Bug 332175 - Disable the XMLDocument.load() API on trunk; r=bzbarsky
Ehsan Akhgari <ehsan@mozilla.com> - Wed, 17 Apr 2019 19:37:10 +0000 - rev 469977
Push 112839 by apavel@mozilla.com at Thu, 18 Apr 2019 21:50:57 +0000
Bug 332175 - Disable the XMLDocument.load() API on trunk; r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D27729
4a3f5fbd5011ed794673c000a0e369393b435e43: Bug 1542790 - Part 3: Make nsIDOMMozBrowserFrame builtinclass, r=bzbarsky
Nika Layzell <nika@thelayzells.com> - Wed, 17 Apr 2019 00:53:12 +0000 - rev 469846
Push 112826 by btara@mozilla.com at Wed, 17 Apr 2019 21:50:20 +0000
Bug 1542790 - Part 3: Make nsIDOMMozBrowserFrame builtinclass, r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D27514
654741b9c784fb5f763ae500fb16865cdd167ccc: Bug 1538353 - Part 2: Create PBrowser actors using ManagedEndpoint instead of IPDL Ctors, r=bzbarsky
Nika Layzell <nika@thelayzells.com> - Wed, 17 Apr 2019 00:51:38 +0000 - rev 469836
Push 112826 by btara@mozilla.com at Wed, 17 Apr 2019 21:50:20 +0000
Bug 1538353 - Part 2: Create PBrowser actors using ManagedEndpoint instead of IPDL Ctors, r=bzbarsky Depends on D24566 Differential Revision: https://phabricator.services.mozilla.com/D24567
4c15baa5aa95c93096d6b0d7050aab8bb0fc2e8e: Bug 1544322 - Part 4 - Remove the [type] attribute for multiline <script> tags loading files in /tests/SimpleTest/ r=bzbarsky
Brian Grinstead <bgrinstead@mozilla.com> - Tue, 16 Apr 2019 04:01:46 +0000 - rev 469643
Push 112806 by apavel@mozilla.com at Tue, 16 Apr 2019 15:49:42 +0000
Bug 1544322 - Part 4 - Remove the [type] attribute for multiline <script> tags loading files in /tests/SimpleTest/ r=bzbarsky This is an autogenerated commit to handle scripts loading mochitest harness files, in the case where the script src is on the line below the script tag. This was generated with https://bug1544322.bmoattachments.org/attachment.cgi?id=9058170 using the `--part 4` argument. Differential Revision: https://phabricator.services.mozilla.com/D27459
0d9b9b96f5475adbed73922da696aeff7cbbaed3: Bug 1544322 - Part 3 - Remove the [type] attribute for multiline <script> tags loading files in chrome://mochikit/content/ r=bzbarsky
Brian Grinstead <bgrinstead@mozilla.com> - Tue, 16 Apr 2019 03:59:25 +0000 - rev 469642
Push 112806 by apavel@mozilla.com at Tue, 16 Apr 2019 15:49:42 +0000
Bug 1544322 - Part 3 - Remove the [type] attribute for multiline <script> tags loading files in chrome://mochikit/content/ r=bzbarsky This is an autogenerated commit to handle scripts loading mochitest harness files, in the case where the script src is on the line below the script tag. This was generated with https://bug1544322.bmoattachments.org/attachment.cgi?id=9058170 using the `--part 3` argument. Differential Revision: https://phabricator.services.mozilla.com/D27458
ba6f655fd68963530c866d0d4a48c3db3d307777: Bug 1544322 - Part 2.2 - Remove the [type] attribute for one-liner <script> tags loading files in /tests/SimpleTest/ in dom/ r=bzbarsky
Brian Grinstead <bgrinstead@mozilla.com> - Tue, 16 Apr 2019 03:53:28 +0000 - rev 469641
Push 112806 by apavel@mozilla.com at Tue, 16 Apr 2019 15:49:42 +0000
Bug 1544322 - Part 2.2 - Remove the [type] attribute for one-liner <script> tags loading files in /tests/SimpleTest/ in dom/ r=bzbarsky This is split from the previous changeset since if we include dom/ the file size is too large for phabricator to handle. This is an autogenerated commit to handle scripts loading mochitest harness files, in the simple case where the script src is on the same line as the tag. This was generated with https://bug1544322.bmoattachments.org/attachment.cgi?id=9058170 using the `--part 2` argument. Differential Revision: https://phabricator.services.mozilla.com/D27457
c9c0c6f2eed54a187e124942e53c3660b4cf17d8: Bug 1544322 - Part 2.1 - Remove the [type] attribute for one-liner <script> tags loading files in /tests/SimpleTest/ in everything except for dom/ r=bzbarsky
Brian Grinstead <bgrinstead@mozilla.com> - Tue, 16 Apr 2019 03:50:44 +0000 - rev 469640
Push 112806 by apavel@mozilla.com at Tue, 16 Apr 2019 15:49:42 +0000
Bug 1544322 - Part 2.1 - Remove the [type] attribute for one-liner <script> tags loading files in /tests/SimpleTest/ in everything except for dom/ r=bzbarsky This excludes dom/, otherwise the file size is too large for phabricator to handle. This is an autogenerated commit to handle scripts loading mochitest harness files, in the simple case where the script src is on the same line as the tag. This was generated with https://bug1544322.bmoattachments.org/attachment.cgi?id=9058170 using the `--part 2` argument. Differential Revision: https://phabricator.services.mozilla.com/D27456
0dc10a2d3d796543badef78e84b53f1ce3c96539: Bug 1544322 - Part 1 - Remove the [type] attribute for one-liner <script> tags loading files in chrome://mochikit/content/ r=bzbarsky
Brian Grinstead <bgrinstead@mozilla.com> - Mon, 15 Apr 2019 20:56:58 +0000 - rev 469639
Push 112806 by apavel@mozilla.com at Tue, 16 Apr 2019 15:49:42 +0000
Bug 1544322 - Part 1 - Remove the [type] attribute for one-liner <script> tags loading files in chrome://mochikit/content/ r=bzbarsky This is an autogenerated commit to handle scripts loading mochitest harness files, in the simple case where the script src is on the same line as the tag. This was generated with https://bug1544322.bmoattachments.org/attachment.cgi?id=9058170 using the `--part 1` argument. Differential Revision: https://phabricator.services.mozilla.com/D26812
fe4a28a68cfc2af8bc74a74ff6ae5c4dbded423a: Bug 1541679 - Skip pseudo frames when finding multicol containing block for reframing. r=bzbarsky
Ting-Yu Lin <tlin@mozilla.com> - Tue, 16 Apr 2019 05:35:51 +0000 - rev 469614
Push 112805 by opoprus@mozilla.com at Tue, 16 Apr 2019 10:02:04 +0000
Bug 1541679 - Skip pseudo frames when finding multicol containing block for reframing. r=bzbarsky This patch does something similar to GetIBContainingBlockFor() because pseudo frames are not good reframe target. Differential Revision: https://phabricator.services.mozilla.com/D26858
38ecdf260ccd7aede37d39df9a8587f4d677176d: Bug 1544215 - Make nsIContentVewer::GetPresShell() return mozilla::PresShell instead of nsIPresShell r=bzbarsky
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 16 Apr 2019 02:47:26 +0000 - rev 469608
Push 112805 by opoprus@mozilla.com at Tue, 16 Apr 2019 10:02:04 +0000
Bug 1544215 - Make nsIContentVewer::GetPresShell() return mozilla::PresShell instead of nsIPresShell r=bzbarsky Additionally, this patch makes `nsDocumentViewer` which is the only implementation of `nsIContentViewer` use `mozilla::PresShell` directly rather than via `nsIPresShell`. Differential Revision: https://phabricator.services.mozilla.com/D27470