searching for reviewer(bwc)
855640e1c096c294c882261ee141b6ce4689d0b8: Bug 1596562: Add ParamTraits specializations for mozilla::Vector and std::vector; r=froydnj,bwc
Aaron Klotz <aklotz@mozilla.com> - Mon, 18 Nov 2019 19:45:41 +0000 - rev 502461
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1596562: Add ParamTraits specializations for mozilla::Vector and std::vector; r=froydnj,bwc While the need for adding `mozilla::Vector` is self-evident, we also need `std::vector` so that we can send some pre-existing telemetry data structures that use it. The new implementations are basically modified from the `nsTArray` specializations. Note that the `mozilla::Vector` specialization does support any type of allocator, so we still check for OOM failures in that case. This patch also removes the specialization for `std::vector` that lives in WebRTC in favour of the centralized implementation. Differential Revision: https://phabricator.services.mozilla.com/D53085
48a708577712a2eb1b19aafcda25b2aa0e607629: Bug 1592620 - Add whitelist for mDNS hostname obfuscation; r=bwc
Dan Minor <dminor@mozilla.com> - Tue, 12 Nov 2019 17:17:11 +0000 - rev 501606
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1592620 - Add whitelist for mDNS hostname obfuscation; r=bwc This adds a whitelist of domains for which mDNS hostname obfuscation is disabled. The implementation is an updated version of the old screensharing whitelist code. Differential Revision: https://phabricator.services.mozilla.com/D52012
0163a2b9ca5ca939aa9f5b3c1ae139ee33814c0a: Bug 1592620 - Add whitelist for mDNS hostname obfuscation; r=bwc
Dan Minor <dminor@mozilla.com> - Thu, 07 Nov 2019 20:59:29 +0000 - rev 501291
Push 114168 by dluca@mozilla.com at Sun, 10 Nov 2019 03:08:55 +0000
Bug 1592620 - Add whitelist for mDNS hostname obfuscation; r=bwc This adds a whitelist of domains for which mDNS hostname obfuscation is disabled. The implementation is an updated version of the old screensharing whitelist code. Differential Revision: https://phabricator.services.mozilla.com/D52012
c4f2a7e9107a59035ef83204a4e36dcce9c61569: Bug 1588055 - Remove use of nsAutoPtr in MediaPipeline. r=bwc
Andreas Pehrson <apehrson@mozilla.com> - Wed, 06 Nov 2019 05:11:00 +0000 - rev 500842
Push 114166 by apavel@mozilla.com at Thu, 07 Nov 2019 10:04:01 +0000
Bug 1588055 - Remove use of nsAutoPtr in MediaPipeline. r=bwc Differential Revision: https://phabricator.services.mozilla.com/D49239
b28a24fa20764029179cbda089f117863b90d41d: Bug 1588055 - Fix MediaPipeline static-analysis warnings and make RefPtr passing consistent. r=bwc
Andreas Pehrson <apehrson@mozilla.com> - Wed, 06 Nov 2019 05:11:02 +0000 - rev 500841
Push 114166 by apavel@mozilla.com at Thu, 07 Nov 2019 10:04:01 +0000
Bug 1588055 - Fix MediaPipeline static-analysis warnings and make RefPtr passing consistent. r=bwc Differential Revision: https://phabricator.services.mozilla.com/D48957
28a50db0c0062c9fac2e44e3c734421d4e69bb23: Bug 1212237 - Use a content principal by default for received tracks. r=bwc
Andreas Pehrson <apehrson@mozilla.com> - Wed, 06 Nov 2019 05:11:04 +0000 - rev 500840
Push 114166 by apavel@mozilla.com at Thu, 07 Nov 2019 10:04:01 +0000
Bug 1212237 - Use a content principal by default for received tracks. r=bwc This swaps things around so that received tracks in peer connections have a content principal instead of a null principal initially. This puts an extra requirement on us to not output any frames under the content principal after ALPN has been negotiated with requested privacy, but before this private principal has been signaled to the MediaPipelines. The private principal is signaled from the STS thread, via the main thread, whereas media is consumed directly by MediaPipelines after being received on the STS thread. This patch adds an extra signaling path directly from the STS thread that tells MediaPipelines to make their PrincipalHandle private, and to ignore any data until the private PrincipalHandle is set. It also moves the responsibility of updating the principal of the received MediaStreamTracks from TransceiverImpl to MediaPipeline, so it's all in the same path. This lets all MediaStream and MediaStreamTrack APIs consume received tracks directly after getting exposed to JS without errors. In case privacy is later requested, consumers that have already been set up must handle this on the fly. (They do, in specs and impls) Differential Revision: https://phabricator.services.mozilla.com/D48947
fafd810651ef5e61cb0d191bef8da3dd45496cc4: Bug 1212237 - s/nsIEventTarget/nsISerialEventTarget/ in media/webrtc. r=bwc
Andreas Pehrson <apehrson@mozilla.com> - Wed, 06 Nov 2019 05:10:58 +0000 - rev 500839
Push 114166 by apavel@mozilla.com at Thu, 07 Nov 2019 10:04:01 +0000
Bug 1212237 - s/nsIEventTarget/nsISerialEventTarget/ in media/webrtc. r=bwc nsISerialEventTarget is more semantically accurate for these uses, as the dispatched runnables cannot run in parallel. It also allows us to use InvokeAsync in future patches, as that function only takes nsISerialEventTarget. Differential Revision: https://phabricator.services.mozilla.com/D49262
f828ded989ea0d4d117d2b3087acc223a59e80f3: Bug 1212237 - Be explicit about principals for received tracks. r=bwc
Andreas Pehrson <apehrson@mozilla.com> - Wed, 06 Nov 2019 05:11:06 +0000 - rev 500838
Push 114166 by apavel@mozilla.com at Thu, 07 Nov 2019 10:04:01 +0000
Bug 1212237 - Be explicit about principals for received tracks. r=bwc This patch fixes two things: 1) A potential threading issue in setting and reading the PrincipalHandle for MediaPipelineReceiveVideo. 2) Plumbs the PrincipalHandle down to the receiving MediaPipelines right from the start. It hasn't been necessary in the past as initially the principal handed to a track's constructor is trusted, but it's good form and will help clarify the situation for the next patch which switches the initial principal from always-private to mostly-non-private. In most cases this principal does no longer get updated after the track's been created, so it helps to have a PrincipalHandle that matches the track's principal. Differential Revision: https://phabricator.services.mozilla.com/D48946
15f2829db807a503a42e8d35ab5cbdf6f05d65fe: Bug 1588055 - Remove use of nsAutoPtr in MediaPipeline. r=bwc
Andreas Pehrson <apehrson@mozilla.com> - Tue, 05 Nov 2019 20:04:59 +0000 - rev 500715
Push 114166 by apavel@mozilla.com at Thu, 07 Nov 2019 10:04:01 +0000
Bug 1588055 - Remove use of nsAutoPtr in MediaPipeline. r=bwc Differential Revision: https://phabricator.services.mozilla.com/D49239
bbff556beb57c45c5fdf88919d4d89431d8fe740: Bug 1588055 - Fix MediaPipeline static-analysis warnings and make RefPtr passing consistent. r=bwc
Andreas Pehrson <apehrson@mozilla.com> - Tue, 05 Nov 2019 20:04:52 +0000 - rev 500714
Push 114166 by apavel@mozilla.com at Thu, 07 Nov 2019 10:04:01 +0000
Bug 1588055 - Fix MediaPipeline static-analysis warnings and make RefPtr passing consistent. r=bwc Differential Revision: https://phabricator.services.mozilla.com/D48957
c3f52449c92c90882fd96ca4003670bc89d1f186: Bug 1212237 - Use a content principal by default for received tracks. r=bwc
Andreas Pehrson <apehrson@mozilla.com> - Tue, 05 Nov 2019 20:04:45 +0000 - rev 500713
Push 114166 by apavel@mozilla.com at Thu, 07 Nov 2019 10:04:01 +0000
Bug 1212237 - Use a content principal by default for received tracks. r=bwc This swaps things around so that received tracks in peer connections have a content principal instead of a null principal initially. This puts an extra requirement on us to not output any frames under the content principal after ALPN has been negotiated with requested privacy, but before this private principal has been signaled to the MediaPipelines. The private principal is signaled from the STS thread, via the main thread, whereas media is consumed directly by MediaPipelines after being received on the STS thread. This patch adds an extra signaling path directly from the STS thread that tells MediaPipelines to make their PrincipalHandle private, and to ignore any data until the private PrincipalHandle is set. It also moves the responsibility of updating the principal of the received MediaStreamTracks from TransceiverImpl to MediaPipeline, so it's all in the same path. This lets all MediaStream and MediaStreamTrack APIs consume received tracks directly after getting exposed to JS without errors. In case privacy is later requested, consumers that have already been set up must handle this on the fly. (They do, in specs and impls) Differential Revision: https://phabricator.services.mozilla.com/D48947
c23272ab755f69f6eca53486ce935f0d96c984d3: Bug 1212237 - s/nsIEventTarget/nsISerialEventTarget/ in media/webrtc. r=bwc
Andreas Pehrson <apehrson@mozilla.com> - Tue, 05 Nov 2019 20:04:29 +0000 - rev 500712
Push 114166 by apavel@mozilla.com at Thu, 07 Nov 2019 10:04:01 +0000
Bug 1212237 - s/nsIEventTarget/nsISerialEventTarget/ in media/webrtc. r=bwc nsISerialEventTarget is more semantically accurate for these uses, as the dispatched runnables cannot run in parallel. It also allows us to use InvokeAsync in future patches, as that function only takes nsISerialEventTarget. Differential Revision: https://phabricator.services.mozilla.com/D49262
184b8485ae32cd143a26ea3fc3a00b8a9917b8e9: Bug 1212237 - Be explicit about principals for received tracks. r=bwc
Andreas Pehrson <apehrson@mozilla.com> - Tue, 05 Nov 2019 20:04:15 +0000 - rev 500711
Push 114166 by apavel@mozilla.com at Thu, 07 Nov 2019 10:04:01 +0000
Bug 1212237 - Be explicit about principals for received tracks. r=bwc This patch fixes two things: 1) A potential threading issue in setting and reading the PrincipalHandle for MediaPipelineReceiveVideo. 2) Plumbs the PrincipalHandle down to the receiving MediaPipelines right from the start. It hasn't been necessary in the past as initially the principal handed to a track's constructor is trusted, but it's good form and will help clarify the situation for the next patch which switches the initial principal from always-private to mostly-non-private. In most cases this principal does no longer get updated after the track's been created, so it helps to have a PrincipalHandle that matches the track's principal. Differential Revision: https://phabricator.services.mozilla.com/D48946
3f664509986e0681c57c3de8454b30da748a7f20: Bug 1591438 - Move DEFINE_IPC_SERIALIZER_WITH_FIELDS into IPCMessageUtils header r=bwc
Dzmitry Malyshau <dmalyshau@mozilla.com> - Mon, 04 Nov 2019 15:00:04 +0000 - rev 500435
Push 114164 by aiakab@mozilla.com at Tue, 05 Nov 2019 10:06:15 +0000
Bug 1591438 - Move DEFINE_IPC_SERIALIZER_WITH_FIELDS into IPCMessageUtils header r=bwc Differential Revision: https://phabricator.services.mozilla.com/D51558
050162995d2aa173e963b19aa7868d82c126c08d: Bug 1591854: properly count active track in CountTracks(). r=bwc
Nils Ohlmeier [:drno] <drno@ohlmeier.org> - Thu, 31 Oct 2019 19:36:00 +0000 - rev 500085
Push 114164 by aiakab@mozilla.com at Tue, 05 Nov 2019 10:06:15 +0000
Bug 1591854: properly count active track in CountTracks(). r=bwc Differential Revision: https://phabricator.services.mozilla.com/D50774
4ffa57ccf558cc9d61d1d8706f6d70d16032ffdb: Bug 1372950 - Enable mediapipeline_unittest on Windows; r=bwc
Dan Minor <dminor@mozilla.com> - Thu, 31 Oct 2019 15:25:15 +0000 - rev 500045
Push 114164 by aiakab@mozilla.com at Tue, 05 Nov 2019 10:06:15 +0000
Bug 1372950 - Enable mediapipeline_unittest on Windows; r=bwc Differential Revision: https://phabricator.services.mozilla.com/D51283
e2536fbffa1551b71f13a0cf54329da0d54c83d5: Bug 1380786 - Remove ICE candidate telemetry; r=bwc
Dan Minor <dminor@mozilla.com> - Fri, 25 Oct 2019 20:24:15 +0000 - rev 499466
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1380786 - Remove ICE candidate telemetry; r=bwc This ICE candidate telemetry has not been used in a long time and in addition requires special handling by the telemetry code. It is best removed. Differential Revision: https://phabricator.services.mozilla.com/D50656
b37d1c262965893df0d27fa9300e6cf6af337a99: Bug 1587164 - Avoid left shift of negative value in TimestampWrapAroundHandler; r=bwc
Dan Minor <dminor@mozilla.com> - Fri, 18 Oct 2019 13:48:21 +0000 - rev 498233
Push 114157 by nbeleuzu@mozilla.com at Mon, 21 Oct 2019 22:00:13 +0000
Bug 1587164 - Avoid left shift of negative value in TimestampWrapAroundHandler; r=bwc The code for handling backwards wraps left shifts num_wrap_ - 1. If num_wrap_ is zero, this results in a left shift of a negative value which is undefined behaviour. This modifies the code to avoid the shift at the cost of an extra multiplication. Differential Revision: https://phabricator.services.mozilla.com/D49609
30a9a8619ce1f31661a40c97a7d7a49ac4d30f1c: Bug 1586423 - Revert bug 1470568 for breaking Google Meet, etc. r=bwc
Jeff Gilbert <jgilbert@mozilla.com> - Wed, 16 Oct 2019 16:40:19 +0000 - rev 497907
Push 114154 by btara@mozilla.com at Thu, 17 Oct 2019 09:58:40 +0000
Bug 1586423 - Revert bug 1470568 for breaking Google Meet, etc. r=bwc Differential Revision: https://phabricator.services.mozilla.com/D49364
98c7a85974c5a1ae7ea166bea9b01a2b2adbc979: Bug 1517369 - Check for invalid rtp extension ids; r=bwc
Dan Minor <dminor@mozilla.com> - Tue, 15 Oct 2019 15:26:01 +0000 - rev 497673
Push 114154 by btara@mozilla.com at Thu, 17 Oct 2019 09:58:40 +0000
Bug 1517369 - Check for invalid rtp extension ids; r=bwc This adds checks for invalid and duplicated rtp extension ids to JsepSessionImpl. Since the version of webrtc.org we're using does not support two byte extension ids, ids must be between 1 and 14 inclusive. Duplicated extension ids are also disallowed by RFC 8285. Passing an invalid extension id into the webrtc.org code will trigger a release assertion and a browser crash. Differential Revision: https://phabricator.services.mozilla.com/D48689
3d1ed8b2fb91d2df8d01c9023ebc7c89967c7278: Bug 1586593 - dispatch CloseInt on DataChannel Open ACK failure - r=bwc
Nico Grunbaum <na-g@nostrum.com> - Fri, 11 Oct 2019 17:03:23 +0000 - rev 497293
Push 114148 by shindli@mozilla.com at Mon, 14 Oct 2019 10:49:50 +0000
Bug 1586593 - dispatch CloseInt on DataChannel Open ACK failure - r=bwc Differential Revision: https://phabricator.services.mozilla.com/D48938
ace16b7e7aa6fe5233bc9a0ddbf9923a04cfadb7: Bug 1587905 - Remove useless variable 'r' declaration & assignation r=bwc
Sylvestre Ledru <sledru@mozilla.com> - Fri, 11 Oct 2019 07:32:47 +0000 - rev 497249
Push 114148 by shindli@mozilla.com at Mon, 14 Oct 2019 10:49:50 +0000
Bug 1587905 - Remove useless variable 'r' declaration & assignation r=bwc Differential Revision: https://phabricator.services.mozilla.com/D48890
258c68e013454a876c4c65a2556a43d4739a26c4: Bug 1585009: Support playout-delay RTP header extension r=bwc
Andreas Schuler <andreas.schuler@phenixrts.com> - Tue, 08 Oct 2019 12:49:52 +0000 - rev 496805
Push 114146 by dmajor@mozilla.com at Wed, 09 Oct 2019 17:52:49 +0000
Bug 1585009: Support playout-delay RTP header extension r=bwc Added playout-delay RTP header extension for video to JsepSessionImpl::SetupDefaultRtpExtensions. This ensures that this extension will be preserved when generating an answer to an offer (by a sending peer) containing it. Also updated JsepSessionTest to include a test verifying that the expected default audio and video extensions are set. Differential Revision: https://phabricator.services.mozilla.com/D47689
2b676ea4de819e1e463429c85ad79a0721fb8722: Bug 1564902 - Checked paused_ prior to calling SendPacket; r=bwc
Dan Minor <dminor@mozilla.com> - Tue, 08 Oct 2019 15:42:58 +0000 - rev 496797
Push 114146 by dmajor@mozilla.com at Wed, 09 Oct 2019 17:52:49 +0000
Bug 1564902 - Checked paused_ prior to calling SendPacket; r=bwc There is a window inside of SendPacket where the critical section is released which means that other code could set paused_. This would lead to us hitting the assertion at the top of SendPacket. Checking paused_ in the while loop will avoid this. Upstream has fixed this problem in a similar way, but the code has changed there enough that it doesn't make sense to try to bring in their fix directly. Differential Revision: https://phabricator.services.mozilla.com/D48540
7bbdfe6958a4305ea430db9d217771a5230c1cd5: Bug 1584751 - Only open DataChannelConnections that aren't already open; r=bwc
Nico Grunbaum <na-g@nostrum.com> - Sat, 05 Oct 2019 02:48:15 +0000 - rev 496438
Push 114143 by rgurzau@mozilla.com at Mon, 07 Oct 2019 09:35:08 +0000
Bug 1584751 - Only open DataChannelConnections that aren't already open; r=bwc Differential Revision: https://phabricator.services.mozilla.com/D47691
363625fae57859e7311acd89164e4789a24f4a0c: Bug 1584695 - Place DataChannelConnection connection state behind an accessor - r=bwc
Nico Grunbaum <na-g@nostrum.com> - Sat, 05 Oct 2019 02:48:08 +0000 - rev 496437
Push 114143 by rgurzau@mozilla.com at Mon, 07 Oct 2019 09:35:08 +0000
Bug 1584695 - Place DataChannelConnection connection state behind an accessor - r=bwc Differential Revision: https://phabricator.services.mozilla.com/D47690
fac79eb65900623382089842962e545aabb1a042: Bug 1584751 - Only open DataChannelConnections that aren't already open; r=bwc
Nico Grunbaum <na-g@nostrum.com> - Thu, 03 Oct 2019 04:56:26 +0000 - rev 496142
Push 114143 by rgurzau@mozilla.com at Mon, 07 Oct 2019 09:35:08 +0000
Bug 1584751 - Only open DataChannelConnections that aren't already open; r=bwc Differential Revision: https://phabricator.services.mozilla.com/D47691
dd5211c4ded2f2212e9ca990f4026c9e4dd1b5b1: Bug 1584695 - Place DataChannelConnection connection state behind an accessor - r=bwc
Nico Grunbaum <na-g@nostrum.com> - Thu, 03 Oct 2019 04:56:18 +0000 - rev 496141
Push 114143 by rgurzau@mozilla.com at Mon, 07 Oct 2019 09:35:08 +0000
Bug 1584695 - Place DataChannelConnection connection state behind an accessor - r=bwc Differential Revision: https://phabricator.services.mozilla.com/D47690
a3afb69b01cf0a296927d39c8b04146bdc9fa8b7: Bug 1583986 - add pref to control ffvpx mp3 decoding so we can turn it off if needed. r=bwc,jya
Michael Froman <mfroman@mozilla.com> - Mon, 30 Sep 2019 14:29:08 +0000 - rev 495696
Push 114140 by dvarga@mozilla.com at Wed, 02 Oct 2019 18:04:51 +0000
Bug 1583986 - add pref to control ffvpx mp3 decoding so we can turn it off if needed. r=bwc,jya Differential Revision: https://phabricator.services.mozilla.com/D47499
843547c4b06eda50bd816303b1df107be8a6282d: Bug 1578810 - Handle mDNS hostname prior to calling OnCandidateFound; r=bwc
Dan Minor <dminor@mozilla.com> - Wed, 18 Sep 2019 22:02:45 +0000 - rev 494277
Push 114114 by dluca@mozilla.com at Fri, 20 Sep 2019 22:00:08 +0000
Bug 1578810 - Handle mDNS hostname prior to calling OnCandidateFound; r=bwc Differential Revision: https://phabricator.services.mozilla.com/D45563
6660b35d217fdd91b83a14feb04475ed766fd5d6: Bug 1581023 - Expand DataChannel logging capabilities - r=bwc
Nico Grunbaum <na-g@nostrum.com> - Thu, 19 Sep 2019 14:50:57 +0000 - rev 494075
Push 114105 by malexandru@mozilla.com at Fri, 20 Sep 2019 04:04:33 +0000
Bug 1581023 - Expand DataChannel logging capabilities - r=bwc Differential Revision: https://phabricator.services.mozilla.com/D45800
2591b1d2429d5ac5afb3a98e5d19e7499e70dd4d: Bug 1581577 - Fix ICE duration telemetry high value; r=bwc
Dan Minor <dminor@mozilla.com> - Mon, 16 Sep 2019 18:15:28 +0000 - rev 493552
Push 114097 by malexandru@mozilla.com at Wed, 18 Sep 2019 10:10:26 +0000
Bug 1581577 - Fix ICE duration telemetry high value; r=bwc The Telemetry::AccumulateTimeDelta function reports in milliseconds but I had assumed seconds when I added the hostname obfuscation ICE duration histogram. This change adjusts the "high" value accordingly. With the telemetry we've collected to date, 60% of the values are below 600 milliseconds, so I think that setting a high value of 30 seconds should be sufficient even if there is a long tail. Since this does not change the data being collected, no additional data-review is required, but it does require renaming the key. Differential Revision: https://phabricator.services.mozilla.com/D46045
598d441e4ebaa93ab098d266035a396057c82129: Bug 1580524 - Free conduits when transceiver is stopped; r=bwc
Dan Minor <dminor@mozilla.com> - Fri, 13 Sep 2019 17:44:06 +0000 - rev 493107
Push 114082 by dvarga@mozilla.com at Fri, 13 Sep 2019 21:51:00 +0000
Bug 1580524 - Free conduits when transceiver is stopped; r=bwc Freeing the conduits when the transceiver is stopped releases all of the associated webrtc.org objects which results in substantial memory savings. On my system, with an opt+debug build and 200 stopped transceivers, I see 373.17 MB of memory use in the content process without this patch, and 158.93 MB of memory use with this patch applied. Going further and calling Shutdown_m as part of Stop() reduces the memory use to 157.98 MB, which seems like a marginal improvement at the cost of a much larger risk of introducing bugs. Differential Revision: https://phabricator.services.mozilla.com/D45845
fd2934cca1ae7b492f29a4d240915aa9ec5b4977: Bug 1569250 - Add telemetry for mDNS use in WebRTC; r=bwc
Dan Minor <dminor@mozilla.com> - Mon, 09 Sep 2019 16:45:02 +0000 - rev 492357
Push 114051 by rgurzau@mozilla.com at Mon, 09 Sep 2019 21:51:12 +0000
Bug 1569250 - Add telemetry for mDNS use in WebRTC; r=bwc Differential Revision: https://phabricator.services.mozilla.com/D44888
ef18dbaff6c7671eac7642f228d458fe15dcc6b9: Bug 1569250 - Add telemetry for mDNS use in WebRTC; r=bwc
Dan Minor <dminor@mozilla.com> - Mon, 09 Sep 2019 13:21:18 +0000 - rev 492319
Push 114051 by rgurzau@mozilla.com at Mon, 09 Sep 2019 21:51:12 +0000
Bug 1569250 - Add telemetry for mDNS use in WebRTC; r=bwc Differential Revision: https://phabricator.services.mozilla.com/D44888
2d4f1f657c820e12359644d3c810cd8a2097f2b7: Bug 1576771 - Reset VideoFrameConverter's track-enabled state when disconnecting video listeners. r=bwc
Andreas Pehrson <apehrson@mozilla.com> - Wed, 04 Sep 2019 14:53:51 +0000 - rev 491686
Push 114032 by btara@mozilla.com at Thu, 05 Sep 2019 03:53:00 +0000
Bug 1576771 - Reset VideoFrameConverter's track-enabled state when disconnecting video listeners. r=bwc Depends on D44675 Differential Revision: https://phabricator.services.mozilla.com/D44676
148bf9d80e428887103aa2dd471efd237ef77755: Bug 1571987 - Forward proxy check request to parent process r=dragana,bwc
Kershaw Chang <kershaw@mozilla.com> - Sat, 24 Aug 2019 05:37:00 +0000 - rev 490367
Push 113991 by rgurzau@mozilla.com at Wed, 28 Aug 2019 15:58:47 +0000
Bug 1571987 - Forward proxy check request to parent process r=dragana,bwc Differential Revision: https://phabricator.services.mozilla.com/D41004
c8773774d96976aea43a9540546d023688d81920: Bug 1575876 - Drop header unused on FreeBSD that breaks with new libc++. r=bwc
Tijl Coosemans <tijl@FreeBSD.org> - Sat, 24 Aug 2019 01:38:05 +0300 - rev 489689
Push 113959 by dvarga@mozilla.com at Fri, 23 Aug 2019 22:42:11 +0000
Bug 1575876 - Drop header unused on FreeBSD that breaks with new libc++. r=bwc
8f803211fda5ad9694932a62e6ac4b3e417f70d0: Bug 1570158 - Add proxy information to candidates table in about:webrtc r=bwc,baku
Ryan Alderete <ralderete@mozilla.com> - Wed, 21 Aug 2019 10:04:45 +0000 - rev 489224
Push 113941 by aciure@mozilla.com at Wed, 21 Aug 2019 21:59:00 +0000
Bug 1570158 - Add proxy information to candidates table in about:webrtc r=bwc,baku This adds a field to about:webrtc which indicates whether an associated candidate is behind a proxy or not. Differential Revision: https://phabricator.services.mozilla.com/D39974
0dc91d87721bbd95ec2bccd1bfff87f22125ae6d: Bug 1574512 - Fix error handling in nr_ice_set_target_for_default_local_address_lookup() r=bwc
Ryan Alderete <ralderete@mozilla.com> - Tue, 20 Aug 2019 15:46:59 +0000 - rev 489032
Push 113935 by malexandru@mozilla.com at Tue, 20 Aug 2019 22:03:24 +0000
Bug 1574512 - Fix error handling in nr_ice_set_target_for_default_local_address_lookup() r=bwc If the remote IP address and port number are unable to be converted to a transport address, the context was incorrectly left with a pointer to zeroed out memory, which causes nr_ice_get_default_local_address() to abort. Freeing the address and setting the pointer to null on failure should allow the fallback to be used to retrieve the default local address. Differential Revision: https://phabricator.services.mozilla.com/D42661
c7035d0cf37cff484d73faa789963cbdda32c10a: Bug 1538933 - Convert remaining TimeStamp checks to use TimeDuration. r=bwc
Andreas Pehrson <apehrson@mozilla.com> - Mon, 12 Aug 2019 16:05:47 +0000 - rev 487614
Push 113883 by btara@mozilla.com at Tue, 13 Aug 2019 16:13:25 +0000
Bug 1538933 - Convert remaining TimeStamp checks to use TimeDuration. r=bwc Differential Revision: https://phabricator.services.mozilla.com/D41510
9f6cb22cf3e2cc2e567c0228b55c2cd471223dc0: Bug 1538933 - Compare TimeDuration instead of TimeStamp in TestVideoFrameConverter for sensible logs. r=bwc
Andreas Pehrson <apehrson@mozilla.com> - Wed, 07 Aug 2019 15:12:39 +0000 - rev 486818
Push 113855 by shindli@mozilla.com at Wed, 07 Aug 2019 21:56:41 +0000
Bug 1538933 - Compare TimeDuration instead of TimeStamp in TestVideoFrameConverter for sensible logs. r=bwc Depends on D40599 Differential Revision: https://phabricator.services.mozilla.com/D41020
acd8b80087e0ddc254455b3a8afcc8cebe3e5922: Bug 1570673 - Update last frame's time on same-frame-ticks. r=bwc
Andreas Pehrson <apehrson@mozilla.com> - Wed, 07 Aug 2019 15:11:00 +0000 - rev 486817
Push 113855 by shindli@mozilla.com at Wed, 07 Aug 2019 21:56:41 +0000
Bug 1570673 - Update last frame's time on same-frame-ticks. r=bwc Differential Revision: https://phabricator.services.mozilla.com/D40599
91d822ac2647976e1e9e80eff9a1306bc030849b: Bug 1570673 - Add an active state to VideoFrameConverter and propagate it from MediaPipeline. r=bwc
Andreas Pehrson <apehrson@mozilla.com> - Mon, 05 Aug 2019 18:00:48 +0000 - rev 486816
Push 113855 by shindli@mozilla.com at Wed, 07 Aug 2019 21:56:41 +0000
Bug 1570673 - Add an active state to VideoFrameConverter and propagate it from MediaPipeline. r=bwc Differential Revision: https://phabricator.services.mozilla.com/D40598
d2a030d452cbc42b30d282ed14730466626f6af6: Bug 1570673 - Add mochitest. r=bwc
Andreas Pehrson <apehrson@mozilla.com> - Mon, 05 Aug 2019 17:21:19 +0000 - rev 486815
Push 113855 by shindli@mozilla.com at Wed, 07 Aug 2019 21:56:41 +0000
Bug 1570673 - Add mochitest. r=bwc Differential Revision: https://phabricator.services.mozilla.com/D40597
57b8410f0239f2756915d3ac62f152f3e70c213d: Bug 1452713 - Update webRTCIPHandlingPolicy to match Chrome r=bwc,mixedpuppy
Ryan Alderete <ralderete@mozilla.com> - Fri, 02 Aug 2019 21:33:46 +0000 - rev 486049
Push 113827 by btara@mozilla.com at Sat, 03 Aug 2019 09:54:50 +0000
Bug 1452713 - Update webRTCIPHandlingPolicy to match Chrome r=bwc,mixedpuppy Previously, the network.webRTCIPHandlingPolicy "disable_non_proxied_udp" only enabled the use of WebRTC if a proxy was configured and the WebRTC service supported TURN TCP. This aims to match Chrome's behavior by forcing the use of a proxy if one is configured, otherwise falling back to mode 3 (no host candidates and default route only). Also, remove some dead code left over from the old way of routing TURN communications through an HTTP proxy. Differential Revision: https://phabricator.services.mozilla.com/D37892
470fee6b609006fbab428baff5a901bf69d20e65: Bug 1561923 - Remove expired WebRTC telemetry; r=drno,bwc
Dan Minor <dminor@mozilla.com> - Wed, 31 Jul 2019 19:57:55 +0000 - rev 485678
Push 113818 by rmaries@mozilla.com at Thu, 01 Aug 2019 22:55:32 +0000
Bug 1561923 - Remove expired WebRTC telemetry; r=drno,bwc Differential Revision: https://phabricator.services.mozilla.com/D37757
0b03dd9d20ace235502714101097fe34d1864563: Bug 1493613 - Update muted state through MediaStreamTrackSource. r=bwc,smaug
Andreas Pehrson <apehrson@mozilla.com> - Wed, 31 Jul 2019 09:35:06 +0000 - rev 485562
Push 113810 by malexandru@mozilla.com at Wed, 31 Jul 2019 16:03:22 +0000
Bug 1493613 - Update muted state through MediaStreamTrackSource. r=bwc,smaug This ensures all clones of the original track also receives the new muted state. Differential Revision: https://phabricator.services.mozilla.com/D37933
de98fc620593931bf5272f70288a03c2750c7272: Bug 1567892 - PeerConnectionMedia should use nsIProtocolProxyService on the parent process - PProxyConfigLookup IPC protocol, r=bwc,kershaw,jld
Andrea Marchesini <amarchesini@mozilla.com> - Mon, 29 Jul 2019 12:27:59 +0000 - rev 485101
Push 113797 by ccoroiu@mozilla.com at Mon, 29 Jul 2019 21:45:35 +0000
Bug 1567892 - PeerConnectionMedia should use nsIProtocolProxyService on the parent process - PProxyConfigLookup IPC protocol, r=bwc,kershaw,jld Differential Revision: https://phabricator.services.mozilla.com/D39010
ed3ab66482afaee673a39d132d256cc619fdb376: Bug 1506219 - Use a known remote for applications loaded from file:// URIs r=bwc
Ryan Alderete <ralderete@mozilla.com> - Wed, 24 Jul 2019 21:58:33 +0000 - rev 484774
Push 113781 by csabou@mozilla.com at Fri, 26 Jul 2019 03:47:00 +0000
Bug 1506219 - Use a known remote for applications loaded from file:// URIs r=bwc Fall back to using Google's DNS server to determine the associated local addresses for web applications that are not loaded over the network. This includes the loopback address, which is frequently used in the unit tests. Provide a separate function for setting the target for the default local address lookup. Differential Revision: https://phabricator.services.mozilla.com/D37331