searching for reviewer(botond)
c3263d20de95ce8ea3108ac6719613863848bf34: Bug 1558863 - elementScroll.html now works fine on Android E10S environments, bug 1554022 fixed the failure reason. r=botond
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Fri, 14 Jun 2019 18:35:34 +0000 - rev 478965
Push 113448 by apavel@mozilla.com at Sat, 15 Jun 2019 10:07:35 +0000
Bug 1558863 - elementScroll.html now works fine on Android E10S environments, bug 1554022 fixed the failure reason. r=botond Differential Revision: https://phabricator.services.mozilla.com/D34951
f0bc3b97d02d39bc3db843c3760a9e56edac5c86: Bug 1557970 - Put the root metadata on the zoom container if there is one, for the WR codepath. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Wed, 12 Jun 2019 16:51:22 +0000 - rev 478467
Push 113422 by aciure@mozilla.com at Wed, 12 Jun 2019 21:46:30 +0000
Bug 1557970 - Put the root metadata on the zoom container if there is one, for the WR codepath. r=botond Same fix as in bug 1553045, but for the WebRender codepath. Differential Revision: https://phabricator.services.mozilla.com/D34626
019f488e7e2d50a1ff6f52b3d79fd10b487c2a55: Bug 1557970 - Implement IsAsyncZoomContainer for the WR codepath. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Wed, 12 Jun 2019 15:48:41 +0000 - rev 478466
Push 113422 by aciure@mozilla.com at Wed, 12 Jun 2019 21:46:30 +0000
Bug 1557970 - Implement IsAsyncZoomContainer for the WR codepath. r=botond This makes the assertion failure from bug 1553045 reproduce with WR enabled. Differential Revision: https://phabricator.services.mozilla.com/D34625
bdb43da73c351267fc68378904ec56d9a1286516: Bug 1554022 - Use the current position in CSS pixels for the start point of ScrollBy. r=botond,mstange
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Tue, 11 Jun 2019 22:43:34 +0000 - rev 478377
Push 113419 by dluca@mozilla.com at Wed, 12 Jun 2019 12:45:34 +0000
Bug 1554022 - Use the current position in CSS pixels for the start point of ScrollBy. r=botond,mstange Otherwise clamped positions in layer pixels might cause 1-pixel difference in CSS pixels on Android. Note that there is a fundamental issue on the interaction between the layer-pixel alignment and scrolling APIs (bug 1556685), once we fix the bug properly, we should use the scrolled position, which was given by the scrolling APIs, for the current position. Differential Revision: https://phabricator.services.mozilla.com/D32779
16588525ccd9b10d52e956e3369c3c3d0fa8b238: Bug 1551801 - Fix the velocity direction on pan gesture events. r=botond
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Tue, 11 Jun 2019 02:40:20 +0000 - rev 478179
Push 113407 by cbrindusan@mozilla.com at Tue, 11 Jun 2019 09:45:25 +0000
Bug 1551801 - Fix the velocity direction on pan gesture events. r=botond The gtest in this commit fails without the fix. Differential Revision: https://phabricator.services.mozilla.com/D34245
6689a98f4a9f59d7af7704006c476ddb7d05ebf7: Bug 1551801 - Fix the velocity direction on pan gesture events. r=botond
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Mon, 10 Jun 2019 16:25:05 +0000 - rev 478142
Push 113405 by nerli@mozilla.com at Tue, 11 Jun 2019 03:22:35 +0000
Bug 1551801 - Fix the velocity direction on pan gesture events. r=botond The gtest in this commit fails without the fix. Differential Revision: https://phabricator.services.mozilla.com/D34245
7bed70ba2b07bd7790964ec5495d66a7dc3d36b3: Bug 1550467 - Add a test for event untransforms. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 06 Jun 2019 20:49:52 +0000 - rev 477715
Push 113372 by dvarga@mozilla.com at Fri, 07 Jun 2019 10:07:35 +0000
Bug 1550467 - Add a test for event untransforms. r=botond This exercises the transforms propagated in bug 1530661, which is WebRender-specific (because the events only have the target layers id set on them if WR is enabled). Differential Revision: https://phabricator.services.mozilla.com/D32189
4da9907d86f8428e91afe3056aec10a13690aa6d: Bug 1550467 - Also install SimpleTest.is into the fission window. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 06 Jun 2019 20:49:43 +0000 - rev 477714
Push 113372 by dvarga@mozilla.com at Fri, 07 Jun 2019 10:07:35 +0000
Bug 1550467 - Also install SimpleTest.is into the fission window. r=botond I split this out so it's more obvious what pieces need to be modified to add additional functions. Differential Revision: https://phabricator.services.mozilla.com/D32188
6deee42954a6d02fa1dbcec201abc57c831e46e5: Bug 1550467 - Add a basic browser-mochitest for testing APZ+fission codepaths. r=botond,nika
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 06 Jun 2019 20:49:34 +0000 - rev 477713
Push 113372 by dvarga@mozilla.com at Fri, 07 Jun 2019 10:07:35 +0000
Bug 1550467 - Add a basic browser-mochitest for testing APZ+fission codepaths. r=botond,nika This introduces the framework and helpers needed to do this kind of testing, and adds a basic sanity test that ensures some basic functionality. Differential Revision: https://phabricator.services.mozilla.com/D32187
57a34b090ca9e5b90dc8acfb0c0efa831a5260b5: Bug 1550467 - Ensure that listeners in chrome scripts are cleaned up. r=botond,jmaher
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 06 Jun 2019 20:49:25 +0000 - rev 477712
Push 113372 by dvarga@mozilla.com at Fri, 07 Jun 2019 10:07:35 +0000
Bug 1550467 - Ensure that listeners in chrome scripts are cleaned up. r=botond,jmaher Apparently leaving these listeners registered can leak DOM windows (in some circumstances that I don't fully comprehend) which causes test failures when running on debug builds. At any rate, unregistering listeners on cleanup seems like a good thing to do. Differential Revision: https://phabricator.services.mozilla.com/D32185
e1fab8c9b1aa45f5e4e234dc0a021c48bea9d00b: Bug 1554024 - Mark scroll-restoration-navigation-cross-origin.html FAIL on Android E10S (i.e. GeckoView). r=botond
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Wed, 05 Jun 2019 21:00:58 +0000 - rev 477523
Push 113351 by shindli@mozilla.com at Thu, 06 Jun 2019 10:13:05 +0000
Bug 1554024 - Mark scroll-restoration-navigation-cross-origin.html FAIL on Android E10S (i.e. GeckoView). r=botond The test should work once after we fixed an issue on the interaction between layer-pixel alignment and scrolling APIs in bug 1556685. Differential Revision: https://phabricator.services.mozilla.com/D33610
addbb08ba89df2b34b91f5136a4c06c5ae2d45b4: Bug 1555511 Part 4: Add a test of resizing a document with meta viewport minimum-scale. r=botond
Brad Werth <bwerth@mozilla.com> - Tue, 04 Jun 2019 22:25:12 +0000 - rev 477418
Push 113332 by malexandru@mozilla.com at Wed, 05 Jun 2019 15:57:09 +0000
Bug 1555511 Part 4: Add a test of resizing a document with meta viewport minimum-scale. r=botond Differential Revision: https://phabricator.services.mozilla.com/D33100
794ac0b82ba8606a6785f993a3f74f7ed0c9cecd: Bug 1555511 Part 3: Refactor viewport resize test helper functions. r=botond
Brad Werth <bwerth@mozilla.com> - Tue, 04 Jun 2019 22:25:08 +0000 - rev 477417
Push 113332 by malexandru@mozilla.com at Wed, 05 Jun 2019 15:57:09 +0000
Bug 1555511 Part 3: Refactor viewport resize test helper functions. r=botond Differential Revision: https://phabricator.services.mozilla.com/D33362
872fc290dbdb2398400e75e75e808fe7861f79e1: Bug 1555511 Part 2: Remove a float division in MVM::ScaleZoomWithDisplayWidth. r=botond
Brad Werth <bwerth@mozilla.com> - Tue, 04 Jun 2019 22:25:06 +0000 - rev 477416
Push 113332 by malexandru@mozilla.com at Wed, 05 Jun 2019 15:57:09 +0000
Bug 1555511 Part 2: Remove a float division in MVM::ScaleZoomWithDisplayWidth. r=botond This is a drive-by fix to turn a division into a multiplication. It also is more correct in that the existing code attempts a divide-by-zero if aNewViewport.width is zero. The updated code will instead return a zoom of zero in such a case. Differential Revision: https://phabricator.services.mozilla.com/D32909
9c0c97f11fa42923cfcb90539f6d38e396fd59a7: Bug 1555511 Part 1: Make MVM::UpdateResolution clamp viewport zoom for the new display size later in the calculation. r=botond
Brad Werth <bwerth@mozilla.com> - Tue, 04 Jun 2019 22:23:47 +0000 - rev 477415
Push 113332 by malexandru@mozilla.com at Wed, 05 Jun 2019 15:57:09 +0000
Bug 1555511 Part 1: Make MVM::UpdateResolution clamp viewport zoom for the new display size later in the calculation. r=botond The existing math is attempting to adjust the display scale ratio to prevent the new size from landing outside the min/max zoom bounds. This introduces unwanted side effects that can be avoided by simply clamping to min/max at the end. The remaining math correctly handles the case where the zoom has ALREADY been clamped, which is the only important case. Differential Revision: https://phabricator.services.mozilla.com/D32908
e0cd61fa79ed1971595aaba6124a4ad07448f409: Bug 1555511 Part 4: Add a test of resizing a document with meta viewport minimum-scale. r=botond
Brad Werth <bwerth@mozilla.com> - Tue, 04 Jun 2019 22:25:12 +0000 - rev 477402
Push 113332 by malexandru@mozilla.com at Wed, 05 Jun 2019 15:57:09 +0000
Bug 1555511 Part 4: Add a test of resizing a document with meta viewport minimum-scale. r=botond Differential Revision: https://phabricator.services.mozilla.com/D33100
8c6e5561abed4b92ab1e722bf24a19b2152e3720: Bug 1555511 Part 3: Refactor viewport resize test helper functions. r=botond
Brad Werth <bwerth@mozilla.com> - Tue, 04 Jun 2019 22:25:08 +0000 - rev 477401
Push 113332 by malexandru@mozilla.com at Wed, 05 Jun 2019 15:57:09 +0000
Bug 1555511 Part 3: Refactor viewport resize test helper functions. r=botond Differential Revision: https://phabricator.services.mozilla.com/D33362
2a85e3af81bbe475217ecdf16ce7c5a1a7985a21: Bug 1555511 Part 2: Remove a float division in MVM::ScaleZoomWithDisplayWidth. r=botond
Brad Werth <bwerth@mozilla.com> - Tue, 04 Jun 2019 22:25:06 +0000 - rev 477400
Push 113332 by malexandru@mozilla.com at Wed, 05 Jun 2019 15:57:09 +0000
Bug 1555511 Part 2: Remove a float division in MVM::ScaleZoomWithDisplayWidth. r=botond This is a drive-by fix to turn a division into a multiplication. It also is more correct in that the existing code attempts a divide-by-zero if aNewViewport.width is zero. The updated code will instead return a zoom of zero in such a case. Differential Revision: https://phabricator.services.mozilla.com/D32909
262d2cad64079c343e35b757ac642b231d50e0df: Bug 1555511 Part 1: Make MVM::UpdateResolution clamp viewport zoom for the new display size later in the calculation. r=botond
Brad Werth <bwerth@mozilla.com> - Tue, 04 Jun 2019 22:23:47 +0000 - rev 477399
Push 113332 by malexandru@mozilla.com at Wed, 05 Jun 2019 15:57:09 +0000
Bug 1555511 Part 1: Make MVM::UpdateResolution clamp viewport zoom for the new display size later in the calculation. r=botond The existing math is attempting to adjust the display scale ratio to prevent the new size from landing outside the min/max zoom bounds. This introduces unwanted side effects that can be avoided by simply clamping to min/max at the end. The remaining math correctly handles the case where the zoom has ALREADY been clamped, which is the only important case. Differential Revision: https://phabricator.services.mozilla.com/D32908
80b9b4eb8305f9dcaa35f0a355fbe673712e854d: Bug 1555511 Part 4: Add a test of resizing a document with meta viewport minimum-scale. r=botond
Brad Werth <bwerth@mozilla.com> - Mon, 03 Jun 2019 18:28:54 +0000 - rev 476724
Push 113311 by btara@mozilla.com at Tue, 04 Jun 2019 16:10:59 +0000
Bug 1555511 Part 4: Add a test of resizing a document with meta viewport minimum-scale. r=botond Differential Revision: https://phabricator.services.mozilla.com/D33100
d9ce18a4d7cd4040eb4980de80463d99687358b9: Bug 1555511 Part 3: Refactor viewport resize test helper functions. r=botond
Brad Werth <bwerth@mozilla.com> - Mon, 03 Jun 2019 18:28:42 +0000 - rev 476723
Push 113311 by btara@mozilla.com at Tue, 04 Jun 2019 16:10:59 +0000
Bug 1555511 Part 3: Refactor viewport resize test helper functions. r=botond Differential Revision: https://phabricator.services.mozilla.com/D33362
5e9e587d0622e85434f65976aeebcf69e1bc0543: Bug 1555511 Part 2: Remove a float division in MVM::ScaleZoomWithDisplayWidth. r=botond
Brad Werth <bwerth@mozilla.com> - Mon, 03 Jun 2019 18:28:40 +0000 - rev 476722
Push 113311 by btara@mozilla.com at Tue, 04 Jun 2019 16:10:59 +0000
Bug 1555511 Part 2: Remove a float division in MVM::ScaleZoomWithDisplayWidth. r=botond This is a drive-by fix to turn a division into a multiplication. It also is more correct in that the existing code attempts a divide-by-zero if aNewViewport.width is zero. The updated code will instead return a zoom of zero in such a case. Differential Revision: https://phabricator.services.mozilla.com/D32909
24e136f2746970b4179a7ebc9d14a1d0089f36a3: Bug 1555511 Part 1: Make MVM::UpdateResolution clamp viewport zoom for the new display size later in the calculation. r=botond
Brad Werth <bwerth@mozilla.com> - Mon, 03 Jun 2019 18:28:34 +0000 - rev 476721
Push 113311 by btara@mozilla.com at Tue, 04 Jun 2019 16:10:59 +0000
Bug 1555511 Part 1: Make MVM::UpdateResolution clamp viewport zoom for the new display size later in the calculation. r=botond The existing math is attempting to adjust the display scale ratio to prevent the new size from landing outside the min/max zoom bounds. This introduces unwanted side effects that can be avoided by simply clamping to min/max at the end. The remaining math correctly handles the case where the zoom has ALREADY been clamped, which is the only important case. Differential Revision: https://phabricator.services.mozilla.com/D32908
6988b151bbe73aaa04e07590c45642a14f13bd46: Bug 1555511 Part 4: Add a test of resizing a document with meta viewport minimum-scale. r=botond
Brad Werth <bwerth@mozilla.com> - Fri, 31 May 2019 22:11:46 +0000 - rev 476564
Push 113292 by apavel@mozilla.com at Sun, 02 Jun 2019 22:18:12 +0000
Bug 1555511 Part 4: Add a test of resizing a document with meta viewport minimum-scale. r=botond Differential Revision: https://phabricator.services.mozilla.com/D33100
aa1c32a3878568e74976ebc5d3b219fb1edf2038: Bug 1555511 Part 3: Refactor viewport resize test helper functions. r=botond
Brad Werth <bwerth@mozilla.com> - Fri, 31 May 2019 22:11:24 +0000 - rev 476563
Push 113292 by apavel@mozilla.com at Sun, 02 Jun 2019 22:18:12 +0000
Bug 1555511 Part 3: Refactor viewport resize test helper functions. r=botond Differential Revision: https://phabricator.services.mozilla.com/D33362
999f3af17edf09b54a3c7f2ff77c0bf33d18b4cb: Bug 1555511 Part 2: Remove a float division in MVM::ScaleZoomWithDisplayWidth. r=botond
Brad Werth <bwerth@mozilla.com> - Fri, 31 May 2019 22:10:59 +0000 - rev 476562
Push 113292 by apavel@mozilla.com at Sun, 02 Jun 2019 22:18:12 +0000
Bug 1555511 Part 2: Remove a float division in MVM::ScaleZoomWithDisplayWidth. r=botond This is a drive-by fix to turn a division into a multiplication. It also is more correct in that the existing code attempts a divide-by-zero if aNewViewport.width is zero. The updated code will instead return a zoom of zero in such a case. Differential Revision: https://phabricator.services.mozilla.com/D32909
1069871269f7330450f0ffdc8ade8aacdd4bca29: Bug 1555511 Part 1: Make MVM::UpdateResolution clamp viewport zoom for the new display size later in the calculation. r=botond
Brad Werth <bwerth@mozilla.com> - Fri, 31 May 2019 22:10:28 +0000 - rev 476561
Push 113292 by apavel@mozilla.com at Sun, 02 Jun 2019 22:18:12 +0000
Bug 1555511 Part 1: Make MVM::UpdateResolution clamp viewport zoom for the new display size later in the calculation. r=botond The existing math is attempting to adjust the display scale ratio to prevent the new size from landing outside the min/max zoom bounds. This introduces unwanted side effects that can be avoided by simply clamping to min/max at the end. The remaining math correctly handles the case where the zoom has ALREADY been clamped, which is the only important case. Differential Revision: https://phabricator.services.mozilla.com/D32908
cadc4bdcd75a64e397ef2a30201d5d09b4bcd0b7: Bug 1549504 - Assert that AsyncPanZoomController::mRecursiveMutex is held in Metrics() r=botond
Srujana Peddinti <srujana.htt121@gmail.com> - Wed, 29 May 2019 18:42:03 +0000 - rev 476104
Push 113247 by shindli@mozilla.com at Wed, 29 May 2019 21:58:37 +0000
Bug 1549504 - Assert that AsyncPanZoomController::mRecursiveMutex is held in Metrics() r=botond Moved assertion statement from GetFrameMetrics() to Metrics() so that internal accesses to the frame metrics are covered as well. Differential Revision: https://phabricator.services.mozilla.com/D32300
4b337e189320be82e50efd1fe93d615224e9d4e0: Bug 1496609 Part 1: Add a test of getViewportInfo clamping initial-scale to min-scale. r=botond
Brad Werth <bwerth@mozilla.com> - Fri, 24 May 2019 22:58:45 +0000 - rev 475504
Push 113209 by aciure@mozilla.com at Sat, 25 May 2019 09:44:12 +0000
Bug 1496609 Part 1: Add a test of getViewportInfo clamping initial-scale to min-scale. r=botond Differential Revision: https://phabricator.services.mozilla.com/D32366
f9699ae30f4d5256b6af7c8493e84984aadb4568: Bug 1213601 - Implement kinetic/inertial scrolling (fling) for Gtk touchpads. r=botond,karlt
myfreeweb <greg@unrelenting.technology> - Fri, 24 May 2019 13:31:34 -0400 - rev 475352
Push 113206 by bballo@mozilla.com at Fri, 24 May 2019 17:54:07 +0000
Bug 1213601 - Implement kinetic/inertial scrolling (fling) for Gtk touchpads. r=botond,karlt
e882a5c576abc2c29ae3e3e3c5a27aefa0c2621e: Bug 1553022 - Don't use the given range in ScrollToWithOrigin in the case where scroll snap will happen. r=botond
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Thu, 23 May 2019 10:22:08 +0000 - rev 475184
Push 113196 by aciure@mozilla.com at Thu, 23 May 2019 22:38:40 +0000
Bug 1553022 - Don't use the given range in ScrollToWithOrigin in the case where scroll snap will happen. r=botond ScrollToShowRect calls nsIScrollableFrame::ScrollTo with an nsRange which will be used to constrain the final scroll position so that if snapping needs to happen we need to ignore the given range not to constrain the final destination position in the range. Differential Revision: https://phabricator.services.mozilla.com/D31948
f68ba99112d6ee6bff3813714f869c87ebcf3143: Bug 1553022 - Stop descending down frame tree if we met another scrollable frame when we collect snap positions. r=botond
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Thu, 23 May 2019 10:27:31 +0000 - rev 475183
Push 113196 by aciure@mozilla.com at Thu, 23 May 2019 22:38:40 +0000
Bug 1553022 - Stop descending down frame tree if we met another scrollable frame when we collect snap positions. r=botond From the last sentence of "3. Scroll Snap Model" [1] in the spec; Snap positions only affect the nearest ancestor scroll container on the element's containing block chain. [1] https://drafts.csswg.org/css-scroll-snap-1/#overview Differential Revision: https://phabricator.services.mozilla.com/D31947
d136380e4945c8081a2952760143a0bb1e36df7c: Bug 1553022 - Don't use the given range in ScrollToWithOrigin in the case where scroll snap will happen. r=botond
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Thu, 23 May 2019 09:44:26 +0000 - rev 475177
Push 113196 by aciure@mozilla.com at Thu, 23 May 2019 22:38:40 +0000
Bug 1553022 - Don't use the given range in ScrollToWithOrigin in the case where scroll snap will happen. r=botond ScrollToShowRect calls nsIScrollableFrame::ScrollTo with an nsRange which will be used to constrain the final scroll position so that if snapping needs to happen we need to ignore the given range not to constrain the final destination position in the range. Differential Revision: https://phabricator.services.mozilla.com/D31948
9a556ee9f0398585c6fdf2fe7193907de92e247e: Bug 1553022 - Stop descending down frame tree if we met another scrollable frame when we collect snap positions. r=botond
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Thu, 23 May 2019 09:44:58 +0000 - rev 475176
Push 113196 by aciure@mozilla.com at Thu, 23 May 2019 22:38:40 +0000
Bug 1553022 - Stop descending down frame tree if we met another scrollable frame when we collect snap positions. r=botond From the last sentence of "3. Scroll Snap Model" [1] in the spec; Snap positions only affect the nearest ancestor scroll container on the element's containing block chain. [1] https://drafts.csswg.org/css-scroll-snap-1/#overview Differential Revision: https://phabricator.services.mozilla.com/D31947
4cd6d838796a453f9de5821b2e146f84174badfb: Bug 1550105 - Implement the parser for scale values in viewport meta tag as what the spec defines. r=botond
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Thu, 23 May 2019 06:35:52 +0000 - rev 475150
Push 113193 by dvarga@mozilla.com at Thu, 23 May 2019 16:04:39 +0000
Bug 1550105 - Implement the parser for scale values in viewport meta tag as what the spec defines. r=botond The relevant definition in the spec; https://drafts.csswg.org/css-device-adapt/#min-scale-max-scale Before this change, if both of initial-scale and maximum-scale are negative, both values are clamped to 0.25. Whereas with this change, negative scale values are treated as if it's not specified so that initial-scale value is automatically calculated based on the layout viewport size. negative-initial-and-maximum-scale.html is a test case for the case. Also with this change, initial-scale values are going to be clamped to the range [0.25, 10] during parsing it so that initial-scale-0.html and initial-scale-100.html need to be modified, now the former is scaled by 0.25x, the latter is scaled by 10x. (Before this change, initial-scale=0 and initial-scale=100 were treated as invalid scale values in nsViewportInfo::ConstrainViewportValues[1]) [1] https://searchfox.org/mozilla-central/rev/6c9f60f8cc064a1005cd8141ecd526578ae9da7a/dom/base/nsViewportInfo.cpp#15,19 Differential Revision: https://phabricator.services.mozilla.com/D32098
e773207729a3d9cb87eb19be2b4df7fa1008454d: Bug 1546219 - Rename mScrollSnapType{X,Y} to mScrollSnapStrictness{X,Y}. r=botond
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Wed, 22 May 2019 17:43:34 +0000 - rev 475080
Push 113193 by dvarga@mozilla.com at Thu, 23 May 2019 16:04:39 +0000
Bug 1546219 - Rename mScrollSnapType{X,Y} to mScrollSnapStrictness{X,Y}. r=botond Differential Revision: https://phabricator.services.mozilla.com/D31746
14743da36853e6b1d745418e128030b89bbb6fe2: Bug 1552089 - Don't tweak snapport position even in the case of RTL scroll containers. r=botond
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Fri, 17 May 2019 20:36:57 +0000 - rev 474445
Push 113154 by nerli@mozilla.com at Sun, 19 May 2019 09:30:32 +0000
Bug 1552089 - Don't tweak snapport position even in the case of RTL scroll containers. r=botond In RTL scroll containers, the right most x-axis scroll position is 0 and leftward scroll positions are negative values. And also nsLayoutUtils::TransformFrameRectToAncestor, which is used to tell whether the snap target element is inside the destination snapport or not [1], returns negative x-axis positions for elements in RTL scroll containers if the element is positioned at places where the elements are outside of the initial scroll position (0, 0). So we don't need to tweak snapport postion even in the case of RTL scroll containers. Instead, what we needed in the first place is that we choose a proper x-axis scroll position that the targe element appears inside the snapport. [1] https://searchfox.org/mozilla-central/rev/11cfa0462a6b5d8c5e2111b8cfddcf78098f0141/layout/generic/nsGfxScrollFrame.cpp#6604-6605,6616-6617 Depends on D31409 Differential Revision: https://phabricator.services.mozilla.com/D31410
ef3c6d8bb498bfdae4c53cc9eec12f70bb9284ed: Bug 1551806 - Don't try to snap if there is no valid snap positions for the scroll-snap v1 implementation. r=botond
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Fri, 17 May 2019 20:50:24 +0000 - rev 474444
Push 113154 by nerli@mozilla.com at Sun, 19 May 2019 09:30:32 +0000
Bug 1551806 - Don't try to snap if there is no valid snap positions for the scroll-snap v1 implementation. r=botond From the spec [1]; If a valid snap position exists then the scroll container must snap at the termination of a scroll (if none exist then no snapping occurs). Both of test cases in this commit fail without this change. [1] https://drafts.csswg.org/css-scroll-snap-1/#valdef-scroll-snap-type-mandatory Differential Revision: https://phabricator.services.mozilla.com/D31409
c0a07a2c5d0263b35ceb271c668a41256b959630: Bug 1550510 - Stop hoisting scrollinfo items inside filters when WR is enabled. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Sat, 18 May 2019 00:17:50 +0000 - rev 474413
Push 113152 by dluca@mozilla.com at Sat, 18 May 2019 10:33:03 +0000
Bug 1550510 - Stop hoisting scrollinfo items inside filters when WR is enabled. r=botond In bug 1527182 we made it so that APZ can directly drag-scroll scrollframes that are inside SVG effects, because that's possible with WR on the compositor. However the code changed in that bug was meant to be kept in sync with a second piece of code. The second piece of code controls the generation of ScrollInfo items for scrollframes inside SVG effects - since we can APZ-scroll them with WR, we don't need the scrollinfo item anymore. Producing the scrollinfo item was changing the structure of the APZ tree in terms of where the transform ended up, and was causing badness with untransforming the drag mouse events. This patch adds a test that covers the scenario and also corrects the defect by bringing the two bits of code back in sync. Differential Revision: https://phabricator.services.mozilla.com/D31647
0eff48265098e8bac99128577b2baccde799611e: Bug 1548896 Part 1: Prevent MobileViewportManager::GetCompositionSize from returning negative sizes. r=botond
Brad Werth <bwerth@mozilla.com> - Mon, 13 May 2019 17:26:34 +0000 - rev 473674
Push 113102 by apavel@mozilla.com at Tue, 14 May 2019 04:24:11 +0000
Bug 1548896 Part 1: Prevent MobileViewportManager::GetCompositionSize from returning negative sizes. r=botond Differential Revision: https://phabricator.services.mozilla.com/D30736
220720dbc492807edbcc203d1dab95b632ec4a00: Bug 1549206. Fix the Eclipse CDT index deletion glob pattern to only match the project name. r=botond
Jonathan Watt <jwatt@jwatt.org> - Tue, 23 Apr 2019 09:37:09 +0100 - rev 473029
Push 113061 by jwatt@jwatt.org at Wed, 08 May 2019 15:29:01 +0000
Bug 1549206. Fix the Eclipse CDT index deletion glob pattern to only match the project name. r=botond Differential Revision: https://phabricator.services.mozilla.com/D30281
7748746bf2feda8edd0cabfdaff88b7faf059ad5: Bug 1548568 - Cleanup to remove unused guid parameter in callback. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Mon, 06 May 2019 22:14:40 +0000 - rev 472835
Push 113048 by shindli@mozilla.com at Tue, 07 May 2019 09:56:38 +0000
Bug 1548568 - Cleanup to remove unused guid parameter in callback. r=botond Differential Revision: https://phabricator.services.mozilla.com/D29688
a51bea90b88626322cbee00108436736ad09f024: Bug 1548568 - Cleanup to stop passing around a guid when we only need a layers id. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Mon, 06 May 2019 22:14:42 +0000 - rev 472834
Push 113048 by shindli@mozilla.com at Tue, 07 May 2019 09:56:38 +0000
Bug 1548568 - Cleanup to stop passing around a guid when we only need a layers id. r=botond Differential Revision: https://phabricator.services.mozilla.com/D29687
b7d27dc874dfc46fcd4455bd4ad2ccddf3e5e754: Bug 1548568 - Cleanup to remove unused guid parameter in callback. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Mon, 06 May 2019 21:03:55 +0000 - rev 472791
Push 113048 by shindli@mozilla.com at Tue, 07 May 2019 09:56:38 +0000
Bug 1548568 - Cleanup to remove unused guid parameter in callback. r=botond Differential Revision: https://phabricator.services.mozilla.com/D29688
dadb3b3dad5f2906d88dbf6661e1edb9514c0c91: Bug 1548568 - Cleanup to stop passing around a guid when we only need a layers id. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Mon, 06 May 2019 21:03:49 +0000 - rev 472790
Push 113048 by shindli@mozilla.com at Tue, 07 May 2019 09:56:38 +0000
Bug 1548568 - Cleanup to stop passing around a guid when we only need a layers id. r=botond Differential Revision: https://phabricator.services.mozilla.com/D29687
c705a64ce83c3e320529baf9527e7060ff2c7bcd: Bug 1062609 - Make scroll-behaviour test work with APZ enabled. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Mon, 06 May 2019 17:50:14 +0000 - rev 472755
Push 113048 by shindli@mozilla.com at Tue, 07 May 2019 09:56:38 +0000
Bug 1062609 - Make scroll-behaviour test work with APZ enabled. r=botond The test itself is reasonable, except that it reads scroll positions from the main thread. With APZ enabled we need to flush any pending APZ repaints before reading these scroll positions. So changing the waitForAllPaints to the APZ-flushing variant makes that happen, and the test passes. Depends on D29921 Differential Revision: https://phabricator.services.mozilla.com/D29922
dc4761caa7d426bfcb76dfff7844129f13854ad9: Bug 1062609 - Ensure that APZCTreeManager::GetFrameTime respects the test sample time. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Mon, 06 May 2019 17:48:54 +0000 - rev 472754
Push 113048 by shindli@mozilla.com at Tue, 07 May 2019 09:56:38 +0000
Bug 1062609 - Ensure that APZCTreeManager::GetFrameTime respects the test sample time. r=botond Differential Revision: https://phabricator.services.mozilla.com/D29921
5cb37293574991dc095d46f7bea8fadb08dbfe91: Bug 1549206. Fix Eclipse CDT project generation to automatically run the indexer on first run. r=botond
Jonathan Watt <jwatt@jwatt.org> - Sun, 21 Apr 2019 15:59:31 +0100 - rev 472610
Push 113029 by jwatt@jwatt.org at Sun, 05 May 2019 22:33:01 +0000
Bug 1549206. Fix Eclipse CDT project generation to automatically run the indexer on first run. r=botond Differential Revision: https://phabricator.services.mozilla.com/D29965
b758384a42e27280c1b11f2a60ff2a378949583e: Bug 1477832 - Acquire AsyncPanZoomController::mRecursiveMutex in more places to make sure it's held whenever Metrics() is accessed. r=botond
Srujana Peddinti <srujana.htt121@gmail.com> - Fri, 26 Apr 2019 18:57:48 -0400 - rev 472403
Push 113005 by bballo@mozilla.com at Fri, 03 May 2019 04:36:15 +0000
Bug 1477832 - Acquire AsyncPanZoomController::mRecursiveMutex in more places to make sure it's held whenever Metrics() is accessed. r=botond Differential Revision: https://phabricator.services.mozilla.com/D29084
9b357ff266758e6826c3addf13916697b8f131be: Bug 1538681 Part 2: Add a perma-fail test that scrollbars appear in proper location after resizing viewport. r=botond,gl
Brad Werth <bwerth@mozilla.com> - Mon, 29 Apr 2019 17:54:52 +0000 - rev 471783
Push 112948 by shindli@mozilla.com at Mon, 29 Apr 2019 21:58:23 +0000
Bug 1538681 Part 2: Add a perma-fail test that scrollbars appear in proper location after resizing viewport. r=botond,gl The test is marked as perma-fail because there are complications with getting RDM and WindowSnapshot.js to work together. 4 approaches are discussed in the test itself, and one is attempted, which perma-fails. The approach that is attempted is the most likely to be turned into an unexpected pass in the future, so the test is being added as perma-fail. Differential Revision: https://phabricator.services.mozilla.com/D28900