searching for reviewer(botond)
8921129925a8621b6a6ce593be136c8a98aac421: Bug 1585806 - Make SideBits an enum class, add casting where necessary. r=botond
James Hooks <james.hooks@mail.utoronto.ca> - Sat, 16 Nov 2019 20:59:34 +0000 - rev 502326
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1585806 - Make SideBits an enum class, add casting where necessary. r=botond Differential Revision: https://phabricator.services.mozilla.com/D51291
828246fa2bdf81639ca22092cb330e2473c1d4e8: Bug 1586144 - Expand the FrameMetrics.mLayoutViewport to the size for viewport units. r=botond
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Thu, 14 Nov 2019 06:00:42 +0000 - rev 501891
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1586144 - Expand the FrameMetrics.mLayoutViewport to the size for viewport units. r=botond Note that this FrameMetrics.mLayoutViewport doesn't represent exact size of the layout viewport on the main thread, it means the maximum layout viewport in future on the compositor thread once after the dynamic toolbar is completely hidden. During the dynamic toolbar transition we don't update any information on the main thread, which means it's possible that the visual viewport on the compositor gets bigger than the layout viewport at the time when we send it to the compositor thread, we have to avoid the situation. Depends on D50419 Differential Revision: https://phabricator.services.mozilla.com/D50420
1f6692cbcebad058f1c4d322e3306314e5d534eb: Bug 1586144 - Expand the clipt rect for visual viewport scrollable display item. r=botond
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Thu, 14 Nov 2019 06:00:25 +0000 - rev 501890
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1586144 - Expand the clipt rect for visual viewport scrollable display item. r=botond Without this change, the junit test in this commit fail, the failure rendered result is the area of the position:fixed element covered by the dynamic toolbar before scrolling is rendered as blank. Depends on D50418 Differential Revision: https://phabricator.services.mozilla.com/D50419
9f96406e2da19b6d4e9f89163ff51c4e529779ae: Bug 1586144 - Factor dynamic toolbar max height into layout metrics. r=emilio,botond
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Thu, 14 Nov 2019 06:00:05 +0000 - rev 501889
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1586144 - Factor dynamic toolbar max height into layout metrics. r=emilio,botond Now * nsPresContext::mVisibleArea is excluding the toolbar max height so that ICB is now static regardless of the dynamic toolbar transition * nsPresContext::mSizeForViewportUnits is introduced to resolve viewport units which is including the toolbar max height That means that with the dynamic toolbar max height; mVisibleArea < mSizeForViewportUnits See https://github.com/bokand/URLBarSizing for more detail backgrounds of this change. Depends on D50417 Differential Revision: https://phabricator.services.mozilla.com/D50418
9087a6d0879514755548085bf9228f600205f7e3: Bug 1586144 - Drop m{Start,Last}Dist in android/nsWindow.h. r=botond
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Thu, 14 Nov 2019 04:05:18 +0000 - rev 501887
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1586144 - Drop m{Start,Last}Dist in android/nsWindow.h. r=botond It's not used in the first place. Differential Revision: https://phabricator.services.mozilla.com/D50416
47865c3e9794bdb4840dd31f2e5374c1f2c5fd57: Bug 1526268 Part 3 - Disable APZ if AccessibleCaret is in position:fixed subtree or its position is changed. r=botond,mats
Ting-Yu Lin <tlin@mozilla.com> - Sat, 02 Nov 2019 03:05:28 +0000 - rev 500280
Push 114164 by aiakab@mozilla.com at Tue, 05 Nov 2019 10:06:15 +0000
Bug 1526268 Part 3 - Disable APZ if AccessibleCaret is in position:fixed subtree or its position is changed. r=botond,mats In common cases where the caret is in a position:static frame subtree, the caret's position (relative to canvas frame's custom content container) should not be changed during scrolling. However, when the caret is in a position:fixed or "stuck" position:sticky frame subtree, the caret's position will change during scrolling. We need to disable APZ to avoid jumpy carets. Differential Revision: https://phabricator.services.mozilla.com/D51351
59f69f1b19d75eff298280f4269d504c465e94e0: Bug 1533918 - Disallow CrossProcessMutex when sandboxing is enabled. r=botond
Gian-Carlo Pascutto <gcp@mozilla.com> - Wed, 30 Oct 2019 17:59:15 +0000 - rev 500017
Push 114164 by aiakab@mozilla.com at Tue, 05 Nov 2019 10:06:15 +0000
Bug 1533918 - Disallow CrossProcessMutex when sandboxing is enabled. r=botond Differential Revision: https://phabricator.services.mozilla.com/D50941
1ec2654d55f86ce7a8677591d25c560a6fd46535: Bug 1561227 Part 8: Update expectations for existing tests. r=botond
Brad Werth <bwerth@mozilla.com> - Sat, 26 Oct 2019 15:31:11 +0000 - rev 499367
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1561227 Part 8: Update expectations for existing tests. r=botond The change to await snapshotWindow is something that should have been done in Bug 1573254. Differential Revision: https://phabricator.services.mozilla.com/D47510
068b231e041acb9802e3d128e6b6d7f81566fc91: Bug 1561227 Part 7: Add a test of meta viewport resizing with full zoom. r=botond
Brad Werth <bwerth@mozilla.com> - Fri, 25 Oct 2019 21:05:50 +0000 - rev 499366
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1561227 Part 7: Add a test of meta viewport resizing with full zoom. r=botond Differential Revision: https://phabricator.services.mozilla.com/D44504
855980cca497c2f945aef338528c1f9ee041d51a: Bug 1561227 Part 6: Rename an existing RDM zoom test in anticipation of adding related tests. r=botond
Brad Werth <bwerth@mozilla.com> - Fri, 25 Oct 2019 21:05:52 +0000 - rev 499365
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1561227 Part 6: Rename an existing RDM zoom test in anticipation of adding related tests. r=botond Differential Revision: https://phabricator.services.mozilla.com/D44503
99fce0ce537537a9128d0d63970a9bea6dc0198f: Bug 1561227 Part 5: Define a helper function for setting RDM zoom and use it in existing tests. r=botond
Brad Werth <bwerth@mozilla.com> - Fri, 25 Oct 2019 21:05:46 +0000 - rev 499364
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1561227 Part 5: Define a helper function for setting RDM zoom and use it in existing tests. r=botond This helper function awaits the new custom event sent by the RDM pane frame script when zooming is done, then waits for the reflow to be complete also. After this is done, resolution and window and content sizes all have their correct, final values. Differential Revision: https://phabricator.services.mozilla.com/D47366
0d1ad0f881d163541c3d01bc0ddc3b89c8a48dc2: Bug 1561227 Part 2: Define and fire an internal event when BrowserChild has finished resizing. r=botond,emilio
Brad Werth <bwerth@mozilla.com> - Fri, 25 Oct 2019 21:05:48 +0000 - rev 499361
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1561227 Part 2: Define and fire an internal event when BrowserChild has finished resizing. r=botond,emilio This event is useful for tests that resize the RDM pane and need to know when all resolution adjusting effects are complete. Differential Revision: https://phabricator.services.mozilla.com/D47364
aa00b1b62ea7c8eae81c69443c9677460a0746e8: Bug 1561227 Part 8: Update expectations for existing tests. r=botond
Brad Werth <bwerth@mozilla.com> - Fri, 25 Oct 2019 19:33:55 +0000 - rev 499317
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1561227 Part 8: Update expectations for existing tests. r=botond The change to await snapshotWindow is something that should have been done in Bug 1573254. Differential Revision: https://phabricator.services.mozilla.com/D47510
b22440a67078ea9d3f69c09b0d53d3c041ab1c27: Bug 1561227 Part 7: Add a test of meta viewport resizing with full zoom. r=botond
Brad Werth <bwerth@mozilla.com> - Thu, 24 Oct 2019 23:43:00 +0000 - rev 499316
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1561227 Part 7: Add a test of meta viewport resizing with full zoom. r=botond Differential Revision: https://phabricator.services.mozilla.com/D44504
4776cec83ae857fc90fd0ed4381ee1ac883e64ca: Bug 1561227 Part 6: Rename an existing RDM zoom test in anticipation of adding related tests. r=botond
Brad Werth <bwerth@mozilla.com> - Thu, 24 Oct 2019 23:43:02 +0000 - rev 499315
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1561227 Part 6: Rename an existing RDM zoom test in anticipation of adding related tests. r=botond Differential Revision: https://phabricator.services.mozilla.com/D44503
ac88bbefb95f63a692ea2859eb5287aa5aa2b576: Bug 1561227 Part 5: Define a helper function for setting RDM zoom and use it in existing tests. r=botond
Brad Werth <bwerth@mozilla.com> - Thu, 24 Oct 2019 23:42:58 +0000 - rev 499314
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1561227 Part 5: Define a helper function for setting RDM zoom and use it in existing tests. r=botond This helper function awaits the new custom event sent by the RDM pane frame script when zooming is done, then waits for the reflow to be complete also. After this is done, resolution and window and content sizes all have their correct, final values. Differential Revision: https://phabricator.services.mozilla.com/D47366
cfcf797940499df388b85b0000acf6ef2e1969b4: Bug 1561227 Part 2: Define and fire an internal event when BrowserChild has finished resizing. r=botond,emilio
Brad Werth <bwerth@mozilla.com> - Thu, 24 Oct 2019 23:42:52 +0000 - rev 499311
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1561227 Part 2: Define and fire an internal event when BrowserChild has finished resizing. r=botond,emilio This event is useful for tests that resize the RDM pane and need to know when all resolution adjusting effects are complete. Differential Revision: https://phabricator.services.mozilla.com/D47364
fe035a7f97c942a31aa820709a0cc0b64fd8fd11: Bug 1588860 - update update-the-rendering.html expectancies r=botond,emilio
Andreea Pavel <apavel@mozilla.com> - Fri, 25 Oct 2019 18:09:53 +0000 - rev 499294
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1588860 - update update-the-rendering.html expectancies r=botond,emilio Differential Revision: https://phabricator.services.mozilla.com/D50217
8117cafb3a205311137ee2a294765fed2a4ed967: Bug 1561227 Part 8: Update expectations for existing tests. r=botond
Brad Werth <bwerth@mozilla.com> - Thu, 24 Oct 2019 16:50:53 +0000 - rev 499159
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1561227 Part 8: Update expectations for existing tests. r=botond The change to await snapshotWindow is something that should have been done in Bug 1573254. Differential Revision: https://phabricator.services.mozilla.com/D47510
635534927ffca1e326871f2f52c0b4800fafb2b1: Bug 1561227 Part 7: Add a test of meta viewport resizing with full zoom. r=botond
Brad Werth <bwerth@mozilla.com> - Thu, 24 Oct 2019 16:50:31 +0000 - rev 499158
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1561227 Part 7: Add a test of meta viewport resizing with full zoom. r=botond Differential Revision: https://phabricator.services.mozilla.com/D44504
693b0dd88f2b1f2c98eeaaffa855226d70393bc2: Bug 1561227 Part 6: Rename an existing RDM zoom test in anticipation of adding related tests. r=botond
Brad Werth <bwerth@mozilla.com> - Thu, 24 Oct 2019 16:50:09 +0000 - rev 499157
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1561227 Part 6: Rename an existing RDM zoom test in anticipation of adding related tests. r=botond Differential Revision: https://phabricator.services.mozilla.com/D44503
257bc09f49af49cb8a7653e14fb5310f736bac65: Bug 1561227 Part 5: Define a helper function for setting RDM zoom and use it in existing tests. r=botond
Brad Werth <bwerth@mozilla.com> - Thu, 24 Oct 2019 16:49:46 +0000 - rev 499156
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1561227 Part 5: Define a helper function for setting RDM zoom and use it in existing tests. r=botond This helper function awaits the new custom event sent by the RDM pane frame script when zooming is done, then waits for the reflow to be complete also. After this is done, resolution and window and content sizes all have their correct, final values. Differential Revision: https://phabricator.services.mozilla.com/D47366
f8b8e593316fe9f39ae4fabc72c0308000824582: Bug 1561227 Part 2: Define and fire an internal event when BrowserChild has finished resizing. r=botond,emilio
Brad Werth <bwerth@mozilla.com> - Thu, 24 Oct 2019 16:48:40 +0000 - rev 499153
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1561227 Part 2: Define and fire an internal event when BrowserChild has finished resizing. r=botond,emilio This event is useful for tests that resize the RDM pane and need to know when all resolution adjusting effects are complete. Differential Revision: https://phabricator.services.mozilla.com/D47364
91756881b7abd409a7350d6880118f0141427b66: Bug 1590551. Allow nsPresContext::GetNearestWidget to work when there is no frame tree. r=botond
Timothy Nikkel <tnikkel@gmail.com> - Wed, 23 Oct 2019 23:37:11 +0000 - rev 498787
Push 114159 by shindli@mozilla.com at Thu, 24 Oct 2019 09:49:00 +0000
Bug 1590551. Allow nsPresContext::GetNearestWidget to work when there is no frame tree. r=botond Differential Revision: https://phabricator.services.mozilla.com/D50135
efc0d1eb94e37a941c4edb2a41a169ca23fa4837: Bug 1571599 - Enable layout.viewport_contains_no_contents_area on all channels. r=botond
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Wed, 23 Oct 2019 16:53:51 +0000 - rev 498772
Push 114159 by shindli@mozilla.com at Thu, 24 Oct 2019 09:49:00 +0000
Bug 1571599 - Enable layout.viewport_contains_no_contents_area on all channels. r=botond Differential Revision: https://phabricator.services.mozilla.com/D50142
eaa08674df893d1e057112fb9bf4a38c05d7a9d2: Bug 1589327 - Remove some other various fennec-dependent code. r=snorp,botond
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 18 Oct 2019 18:49:49 +0000 - rev 498251
Push 114157 by nbeleuzu@mozilla.com at Mon, 21 Oct 2019 22:00:13 +0000
Bug 1589327 - Remove some other various fennec-dependent code. r=snorp,botond Some of this may be able to be cleaned up further. Differential Revision: https://phabricator.services.mozilla.com/D49587
2d6b09a782bb7e2523b41d0c829c382140d74907: Bug 1588675 - Use nsPresContext::IsRootContentDocumentCrossProcess instead of IsRootContentDocument for places where we call nsLayoutUtils::ComputeScrollMetadata. r=botond
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Wed, 16 Oct 2019 21:34:45 +0000 - rev 497917
Push 114154 by btara@mozilla.com at Thu, 17 Oct 2019 09:58:40 +0000
Bug 1588675 - Use nsPresContext::IsRootContentDocumentCrossProcess instead of IsRootContentDocument for places where we call nsLayoutUtils::ComputeScrollMetadata. r=botond Differential Revision: https://phabricator.services.mozilla.com/D49272
263936aecc1dcd15f9dadbf4e41f7e7eebad29a6: Bug 1308286. Consider sticky frames that are acting like fixed position frames when determining page scroll amount. r=botond
Timothy Nikkel <tnikkel@gmail.com> - Wed, 09 Oct 2019 23:51:05 +0000 - rev 497063
Push 114147 by ccoroiu@mozilla.com at Thu, 10 Oct 2019 09:56:56 +0000
Bug 1308286. Consider sticky frames that are acting like fixed position frames when determining page scroll amount. r=botond Differential Revision: https://phabricator.services.mozilla.com/D48618
7bb758a5b7a08fee302a971fffef1ba2b5a0123f: Bug 1569744 - Ensure that lock is held even with smooth scrolling disabled. r=botond
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 06 Oct 2019 01:36:05 +0000 - rev 496453
Push 114143 by rgurzau@mozilla.com at Mon, 07 Oct 2019 09:35:08 +0000
Bug 1569744 - Ensure that lock is held even with smooth scrolling disabled. r=botond See comment 5 in the bug for the diagnostic. Differential Revision: https://phabricator.services.mozilla.com/D48254
c10147827a4f8bfcdc1174a609e3a083c8ee4333: Bug 1585317 - When using the scrollport, account for scroll-padding for anchor node selection. r=botond
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 02 Oct 2019 17:24:25 +0000 - rev 496080
Push 114141 by rmaries@mozilla.com at Thu, 03 Oct 2019 09:42:28 +0000
Bug 1585317 - When using the scrollport, account for scroll-padding for anchor node selection. r=botond Unclear whether the visual viewport code path is the right thing to do at all. Differential Revision: https://phabricator.services.mozilla.com/D47791
ab74e2147c5c1761ac324bbdf993d6aa0891ca96: Bug 1551659 - Remove MVMContext::ResizeEventFlag and related code. r=botond,hiro
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 25 Sep 2019 19:35:29 +0000 - rev 494971
Push 114131 by dluca@mozilla.com at Thu, 26 Sep 2019 09:47:34 +0000
Bug 1551659 - Remove MVMContext::ResizeEventFlag and related code. r=botond,hiro D46944 / bug 1583534 is what fixes the root cause of bug 1528052 by not having the first call to ResizeReflow have a wrong old size of 0x0. This removes the code that bug introduces to suppress resize events, which fixes this bug. I think our behavior now is pretty sane. In particular, consider the test-case: <!doctype html> <meta name="viewport" content="width=device-width, initial-scale=1.0"> <a href="" target="_blank">Open me in a separate tab</a> <pre id="log"></pre> <script> // This shouldn't be needed, but otherwise Fenix doesn't show the tooltip on // longpress... document.querySelector("a").href = location.href; function logSize() { log.innerText += window.innerWidth + "x" + window.innerHeight + "\n"; } logSize(); onresize = logSize; </script> (Hosted at https://crisal.io/tmp/gecko-mobile-resize.html for convenience) Right now on trunk, when you click the link from GVE or Fenix, we're only getting an initial size of 0x0 (which is not great, btw), and only after first paint we get the real device size, but content doesn't get a resize event. This is obviously wrong, every time the layout viewport changes we should fire resize events. Pages that get opened in new tabs and get refreshed when resized may get an extra reload with this approach, but this seems not avoidable unless widget sets the viewport size right in advance (which from discussion with snorp and agi doesn't seem possible in the general case). What used to happen is that we were triggering a redundant resize reflow from the initial paint which didn't update the layout viewport (because the content viewer and co had the right viewport from the previous navigation). Now that we optimize those away, I think our behavior should be correct. Differential Revision: https://phabricator.services.mozilla.com/D46956
a7180808eaaeb815467d7794477f69a71b62a93b: Bug 1583534 - Further simplify PresShell::ResizeReflow. r=botond
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 25 Sep 2019 19:12:44 +0000 - rev 494966
Push 114131 by dluca@mozilla.com at Thu, 26 Sep 2019 09:47:34 +0000
Bug 1583534 - Further simplify PresShell::ResizeReflow. r=botond In particular, not let ResizeReflow take the old and new size. Most of the callers pass dummy values anyway. Instead, use the old size of the layout viewport. This ensures we fire resize events only if the layout viewport actually changes. This is important because the first resize of the mobile viewport manager after a navigation has an "old size" of 0x0, even though the layout viewport is initialized on presshell initialization to the right size. Thus, we fire resize events unnecessarily in that case, which is the root cause for bug 1528052. To do this, we need to shuffle a bit of code in nsDocumentViewer that deals with delayed resizes, to set the visible area _and_ invalidate layout, rather than setting the visible area and _then_ relying on doing a resize reflow. Further cleanup is possible, though not required for my android resizing fix, so will do separately. Differential Revision: https://phabricator.services.mozilla.com/D46944
7821ada49c6b317bd2bf8c76c4d028b2bea4c409: Bug 1557411 - Add GeckoView API to expose how touch events are handled. r=geckoview-reviewers,botond,agi
James Willcox <snorp@snorp.net> - Mon, 23 Sep 2019 21:00:44 +0000 - rev 494578
Push 114123 by csabou@mozilla.com at Tue, 24 Sep 2019 03:53:15 +0000
Bug 1557411 - Add GeckoView API to expose how touch events are handled. r=geckoview-reviewers,botond,agi Differential Revision: https://phabricator.services.mozilla.com/D46601
ca9a4f2cd50d85ae568f94478b53709a6fc7bfa0: Bug 1582918. Make sure that async-scrollbar* reftests don't pass because they draw nothing. r=botond
Timothy Nikkel <tnikkel@gmail.com> - Mon, 23 Sep 2019 14:58:46 +0000 - rev 494550
Push 114123 by csabou@mozilla.com at Tue, 24 Sep 2019 03:53:15 +0000
Bug 1582918. Make sure that async-scrollbar* reftests don't pass because they draw nothing. r=botond Differential Revision: https://phabricator.services.mozilla.com/D46699
7099f0e6f0fbc7717ccfb4d9e415f446a37cbed1: Bug 1582585 - Test autoscroll for scrollable and non-scrollable iframes. r=botond
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 23 Sep 2019 16:32:47 +0000 - rev 494525
Push 114122 by csabou@mozilla.com at Mon, 23 Sep 2019 21:59:47 +0000
Bug 1582585 - Test autoscroll for scrollable and non-scrollable iframes. r=botond Differential Revision: https://phabricator.services.mozilla.com/D46733
47a831cbcebe9588507e42df296376898725c665: Bug 1582585 - Make AutoScrollController not scroll non-scrollable windows. r=botond
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 23 Sep 2019 16:05:11 +0000 - rev 494524
Push 114122 by csabou@mozilla.com at Mon, 23 Sep 2019 21:59:47 +0000
Bug 1582585 - Make AutoScrollController not scroll non-scrollable windows. r=botond That is, avoid scrolling <iframe>s that have scrolling="no", for example. Differential Revision: https://phabricator.services.mozilla.com/D46731
8b0a53915fcbcb9a16b094be89c38d19ac82f34e: Bug 1582585 - Factor out a bit more code from AutoScrollController.jsm. r=botond
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 23 Sep 2019 15:54:19 +0000 - rev 494523
Push 114122 by csabou@mozilla.com at Mon, 23 Sep 2019 21:59:47 +0000
Bug 1582585 - Factor out a bit more code from AutoScrollController.jsm. r=botond Also an idempotent change. Differential Revision: https://phabricator.services.mozilla.com/D46730
523ac2d790f3bca3c259d26a6d7eef1da95ae988: Bug 1582585 - Use flattenedTreeParentNode in AutoScrollController.jsm. r=botond
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 23 Sep 2019 15:52:55 +0000 - rev 494522
Push 114122 by csabou@mozilla.com at Mon, 23 Sep 2019 21:59:47 +0000
Bug 1582585 - Use flattenedTreeParentNode in AutoScrollController.jsm. r=botond This makes it work with both Shadow DOM and XBL. Differential Revision: https://phabricator.services.mozilla.com/D46729
8b208c167f360a8cea77782905736426fba08231: Bug 1582585 - Factor out a bit of the logic in AutoScrollController.jsm. r=botond
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 23 Sep 2019 15:39:48 +0000 - rev 494521
Push 114122 by csabou@mozilla.com at Mon, 23 Sep 2019 21:59:47 +0000
Bug 1582585 - Factor out a bit of the logic in AutoScrollController.jsm. r=botond No behavior change intended. Differential Revision: https://phabricator.services.mozilla.com/D46728
9bb8cf06af1404e514589606da0914f79e64b160: Bug 1582288. Don't get the display port in nsLayoutUtils::SetDisplayPortMargins when we don't need it because we don't have a frame. r=botond
Timothy Nikkel <tnikkel@gmail.com> - Fri, 20 Sep 2019 18:36:30 +0000 - rev 494372
Push 114115 by aiakab@mozilla.com at Sat, 21 Sep 2019 10:09:09 +0000
Bug 1582288. Don't get the display port in nsLayoutUtils::SetDisplayPortMargins when we don't need it because we don't have a frame. r=botond It will generate a warning and is useless as explained in the code comment. Differential Revision: https://phabricator.services.mozilla.com/D46626
8eeddedeedb8fc9ef3594086d0759051b51e8db0: Bug 1577258 - Streamline the shrink-wrapping resize reflow code. r=botond
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 12 Sep 2019 21:27:06 +0000 - rev 492990
Push 114081 by btara@mozilla.com at Fri, 13 Sep 2019 15:49:27 +0000
Bug 1577258 - Streamline the shrink-wrapping resize reflow code. r=botond Now that this code path is on its own, we can write more straight-forward code. Depends on D43799 Differential Revision: https://phabricator.services.mozilla.com/D43800
481dbebe905c483350f618dc146bf77eef90b947: Bug 1541705 - Introduce nsLayoutUtils::FrameIsMostlyScrolledOutOfViewInCrossProcess. r=botond
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Thu, 12 Sep 2019 08:09:09 +0000 - rev 492812
Push 114076 by ncsoregi@mozilla.com at Thu, 12 Sep 2019 15:29:15 +0000
Bug 1541705 - Introduce nsLayoutUtils::FrameIsMostlyScrolledOutOfViewInCrossProcess. r=botond This will be used for accessibility stuff. Differential Revision: https://phabricator.services.mozilla.com/D44422
dd526a39c352e4c18568eefeb631a09ec6150c48: Bug 1541705 - Introduce nsLayoutUtils::FrameIsScrolledOutOfViewInCrossProcess and use it for the check whether animating element is scrolled out of view or not. r=botond,boris
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Thu, 12 Sep 2019 08:08:57 +0000 - rev 492811
Push 114076 by ncsoregi@mozilla.com at Thu, 12 Sep 2019 15:29:15 +0000
Bug 1541705 - Introduce nsLayoutUtils::FrameIsScrolledOutOfViewInCrossProcess and use it for the check whether animating element is scrolled out of view or not. r=botond,boris Differential Revision: https://phabricator.services.mozilla.com/D44421
fb5bcfad4822475c2b90d76d7165674ae259d570: Bug 1541705 - Notify areas of out-of-process subframes from the compositor to the corresponding process. r=botond
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Thu, 12 Sep 2019 08:08:45 +0000 - rev 492810
Push 114076 by ncsoregi@mozilla.com at Thu, 12 Sep 2019 15:29:15 +0000
Bug 1541705 - Notify areas of out-of-process subframes from the compositor to the corresponding process. r=botond Note that the areas are clipped out by all ancestor scroll ports and their coordinate systems are the screen coordinate. So that we can tell arbitrary elements in out-of-process iframes are scrolled out or not with this area and the transform matrix of the iframe on screen coodinate. Differential Revision: https://phabricator.services.mozilla.com/D44420
689df124ac2c843b92dfb647e5ecfc0caa81be99: Bug 1541705 - Introduce remote document rect. r=botond
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Thu, 12 Sep 2019 08:08:32 +0000 - rev 492809
Push 114076 by ncsoregi@mozilla.com at Thu, 12 Sep 2019 15:29:15 +0000
Bug 1541705 - Introduce remote document rect. r=botond The rect will be used for calculating the result of the composition of the remote display item on the compositor. Differential Revision: https://phabricator.services.mozilla.com/D44419
907ee4a0aa61f2ef1dc60e9abb3c21971a00eaa4: Bug 1577258 - early-return for noop resizes. r=botond
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 28 Aug 2019 22:03:26 +0000 - rev 490513
Push 113995 by ccoroiu@mozilla.com at Thu, 29 Aug 2019 04:13:32 +0000
Bug 1577258 - early-return for noop resizes. r=botond This avoids doing wasted work and sending spurious resize events if this case would be hit. In practice, it cannot be hit yet, I think, because callers do check for this and bail out earlier. But there's no assertion to that respect so this shouldn't hurt. Differential Revision: https://phabricator.services.mozilla.com/D43798
92a7cfbc46bae07b1996fd0fc070f1637d27d37f: Bug 1573648 - Use ToFloatAllowTrailingChars for parsing scale values in meta viewport tag. r=botond
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Fri, 16 Aug 2019 22:37:42 +0000 - rev 488629
Push 113914 by nbeleuzu@mozilla.com at Sat, 17 Aug 2019 21:54:15 +0000
Bug 1573648 - Use ToFloatAllowTrailingChars for parsing scale values in meta viewport tag. r=botond From the spec <https://drafts.csswg.org/css-device-adapt/#parsing-algorithm> If a prefix of property-value can be converted to a number using strtod, the value will be that number. The remainder of the string is ignored. Note that nsTSubStrubg::ToInteger() allows trailing characters as it is so that we don't need to modify the width/height parser for meta viewport. Differential Revision: https://phabricator.services.mozilla.com/D42240
f9534a732e48d4b292da4dee06dbeff6586c698e: Bug 1572633 - Remove apz.overscroll.spring_{stiffness,friction}. r=botond
Nicholas Nethercote <nnethercote@mozilla.com> - Fri, 16 Aug 2019 07:28:08 +0000 - rev 488466
Push 113910 by ccoroiu@mozilla.com at Fri, 16 Aug 2019 16:28:54 +0000
Bug 1572633 - Remove apz.overscroll.spring_{stiffness,friction}. r=botond They are unused. Differential Revision: https://phabricator.services.mozilla.com/D41330
77ba426bcfc57ca743dbe6ed640a27ffec0864a7: Bug 1573999 - Add fuzzy-if(Android) to css-ui-invalid/select/select-disabled-fieldset-2.html and remove fuzzy-if(Android) from css-ui-valid/select/select-disabled-fieldset-2.html. r=botond
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Thu, 15 Aug 2019 14:58:51 +0000 - rev 488345
Push 113906 by ncsoregi@mozilla.com at Fri, 16 Aug 2019 04:07:24 +0000
Bug 1573999 - Add fuzzy-if(Android) to css-ui-invalid/select/select-disabled-fieldset-2.html and remove fuzzy-if(Android) from css-ui-valid/select/select-disabled-fieldset-2.html. r=botond The fuzzy-if added in bug 1508177 should have added to the test in css-ui-invalid/ not the test in css-ui-valid/. Differential Revision: https://phabricator.services.mozilla.com/D42072
e3ec23ebfc2d1065967a7b45a89b700c94cfb31f: Bug 1573720 - Convert ui.touch_activation.duration_ms to a static pref. r=botond
Nicholas Nethercote <nnethercote@mozilla.com> - Thu, 15 Aug 2019 05:30:23 +0000 - rev 488188
Push 113904 by ncsoregi@mozilla.com at Thu, 15 Aug 2019 19:41:00 +0000
Bug 1573720 - Convert ui.touch_activation.duration_ms to a static pref. r=botond The commit also adds a missing StaticPrefs_dom.h include for APZEventState.cpp. Differential Revision: https://phabricator.services.mozilla.com/D41915