searching for reviewer(bobowen)
0bc5888755fd271b4053101ce0c58765d3b4e071: Bug 1593793. Move and rename nsPrintData::mBrandName to nsPrintJob::mFallbackDocTitle. r=bobowen
Jonathan Watt <jwatt@jwatt.org> - Mon, 04 Nov 2019 20:02:03 +0000 - rev 500451
Push 114164 by aiakab@mozilla.com at Tue, 05 Nov 2019 10:06:15 +0000
Bug 1593793. Move and rename nsPrintData::mBrandName to nsPrintJob::mFallbackDocTitle. r=bobowen nsPrintData::mBrandName never changes over the lifetime of a Firefox instance. It is wasteful to have nsPrintData obtain and store it, since we can replace an nsPrintJob's nsPrintData object multiple times over the lifetime of the nsPrintJob and nsPrintJob is the only consumer. Differential Revision: https://phabricator.services.mozilla.com/D51689
52c1f2b59d64bb5ffeb8076b2c0fd7475fc1eef5: Bug 1592371 - QueryDosDeviceWHook returns size of lpTargetPath copy on success. r=bobowen
Bryce Seager van Dyk <bvandyk@mozilla.com> - Tue, 29 Oct 2019 19:31:19 +0000 - rev 499670
Push 114163 by aiakab@mozilla.com at Thu, 31 Oct 2019 10:03:38 +0000
Bug 1592371 - QueryDosDeviceWHook returns size of lpTargetPath copy on success. r=bobowen Prior to the patch we appear to be returning the size of lpDeviceName rather than lpTargetPath. Differential Revision: https://phabricator.services.mozilla.com/D50979
e60db9056c2e20464f8dd4f991d8795edaed4dcf: Bug 1570009 - Part 3 : Added GPU Process testing to the framework. r=bobowen
Srujana Peddinti <srujana.htt121@gmail.com> - Mon, 14 Oct 2019 15:26:47 +0000 - rev 497933
Push 114154 by btara@mozilla.com at Thu, 17 Oct 2019 09:58:40 +0000
Bug 1570009 - Part 3 : Added GPU Process testing to the framework. r=bobowen Adds support for creating and using a PSandboxTesting actor in the GPU process. Differential Revision: https://phabricator.services.mozilla.com/D42386
191da9c843802b9f416b76b03bb5e6666c09cc27: Bug 1570009 - Part 2 : Added Content Process testing to the framework. r=bobowen
Srujana Peddinti <srujana.htt121@gmail.com> - Mon, 14 Oct 2019 15:08:47 +0000 - rev 497932
Push 114154 by btara@mozilla.com at Thu, 17 Oct 2019 09:58:40 +0000
Bug 1570009 - Part 2 : Added Content Process testing to the framework. r=bobowen Adds the ability to create and run sandbox tests in a content process. Differential Revision: https://phabricator.services.mozilla.com/D37913
cfc5fac4fbb6db8ff17b3d441723515fc4af3fd9: Bug 1570009 - Part 1: Create a top-level actor in child processes capable of testing the sandbox. r=bobowen,dmajor
Srujana Peddinti <srujana.htt121@gmail.com> - Tue, 15 Oct 2019 07:19:54 +0000 - rev 497931
Push 114154 by btara@mozilla.com at Thu, 17 Oct 2019 09:58:40 +0000
Bug 1570009 - Part 1: Create a top-level actor in child processes capable of testing the sandbox. r=bobowen,dmajor This patch includes a new browser chrome mochitest that uses a new XPCOM service (moxISandboxTest) to create a new top-level actor (PSandboxTesting) between the chrome process and any supported child processes (in later parts of this patch set). The framework is makes it easy to add new C/C++ instructions to be tested for permission under real sandbox conditions. Test results can be conditioned on the type of OS, process, sandbox level, etc. Differential Revision: https://phabricator.services.mozilla.com/D37706
4dd3834214c99e2dcca6c73ca3da42805d9ab91c: Bug 1574571. r=bobowen
Jed Davis <jld@mozilla.com> - Wed, 28 Aug 2019 18:30:43 +0000 - rev 490505
Push 113995 by ccoroiu@mozilla.com at Thu, 29 Aug 2019 04:13:32 +0000
Bug 1574571. r=bobowen Differential Revision: https://phabricator.services.mozilla.com/D43707
25ee714cbf2b80245d0b1e55dc885c59aba4b8a6: Bug 1565744. r=kmag,bobowen
Jed Davis <jld@mozilla.com> - Mon, 05 Aug 2019 14:56:42 +0000 - rev 486614
Push 113849 by aciure@mozilla.com at Wed, 07 Aug 2019 04:39:23 +0000
Bug 1565744. r=kmag,bobowen Differential Revision: https://phabricator.services.mozilla.com/D39380
b60e3b91037e55bef7d779b24773f03ddd847d59: Bug 1566808 - Add STARTF_FORCEOFFFEEDBACK when launching process on windows r=bobowen
Kershaw Chang <kershaw@mozilla.com> - Mon, 29 Jul 2019 14:59:27 +0000 - rev 485133
Push 113797 by ccoroiu@mozilla.com at Mon, 29 Jul 2019 21:45:35 +0000
Bug 1566808 - Add STARTF_FORCEOFFFEEDBACK when launching process on windows r=bobowen Differential Revision: https://phabricator.services.mozilla.com/D39682
8db0868227e62019577296789fea5952810fe7c0: Bug 1563774 - Enable Binary Signature Policy on the RDD process r=bobowen
Tom Ritter <tom@mozilla.com> - Tue, 23 Jul 2019 17:49:55 +0000 - rev 484925
Push 113786 by dvarga@mozilla.com at Sat, 27 Jul 2019 09:34:13 +0000
Bug 1563774 - Enable Binary Signature Policy on the RDD process r=bobowen To do this, we preload the AV libraries. They may not be needed right now, but by doing this now we ensure that future RDD work won't mysteriously fail during development for some poor coworker. Differential Revision: https://phabricator.services.mozilla.com/D37928
a030c27bb1c1b523b16d1b3da70ed1dac1ef0310: Bug 1455996 - Skip mochitest test_marquee_event_handlers.html; r=bobowen
Geoff Brown <gbrown@mozilla.com> - Fri, 05 Jul 2019 12:56:54 +0000 - rev 481465
Push 113615 by malexandru@mozilla.com at Sat, 06 Jul 2019 03:45:59 +0000
Bug 1455996 - Skip mochitest test_marquee_event_handlers.html; r=bobowen Failures are affecting all platforms now. Let's skip the test entirely until you can make it more reliable. Differential Revision: https://phabricator.services.mozilla.com/D37022
62cc1336cd81335ae752cdd386f4213e75cc8f78: Bug 1562111 - Unconditionally include WinUtils.h on Windows. r=bobowen
Dan Glastonbury <dan.glastonbury@gmail.com> - Sat, 29 Jun 2019 08:27:35 +0000 - rev 480709
Push 113563 by apavel@mozilla.com at Sun, 30 Jun 2019 10:04:30 +0000
Bug 1562111 - Unconditionally include WinUtils.h on Windows. r=bobowen Differential Revision: https://phabricator.services.mozilla.com/D36283
496d94e9449892fbed4f6e727b3f438dad9cc795: Bug 1552706 - Update MinGW version and remove MinGW sandbox hacks r=bobowen
Tom Ritter <tom@mozilla.com> - Fri, 28 Jun 2019 09:53:12 +0000 - rev 480600
Push 113558 by shindli@mozilla.com at Fri, 28 Jun 2019 23:24:53 +0000
Bug 1552706 - Update MinGW version and remove MinGW sandbox hacks r=bobowen Differential Revision: https://phabricator.services.mozilla.com/D36218
95a7d9d33d7b2929980c397f278e672165df5199: Bug 1553249: Only set the Win32k disable policy for the RDD process when running on Win8+; r=bobowen
Aaron Klotz <aklotz@mozilla.com> - Fri, 28 Jun 2019 09:44:03 +0000 - rev 480591
Push 113558 by shindli@mozilla.com at Fri, 28 Jun 2019 23:24:53 +0000
Bug 1553249: Only set the Win32k disable policy for the RDD process when running on Win8+; r=bobowen Differential Revision: https://phabricator.services.mozilla.com/D36239
c627801eeecc8bf6100c723b435138b2f47179e8: Bug 1552160 Part 2: Roll-up patch to apply remaining mozilla changes to chromium sandbox. r=tabraldes,aklotz,jimm,bobowen
Bob Owen <bobowencode@gmail.com> - Sat, 29 Nov 2014 17:12:18 +0000 - rev 478293
Push 113417 by bobowencode@gmail.com at Wed, 12 Jun 2019 10:11:11 +0000
Bug 1552160 Part 2: Roll-up patch to apply remaining mozilla changes to chromium sandbox. r=tabraldes,aklotz,jimm,bobowen Patches re-applied from security/sandbox/chromium-shim/patches/after_update/. See patch files for additional commit comments.
370c40e4923073a87845b57c1f4851bacd9663da: Bug 1552160 Part 1: Roll-up of chromium sandbox update and mozilla patches to get a running browser. r=jld,aklotz,tjr,bobowen
Bob Owen <bobowencode@gmail.com> - Wed, 12 Jun 2019 11:10:48 +0100 - rev 478292
Push 113417 by bobowencode@gmail.com at Wed, 12 Jun 2019 10:11:11 +0000
Bug 1552160 Part 1: Roll-up of chromium sandbox update and mozilla patches to get a running browser. r=jld,aklotz,tjr,bobowen This updates security/sandbox/chromium/ files to chromium commit 84108231f6e6e0772fb9a4643679ce76aa771e67. Existing and new patches applied from security/sandbox/chromium-shim/patches/with_update/ to give a compiling and mostly working browser. See patch files for additional commit comments.
39960085afa77bd6a391a86d5eff93a3b351e52a: Bug 1558349. Stop calling SetIsPrintPreview in nsDocumentViewer::PrepareToStartLoad. r=bobowen
Jonathan Watt <jwatt@jwatt.org> - Tue, 04 Jun 2019 22:53:09 +0100 - rev 478290
Push 113415 by jwatt@jwatt.org at Wed, 12 Jun 2019 00:07:39 +0000
Bug 1558349. Stop calling SetIsPrintPreview in nsDocumentViewer::PrepareToStartLoad. r=bobowen This code predates our use of a static clone to print. Nowadays we never navigate in the (dedicated) print preview tab. Differential Revision: https://phabricator.services.mozilla.com/D34433
d4615047a124f93f4350e7ad498a73d22810a8b6: Bug 1558210. Make various nsPrintJob methods private. r=bobowen
Jonathan Watt <jwatt@jwatt.org> - Tue, 04 Jun 2019 17:03:35 +0100 - rev 478024
Push 113398 by jwatt@jwatt.org at Mon, 10 Jun 2019 17:13:05 +0000
Bug 1558210. Make various nsPrintJob methods private. r=bobowen Also removes two unused (not even defined) method declarations. Differential Revision: https://phabricator.services.mozilla.com/D34357
384b5c730c10a9c5a31fa483064130ec06de0585: Bug 1558180. Comment the mysterious OnPageHide() call in nsPrintJob and move it somewhere that makes sense. r=bobowen
Jonathan Watt <jwatt@jwatt.org> - Tue, 04 Jun 2019 16:01:33 +0100 - rev 478021
Push 113395 by jwatt@jwatt.org at Mon, 10 Jun 2019 13:44:56 +0000
Bug 1558180. Comment the mysterious OnPageHide() call in nsPrintJob and move it somewhere that makes sense. r=bobowen Differential Revision: https://phabricator.services.mozilla.com/D34347
b549ba82a1dc3fbc1de89c1af4c0e8218634565b: Bug 1558071. Rename nsIWebBrowserPrint.printPreviewNavigate to printPreviewScrollToPage. r=bobowen
Jonathan Watt <jwatt@jwatt.org> - Mon, 03 Jun 2019 12:48:21 +0100 - rev 478020
Push 113394 by jwatt@jwatt.org at Mon, 10 Jun 2019 13:40:35 +0000
Bug 1558071. Rename nsIWebBrowserPrint.printPreviewNavigate to printPreviewScrollToPage. r=bobowen Differential Revision: https://phabricator.services.mozilla.com/D34297
82b42e15e77e4614306f8c2849898dea65a6f259: Bug 1558072. Inline the nsDocumentViewer::ReturnToGalleyPresentation code to its single caller. r=bobowen
Jonathan Watt <jwatt@jwatt.org> - Mon, 03 Jun 2019 10:10:42 +0100 - rev 478019
Push 113394 by jwatt@jwatt.org at Mon, 10 Jun 2019 13:40:35 +0000
Bug 1558072. Inline the nsDocumentViewer::ReturnToGalleyPresentation code to its single caller. r=bobowen Differential Revision: https://phabricator.services.mozilla.com/D34296
5415ff10fa45eaaaf53e0405b9579adb1244bc92: Bug 1558079. Add a comment to the mozPrintCallback invoking code warning about its non-obvious behavior. r=bobowen
Jonathan Watt <jwatt@jwatt.org> - Fri, 31 May 2019 16:18:51 +0100 - rev 478018
Push 113394 by jwatt@jwatt.org at Mon, 10 Jun 2019 13:40:35 +0000
Bug 1558079. Add a comment to the mozPrintCallback invoking code warning about its non-obvious behavior. r=bobowen Differential Revision: https://phabricator.services.mozilla.com/D34298
5b55f2d60ad734e3f2b597badd74dcc8076f2e9f: Bug 1558067. Prevent mozPrintCallback being invoked with the wrong <canvas> element. r=bobowen
Jonathan Watt <jwatt@jwatt.org> - Fri, 31 May 2019 11:01:33 +0100 - rev 478017
Push 113394 by jwatt@jwatt.org at Mon, 10 Jun 2019 13:40:35 +0000
Bug 1558067. Prevent mozPrintCallback being invoked with the wrong <canvas> element. r=bobowen Since the Firefox print preview code creates a static clone from the existing print preview static clone for any print preview settings changes, for enabling of simplified mode, and for a print from a print preview document, HTMLCanvasElement::CopyInnerTo may be invoked on an existing static clone. In that case, the mozPrintCallback's printState.context.canvas would previously have ended up using the canvas in the previous print preview static clone, which is wrong, and allow the callback to modify the static clone document. Differential Revision: https://phabricator.services.mozilla.com/D34294
8fe09c42467e19c74ad97cc46ee3dec3df08574f: Bug 1558057. Remove nsPrintJob::CleanupDocTitleArray. r=bobowen
Jonathan Watt <jwatt@jwatt.org> - Thu, 30 May 2019 14:03:36 +0100 - rev 478016
Push 113394 by jwatt@jwatt.org at Mon, 10 Jun 2019 13:40:35 +0000
Bug 1558057. Remove nsPrintJob::CleanupDocTitleArray. r=bobowen Differential Revision: https://phabricator.services.mozilla.com/D34289
5db384ff08c5dcb7d35668d97a3c28bbc30797e5: Bug 1557878. Replace nsIWebBrowserPrint::enumerateDocumentNames with a getter for the top document's name. r=bobowen
Jonathan Watt <jwatt@jwatt.org> - Thu, 30 May 2019 11:43:16 +0100 - rev 477990
Push 113390 by jwatt@jwatt.org at Sun, 09 Jun 2019 11:50:07 +0000
Bug 1557878. Replace nsIWebBrowserPrint::enumerateDocumentNames with a getter for the top document's name. r=bobowen Differential Revision: https://phabricator.services.mozilla.com/D34260
b45b36994d2fe506f024ae26eb2f17e73d88dd59: Bug 1557687. Remove nsPrintData::mDocWasToBeDestroyed. r=bobowen
Jonathan Watt <jwatt@jwatt.org> - Wed, 29 May 2019 10:42:14 +0100 - rev 477958
Push 113387 by jwatt@jwatt.org at Sat, 08 Jun 2019 13:56:01 +0000
Bug 1557687. Remove nsPrintData::mDocWasToBeDestroyed. r=bobowen This shows that this variable has never been read going back all the way to the original Mercurial import in 2007: hg grep -f --diff mDocWasToBeDestroyed layout/printing/ns* Differential Revision: https://phabricator.services.mozilla.com/D34143
e5133a9ebb56d38e806418026c2ceb5f8f27c2db: Bug 1557681. Rename nsPrintJob::Cancelled() to Cancel(). r=bobowen
Jonathan Watt <jwatt@jwatt.org> - Wed, 29 May 2019 07:14:46 +0100 - rev 477770
Push 113374 by jwatt@jwatt.org at Fri, 07 Jun 2019 11:50:50 +0000
Bug 1557681. Rename nsPrintJob::Cancelled() to Cancel(). r=bobowen "Cancelled" sounds like it's a query and should return a bool. In fact this method sets state in response to a nsIWebBrowserPrint.cancel() being called. Differential Revision: https://phabricator.services.mozilla.com/D34137
f9d538a3e51701f85f05231b363fb11184d7fdf3: Bug 1557434. Remove nsPrintObject::mPrintPreview. r=bobowen
Jonathan Watt <jwatt@jwatt.org> - Tue, 28 May 2019 15:26:59 +0100 - rev 477769
Push 113374 by jwatt@jwatt.org at Fri, 07 Jun 2019 11:50:50 +0000
Bug 1557434. Remove nsPrintObject::mPrintPreview. r=bobowen Differential Revision: https://phabricator.services.mozilla.com/D34134
f39ff7aa10b3355e70a6d45bbbd74c038a468f40: Bug 1557434. Rename nsPrintJob::BuildDocTree to BuildNestedPrintObjects. r=bobowen
Jonathan Watt <jwatt@jwatt.org> - Tue, 28 May 2019 14:16:49 +0100 - rev 477768
Push 113374 by jwatt@jwatt.org at Fri, 07 Jun 2019 11:50:50 +0000
Bug 1557434. Rename nsPrintJob::BuildDocTree to BuildNestedPrintObjects. r=bobowen The previous splitting of nsPrintObject::Init made clear that in fact this method does not create documents at all! This new name better describes what it does. Differential Revision: https://phabricator.services.mozilla.com/D34118
d5732da1844be4de4558a506046fb716d9da4ec7: Bug 1557434. Split nsPrintObject::Init into separate root-object and nested-object init methods. r=bobowen
Jonathan Watt <jwatt@jwatt.org> - Tue, 28 May 2019 12:48:21 +0100 - rev 477767
Push 113374 by jwatt@jwatt.org at Fri, 07 Jun 2019 11:50:50 +0000
Bug 1557434. Split nsPrintObject::Init into separate root-object and nested-object init methods. r=bobowen Differential Revision: https://phabricator.services.mozilla.com/D34006
4793f9c4f13d2589c9322363bc307ffcac501db5: Bug 1529677 - Move writing of Event type from RecordEvent() into RecordToStream(). r=bobowen
Jeff Muizelaar <jrmuizel@gmail.com> - Thu, 21 Feb 2019 11:23:00 +0000 - rev 477751
Push 113373 by bobowencode@gmail.com at Fri, 07 Jun 2019 11:10:59 +0000
Bug 1529677 - Move writing of Event type from RecordEvent() into RecordToStream(). r=bobowen
b8b9273b3a5c4c48e077194fd701c04eb6a64796: Bug 1557033. Stop using nsIDocShellTreeItem in nsPrintJob. r=bobowen
Jonathan Watt <jwatt@jwatt.org> - Fri, 24 May 2019 10:50:22 +0100 - rev 477573
Push 113359 by jwatt@jwatt.org at Thu, 06 Jun 2019 18:27:19 +0000
Bug 1557033. Stop using nsIDocShellTreeItem in nsPrintJob. r=bobowen Differential Revision: https://phabricator.services.mozilla.com/D33793
94a2d681edb4edaca48c87c059e94db2fba2f954: Bug 1537586 - Address build failure with --disable-printing r=bobowen,froydnj
sotaro <sotaro.ikeda.g@gmail.com> - Wed, 05 Jun 2019 01:25:36 +0000 - rev 477377
Push 113327 by malexandru@mozilla.com at Wed, 05 Jun 2019 10:00:10 +0000
Bug 1537586 - Address build failure with --disable-printing r=bobowen,froydnj Make nsIWebBrowserPrint included unconditionally for addressing nsIDocShell.rs build failure. Remove direct_call of PPrinting and PRemotePrintJob. Their ipdl are built unconditionally, but their derived classes are not built with --disable-printing. Differential Revision: https://phabricator.services.mozilla.com/D33391
784f254cebbcdfab9d4405f87274711b8941f5a7: Bug 1552785. Remove printing related isFramesetDocument and isFramesetFrameSelected code. r=bobowen
Jonathan Watt <jwatt@jwatt.org> - Tue, 21 May 2019 23:25:57 +0100 - rev 476869
Push 113325 by jwatt@jwatt.org at Wed, 05 Jun 2019 09:19:26 +0000
Bug 1552785. Remove printing related isFramesetDocument and isFramesetFrameSelected code. r=bobowen Differential Revision: https://phabricator.services.mozilla.com/D33696
625e654f20a43d0fb7f05997a4315d2632347e6c: Bug 1552785. Remove internal code for various frameset printing behaviors. r=bobowen
Jonathan Watt <jwatt@jwatt.org> - Tue, 21 May 2019 16:01:34 +0100 - rev 476868
Push 113325 by jwatt@jwatt.org at Wed, 05 Jun 2019 09:19:26 +0000
Bug 1552785. Remove internal code for various frameset printing behaviors. r=bobowen Differential Revision: https://phabricator.services.mozilla.com/D33624
a5cb405483b4cd860194fb9afdafe7fe122ed6cd: Bug 1552785. Reduce code duplication in nsPrintJob::EnablePOsForPrinting. r=bobowen
Jonathan Watt <jwatt@jwatt.org> - Mon, 20 May 2019 15:29:01 +0100 - rev 476867
Push 113325 by jwatt@jwatt.org at Wed, 05 Jun 2019 09:19:26 +0000
Bug 1552785. Reduce code duplication in nsPrintJob::EnablePOsForPrinting. r=bobowen Differential Revision: https://phabricator.services.mozilla.com/D33686
618f6a8269ac57d18b6fda1fb68b0dbbbc04d83e: Bug 1552785. Stop using GetHowToEnableFrameUI in nsPrintJob::EnablePOsForPrinting. r=bobowen
Jonathan Watt <jwatt@jwatt.org> - Fri, 17 May 2019 16:38:10 +0100 - rev 476866
Push 113324 by jwatt@jwatt.org at Wed, 05 Jun 2019 09:15:36 +0000
Bug 1552785. Stop using GetHowToEnableFrameUI in nsPrintJob::EnablePOsForPrinting. r=bobowen kFrameEnableNone is synonymous with having a non-frameset document. This makes what is going on here explicit. It also gets rid of the kRangeSelection based override and makes that explicit too. Differential Revision: https://phabricator.services.mozilla.com/D33684
be349ba2725089e6d1019139f5b1845a80917337: Bug 1552785. Stop setting frameset printing behavior for nsIPrintSettings::kRangeSelection. r=bobowen
Jonathan Watt <jwatt@jwatt.org> - Fri, 17 May 2019 14:52:25 +0100 - rev 476865
Push 113324 by jwatt@jwatt.org at Wed, 05 Jun 2019 09:15:36 +0000
Bug 1552785. Stop setting frameset printing behavior for nsIPrintSettings::kRangeSelection. r=bobowen Differential Revision: https://phabricator.services.mozilla.com/D33623
a93db5ac1278f5d97107c41f4933074ccde67c93: Bug 1552785. Remove Windows print dialog UI for selecting frameset behavior. r=bobowen
Jonathan Watt <jwatt@jwatt.org> - Wed, 15 May 2019 10:36:08 +0100 - rev 476863
Push 113323 by jwatt@jwatt.org at Wed, 05 Jun 2019 09:11:26 +0000
Bug 1552785. Remove Windows print dialog UI for selecting frameset behavior. r=bobowen Note that this makes Firefox use the standard system Print dialog as opposed to just removing our "Frames" section from our custom dialog. Differential Revision: https://phabricator.services.mozilla.com/D33389
919893dc7365431d63b09f1603a961e6e5285f20: Bug 1553324. Remove nsIPrintSettings.printFrameTypeUsage. r=bobowen
Jonathan Watt <jwatt@jwatt.org> - Mon, 13 May 2019 16:30:20 +0100 - rev 475057
Push 113191 by jwatt@jwatt.org at Thu, 23 May 2019 15:00:08 +0000
Bug 1553324. Remove nsIPrintSettings.printFrameTypeUsage. r=bobowen Differential Revision: https://phabricator.services.mozilla.com/D32068
1af5cf2905662442515ff17166e79cb3e10e252f: Bug 1553318. Remove nsIPrintSettings.kRangeFocus. r=bobowen
Jonathan Watt <jwatt@jwatt.org> - Mon, 13 May 2019 14:52:25 +0100 - rev 475056
Push 113191 by jwatt@jwatt.org at Thu, 23 May 2019 15:00:08 +0000
Bug 1553318. Remove nsIPrintSettings.kRangeFocus. r=bobowen Differential Revision: https://phabricator.services.mozilla.com/D32064
fbbf969a151c4f0194114822f8f39285e61c8014: Bug 1553081. Set nsPrintJob::mDisallowSelectionPrint during Initialize(). r=bobowen
Jonathan Watt <jwatt@jwatt.org> - Fri, 10 May 2019 16:01:33 +0100 - rev 474828
Push 113172 by jwatt@jwatt.org at Tue, 21 May 2019 22:44:31 +0000
Bug 1553081. Set nsPrintJob::mDisallowSelectionPrint during Initialize(). r=bobowen Differential Revision: https://phabricator.services.mozilla.com/D31975
15f415dac8da4ccc97cc2f24d300345bc43b2d4a: Bug 1553080. Have nsPrintJob record modality and mozPrintCallback presence during initialization. r=bobowen
Jonathan Watt <jwatt@jwatt.org> - Fri, 10 May 2019 14:52:25 +0100 - rev 474827
Push 113172 by jwatt@jwatt.org at Tue, 21 May 2019 22:44:31 +0000
Bug 1553080. Have nsPrintJob record modality and mozPrintCallback presence during initialization. r=bobowen Differential Revision: https://phabricator.services.mozilla.com/D31974
1a5c3aa4d7be85f4bf31179de333147c76101004: Bug 1552969. Pass the document to print through to nsPrintJob::Print. r=bobowen
Jonathan Watt <jwatt@jwatt.org> - Fri, 10 May 2019 09:38:11 +0100 - rev 474826
Push 113172 by jwatt@jwatt.org at Tue, 21 May 2019 22:44:31 +0000
Bug 1552969. Pass the document to print through to nsPrintJob::Print. r=bobowen ...and have nsPrintJob::Print use that instead of mOriginalDoc, which we want to get rid of. When nsPrintJob::Print is called and mPrtPreview is nullptr, we know that we have been called to print a page directly without print preview. In that case we know that we're printing the nsPrintJob's docViewer's document. I.e. the document of the caller of nsPrintJob::Print. So in this case mOriginalDoc and the passed doc are always the same thing. Differential Revision: https://phabricator.services.mozilla.com/D31874
65f1f6d80936cb7557183664b37038d83cda64c1: Bug 1523526 - Don't allow CFG on old releases of Windows for arm64 r=bobowen,aklotz
David Major <dmajor@mozilla.com> - Mon, 20 May 2019 17:25:30 +0000 - rev 474622
Push 113165 by dvarga@mozilla.com at Tue, 21 May 2019 04:23:23 +0000
Bug 1523526 - Don't allow CFG on old releases of Windows for arm64 r=bobowen,aklotz There's a bug in ole32.dll on arm64 versions of Windows prior to 1809, that crashes our content processes if we enable CFG. We've reported the issue, but even if it gets fixed, we can't assume users will have the update. This patch uses process mitigation policy flags to disable CFG on arm64 before 1809. Based on testing, we only need to do this in the sandbox for child processes, and it's not strictly necessary for the launcher stub to set the flag on the main process. But I've included that anyway as a guard against some yet-undiscovered scenario that might hit the issue and make the browser unusable. The effects of this patch won't be visible until we actually enable CFG in a subsequent landing. Differential Revision: https://phabricator.services.mozilla.com/D29474
e8ac4b512f9d03dae670be39b399ea8189e1ca05: Bug 1523526 - Don't allow CFG on old releases of Windows for arm64 r=bobowen,aklotz
David Major <dmajor@mozilla.com> - Tue, 07 May 2019 18:37:13 +0000 - rev 474538
Push 113165 by dvarga@mozilla.com at Tue, 21 May 2019 04:23:23 +0000
Bug 1523526 - Don't allow CFG on old releases of Windows for arm64 r=bobowen,aklotz There's a bug in ole32.dll on arm64 versions of Windows prior to 1809, that crashes our content processes if we enable CFG. We've reported the issue, but even if it gets fixed, we can't assume users will have the update. This patch uses process mitigation policy flags to disable CFG on arm64 before 1809. Based on testing, we only need to do this in the sandbox for child processes, and it's not strictly necessary for the launcher stub to set the flag on the main process. But I've included that anyway as a guard against some yet-undiscovered scenario that might hit the issue and make the browser unusable. The effects of this patch won't be visible until we actually enable CFG in a subsequent landing. Differential Revision: https://phabricator.services.mozilla.com/D29474
a42daaa44f8846936526459b8b97e7206902d4ec: Bug 1552880 p2. Document nsPritJob's Initialize, Print and PrintPreview and rename their document params. r=bobowen
Jonathan Watt <jwatt@jwatt.org> - Thu, 09 May 2019 23:26:59 +0100 - rev 474509
Push 113163 by jwatt@jwatt.org at Mon, 20 May 2019 19:12:59 +0000
Bug 1552880 p2. Document nsPritJob's Initialize, Print and PrintPreview and rename their document params. r=bobowen Differential Revision: https://phabricator.services.mozilla.com/D31812
6030ebc07cd2c5348ba0a2364ca7ad18111cdd22: Bug 1552880 p1. Pass a document to nsPrintJob::PrintPreview instead of a window. r=bobowen
Jonathan Watt <jwatt@jwatt.org> - Thu, 09 May 2019 10:40:12 +0100 - rev 474508
Push 113163 by jwatt@jwatt.org at Mon, 20 May 2019 19:12:59 +0000
Bug 1552880 p1. Pass a document to nsPrintJob::PrintPreview instead of a window. r=bobowen This stops nsPrintJob::PrintPreview from duplicating work done in nsDocumentViewer::PrintPreview. Differential Revision: https://phabricator.services.mozilla.com/D31811
0f7ad2632fd279934b895d9a23074ec63ab52914: Bug 1552711. Use 'DocShell' instead of 'Container' in nsPrintJob. r=bobowen
Jonathan Watt <jwatt@jwatt.org> - Wed, 08 May 2019 14:54:26 +0100 - rev 474466
Push 113161 by jwatt@jwatt.org at Mon, 20 May 2019 12:14:11 +0000
Bug 1552711. Use 'DocShell' instead of 'Container' in nsPrintJob. r=bobowen Differential Revision: https://phabricator.services.mozilla.com/D31743
930f0f51b681aea2a5e915a2770f80a9914ed3df: Bug 1552478. Stop printpreview_bug396024_helper.xul creating a print preview viewer in a normal document window. r=bobowen
Jonathan Watt <jwatt@jwatt.org> - Tue, 07 May 2019 23:58:30 +0100 - rev 474333
Push 113145 by jwatt@jwatt.org at Fri, 17 May 2019 16:50:32 +0000
Bug 1552478. Stop printpreview_bug396024_helper.xul creating a print preview viewer in a normal document window. r=bobowen Differential Revision: https://phabricator.services.mozilla.com/D31613
73c9f2d6d3a067cd3f0a1982e22f60d70123ca21: Bug 1552449. Make the nsIDocShell interface to print preview less susceptible to inadvertent misuse. r=bobowen
Jonathan Watt <jwatt@jwatt.org> - Tue, 07 May 2019 14:12:44 +0100 - rev 474332
Push 113145 by jwatt@jwatt.org at Fri, 17 May 2019 16:50:32 +0000
Bug 1552449. Make the nsIDocShell interface to print preview less susceptible to inadvertent misuse. r=bobowen Differential Revision: https://phabricator.services.mozilla.com/D31598