searching for reviewer(bgrins)
a39c67169747c1dbd184c14c11aa6bdd3d61db93: Bug 1544864 - Enable Show Content Messages in browser console. r=bgrins.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Sat, 15 Jun 2019 08:07:17 +0000 - rev 479060
Push 113457 by ncsoregi@mozilla.com at Sun, 16 Jun 2019 21:56:56 +0000
Bug 1544864 - Enable Show Content Messages in browser console. r=bgrins. This patch removes the preference we were using to display the checkbox in the Browser Console; it's now always displayed there. We flip the pref to show content messages ini tests that need them. Differential Revision: https://phabricator.services.mozilla.com/D34996
7312aba8ec3b2149f5251bd91d8f1cfee7cd3322: Bug 1558674 - Allow chrome privileged documents to enable/disable copy/paste. r=Ehsan,bgrins
Brendan Dahl <bdahl@mozilla.com> - Sat, 15 Jun 2019 00:27:36 +0000 - rev 479004
Push 113448 by apavel@mozilla.com at Sat, 15 Jun 2019 10:07:35 +0000
Bug 1558674 - Allow chrome privileged documents to enable/disable copy/paste. r=Ehsan,bgrins For content HTML/XHTML copy/paste should always be enabled, but for chrome docs we can support enabling/disabling copy/paste. Also, restores tests to how they were before copy/paste was always enabled. Differential Revision: https://phabricator.services.mozilla.com/D34805
6fb248823c0d8969e2bd909578faee12f59fcc0f: Bug 1544864 - Enable Show Content Messages in browser console. r=bgrins.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Fri, 14 Jun 2019 13:40:32 +0000 - rev 478873
Push 113443 by dvarga@mozilla.com at Fri, 14 Jun 2019 21:53:52 +0000
Bug 1544864 - Enable Show Content Messages in browser console. r=bgrins. This patch removes the preference we were using to display the checkbox in the Browser Console; it's now always displayed there. Differential Revision: https://phabricator.services.mozilla.com/D34996
2807c9fd659decb188eea7a6751db8daa499b318: Bug 1558574 - Re-add support for clickSelectsAll attribute on search-textbox. r=bgrins
Tim Nguyen <ntim.bugs@gmail.com> - Thu, 13 Jun 2019 16:32:17 +0000 - rev 478712
Push 113434 by shindli@mozilla.com at Thu, 13 Jun 2019 22:05:34 +0000
Bug 1558574 - Re-add support for clickSelectsAll attribute on search-textbox. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D34906
4ab156373ed150f7a1b334cb35016b10b1f59c94: Bug 1558692 - Fix browser_webconsole_warning_group_multiples.js intermittent. r=bgrins.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 13 Jun 2019 16:04:11 +0000 - rev 478705
Push 113434 by shindli@mozilla.com at Thu, 13 Jun 2019 22:05:34 +0000
Bug 1558692 - Fix browser_webconsole_warning_group_multiples.js intermittent. r=bgrins. Making the URLs unique seems to fix the issue. Differential Revision: https://phabricator.services.mozilla.com/D34877
62ac95a65617d4a0bdcf494986d4b9c9626cc7f9: Bug 1495621 - convert wizard binding to Custom Element r=bgrins
Alexander Surkov <surkov.alexander@gmail.com> - Wed, 12 Jun 2019 23:37:05 +0000 - rev 478683
Push 113434 by shindli@mozilla.com at Thu, 13 Jun 2019 22:05:34 +0000
Bug 1495621 - convert wizard binding to Custom Element r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D26334
5555e12078d379f7f54ad89ffa7b9dbc99d3cf14: Bug 1488953 - Disable smooth scroll on tabbar scrollbox to avoid stopping scrolling the last tab on race conditions. r=bgrins
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Thu, 13 Jun 2019 02:30:25 +0000 - rev 478601
Push 113428 by opoprus@mozilla.com at Thu, 13 Jun 2019 10:07:38 +0000
Bug 1488953 - Disable smooth scroll on tabbar scrollbox to avoid stopping scrolling the last tab on race conditions. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D33615
2a638724408b5b272c052cf06e663ea1f4177181: Bug 1488953 - Wait for a scrollend event to make sure the scrolling has finished before proceeding the test. r=bgrins
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Thu, 13 Jun 2019 02:29:08 +0000 - rev 478600
Push 113428 by opoprus@mozilla.com at Thu, 13 Jun 2019 10:07:38 +0000
Bug 1488953 - Wait for a scrollend event to make sure the scrolling has finished before proceeding the test. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D33614
7d0ccb92fae02584def07d82e976b38ab8f2bda8: Bug 1555951 - Use AppConstants.platform instead of RegExp::test(navigator.platform) in custom element scripts. r=bgrins
Dão Gottwald <dao@mozilla.com> - Mon, 10 Jun 2019 19:28:11 +0000 - rev 478213
Push 113412 by rgurzau@mozilla.com at Tue, 11 Jun 2019 21:39:14 +0000
Bug 1555951 - Use AppConstants.platform instead of RegExp::test(navigator.platform) in custom element scripts. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D33926
406aa9e6a10200d321e2d78cd0c2769c1f94fac3: Bug 1551612 - Add componentDidCatch in Message component. r=bgrins.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 10 Jun 2019 06:22:05 +0000 - rev 478033
Push 113403 by nerli@mozilla.com at Mon, 10 Jun 2019 21:55:07 +0000
Bug 1551612 - Add componentDidCatch in Message component. r=bgrins. This patch adds a componentDidCatch handler to the Message component so we don't crash the whole console when a message can't be rendered. When a message causes a crash, we display an error message instead, asking the user to file a bug. A button allow to copy the message data so it can be attached in the bug report. Differential Revision: https://phabricator.services.mozilla.com/D31195
519acd8e145fd146b0d5be3dfc2f551f55b868f7: Bug 1488953 - Disable smooth scroll on tabbar scrollbox to avoid stopping scrolling the last tab on race conditions. r=bgrins
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Mon, 10 Jun 2019 03:06:25 +0000 - rev 478030
Push 113403 by nerli@mozilla.com at Mon, 10 Jun 2019 21:55:07 +0000
Bug 1488953 - Disable smooth scroll on tabbar scrollbox to avoid stopping scrolling the last tab on race conditions. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D33615
3a5cbbb9bc48fce8b1afeab3b09288849c117f61: Bug 1488953 - Wait for a scrollend event to make sure the scrolling has finished before proceeding the test. r=bgrins
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Mon, 10 Jun 2019 03:06:25 +0000 - rev 478029
Push 113403 by nerli@mozilla.com at Mon, 10 Jun 2019 21:55:07 +0000
Bug 1488953 - Wait for a scrollend event to make sure the scrolling has finished before proceeding the test. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D33614
534c277917ae66d6cb0b580e88d30559f66e10b4: Bug 1557674 - Replace XUL textbox usages with HTML inputs in storage inspector. r=bgrins
Tim Nguyen <ntim.bugs@gmail.com> - Fri, 07 Jun 2019 21:42:59 +0000 - rev 477929
Push 113386 by nbeleuzu@mozilla.com at Sat, 08 Jun 2019 09:51:50 +0000
Bug 1557674 - Replace XUL textbox usages with HTML inputs in storage inspector. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D34190
7bf9069eba430471a76604af10b089982d2de2df: Bug 1557674 - Replace XUL textbox usages with HTML inputs in storage inspector. r=bgrins
Tim Nguyen <ntim.bugs@gmail.com> - Fri, 07 Jun 2019 19:36:00 +0000 - rev 477905
Push 113386 by nbeleuzu@mozilla.com at Sat, 08 Jun 2019 09:51:50 +0000
Bug 1557674 - Replace XUL textbox usages with HTML inputs in storage inspector. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D34190
4c97b0e294f528977f12a33b8cdeee04e5fa5082: Bug 1557814 - Replace XUL textbox with HTML input in identityPanel.inc.xul. r=bgrins
Tim Nguyen <ntim.bugs@gmail.com> - Fri, 07 Jun 2019 19:15:19 +0000 - rev 477904
Push 113386 by nbeleuzu@mozilla.com at Sat, 08 Jun 2019 09:51:50 +0000
Bug 1557814 - Replace XUL textbox with HTML input in identityPanel.inc.xul. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D34223
e2af0f70828c3ff4f70bc12e70cf2a299fab5ad9: Bug 1551612 - Add componentDidCatch in Message component. r=bgrins.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Fri, 07 Jun 2019 13:03:48 +0000 - rev 477831
Push 113380 by apavel@mozilla.com at Fri, 07 Jun 2019 22:16:42 +0000
Bug 1551612 - Add componentDidCatch in Message component. r=bgrins. This patch adds a componentDidCatch handler to the Message component so we don't crash the whole console when a message can't be rendered. When a message causes a crash, we display an error message instead, asking the user to file a bug. A button allow to copy the message data so it can be attached in the bug report. Differential Revision: https://phabricator.services.mozilla.com/D31195
98973168545ee1f46e32fb758ce71fb5aa76cf3b: Bug 1557252 - add missing style for in-content dialogs, r=bgrins
Alexander Surkov <surkov.alexander@gmail.com> - Fri, 07 Jun 2019 11:33:26 +0000 - rev 477821
Push 113380 by apavel@mozilla.com at Fri, 07 Jun 2019 22:16:42 +0000
Bug 1557252 - add missing style for in-content dialogs, r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D34012
584e6d9246ac3cfa73d6bb0abfe88294cb309856: Bug 1557252 - add missing style for in-content dialogs, r=bgrins
Alexander Surkov <surkov.alexander@gmail.com> - Thu, 06 Jun 2019 15:56:34 +0000 - rev 477644
Push 113366 by ncsoregi@mozilla.com at Thu, 06 Jun 2019 22:41:06 +0000
Bug 1557252 - add missing style for in-content dialogs, r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D33976
843c150636f81fb2f13196844206514f8a938bd9: Bug 1544916 - migrate dialog binding to Custom Element r=bgrins,whimboo
Alexander Surkov <surkov.alexander@gmail.com> - Tue, 04 Jun 2019 17:28:16 +0000 - rev 477332
Push 113327 by malexandru@mozilla.com at Wed, 05 Jun 2019 10:00:10 +0000
Bug 1544916 - migrate dialog binding to Custom Element r=bgrins,whimboo Differential Revision: https://phabricator.services.mozilla.com/D30289
6fa9d5d2aa9d2a695ab15cb7810a95df8db3ae76: Bug 1555929 - Use handleEvent and on_<event name> pattern in MozTab and MozTabbrowserTab. r=bgrins
Dão Gottwald <dao@mozilla.com> - Fri, 31 May 2019 17:32:26 +0000 - rev 476461
Push 113285 by aiakab@mozilla.com at Fri, 31 May 2019 22:31:43 +0000
Bug 1555929 - Use handleEvent and on_<event name> pattern in MozTab and MozTabbrowserTab. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D33272
e09471d136599b68f40f6bb9ec7fcc419732948e: Bug 1512432 - convert richlistitem binding to Custom Element, r=bgrins
Alexander Surkov <surkov.alexander@gmail.com> - Thu, 30 May 2019 14:12:47 +0000 - rev 476240
Push 113262 by nbeleuzu@mozilla.com at Thu, 30 May 2019 21:52:09 +0000
Bug 1512432 - convert richlistitem binding to Custom Element, r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D32474
f6eb58afc87bf10d483fffbbb66256978f0d55b0: Bug 1555496 Fix bookmark toolbar drag handlers r=bgrins
Andrew Swan <aswan@mozilla.com> - Thu, 30 May 2019 03:29:19 +0000 - rev 476202
Push 113262 by nbeleuzu@mozilla.com at Thu, 30 May 2019 21:52:09 +0000
Bug 1555496 Fix bookmark toolbar drag handlers r=bgrins Code here explicitly references lastElementChild inside a toolbarbutton but it doesn't have any tests so it wasn't caught when bug 1519577 landed :( Differential Revision: https://phabricator.services.mozilla.com/D33104
b33cfaa24138bd3bd1e167f1736fb6ba0b20d473: Bug 1555240 - Remove unnecessary macOS scrollbar rule. r=bgrins
Cameron McCormack <cam@mcc.id.au> - Wed, 29 May 2019 13:58:54 +0000 - rev 476153
Push 113250 by shindli@mozilla.com at Thu, 30 May 2019 03:52:44 +0000
Bug 1555240 - Remove unnecessary macOS scrollbar rule. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D32954
555ca6176088409a3e41452759bd7e71c1ad547a: Bug 1519514 - hg copy tabbrowser.xml to tabbrowser-tabs.js to preserve history for tab binding conversion to a Custom Element, r=bgrins
Alexander Surkov <surkov.alexander@gmail.com> - Tue, 28 May 2019 22:00:18 +0000 - rev 476043
Push 113243 by nerli@mozilla.com at Wed, 29 May 2019 16:02:35 +0000
Bug 1519514 - hg copy tabbrowser.xml to tabbrowser-tabs.js to preserve history for tab binding conversion to a Custom Element, r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D26601
9aa56223938bb6f94c1184a71b8edf856d54a02d: Bug 1519514 - convert tab binding to a Custom Element, r=bgrins
Alexander Surkov <surkov.alexander@gmail.com> - Tue, 28 May 2019 22:00:16 +0000 - rev 476042
Push 113243 by nerli@mozilla.com at Wed, 29 May 2019 16:02:35 +0000
Bug 1519514 - convert tab binding to a Custom Element, r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D26600
858b9456eb3c8b081d652468afdefd7cbf79538c: Bug 1519514 - hg copy tabbrowser.xml to tabbrowser-tabs.js to preserve history for tab binding conversion to a Custom Element, r=bgrins
Alexander Surkov <surkov.alexander@gmail.com> - Tue, 28 May 2019 22:00:18 +0000 - rev 475996
Push 113240 by nerli@mozilla.com at Wed, 29 May 2019 09:56:33 +0000
Bug 1519514 - hg copy tabbrowser.xml to tabbrowser-tabs.js to preserve history for tab binding conversion to a Custom Element, r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D26601
2cd983857de6c73d677c161faf1aaa67a4c3f500: Bug 1519514 - convert tab binding to a Custom Element, r=bgrins
Alexander Surkov <surkov.alexander@gmail.com> - Tue, 28 May 2019 22:00:16 +0000 - rev 475995
Push 113240 by nerli@mozilla.com at Wed, 29 May 2019 09:56:33 +0000
Bug 1519514 - convert tab binding to a Custom Element, r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D26600
a3228e7cd5208a463255c4eeea0503e909cba70e: Bug 1550559 - Convert findbar XUL textbox to HTML input. r=bgrins
Tim Nguyen <ntim.bugs@gmail.com> - Mon, 20 May 2019 21:54:15 +0000 - rev 475371
Push 113208 by cbrindusan@mozilla.com at Fri, 24 May 2019 21:57:39 +0000
Bug 1550559 - Convert findbar XUL textbox to HTML input. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D30542
6efc35cfb29a053c8a527d5a88dde4908812f40e: Bug 1551320 - Replace another instance of createElement with createXULElement. r=bgrins
Brendan Dahl <bdahl@mozilla.com> - Wed, 22 May 2019 20:19:28 +0000 - rev 475071
Push 113193 by dvarga@mozilla.com at Thu, 23 May 2019 16:04:39 +0000
Bug 1551320 - Replace another instance of createElement with createXULElement. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D32211
3c824624aa30a223ba960b0131b71882c872f0ae: Bug 1551320 - Replace one more createElement with createElementNS. r=bgrins
Brendan Dahl <brendan.dahl@gmail.com> - Tue, 21 May 2019 18:12:31 +0000 - rev 474818
Push 113171 by aiakab@mozilla.com at Tue, 21 May 2019 21:56:33 +0000
Bug 1551320 - Replace one more createElement with createElementNS. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D31918
8e5c0606d1555b052c98ab5d01dc6076b4453039: Bug 1552109 - Fix filter count when text filtering is on. r=bgrins.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 16 May 2019 13:12:06 +0000 - rev 474133
Push 113134 by ncsoregi@mozilla.com at Thu, 16 May 2019 22:01:33 +0000
Bug 1552109 - Fix filter count when text filtering is on. r=bgrins. The counter was erroneous because we were checking that messages were validating the text input before checking if they should be visible based on their category. Sadly, mocha tests were asserting that we had a bug, so we fixed them in this patch. Differential Revision: https://phabricator.services.mozilla.com/D31402
2a9a034e1b6a38cba33ba668704cce7ad7a04cd3: Bug 1550559 - Convert findbar XUL textbox to HTML input. r=bgrins
Tim Nguyen <ntim.bugs@gmail.com> - Thu, 16 May 2019 11:30:37 +0000 - rev 474123
Push 113134 by ncsoregi@mozilla.com at Thu, 16 May 2019 22:01:33 +0000
Bug 1550559 - Convert findbar XUL textbox to HTML input. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D30542
d15e60f91051c45b51a5c8cf130eaa03ef24ce62: Bug 1551312 - allow customized built-in buttons to be passed to notificationbox r=bgrins
Magnus Melin <mkmelin+mozilla@iki.fi> - Wed, 15 May 2019 20:14:30 +0000 - rev 474106
Push 113134 by ncsoregi@mozilla.com at Thu, 16 May 2019 22:01:33 +0000
Bug 1551312 - allow customized built-in buttons to be passed to notificationbox r=bgrins Allow customized built-in buttons to be used for the notificationbox buttons. This way e.g. <button type=menu-button> can be used there. Differential Revision: https://phabricator.services.mozilla.com/D30971
30ee2053caf27c743cb02d8355da879ec8310465: Bug 1550559 - Convert findbar XUL textbox to HTML input. r=bgrins
Tim Nguyen <ntim.bugs@gmail.com> - Wed, 15 May 2019 18:02:10 +0000 - rev 473983
Push 113120 by dvarga@mozilla.com at Thu, 16 May 2019 04:21:05 +0000
Bug 1550559 - Convert findbar XUL textbox to HTML input. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D30542
c8057f34f28123f2ad4b3aa14e8cbc621159a03a: Bug 1550559 - Convert findbar XUL textbox to HTML input. r=bgrins
Tim Nguyen <ntim.bugs@gmail.com> - Wed, 15 May 2019 15:40:23 +0000 - rev 473969
Push 113119 by dvarga@mozilla.com at Wed, 15 May 2019 21:35:00 +0000
Bug 1550559 - Convert findbar XUL textbox to HTML input. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D30542
a219fd210a0422bf9eccbcdb4ff49f179e1b735e: Bug 1550561 - Support edit context menu on HTML inputs in chrome documents. r=bgrins
Tim Nguyen <ntim.bugs@gmail.com> - Mon, 13 May 2019 05:56:52 +0000 - rev 473736
Push 113104 by aiakab@mozilla.com at Tue, 14 May 2019 09:49:04 +0000
Bug 1550561 - Support edit context menu on HTML inputs in chrome documents. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D30552
b90c24bb6358c8ad4b0b56cd312457e0548c26f3: Bug 1549388 - Render non-string messageText with GripMessageBody. r=bgrins.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 13 May 2019 23:47:19 +0000 - rev 473727
Push 113104 by aiakab@mozilla.com at Tue, 14 May 2019 09:49:04 +0000
Bug 1549388 - Render non-string messageText with GripMessageBody. r=bgrins. Sometimes the messageText can be a longString, which was crashing the whole console output since we were always assuming messageText was a plain string. We now render non-string messageText with reps so it handles longStrings. A mocha test is added to ensure this works as expected. Differential Revision: https://phabricator.services.mozilla.com/D30875
5a993bd3862b7a5b40771c25d962ba9c30ce76de: Bug 1521280 - Convert search-textbox to a custom element. r=dao,bgrins
Tim Nguyen <ntim.bugs@gmail.com> - Mon, 13 May 2019 18:12:37 +0000 - rev 473696
Push 113102 by apavel@mozilla.com at Tue, 14 May 2019 04:24:11 +0000
Bug 1521280 - Convert search-textbox to a custom element. r=dao,bgrins Differential Revision: https://phabricator.services.mozilla.com/D23045
0d1dee50991e0efa3b56c843cecb53ec140a6076: Bug 1521280 - Remove special-case that's no longer needed after these patches. r=bgrins
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 13 May 2019 21:47:20 +0000 - rev 473693
Push 113102 by apavel@mozilla.com at Tue, 14 May 2019 04:24:11 +0000
Bug 1521280 - Remove special-case that's no longer needed after these patches. r=bgrins After the patches in this bug, the input in the old about:config will no longer be anonymous, so we don't need this anymore since it'll get handled just fine by CollectFromInputElement. Differential Revision: https://phabricator.services.mozilla.com/D30956
4b3945b758896f5153e61a1b84a2b3614a98021a: Bug 1550561 - Support edit context menu on HTML inputs in chrome documents. r=bgrins
Tim Nguyen <ntim.bugs@gmail.com> - Sun, 12 May 2019 13:45:53 +0000 - rev 473551
Push 113088 by ncsoregi@mozilla.com at Sun, 12 May 2019 21:47:53 +0000
Bug 1550561 - Support edit context menu on HTML inputs in chrome documents. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D30552
c5798de806e28251aeda7d23123ab2b05eb7e8fb: Bug 1521280 - Convert search-textbox to a custom element. r=dao,bgrins
Tim Nguyen <ntim.bugs@gmail.com> - Fri, 10 May 2019 11:46:49 +0000 - rev 473399
Push 113082 by dvarga@mozilla.com at Fri, 10 May 2019 21:54:38 +0000
Bug 1521280 - Convert search-textbox to a custom element. r=dao,bgrins Differential Revision: https://phabricator.services.mozilla.com/D23045
3315610792f4b94ab15a102fa8119efec42f9a2e: Bug 1550561 - Support edit context menu on HTML inputs in chrome documents. r=bgrins
Tim Nguyen <ntim.bugs@gmail.com> - Thu, 09 May 2019 19:33:06 +0000 - rev 473296
Push 113072 by nbeleuzu@mozilla.com at Fri, 10 May 2019 02:59:17 +0000
Bug 1550561 - Support edit context menu on HTML inputs in chrome documents. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D30552
4d0cb443ef8b8ae84d8ea3dd65da1d923da3ff0e: Bug 1547767 Fix buttons in Sync disconnect dialog r=bgrins
Andrew Swan <aswan@mozilla.com> - Tue, 30 Apr 2019 22:58:26 +0000 - rev 472078
Push 112978 by apavel@mozilla.com at Wed, 01 May 2019 16:09:45 +0000
Bug 1547767 Fix buttons in Sync disconnect dialog r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D29432
d507bf325bf77e1513b1e1ebe3bc3714a7ba6998: Bug 1547463 Explicit load customElements.js where necessary r=bgrins
Andrew Swan <aswan@mozilla.com> - Mon, 29 Apr 2019 18:14:17 +0000 - rev 471786
Push 112948 by shindli@mozilla.com at Mon, 29 Apr 2019 21:58:23 +0000
Bug 1547463 Explicit load customElements.js where necessary r=bgrins commonDialog.xul and profileDowngrade.xul both may load early enough during startup that they don't automatically get customElements.js. The quick workaround here is just to load it explicitly in those documents. Differential Revision: https://phabricator.services.mozilla.com/D29235
013a4420b53c6697abb8609b6d576b1cc07991e2: Bug 1547322 Don't double-insert inner content when <button> is cloned r=bgrins
Andrew Swan <aswan@mozilla.com> - Fri, 26 Apr 2019 21:36:03 +0000 - rev 471609
Push 112929 by nbeleuzu@mozilla.com at Sat, 27 Apr 2019 09:55:23 +0000
Bug 1547322 Don't double-insert inner content when <button> is cloned r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D29063
936c2d2014055dcaf1cc8d15bca959815224bd3c: Bug 1538983 Convert button xbl binding to a custom element r=bgrins
Andrew Swan <aswan@mozilla.com> - Mon, 15 Apr 2019 14:27:32 -0700 - rev 471289
Push 112911 by aswan@mozilla.com at Thu, 25 Apr 2019 20:48:08 +0000
Bug 1538983 Convert button xbl binding to a custom element r=bgrins As of this change, instances of xul <button> use a custom element. The button-base xbl binding remains for now, since it is still used by toolbarbutton, it will be removed soon. Differential Revision: https://phabricator.services.mozilla.com/D27742
9d97144e67e9d2927c277ce81d25a009c44c4d70: Bug 1470880 - Stop relying on [side] in arrowpanel selectors in order to remove last usage of xbl resources. r=bgrins
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 24 Apr 2019 09:29:48 +0000 - rev 471084
Push 112895 by cbrindusan@mozilla.com at Wed, 24 Apr 2019 22:47:15 +0000
Bug 1470880 - Stop relying on [side] in arrowpanel selectors in order to remove last usage of xbl resources. r=bgrins The reason why this fixes it is a bit subtle, let me try to explain. XBL has this mechanism where all attributes in the binding `<content>` element get auto-propagated to the bound element (the `<panel>` in this case). This doesn't seem to be a very used feature looking at: https://searchfox.org/mozilla-central/search?q=%3Ccontent&case=false&regexp=false&path=xml The panel binding uses it to add the `side` attribute: https://searchfox.org/mozilla-central/rev/d80f0a570736dce76a2eb184fb65517462089e8a/toolkit/content/widgets/popup.xml#264 The key here is that this attribute addition is silent (`aNotify=false`): https://searchfox.org/mozilla-central/rev/d80f0a570736dce76a2eb184fb65517462089e8a/dom/xbl/nsXBLBinding.cpp#341 This means that the presence of this attribute is not supposed to change the rendering of the page. It'd also be unsafe to notify at the point at which we create XBL bindings. So the way this happens is: * We compute the initial style of the `<panel>` element (which doesn't have a `side` attribute, and thus doesn't match the rules, and has a computed opacity of 1). * The XBL service _silently_ sets the `side` attribute. This should cause a style change, but it doesn't since it's silent, so we remain with the opacity of 1. * We open the popup, and the XBL binding listens for the `popupshowing` event and adds the `animate` attribute. The style system notices, and eventually we compute the new style. Issue is, it has again an opacity of 1, so we don't fire the transition. Same with transform and such of course. So far so good, but then, why does it work if there's a `<resources>` element with an empty stylesheet? Fun that you ask! We explicitly re-resolve the style of the element if there are any stylesheets: https://searchfox.org/mozilla-central/rev/d80f0a570736dce76a2eb184fb65517462089e8a/dom/xbl/nsXBLService.cpp#551 And thus grab the correct initial opacity of zero, and trigger the transition. Given arrow panels always have a `side` attribute (and same for the bookmarks thing), making their style not depend on the silent attribute additions from `<content>` fixes the bug. We could fix the bug with an alternative patch (re-resolving style if there's a `<content>` element with attributes in the binding). This wouldn't be completely sound anyway in presence of combinators, and given that it'd remain being unsound anyway, we should probably just remove that feature. Also, the simplification of the stylesheets seems worth it anyway. I'll follow-up removing the `<resources>` implementation, and we should probably investigate removing the `<content>` attribute propagation, since it's the really unsound thing here. Differential Revision: https://phabricator.services.mozilla.com/D28310
eae703fef90edaafc129ee1f66927b97e26b2988: Bug 1546541 Remove no-op toolbarbutton menu bindings r=bgrins
Andrew Swan <aswan@mozilla.com> - Wed, 24 Apr 2019 00:10:42 +0000 - rev 470825
Push 112882 by nerli@mozilla.com at Wed, 24 Apr 2019 09:58:31 +0000
Bug 1546541 Remove no-op toolbarbutton menu bindings r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D28584
99ad1e5017af4029d97661a835ab95f78a5cb2b8: Bug 1546367 - Clear report textarea when report is submitted. r=bgrins
Tim Nguyen <ntim.bugs@gmail.com> - Tue, 23 Apr 2019 18:28:04 +0000 - rev 470764
Push 112876 by aciure@mozilla.com at Tue, 23 Apr 2019 22:24:17 +0000
Bug 1546367 - Clear report textarea when report is submitted. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D28522
970ef36e6c09e748140ebf96c9ccfec6eb52ab5e: Bug 1544749 - Fix HTML Tooltip tests when running in content frame r=bgrins
Julian Descottes <jdescottes@mozilla.com> - Tue, 23 Apr 2019 15:00:23 +0000 - rev 470735
Push 112876 by aciure@mozilla.com at Tue, 23 Apr 2019 22:24:17 +0000
Bug 1544749 - Fix HTML Tooltip tests when running in content frame r=bgrins Depends on D27680 Not strictly related to win.top/parent, but those tests would fail if the toolbox is in a content frame. tooltip-01.js is creating a blank tab for no reason which prevents interacting with the actual test frame. tooltip-02.js is not properly targeting an iframe to simulate a click Differential Revision: https://phabricator.services.mozilla.com/D27674