searching for reviewer(bgrins)
9cd05214d12a8727677c0db1fe46a73ca51f70b8: Bug 1595925 - QI to nsIWebNavigation before using docShell.document, r=bgrins
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Mon, 18 Nov 2019 17:59:36 +0000 - rev 502446
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1595925 - QI to nsIWebNavigation before using docShell.document, r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D53661
493025785e6adfde44b1e2ad0a00b48b3ff4cb7b: Bug 1596735 - Re-add 'data' in the list of XUL elements to hide. r=bgrins
Tim Nguyen <ntim.bugs@gmail.com> - Fri, 15 Nov 2019 17:34:27 +0000 - rev 502247
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1596735 - Re-add 'data' in the list of XUL elements to hide. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D53235
48829132cb50ae7cdcb69e1780aecb3f3737c27b: Bug 1588142 - Fix test failure of browser_canvasframe_helper_02.js r=bgrins
Kirk Steuber <ksteuber@mozilla.com> - Thu, 14 Nov 2019 00:35:53 +0000 - rev 501867
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1588142 - Fix test failure of browser_canvasframe_helper_02.js r=bgrins Depends on D52289 Differential Revision: https://phabricator.services.mozilla.com/D52937
1f37c31422e2737db9e6bcc9826facd3fdb15bf2: Bug 1588142 - about:preferences - migrate the root xul:window element to an html:html element r=Gijs,bgrins
Kirk Steuber <ksteuber@mozilla.com> - Thu, 14 Nov 2019 00:17:01 +0000 - rev 501863
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1588142 - about:preferences - migrate the root xul:window element to an html:html element r=Gijs,bgrins Differential Revision: https://phabricator.services.mozilla.com/D51712
e17aebea669678319835e399324df56eb14c78cf: Bug 1596176 - Add missing linux and windows rule for badge positioning. r=bgrins
Tim Nguyen <ntim.bugs@gmail.com> - Wed, 13 Nov 2019 20:11:07 +0000 - rev 501822
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1596176 - Add missing linux and windows rule for badge positioning. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D52890
87336cc7f8a1afe7dbd042fd23de5ae3010b0845: Bug 1588142 - about:preferences - migrate the root xul:window element to an html:html element r=Gijs,bgrins
Kirk Steuber <ksteuber@mozilla.com> - Wed, 13 Nov 2019 17:46:30 +0000 - rev 501807
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1588142 - about:preferences - migrate the root xul:window element to an html:html element r=Gijs,bgrins Differential Revision: https://phabricator.services.mozilla.com/D51712
56f779b8961dd87cac2e20b4c91c1d6b2a3b0f7b: Bug 1579129 - Implement left-aligning/centering the viewport based on user prefs. r=gl,bgrins
Micah Tigley <mtigley@mozilla.com> - Tue, 12 Nov 2019 20:34:55 +0000 - rev 501645
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1579129 - Implement left-aligning/centering the viewport based on user prefs. r=gl,bgrins Differential Revision: https://phabricator.services.mozilla.com/D51671
7477b284a8a3990f57ea98a1d210fa61c78efc36: Bug 1576946 - Implement <stack> using CSS Grid. r=bgrins
Tim Nguyen <ntim.bugs@gmail.com> - Tue, 12 Nov 2019 19:49:48 +0000 - rev 501619
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1576946 - Implement <stack> using CSS Grid. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D46226
a2af5be34b6b8ee865a3283880e5b4b16bbbde30: Bug 1594457 - fix DOMTitleChanged handling for reloads, r=bgrins
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Tue, 12 Nov 2019 17:29:14 +0000 - rev 501602
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1594457 - fix DOMTitleChanged handling for reloads, r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D52022
9644ee96a51a03a8f4e50e9777fb7278f246383c: Bug 1492582 - Fix screenshot tests for htmlified browser.xhtml. r=bgrins
Brendan Dahl <bdahl@mozilla.com> - Fri, 08 Nov 2019 23:34:18 +0000 - rev 501409
Push 114169 by ncsoregi@mozilla.com at Mon, 11 Nov 2019 12:39:11 +0000
Bug 1492582 - Fix screenshot tests for htmlified browser.xhtml. r=bgrins The <html> element does not have screenX and screenY like XULElement. Instead use window location and element offset to calculate it. Differential Revision: https://phabricator.services.mozilla.com/D52420
c2b41600ce78924d6a8b0cfd649fd8a7867ee6d1: Bug 1492582 - Use XUL inspector highlighter for HTML docs without scroll frames. r=bgrins
Brendan Dahl <bdahl@mozilla.com> - Fri, 08 Nov 2019 23:34:10 +0000 - rev 501408
Push 114169 by ncsoregi@mozilla.com at Mon, 11 Nov 2019 12:39:11 +0000
Bug 1492582 - Use XUL inspector highlighter for HTML docs without scroll frames. r=bgrins The devtools highlighter is broken with browser.xhtml when scroll frames are disabled. Differential Revision: https://phabricator.services.mozilla.com/D52104
1484255e5f4df32ea381c58669ed22545a70d4a7: Bug 1492582 - Use XUL inspector highlighter for HTML docs without scroll frames. r=bgrins
Brendan Dahl <bdahl@mozilla.com> - Thu, 07 Nov 2019 16:21:30 +0000 - rev 501106
Push 114168 by dluca@mozilla.com at Sun, 10 Nov 2019 03:08:55 +0000
Bug 1492582 - Use XUL inspector highlighter for HTML docs without scroll frames. r=bgrins The devtools highlighter is broken with browser.xhtml when scroll frames are disabled. Differential Revision: https://phabricator.services.mozilla.com/D52104
9c25076644f29ccfe65bde0b3b8a22e74966b2a2: Bug 1593475 - Ensure FluentDOM does not localize elements in template. r=bgrins
Zibi Braniecki <zbraniecki@mozilla.com> - Wed, 06 Nov 2019 18:18:14 +0000 - rev 500906
Push 114166 by apavel@mozilla.com at Thu, 07 Nov 2019 10:04:01 +0000
Bug 1593475 - Ensure FluentDOM does not localize elements in template. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D51506
b76033ea35ef3684c407e7369bea038fa58c8b9e: Bug 1589134 - Move <script> tags out of <wizard>s r=bgrins
Kirk Steuber <ksteuber@mozilla.com> - Tue, 05 Nov 2019 21:08:50 +0000 - rev 500727
Push 114166 by apavel@mozilla.com at Thu, 07 Nov 2019 10:04:01 +0000
Bug 1589134 - Move <script> tags out of <wizard>s r=bgrins Moving these script tags has caused some code to be called in a different order. This patch enforces the necessary ordering by explicitly initializing MozWizardButtons from MozWizard's connectedCallback. Differential Revision: https://phabricator.services.mozilla.com/D49490
a44bfb190d80487c84b216aac35150c6aa098cff: Bug 1593051 - Remove usage of parseXULToFragment from applicationManager.js r=bgrins
Christoph Walcher <christoph-wa@gmx.de> - Mon, 04 Nov 2019 20:18:53 +0000 - rev 500449
Push 114164 by aiakab@mozilla.com at Tue, 05 Nov 2019 10:06:15 +0000
Bug 1593051 - Remove usage of parseXULToFragment from applicationManager.js r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D51545
6078cd6452f3b569a603daf7d183e12fdc930a5c: Bug 1573781 - Remove unnecessary closing tag for the richlistitem in MozAutocompleteRichlistboxPopup r=bgrins
Thomas <thomas510111@gmail.com> - Mon, 04 Nov 2019 18:34:33 +0000 - rev 500427
Push 114164 by aiakab@mozilla.com at Tue, 05 Nov 2019 10:06:15 +0000
Bug 1573781 - Remove unnecessary closing tag for the richlistitem in MozAutocompleteRichlistboxPopup r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D51521
88d9d6ff69d74941cdb3347bf8900c0f45b9fa3c: Bug 1593066 - Remove XBL <children> support in arrowscrollbox _getScrollableElements r=bgrins
Christoph Walcher <christoph-wa@gmx.de> - Mon, 04 Nov 2019 14:32:12 +0000 - rev 500379
Push 114164 by aiakab@mozilla.com at Tue, 05 Nov 2019 10:06:15 +0000
Bug 1593066 - Remove XBL <children> support in arrowscrollbox _getScrollableElements r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D51537
dce0e0b88e8a36ed6580ef51d3aa1cfbbea36db9: Bug 1593053 - Remove XBL categories in console-services.js isCategoryAllowed. r=bgrins.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 04 Nov 2019 14:30:15 +0000 - rev 500378
Push 114164 by aiakab@mozilla.com at Tue, 05 Nov 2019 10:06:15 +0000
Bug 1593053 - Remove XBL categories in console-services.js isCategoryAllowed. r=bgrins. We shouldn't need those anymore now. Differential Revision: https://phabricator.services.mozilla.com/D51568
7ba47f9818b318d98c4203f1fb43c5bdc06875ad: Bug 1593068 - Remove "text" attribute observing from MozTextLabel r=bgrins
Christoph Walcher <christoph-wa@gmx.de> - Fri, 01 Nov 2019 17:01:24 +0000 - rev 500182
Push 114164 by aiakab@mozilla.com at Tue, 05 Nov 2019 10:06:15 +0000
Bug 1593068 - Remove "text" attribute observing from MozTextLabel r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D51398
5d9d57cd5b311c88ec886487335ef1e5eacf3439: Bug 1593065 - Remove XBL workaround for setting deck index. r=bgrins
Edouard Oger <eoger@fastmail.com> - Thu, 31 Oct 2019 22:10:51 +0000 - rev 500109
Push 114164 by aiakab@mozilla.com at Tue, 05 Nov 2019 10:06:15 +0000
Bug 1593065 - Remove XBL workaround for setting deck index. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D51319
cd45360fb1ff5110acd8d54329ab45fce7395ba0: Bug 1584627 - Remove ensureXBLBindingAttached from tabprompts.jsm. r=bgrins
Paolo Amadini <paolo.mozmail@amadzone.org> - Tue, 29 Oct 2019 18:32:40 +0000 - rev 499931
Push 114164 by aiakab@mozilla.com at Tue, 05 Nov 2019 10:06:15 +0000
Bug 1584627 - Remove ensureXBLBindingAttached from tabprompts.jsm. r=bgrins This is unnecessary now that XBL bindings are not used anymore. Differential Revision: https://phabricator.services.mozilla.com/D50975
53ebedebdb63ded40f5f3fef677ccc60fa6deeac: Bug 1434087, remove [moz-collapsed=true] attribute from minimal-xul.css and static atom r=bgrins
Emma Malysz <emalysz@mozilla.com> - Tue, 29 Oct 2019 23:05:31 +0000 - rev 499715
Push 114163 by aiakab@mozilla.com at Thu, 31 Oct 2019 10:03:38 +0000
Bug 1434087, remove [moz-collapsed=true] attribute from minimal-xul.css and static atom r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D51015
2362ccd868c631c65de8723b274e3cef16f3381a: Bug 1591761 - parseXULToFragment should throw a clearer exception for non-well-formed markup. r=bgrins
Alexander J. Vincent <ajvincent@gmail.com> - Tue, 29 Oct 2019 23:04:14 +0000 - rev 499710
Push 114163 by aiakab@mozilla.com at Thu, 31 Oct 2019 10:03:38 +0000
Bug 1591761 - parseXULToFragment should throw a clearer exception for non-well-formed markup. r=bgrins *** Bug 1591671, revert a breaking change in calling DOMParser. Differential Revision: https://phabricator.services.mozilla.com/D50729
20e122d88c48306529cace5d0cddf81690c9a380: Bug 1588816 - Remove userChrome.css case since XBL is dead in Nightly r=bgrins
Tom Ritter <tom@mozilla.com> - Tue, 29 Oct 2019 17:10:59 +0000 - rev 499661
Push 114163 by aiakab@mozilla.com at Thu, 31 Oct 2019 10:03:38 +0000
Bug 1588816 - Remove userChrome.css case since XBL is dead in Nightly r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D50964
8799781bbf3490a6f8c58c7de511dac360be6bb5: Bug 1591761 - parseXULToFragment should throw a clearer exception for non-well-formed markup. r=bgrins
Alexander J. Vincent <ajvincent@gmail.com> - Mon, 28 Oct 2019 21:59:59 +0000 - rev 499524
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1591761 - parseXULToFragment should throw a clearer exception for non-well-formed markup. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D50729
5e129785c9664543a48ad07cf6c96aed304671b9: Bug 1519103 - Remove Scratchpad panel. r=bgrins.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Sun, 27 Oct 2019 09:05:58 +0000 - rev 499397
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1519103 - Remove Scratchpad panel. r=bgrins. Differential Revision: https://phabricator.services.mozilla.com/D50583
8a47372311a98d5b91e89996d92472a10b237d34: Bug 1587789 - Remove isXBLAnonymous functions defined and used in the inspector. r=bgrins
Gabriel Luong <gabriel.luong@gmail.com> - Thu, 24 Oct 2019 21:05:44 +0000 - rev 499165
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1587789 - Remove isXBLAnonymous functions defined and used in the inspector. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D50517
f748a3d2cdf108e9443fd15332efe477c7c398a9: Bug 1590387 - Remove remaining usages of XUL textboxes. r=bgrins
Tim Nguyen <ntim.bugs@gmail.com> - Tue, 22 Oct 2019 19:27:23 +0000 - rev 498600
Push 114159 by shindli@mozilla.com at Thu, 24 Oct 2019 09:49:00 +0000
Bug 1590387 - Remove remaining usages of XUL textboxes. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D50063
118d8c49d63f4bad5467ae9c148a3c15c6604085: Bug 1576363 - Unset active styling for the default dialog button when another button inside the dialog gets focused r=bgrins
Alexander Surkov <surkov.alexander@gmail.com> - Mon, 21 Oct 2019 20:02:44 +0000 - rev 498440
Push 114158 by ncsoregi@mozilla.com at Tue, 22 Oct 2019 09:53:30 +0000
Bug 1576363 - Unset active styling for the default dialog button when another button inside the dialog gets focused r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D49952
1f285b3386fa01b242fc3c9947ac50876973652b: Bug 1583531 - add in-bookmarks-menu class for arrowscrollboxes to adjust padding in bookmarks submenus r=bgrins
Alexander Surkov <surkov.alexander@gmail.com> - Thu, 17 Oct 2019 18:23:44 +0000 - rev 498101
Push 114157 by nbeleuzu@mozilla.com at Mon, 21 Oct 2019 22:00:13 +0000
Bug 1583531 - add in-bookmarks-menu class for arrowscrollboxes to adjust padding in bookmarks submenus r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D49633
8adbff6372abb498ced4e66f904abc516e76d101: Bug 1589188 - Reintroduce '.textbox-contextmenu:-moz-locale-dir(rtl)' rule. r=bgrins
Tim Nguyen <ntim.bugs@gmail.com> - Wed, 16 Oct 2019 22:12:42 +0000 - rev 498008
Push 114157 by nbeleuzu@mozilla.com at Mon, 21 Oct 2019 22:00:13 +0000
Bug 1589188 - Reintroduce '.textbox-contextmenu:-moz-locale-dir(rtl)' rule. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D49493
a37b3531c1d18962ed04ac83c7d326d40e969454: Bug 1588135, replace .xul test files in browser/ to .xhtml r=bgrins
Emma Malysz <emalysz@mozilla.com> - Mon, 14 Oct 2019 22:24:12 +0000 - rev 497556
Push 114152 by dvarga@mozilla.com at Tue, 15 Oct 2019 11:14:34 +0000
Bug 1588135, replace .xul test files in browser/ to .xhtml r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D48986
9de4958b65f183a452937f1e7e6b526df36e02f1: Bug 1588135, replace .xul test files in browser/ to .xhtml r=bgrins
Emma Malysz <emalysz@mozilla.com> - Mon, 14 Oct 2019 22:24:12 +0000 - rev 497552
Push 114152 by dvarga@mozilla.com at Tue, 15 Oct 2019 11:14:34 +0000
Bug 1588135, replace .xul test files in browser/ to .xhtml r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D48986
e3a8a694bfad19d0d6e9d3fb0a0bbf4caa3bb43d: Bug 1588472 - Remove unused entries from DISABLED_ATTRIBUTE_SUPPORTED_XUL. r=webdriver-reviewers,bgrins,ato
Tim Nguyen <ntim.bugs@gmail.com> - Mon, 14 Oct 2019 16:08:05 +0000 - rev 497526
Push 114152 by dvarga@mozilla.com at Tue, 15 Oct 2019 11:14:34 +0000
Bug 1588472 - Remove unused entries from DISABLED_ATTRIBUTE_SUPPORTED_XUL. r=webdriver-reviewers,bgrins,ato Differential Revision: https://phabricator.services.mozilla.com/D49131
b1d22c68b66d0ae5d1337e46adf387566d548298: Bug 1572651 - (Part 1) Add highlighter renderer base class r=jdescottes,pbro,bgrins
Razvan Caliman <rcaliman@mozilla.com> - Thu, 10 Oct 2019 21:51:42 +0000 - rev 497476
Push 114152 by dvarga@mozilla.com at Tue, 15 Oct 2019 11:14:34 +0000
Bug 1572651 - (Part 1) Add highlighter renderer base class r=jdescottes,pbro,bgrins **Update October 8** To use the new box model highlighter, flip this pref to true: `devtools.inspector.use-new-box-model-highlighter` --- Adding Julian as reviewer to check the sanity of the communication system and Patrick for the overall highlighter behavior. --- This patch adds a base class for the renderer part of highlighters which is set up on the parent process in the browser window. This is used by the `BoxModelHighlighterRender` introduced by D47092 `HighlighterRenderer.init()` will create an HTML iframe and inject it to the appropriate position in the browser window in order to serve as a rendering surface for highlighters of the inspected page content (content toolbox) or the browser UI (browser toolbox). A host iframe is used until [Bug 1492582](https://bugzilla.mozilla.org/show_bug.cgi?id=1492582) is fixed because the browser window is XUL and does not support the anonymous canvas frame used by existing highlighters. The primary use case of `HighlighterRenderer` is as a base class for renderers which live in a separate process than the observers. This happens with highlighters for the content toolbox. Therefore, it provides methods to setup a communication system (via MessageManager for now) whereby the observer can send messages to the renderer and vice-versa: `setMessageManager()`, `postMessage()` and `onMessage()`. I used the existing code from [`AccessibilityParent`](https://searchfox.org/mozilla-central/source/devtools/server/actors/accessibility/accessibility-parent.js) as a reference for this. Classes that extend HighlighterRenderer must implement: - a typeName representing the highlighter type; used to differentiate between other types of messages when the Message Manager is used; - a _buildMarkup() method to generate the highlighter markup; - a `render()` method to update the highlighter markup when given new information about the observed node. NOTE: A temporary pink outline is set on the highlighter surface as a quick visual check to show its extent depending on context: browser toolbox or content toolbox. This will be removed before landing. Differential Revision: https://phabricator.services.mozilla.com/D47091
deb30855228644a17c206a99d45ab248f05f542c: Bug 1588066 - Remove remaining references to textbox. r=surkov,emilio,webdriver-reviewers,bgrins,whimboo
Tim Nguyen <ntim.bugs@gmail.com> - Mon, 14 Oct 2019 07:41:35 +0000 - rev 497455
Push 114152 by dvarga@mozilla.com at Tue, 15 Oct 2019 11:14:34 +0000
Bug 1588066 - Remove remaining references to textbox. r=surkov,emilio,webdriver-reviewers,bgrins,whimboo Differential Revision: https://phabricator.services.mozilla.com/D48958
5ef33867cacb34b48a89fef0c5aa08f38df67544: Bug 1572651 - (Part 1) Add highlighter renderer base class r=jdescottes,pbro,bgrins
Razvan Caliman <rcaliman@mozilla.com> - Thu, 10 Oct 2019 14:13:23 +0000 - rev 497108
Push 114148 by shindli@mozilla.com at Mon, 14 Oct 2019 10:49:50 +0000
Bug 1572651 - (Part 1) Add highlighter renderer base class r=jdescottes,pbro,bgrins **Update October 8** To use the new box model highlighter, flip this pref to true: `devtools.inspector.use-new-box-model-highlighter` --- Adding Julian as reviewer to check the sanity of the communication system and Patrick for the overall highlighter behavior. --- This patch adds a base class for the renderer part of highlighters which is set up on the parent process in the browser window. This is used by the `BoxModelHighlighterRender` introduced by D47092 `HighlighterRenderer.init()` will create an HTML iframe and inject it to the appropriate position in the browser window in order to serve as a rendering surface for highlighters of the inspected page content (content toolbox) or the browser UI (browser toolbox). A host iframe is used until [Bug 1492582](https://bugzilla.mozilla.org/show_bug.cgi?id=1492582) is fixed because the browser window is XUL and does not support the anonymous canvas frame used by existing highlighters. The primary use case of `HighlighterRenderer` is as a base class for renderers which live in a separate process than the observers. This happens with highlighters for the content toolbox. Therefore, it provides methods to setup a communication system (via MessageManager for now) whereby the observer can send messages to the renderer and vice-versa: `setMessageManager()`, `postMessage()` and `onMessage()`. I used the existing code from [`AccessibilityParent`](https://searchfox.org/mozilla-central/source/devtools/server/actors/accessibility/accessibility-parent.js) as a reference for this. Classes that extend HighlighterRenderer must implement: - a typeName representing the highlighter type; used to differentiate between other types of messages when the Message Manager is used; - a _buildMarkup() method to generate the highlighter markup; - a `render()` method to update the highlighter markup when given new information about the observed node. NOTE: A temporary pink outline is set on the highlighter surface as a quick visual check to show its extent depending on context: browser toolbox or content toolbox. This will be removed before landing. Differential Revision: https://phabricator.services.mozilla.com/D47091
fc5adc9d81efa8bff98a64c33805038a4ec73c0d: Bug 1586680 - Prevent showing caret browsing prompt when using StyleEditor shortcut r=bgrins
Julian Descottes <jdescottes@mozilla.com> - Wed, 09 Oct 2019 13:00:15 +0000 - rev 496975
Push 114147 by ccoroiu@mozilla.com at Thu, 10 Oct 2019 09:56:56 +0000
Bug 1586680 - Prevent showing caret browsing prompt when using StyleEditor shortcut r=bgrins Depends on D48313 caret browsing is enabled by the F7 shortcut, and devtools style editor is toggled via shift+F7. When the DevTools toolbox is using a browser element, using shift+F7 in the toolbox will first trigger caret browsing and then toggle the style-editor. The DevTools shortcut is added via a XUL key in DevToolsStartup.jsm but I didn't manage to prevent the shift+F7 event from triggering the caret-browsing keypress callback. So instead, check if shiftKey is true in the caret-browsing callback and bail out. In theory, unless explicitly supported, the callback should bailout if any modifier is pressed. Differential Revision: https://phabricator.services.mozilla.com/D48315
7fabb89dd479e8b9745600858e6f35096fc31e3b: Bug 1587152 - Remove some dead menupopup code. r=bgrins
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 08 Oct 2019 18:08:46 +0000 - rev 496810
Push 114146 by dmajor@mozilla.com at Wed, 09 Oct 2019 17:52:49 +0000
Bug 1587152 - Remove some dead menupopup code. r=bgrins I was looking at some unsoundness in our XUL layout code just randomly setting attributes on non-anonymous nodes [1] and wondering what the acceltext attribute was used for. Found this usage which is dead, as boxObject will never return anything truthy. If nobody is missing it, we may as well remove it. [1]: https://searchfox.org/mozilla-central/rev/7cc0f0e89cb40e43bf5c96906f13d44705401042/layout/xul/nsMenuFrame.cpp#1030 Differential Revision: https://phabricator.services.mozilla.com/D48584
da50dff5f11f88f466079cc9174e80f973093153: Bug 1579709 Fix ctrl-tab with only one tab r=bgrins
Andrew Swan <aswan@mozilla.com> - Mon, 07 Oct 2019 22:28:11 +0000 - rev 496671
Push 114145 by apavel@mozilla.com at Tue, 08 Oct 2019 11:00:56 +0000
Bug 1579709 Fix ctrl-tab with only one tab r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D48451
7c3489dfee6082bec00f05d0f02f502ec4686743: Bug 1397876 - Replace panel and arrowpanel bindings with a custom element r=bgrins
Alexander Surkov <surkov.alexander@gmail.com> - Mon, 07 Oct 2019 21:57:04 +0000 - rev 496669
Push 114145 by apavel@mozilla.com at Tue, 08 Oct 2019 11:00:56 +0000
Bug 1397876 - Replace panel and arrowpanel bindings with a custom element r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D35040
eb65a610bbf2e712757984efaa88a6bce3d937d0: Bug 1586046 - sort toolkit chrome textbox tests out r=bgrins
Alexander Surkov <surkov.alexander@gmail.com> - Fri, 04 Oct 2019 21:51:06 +0000 - rev 496431
Push 114143 by rgurzau@mozilla.com at Mon, 07 Oct 2019 09:35:08 +0000
Bug 1586046 - sort toolkit chrome textbox tests out r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D48124
c923f4ce93deda79e2d699c9c28e913b35b1bcd6: Bug 1583945 - Import the RDM browser stylesheet along with the devtools-browser stylesheet. r=bgrins
Gabriel Luong <gabriel.luong@gmail.com> - Fri, 04 Oct 2019 22:29:47 +0000 - rev 496419
Push 114143 by rgurzau@mozilla.com at Mon, 07 Oct 2019 09:35:08 +0000
Bug 1583945 - Import the RDM browser stylesheet along with the devtools-browser stylesheet. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D47132
c6c4ca4c944fdb5cb7fc46423ed1fd73ad1d37eb: Bug 1586246 - Migrate autohide-context to Fluent using convert script. r=fluent-reviewers,bgrins,flod
Zibi Braniecki <zbraniecki@mozilla.com> - Fri, 04 Oct 2019 14:56:30 +0000 - rev 496330
Push 114143 by rgurzau@mozilla.com at Mon, 07 Oct 2019 09:35:08 +0000
Bug 1586246 - Migrate autohide-context to Fluent using convert script. r=fluent-reviewers,bgrins,flod Differential Revision: https://phabricator.services.mozilla.com/D48171
79e31fdfc7d1d6e2a180570d1a9f43c79bbb36db: Bug 1586141 - Remove document.createXULElement("textbox") usages from tests. r=bgrins
Tim Nguyen <ntim.bugs@gmail.com> - Fri, 04 Oct 2019 00:56:28 +0000 - rev 496262
Push 114143 by rgurzau@mozilla.com at Mon, 07 Oct 2019 09:35:08 +0000
Bug 1586141 - Remove document.createXULElement("textbox") usages from tests. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D48138
e11ca970b00b93d424a5422df890000c62304d66: Bug 1583952 - Remove XUL grid from toolkit/components/printing/content/printProgress.xul. r=bgrins
Tim Nguyen <ntim.bugs@gmail.com> - Thu, 26 Sep 2019 22:08:38 +0000 - rev 496229
Push 114143 by rgurzau@mozilla.com at Mon, 07 Oct 2019 09:35:08 +0000
Bug 1583952 - Remove XUL grid from toolkit/components/printing/content/printProgress.xul. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D47138
b58ea6f54a8bf864702f94f746fc265fbd786fc0: Bug 1585971 - Fix chrome root element styling. r=bgrins
Brendan Dahl <bdahl@mozilla.com> - Thu, 03 Oct 2019 19:39:55 +0000 - rev 496228
Push 114143 by rgurzau@mozilla.com at Mon, 07 Oct 2019 09:35:08 +0000
Bug 1585971 - Fix chrome root element styling. r=bgrins In bug 1583403, some styling was moved from a "window,dialog,wizard" section to ":root" which changed the specificity and overrode styles in common.inc.css. Changing common.inc.css to also use ":root" fixes the issue. Differential Revision: https://phabricator.services.mozilla.com/D48090
8ae524d3514d32fa19cce6db1ff7aaa32a55702c: Bug 1584795 - Add editMenuOverlay.js and globalOverlay.js to config.xul to fix context menu for Thunderbird. r=bgrins
Jorg K <jorgk@jorgk.com> - Thu, 03 Oct 2019 21:47:10 +0300 - rev 496218
Push 114143 by rgurzau@mozilla.com at Mon, 07 Oct 2019 09:35:08 +0000
Bug 1584795 - Add editMenuOverlay.js and globalOverlay.js to config.xul to fix context menu for Thunderbird. r=bgrins
1cfb94153f548ea78f67e65478d6df36ecbfc14b: Bug 1586019 - Remove textbox .plain class support. r=bgrins
Tim Nguyen <ntim.bugs@gmail.com> - Thu, 03 Oct 2019 16:21:42 +0000 - rev 496199
Push 114143 by rgurzau@mozilla.com at Mon, 07 Oct 2019 09:35:08 +0000
Bug 1586019 - Remove textbox .plain class support. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D48074
4338e87a88886959506bf6bd3fc42df8bf69e54e: Bug 1584638: Relax -mox-box blockification assertions to be debug-only. r=bgrins
Daniel Holbert <dholbert@cs.stanford.edu> - Fri, 27 Sep 2019 21:31:04 +0000 - rev 495444
Push 114134 by ccoroiu@mozilla.com at Mon, 30 Sep 2019 09:57:15 +0000
Bug 1584638: Relax -mox-box blockification assertions to be debug-only. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D47505