searching for reviewer(bent)
5143234fc6be8c842fa6ac7df75260fa7d43cfaa: Bug 1253807 - Use the shared UniqueFreePtr class r=bent
Gabriele Svelto <gsvelto@mozilla.com> - Wed, 09 Mar 2016 12:24:03 +0100 - rev 287473
Push 73187 by gsvelto@mozilla.com at Wed, 09 Mar 2016 11:24:19 +0000
Bug 1253807 - Use the shared UniqueFreePtr class r=bent
4c93d1b63dd85638db65af83774a500dd178ff25: Bug 1085575: Account for another potential race when asserting metadata is consistent. r=bent
Kyle Huey <khuey@kylehuey.com> - Tue, 23 Feb 2016 11:56:16 -0800 - rev 285205
Push 72273 by khuey@mozilla.com at Tue, 23 Feb 2016 19:56:42 +0000
Bug 1085575: Account for another potential race when asserting metadata is consistent. r=bent
62a1b39559a7403587a1a5cfe3b16305376d3259: Bug 1150737: Make executeSoon work properly on workers, enable tests. r=bent
Kyle Huey <khuey@kylehuey.com> - Wed, 10 Feb 2016 22:35:50 -0800 - rev 283860
Push 71735 by khuey@mozilla.com at Thu, 11 Feb 2016 06:36:52 +0000
Bug 1150737: Make executeSoon work properly on workers, enable tests. r=bent
4a5dfc998bf4a41e539988b8165d2efc0411f07c: Bug 1059469: Part 2 - When rescheduling the interval timer, cancel it first, and refactor things so that actually does something. r=bent
Kyle Huey <khuey@kylehuey.com> - Wed, 06 Jan 2016 13:18:29 -0800 - rev 278803
Push 69888 by khuey@mozilla.com at Wed, 06 Jan 2016 21:18:57 +0000
Bug 1059469: Part 2 - When rescheduling the interval timer, cancel it first, and refactor things so that actually does something. r=bent RunExpiredTimeouts has "fudging" code to always ensure that we execute at least one timeout. This is intended to cover cases where an nsITimer fires slightly early, but it means we must be careful not to fire a timer more times than we intend to or we'll execute a timeout prematurely. Consider a sequences of setTimeout calls alternating in delay between 0ms and 1000ms. When the 1000ms timeout fires, it schedules a 0ms timeout. The setTimeout call itself calls RescheduleTimeoutTimer, which schedules the timer for a 0 ms delay. And once we unwind the 1000ms timeout RunExpiredTimeouts will also schedule the timer for a 0 ms delay. If the timer has fired (remember, it's processed on a completely different thread) in the meantime, we ultimately will get two callbacks from nsITimer for our 0 ms timeout. The first will run the 0 ms timeout and schedule a 1000 ms timeout, and the second will run the 1000 ms timeout (remember, RunExpiredTimeouts always runs at least one timeout!) ~999 ms ahead of schedule. The solution is to cancel the timer in RescheduleTimeoutTimer, so that when we call it the second time it will cause any pending events from the first scheduling to be canceled. But this actually doesn't work at all, because of how we use nsITimer. Before worker threads were capable of accepting arbitrary runnables we created TimerThreadEventTarget, which translates the timer firing to the special worker event queue when the timer thread attempts to *dispatch* a runnable to the worker. We still need this for some of the other types of timers (which use control runnables that interrupt JS, and not the regular event queue). But setTimeout can simply run like a normal nsITimer callback now. We need that here, or calling nsITimer::Cancel won't actually do anything, because the timer's event was ignored and TimerThreadEventTarget created its own event.
aadea6a5781c963f782fa3bd4c7c046c8ff658e8: Bug 1059469: Part 1 - Add a log module for dump() calls. r=bent
Kyle Huey <khuey@kylehuey.com> - Wed, 06 Jan 2016 13:18:29 -0800 - rev 278802
Push 69888 by khuey@mozilla.com at Wed, 06 Jan 2016 21:18:57 +0000
Bug 1059469: Part 1 - Add a log module for dump() calls. r=bent
c33072613b5e7f60db7c324bdb79b558a0a1d50e: Bug 1211266 - Remote blobs coming from a different thread and a different manager must be kept alive until the creation of depending RemoteBlobs is not completed, r=bent, f=gerard-majax
Andrea Marchesini <amarchesini@mozilla.com> - Sat, 28 Nov 2015 10:48:28 +0000 - rev 274498
Push 68607 by amarchesini@mozilla.com at Sat, 28 Nov 2015 10:48:44 +0000
Bug 1211266 - Remote blobs coming from a different thread and a different manager must be kept alive until the creation of depending RemoteBlobs is not completed, r=bent, f=gerard-majax
8405467ea7adc556cf29e677243ed86a5bf0e1bb: Bug 1211266 - Remote blobs coming from a different thread and a different manager must be kept alive until the creation of depending RemoteBlobs is not completed, r=bent, f=gerard-majax
Andrea Marchesini <amarchesini@mozilla.com> - Wed, 25 Nov 2015 17:48:19 +0000 - rev 274185
Push 68508 by amarchesini@mozilla.com at Wed, 25 Nov 2015 17:49:00 +0000
Bug 1211266 - Remote blobs coming from a different thread and a different manager must be kept alive until the creation of depending RemoteBlobs is not completed, r=bent, f=gerard-majax
79004346238d8aa8e571105ae9150b8a432aad19: Bug 1211266 - Remote blobs coming from a different thread and a different manager must be kept alive until the creation of depending RemoteBlobs is not completed, r=bent, f=gerard-majax
Andrea Marchesini <amarchesini@mozilla.com> - Wed, 25 Nov 2015 17:15:16 +0000 - rev 274179
Push 68504 by amarchesini@mozilla.com at Wed, 25 Nov 2015 17:15:32 +0000
Bug 1211266 - Remote blobs coming from a different thread and a different manager must be kept alive until the creation of depending RemoteBlobs is not completed, r=bent, f=gerard-majax
cbc2c8a244380a83ba857d0c315462490b1652e8: Bug 1211266 - Remote blobs coming from a different thread and a different manager must be kept alive until the creation of depending RemoteBlobs is not completed, r=bent, f=gerard-majax
Andrea Marchesini <amarchesini@mozilla.com> - Tue, 24 Nov 2015 19:51:28 +0000 - rev 273963
Push 68453 by amarchesini@mozilla.com at Tue, 24 Nov 2015 19:52:12 +0000
Bug 1211266 - Remote blobs coming from a different thread and a different manager must be kept alive until the creation of depending RemoteBlobs is not completed, r=bent, f=gerard-majax
4c0e0c5176e9c8ece837393a916f8ef52f4dc473: Bug 1101264: Truncate long sourceName messages since they can be massive data: URLs. r=bent
David Major <dmajor@mozilla.com> - Fri, 25 Sep 2015 15:55:34 -0400 - rev 264480
Push 65646 by dmajor@mozilla.com at Fri, 25 Sep 2015 19:55:56 +0000
Bug 1101264: Truncate long sourceName messages since they can be massive data: URLs. r=bent
a29378ef825e59f8042d0cb4b202061130fcbec0: Bug 1179505 - Make LoadInfo arguments optional in ipdl (r=bent,sicking)
Christoph Kerschbaumer <mozilla@christophkerschbaumer.com> - Mon, 13 Jul 2015 22:43:13 -0700 - rev 252697
Push 62221 by mozilla@christophkerschbaumer.com at Tue, 14 Jul 2015 05:56:23 +0000
Bug 1179505 - Make LoadInfo arguments optional in ipdl (r=bent,sicking)
05a59f43bb0291b9568fc563f04af24130cc7d6d: Bug 1168606 - Part 2: Convert DelayedDeleteRunnable into reusable DelayedActionRunnable class. r=bent
Birunthan Mohanathas <birunthan@mohanathas.com> - Tue, 09 Jun 2015 07:57:19 -0700 - rev 251781
Push 61942 by birunthan@mohanathas.com at Tue, 07 Jul 2015 18:27:45 +0000
Bug 1168606 - Part 2: Convert DelayedDeleteRunnable into reusable DelayedActionRunnable class. r=bent
e99b141dd96ba72fc19efaa2d0196aed6474114f: Bug 1168606 - Part 1: Extract Cursor response data population into shared function. r=bent
Birunthan Mohanathas <birunthan@mohanathas.com> - Tue, 07 Jul 2015 11:27:04 -0700 - rev 251780
Push 61942 by birunthan@mohanathas.com at Tue, 07 Jul 2015 18:27:45 +0000
Bug 1168606 - Part 1: Extract Cursor response data population into shared function. r=bent
c7002e70d94953f0240ba31c79c3cfda0015bcaa: Bug 1143575. Avoid use of COMPARE macro which can clash with Android headers. r=bent
Robert O'Callahan <robert@ocallahan.org> - Sun, 07 Jun 2015 12:26:40 +0300 - rev 251605
Push 61921 by rocallahan@mozilla.com at Tue, 07 Jul 2015 07:13:27 +0000
Bug 1143575. Avoid use of COMPARE macro which can clash with Android headers. r=bent
9e6b4d673d203d0415ebeb6562e460555797049d: Bug 1179379 - PhonenumberJS: Update Metadata. r=bent
Gregor Wagner <anygregor@gmail.com> - Mon, 06 Jul 2015 10:12:37 -0700 - rev 251556
Push 61905 by kwierso@gmail.com at Tue, 07 Jul 2015 00:20:48 +0000
Bug 1179379 - PhonenumberJS: Update Metadata. r=bent
335fe5e5e8e5ab88fa11119f27432345291985ce: Bug 1176434 - Enabling indexedDB for content JS sandboxes, r=bent
Martin Thomson <martin.thomson@gmail.com> - Thu, 02 Jul 2015 13:30:15 -0700 - rev 251190
Push 61788 by martin.thomson@gmail.com at Thu, 02 Jul 2015 20:30:40 +0000
Bug 1176434 - Enabling indexedDB for content JS sandboxes, r=bent
877583d2073486d289a1810f7f91f1a28d8c0d2e: Bug 1176096 - Ensure we don't do self-moves in move assignment (r=bent)
Bill McCloskey <billm@mozilla.com> - Mon, 29 Jun 2015 13:43:42 -0700 - rev 250965
Push 61725 by wmccloskey@mozilla.com at Wed, 01 Jul 2015 20:31:00 +0000
Bug 1176096 - Ensure we don't do self-moves in move assignment (r=bent)
f87683a37d20fea4c45963bd1288c5e29faf220e: Bug 1178806. IndexedDB autoincrement overflow should be throwing ConstraintError per spec. r=bent
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 01 Jul 2015 00:15:30 -0400 - rev 250832
Push 61679 by bzbarsky@mozilla.com at Wed, 01 Jul 2015 04:15:47 +0000
Bug 1178806. IndexedDB autoincrement overflow should be throwing ConstraintError per spec. r=bent
8c5644f340d7d1d64bb0f2db50134f36d9ca48ae: Bug 1178803. Fix the handling of the 'length' key in IDB keypaths when operating on a string. r=bent
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 01 Jul 2015 00:15:30 -0400 - rev 250831
Push 61679 by bzbarsky@mozilla.com at Wed, 01 Jul 2015 04:15:47 +0000
Bug 1178803. Fix the handling of the 'length' key in IDB keypaths when operating on a string. r=bent
3b9be17895cbc294896b2fb83a239e30aad1dcc6: Bug 1174803 - Simplify RuntimeService::WorkerPrefChanged. r=bent
Birunthan Mohanathas <birunthan@mohanathas.com> - Tue, 30 Jun 2015 11:16:03 -0700 - rev 250737
Push 61643 by birunthan@mohanathas.com at Tue, 30 Jun 2015 18:16:26 +0000
Bug 1174803 - Simplify RuntimeService::WorkerPrefChanged. r=bent
2327a71054765cd599b0cb7d717a4bc1edb12433: Bug 1170021 - Part 2: Move DirectoryLock out of QuotaManager class; r=bent
Jan Varga <jan.varga@gmail.com> - Tue, 30 Jun 2015 14:59:53 +0200 - rev 250697
Push 61626 by Jan.Varga@gmail.com at Tue, 30 Jun 2015 13:11:05 +0000
Bug 1170021 - Part 2: Move DirectoryLock out of QuotaManager class; r=bent
c1bc9e9c1c92d51907af9a772ed4358bcfc3cc57: Bug 1170021 - Part 1: Merge QuotaManager with QuotaObject; r=bent
Jan Varga <jan.varga@gmail.com> - Tue, 30 Jun 2015 14:59:42 +0200 - rev 250696
Push 61626 by Jan.Varga@gmail.com at Tue, 30 Jun 2015 13:11:05 +0000
Bug 1170021 - Part 1: Merge QuotaManager with QuotaObject; r=bent
c9b3704bd0ed90f0e737a25f889c25a425075455: Bug 1130775 - Convert synchronized ops and storage registration into unified directory locks; r=bent
Jan Varga <jan.varga@gmail.com> - Tue, 30 Jun 2015 14:59:27 +0200 - rev 250695
Push 61626 by Jan.Varga@gmail.com at Tue, 30 Jun 2015 13:11:05 +0000
Bug 1130775 - Convert synchronized ops and storage registration into unified directory locks; r=bent
98d916640208e1a724b99504cbccfda1cb391708: Bug 1178514 - Mark one-argument constructors in IPDL tests as 'explicit'. r=bent
Botond Ballo <botond@mozilla.com> - Mon, 29 Jun 2015 18:29:48 -0400 - rev 250595
Push 61600 by bballo@mozilla.com at Mon, 29 Jun 2015 23:14:12 +0000
Bug 1178514 - Mark one-argument constructors in IPDL tests as 'explicit'. r=bent
3723cf728d14127f9385b313bfcb27d95161704c: Bug 1167650 - Expose DOMRequest and DOMCursor to workers. r=bent
Andrew Osmond <aosmond@mozilla.com> - Sun, 28 Jun 2015 09:34:01 -0700 - rev 250478
Push 61573 by cbook@mozilla.com at Mon, 29 Jun 2015 12:19:41 +0000
Bug 1167650 - Expose DOMRequest and DOMCursor to workers. r=bent
bda3c545aa48d1006c704f0b5cfdbd2d9c583356: Bug 1176034 - MessagePort should force a close() if the structured clone algorithm fails, r=bent
Andrea Marchesini <amarchesini@mozilla.com> - Tue, 23 Jun 2015 15:50:00 -0700 - rev 250051
Push 61433 by amarchesini@mozilla.com at Wed, 24 Jun 2015 11:46:51 +0000
Bug 1176034 - MessagePort should force a close() if the structured clone algorithm fails, r=bent
4f4ceae7be1a481e0df0f53a7e87c34d33561bf5: Bug 1176034 - MessagePort should force a close() if the structured clone algorithm fails, r=bent
Andrea Marchesini <amarchesini@mozilla.com> - Tue, 23 Jun 2015 15:50:00 -0700 - rev 250016
Push 61417 by amarchesini@mozilla.com at Wed, 24 Jun 2015 00:22:29 +0000
Bug 1176034 - MessagePort should force a close() if the structured clone algorithm fails, r=bent
f25d12a330d60681967b721cb8a1291c5f868ba4: Bug 1175352 - Refactor LoadInfo arguments to be more self contained (r=bent)
Christoph Kerschbaumer <mozilla@christophkerschbaumer.com> - Thu, 18 Jun 2015 15:37:20 -0700 - rev 249673
Push 61314 by mozilla@christophkerschbaumer.com at Fri, 19 Jun 2015 06:10:21 +0000
Bug 1175352 - Refactor LoadInfo arguments to be more self contained (r=bent)
964d75a56702a7b552e572ba30153ca6b2038fb4: Bug 911972 - MessagePort and MessageChannel in workers, r=smaug, r=bent
Andrea Marchesini <amarchesini@mozilla.com> - Wed, 17 Jun 2015 11:44:27 +0100 - rev 249279
Push 61202 by amarchesini@mozilla.com at Wed, 17 Jun 2015 10:46:19 +0000
Bug 911972 - MessagePort and MessageChannel in workers, r=smaug, r=bent
30d3e9d41e8276f3a09a5a509f3f3c540daf85e9: Bug 1142694 - QuotaManager default/temporary initialization fails on some profiles; r=bent
Jan Varga <jan.varga@gmail.com> - Tue, 16 Jun 2015 06:42:06 +0200 - rev 249007
Push 61120 by Jan.Varga@gmail.com at Tue, 16 Jun 2015 04:43:11 +0000
Bug 1142694 - QuotaManager default/temporary initialization fails on some profiles; r=bent
1d67d747b3eba11d8a9ba766abb19eb2ebcd0676: Bug 911972 - MessagePort and MessageChannel in workers, r=smaug, r=bent
Andrea Marchesini <amarchesini@mozilla.com> - Mon, 15 Jun 2015 14:08:25 +0100 - rev 248807
Push 61066 by amarchesini@mozilla.com at Mon, 15 Jun 2015 13:08:44 +0000
Bug 911972 - MessagePort and MessageChannel in workers, r=smaug, r=bent
281a5a64be5e4c30d551c3605f996352ee0cc483: Bug 1169867 - XMLHttpRequest::SendInternal should not unpin itself when the worker goes away. r=bent
Andrea Marchesini <amarchesini@mozilla.com> - Fri, 12 Jun 2015 10:06:19 -0400 - rev 248543
Push 60998 by ryanvm@gmail.com at Fri, 12 Jun 2015 14:06:23 +0000
Bug 1169867 - XMLHttpRequest::SendInternal should not unpin itself when the worker goes away. r=bent
b93ec2ad9a08d86f5a2dc773e0d10b0a4191b165: Bug 1174113 - QuotaManager: Origin initialization fails on moz-safe-about+++home; r=bent
Jan Varga <jan.varga@gmail.com> - Fri, 12 Jun 2015 12:00:53 +0200 - rev 248525
Push 60989 by Jan.Varga@gmail.com at Fri, 12 Jun 2015 10:01:11 +0000
Bug 1174113 - QuotaManager: Origin initialization fails on moz-safe-about+++home; r=bent
be976c7cb4b1ff8d4f26c0f33d780950ec491f3b: Bug 1161063; r=bent
Jan Varga <jan.varga@gmail.com> - Thu, 11 Jun 2015 22:34:30 +0200 - rev 248501
Push 60974 by Jan.Varga@gmail.com at Fri, 12 Jun 2015 05:05:18 +0000
Bug 1161063; r=bent
219780d1c8fd5edeceebcd6fe1f3cfc6ff1e0d77: Bug 1137245 - ServiceWorkerManager should set WorkerPrivate::LoadInfo::mIndexedDBAllowed correctly. r=bent, bkelly
Fernando Jimenez <ferjmoreno@gmail.com> - Thu, 11 Jun 2015 15:32:54 +0200 - rev 248288
Push 60927 by ferjmoreno@gmail.com at Thu, 11 Jun 2015 13:33:08 +0000
Bug 1137245 - ServiceWorkerManager should set WorkerPrivate::LoadInfo::mIndexedDBAllowed correctly. r=bent, bkelly
1c9478931a9463d292e0d5dc5a20097be06f38f8: Bug 1170746 - Getting mutable files over a cursor crashes the browser; r=bent
Jan Varga <jan.varga@gmail.com> - Thu, 11 Jun 2015 11:49:51 +0200 - rev 248256
Push 60918 by Jan.Varga@gmail.com at Thu, 11 Jun 2015 09:50:11 +0000
Bug 1170746 - Getting mutable files over a cursor crashes the browser; r=bent
f537b304247e9f275459a24a76afd50ef58aa1a7: Bug 1158133 - Add a way to disable async stacks, and disable by default on mobile platforms. r=bent,jimb
Paolo Amadini <paolo.mozmail@amadzone.org> - Tue, 09 Jun 2015 11:17:09 +0200 - rev 248146
Push 60888 by kwierso@gmail.com at Thu, 11 Jun 2015 01:38:38 +0000
Bug 1158133 - Add a way to disable async stacks, and disable by default on mobile platforms. r=bent,jimb
c4db01ea9e6c80e2b269549abeec1d4aea34eab7: Bug 1170746 - Getting mutable files over a cursor crashes the browser; r=bent
Jan Varga <jan.varga@gmail.com> - Wed, 10 Jun 2015 22:48:06 +0200 - rev 247987
Push 60869 by Jan.Varga@gmail.com at Wed, 10 Jun 2015 20:48:45 +0000
Bug 1170746 - Getting mutable files over a cursor crashes the browser; r=bent
acd94173f7e1cc0cd1f38ea844bccb2f6827e35e: Bug 1157670 - Fixing an incorrect assertion in QuotaManager.cpp leads to an assertion failure; r=bent
Jan Varga <jan.varga@gmail.com> - Tue, 09 Jun 2015 17:27:50 +0200 - rev 247873
Push 60823 by Jan.Varga@gmail.com at Wed, 10 Jun 2015 04:20:23 +0000
Bug 1157670 - Fixing an incorrect assertion in QuotaManager.cpp leads to an assertion failure; r=bent
eefcbe8e6a0cb28ebc739d4b40f8a066bdf529f0: Bug 1109338: Part 2: Sharing UDPSocket between PNecko and PBackground r=bent
Randell Jesup <rjesup@jesup.org> - Fri, 29 May 2015 10:14:14 -0400 - rev 246277
Push 60391 by rjesup@wgate.com at Fri, 29 May 2015 14:14:52 +0000
Bug 1109338: Part 2: Sharing UDPSocket between PNecko and PBackground r=bent
635ef933d0d519ff0df2f9044400792d9bfa67af: Bug 1166924 part 0 r=bent
Andrea Marchesini <amarchesini@mozilla.com> - Wed, 27 May 2015 14:21:44 -0700 - rev 245792
Push 60291 by kwierso@gmail.com at Wed, 27 May 2015 21:34:37 +0000
Bug 1166924 part 0 r=bent
0db3b7dbcdf64c8c4b56003105ad696c491a246b: Bug 1167396 - Make ProtocolCloneContext::mContentParent a smart pointer. r=bent
Michael Layzell <michael@thelayzells.com> - Fri, 22 May 2015 10:10:00 -0400 - rev 245478
Push 60185 by ryanvm@gmail.com at Mon, 25 May 2015 14:49:28 +0000
Bug 1167396 - Make ProtocolCloneContext::mContentParent a smart pointer. r=bent
4ee8035b043d3d7c4bd2d410253b29c606f763ad: Bug 1154974 (Part 1) - Give blobs serial numbers. r=bent
Seth Fowler <mark.seth.fowler@gmail.com> - Wed, 20 May 2015 18:49:50 -0700 - rev 244885
Push 60050 by mfowler@mozilla.com at Thu, 21 May 2015 01:50:12 +0000
Bug 1154974 (Part 1) - Give blobs serial numbers. r=bent
f1eec08c595b523c14b967f98c08dd5ebed58efd: Bug 803783 - Send message manager results via structured clone (r=bent)
Bill McCloskey <billm@mozilla.com> - Wed, 29 Apr 2015 20:39:59 -0700 - rev 243341
Push 59657 by wmccloskey@mozilla.com at Tue, 12 May 2015 00:19:43 +0000
Bug 803783 - Send message manager results via structured clone (r=bent)
3d43ed34435515e4fd18937281f882bd8f4a431a: Bug 1162624 - Add support for restoring corrupted or missing metadata files; r=bent
Jan Varga <jan.varga@gmail.com> - Fri, 08 May 2015 21:05:30 +0200 - rev 243050
Push 59571 by Jan.Varga@gmail.com at Fri, 08 May 2015 19:05:56 +0000
Bug 1162624 - Add support for restoring corrupted or missing metadata files; r=bent
522f3549ec5b993c809486dc3dbe9fa7da0c7c00: Bug 1156875 - patch 2 - Unify the registration of blob URIs in WorkerPrivate and nsIGlobalObject, r=bent
Andrea Marchesini <amarchesini@mozilla.com> - Thu, 07 May 2015 08:06:24 +0100 - rev 242686
Push 59480 by amarchesini@mozilla.com at Thu, 07 May 2015 09:11:48 +0000
Bug 1156875 - patch 2 - Unify the registration of blob URIs in WorkerPrivate and nsIGlobalObject, r=bent
9641952c788f9a6ba52f7d773b2887d6d0493641: Bug 1151495 - Support permission prompting from workers for IDB, r=bent
Andrea Marchesini <amarchesini@mozilla.com> - Wed, 06 May 2015 09:07:57 +0100 - rev 242524
Push 59428 by amarchesini@mozilla.com at Wed, 06 May 2015 10:06:09 +0000
Bug 1151495 - Support permission prompting from workers for IDB, r=bent
b85b9b590db0a9f1e45e5233e165da2e79ac012b: Bug 1156847 - Part 2: Store the security info for a service worker on its WorkerPrivate; r=bent,khuey
Ehsan Akhgari <ehsan@mozilla.com> - Thu, 23 Apr 2015 18:59:52 -0400 - rev 241655
Push 59189 by eakhgari@mozilla.com at Thu, 30 Apr 2015 00:22:42 +0000
Bug 1156847 - Part 2: Store the security info for a service worker on its WorkerPrivate; r=bent,khuey
2696c3d2ee5118bc1be664eb9528485584b58d8a: Bug 1159303 - Reduce noise due to sort operations warnings. r=bent
Marco Bonardo <mbonardo@mozilla.com> - Tue, 28 Apr 2015 22:35:48 +0200 - rev 241613
Push 59184 by kwierso@gmail.com at Wed, 29 Apr 2015 23:54:41 +0000
Bug 1159303 - Reduce noise due to sort operations warnings. r=bent
abdd5415502397ae44219c86eecee4741e4c7133: Bug 1158905 - remove dead code from protocol Transition functions; r=bent
Nathan Froyd <froydnj@mozilla.com> - Mon, 27 Apr 2015 13:29:37 -0400 - rev 241398
Push 59103 by nfroyd@mozilla.com at Tue, 28 Apr 2015 12:57:39 +0000
Bug 1158905 - remove dead code from protocol Transition functions; r=bent PFoo::Transition currently looks something like: bool Transition( State from, mozilla::ipc::Trigger trigger, State* next) { switch (from) { ... default: NS_RUNTIMEABORT("corrupted actor state"); return false; } (*(next)) = __Error; return false; } Coverity complains that the assignment (*(next)) = __Error will never be reached, and rightfully so. We can remove this fallthrough block when there are no states declared in the individual protocol.