searching for reviewer(alwu)
2d4bb8556f0815eb766b781b9d0bf9e086d2cc0d: Bug 1172394 - Ignore video tracks in autoplay checks in MediaStreamAudioSourceNode. r=alwu
Andreas Pehrson <apehrson@mozilla.com> - Wed, 13 Nov 2019 22:39:53 +0000 - rev 501960
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1172394 - Ignore video tracks in autoplay checks in MediaStreamAudioSourceNode. r=alwu Differential Revision: https://phabricator.services.mozilla.com/D52048
d0aa43657e8cb3f06eafe5c537dc64ff1499a353: Bug 1172394 - Ignore video tracks in autoplay checks in MediaStreamAudioSourceNode. r=alwu
Andreas Pehrson <apehrson@mozilla.com> - Wed, 13 Nov 2019 08:58:21 +0000 - rev 501793
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1172394 - Ignore video tracks in autoplay checks in MediaStreamAudioSourceNode. r=alwu Differential Revision: https://phabricator.services.mozilla.com/D52048
6b0a3059d313caa54bb34179f80430201859596c: Bug 1588002 - Make sure to remove every nsIDOMMozWakeLockListener added by browser_media_wakelock.js even if a notification is not seen. r=alwu
Mike Conley <mconley@mozilla.com> - Mon, 28 Oct 2019 20:41:36 +0000 - rev 499511
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1588002 - Make sure to remove every nsIDOMMozWakeLockListener added by browser_media_wakelock.js even if a notification is not seen. r=alwu Differential Revision: https://phabricator.services.mozilla.com/D48931
c65ef27b6fc78ec5140068913209bad3b55f1139: Bug 1591712 - Remove useless OwnerDoc() checks in MediaPlayackDelayPolicy. r=alwu
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 28 Oct 2019 17:29:08 +0000 - rev 499469
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1591712 - Remove useless OwnerDoc() checks in MediaPlayackDelayPolicy. r=alwu OwnerDoc() always return non-null. Differential Revision: https://phabricator.services.mozilla.com/D50703
8e94e62b2ab102c32c222dcef1dfa32364e9164b: Bug 1580695 - Revert bug 1533129. r=alwu,bryce
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 24 Oct 2019 22:50:35 +0000 - rev 499176
Push 114161 by ncsoregi@mozilla.com at Tue, 29 Oct 2019 21:34:24 +0000
Bug 1580695 - Revert bug 1533129. r=alwu,bryce This change was a workaround a Youtube bug that expected a particular behaviour from old TV and that we were exploiting. It was adding support for unsupported, unofficial code. MediaCapabilities is how things should be done. Making this code to work conditionally is too much effort. Reverting it entirely is easier. Differential Revision: https://phabricator.services.mozilla.com/D49515
d92b15efc8b452e9cac2cba12b83c72a913be6b9: Bug 1583861 - Replace usages of GMP_LOG with GMP_LOG_DEBUG and remove GMP_LOG. r=alwu
Bryce Seager van Dyk <bvandyk@mozilla.com> - Fri, 27 Sep 2019 17:57:24 +0000 - rev 495423
Push 114134 by ccoroiu@mozilla.com at Mon, 30 Sep 2019 09:57:15 +0000
Bug 1583861 - Replace usages of GMP_LOG with GMP_LOG_DEBUG and remove GMP_LOG. r=alwu Now that we have explicit macros for each GMP_LOG level GMP_LOG and GMP_LOG_DEBUG are doing the same thing. This patch replaces all instances of GMP_LOG with GMP_LOG_DEBUG. This has the benefit of all uses of the GMP macros sharing a consistent naming convention and being explicit about the level they're logging at. Since we no longer use GMP_LOG() anywhere, remove it. Differential Revision: https://phabricator.services.mozilla.com/D47374
0a0ff7a39921537ee61d597232876077e153f7a4: Bug 1583861 - Tidy includes in files using new logs. r=alwu
Bryce Seager van Dyk <bvandyk@mozilla.com> - Fri, 27 Sep 2019 00:14:23 +0000 - rev 495422
Push 114134 by ccoroiu@mozilla.com at Mon, 30 Sep 2019 09:57:15 +0000
Bug 1583861 - Tidy includes in files using new logs. r=alwu I've reworked the includes in most of the files I've touched since I was adding GMPLog.h: - Reordered the includes to better match the Google C++ style. - Removed includes that are already included from the associated header or GMPLog.h. I.e. if Foo.cpp includes Foo.h, and Foo.cpp includes other headers already included in Foo.h, these were removed. Depends on D47194 Differential Revision: https://phabricator.services.mozilla.com/D47373
e146d1355850256fa6220d5b4d4cf75217f309ed: Bug 1583861 - Use GMPLog.h macros where applicable. r=alwu
Bryce Seager van Dyk <bvandyk@mozilla.com> - Fri, 27 Sep 2019 00:14:46 +0000 - rev 495421
Push 114134 by ccoroiu@mozilla.com at Mon, 30 Sep 2019 09:57:15 +0000
Bug 1583861 - Use GMPLog.h macros where applicable. r=alwu This patch changes instances where the GMP MOZ_LOG is used to prefer using macros from GMPLog.h: - Files that don't need their own macros now just directly call `GMP_LOG_<LEVEL>` as required. - Files that use their own macros for formatting have had those macro definitions changes so that the macros have unique names and are expressed in terms of the macros from GMPLog.h. I've also made a couple of drive by edits to logs so that they log more than a couple of words and updated some strings where the incorrect class name was being logged. Differential Revision: https://phabricator.services.mozilla.com/D47194
d2c33136e60fac134d4ec8b60a551f38cd463ec4: Bug 1583861 - Add different log level macros to GMPLog.h r=alwu
Bryce Seager van Dyk <bvandyk@mozilla.com> - Fri, 27 Sep 2019 15:23:07 +0000 - rev 495420
Push 114134 by ccoroiu@mozilla.com at Mon, 30 Sep 2019 09:57:15 +0000
Bug 1583861 - Add different log level macros to GMPLog.h r=alwu Differential Revision: https://phabricator.services.mozilla.com/D47193
ffa5b20081151082d82db29d92f12b0f863baa3b: Bug 1583861 - Rework GMPLog.h include guard to follow Google C++ style. r=alwu
Bryce Seager van Dyk <bvandyk@mozilla.com> - Thu, 26 Sep 2019 23:55:08 +0000 - rev 495419
Push 114134 by ccoroiu@mozilla.com at Mon, 30 Sep 2019 09:57:15 +0000
Bug 1583861 - Rework GMPLog.h include guard to follow Google C++ style. r=alwu Differential Revision: https://phabricator.services.mozilla.com/D47192
e56ef27b142a02fe06c83dd12b800d997abba3c3: Bug 1582617 - Split up assertions in browser_multiselect_tabs_mute_unmute.js. r=alwu
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 20 Sep 2019 05:17:55 +0000 - rev 494189
Push 114108 by dvarga@mozilla.com at Fri, 20 Sep 2019 09:59:36 +0000
Bug 1582617 - Split up assertions in browser_multiselect_tabs_mute_unmute.js. r=alwu I have to debug this test and some of these are failing. It'd be good to know which one of these fail separately. Differential Revision: https://phabricator.services.mozilla.com/D46558
2e6f8b858af7f55dcef9dc4af05c8f3250e5710b: Bug 1580112 - Stop updating the database when the value has not changed. r=alwu
Alex Chronopoulos <achronop@gmail.com> - Wed, 11 Sep 2019 20:21:51 +0000 - rev 492797
Push 114076 by ncsoregi@mozilla.com at Thu, 12 Sep 2019 15:29:15 +0000
Bug 1580112 - Stop updating the database when the value has not changed. r=alwu In most of the cases, the value to be stored is the same as the existing value, which does not require an update to the database. Setting something in the database requires disk access. By using this we avoid accessing the disk in the majority of the cases. Differential Revision: https://phabricator.services.mozilla.com/D45504
0d5c063c17b49d4be792578849376d95a7e5e40a: Bug 1571821 - Use total frames instead of parsed frames to calculate benchmark. r=alwu
Alex Chronopoulos <achronop@gmail.com> - Mon, 09 Sep 2019 20:08:59 +0000 - rev 492458
Push 114063 by malexandru@mozilla.com at Tue, 10 Sep 2019 15:57:55 +0000
Bug 1571821 - Use total frames instead of parsed frames to calculate benchmark. r=alwu The problem reproduces when the system is loaded and the decoder is dropping most of the frames. When there are two benchmark calculations close to each other, the measured parsed frames of the first calculation can be buffered in the decoder and reported as dropped frames on the second calculation. Then on the second calculation, the number of dropped frames can be greater than the parsed frame which will hit the assert. The number of total frames is a better measure since it counts the frames that appeared in the in VideoSink plus the total dropped frames. Differential Revision: https://phabricator.services.mozilla.com/D44478
ab1e0dacd90a8a729b064755a70c8af73618e634: Bug 1576627 - Move MaybeNotifyAutoplayBlocked from Document to HTMLMediaElement; r=alwu
Edgar Chen <echen@mozilla.com> - Tue, 27 Aug 2019 21:22:19 +0000 - rev 490503
Push 113995 by ccoroiu@mozilla.com at Thu, 29 Aug 2019 04:13:32 +0000
Bug 1576627 - Move MaybeNotifyAutoplayBlocked from Document to HTMLMediaElement; r=alwu Given that it is used only in HTMLMediaElement. Differential Revision: https://phabricator.services.mozilla.com/D43452
4f5115932bdac48f923c48f7a4843f5925e131e2: Bug 1562990 - Remove 'audioMuted' and 'audioVolume' properties from nsIDOMWindowUtils. r=NeilDeakin,alwu,farre
Abdoulaye O. Ly <ablayelyfondou@gmail.com> - Mon, 19 Aug 2019 21:17:21 +0000 - rev 488818
Push 113926 by ccoroiu@mozilla.com at Tue, 20 Aug 2019 03:58:58 +0000
Bug 1562990 - Remove 'audioMuted' and 'audioVolume' properties from nsIDOMWindowUtils. r=NeilDeakin,alwu,farre While working on porting the (audio-playback indicators) bug 1562990 to fission, we saw the potential to delete some methods in nsIDOMWindowUtils because they were not used anymore in our codebase except in a couple of tests files. So now, we should only mute/unmute or change the volume in the parent process. As such, interfaces are added in SpecialPowers to change media muted or volume state from content processes. Differential Revision: https://phabricator.services.mozilla.com/D41782
9d89249349d07225b6f5e34381ddbb9044ef2912: Bug 1573976 - Update hdcp version strings used in GetStatusForPolicy. r=dminor,alwu
Bryce Seager van Dyk <bvandyk@mozilla.com> - Fri, 16 Aug 2019 17:17:32 +0000 - rev 488758
Push 113922 by opoprus@mozilla.com at Mon, 19 Aug 2019 22:15:45 +0000
Bug 1573976 - Update hdcp version strings used in GetStatusForPolicy. r=dminor,alwu These strings are detailed at https://github.com/WICG/hdcp-detection/blob/master/explainer.md, and were changed since the original implementation of this feature. Differential Revision: https://phabricator.services.mozilla.com/D42062
9666df4faff79b8883397e1210673a9a325b3106: Bug 1573976 - Fix GetStatusForPolicy handling of unrecognized values. r=dminor,alwu
Bryce Seager van Dyk <bvandyk@mozilla.com> - Fri, 16 Aug 2019 17:47:21 +0000 - rev 488757
Push 113922 by opoprus@mozilla.com at Mon, 19 Aug 2019 22:15:45 +0000
Bug 1573976 - Fix GetStatusForPolicy handling of unrecognized values. r=dminor,alwu GetStatusPolicy should not treat unrecognized values as if they were no hdcp policy. A trivial example is that if we do not recognize a newer hdcp string, say "2.3", then we should not query if the CDM supports this policy as if it were no hdcp. This patch means that we surface and error to JS if we do no recognize an hdcp string. Differential Revision: https://phabricator.services.mozilla.com/D42061
2a7a1901557eb923fa616b28ac438818e7f087dc: Bug 1547784 - Return an error if an EME associated MediaElement becomes inactive as deocder setup finishes. r=alwu
Bryce Seager van Dyk <bvandyk@mozilla.com> - Tue, 06 Aug 2019 17:48:41 +0000 - rev 486672
Push 113852 by nerli@mozilla.com at Wed, 07 Aug 2019 10:10:48 +0000
Bug 1547784 - Return an error if an EME associated MediaElement becomes inactive as deocder setup finishes. r=alwu This fixes an edge case where it was possible for an HTMLMediaElement in the middle of setup to have ownership transferred to a inactive document and deref a null pointer. This happened because we have special handling for EME related media where we perform more aggressive shutdown on for media in inactive documents. As far as I can tell, there's nothing specced that forbids performing EME related functionality on elements in inactive documents. However, our code already prevents doing so in other cases. E.g. if you create an inactive document, place an HTMLMediaElement in it and try to setup EME related data on it, then that will fail. So this fix just covers another such case. While it would be nice to support doing these operations on inactive document's media, it seems like very much an edge case, and something that would require a large amount of reworking in how we handle inactive documents. We can cross that bridge later should we ever need do so. Differential Revision: https://phabricator.services.mozilla.com/D40482
3b56af8ee88e7ee682717a358cc65c284d45ea6a: Bug 1547784 - Add crashtest for moving media element with media keys to inactive doc. r=alwu
Bryce Seager van Dyk <bvandyk@mozilla.com> - Tue, 06 Aug 2019 17:48:29 +0000 - rev 486671
Push 113852 by nerli@mozilla.com at Wed, 07 Aug 2019 10:10:48 +0000
Bug 1547784 - Add crashtest for moving media element with media keys to inactive doc. r=alwu Differential Revision: https://phabricator.services.mozilla.com/D40481
21f0da4d57639840635aa5c9fcde97b57d44d829: Bug 1547784 - Return an error if an EME associated MediaElement becomes inactive as deocder setup finishes. r=alwu
Bryce Seager van Dyk <bvandyk@mozilla.com> - Fri, 02 Aug 2019 21:53:53 +0000 - rev 486052
Push 113827 by btara@mozilla.com at Sat, 03 Aug 2019 09:54:50 +0000
Bug 1547784 - Return an error if an EME associated MediaElement becomes inactive as deocder setup finishes. r=alwu This fixes an edge case where it was possible for an HTMLMediaElement in the middle of setup to have ownership transferred to a inactive document and deref a null pointer. This happened because we have special handling for EME related media where we perform more aggressive shutdown on for media in inactive documents. As far as I can tell, there's nothing specced that forbids performing EME related functionality on elements in inactive documents. However, our code already prevents doing so in other cases. E.g. if you create an inactive document, place an HTMLMediaElement in it and try to setup EME related data on it, then that will fail. So this fix just covers another such case. While it would be nice to support doing these operations on inactive document's media, it seems like very much an edge case, and something that would require a large amount of reworking in how we handle inactive documents. We can cross that bridge later should we ever need do so. Differential Revision: https://phabricator.services.mozilla.com/D40482
54b3b878f07d47e40b6962b9f95ddfe1dd84b7ae: Bug 1547784 - Add crashtest for moving media element with media keys to inactive doc. r=alwu
Bryce Seager van Dyk <bvandyk@mozilla.com> - Fri, 02 Aug 2019 21:54:03 +0000 - rev 486051
Push 113827 by btara@mozilla.com at Sat, 03 Aug 2019 09:54:50 +0000
Bug 1547784 - Add crashtest for moving media element with media keys to inactive doc. r=alwu Differential Revision: https://phabricator.services.mozilla.com/D40481
0928c6245907b29a632be53031c0f4ea358151ee: Bug 1356046 - Remove expired media telemetry; r=jya,alwu,bryce
Dan Minor <dminor@mozilla.com> - Fri, 02 Aug 2019 18:17:45 +0000 - rev 485993
Push 113825 by opoprus@mozilla.com at Fri, 02 Aug 2019 22:01:10 +0000
Bug 1356046 - Remove expired media telemetry; r=jya,alwu,bryce This removes all telemetry which expired in Firefox 69 or earlier, with the exceptions of the following, which we plan to renew: * AUDIO_TRACK_SILENCE_PROPORTION * MEDIA_AUTOPLAY_WOULD_BE_ALLOWED_COUNT * MEDIA_AUTOPLAY_WOULD_NOT_BE_ALLOWED_COUNT * MEDIACACHESTREAM_LENGTH_KB * MEDIA_MKV_CANPLAY_REQUESTED * MEDIA_PAGE_COUNT * MEDIA_PAGE_HAD_MEDIA_COUNT * VIDEO_DROPPED_FRAMES_PROPORTION * VIDEO_PLAY_TIME * VIDEO_HIDDEN_PLAY_TIME * VIDEO_HIDDEN_PLAY_TIME_PERCENTAGE * VIDEO_INFERRED_DECODE_SUSPEND_PERCENTAGE * VIDEO_INTER_KEYFRAME_AVERAGE_MS * VIDEO_INTER_KEYFRAME_MAX_MS * VIDEO_SUSPEND_RECOVERY_TIME_MS * VIDEO_VP9_BENCHMARK_FPS * WEB_AUDIO_BECOMES_AUDIBLE_TIME * WEBVTT_TRACK_KINDS Differential Revision: https://phabricator.services.mozilla.com/D37313
b8661a3b5dc23c855fbebf7af1ac0c2c47ddd20d: Bug 1356046 - Remove expired media telemetry; r=jya,alwu,bryce
Dan Minor <dminor@mozilla.com> - Fri, 02 Aug 2019 15:37:59 +0000 - rev 485966
Push 113825 by opoprus@mozilla.com at Fri, 02 Aug 2019 22:01:10 +0000
Bug 1356046 - Remove expired media telemetry; r=jya,alwu,bryce This removes all telemetry which expired in Firefox 69 or earlier, with the exceptions of the following, which we plan to renew: * AUDIO_TRACK_SILENCE_PROPORTION * MEDIA_AUTOPLAY_WOULD_BE_ALLOWED_COUNT * MEDIA_AUTOPLAY_WOULD_NOT_BE_ALLOWED_COUNT * MEDIACACHESTREAM_LENGTH_KB * MEDIA_MKV_CANPLAY_REQUESTED * MEDIA_PAGE_COUNT * MEDIA_PAGE_HAD_MEDIA_COUNT * VIDEO_DROPPED_FRAMES_PROPORTION * VIDEO_PLAY_TIME * VIDEO_HIDDEN_PLAY_TIME * VIDEO_HIDDEN_PLAY_TIME_PERCENTAGE * VIDEO_INFERRED_DECODE_SUSPEND_PERCENTAGE * VIDEO_INTER_KEYFRAME_AVERAGE_MS * VIDEO_INTER_KEYFRAME_MAX_MS * VIDEO_SUSPEND_RECOVERY_TIME_MS * VIDEO_VP9_BENCHMARK_FPS * WEB_AUDIO_BECOMES_AUDIBLE_TIME * WEBVTT_TRACK_KINDS Differential Revision: https://phabricator.services.mozilla.com/D37313
9b3f4d1a7c206b88fd3cf4ae8beb4cf145a3136e: Bug 1561486 - shutdown demuxer early. r=alwu
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 10 Jul 2019 12:04:50 +0000 - rev 483650
Push 113742 by ccoroiu@mozilla.com at Mon, 22 Jul 2019 10:08:17 +0000
Bug 1561486 - shutdown demuxer early. r=alwu We don't need the demuxer after we've resolved the promise. Differential Revision: https://phabricator.services.mozilla.com/D36713
ee059061515f19c66cbc1466108d2cf0e05de0bd: Bug 1561484 - Keep MediaInfo object for entire benchmark. r=alwu
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 10 Jul 2019 05:24:54 +0000 - rev 482121
Push 113650 by aciure@mozilla.com at Wed, 10 Jul 2019 15:54:09 +0000
Bug 1561484 - Keep MediaInfo object for entire benchmark. r=alwu Differential Revision: https://phabricator.services.mozilla.com/D36566
b157ff9c0f229695504eec11632e1789a7820708: Bug 1561484 - Keep MediaInfo object for entire benchmark. r=alwu
Jean-Yves Avenard <jyavenard@mozilla.com> - Tue, 09 Jul 2019 21:45:29 +0000 - rev 482050
Push 113647 by aciure@mozilla.com at Wed, 10 Jul 2019 09:46:39 +0000
Bug 1561484 - Keep MediaInfo object for entire benchmark. r=alwu Differential Revision: https://phabricator.services.mozilla.com/D36566
8c6d523bdb3bdff85404f46576187a9ae035d32e: Bug 1553046 - Update wpt metadata for webvtt tests that crash. r=alwu
Maja Frydrychowicz <mjzffr@gmail.com> - Sat, 22 Jun 2019 06:36:53 +0000 - rev 479862
Push 113496 by rmaries@mozilla.com at Sat, 22 Jun 2019 21:55:36 +0000
Bug 1553046 - Update wpt metadata for webvtt tests that crash. r=alwu Differential Revision: https://phabricator.services.mozilla.com/D35475
7a6d1ef048099da40346447f987474efb0234324: Bug 1554699 - Don't fire "timeupdate" in PlayInternal as it's against spec. r=jya,alwu
Andreas Pehrson <apehrson@mozilla.com> - Tue, 11 Jun 2019 11:49:26 +0000 - rev 478503
Push 113422 by aciure@mozilla.com at Wed, 12 Jun 2019 21:46:30 +0000
Bug 1554699 - Don't fire "timeupdate" in PlayInternal as it's against spec. r=jya,alwu Bug 1279865 introduced this under the premise of "Run TimeMarchesOn() at the beginning of play.", but it did a bit too much. This makes us spec compliant for this particular case again. Differential Revision: https://phabricator.services.mozilla.com/D33650
75a6f48ca07813830b88470606a2145b2f7610e7: Bug 1543812 - Add ability to block all autoplay. r=johannh,alwu,flod,fluent-reviewers
Dale Harvey <dale@arandomurl.com> - Thu, 06 Jun 2019 09:06:09 +0000 - rev 477604
Push 113366 by ncsoregi@mozilla.com at Thu, 06 Jun 2019 22:41:06 +0000
Bug 1543812 - Add ability to block all autoplay. r=johannh,alwu,flod,fluent-reviewers Differential Revision: https://phabricator.services.mozilla.com/D30135
2dacf7539a2f6238bc9731fddc5eac8460fb9afc: Bug 1543812 - Add ability to block all autoplay. r=johannh,alwu,flod,fluent-reviewers
Dale Harvey <dale@arandomurl.com> - Wed, 05 Jun 2019 01:03:14 +0000 - rev 477458
Push 113340 by aiakab@mozilla.com at Wed, 05 Jun 2019 22:07:26 +0000
Bug 1543812 - Add ability to block all autoplay. r=johannh,alwu,flod,fluent-reviewers Differential Revision: https://phabricator.services.mozilla.com/D30135
d64cb52ebf88093b7c4b40597a795ed5d46a2214: Bug 1543812 - Add ability to block all autoplay. r=johannh,alwu,flod,fluent-reviewers
Dale Harvey <dale@arandomurl.com> - Tue, 04 Jun 2019 17:33:06 +0000 - rev 477348
Push 113327 by malexandru@mozilla.com at Wed, 05 Jun 2019 10:00:10 +0000
Bug 1543812 - Add ability to block all autoplay. r=johannh,alwu,flod,fluent-reviewers Differential Revision: https://phabricator.services.mozilla.com/D30135
b9bd90dd38bfcc9ea7231d0dd326fced00750749: Bug 1545108 - Use a diagnostic assert to check for nullptr when pushing into MediaQueue. r=alwu
Bryce Van Dyk <bvandyk@mozilla.com> - Thu, 25 Apr 2019 17:08:27 +0000 - rev 471378
Push 112918 by rmaries@mozilla.com at Fri, 26 Apr 2019 09:59:41 +0000
Bug 1545108 - Use a diagnostic assert to check for nullptr when pushing into MediaQueue. r=alwu We're rarely getting nullptrs out of MediaQueues. It's not clear where these are coming from, as we have many guards against them. Upgrade this assert to a diagnostic to help us track the source and determine if the value is null before entering the queue. Differential Revision: https://phabricator.services.mozilla.com/D28866
40db29867fd9f6fb49a8af84aa1f3029d5ea668a: Bug 1538003 - Disable some more intermittently failing webvtt tests. r=alwu"
Matt Woodrow <mwoodrow@mozilla.com> - Tue, 26 Mar 2019 02:11:55 +0000 - rev 466047
Push 112550 by rgurzau@mozilla.com at Tue, 26 Mar 2019 09:57:15 +0000
Bug 1538003 - Disable some more intermittently failing webvtt tests. r=alwu" Differential Revision: https://phabricator.services.mozilla.com/D24436
2d1930ba617fd4ab61d0c427b570faedd632aa34: Bug 1504060 - Log instead of asserting that webm samples do not have timestamps > segment druation. r=alwu
Bryce Van Dyk <bvandyk@mozilla.com> - Fri, 01 Mar 2019 18:20:00 +0000 - rev 462037
Push 112259 by rmaries@mozilla.com at Sat, 02 Mar 2019 10:10:00 +0000
Bug 1504060 - Log instead of asserting that webm samples do not have timestamps > segment druation. r=alwu We're able to hit this assertion in the wild due to bad muxers. As such, replace the assert with a log. If a sample has a time stamp > the segment duration, use that instead of the duration for calculating our next time stamp. Use an explicit int64_t type in the signature for our next time stamp calculation as the logging explicitly expects an int64_t (makes it harder to change the types involved and footgunning by having a wrong formatter in the logs). Differential Revision: https://phabricator.services.mozilla.com/D21717
a110f9abc663ae498abb7b9c929d64b350b972bc: Bug 1527863 - Prevent the video controls from inheriting white-space style. r=alwu
Jared Wein <jwein@mozilla.com> - Thu, 14 Feb 2019 18:08:32 +0000 - rev 459396
Push 111944 by dvarga@mozilla.com at Fri, 15 Feb 2019 01:52:15 +0000
Bug 1527863 - Prevent the video controls from inheriting white-space style. r=alwu Differential Revision: https://phabricator.services.mozilla.com/D19802
589b502d9d46a8bd5bfec8da0022d9ca56eb1041: Bug 1519812 - toolkit/content/tests/browser/browser_autoplay* tests should be marked as the 'Audio/Video: Playback' component. r=alwu
Mark Banner <standard8@mozilla.com> - Mon, 14 Jan 2019 19:00:38 +0000 - rev 453848
Push 111157 by cbrindusan@mozilla.com at Tue, 15 Jan 2019 04:43:09 +0000
Bug 1519812 - toolkit/content/tests/browser/browser_autoplay* tests should be marked as the 'Audio/Video: Playback' component. r=alwu Differential Revision: https://phabricator.services.mozilla.com/D16451
d5c767dcf1bba1d12d4a35c66ddc1a57842c5591: Bug 1512456 - P8. Use GenericNonExclusivePromise where needed. r=gerald,alwu
Jean-Yves Avenard <jyavenard@mozilla.com> - Tue, 11 Dec 2018 10:47:01 +0000 - rev 450150
Push 110454 by ccoroiu@mozilla.com at Wed, 12 Dec 2018 05:27:58 +0000
Bug 1512456 - P8. Use GenericNonExclusivePromise where needed. r=gerald,alwu Those MozPromises are shared and must be made non-exclusive Differential Revision: https://phabricator.services.mozilla.com/D14032
167783db980446c172f7c3bab123cd565a8ed886: Bug 1512456 - P4. Replace assert with MOZ_ASSERT. r=alwu
Jean-Yves Avenard <jyavenard@mozilla.com> - Tue, 11 Dec 2018 10:46:25 +0000 - rev 450146
Push 110454 by ccoroiu@mozilla.com at Wed, 12 Dec 2018 05:27:58 +0000
Bug 1512456 - P4. Replace assert with MOZ_ASSERT. r=alwu Differential Revision: https://phabricator.services.mozilla.com/D14027
2109be597625ff232c74d6b8778f32fcd964563c: Bug 1512456 - P1. Don't use GenericPromise with MediaSink. r=alwu
Jean-Yves Avenard <jyavenard@mozilla.com> - Tue, 11 Dec 2018 10:44:51 +0000 - rev 450143
Push 110454 by ccoroiu@mozilla.com at Wed, 12 Dec 2018 05:27:58 +0000
Bug 1512456 - P1. Don't use GenericPromise with MediaSink. r=alwu The VideoSink shares the AudioSink's own EndedPromise to notify its user that it has ended. As such, the MozPromise used must be non-exclusive. Using the GenericPromise for such purpose only hid that requirement. We also remove the MediaSink from the media namespace, and clarify the naming of some arguments and class members to accurately describe what they do. Differential Revision: https://phabricator.services.mozilla.com/D14024
720f409b83f27d5c92c9194157b6f7ac65068361: Bug 1423241 - Remove screen-wakelock code that no longer has an effect. r=alwu
Andreas Pehrson <apehrson@mozilla.com> - Fri, 23 Nov 2018 15:01:18 +0000 - rev 447863
Push 110089 by btara@mozilla.com at Fri, 23 Nov 2018 21:42:24 +0000
Bug 1423241 - Remove screen-wakelock code that no longer has an effect. r=alwu Differential Revision: https://phabricator.services.mozilla.com/D9102
6a32be5a7100fc82eea08a2952778c2dce7e84ff: Bug 1506076 - Mark video android decoder as needing AnnexB. r=jolin,alwu
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 09 Nov 2018 22:07:40 +0000 - rev 445752
Push 109758 by csabou@mozilla.com at Sat, 10 Nov 2018 11:51:47 +0000
Bug 1506076 - Mark video android decoder as needing AnnexB. r=jolin,alwu It only used to work as the H264Converter used to check that the conversion needed was != kNeedAVCC (the default being kNone) Differential Revision: https://phabricator.services.mozilla.com/D11526
7f1d96b0004f2d12a131dbf1116cda7bf3410dfb: Bug 1487143 - Properly dispatch MozAutoplayMediaBlocked event to content, r=alwu
Timothy Guan-tin Chien <timdream@gmail.com> - Thu, 13 Sep 2018 21:21:11 +0000 - rev 436287
Push 107823 by nerli@mozilla.com at Fri, 14 Sep 2018 03:47:40 +0000
Bug 1487143 - Properly dispatch MozAutoplayMediaBlocked event to content, r=alwu The MozAutoplayMediaBlocked event should have its target set to the video element, not the document. Also, MozNoControlsBlockedVideo event has to initialized from the CustomEvent constructor of the right window for the XBL binding to access it. I don't know when it stopped working. Test is added to ensure the entire UI won't break. Differential Revision: https://phabricator.services.mozilla.com/D5801
b88bbab404c63daba2e0994f937ab62bf05d44fb: Bug 1491066 - Allow TextTrackManager to pass cue without videocontrols r=alwu
Timothy Guan-tin Chien <timdream@gmail.com> - Thu, 13 Sep 2018 22:38:43 +0000 - rev 436286
Push 107823 by nerli@mozilla.com at Fri, 14 Sep 2018 03:47:40 +0000
Bug 1491066 - Allow TextTrackManager to pass cue without videocontrols r=alwu With UA Widget, the videocontrols container is created lazily. It won't be a problem for WebVTT.processCues() in vtt.jsm, so TextTrackManager::UpdateCueDisplay() should not early return there, but pass nullptr to it. Differential Revision: https://phabricator.services.mozilla.com/D3667
b28c1da957075c15f306c05ff94332210b09b277: Bug 1488520 - Continue searching for a moof until a valid one is found. r=alwu
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 06 Sep 2018 18:32:37 +0000 - rev 435120
Push 107563 by btara@mozilla.com at Thu, 06 Sep 2018 22:57:41 +0000
Bug 1488520 - Continue searching for a moof until a valid one is found. r=alwu It is possible for audio and videos moofs to be interleaved in the stream. If we were to stop on an invalid moof or a moof whose track ID doesn't match, the track would end up not playing. Differential Revision: https://phabricator.services.mozilla.com/D5157
f5f55e363d318effdfd504061c50f87e06301c6f: Bug 1478208 - Implement HTMLMediaElement.allowedToPlay. r=alwu,bz
Chris Pearce <cpearce@mozilla.com> - Wed, 25 Jul 2018 14:25:17 +1200 - rev 429772
Push 105984 by nerli@mozilla.com at Thu, 02 Aug 2018 09:04:51 +0000
Bug 1478208 - Implement HTMLMediaElement.allowedToPlay. r=alwu,bz Various web authors have expressed desire to know in advance whether autoplay will work. They want this in order to avoid paying the price for downloading media that won't play. Or they want to take other action such as showing a poster image instead. This is of particular interest to Firefox, as we're planning on showing a prompt to ask the user whether they would like a site to play. If sites want to determine whether they can autoplay but avoid the prompt showing, they won't be able to just call play() in Firefox and see whether it works, as that would likely show the prompt if the user doesn't already have a stored permission. We've been working out a spec here: https://github.com/whatwg/html/issues/3617#issuecomment-398613484 This implements what is the consensus to date there; HTMLMediaElement.allowedToPlay, which returns true when a play() call would not be blocked with NotAllowedError by autoplay blocking policies. MozReview-Commit-ID: AkBu0G7uCJ0
f4e4541f3c1c760975a76668e72e11f1f56d8b3c: Bug 1477881 - Ensure AutoplayPermissionRequest can't double report a response. r=alwu
Chris Pearce <cpearce@mozilla.com> - Tue, 24 Jul 2018 10:23:05 +1200 - rev 428263
Push 105659 by toros@mozilla.com at Wed, 25 Jul 2018 10:43:25 +0000
Bug 1477881 - Ensure AutoplayPermissionRequest can't double report a response. r=alwu We cancel the permission request in the AutoplayPermissionRequest destructor, and if we get a genuine cancel from the doorhanger. The Request reports the cancel to the AutoplayPermissionManager, but we reuse the same manager across different requests. So if a second request for permission comes in, we create a new AutoplayPermissionRequest and fire that off to the front end code, but the first request could be destroyed after the second request is dispatched but before the response for the second request has retuned. Thus and the cancel in the first's destructor could be reported to the manager as the second's result. We should clear the AutoplayPermissionRequest's reference to the Manager in Approve() and Cancel() so that we can't mixup the responses like this. MozReview-Commit-ID: 1qYJfLOaqST
36a8327139530a95003d431f3f43e7c3f6f9c3ee: Bug 1395086 - Increase max wait time to avoid intermittent failure in testAudioFocus; r=alwu
Geoff Brown <gbrown@mozilla.com> - Thu, 18 Jan 2018 11:25:45 -0700 - rev 399825
Push 99041 by gbrown@mozilla.com at Thu, 18 Jan 2018 18:26:03 +0000
Bug 1395086 - Increase max wait time to avoid intermittent failure in testAudioFocus; r=alwu
772fef647fd7750f8c87dfd4f55bbd85046a555a: Bug 1420608. P2 - fix the test timeout. r=alwu
JW Wang <jwwang@mozilla.com> - Fri, 08 Dec 2017 17:35:29 +0800 - rev 396163
Push 98257 by nbeleuzu@mozilla.com at Wed, 13 Dec 2017 10:25:14 +0000
Bug 1420608. P2 - fix the test timeout. r=alwu See comment 50 for the cause. Since file_silentAudioTrack.html calls play() to start playback immediately, it is possible that 'mozentervideosuspend' has been fired before check_video_decoding_state() has a chance to register event handlers. We call load() and play() to start playback from the beginning so we won't miss any events. MozReview-Commit-ID: 9sKygfIxEtS
5a9fbe6806cfa927e1b19c60f0f351ae0e6f7777: Bug 1415821 - Correct the behavior for BADCUE state. r=alwu
bechen@mozilla.com <bechen@mozilla.com> - Wed, 15 Nov 2017 17:21:09 +0800 - rev 392259
Push 97440 by aciure@mozilla.com at Fri, 17 Nov 2017 10:12:11 +0000
Bug 1415821 - Correct the behavior for BADCUE state. r=alwu MozReview-Commit-ID: G59NBC9rcGa
1786297a20dfb8cdd1082edc746b9479e78435a1: Bug 1415821 - Support multi-line parsing for REGION/STYLE block. r=alwu
bechen@mozilla.com <bechen@mozilla.com> - Wed, 15 Nov 2017 10:25:02 +0800 - rev 392258
Push 97440 by aciure@mozilla.com at Fri, 17 Nov 2017 10:12:11 +0000
Bug 1415821 - Support multi-line parsing for REGION/STYLE block. r=alwu MozReview-Commit-ID: HhRkv27UPO