searching for reviewer(Jamie)
3dfd9b62f429f656dcf6d08fd64fb8991f54db51: Bug 1565728 - Introduce PDocAccessiblePlatformExt for Android. r=Jamie
Eitan Isaacson <eitan@monotonous.org> - Fri, 13 Sep 2019 16:55:05 +0000 - rev 493091
Push 114082 by dvarga@mozilla.com at Fri, 13 Sep 2019 21:51:00 +0000
Bug 1565728 - Introduce PDocAccessiblePlatformExt for Android. r=Jamie Ultimately Batch from PDocAccessible would be moved to here as well. Differential Revision: https://phabricator.services.mozilla.com/D37954
2526ca5dd7b377847e6fa90fa20e20335dcfb3dd: Bug 1565728 - Introduce PDocAccessiblePlatformExt. r=Jamie
Eitan Isaacson <eitan@monotonous.org> - Fri, 13 Sep 2019 16:55:01 +0000 - rev 493090
Push 114082 by dvarga@mozilla.com at Fri, 13 Sep 2019 21:51:00 +0000
Bug 1565728 - Introduce PDocAccessiblePlatformExt. r=Jamie This is an extension protocol that can be used for platform specific API (ie. AccessibleWrap methods). I'm not thrilled with the seperate constructor for the sub-protocol. This means that the parent won't have the actor upon DocAccessibleParent construction, and some timing bugs can arise because of the extra round trip. It would be cool if both actors could be co-created, but that would require ManagedEndpoint, and for PBrowser to manage them both. I don't want to expose this to PBrowser. Differential Revision: https://phabricator.services.mozilla.com/D37955
bafede36df6da525eeb8bd6eb7d54f8bbdcf5db5: Bug 1563598: Display 'container-live' attribute on descendents of implicitly-live elements. r=Jamie
Morgan Reschenberg <mreschenberg@mozilla.com> - Fri, 13 Sep 2019 16:43:58 +0000 - rev 493086
Push 114082 by dvarga@mozilla.com at Fri, 13 Sep 2019 21:51:00 +0000
Bug 1563598: Display 'container-live' attribute on descendents of implicitly-live elements. r=Jamie Depends on D45402 Differential Revision: https://phabricator.services.mozilla.com/D45609
ab38f605155c257f302310943026951258e9c18f: Bug 1563598: Change output elements to have statusbar role instead of section role. r=Jamie
Morgan Reschenberg <mreschenberg@mozilla.com> - Fri, 13 Sep 2019 16:43:49 +0000 - rev 493085
Push 114082 by dvarga@mozilla.com at Fri, 13 Sep 2019 21:51:00 +0000
Bug 1563598: Change output elements to have statusbar role instead of section role. r=Jamie Differential Revision: https://phabricator.services.mozilla.com/D45402
6c30dad5259b855a5fe7caacc45bd174544066c6: Bug 1565728 - Introduce PDocAccessiblePlatformExt for Android. r=Jamie
Eitan Isaacson <eitan@monotonous.org> - Thu, 12 Sep 2019 23:02:01 +0000 - rev 492965
Push 114079 by nerli@mozilla.com at Fri, 13 Sep 2019 04:45:18 +0000
Bug 1565728 - Introduce PDocAccessiblePlatformExt for Android. r=Jamie Ultimately Batch from PDocAccessible would be moved to here as well. Differential Revision: https://phabricator.services.mozilla.com/D37954
4369b720326617286976d68b96cea3e49d09fbec: Bug 1565728 - Introduce PDocAccessiblePlatformExt. r=Jamie
Eitan Isaacson <eitan@monotonous.org> - Thu, 12 Sep 2019 23:01:59 +0000 - rev 492964
Push 114079 by nerli@mozilla.com at Fri, 13 Sep 2019 04:45:18 +0000
Bug 1565728 - Introduce PDocAccessiblePlatformExt. r=Jamie This is an extension protocol that can be used for platform specific API (ie. AccessibleWrap methods). I'm not thrilled with the seperate constructor for the sub-protocol. This means that the parent won't have the actor upon DocAccessibleParent construction, and some timing bugs can arise because of the extra round trip. It would be cool if both actors could be co-created, but that would require ManagedEndpoint, and for PBrowser to manage them both. I don't want to expose this to PBrowser. Differential Revision: https://phabricator.services.mozilla.com/D37955
968ef845dc64264118c667f00a5e1b8c43b5d7f1: Bug 1563598: Display 'container-live' attribute on descendents of implicitly-live elements. r=Jamie
Morgan Reschenberg <mreschenberg@mozilla.com> - Thu, 12 Sep 2019 20:01:50 +0000 - rev 492929
Push 114079 by nerli@mozilla.com at Fri, 13 Sep 2019 04:45:18 +0000
Bug 1563598: Display 'container-live' attribute on descendents of implicitly-live elements. r=Jamie Differential Revision: https://phabricator.services.mozilla.com/D45609
d647bd5b0b29b75285d36b737cda3dee3a982634: Bug 1563598: Change output elements to have statusbar role instead of section role. r=Jamie
Morgan Reschenberg <mreschenberg@mozilla.com> - Thu, 12 Sep 2019 16:13:19 +0000 - rev 492928
Push 114079 by nerli@mozilla.com at Fri, 13 Sep 2019 04:45:18 +0000
Bug 1563598: Change output elements to have statusbar role instead of section role. r=Jamie Differential Revision: https://phabricator.services.mozilla.com/D45402
0d08e4b02c17468ddcc8f2c1607cafa8de7ae0b0: Bug 1565728 - Introduce PDocAccessiblePlatformExt for Android. r=Jamie
Eitan Isaacson <eitan@monotonous.org> - Thu, 12 Sep 2019 20:10:55 +0000 - rev 492925
Push 114079 by nerli@mozilla.com at Fri, 13 Sep 2019 04:45:18 +0000
Bug 1565728 - Introduce PDocAccessiblePlatformExt for Android. r=Jamie Ultimately Batch from PDocAccessible would be moved to here as well. Differential Revision: https://phabricator.services.mozilla.com/D37954
4fe176e80602913f80f7b73f9a2c6924693ecd82: Bug 1565728 - Introduce PDocAccessiblePlatformExt. r=Jamie
Eitan Isaacson <eitan@monotonous.org> - Thu, 12 Sep 2019 20:10:51 +0000 - rev 492924
Push 114079 by nerli@mozilla.com at Fri, 13 Sep 2019 04:45:18 +0000
Bug 1565728 - Introduce PDocAccessiblePlatformExt. r=Jamie This is an extension protocol that can be used for platform specific API (ie. AccessibleWrap methods). I'm not thrilled with the seperate constructor for the sub-protocol. This means that the parent won't have the actor upon DocAccessibleParent construction, and some timing bugs can arise because of the extra round trip. It would be cool if both actors could be co-created, but that would require ManagedEndpoint, and for PBrowser to manage them both. I don't want to expose this to PBrowser. Differential Revision: https://phabricator.services.mozilla.com/D37955
c7abc15f7444c9ebc5c6adafc3a1be2d5d1e3090: Bug 1578282 - Use flattened tree parent when getting inserted node container. r=Jamie
Eitan Isaacson <eitan@monotonous.org> - Fri, 06 Sep 2019 00:24:21 +0000 - rev 492070
Push 114040 by ncsoregi@mozilla.com at Sat, 07 Sep 2019 09:47:24 +0000
Bug 1578282 - Use flattened tree parent when getting inserted node container. r=Jamie This assures that a node that has already been inserted in a shadow root subtree does not get erroneously reinserted into the top container. Differential Revision: https://phabricator.services.mozilla.com/D44880
882d5da92a00655a88956ee68eeff03b1af91d02: Bug 1570701: Part 2 - Add asynchronous CreateInstance method to mscom::EnsureMTA; r=Jamie
Aaron Klotz <aklotz@mozilla.com> - Wed, 04 Sep 2019 15:36:42 +0000 - rev 491682
Push 114032 by btara@mozilla.com at Thu, 05 Sep 2019 03:53:00 +0000
Bug 1570701: Part 2 - Add asynchronous CreateInstance method to mscom::EnsureMTA; r=Jamie We'd like to offer a way for developers to safely do asynchronous instantiations of COM objects. This patch adds a static CreateInstance method to mscom::EnsureMTA that facilitates this under certain conditions (as outlined in the comments). To help ensure that this is as safe as possible, we return a MozPromise that, once resolved, produces an AgileReference that may then be passed between threads, and may then be resolved when a specific thread needs to access the interface. Differential Revision: https://phabricator.services.mozilla.com/D44519
21fcdb29114034e26f567f0106039f3773466d81: Bug 1570701: Part 1 - Add IsClassThreadAwareInprocServer utility function to MSCOM; r=Jamie
Aaron Klotz <aklotz@mozilla.com> - Tue, 03 Sep 2019 23:58:39 +0000 - rev 491681
Push 114032 by btara@mozilla.com at Thu, 05 Sep 2019 03:53:00 +0000
Bug 1570701: Part 1 - Add IsClassThreadAwareInprocServer utility function to MSCOM; r=Jamie We want to ensure that the code being added in part 2 is only used when it is reasonable and safe to do so. One way to ensure this is to add a check that the desired CLSID is an in-process, thread-aware server. Differential Revision: https://phabricator.services.mozilla.com/D44518
7503e58cf7c742ecbc8ceb7fa4a27624b211e260: Bug 1578490: Use rvalue references and std::move for all closures being passed into mscom::EnsureMTA; r=Jamie
Aaron Klotz <aklotz@mozilla.com> - Tue, 03 Sep 2019 23:51:15 +0000 - rev 491680
Push 114032 by btara@mozilla.com at Thu, 05 Sep 2019 03:53:00 +0000
Bug 1578490: Use rvalue references and std::move for all closures being passed into mscom::EnsureMTA; r=Jamie Differential Revision: https://phabricator.services.mozilla.com/D44517
59b97cbfadda1c89388c495061be448f8c475b46: Bug 1576549 - Use bounds in bundle argument instead of getter method. r=Jamie
Eitan Isaacson <eitan@monotonous.org> - Fri, 30 Aug 2019 01:29:31 +0000 - rev 490762
Push 114002 by shindli@mozilla.com at Fri, 30 Aug 2019 09:43:28 +0000
Bug 1576549 - Use bounds in bundle argument instead of getter method. r=Jamie Differential Revision: https://phabricator.services.mozilla.com/D44041
89963083c79dd5f7fbb1bcf90efe5f9985597db5: Bug 1576690 - Prune de-slotted accessibles, or relocate them to new slot. r=Jamie,emilio
Eitan Isaacson <eitan@monotonous.org> - Thu, 29 Aug 2019 16:14:48 +0000 - rev 490696
Push 114000 by csabou@mozilla.com at Thu, 29 Aug 2019 22:00:33 +0000
Bug 1576690 - Prune de-slotted accessibles, or relocate them to new slot. r=Jamie,emilio This patch does several things: 1. If there is a change to a host or a slot, check the slottable elements to see if they are rendered in the tree. Remove them if not. 2. Check slot elements' fallback content if it is rendered and remove if not. 3. Allow accessibles to be reinserted into a different parent or index. Differential Revision: https://phabricator.services.mozilla.com/D43489
7af553376576253a34735954c2f0e22b85847fec: Bug 1357071 - Implement support for implicit values for aria-value* attributes for scrollbar and slider roles, r=Jamie
Maliha Islam <mislam@mozilla.com> - Thu, 29 Aug 2019 06:39:28 +0000 - rev 490615
Push 113999 by rmaries@mozilla.com at Thu, 29 Aug 2019 15:55:04 +0000
Bug 1357071 - Implement support for implicit values for aria-value* attributes for scrollbar and slider roles, r=Jamie Differential Revision: https://phabricator.services.mozilla.com/D43293
ecf3e677949399f0d886170c5bac66a5f0f34766: Bug 1522383 - Assign gridcell role to cells inside a table with grid role, r=Jamie
Maliha Islam <mislam@mozilla.com> - Thu, 29 Aug 2019 10:09:48 +0000 - rev 490614
Push 113999 by rmaries@mozilla.com at Thu, 29 Aug 2019 15:55:04 +0000
Bug 1522383 - Assign gridcell role to cells inside a table with grid role, r=Jamie Differential Revision: https://phabricator.services.mozilla.com/D43858
7f1703036acfcd9e90003a8468fee793500556ae: Bug 1357071 - Implement support for implicit values for aria-value* attributes for scrollbar and slider roles, r=Jamie
Maliha Islam <mislam@mozilla.com> - Thu, 29 Aug 2019 00:18:08 +0000 - rev 490540
Push 113996 by rmaries@mozilla.com at Thu, 29 Aug 2019 09:48:46 +0000
Bug 1357071 - Implement support for implicit values for aria-value* attributes for scrollbar and slider roles, r=Jamie Differential Revision: https://phabricator.services.mozilla.com/D43293
170a5ba09a6f9847405bc522b4984f33dface562: Bug 1572829 - Remove explicit children too when node has a shadow root. r=Jamie
Eitan Isaacson <eitan@monotonous.org> - Wed, 28 Aug 2019 23:02:19 +0000 - rev 490514
Push 113995 by ccoroiu@mozilla.com at Thu, 29 Aug 2019 04:13:32 +0000
Bug 1572829 - Remove explicit children too when node has a shadow root. r=Jamie Differential Revision: https://phabricator.services.mozilla.com/D43488
8f193119390c2a2689b7584b91ff825c5a010ff2: Bug 1576925: Make AgileReference copyable; r=Jamie
Aaron Klotz <aklotz@mozilla.com> - Wed, 28 Aug 2019 15:05:32 +0000 - rev 490428
Push 113993 by ccoroiu@mozilla.com at Wed, 28 Aug 2019 21:49:44 +0000
Bug 1576925: Make AgileReference copyable; r=Jamie Until now, AgileReference was not copyable because it could not handle the copying of global interface table cookies. By moving the cookie into its own reference counted object, we can enable copying on the AgileReference. Differential Revision: https://phabricator.services.mozilla.com/D43616
623da84b651a53382a63b0465fa57f2125a5b5f8: Bug 1573679: Add IsCurrentThread(Explicit|Implicit)MTA utility functions to mscom; r=Jamie
Aaron Klotz <aklotz@mozilla.com> - Tue, 27 Aug 2019 01:48:08 +0000 - rev 490153
Push 113979 by csabou@mozilla.com at Tue, 27 Aug 2019 09:55:53 +0000
Bug 1573679: Add IsCurrentThread(Explicit|Implicit)MTA utility functions to mscom; r=Jamie This patch provides us with utility functions that give us more specific information about the current thread's MTA if so desired. Differential Revision: https://phabricator.services.mozilla.com/D41852
e48fd9a20d62c98ceb843010a7c08df4dd9d9650: Bug 1576709 - Add crash test for bug 1572811. r=Jamie
Eitan Isaacson <eitan@monotonous.org> - Mon, 26 Aug 2019 23:12:27 +0000 - rev 490152
Push 113979 by csabou@mozilla.com at Tue, 27 Aug 2019 09:55:53 +0000
Bug 1576709 - Add crash test for bug 1572811. r=Jamie Differential Revision: https://phabricator.services.mozilla.com/D43499
7395aa7395272714890d0510247743ca19fcbcc6: Bug 1576696 - Add a '0x' prefix to hex pointer values in logging nodes. r=Jamie
Eitan Isaacson <eitan@monotonous.org> - Tue, 27 Aug 2019 02:02:01 +0000 - rev 490151
Push 113979 by csabou@mozilla.com at Tue, 27 Aug 2019 09:55:53 +0000
Bug 1576696 - Add a '0x' prefix to hex pointer values in logging nodes. r=Jamie Differential Revision: https://phabricator.services.mozilla.com/D43485
54d0977adb446888899d91be9ab9a5276ccbd012: Bug 1357100 - change implicit val for aria-level on a heading to 2 r=Jamie
Gautham Velchuru <gvelchuru@gmail.com> - Fri, 23 Aug 2019 01:28:13 +0000 - rev 489536
Push 113949 by ncsoregi@mozilla.com at Fri, 23 Aug 2019 09:59:00 +0000
Bug 1357100 - change implicit val for aria-level on a heading to 2 r=Jamie Differential Revision: https://phabricator.services.mozilla.com/D35616
b47aa54a3dad5afba524bc047c8b9b8c5c4533c6: Bug 1572811 - Don't fire text change events if container accessible has no frame. r=Jamie
Eitan Isaacson <eitan@monotonous.org> - Thu, 22 Aug 2019 20:28:38 +0000 - rev 489486
Push 113949 by ncsoregi@mozilla.com at Fri, 23 Aug 2019 09:59:00 +0000
Bug 1572811 - Don't fire text change events if container accessible has no frame. r=Jamie Differential Revision: https://phabricator.services.mozilla.com/D42199
ad9f9646f46cd86078ddfe8082828948eeef5b5b: Bug 1540813 - Support new ARIA roles insertion and deletion, r=Jamie
Maliha Islam <mislam@mozilla.com> - Wed, 21 Aug 2019 20:36:39 +0000 - rev 489280
Push 113942 by aciure@mozilla.com at Thu, 22 Aug 2019 04:06:52 +0000
Bug 1540813 - Support new ARIA roles insertion and deletion, r=Jamie Differential Revision: https://phabricator.services.mozilla.com/D42911
279533771340729b3112c25e889a91d2e5dd7f9d: Bug 1574950 - atk: Set returned values to -1 in case of errors, as newly documented in atk r=Jamie
Samuel Thibault <samuel.thibault@ens-lyon.org> - Tue, 20 Aug 2019 22:42:49 +0000 - rev 489083
Push 113937 by malexandru@mozilla.com at Wed, 21 Aug 2019 03:54:54 +0000
Bug 1574950 - atk: Set returned values to -1 in case of errors, as newly documented in atk r=Jamie Differential Revision: https://phabricator.services.mozilla.com/D42515
73fb03448d1527347843eabd45c561ebfa8c6db6: Bug 1574298: Convert mscom::ProcessRuntime to use ProcessCategory enum and matching constructor; r=Jamie
Aaron Klotz <aklotz@mozilla.com> - Fri, 16 Aug 2019 16:06:45 +0000 - rev 488571
Push 113913 by malexandru@mozilla.com at Fri, 16 Aug 2019 22:02:18 +0000
Bug 1574298: Convert mscom::ProcessRuntime to use ProcessCategory enum and matching constructor; r=Jamie In order to use `mscom::ProcessRuntime` in the maintenance service, we need `ProcessRuntime` to be able to distinguish between more than just whether or not the current process is the parent process. I've added a new `ProcessCategory` enum to track this information, and revised the constructors so that we now have one that accepts a ProcessCategory. The `ProcessCategory` constructor is private inside XUL, since the `GeckoProcessType` variant should always be used in that case. We also slightly change apartment initialization to depend on the underlying `ProcessCategory` value. Finally, I modify the one case where we instantiate a `ProcessRuntime` in the launcher process to use the new constructor. Differential Revision: https://phabricator.services.mozilla.com/D42225
067d47e20a9439ad81d0b119b1b660c9638ff08e: Bug 1572811 - Explicitly check for removed anonymous children in reframe. r=Jamie
Eitan Isaacson <eitan@monotonous.org> - Thu, 15 Aug 2019 16:06:33 +0000 - rev 488261
Push 113906 by ncsoregi@mozilla.com at Fri, 16 Aug 2019 04:07:24 +0000
Bug 1572811 - Explicitly check for removed anonymous children in reframe. r=Jamie The DOM mutation observer method is called during frame destruction which is not a good state to be in when constructing and dispatching events. Differential Revision: https://phabricator.services.mozilla.com/D41825
9406ccf380bbc14f54eeecd3eec671750b22f53f: Bug 1573337 - remove XBL anon content filtering support from accessible tree traversal r=Jamie
Alexander Surkov <surkov.alexander@gmail.com> - Thu, 15 Aug 2019 00:58:28 +0000 - rev 488177
Push 113904 by ncsoregi@mozilla.com at Thu, 15 Aug 2019 19:41:00 +0000
Bug 1573337 - remove XBL anon content filtering support from accessible tree traversal r=Jamie Differential Revision: https://phabricator.services.mozilla.com/D42022
3769178b9a30790002c9c9555a11a045d460d5a3: Bug 1501182 - Expose WAI-ARIA landmarks as landmark roles through accessibility APIs, r=Jamie
Marco Zehe <mzehe@mozilla.com> - Thu, 15 Aug 2019 01:25:56 +0000 - rev 488176
Push 113904 by ncsoregi@mozilla.com at Thu, 15 Aug 2019 19:41:00 +0000
Bug 1501182 - Expose WAI-ARIA landmarks as landmark roles through accessibility APIs, r=Jamie This change will bring us on par with what Chrome does. However, if the author makes an error in applying a landmark role to an interactive element, or other element where the landmark role is illegal, as defined in the [WAI-ARIA in HTML specification section 2](https://www.w3.org/TR/html-aria/#document-conformance-requirements-for-use-of-aria-attributes-in-html), the accessible properties will now be that of the landmark role, no longer that of the native host language element. This might make some elements less accessible due to author error than before, but we currently do not know of examples in the wild that actually expose this problem. This could only be solved by applying the rules from said table also in the user agents, but that is not specified anywhere. Differential Revision: https://phabricator.services.mozilla.com/D41923
80c985e13b4713e0785a0de65b5c1f098e6b4ffa: Bug 1573750 - If header or footer elements are descendants of the main element, do not expose them as landmarks, r=Jamie
Marco Zehe <mzehe@mozilla.com> - Wed, 14 Aug 2019 06:10:24 +0000 - rev 487849
Push 113888 by aciure@mozilla.com at Wed, 14 Aug 2019 16:37:41 +0000
Bug 1573750 - If header or footer elements are descendants of the main element, do not expose them as landmarks, r=Jamie Differential Revision: https://phabricator.services.mozilla.com/D41893
5e72bd463b8f0ef5c01e34fc1e1486678410d885: Bug 1572256 - Clear virtual cursor position when focus clear action is invoked. r=geckoview-reviewers,Jamie,snorp
Eitan Isaacson <eitan@monotonous.org> - Fri, 09 Aug 2019 00:07:21 +0000 - rev 487329
Push 113869 by ncsoregi@mozilla.com at Sat, 10 Aug 2019 21:42:30 +0000
Bug 1572256 - Clear virtual cursor position when focus clear action is invoked. r=geckoview-reviewers,Jamie,snorp Differential Revision: https://phabricator.services.mozilla.com/D41114
d5c7213d35064722ae719b6640a742d46a261456: Bug 1551344 - Part 1: Remove XULDocument code. r=smaug,Jamie
Brendan Dahl <bdahl@mozilla.com> - Fri, 09 Aug 2019 19:57:50 +0000 - rev 487298
Push 113869 by ncsoregi@mozilla.com at Sat, 10 Aug 2019 21:42:30 +0000
Bug 1551344 - Part 1: Remove XULDocument code. r=smaug,Jamie All .xul files have been loading as HTMLDocuments for a few weeks now, so it should be safe to remove the XULDocument implementation. Differential Revision: https://phabricator.services.mozilla.com/D41238
44677a227173f811473b8bc3079cd92566f88e97: Bug 1572519 - Log all element attributes in accessibility logging. r=Jamie
Eitan Isaacson <eitan@monotonous.org> - Fri, 09 Aug 2019 00:02:51 +0000 - rev 487290
Push 113869 by ncsoregi@mozilla.com at Sat, 10 Aug 2019 21:42:30 +0000
Bug 1572519 - Log all element attributes in accessibility logging. r=Jamie Differential Revision: https://phabricator.services.mozilla.com/D41265
97923749f8eb623318d4e71bba3bd5cdec34972c: Bug 1571616 - Prune or reinsert accessibles in non-accessible container. r=Jamie
Eitan Isaacson <eitan@monotonous.org> - Thu, 08 Aug 2019 16:47:14 +0000 - rev 487012
Push 113859 by rmaries@mozilla.com at Fri, 09 Aug 2019 03:53:37 +0000
Bug 1571616 - Prune or reinsert accessibles in non-accessible container. r=Jamie We need to visit the descendants of a container that has no accessible, but has accessible children. Also added a test for delayed removal where we can put all these nasty cases. Differential Revision: https://phabricator.services.mozilla.com/D41059
36592e14f6cefa6e4fc32386f76d9f2558892922: Bug 1568361: Use StaticLocalAutoPtr for BackgroundMTAData; r=Jamie
Aaron Klotz <aklotz@mozilla.com> - Wed, 07 Aug 2019 01:48:31 +0000 - rev 486649
Push 113849 by aciure@mozilla.com at Wed, 07 Aug 2019 04:39:23 +0000
Bug 1568361: Use StaticLocalAutoPtr for BackgroundMTAData; r=Jamie The new StaticLocalAutoPtr smart pointer has a trivial destructor, so we will either properly clean up this data or leak it on process shutdown. Either way, we will not destroy it in a way that the underlying type does not support. Differential Revision: https://phabricator.services.mozilla.com/D40842
3b0f047710050088034bb83143f31478d99a516f: Bug 1568361: Use StaticLocalAutoPtr for BackgrundMTAData; r=Jamie
Aaron Klotz <aklotz@mozilla.com> - Tue, 06 Aug 2019 23:56:21 +0000 - rev 486640
Push 113849 by aciure@mozilla.com at Wed, 07 Aug 2019 04:39:23 +0000
Bug 1568361: Use StaticLocalAutoPtr for BackgrundMTAData; r=Jamie The new StaticLocalAutoPtr smart pointer has a trivial destructor, so we will either properly clean up this data or leak it on process shutdown. Either way, we will not destroy it in a way that the underlying type does not support. Differential Revision: https://phabricator.services.mozilla.com/D40842
0b0758d7768c226d1b460a69a03d9a4668b8a7c4: Bug 1571507 - Fix tree/test_invalidationlist.html. r=Jamie
Eitan Isaacson <eitan@monotonous.org> - Tue, 06 Aug 2019 00:05:44 +0000 - rev 486468
Push 113840 by dluca@mozilla.com at Tue, 06 Aug 2019 09:43:33 +0000
Bug 1571507 - Fix tree/test_invalidationlist.html. r=Jamie The current test doesn't actually do anything because divs with IDs are always created. Differential Revision: https://phabricator.services.mozilla.com/D40674
06d909e0de088e8dd586b4b4be6da83114c93148: Bug 686400 - Delay accessible removal on frame reconstruction. r=Jamie,emilio
Eitan Isaacson <eitan@monotonous.org> - Fri, 02 Aug 2019 22:13:28 +0000 - rev 486063
Push 113827 by btara@mozilla.com at Sat, 03 Aug 2019 09:54:50 +0000
Bug 686400 - Delay accessible removal on frame reconstruction. r=Jamie,emilio We naively remove and then recreate accessibles when their content's frame is reconstructed. By delaying the removal until we are certain the content does not have a new layout frame, we can cut down on redundant recreations. When reconstructed content is re-inserted we can check it and its subtree for missing frames and prune those accessibles from the tree. Differential Revision: https://phabricator.services.mozilla.com/D38380
9c430a684fe03d185f8f21d3ad23960d9e943c4a: Bug 686400 - Filter content insertions in DocAccessible. r=Jamie
Eitan Isaacson <eitan@monotonous.org> - Thu, 01 Aug 2019 16:19:15 +0000 - rev 485810
Push 113820 by rmaries@mozilla.com at Fri, 02 Aug 2019 04:17:07 +0000
Bug 686400 - Filter content insertions in DocAccessible. r=Jamie It seems a bit more sensible to me that if any filtering needs to happen from content insertions, it should happen in the doc and not the notification controller. Differential Revision: https://phabricator.services.mozilla.com/D40132
749582be170c17f818106756bef92b8890515b94: Bug 686400 - Add function to nsCoreUtils for display: contents. r=Jamie
Eitan Isaacson <eitan@monotonous.org> - Thu, 01 Aug 2019 16:19:06 +0000 - rev 485809
Push 113820 by rmaries@mozilla.com at Fri, 02 Aug 2019 04:17:07 +0000
Bug 686400 - Add function to nsCoreUtils for display: contents. r=Jamie Differential Revision: https://phabricator.services.mozilla.com/D40131
327832d4b0354261824d1d25317b124ee2ef851b: Bug 1552716 - Part 1: Fix the keyboard navigation of the tracking protection icon. r=Jamie
Tim Huang <tihuang@mozilla.com> - Tue, 30 Jul 2019 06:31:58 +0000 - rev 485294
Push 113803 by dvarga@mozilla.com at Wed, 31 Jul 2019 00:31:34 +0000
Bug 1552716 - Part 1: Fix the keyboard navigation of the tracking protection icon. r=Jamie This patch fixes the issue that the keyboard navigation doesn't work for the tracking protection icon. Differential Revision: https://phabricator.services.mozilla.com/D39329
45b9bfbc709b1fc2e4d9fb68ba47bd766238b97f: Bug 1552716 - Part 1: Fix the keyboard navigation of the tracking protection icon. r=Jamie
Tim Huang <tihuang@mozilla.com> - Fri, 26 Jul 2019 04:02:03 +0000 - rev 485122
Push 113797 by ccoroiu@mozilla.com at Mon, 29 Jul 2019 21:45:35 +0000
Bug 1552716 - Part 1: Fix the keyboard navigation of the tracking protection icon. r=Jamie This patch fixes the issue that the keyboard navigation doesn't work for the tracking protection icon. Differential Revision: https://phabricator.services.mozilla.com/D39329
43322f9d1f3382b69fed2e34f118ad3fd4320dda: Bug 1568360 - Don't calculate the accessible names for table or grid rows unless they have an explicit ARIA role, r=Jamie
Marco Zehe <mzehe@mozilla.com> - Fri, 26 Jul 2019 09:14:55 +0000 - rev 484840
Push 113783 by shindli@mozilla.com at Fri, 26 Jul 2019 16:31:06 +0000
Bug 1568360 - Don't calculate the accessible names for table or grid rows unless they have an explicit ARIA role, r=Jamie Previously, we would always calculate the name for tr elements from their descendants unconditionally. Assistive technologies aren't using this information, moreover, it causes problems if the name gets too long, for example in layout tables. We now only calculate the name if the tr element has an explicit ARIA role. Differential Revision: https://phabricator.services.mozilla.com/D39314
fac0f2d6482207007677573668304d69d07be6b9: Bug 1568728 - Properly map thead to grouping if it is custom style, r=Jamie
Marco Zehe <mzehe@mozilla.com> - Fri, 26 Jul 2019 01:00:52 +0000 - rev 484789
Push 113782 by shindli@mozilla.com at Fri, 26 Jul 2019 09:48:26 +0000
Bug 1568728 - Properly map thead to grouping if it is custom style, r=Jamie This was an oversight in the checkin for bug 1461244. tfoot was duplicated due to a copy and paste error, thead was not mapped at all. It is now properly mapped, and the test adjusted accordingly. Differential Revision: https://phabricator.services.mozilla.com/D39305
af667e4c7419a4cd397ea7e7cd46c6b6fa201cbe: Bug 1566321 - Make meatball menu keyboard navigation match WAI-ARIA authoring practices. r=Jamie,jaws
Tim Nguyen <ntim.bugs@gmail.com> - Thu, 25 Jul 2019 19:36:13 +0000 - rev 484751
Push 113781 by csabou@mozilla.com at Fri, 26 Jul 2019 03:47:00 +0000
Bug 1566321 - Make meatball menu keyboard navigation match WAI-ARIA authoring practices. r=Jamie,jaws Differential Revision: https://phabricator.services.mozilla.com/D39246
2a77d3e78e0b757d676797a1dc71707146418dcb: Bug 1548389 - part 6: Add automated tests for new API and rendering of password fields r=m_kato,Jamie
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 22 Jul 2019 03:55:13 +0000 - rev 483661
Push 113742 by ccoroiu@mozilla.com at Mon, 22 Jul 2019 10:08:17 +0000
Bug 1548389 - part 6: Add automated tests for new API and rendering of password fields r=m_kato,Jamie Differential Revision: https://phabricator.services.mozilla.com/D38010
daf3f25dd398e6925dc00d064600528a2bc75a00: Bug 1566955: Make EnsureMTA fully thread-safe; r=Jamie
Aaron Klotz <aklotz@mozilla.com> - Thu, 18 Jul 2019 00:48:41 +0000 - rev 483258
Push 113709 by csabou@mozilla.com at Thu, 18 Jul 2019 09:58:26 +0000
Bug 1566955: Make EnsureMTA fully thread-safe; r=Jamie Until now we asserted that EnsureMTA was being called from the main thread unless the current thread was already in the MTA. This patch makes MTA thread initialization thread-safe by using a C++11 "magic static," thus allowing EnsureMTA to be safely invoked from any thread. Differential Revision: https://phabricator.services.mozilla.com/D38422